[13:08:54] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 2 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (vas) @Ammarpad Thank you! It works now. [13:15:10] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (KHaggard) @Eileenmcnaughton I think we definitely would benefit from alphabe... [14:02:08] Wikimedia-Fundraising-Banners: RML Options not available on Ja banners - https://phabricator.wikimedia.org/T255893 (Pcoombe) Enabled with this change: https://meta.wikimedia.org/w/index.php?title=MediaWiki:FundraisingBanners/LocalizeJS-2017.js&diff=prev&oldid=20203821 It seems like we're missing a translati... [15:11:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, phan-taint-check-plugin: CI Phan check blocking CentralNotice patches - https://phabricator.wikimedia.org/T255822 (sbassett) [16:08:51] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 2 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (vas) Hi Jon, I didn't find existing `sitesupport` message, so I have used a new one. Please review my patch again. [16:29:08] (PS6) Jgleeson: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) [16:30:12] (CR) jerkins-bot: [V: -1] Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [16:39:21] (PS7) Jgleeson: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) [16:40:07] (CR) jerkins-bot: [V: -1] Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [16:50:12] (PS8) Jgleeson: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) [16:51:24] (CR) jerkins-bot: [V: -1] Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [16:53:43] (CR) Jgleeson: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [17:01:01] (PS9) Jgleeson: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) [17:03:48] tzag fr-tech [17:04:05] hi mepps! [17:04:52] how goes it ejegg? [17:06:05] hi mepps ejegg [17:06:33] hi cstone! [17:10:20] (PS11) Mepps: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [17:10:32] (CR) Mepps: [C: +2] Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [17:24:33] (Merged) jenkins-bot: Add object caching for API for employer data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/606016 (https://phabricator.wikimedia.org/T255593) (owner: AndyRussG) [17:27:43] fr-tech was there a task for the contribution tracking fail mail created from duplicate donations? I kind of remember it being mentioned before but I cant find a task [17:29:07] PROBLEM - Host frpm2001 is DOWN: PING CRITICAL - Packet loss = 100% [17:29:51] cstone: I think so, yeah [17:30:41] fr-tech cstone mepps ejegg also hellloooo btw ;) [17:31:08] mepps it's going ok, how about you? [17:31:13] and hi cstone and AndyRussG ! [17:31:41] :) [17:32:09] RECOVERY - Host frpm2001 is UP: PING OK - Packet loss = 0%, RTA = 36.32 ms [17:35:51] cstone is that issue biting us more just now? [17:36:16] AndyRussG: we didn't have any warnings about it before [17:37:05] there are probably a bunch of different reasons that it could happen [17:37:17] just a couple happened over the wekeend, mailing some failmail [17:37:21] so an investigation task might make sense [17:37:21] making* [17:40:09] so this is unrelated? https://phabricator.wikimedia.org/T253602 [17:41:58] yeah its a bit different from that one, the same tracking id is getting 2 donations associated with it AndyRussG [17:43:49] cstone: right I remember talking about that at least, I thought there was a task, but I don't see one now, also looked thru my browser history [17:50:07] fr-tech dstrine I thought this one was in review? https://phabricator.wikimedia.org/T254809 [18:04:05] Fundraising-Backlog: Duplicate donations with the same contribution tracking id - https://phabricator.wikimedia.org/T256037 (Cstone) [18:13:08] AndyRussG: I had a few issues getting it through on CI but it's there now :) [18:17:06] I'm gonna add a follow-on patch to that which adds in a new employer_name field. That isn't in the task description but it was requested on a call with the email folks. I guess I'll update the task description to include that. [18:37:44] AndyRussG are you reviewing jgleeson's patch? [18:38:33] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (mepps) @Ejegg @Eileenmcnaughton what are next steps on this task? [18:40:40] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Ejegg) @Jgreen or @Dwisehaupt were either of you able to sort out the connection between this box and frqueue1001? Once that's working we can... [18:42:45] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Jgreen) >>! In T254940#6245890, @Ejegg wrote: > @Jgreen or @Dwisehaupt were either of you able to sort out the connection between this box and... [18:43:33] fr-tech shall we test that new box then? [18:43:47] turning of the queue consumers on the main one and running them from the upgraded version? [18:44:14] hmmm [18:44:29] *off [18:44:44] so testing with real queue messages that end up in the real end destination ? [18:45:03] yep, it's connected to the main db [18:45:20] just the civi codebase is running on a box with a new OS [18:46:02] we tried testing a couple weeks ago in a late tech talk [18:46:17] but there was a network issue so we couldn't test the consumers [18:47:51] hard one to answer. my instinct is no as it sounds dangerous maybe? but you might be more confident in what we can do if stuff goes wrong [18:48:04] Fundraising-Backlog: Recurring Adyen amex IPNs not ignored - https://phabricator.wikimedia.org/T255303 (Cstone) Some more examples: Contribution tracking ids: 79778998 79786318 80468936 80476424 80476369 [18:48:14] assuming you're planning to drip feed single donations ejegg ? [18:48:34] yep, that's the idea [18:48:51] I could be convinced of testing one donation in a controlled fashion :) [18:49:43] ejegg: do we do any maxmind/follow-on api calls that we need to confirm work from that box? [18:50:06] hmm I guess most of that happens at the front [18:53:33] thinking it through the only potential gotchas I can think of would be network related and if something doesn't work for whatever reason the clean up is pretty straightforward, we just fix it and run it again [18:53:45] ejegg: ^ [18:54:19] we'd presumably lose some prometheus stats [18:54:31] unless they're being collected on the new box also [18:54:48] Jeff_Green: dwisehaupt any ideas? [18:55:14] stats should be collected in both locations. i'll verify that. [18:55:21] awesome [18:59:14] yeah. everything looks good for stat collection. it should clear. [18:59:27] thanks dwisehaupt [18:59:43] hmmm what else can wrong? [19:00:17] only thing i notice that might be an issue is that process_control is not enable on civi2001, but i think that is right and since we will hand run things it should be aok. [19:03:01] dwisehaupt: would the logs for the new box be available on frlog? [19:04:21] are outbound emails configured also so we get any failmail if triggered? [19:04:41] we got failmail from the first test [19:04:49] thats good, thanks cstone [19:05:02] dwisehaupt: actually it is there [19:05:03] the logs will be on frlog2001. [19:05:16] process_control that is [19:05:34] we copied over a version of the job configs to a civi2001 directory [19:05:41] just with the schedule lines commented out [19:05:42] ejegg: yeah, it is there, just not 'enabled' according to puppet. [19:06:04] oh hmm, what does puppet enablement mean? [19:06:34] iirc, if it is not set to enabled, it will comment out all lines for all jobs. [19:06:35] the scripts themselves would be run via crontabs that are generated at the end of the deploy / rsync command [19:06:49] ohh, cool, nice to have that puppet safeguard too [19:06:49] let me find a better description. [19:07:20] (PS4) Mepps: Add modified date to the silverpop_export_staging table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/605816 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [19:07:22] (CR) Mepps: [C: +2] Add modified date to the silverpop_export_staging table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/605816 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [19:08:46] (Merged) jenkins-bot: Add modified date to the silverpop_export_staging table. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/605816 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [19:09:56] Fundraising-Backlog: Add lockdown to vagrant fundraising role - https://phabricator.wikimedia.org/T255713 (mepps) Open→Declined This is not needed. [19:12:41] Fundraising-Backlog: Fr-tech engineers need a schedule for chores list - https://phabricator.wikimedia.org/T250735 (mepps) Open→Resolved a:mepps We will be assigning chores at sprint planning. [19:13:46] Fundraising-Backlog: Investigation: Civicrm has two end of year summary links - https://phabricator.wikimedia.org/T255799 (mepps) Open→Resolved a:mepps [19:15:24] yeah. so the enabled/disabled bit in puppet gets propagated to the process-control.yaml config file. if it is set to disabled, then when process_control generates the cron files. it will comment out all jobs so that they won't run. [19:16:07] the generation is done by cron-generate which i believe is called by the deploy process. [19:23:37] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (DStrine) a:Eileenmcnaughton [19:36:33] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 2 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Ammarpad) >>! In T219793#6245060, @vas wrote: > Hi Jon, > > I didn't find existing `sitesupport` message, > so I have used a new one. You'll not see it becau... [19:59:09] (PS4) Eileen: Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) [19:59:11] (PS1) Eileen: WIP address query [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607101 [19:59:57] (CR) jerkins-bot: [V: -1] WIP address query [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607101 (owner: Eileen) [20:00:19] (CR) jerkins-bot: [V: -1] Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [20:00:38] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, phan-taint-check-plugin: CI Phan check blocking CentralNotice patches - https://phabricator.wikimedia.org/T255822 (DStrine) [20:04:59] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: civi crm db approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [20:09:09] (CR) Eileen: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [20:12:17] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: civi crm db approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [20:18:32] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: civi crm db approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [20:33:58] (PS5) Eileen: Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) [20:34:38] (CR) jerkins-bot: [V: -1] Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [20:39:08] (PS6) Eileen: Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) [20:39:52] (CR) jerkins-bot: [V: -1] Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [20:42:36] fr-tech, looks like this one made it to my drive also without being shared https://drive.google.com/file/d/1xRuxJiYXa7MGFl25CdflJZIFFMhiDsCm/view?usp=sharing [20:44:36] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) It sounds like the outcome for this task would be a basic roadmap and plan for the upgrade. Some of the answers to these questions depend on how much we do before the... [20:53:15] (PS7) Eileen: Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) [20:57:39] (PS1) Eileen: Specify column_name for prospect.charitable_contributions_decile [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607114 [20:59:21] jgleeson: I have the split queries out to separate files back to unconflicted [20:59:59] also this patch - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/607114/ - this is how we can align dev column_names with live - to the extent we want [21:01:56] eileen: so it was a table name that was different for me [21:02:35] yeah - probably I had already renamed locally - I little further up in that file we define the table & we could specify table_name there [21:02:45] (obviously only affects new builds) [21:03:32] got it [21:08:38] (PS2) Eileen: Specify column_name for prospect.charitable_contributions_decile, occupation, party [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607114 [21:09:28] jgleeson: so is it better to merge this first - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/606059/ & then make your change - I think that was your thought [21:10:00] eileen: yeah that probably makes more sense [21:10:42] I've only skimmed through the files so far lemme see if it's something quick to +2 [21:10:52] if not I'll review it tomorrow and rebase my stuff over it [21:12:00] looks straightforward enough [21:17:51] (CR) Jgleeson: [C: +2] "Nice work. Tested locally and working as previous. Nose tests also passing locally on vagrant." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:18:29] cool - that should make it easier to read [21:18:43] (Merged) jenkins-bot: Separate out code to build staging schema create [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606059 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:21:02] (PS1) Jgleeson: Add employer_name field to full export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607122 (https://phabricator.wikimedia.org/T254809) [21:21:11] (CR) jerkins-bot: [V: -1] Add employer_name field to full export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607122 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [21:21:47] eileen: yup. I've just pushed up my additional 'employer_name' field so I'll rebase that and the earlier one first thing [21:22:26] cool - I'm just looking at extra fields in general but we should prob get yours merged next [21:23:16] hmmm for the SQL casing tidy up it might be best if I apply that to your split out SQL first [21:24:55] (PS2) Jgleeson: Add employer_name field to full export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607122 (https://phabricator.wikimedia.org/T254809) [21:25:04] (CR) jerkins-bot: [V: -1] Add employer_name field to full export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607122 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [21:29:14] oh that's disappointing, the SQL beautifier removes the inline SQL comments like this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/606059/7/silverpop_export/rebuild_schema.sql@21 [21:31:10] I guess in that case we might preserve the unusual structure in favour of preserving the documentation in the form of comments in the current structure [21:31:30] as losing all those comments would make things harder to work with [21:31:44] ok I'll scrap that idea for now [21:31:49] AndyRussG: ^ fyi [21:32:35] jgleeson: thx! [21:34:57] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Patch-For-Review: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (jgleeson) [21:39:04] AndyRussG: looks like Special:HideBanners is NOT called from anything in the CN frontend [21:42:33] ejegg: no, it is [21:42:35] from hide.j [21:42:38] hide.js [21:42:53] in resources/ext.centralNotice.display [21:43:05] setHideCookies() [21:43:25] see also NoticeHideUrls in wmf-config/CommonSettings.php [21:46:16] ahh shoot, wgNoticeHideUrls [21:46:23] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (Eileenmcnaughton) @KHaggard my understanding is that re-ordering at our end... [21:46:24] I was just searching for the special page name [21:46:27] hmph [21:46:44] so that's just to get the hide cookies for other domains [21:47:34] maybe? maybe check banner code to see for sure how it works? [21:47:49] it looks like we're setting the local domain's hide cookie right in JS [21:48:12] sorry just a bit distracted by cooking (kids are still here) I'll be more fully available in 1 hr [21:49:15] eileen is there a non-deprecated way to set CiviCRM settings which are inside a group? [21:49:44] CRM_Core_BAO_Setting::setItem is deprecated [21:49:47] Fundraising-Backlog, fundraising-tech-ops: Upgrade mariaDB on frdb1003 to >= 10.2 - https://phabricator.wikimedia.org/T255066 (Dwisehaupt) Upgrade to buster has completed. MariaDB now running 10.4.13. Verified normal behavior through superset and mysql command line. [21:50:16] but the Civi::settings()->set() call [21:50:22] doesn't let me specify a group [21:51:00] are settings groups just deprecated? [22:29:06] ejegg: yep [22:29:31] ejegg: question about silverpop limit on adding new fields [22:29:54] my understanding is we are restructuring before adding them because we are somewhere near our limit [22:30:39] & I'm wondering which of the 2 limits is more immediate [22:30:39] 1) the time it takes to generate the file or [22:30:39] 2) the issues around the size of the file (upload, import) [22:41:03] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (Eileenmcnaughton) [22:41:20] ejegg: asking in the context of ^^ [22:59:39] (PS1) Ejegg: Normalize values returned from SSBInfo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607141 (https://phabricator.wikimedia.org/T249924) [23:00:45] (PS5) Ejegg: WIP new api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) [23:06:21] eileen those two both contribute to the same delays [23:06:56] so we just had to push the start time back a half hour [23:06:57] ejegg: so it's just the total time to get the file created that is the main issue? [23:07:06] yep, total time to create and upload [23:07:18] (CR) jerkins-bot: [V: -1] WIP new api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [23:07:46] ok - & what is the impact of the main table & excluded being sequential? [23:07:48] eileen ok, so my settings should all just have the matching_gifts_ prefix rather than be in the ["Matching Gifts"] group [23:07:55] yep [23:08:14] We generally still add group - but possibly only due to copy & paste [23:08:23] being sequential? like generating one then the other? [23:08:30] ejegg: if you want to expose in the UI use settings_page key [23:08:41] yep sequential in that way [23:09:05] the excluded job really just needs to happen after [23:09:10] so they're sequential now because we need to know who we're exporting to subtract them from the list of all addresses [23:09:28] yep yep [23:11:25] ejegg: right - but they are currently a bit intertwined - I think per [23:11:25] https://phabricator.wikimedia.org/T256073 we can separate them [23:12:56] sure, if they're fine doing two separate imports [23:13:03] Fundraising-Backlog, fundraising-tech-ops: Upgrade mariaDB on frdb1003 to >= 10.2 - https://phabricator.wikimedia.org/T255066 (Dwisehaupt) Open→Resolved [23:13:52] (PS1) Eileen: Move suppression list generation queries to separate file. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607145 (https://phabricator.wikimedia.org/T256073) [23:14:45] (CR) jerkins-bot: [V: -1] Move suppression list generation queries to separate file. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607145 (https://phabricator.wikimedia.org/T256073) (owner: Eileen) [23:21:58] ejegg: hey back from cooking and eating land, back at the keyboard now (in case you want to discuss the hide cookie more...) [23:24:28] oh sure AndyRussG, I think this line sets the local cookie: https://phabricator.wikimedia.org/diffusion/ECNO/browse/wmf_deploy/resources/ext.centralNotice.display/hide.js$116 [23:25:40] so I guess when all the browsers stop accepting 3rd party pixelcookies we can delete the following chunk looping over wgNoticeHideUrls [23:26:01] (PS2) Eileen: Move suppression list generation queries to separate file. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607145 (https://phabricator.wikimedia.org/T256073) [23:26:44] err, wait, I guess if we want to change the special page, we would just get rid of that chunk now [23:27:59] ejegg: hmmm I guess [23:28:17] So the redirect would only be from thank u page? [23:28:27] As far as I can tell, yeah [23:29:00] Do you think we should maintain the existing pixel render for compatibility for a while? [23:29:11] As long as there are some browsers that it still works with? [23:33:06] ejegg: that's a good idea actually yeah [23:33:27] we could always use a different special page, or alternately have a url param that determines redirect vs pixel [23:33:41] trying to remember where setHideCookies() is caled from [23:33:44] *called [23:34:00] man I really wish there were a better way of doing this [23:37:02] ejegg: ah right the setHideCookies() is called also for banner closes [23:39:03] ejegg: in hide.js setHideWithCloseButtonCookies() [23:39:10] yep yep [23:39:17] so actually that won't can't do any redirecting [23:39:46] won't can't doesn't want to and wouldn't even if it could [23:40:01] If we want to maintain back-compat, a new special page sounds cleaner [23:40:21] so we're not adding extra params that later will have no meaning [23:41:57] ejegg: k yeah sounds right for sure [23:42:39] oh, wait, we are adding a new param for the redirect anyway [23:42:57] Fundraising-Backlog, Wikimedia-Fundraising-Banners: iDEAL logo not ideally located - https://phabricator.wikimedia.org/T256078 (jbolorinos-ctr) [23:43:08] so that would be a totally logical way to determine how to act [23:46:05] ? from ty page= [23:46:07] ? [23:46:48] or to that page? [23:47:39] to the TY page [23:48:27] we will redirect straight from payments-wiki's result page to the CN hideBanners page, with a ?redirect=donatewiki/ty_page [23:48:28] ejegg: as in for the redirect, it needs info about what params to include when redirecting, no? [23:48:35] yep yep [23:48:40] ok cool beans [23:48:41] so if a ?redirect exists [23:49:02] we validate it against the list of OK places to redirect [23:49:04] and do that [23:49:12] otherwise render the pixel [23:52:28] Fundraising-Backlog, Wikimedia-Fundraising-Banners: iDEAL logo not ideally located - https://phabricator.wikimedia.org/T256078 (jbolorinos-ctr) p:Triage→Low [23:52:49] ejegg: yeah that sounds fine... so a new config variable also needed for allowlist for redirects [23:53:14] yep [23:54:17] Wikimedia-Fundraising-Banners: [Candidate] NL Banners (Duplicate of Asana task) - https://phabricator.wikimedia.org/T255833 (jbolorinos-ctr) Links to screenshot tests pasted below - Desktop Large: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zbac597da6ce21fa98c7... [23:54:59] Wikimedia-Fundraising-Banners: [Candidate] NL Banners (Duplicate of Asana task) - https://phabricator.wikimedia.org/T255833 (jbolorinos-ctr) p:Triage→High [23:56:23] (PS1) AndyRussG: Suppress DoubleEscaped phan warning in CentralNoticePageLogPager [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607149 (https://phabricator.wikimedia.org/T255822) [23:58:57] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (CCogdill_WMF) Jumping in since Katie is having a busy week. I want to add a response to y...