[00:05:46] (CR) jerkins-bot: [V: -1] Suppress DoubleEscaped phan warning in CentralNoticePageLogPager [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607149 (https://phabricator.wikimedia.org/T255822) (owner: AndyRussG) [00:08:24] (PS2) AndyRussG: Suppress DoubleEscaped phan warning in CentralNoticePageLogPager [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607149 (https://phabricator.wikimedia.org/T255822) [00:10:41] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (Eileenmcnaughton) @CCogdill_WMF thanks for this - that simplifies it - it sounds like th... [00:11:48] (CR) jerkins-bot: [V: -1] Suppress DoubleEscaped phan warning in CentralNoticePageLogPager [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607149 (https://phabricator.wikimedia.org/T255822) (owner: AndyRussG) [00:14:23] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (CCogdill_WMF) Makes sense! [00:15:37] (PS3) AndyRussG: Suppress DoubleEscaped phan warning in CentralNoticePageLogPager [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607149 (https://phabricator.wikimedia.org/T255822) [00:17:12] Wikimedia-Fundraising-Banners: RML Options not available on Ja banners - https://phabricator.wikimedia.org/T255893 (jbolorinos-ctr) p:Triage→Medium [00:21:28] Wikimedia-Fundraising-Banners: Missing translation text for avg donation on donation form - https://phabricator.wikimedia.org/T255895 (jbolorinos-ctr) [00:21:30] Wikimedia-Fundraising-Banners: QA Desktop Lg - https://phabricator.wikimedia.org/T255894 (jbolorinos-ctr) [00:21:32] Wikimedia-Fundraising-Banners: Early QA: Japan Banners - https://phabricator.wikimedia.org/T255813 (jbolorinos-ctr) [00:22:16] Wikimedia-Fundraising-Banners: QA Desktop Lg - https://phabricator.wikimedia.org/T255894 (jbolorinos-ctr) Open→Invalid [00:22:16] fr-tech ejegg anyone got a +2 to spare? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/607149 [00:22:36] For the CI CN issue [00:22:39] Wikimedia-Fundraising-Banners: QA Desktop Lg - https://phabricator.wikimedia.org/T255894 (jbolorinos-ctr) Closed as invalid, since there is no need to separate out subtasks for each banner type [00:22:43] looking AndyRussG [00:23:14] ah yeah, they keep tightening up the static analysis rules [00:25:06] so htmlspecialchars inside of xml::tags is the suggested behavior? [00:28:19] ejegg: security folks commented on the task, their recommendation is a change in how core handles stuff [00:28:34] ah, sorry, lemme get wise to the context [00:29:03] ejegg: basically it seems like a false positive, and they suggested suppressing it [00:29:59] also no worries :) [00:31:00] wow, phan knows which db spots have tainted vals [00:31:01] nice [00:31:07] or, usually knows [00:31:44] smart enough to tell us we're wrong but not smart enough to understand when it's wrong [00:32:02] (CR) Ejegg: [C: +2] Suppress DoubleEscaped phan warning in CentralNoticePageLogPager [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607149 (https://phabricator.wikimedia.org/T255822) (owner: AndyRussG) [00:34:09] ejegg: thanks much!! [00:37:45] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/607154 [00:39:07] (PS2) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/607154 [00:45:45] (CR) AndyRussG: [C: +2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/607154 (owner: AndyRussG) [00:46:30] ejegg: what I didn't understand from Phan is why it gave the same error twice for what was essentially a single line of code [00:46:44] but I did try it with just suppression or the other, and it didn't pass [00:48:50] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/607154 (owner: AndyRussG) [01:01:30] once for that content being inside of Xml::tag and once for that content being inside of htmlspecialchars? [01:48:47] (PS1) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [01:49:27] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [01:49:37] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (Eileenmcnaughton) [01:51:37] (PS2) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [01:52:17] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [01:56:03] (PS3) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [01:56:53] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) That last patch drops out about 50 mins from the job [01:57:05] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [02:14:10] (PS4) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [02:14:51] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [03:41:00] (PS5) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [03:41:42] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [04:07:30] (PS6) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [04:08:09] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [04:10:25] (PS7) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [04:11:07] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [04:14:49] (PS8) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [04:15:30] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [04:17:37] (PS9) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [04:18:19] (CR) jerkins-bot: [V: -1] Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [04:50:30] (PS1) Eileen: Try to update unit tests [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607166 [04:51:10] (CR) jerkins-bot: [V: -1] Try to update unit tests [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607166 (owner: Eileen) [04:52:12] (PS2) Eileen: Try to update unit tests [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607166 [04:52:51] (CR) jerkins-bot: [V: -1] Try to update unit tests [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607166 (owner: Eileen) [05:01:13] PROBLEM - check_procs on fran1001 is CRITICAL: PROCS CRITICAL: 1014 processes [05:05:42] ACKNOWLEDGEMENT - check_procs on fran1001 is CRITICAL: PROCS CRITICAL: 1014 processes Dwisehaupt Known [05:25:43] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (Eileenmcnaughton) I'm a bit stuck on this - I can't understand why this isn't passing - h... [05:53:01] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add job to protect us against contacts with duplicate primary addresses - https://phabricator.wikimedia.org/T256096 (Eileenmcnaughton) [05:53:49] (Abandoned) Eileen: [WIP] Limit the email update [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606026 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [06:05:45] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) [06:56:13] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/607193 (owner: L10n-bot) [07:03:00] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/607193 (owner: L10n-bot) [07:03:12] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) [07:03:35] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) I'm thinking the goal will be to build a staging table - in th... [07:58:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (Eileenmcnaughton) Of the list these are all cases where they were added to the suppression list but not updated due to their opt out flags. This is by desig... [11:11:12] RECOVERY - check_procs on fran1001 is OK: PROCS OK: 428 processes [13:16:23] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (KHaggard) That spreadsheet looks good to me. Confirming that "prospect_" ref... [13:59:04] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: civicrm database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [13:59:47] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: civicrm database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [14:01:04] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [14:03:57] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [14:11:50] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [14:21:26] tzag fr-tech [14:32:18] hi mepps [14:32:26] hey cstone, how are you? [14:32:55] good just about to head out on the lake, how about you? [14:34:16] also good, i got to go swimming this morning :) [14:35:24] nice! :) [14:46:39] (PS7) Ejegg: Filter matching gift policies on type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605340 (https://phabricator.wikimedia.org/T249924) [14:46:41] (PS4) Ejegg: Matching gifts fetcher factory, beef up interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605637 (https://phabricator.wikimedia.org/T249924) [14:46:43] (PS2) Ejegg: Normalize values returned from SSBInfo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607141 (https://phabricator.wikimedia.org/T249924) [14:46:45] (PS6) Ejegg: WIP new api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) [14:49:03] hi ejegg! [14:53:22] (CR) jerkins-bot: [V: -1] WIP new api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [15:00:29] hi mepps and cstone [15:00:30] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (Jgreen) [15:00:53] how's it going ejegg? [15:01:57] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (Ejegg) Moving fredge would make it pretty hard to do some of the antifraud reporting. T... [15:16:20] (PS8) Ejegg: Filter matching gift policies on type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605340 (https://phabricator.wikimedia.org/T249924) [15:25:00] (PS5) Ejegg: Matching gifts fetcher factory, beef up interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605637 (https://phabricator.wikimedia.org/T249924) [15:25:02] (PS3) Ejegg: Normalize values returned from SSBInfo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607141 (https://phabricator.wikimedia.org/T249924) [15:25:27] fr-tech i notice that just before sprint planning our backlog got bloated! [15:37:42] mepps it's going pretty well. Still got that dumb synchronizer class with a bunch of static methods but am getting closer to working [15:38:51] that's cool ejegg [15:39:00] i'm trying to look at eileen's failing test [15:43:30] oh hmm, that normalize patch should also normalize the search results [15:49:40] ooh i got the failure locally! [15:52:34] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (Jgreen) [15:52:44] (PS4) Ejegg: Normalize values returned from SSBInfo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607141 (https://phabricator.wikimedia.org/T249924) [15:55:03] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (Jgreen) [16:02:44] (CR) Mepps: "locally, I'm getting formerperson1@localhost instead of the expected optionzero@localhost. it looks like formerperson1 is left over from t" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [16:16:28] huh, I guess I'm confused about the settings groups being deprecated [16:18:06] looks like in the settings.php file you still need to group them [16:22:03] and I guess the suggested way to namespace is with a '.' [16:22:57] mepps: I remember you asking about error logs last week was SSL_do_handshake() failed one of them? [16:23:07] maybe last sprint is better term [16:23:51] yeah cstone i think so and i think dwisehaupt looked into them.. [16:23:59] ok i thought i remembered that [16:24:08] cstone I think those are ancient browsers [16:24:15] that don't support modern TLS [16:24:36] ahh i see there was just a lot in the error log hadnt seen that many before [16:24:37] and we had to turn off old SSL since it's cryptographically too weak [16:24:42] oh hmm [16:24:49] maybe due to the India campaign? [16:25:04] Wouldn't be surprised if there were a lot of older browsers there [16:25:12] theres also some safari weirdness but my safari is probably an ancient browser haha trying to figure that out [16:25:15] hmm yeah [16:38:50] hi fr-tech :) [16:38:58] hi AndyRussG [16:38:59] hey AndyRussG fr-tech :) [16:38:59] ! [16:39:03] hi jgleeson ! [16:39:06] hi AndyRussG jgleeson [16:39:09] :) [16:39:15] cstone: they also happen when a nessus scan is initiated. you can ignore any of those lines coming from frnetmon1001's ip. [16:39:27] fr-tech should I try to deploy DI to put the caching patch out? [16:39:35] sure AndyRussG ! [16:39:40] thanks dwisehaupt [16:39:50] sounds good AndyRussG [16:40:02] we can then hit the API just to see that all is working as expected [16:40:18] okok will do! I may ping here with questions... [16:40:57] whoa, Mozilla is no longer funding Thunderbird? [16:41:13] all ur email belongs to webmail providers? [16:41:26] (CR) Mepps: "The test failure is because the logdate is set to "none" for optinzero in the failing tests." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [16:41:57] nice sleuthing mepps [16:43:27] ok, now to do another round of PSes to change the settings formats [16:43:30] :P [16:49:09] ejegg: wat? no way! (wrt thunderbird) [16:50:24] ejegg: you mean this? https://blog.thunderbird.net/2020/01/thunderbirds-new-home/ [16:50:36] i would say alpine still runsgood, but i know that google is phasing out anything that can't do oath2 over the next year or so. [16:51:07] so for me it'll either be a shift to something else or some crazy shims. to get it to work. [17:15:36] Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.35 - https://phabricator.wikimedia.org/T254298 (Jgreen) The codfw payments servers have been upgraded to Buster with stock php 7.3.14, and are in the standard payments deploy group so they're getting the same code/config as eqiad.... [17:26:07] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: upgrade payments servers to Debian Buster - https://phabricator.wikimedia.org/T256146 (Jgreen) [17:27:11] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: upgrade payments servers to Debian Buster - https://phabricator.wikimedia.org/T256146 (Jgreen) [17:27:24] Fundraising-Backlog, fundraising-tech-ops, fr-tech-ops-okr: Upgrade payments servers to Debian Buster - https://phabricator.wikimedia.org/T256146 (Jgreen) [17:30:38] (PS9) Ejegg: Filter matching gift policies on type [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605340 (https://phabricator.wikimedia.org/T249924) [17:36:48] mepps do you know a quick fix for Error: Class 'Civi\Api4\Action\Afform\Submit' not found in afform_civicrm_config() [17:36:51] ? [17:37:19] getting that whenever I try to call my new API3 things with drush cvapi [17:37:37] and can't see why it would need that [17:43:34] fr-tech I see the following commits in DI master ready to merge into the deploy branch: [17:43:38] 48748f64 Add object caching for API for employer data [17:43:40] f7fffc96 Change to not read mode to allow access from form [17:43:42] a2575440 Merge "Extract boolean method to check for updated ct data" [17:43:44] b0150320 Doc and default value for $wgDonationInterfaceEmployersListDataFileLocation [17:43:46] 74a785d7 Merge "Allow lowercase letters in India PAN" [17:43:48] 82e1c7af Allow lowercase letters in India PAN [17:43:50] a635c9aa Extract boolean method to check for updated ct data [17:43:52] so I guess ok to deploy all of those? [17:45:00] (hmmm forgot to ignore merge commits) [17:48:56] fr-tech also I see no tests in the deployment branch of DI... how do I stop those from merging in? [17:52:41] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (DStrine) >>! In T251914#6246394, @mepps wrote: > It sounds like the outcome for this task would be a basic roadmap and plan for the upgrade. Some of the answers to these ques... [17:53:01] I guess just amend the merge commit to remove them before sending to Gerrit? [17:57:03] AndyRussG: Yep, that's how you do it. [17:57:16] XenoRyet: okok cool beans, thanks! [17:58:38] also, I don't see any composer.lock changes, but there is a composer.json change. Just a CI script added [17:58:53] php tests/phpunit/LintYaml.php [17:59:17] in scripts/test of composer.json [18:01:54] AndyRussG: oh, that shouldn't be in composer.json on the deployment branch [18:02:06] since that script is gone there [18:02:43] mepps ok, my civicrm submodule needed an update and a db update, so now I'm past that error [18:03:56] ejegg: it's just in the master branch. Should I remove that change from the deployment branch merge too? [18:04:32] odd that it would be in the merge - that line has been there forever [18:04:51] but yeah, you'll have to keep it out of the merge for tests to pass on the deployment branch [18:08:55] fr-tech, I made this for dinner today and it was so good I think it's worth sharing. I think the sausage could be substituted for vegetarian ones easy enough for folks who don't eat meat. The kids liked it too! https://www.hellofresh.co.uk/recipes/sausage-traybake-5bc71b0530006c77547bc842?week=2020-W24 [18:16:12] jgleeson: yom! [18:17:01] yeah roasted apple! worked a treat [18:17:05] :) [18:17:47] (CR) Mepps: "okay if I add log_date I can see optinzero in there but formerperson1 is also in there screwing up the results. Was there supposed to be a" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [18:18:58] (CR) Mepps: "ah this is probably because we're not dropping and recreating the table anymore" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [18:20:42] fr-tech hmmm it seems that automagically the merge didn't include the tests directory or the composer.json change [18:20:57] (PS1) AndyRussG: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/607328 [18:23:28] AndyRussG: yep no tests on the deployment branch [18:23:33] (PS1) Mepps: This got tests passing locally [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607329 [18:23:44] Fundraising-Backlog, fundraising-tech-ops: Configure payments2xxx for MediaWiki 1.35 upgrade testing - https://phabricator.wikimedia.org/T256153 (Jgreen) [18:26:25] fr-tech so I know I could self-merge, but maybe someone would like to peek at the merge commit just in case? [18:26:26] wow, all those translations fr-tech! [18:26:32] ^ [18:26:34] looking now AndyRussG [18:26:47] that is amazing [18:27:30] jgleeson: thanks! In Gerrit is says a thing about a test file being deleted, but I think that's just 'cause I had to do that manually to make it merge [18:27:46] The actual diff between the previous merge to deployment branch and this one seems fine [18:28:02] (See git difftool -d ca2400baa085..deployment) [18:29:16] oh AndyRussG I don't see anything on the patch about a deleted file [18:30:08] I know it's normal for us to get the conflict when we add tests tho and remove them when merging into development [18:30:17] due to the tests dir being deleted on deployment [18:31:11] jgleeson: right... I only got the conflict for one test file, did git rm on it and git commit to finish the merge [18:31:30] jgleeson: also, the file deletion only shows up in Gerrit if you use the new Gerrit UI... go figure [18:31:41] hah AndyRussG I was just going to ask that [18:31:46] about the new UI [18:31:56] oh interesting [18:31:58] lemme check that out [18:32:07] it's more than just a new UI [18:32:08] but it doesnt nicely list all the changes in the new UI [18:32:15] also yep [18:32:21] oh yeah I see it now [18:32:36] I'm pretty sure I've seen this issue before, oh well [18:32:58] jgleeson: cstone: so should I +2 the merge and deploy? [18:33:19] looks good to me! [18:34:07] jgleeson: whee thanks! [18:34:27] (CR) AndyRussG: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/607328 (owner: AndyRussG) [18:35:27] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/607328 (owner: AndyRussG) [18:35:52] fr-tech so the deploy is just gonna go like this: [18:36:06] fundraising_code_update -p DonationInterface [18:36:20] rsync_blaster ALL:DonationInterface [18:36:31] oh hey AndyRussG it's actually paymentswiki [18:36:32] Then log the update [18:36:34] or payments [18:37:01] I forget the project name, maybe if you do f_c_u.. -h or -i [18:37:09] or will show you the list of available projects to deploy [18:37:14] payments-wiki? [18:37:15] s/or/it [18:37:22] that might be it cstone ! [18:37:33] jgleeson: there's a payments-wiki project, yes [18:37:43] but there's also a DonationInterface project there [18:37:46] do you still have to do the submodule update (I havent deployed DI in a while) [18:38:02] yep cstone [18:39:50] yea, project name is payments-wiki, and you do still have to do the submodule update. [18:40:14] AndyRussG: so I'm not sure about the DonationInterface standalone project. I've never deployed that. I wonder if it's a wrapper for multiple deployments of DI or maybe is being wrapped by by the payments-wiki deploy.. but I do know we typically deploy payments-wiki [18:40:34] when pushing out updates made to any of the payments-wiki submodules/extensions [18:41:08] fr-tech so how do I do the submodule update? I don't see it in the doc on collab [18:41:12] https://collab.wikimedia.org/wiki/Fundraising/Engineering#Deploy_Fundraising_Code [18:41:23] Or at least, I don't see details [18:41:25] and like cstone and XenoRyet said we also need to update the extensions/DonationInterface to your new version of deployment [18:42:08] AndyRussG: you can probably just move up a direction and do a git diff [18:42:22] and you'll the submodule hash has changed to your latest on deploy [18:42:25] fr-tech oh I see, so the procedure is to do an update to the payments mediawiki DI submodule and eploy that [18:42:35] that also goes through Gerrit I guess? [18:42:38] you can then add that and push up the submodule bump [18:42:46] to gerrit [18:42:48] yep [18:43:01] you'll see* [18:43:15] fr-tech there's also a change in the vendor submodule there [18:44:07] Mw should be on fundraising/REL1_31? [18:44:13] yep [18:47:26] AndyRussG: we typically update the vendor submodule when one of the packages we use (e.g. smashpig) is updated [18:47:39] I don't think we've updated any vendor packages this time tho? [18:47:58] oh actually I don't think we even do that anymore [18:48:07] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (mepps) @Eileenmcnaughton I added a patch that gets the tests working. I figure we'll squa... [18:56:05] jgleeson: seems that was just due to me not having updated that submodule properly [18:56:13] jgleeson: fr-tech: however now I have a different issue [18:56:38] Instead of showing a submodule update, it says this: [18:56:40] Changes not staged for commit: [18:56:42] (use "git add ..." to update what will be committed) [18:56:44] (use "git restore ..." to discard changes in working directory) [18:56:46] modified: extensions/DonationInterface (new commits) [18:56:48] when I say git status [18:57:09] that looks right I think [18:57:18] does git diff just show the commit hash change? [18:57:21] or the submodule [18:57:23] of* [18:57:53] jgleeson: ahh right yes it's fine [18:57:59] I should have been doing git diff [18:58:00] awesome [18:58:07] not git status [19:01:03] brb [19:04:02] Fundraising-Backlog: [High Priority] Missing link "unsubscribe" links in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) [19:04:39] (PS1) AndyRussG: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 [19:05:24] fr-tech I think this is ok then? https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/607348/ [19:06:05] (CR) AndyRussG: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 (owner: AndyRussG) [19:06:10] Looks normal to me. [19:06:17] XenoRyet: thanks!!! [19:06:25] I guess it'll run tests [19:06:39] Is there still time to deploy it before planning meet? [19:08:13] We've got around 20 mins, yea? That should be fine. It's quick to roll things back if something asplodes [19:08:34] XenoRyet: yay cool thx :) [19:12:19] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 (owner: AndyRussG) [19:13:44] fr-tech hmmm test failure here https://integration.wikimedia.org/ci/job/mwgate-composer-php70-docker/4463/console [19:14:09] seems like the relevant line is "The process "'/usr/bin/php7.0' -d allow_url_fopen='1' -d disable_functions='' -d memory_limit='-1' '/usr/bin/composer' phpcs" exceeded the timeout of 300 seconds. " [19:14:43] maybe a recheck AndyRussG? [19:15:00] That'd be my first guess as well [19:15:08] (CR) AndyRussG: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 (owner: AndyRussG) [19:15:21] yeah just did that :) [19:15:34] Dunno how that works once it already was +2'ed I guess we'll see what Gerrit sez [19:16:35] K it's trying again... [19:20:13] Fundraising-Backlog: [High Priority] Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) [19:20:34] (CR) Mepps: "Are there tests for the matching gifts code?" (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [19:25:15] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 (owner: AndyRussG) [19:25:27] hey mepps, no there's no tests for the new table being exported. I did look at the existing tests and it doesn't look like we test anything to do with the csv output. I guess I could add a test to confirm the new employer_name field is present in the main update view but it probably wouldn't give us much value [19:26:48] well poop [19:27:15] same symphony component timeout [19:27:45] AndyRussG: it looks like phpcs is taking longer than expected [19:28:29] jgleeson: yeah I wonder how we increase that timeout? [19:30:19] hmm [19:32:39] Fundraising-Backlog: [High Priority] Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (DStrine) @TSkaff if this is from an email from the email team, we can't change this. @CCogdill_WMF I'm not sure who all would need to see this. [19:33:31] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (DStrine) [19:37:17] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (CCogdill_WMF) Which email was this from? I read the title of this task and thought it was referring to a Civi TY email. [19:39:08] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) @DStrine My understanding is that the issue is from some of the auto-generated emails from Civi (not ones that the email team can edit). Such as the new Automated Recurring Resta... [19:39:58] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (DStrine) Tsk [19:41:45] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (DStrine) a:DStrine→None [19:43:04] (CR) Eileen: This got tests passing locally (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607329 (owner: Mepps) [19:46:53] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (Eileenmcnaughton) @KHaggard that's quite far out - I thought you wanted the... [19:48:10] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) @dstrine **I checked and don't spot any issues with the following** - Standard TY email - Recurring TY email - Endowment TY email **But I don't know how to send myself te... [19:49:22] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) @krobinson says "Just FYI the link is not clickable across the board. I did some searches of replies (we have only had a handful) but the unsub link is just text." [19:51:17] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (CCogdill_WMF) Can she provide a sample Zendesk ticket? It should be easy enough to tell what type of email this is. [19:53:04] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) @CCogdill_WMF Kristine cited this one: #760801, but Kristie seemed to have found it elsewhere, I'm just not sure where, so I'm looking around. [20:02:08] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) [20:02:15] Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) Example: Ref CiviRecen_US 582401 [20:04:34] (PS3) Eileen: Move suppression list generation queries to separate file. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607145 (https://phabricator.wikimedia.org/T256073) [20:04:36] (PS10) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [20:09:51] (CR) Eileen: "mepps - it passed! with your fix" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [20:11:42] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, phan-taint-check-plugin, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23): CI Phan check blocking CentralNotice patches - https://phabricator.wikimedia.org/T255822 (DStrine) Open→Resolved [20:12:07] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, FR-Civi-Dedupe: Civi: manual dedupe is slow - https://phabricator.wikimedia.org/T254815 (DStrine) Open→Resolved [20:12:36] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (... [20:14:11] Fundraising-Backlog: EPIC: Enable the ability for user to pay with iDeal through Adyen - https://phabricator.wikimedia.org/T231370 (DStrine) [20:14:13] Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, FR-Adyen: Update Adyen IPN processing for non-card txns - https://phabricator.wikimedia.org/T241859 (DStrine) Open→Resolved [20:15:05] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Payments should only send new contribution tracking messages if something changes - https://phabricator.wikimedia.org/T253602 (DSt... [20:15:38] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Frontend - Make employer field autocomplete which integr... - https://phabricator.wikimedia.org/T251200 [20:15:40] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create employer autocomplete for payments-wiki - https://phabricator.wikimedia.org/T249921 (DStrine) [20:16:06] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create employer autocomplete for payments-wiki - https://phabricator.wikimedia.org/T249921 (DStrine) [20:16:08] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 4 others: Backend - Create MW API to expose employer data - https://phabricator.wikimedia.org/T251199 (DStr... [20:18:26] Fundraising-Backlog: Recurring Smashpig Extension Email error - https://phabricator.wikimedia.org/T256176 (Cstone) [20:19:45] (CR) AndyRussG: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 (owner: AndyRussG) [20:19:55] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: large quantity of bounce messages in the civimail "ignored" bucket - https://phabricator.wikimedia.org/T254513 (DStrine) Open→Resolved [20:21:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add job to protect us against contacts with duplicate primary addresses - https://phabricator.wikimedia.org/T256096 (DStrine) [20:21:53] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (KHaggard) You're right! Apologies, I was trying to work around the email sen... [20:21:59] Fundraising-Backlog: Investigate missing CiviCRM bounce handling for one cid - https://phabricator.wikimedia.org/T256177 (mepps) [20:22:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop export: move the suppression list to a different job - https://phabricator.wikimedia.org/T256073 (DStrine) [20:24:11] Fundraising-Backlog: Investigate missing CiviCRM bounce handling for one cid - https://phabricator.wikimedia.org/T256177 (mepps) Use alpine. [20:25:05] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Ejegg) [20:25:56] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 (owner: AndyRussG) [20:31:58] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog: Flowchart all incoming data from non fundraising sources - https://phabricator.wikimedia.org/T254783 (DStrine) [20:38:05] Fundraising-Backlog: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (DStrine) [20:46:30] Fundraising-Backlog, fundraising-tech-ops: Configure payments2xxx for MediaWiki 1.35 upgrade testing - https://phabricator.wikimedia.org/T256153 (Jgreen) [20:48:00] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create employer autocomplete for payments-wiki - https://phabricator.wikimedia.org/T249921 (DStrine) Open→Resolved [20:48:02] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (DStrine) [20:50:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Matching gifts should not update contribution_tracking to point to new contribution - https://phabricator.wikimedia.org/T254487 (DStrine) Open→Resolved [20:51:48] Fundraising-Backlog, fundraising-tech-ops: Configure payments2xxx for MediaWiki 1.35 upgrade testing - https://phabricator.wikimedia.org/T256153 (Jgreen) @Ejegg ok we're set to use the payments-staging frdeploy project for this, we just need to set it to the right branch and make the config changes for 1... [20:52:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: TS update import back into Civi - https://phabricator.wikimedia.org/T255805 (Eileenmcnaughton) What I normally do is test doing a UI import to the target smart import mapping & check it's OK (e.g 200 rows) & get Leanne to check. Then I upload & use... [20:54:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Localizable messages with spaces in the name cause fatal exception - should fail gracefully - https://phabricator.wikimedia.org/T58105 (Krinkle) Open→Resolved [20:55:29] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (DStrine) [20:55:31] Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: TS update import back into Civi - https://phabricator.wikimedia.org/T255805 (DStrine) [20:55:33] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog: Close filehandle in MW API code - https://phabricator.wikimedia.org/T255593 (DStrine) [20:55:35] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23): Employer autocomplete showing readonly error in production - https://phabricator.wikimedia.org/T255478 (DStrine) [20:55:37] Fundraising Sprint M 2020, Fundraising-Backlog: Rebellious colon displaying within ingenico iframe - https://phabricator.wikimedia.org/T255477 (DStrine) [20:55:39] Fundraising Sprint Lazy Loading Life, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (Eileenmcnaughton) @KHaggard maybe we should remove the 2 fields that I've re... [20:55:41] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Prepare CN deploy 2020-06 - https://phabricator.wikimedia.org/T255476 (DStrine) [20:55:43] Fundraising Sprint M 2020, Fundraising-Backlog: Japanese MC 2nd Upsell Email - https://phabricator.wikimedia.org/T255227 (DStrine) [20:55:45] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23): Add PHP object caching to MW employer data API - https://phabricator.wikimedia.org/T255170 (DStrine) [20:55:49] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, FR-dlocal, and 2 others: Make PAN field default to upper case - https://phabricator.wikimedia.org/T255171 (DStrine) [20:55:52] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix new recurrings to be created with a Pending status - https://phabricator.wikimedia.org/T254941 (DStrine) [20:55:54] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (DStrine) [20:55:56] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog: Fr-tech engineer should take on chores this sprint - https://phabricator.wikimedia.org/T254938 (DStrine) [20:55:58] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog: Flowchart all incoming data from non fundraising sources - https://phabricator.wikimedia.org/T254783 (DStrine) [20:56:00] Fundraising Sprint M 2020, Fundraising-Backlog: Japanese TY Email - https://phabricator.wikimedia.org/T254052 (DStrine) [20:56:02] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Patch-For-Review: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (DStrine) [20:56:04] Fundraising Sprint M 2020, Fundraising-Backlog: Removing asterisks in payment page card number field - https://phabricator.wikimedia.org/T254032 (DStrine) [20:56:06] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (DStrine) [20:56:08] Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, and 3 others: CentralNotice: Deploy new regional geotargeting and banner template features - https://phabricator.wikimedia.org/T252596 (DStrine) [20:56:11] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Add and delete fields from the _all_Wikimedia database (civi export to ESP) - https://phabricator.wikimedia.org/T252245 (DStrine) [20:56:13] Fundraising Sprint M 2020, Fundraising-Backlog, fundraising Sprint Grep works IRL, MediaWiki-extensions-CentralNotice: Implement redirect for hide banner cookie issue - https://phabricator.wikimedia.org/T251780 (DStrine) [20:56:16] Fundraising Sprint Kavascript: the chill new language, Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, and 2 others: Civi: annual summary email - add tax deductibility language - https://phabricator.wikimedia.org/T242001 (DStrine) [20:56:18] Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create CiviCRM API to export data for employer autocomplete - https://phabricator.wikimedia.org/T250328 (DStrine) [20:56:20] Fundraising Sprint M 2020, Fundraising-Backlog: Create job to update/generate employer dataset for usage within paymentswiki - https://phabricator.wikimedia.org/T251201 (DStrine) [20:56:22] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising Sprint Just space out, Fundraising Sprint Kavascript: the chill new language, and 5 others: Make Civi matching gifts extension store data in custom ... - https://phabricator.wikimedia.org/T249924 [20:56:26] Fundraising-Backlog: Check on old Ingenico to new Ingenico test recurrings - https://phabricator.wikimedia.org/T256181 (Cstone) [20:57:23] Fundraising Sprint M 2020, Fundraising-Backlog: Check on old Ingenico to new Ingenico test recurrings - https://phabricator.wikimedia.org/T256181 (DStrine) [20:58:44] Fundraising Sprint M 2020, Fundraising-Backlog, fundraising Sprint Grep works IRL, MediaWiki-extensions-CentralNotice: Implement redirect for hide banner cookie issue - https://phabricator.wikimedia.org/T251780 (DStrine) p:Triage→Lowest [20:59:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (DStrine) p:High→Medium [20:59:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (DStrine) p:High→Medium [21:00:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (DStrine) @MNoorWMF @CCogdill_WMF we looked into this and we are not using the urls that are scheduled to change. It doesn't seem like we need to do this before the Ju... [21:17:44] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (DStrine) @CDenes_WMF , @jbolorinos-ctr @spatton @EMartin This is really just one little space and it seems to be an issue with this cur... [21:25:26] dwisehaupt: I'm doing some more query testing... [21:25:43] sounds good. [21:26:11] i'm pretty sure jeff adjusted some timeout/retry settings also so we'll see if those made a difference. [21:26:18] nice! [21:28:29] (CR) AndyRussG: [V: +2 C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607348 (owner: AndyRussG) [21:39:03] (Abandoned) Jgleeson: Add employer_name field to full export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607122 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [21:40:26] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog: Fr-tech engineer should take on chores this sprint - https://phabricator.wikimedia.org/T254938 (Cstone) a:Cstone→None [21:41:15] fr-tech so after force-merging the submodule update patch, I'll deploy payments-wiki, sound good? [21:41:37] yep! [21:41:42] oops [21:41:46] yay thanks! [21:43:13] K so first step: fundraising_code_update -p payments-wiki [21:43:24] yep [21:44:50] ejegg: it also wants to update localsettings [21:44:57] yep, that's ok [21:45:09] the repo has updates, but none of them are payments-wiki-relevant [21:46:57] ejegg: should I care about what they are? they're going out in any case, no? [21:47:21] nope, your deploy will only send out the ones connected to payments-wiki [21:47:51] ejegg: so what is the code update script talking about or doing with them then? [21:48:01] it's updating I guess the code on the staging server? [21:48:02] the f_c_u step updates the staged copy of localsettings, then copies the payments-wiki subdir of localsettings into the staging copy of payments-wiki [21:48:29] then your rsync_blaster command will just rsync the staging copy of payments-wiki [21:48:32] (PS10) Jgleeson: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) [21:48:34] (PS1) Jgleeson: Add employer_name field to full export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607366 (https://phabricator.wikimedia.org/T254809) [21:48:35] ejegg: ok so those other changes won't actually get deployed until someone explicitly deploys them, correct? [21:48:45] right AndyRussG [21:48:45] and people will get re-informed about them when that happens? [21:49:02] yep [21:50:26] ok cool, so, doing the thing then [21:50:46] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Dwisehaupt) frdb1003 upgraded to buster in the process of completing T255066 [21:52:43] fr-tech for those reviewing the silverpop matching gifts export stuff, I just rebased it over eileen's new way to rebuilding the schema so if you happened to have checked it out locally to look at the code maybe pull down the latest [21:53:49] ejegg fr-tech hmmmm /srv/www-staging/org/wikimedia/payments is not at the right revision [21:54:12] is that a bug or not supposed to be updated or am I looking in the wrong place? [21:54:21] this is on frpm1001 [21:56:12] The message from f_c_u says it's updating the DI submodule to the correct sha [22:00:50] hmm AndyRussG is that path on the srv the place we rsync out from? [22:02:18] jgleeson: that's what I don't know [22:03:49] AndyRussG: looks like that checkout hasn't been updated since may 2019 [22:04:26] I can see in vivafredge that payments-wiki is on the right hash [22:04:43] I'd say it's ready to launch! [22:05:32] AndyRussG: ahhh looks like the actual local that gets pushed out is /srv/www/org/wikimedia/payments [22:05:39] and that hash is the one we want [22:05:49] actual location* [22:06:32] `rsync_blaster -i` shows the src/dst paths on the box [22:07:59] ahhh ok cool thanks! [22:08:03] and since we're gonna be running `rsync_blaster ALL:payments-wiki` to push it out you can see the src/dst for that project is the one we want [22:09:13] jgleeson: okok gotcha [22:09:18] fr-tech deploying to payments wiki now [22:11:12] jgleeson: does a log message like this seem right? Updated pyaments-wiki 5fd4eb1519 --> 28ad76dcd7 [22:13:39] !log updated payments-wiki from 5fd4eb1519 to 28ad76dcd7 [22:13:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:14:12] yep AndyRussG ! [22:15:59] AndyRussG: it's erroring as expected! https://payments.wikimedia.org/api.php?action=employerSearch&employer=a&format=json :) [22:16:36] adding the employer variant will load the new frontend code - [22:16:37] https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&ffname=cc-vmaj&recurring=false&utm_source=fr-redir.default~default~default~default~control.cc&utm_medium=spontaneous&utm_campaign=spontaneous&utm_key=vw_1861.vh_569.otherAmt_0.time_5&referrer=&language=en&country=GB&payment_method=cc&payment_submethod=&gateway=ingenico&variant=&amountGiven=&frequency=onetim [22:16:39] e&amount=2&opt_in=0¤cy=GBP&variant=employer [22:16:41] shoot [22:17:24] the error handling on the frontend is doing as expected also [22:18:02] oh hey I just noticed the error includes the word vagrant [22:18:34] jgleeson: yeah I was trying to test it [22:19:12] didn't we set the default to something like /usr/share [22:19:44] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Dwisehaupt) [22:20:12] jgleeson: I changed the default [22:20:18] got it [22:20:18] so yeah that is correct [22:20:34] dunno why the URL I was trying didn't work, but yours did! [22:20:42] yay! Thanks much!!! [22:22:15] nice work! [22:22:20] have a good evening all [22:22:58] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (EMartin) Not a blocker from my POV [22:27:32] Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: TS update import back into Civi - https://phabricator.wikimedia.org/T255805 (LeanneS) @Eileenmcnaughton I just added the amended file to the server here: Tech/Major Gifts/TargetSmart Update/2020 Update/Amended contacts/Jun... [22:30:47] (PS1) Eileen: Only add activity if send works [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607376 (https://phabricator.wikimedia.org/T256176) [22:35:09] !log disabled fundraising jobs on civi1001 for testing on civi2001 [22:35:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:55:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add utm_medium to failed recur email - https://phabricator.wikimedia.org/T256184 (Reedy) [23:10:44] (PS1) Ejegg: Fix template info comment for TY mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607381 [23:20:03] Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: adjust fr-log-announcer to use IRC more securely - https://phabricator.wikimedia.org/T122104 (Dwisehaupt) [23:37:20] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Ejegg) @Jgreen and @Dwisehaupt we can't test audit processing - the /var/spool/audit folder and its subfolders... [23:53:24] oh hey, I need to turn those jobs back on! [23:54:14] eileen: can you give this a quick +2? https://gerrit.wikimedia.org/r/607381 [23:58:23] (CR) Eileen: [C: +2] Fix template info comment for TY mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607381 (owner: Ejegg) [23:58:27] done [23:58:41] thanks! [23:59:04] I'll just deploy that before I turn the queues & ty messages back on on the main civi box