[00:00:32] (CR) jerkins-bot: [V: -1] Fix template info comment for TY mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607381 (owner: Ejegg) [00:00:39] boo [00:01:26] (CR) Ejegg: [V: +2] Fix template info comment for TY mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607381 (owner: Ejegg) [00:01:34] overruled! [00:01:47] :-) [00:03:57] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/607384 [00:04:01] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/607384 (owner: Ejegg) [00:14:38] (CR) Eileen: [C: +2] "I tested this & it works & all makes sense. I have been trying to move more towards logical separation & might yet move some to a separate" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [00:15:34] (Merged) jenkins-bot: Add in matching gift table to export and include employer_id alongisde contact row fields. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/606463 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [00:33:05] !log updated Fundraising CiviCRM from f01b036128 to 52a32f2d66 [00:33:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:35:55] !log restarted fundraising jobs on main CiviCRM box [00:35:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:36:05] (CR) Eileen: [C: +2] "Per code level comment I think we should drop the commented join as it is not needed as the information is in the table." (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607366 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [00:36:28] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Dwisehaupt) I have pulled the audit directory structure of civi1001 from frlog2001 and put it into /srv/archive... [00:36:48] (Merged) jenkins-bot: Add employer_name field to full export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607366 (https://phabricator.wikimedia.org/T254809) (owner: Jgleeson) [00:36:57] ejegg that failmail looks related [00:37:13] to your testinng? [00:40:39] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Dwisehaupt) @Ejegg Looking a little more at the size differences, it appears there is a significant amount of d... [00:43:03] the fredgewrite issue seems odd. [00:43:35] (PS1) Eileen: Silverpop employer_name, slight simplification on the query [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607391 (https://phabricator.wikimedia.org/T254809) [00:44:21] oh. i think i may see what happened. [00:45:34] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Patch-For-Review: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (Eileenmcnaughton) @jgleeson I merged yours but added a follow up patch here https://gerrit.wikimedia.org/r/#/... [00:46:46] ok. just updated the fredgewrite user. the mapping for the eqiad dc got reset so plumbed that back in. [00:48:10] (PS4) Eileen: Move suppression list generation queries to separate file. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607145 (https://phabricator.wikimedia.org/T256073) [00:48:12] (PS11) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [00:48:47] would have caught that a bit earlier but was headsdown getting the audit files in place for testing. [00:49:52] eileen dwisehaupt oops, just saw the failmails now [00:50:03] looks like it's fixed though? [00:50:12] should be. [00:50:22] and you have shiny audit data to test when you have time. :) [00:50:30] oh nice! [00:51:12] ejegg|away: are you able to + 2 this - should be a no-brainer https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/607114/ [00:51:53] ok. i need to step away and stop ignoring the family. i'll stay logged in and am pingable via sms/slack if something else is amiss. [00:56:18] (PS12) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [01:01:26] eileen: that trailing _175 on the occupation column is on purpose? [01:01:49] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (CDenes_WMF) Based off citation above, spacing looks correct for INR (i.e. ₹ 1,234.56). Not a blocker. thanks! [01:34:20] (CR) Ejegg: [C: +1] "Just one question about a trailing id" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607114 (owner: Eileen) [01:34:50] (CR) Eileen: Specify column_name for prospect.charitable_contributions_decile, occupation, party (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607114 (owner: Eileen) [01:35:41] ejegg|away: yep - as .... live [01:40:41] (CR) Ejegg: [C: +2] Specify column_name for prospect.charitable_contributions_decile, occupation, party [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607114 (owner: Eileen) [01:47:19] (Merged) jenkins-bot: Specify column_name for prospect.charitable_contributions_decile, occupation, party [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607114 (owner: Eileen) [04:22:24] (PS1) Eileen: Silverpop export: refactor calculation of address and preferred_language [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607401 [04:32:38] (PS2) Eileen: Silverpop export: refactor calculation of address and preferred_language [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607401 [05:01:13] PROBLEM - check_procs on fran1001 is CRITICAL: PROCS CRITICAL: 1018 processes [05:03:07] ACKNOWLEDGEMENT - check_procs on fran1001 is CRITICAL: PROCS CRITICAL: 1018 processes Dwisehaupt Known [05:32:39] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog: Close filehandle in MW API code - https://phabricator.wikimedia.org/T255593 (AndyRussG) Open→Resolved [05:32:41] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (AndyRussG) [05:34:01] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23): Add PHP object caching to MW employer data API - https://phabricator.wikimedia.org/T255170 (AndyRussG) Open→Resolved [05:34:03] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (AndyRussG) [05:45:05] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23): Employer autocomplete showing readonly error in production - https://phabricator.wikimedia.org/T255478 (AndyRussG) Open→Resolved a:AndyRussG [05:45:26] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23): Employer autocomplete showing readonly error in production - https://phabricator.wikimedia.org/T255478 (AndyRussG) a:AndyRussG→mepps [05:51:45] (PS3) AndyRussG: Don't show Admin UI tabs on subscribing wikis [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606371 [05:52:09] (PS2) AndyRussG: Remove unused bannerController RL modules [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/606370 (https://phabricator.wikimedia.org/T224034) [05:52:36] (PS3) AndyRussG: ESLint: Enforce jQuery variable pattern [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603631 (owner: Esanders) [05:53:21] (PS2) AndyRussG: Speed up BannerMessageGroup's getKeys and getDefinitions. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/598470 (https://phabricator.wikimedia.org/T221119) (owner: Nikerabbit) [08:08:38] (CR) Jforrester: [C: +2] "…" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603631 (owner: Esanders) [08:12:32] (Merged) jenkins-bot: ESLint: Enforce jQuery variable pattern [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/603631 (owner: Esanders) [08:42:14] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (krobinson) More examples can be found in #761358 ; #760858 ; and #760710. In each of them the unsubscribe link in the footer is just text, and not clicka... [10:21:04] (PS25) ItSpiderman: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [10:21:06] (PS1) ItSpiderman: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 [10:21:27] (PS2) ItSpiderman: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 [10:26:04] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [10:26:06] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [10:26:09] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [10:54:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add utm_medium to failed recur email - https://phabricator.wikimedia.org/T256184 (Pcoombe) Adding those would only work for a direct donation link. They have no effect on the Ways to Give page. [11:06:16] RECOVERY - check_procs on fran1001 is OK: PROCS OK: 427 processes [12:29:21] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 2 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (vas) Hi Jon, please review my patch again. [13:23:42] Fundraising Sprint M 2020, Fundraising-Backlog: Rebellious colon displaying within ingenico iframe - https://phabricator.wikimedia.org/T255477 (mepps) @jgleeson this is not showing up for me. Is it only after you click donate? Can you confirm you still see it? [13:49:35] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) I've confirmed these are all the newly added failed recurring emails. We'll need to address it in the data strings template for that. [13:50:16] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) a:mepps [14:37:12] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (DStrine) Open→Declined [14:37:14] Wikimedia-Fundraising-Banners: [CANDIDATE] QA India Banners - https://phabricator.wikimedia.org/T254903 (DStrine) [15:04:38] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) I have confirmed that the html message we imported didn't have the unsubscribe link. I just need to confirm how to get that then we'll update the ht... [15:12:53] Fundraising-Backlog: Error: UNKNOWN missing essential contribution tracking ID - https://phabricator.wikimedia.org/T256274 (Cstone) [15:13:24] (PS6) Ejegg: Matching gifts fetcher factory, beef up interface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605637 (https://phabricator.wikimedia.org/T249924) [15:13:26] (PS5) Ejegg: Normalize values returned from SSBInfo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607141 (https://phabricator.wikimedia.org/T249924) [15:13:42] Fundraising Sprint M 2020, Fundraising-Backlog: Check on old Ingenico to new Ingenico test recurrings - https://phabricator.wikimedia.org/T256181 (Cstone) a:Cstone [15:15:11] Fundraising Sprint M 2020, Fundraising-Backlog: Check on old Ingenico to new Ingenico test recurrings - https://phabricator.wikimedia.org/T256181 (Cstone) [15:38:10] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) Right now, I can find the unsub link in the thank_you drupal module and it's generated by a variable. I'm wondering if we ever get it in civi now. [15:52:22] (CR) Jgleeson: [C: +2] "Working good for me. I just wanna confirm that when we import donations that include an employer_id, we write the employer name to the con" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607391 (https://phabricator.wikimedia.org/T254809) (owner: Eileen) [15:53:11] (Merged) jenkins-bot: Silverpop employer_name, slight simplification on the query [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607391 (https://phabricator.wikimedia.org/T254809) (owner: Eileen) [15:53:41] ejegg: do you know off the top of your head whether we populate the contact record organization_name field with the corresponding organizsaton contact organization_name during a donation import? [15:54:02] eileen's comments here suggest we do https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/607391/ [15:54:11] jgleeson really? That's news to me [15:54:25] we should be able to look up some contact records from the benevity import I guess [15:54:42] though that would add an extra step to the ones we'll get from the frontend [15:54:48] with the new form [15:54:51] yeah [15:54:56] that's what I'm worried about [15:55:00] since that will potentially have a subsidiary name [15:55:21] hmm [15:55:45] I kinda feel like not relying on the field on the contact record is the safer approach [15:56:04] that way we just point to the organization_name of the organization contact in all cases [15:56:54] I'll see what the current code does [15:57:04] right, that sounds like the correct approach [15:57:53] (PS1) Jgleeson: Revert "Silverpop employer_name, slight simplification on the query" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607546 [16:02:28] so currently when importing a donation it looks like we create the contact via the civi api and we do pass the employer_id to that call [16:02:58] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) So currently we're not including the unsubscribe link in the civi receipt /civicrm/admin/messageTemplates/add?action=update&id=29&reset=1 I just in... [16:03:22] although I guess the employer record might not exist at that point [16:03:25] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) @Eileenmcnaughton @Ejegg I'm going to pause on this until we talk to make sure I'm approaching it the best way. [16:06:49] ejegg: what's your plans with regards to persisting MG companies to the civi db? are you gonna create an organization contact for each result of the full list available at SSB ? [16:07:54] (PS7) Ejegg: New MatchingGiftPolicies api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) [16:07:55] jgleeson for each of the parent companies [16:08:14] (and that PS7 ^^^ actually manages to do it) [16:08:29] so yeah, there will be a lot of new org contact records [16:08:48] hmm, maybe I should set a contact source [16:09:01] in case people need to filter them out [16:14:14] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (TSkaff) Thanks all! In case I confused anyone, it seems like might just apply to the new "Automated Recurring Restart Email"--I wasn't sure about this myse... [16:15:19] (CR) jerkins-bot: [V: -1] New MatchingGiftPolicies api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [16:15:39] (CR) Jgleeson: "hey @Eileen after thining this through I've pushed a revert of this patch up. Although we get a slight performance benefit here it means w" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607546 (owner: Jgleeson) [16:15:47] thanks ejegg [16:16:34] (CR) Jgleeson: "thinking*" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607546 (owner: Jgleeson) [16:18:40] fr-tech, I'm gonna skip standup today at 5:30pm my time as the break between it and tech-talk won't give me enough time to cook and eat dinner. I'll email my update over shortly before and be back in time for tech-talk. [16:21:00] jgleeson: enjoy ur dinner! thanks also for that recipe btw! [16:21:21] Fundraising Sprint M 2020, Fundraising-Backlog: Rebellious colon displaying within ingenico iframe - https://phabricator.wikimedia.org/T255477 (jgleeson) @mepps it looks like they've fixed it. We can close this task now [16:21:27] Fundraising Sprint M 2020, Fundraising-Backlog: Rebellious colon displaying within ingenico iframe - https://phabricator.wikimedia.org/T255477 (jgleeson) Open→Resolved [16:23:07] Fundraising Sprint M 2020, Fundraising-Backlog: Create job to update/generate employer dataset for usage within paymentswiki - https://phabricator.wikimedia.org/T251201 (jgleeson) a:jgleeson [16:26:13] Fundraising Sprint M 2020, Fundraising-Backlog: Rebellious colon displaying within ingenico iframe - https://phabricator.wikimedia.org/T255477 (mepps) Yay for an easy win! [16:26:35] :) [16:27:06] (CR) Ejegg: [C: +2] Only add activity if send works [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607376 (https://phabricator.wikimedia.org/T256176) (owner: Eileen) [16:27:16] (PS2) Ejegg: Only add activity if send works [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607376 (https://phabricator.wikimedia.org/T256176) (owner: Eileen) [16:27:55] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) Thanks TSkaff! [16:27:57] (CR) Ejegg: [C: +2] "This is nice, but maybe we also want a try/catch around this chunk for situations where the send throws an exception?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607376 (https://phabricator.wikimedia.org/T256176) (owner: Eileen) [16:38:01] (Merged) jenkins-bot: Only add activity if send works [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607376 (https://phabricator.wikimedia.org/T256176) (owner: Eileen) [16:42:57] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Jgreen) IIRC audit processing (or maybe just orphan-slaying?) also uses logs that we push over from the central... [16:52:26] Fundraising Sprint M 2020, Fundraising-Backlog: Japanese TY Email - https://phabricator.wikimedia.org/T254052 (Cstone) a:Cstone [17:02:26] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Jgreen) @Ejegg how significant is it that civi1001:/var/spool/audit vs civi2001:/var/spool/audit are not in syn... [17:08:11] dwisehaupt: I still don't see the /var/spool/audit dir on 2001 [17:10:02] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Ejegg) @Jgreen it would be nicer if they shared that dir, but it might not be too bad. We'll just have to remem... [17:18:02] ejegg: oh yeah. i transferred over the files but forgot the symlinks needed at the end of the process. [17:20:11] (CR) AndyRussG: [C: +2] "Thanks so much, Nikerabbit, for digging into this stuff and finding this, and thanks also Abijeet Patro, DannyS712 and Jforrester for the " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/598470 (https://phabricator.wikimedia.org/T221119) (owner: Nikerabbit) [17:25:55] (PS1) Cstone: Update Japanese thank you email and subject. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607573 [17:32:03] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog: Fr-tech engineer should take on chores this sprint - https://phabricator.wikimedia.org/T254938 (mepps) a:jgleeson @jgleeson I think you said you were taking chores this sprint? [17:32:21] Wikimedia-Fundraising-Banners: Add non-breaking space between ₹ and amount for Indian Rupee - https://phabricator.wikimedia.org/T256288 (spatton) [17:34:58] (Merged) jenkins-bot: Speed up BannerMessageGroup's getKeys and getDefinitions. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/598470 (https://phabricator.wikimedia.org/T221119) (owner: Nikerabbit) [17:40:39] ejegg: i have created the symlinks. [17:48:41] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog: Fr-tech engineer should take on chores this sprint - https://phabricator.wikimedia.org/T254938 (jgleeson) @mepps yup yup [18:12:30] Fundraising Sprint M 2020, Fundraising-Backlog: Create job to update/generate employer dataset for usage within paymentswiki - https://phabricator.wikimedia.org/T251201 (jgleeson) My current thinking on this is for generating the file we can either: # Add a new drupal module command called something lik... [18:21:51] (PS1) Cstone: Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607585 [18:29:24] (CR) jerkins-bot: [V: -1] Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607585 (owner: Cstone) [18:31:37] (CR) Ejegg: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607585 (owner: Cstone) [18:44:01] (CR) Ejegg: [V: +2 C: +2] "Recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/607585 (owner: Cstone) [18:48:11] !log payments-wiki revision changed from 28ad76dcd7 to 91852dbc9b [18:48:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:17:13] Wikimedia-Fundraising-Banners: [Candidate] NL Banners (Duplicate of Asana task) - https://phabricator.wikimedia.org/T255833 (TSkaff) [19:18:13] Wikimedia-Fundraising-Banners: Early QA: Japan Banners - https://phabricator.wikimedia.org/T255813 (TSkaff) [19:18:47] (CR) Eileen: "jgleeson - civi already does that!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607546 (owner: Jgleeson) [19:18:50] Wikimedia-Fundraising-Banners: Early QA: Japan Banners - https://phabricator.wikimedia.org/T255813 (TSkaff) Added he due date from Asana to the description: June 30 [19:23:21] Wikimedia-Fundraising-Banners: [Candidate] NL Banners (Duplicate of Asana task) - https://phabricator.wikimedia.org/T255833 (TSkaff) Added the due date to the description per the Asana task: June 26. (July 7 is the actual pre-test date.) [19:42:35] I'm keen to get this deployed & see how it affects total time if anyone is able to look - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/607156/ [19:42:59] Wikimedia-Fundraising-Banners: Add non-breaking space between ₹ and amount for Indian Rupee - https://phabricator.wikimedia.org/T256288 (jbolorinos-ctr) This is what the formatting looks like on e-commerce sites in India: {F31904209} [19:43:27] I'm gonna do an interim pr to not deploy already-changed-fields for now so we can deploy this...if I can get it reviewed / merged [19:43:45] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Extra spacing between currency symbol and amount on India Astroypay form - https://phabricator.wikimedia.org/T255065 (jbolorinos-ctr) This is what the formatting looks like on other e-commerce sites in India: {F31904212} [20:08:10] OK, i'm going to try making the API call to export Matching gift policy data [20:12:32] ejegg - any chance you or mepps can look at the suppression one today (7.42^^)- i'd love to test the impact... Hmm maybe i'm just being impatient & ext week is fine [20:15:37] interestingly we use country over preferred language when exporting & only preferred language if country doesn't offer a guess [20:16:13] Fundraising-Backlog, FR-Civi-Dedupe: Civi Dedupe: show Last Donated date at top of legacy dedupe screen - https://phabricator.wikimedia.org/T256314 (MBeat33) [20:18:27] Fundraising-Backlog, FR-Tech-Analytics, FR-Email: Automated Email Import to Civi - https://phabricator.wikimedia.org/T256315 (EYener) [20:20:08] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Jgreen) [20:20:10] fundraising-tech-ops, Patch-For-Review: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Jgreen) [20:20:34] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Jgreen) [20:20:36] Fundraising-Backlog, fundraising-tech-ops: test civicrm and peripheral software on Debian Buster - https://phabricator.wikimedia.org/T253159 (Jgreen) [20:20:53] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Test CiviCRM on new box - https://phabricator.wikimedia.org/T254940 (Jgreen) [20:21:34] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) It looks like the acoustic emails are using a more generic link that could be put in the template. [20:23:24] eileen re:suppression, because i added the test updates i'm wondering if i shouldn't be the one to +2 it [20:23:49] I don't that disqualifies [20:24:22] it's the actual change that needs a second pair of eyes [20:29:06] Fundraising-Backlog, FR-Civi-Dedupe: Civi Dedupe: enable Deduper to handle multiple email addresses - https://phabricator.wikimedia.org/T256316 (MBeat33) [20:29:57] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: refactor civi1001 archive_sync jobs to also keep civi1001 and civi2001 audit data in sync - https://phabricator.wikimedia.org/T256317 (Jgreen) [20:30:53] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: refactor civi1001 archive_sync jobs to also keep civi1001 and civi2001 audit data in sync - https://phabricator.wikimedia.org/T256317 (Jgreen) [20:31:14] Fundraising-Backlog, FR-Civi-Dedupe: Civi Dedupe: enable Deduper to handle multiple email addresses - https://phabricator.wikimedia.org/T256316 (MBeat33) @SHust says this use case is the main reason agents go back to the legacy interface, so if we could add this functionality, agents could work exclusive... [20:36:42] fundraising-tech-ops: modify pc_log_archiver to add hostname to the target filename on log rotation - https://phabricator.wikimedia.org/T256318 (Jgreen) [20:44:29] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in auto-generated Civi emails - https://phabricator.wikimedia.org/T256162 (mepps) I can't help but notice we have two unsubscribe links. Also @DStrine there's a little confusion about whether we need to wait for more feedback befo... [20:44:46] Fundraising Sprint M 2020, Fundraising-Backlog: Missing "unsubscribe" link in automatic recurring failure email - https://phabricator.wikimedia.org/T256162 (mepps) [20:52:10] (CR) Mepps: "Given that the log_date field is created in this patch--where does it get updated?" (3 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [20:52:58] eileen just saw this in your commit message: I wrote my analysis in the code comments - please attend to any caffeine needs before proceeding [20:52:58] to review. :) [20:53:05] i'm afraid i caffeinated a whlie ago [20:53:13] lol [20:53:23] it's a lot - I'm just checking [20:53:40] so the log_date is on the log_civicrm_email table & managed by triggers [20:55:05] (CR) Eileen: "log_date is in the tables managed by triggers - fixing the other 2 now" (3 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [20:57:19] (PS13) Eileen: Add to, rather than rebuild the suppression list. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607156 (https://phabricator.wikimedia.org/T253152) [21:15:48] ejegg mepps: I just had a thought - if we switch to master suppression list updates being incremental rather than the whole lot each day - do you think they would want to do a last purge+ replace first? [21:25:23] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) @CCogdill_WMF @KHaggard when I... [21:28:15] eileen probably [21:28:32] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) Sorry I lie - that change is no... [21:28:37] so can they do that all on their own? [21:29:07] ejegg: I just realised it doesn't apply to the current change -because at this stage we would still send the full file, just calculate incrementally [21:29:18] see https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/607156/ [21:29:31] yep yep [21:34:02] (PS3) Eileen: Silverpop export: refactor calculation of address and preferred_language [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607401 [21:34:16] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (KHaggard) Thanks Eileen. I defer to @CCogdill_WMF... [21:35:56] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) @KHaggard we can punt that ques... [21:42:21] Fundraising Sprint M 2020, Fundraising-Backlog: Japanese MC 2nd Upsell Email - https://phabricator.wikimedia.org/T255227 (Cstone) a:Cstone [21:42:42] (PS1) Cstone: Create Japanese recurring notification html and subject templates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607623 [21:47:57] (PS1) Eileen: Add some timings [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607624 [21:51:40] (PS1) Cstone: Add recurring notification template to thank you email test UI. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607626 [21:52:24] (CR) Ejegg: [C: +2] Add recurring notification template to thank you email test UI. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607626 (owner: Cstone) [21:59:50] (Merged) jenkins-bot: Add recurring notification template to thank you email test UI. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607626 (owner: Cstone) [22:02:42] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (KHaggard) If I understand the process correctly,... [22:22:00] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) @KHaggard I tried to ping you... [22:37:31] Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create CiviCRM API to export data for employer autocomplete - https://phabricator.wikimedia.org/T250328 (Ejegg) a:Ejegg [22:38:45] (PS1) Ejegg: Add matching gift employer export [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607633 (https://phabricator.wikimedia.org/T250328) [22:42:51] Fundraising Sprint M 2020, Fundraising-Backlog: Create job to update/generate employer dataset for usage within paymentswiki - https://phabricator.wikimedia.org/T251201 (Ejegg) @jgleeson this commit creates an API call within the new Matching Gifts civi extension: https://gerrit.wikimedia.org/r/607633 o... [22:47:24] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaughton) & just to be clear - I'm talkin... [22:47:52] (CR) jerkins-bot: [V: -1] Add matching gift employer export [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607633 (https://phabricator.wikimedia.org/T250328) (owner: Ejegg) [23:06:23] (PS8) Ejegg: New MatchingGiftPolicies api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) [23:06:25] (PS2) Ejegg: Add matching gift employer export [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607633 (https://phabricator.wikimedia.org/T250328)