[02:53:50] eileen: hi! yt? [02:53:57] AndyRussG: yep [02:54:09] eileen: hey! how's it going? [02:54:18] not bad - are you feeling better? [02:54:30] yeah, thanks! [02:54:41] it was just a cold apparently, seems quite unlikely to have been anything else [02:54:54] a bit of a scare tho [02:55:43] yep - for sure! [02:55:56] hey quick question... there's a line in this patch of Elliott's that I'm reviewing, that he said didn't work... One sec I'll get a link [02:56:11] this is the patch: [02:56:13] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/605638 [02:57:24] this is the line: https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/258ec66008c1086369aa837c8c13a8730f906afa/sites/default/civicrm/extensions/matching-gifts/CRM/MatchingGifts/Upgrader.php#13 [02:57:40] it's meant to add a table when the extension is installed [02:58:04] so it's likely he didn't know how to trigger it [02:58:05] I haven't tried it myself yet, but I thought you might know just by glancing at it what's wrong [02:58:17] ahhh ok how does that go? [02:58:26] So it's a civi api call [02:58:44] there is Extension.update & Extension.upgrade & I can never recall which is which [02:58:45] I have the extension installed locally, btw so to smoke test it I'll also have to uninstall [02:59:09] Do you know how to call civi api using drush? [03:00:06] yes-ish [03:00:29] I'm able to run the api provided by the extension [03:01:32] so I go into the drupal directory and say drush cvapi MatchingGiftPolicies.Sync [03:01:35] and that works [03:03:26] so it's not with the cv tool? [03:03:40] you can call the api from either [03:03:51] cv is a cms-agnostic drush thingee [03:03:57] so it would be [03:04:03] drush cvapi Extension.upgrade [03:04:14] (or update if I'm wrong about which is which [03:04:48] you can also find a link in the status checks screen usually [03:04:53] eileen: well the function is called upgrade_1001 [03:06:10] I guess first to uninstall it, drush civiapi Extension.uninstall ? [03:06:13] status checks page is at http://wmf.local/civicrm/a/#/status on my local [03:06:33] yep - that is right - although it seems better to test the upgrade works? [03:08:31] hmm http://crm.local.wmftest.net:8080/civicrm/#/status just brings me to the civi home in vagrant [03:08:44] well I actually installed the table by running the sql manually [03:08:57] so I should uninstall first [03:09:24] I'll do a vagrant snapshot first [03:13:52] hmmm vagrant snapshot seems to have messed up my vagrant :( [03:21:56] some silly thing about vagrant being stopped and the ports being in use when I try to do vagrant up [03:22:10] maybe due to the system upgrade I just did... just gonna restart my computer, brb! [03:32:54] yay got my vagrant back again! [03:43:29] eileen: well when I said "drush ceui matching-gifts" [03:43:45] I got back "Extension matching-gifts could not be uninstalled." [03:43:54] but I was able to uninstall it from the UI [03:43:58] sigh! [03:44:26] It didn't remove the table civicrm_value_matching_gift [03:44:46] but it did remove civicrm_matching_gift_job_progress [03:44:48] that's correct behaviour actally [03:44:54] ahhh ok that's good [03:44:58] because the former table is a civicrm custom table [03:45:07] the latter is specific to the extension [03:45:14] hmmm [03:45:16] it should still re-install I think... [03:45:22] right [03:45:47] so the table would stay there, even though the fields for that table are defined in the matching-gifts extension? but not the table, somehow, I guess? [03:46:12] https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/crm/+/258ec66008c1086369aa837c8c13a8730f906afa/sites/default/civicrm/extensions/matching-gifts/xml/auto_install.xml [03:46:57] K so I'll try drush cei matching-gifts [03:47:11] yep - because the data in those fields is not purely managed through the extension [03:47:52] (I mean it is in this case but in general that's the matching gifts philosophy) [03:48:08] ahh okok so what our extension does is just add some columns, I guess? [03:48:09] sorry the custom fields philosophy [03:48:26] So you can create & modify custom fields through the UI [03:48:46] so they are not 'owned' by the extension - even if the extension creates them [03:49:04] by contrast the other table is nowhere in the UI - users can't touch / alter it [03:49:55] ahh ok gotcha [03:49:58] thanks btw [03:50:07] mmm druish cei didn't work [03:50:17] Extension matching-gifts could not be installed. [03:52:35] Hmmm with the -vv flag it says Undefined index: values civicrm.drush.inc:576 [03:54:10] if you do is matching_gifts (underscore) any different? [03:55:05] debug=1 [03:55:05] at the end might help too [03:55:52] hmm - it seems to work for me drush cvapi Extension.install matching-gifts debug=1 [03:58:04] ahh I was doing civiapi [03:58:06] it's cvapi [03:58:17] at least in the second way I was trying it [03:59:52] hmmmm nope [03:59:54] drush -vv cvapi Extension.install matching-gifts [03:59:56] Initialized Drupal 7.70 root directory at /vagrant/srv/org.wikimedia.civicrm/drupal [notice] [03:59:58] Initialized Drupal site default at sites/default [notice] [04:00:00] Undefined offset: 1 civicrm.drush.inc:1522 [notice] [04:00:02] Undefined offset: 2 civicrm.drush.inc:1522 [notice] [04:00:04] Array [04:00:06] ( [04:00:08] [is_error] => 0 [04:00:10] [version] => 3 [04:00:12] [count] => 1 [04:00:14] [values] => 1 [04:00:16] ) [04:00:18] Command dispatch complete [04:01:55] and with the debug flag it just outputs the same array [04:02:04] oh no not true [04:02:22] AndyRussG: that --vv triggers noise for me [04:02:38] it outputs a similar array but not the same [04:02:50] --vv is drupal debug - the other is civi [04:02:50] eileen: ah ok maybe I'm assuming it's doing something it's not [04:03:09] but values => 1 should mean success [04:03:41] hummm but in the UI it shows it as not installed [04:04:03] I don't remember what Elliott got me to do on Friday to have it installed [04:04:11] and it's somehow not in my vagrant's bash history [04:04:19] aaargh sorry for the bother [04:05:53] I could just try installing via the UI [04:08:48] Hmmm couldn't install via the UI either [04:08:51] it says " Sorry, due to an error, we are unable to fulfill your request at the moment. You may want to contact your administrator or service provider with more details about what action you were performing when this occurred. [04:08:52] DB Error: already exists" [04:09:46] and that's even after I manually deleted all the tables with "gift" in their name [04:09:52] I guess I'll go back to the vagrant snapshot [04:12:00] AndyRussG: might have to delete the custom field group and fields manually too? [04:12:46] ejegg|away: oh hi! well, it did show a message about custom field groups found! [04:12:59] sorry, about to sleep, but i'd be happy to go over this in the morning [04:13:06] ejegg|away: yee thanks! [04:13:12] ¡que descanses! [04:13:25] gracias, igualmente [04:13:28] :) [04:14:32] eileen: anyway I was able to get my vagrant back to where it was before, with the extension installed [04:15:06] so I can continue reviewing the rest of the patch [04:15:29] I think that's progress... [04:16:17] eileen: yis!! :) thanks so much for your help eh [04:16:35] I think I mostly just made supportive noises... [04:25:25] eileen: instructional and super helpful supportive noises yeah :) [04:25:34] :-) [05:30:08] hah you were right, it does need an underscore! [07:07:57] (PS1) Eileen: Reorganize final export mapping fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/608262 (https://phabricator.wikimedia.org/T252245) [07:09:06] (CR) jerkins-bot: [V: -1] Reorganize final export mapping fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/608262 (https://phabricator.wikimedia.org/T252245) (owner: Eileen) [07:19:00] Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: adjust fr-log-announcer to use IRC more securely - https://phabricator.wikimedia.org/T122104 (ayounsi) [07:20:46] (PS2) Eileen: Reorganize final export mapping fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/608262 (https://phabricator.wikimedia.org/T252245) [07:46:31] (CR) AndyRussG: "Really nicely organized, super-clean code! Way to go!! :)" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [10:19:55] Wikimedia-Fundraising-Banners: Add non-breaking space between ₹ and amount for Indian Rupee - https://phabricator.wikimedia.org/T256288 (Pcoombe) >>! In T256288#6260604, @jbolorinos-ctr wrote: > Thanks Peter! I agree consistency is better, would we still need to update the payments wiki page though? No. No... [12:46:43] Fundraising Sprint Lazy Loading Life, Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Q4 19/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (KHaggard) Yes that plan sounds great. Thanks, @Ei... [13:39:05] Fundraising Sprint M 2020, Fundraising-Backlog: Removing asterisks in payment page card number field - https://phabricator.wikimedia.org/T254032 (mepps) It sounds like we're good to go with 0000s. [13:44:34] Wikimedia-Fundraising-Banners: Add non-breaking space between ₹ and amount for Indian Rupee - https://phabricator.wikimedia.org/T256288 (spatton) Fire, @Pcoombe! Totally agree re: consistency. Seeing John's screenshot makes me kind of curious to retry the [[ https://docs.google.com/spreadsheets/d/1SOwrCYMYSU... [14:08:39] Fundraising Sprint M 2020, Fundraising-Backlog: Removing asterisks in payment page card number field - https://phabricator.wikimedia.org/T254032 (mepps) I'm noticing that the asterisks actually do correspond to the places where card numbers should be (so it's different for AmEx). I'm trying to see if it'... [14:14:52] Fundraising Sprint M 2020, Fundraising-Backlog: Removing asterisks in payment page card number field - https://phabricator.wikimedia.org/T254032 (mepps) I also realized we'll want to do this for the redirect as well as the iframe. [14:38:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (MNoorWMF) thanks for the update David [15:17:05] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [15:19:10] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [16:00:09] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [16:01:19] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [16:05:18] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Dwi... [16:08:32] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (jbolorinos-ctr) [16:12:51] Wikimedia-Fundraising-Banners: [Enhancement] Auto-select email input field after user clicks RML link in Nag - https://phabricator.wikimedia.org/T255598 (jbolorinos-ctr) [16:12:57] Wikimedia-Fundraising-Banners: [Enhancement] Auto-select email input field after user clicks RML link in Nag - https://phabricator.wikimedia.org/T255598 (jbolorinos-ctr) [16:14:03] Wikimedia-Fundraising-Banners: [Enhancement] Auto-select email input field after user clicks RML link in Nag - https://phabricator.wikimedia.org/T255598 (jbolorinos-ctr) Hey @EWilfong_WMF, The Maybe later link does automatically select the email input, however the nag doesnt. Would it be possible to just a... [16:16:17] Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: adjust fr-log-announcer to use IRC more securely - https://phabricator.wikimedia.org/T122104 (Dwisehaupt) Package changes were pushed to our local version. Still need to get pull requests / branches up to the gerrit repo. iptables and FW po... [16:16:36] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [16:18:33] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [16:27:51] Wikimedia-Fundraising-Banners: [Enhancement] Auto-select email input field after user clicks RML link in Nag - https://phabricator.wikimedia.org/T255598 (EWilfong_WMF) Yes, we can auto-focus the email input in the nag. Noting again that this is how it works in control. So, let's fix it there as well. [16:29:36] fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (Dwisehaupt) A chunk of connections will shift once we can complete T246823 and get one a module that will be in use for stretch and buster. I have a diff available that could add ssl c... [16:56:34] Wikimedia-Fundraising-Banners: [All Controls] Missing comma on donation amounts in older versions of Safari - https://phabricator.wikimedia.org/T256347 (jbolorinos-ctr) Open→Declined Thanks Peter, closing this as declined [16:56:36] Wikimedia-Fundraising-Banners: Early QA: Japan Banners - https://phabricator.wikimedia.org/T255813 (jbolorinos-ctr) [16:57:54] fr-tech I'm gonna join standup while cooking. Back later! [17:44:23] (CR) Ejegg: "Thanks for the review AndyRussG! I'll add a bit more documentation in the next PS." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) (owner: Ejegg) [17:56:37] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 3 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Jdlrobson) >>! In T219793#6201471, @Pcoombe wrote: > If it's possible to change the URL in some way to distinguish it from the desktop sidebar link, that woul... [18:03:56] fundraising-tech-ops: fundraising database "faulkner" end of life - https://phabricator.wikimedia.org/T256670 (Jgreen) [18:05:48] Fundraising-Backlog, fundraising-tech-ops, Epic: Epic: fundraising database approaching data partition capacity - https://phabricator.wikimedia.org/T241083 (Jgreen) [18:22:30] Wikimedia-Fundraising-Banners: [Enhancement] Auto-select email input field after user clicks RML link in Nag - https://phabricator.wikimedia.org/T255598 (jbolorinos-ctr) [18:22:32] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (jbolorinos-ctr) [18:24:31] Wikimedia-Fundraising-Banners: [Enhancement] Auto-select email input field after user clicks RML link in Nag - https://phabricator.wikimedia.org/T255598 (jbolorinos-ctr) Thanks for pointing that out @EWilfong_WMF, I've now removed the RML variant as the parent task, so that it's clear this enhancement is bei... [19:39:56] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 3 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Pcoombe) Not really, because then I don't know how we would re-add that parameter for the desktop link. And utm_skin won't be picked up by our analytics syste... [19:47:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1002:down, kafka-jumbo1005:down, kafka-jumbo1009:down, kafka-jumbo1007:down, kafka-jumbo1003:down, kafka-jumbo1008:down [19:47:18] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1007:down, kafka-jumbo1008:down [19:52:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1009:down, kafka-jumbo1002:down, kafka-jumbo1007:down, kafka-jumbo1006:down, kafka-jumbo1008:down, kafka-jumbo1005:down, kafka-jumbo1003:down [19:52:18] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1007:down, kafka-jumbo1008:down [19:57:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down, kafka-jumbo1007:down, kafka-jumbo1006:down, kafka-jumbo1009:down, kafka-jumbo1002:down, kafka-jumbo1003:down, kafka-jumbo1008:down [19:57:18] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1008:down, kafka-jumbo1007:down [19:58:37] ACKNOWLEDGEMENT - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1008:down, kafka-jumbo1007:down Dwisehaupt checking on expired CA cert [19:58:37] ACKNOWLEDGEMENT - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down, kafka-jumbo1007:down, kafka-jumbo1006:down, kafka-jumbo1009:down, kafka-jumbo1002:down, kafka-jumbo1003:down, kafka-jumbo1008:down Dwisehaupt checking on expired CA cert [19:59:04] looking at the kafka issue. may be a CA cert expiration. [20:20:01] Fundraising-Backlog: New Ingenico API key required before July 29,2020 - https://phabricator.wikimedia.org/T256408 (DStrine) [20:21:00] fundraising-tech-ops: fundraising kafkatee ca certificate has expired - https://phabricator.wikimedia.org/T256683 (Jgreen) [20:21:37] fundraising-tech-ops: fundraising kafkatee ca certificate has expired - https://phabricator.wikimedia.org/T256683 (Jgreen) p:Triage→Unbreak! [20:26:45] Fundraising-Backlog: New Ingenico API key required before July 29,2020 - https://phabricator.wikimedia.org/T256408 (DStrine) [20:27:23] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 3 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Ammarpad) We can easily replace `&utm_medium=sidebar` with `&utm_medium=mobileSidebar` in the link generated by Minerva [20:27:35] Fundraising-Backlog: New Ingenico API key required before July 29,2020 - https://phabricator.wikimedia.org/T256408 (DStrine) [20:28:06] Fundraising-Backlog: New Ingenico API key required before July 29,2020 - https://phabricator.wikimedia.org/T256408 (DStrine) [20:32:38] fundraising-tech-ops: fundraising kafkatee ca certificate has expired - https://phabricator.wikimedia.org/T256683 (Jgreen) https://wikitech.wikimedia.org/wiki/Cergen [20:37:27] fundraising-tech-ops: fundraising kafkatee ca certificate has expired - https://phabricator.wikimedia.org/T256683 (Jgreen) [20:47:18] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [20:49:02] Fundraising-Backlog: New Ingenico API key required before July 29,2020 - https://phabricator.wikimedia.org/T256408 (DStrine) [20:49:14] fundraising-tech-ops: fundraising kafkatee ca certificate has expired - https://phabricator.wikimedia.org/T256683 (Jgreen) Refreshed CA cert from puppetmaster1001:/srv/private/modules/secret/secrets/certificates/kafka_fundraising_client which has fixed the problem. [20:49:43] fundraising-tech-ops: fundraising kafkatee ca certificate has expired - https://phabricator.wikimedia.org/T256683 (Jgreen) Open→Resolved a:Jgreen [20:52:12] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [20:59:22] Fundraising Sprint M 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: TS update import back into Civi - https://phabricator.wikimedia.org/T255805 (DStrine) [21:09:41] mepps: I won't be about for our catch up tomorow - can do today if you want [21:14:59] Wikimedia-Fundraising-Banners: [Enhancement] Auto-select email input field after user clicks RML link in Nag - https://phabricator.wikimedia.org/T255598 (EWilfong_WMF) Sounds good. I've updated the RML options banner to include this update: https://en.wikipedia.org/wiki/Wikipedia?banner=Trilogy_mlWW_dsk_p1_l... [21:27:51] If someone can merge this .... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/607657 - it would cause issues if I don't do this before some of the other changes in the tools repo & it will be easy to forget that sequencing.... [21:29:42] (PS6) Eileen: Add index to civicrm_country.iso_code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607657 (https://phabricator.wikimedia.org/T253152) [21:31:51] (CR) jerkins-bot: [V: -1] Add index to civicrm_country.iso_code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607657 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:32:44] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607657 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:50:51] (CR) Cstone: [C: +2] Add index to civicrm_country.iso_code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607657 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:52:40] (CR) jerkins-bot: [V: -1] Add index to civicrm_country.iso_code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607657 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:53:20] man, crm CI is super fail-y these days [22:05:01] :-( [22:05:13] they are switching to gitlab.... [22:12:21] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/607657 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [22:22:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [22:22:35] Fundraising-Backlog, MobileFrontend, WMF-Design, Design, and 3 others: Mobile web donate link - https://phabricator.wikimedia.org/T219793 (Jdlrobson) a:Jdlrobson→Edtadros [22:27:12] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [22:37:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1003:down [22:42:12] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [22:43:21] (PS17) Ejegg: New MatchingGiftPolicies api action 'sync' using job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/605638 (https://phabricator.wikimedia.org/T249924) [22:43:23] (PS1) Ejegg: WIP tests for sync [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/608486 [22:45:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1378 [22:50:12] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 3048458 Threads: 3 Questions: 83206580 Slow queries: 178088 Opens: 1309462 Flush tables: 1 Open tables: 200 Queries per second avg: 27.294 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [22:50:18] (CR) jerkins-bot: [V: -1] WIP tests for sync [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/608486 (owner: Ejegg) [22:52:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1007:down [22:57:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1009:down [22:59:25] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/608487 [23:00:17] ejegg: wee have a deploy commit with quite a few changes - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/608487 - notably matching gifts stuff - all good? [23:00:59] I feel like I recognise those patches actually [23:02:12] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [23:05:59] looking eileen [23:06:23] yep, looks good to me eileen [23:07:05] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/608487 (owner: Eileen) [23:21:12] this is the one I need merged today https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/608262 [23:21:53] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/608487 (owner: Eileen) [23:28:01] eileen when you're done there I have some questions about Civi extension install and upgrade sql scripts [23:28:23] !log civicrm revision changed from 52a32f2d66 to 391d0fdf75, config revision is f1b4bdb7b7 [23:28:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:28:28] ejegg: shoot [23:36:29] what happened? [23:37:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1008:down [23:38:14] ejegg: no shoot as in tell me your qustios... [23:38:19] questions... [23:38:48] ah ha [23:39:24] so, if I add a table and want it installed on first install and also on upgrade for existing installs [23:39:38] do I need to put it in upgrade_1001 and also install() ? [23:41:12] fundraising-tech-ops: Determine reason for daily increasing proc count on fran1001 - https://phabricator.wikimedia.org/T256420 (Dwisehaupt) a:Dwisehaupt [23:41:38] actually I don't know [23:42:09] I think so [23:42:12] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [23:42:19] that's how it should work - ie on install it installs the 'now' [23:42:37] and on upgrade it applies any incrementals that might be needed [23:50:19] does anyone know who DannyS712 is? [23:52:27] (PS4) Eileen: Silverpop refactor - reduce queries to build country & language [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607652 [23:54:14] dang - it's beyond me to figure out how to rebase over fixing the typo in the commit message that DannyS712 commented on with the new gerrit interface - it's the first in a chain [23:55:05] (PS3) Eileen: Reorganize final export mapping fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/608262 (https://phabricator.wikimedia.org/T252245) [23:55:07] (PS1) Eileen: Prefix all total colums in our staging tables with foundation_ [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/608492 (https://phabricator.wikimedia.org/T252245) [23:55:11] ok I guess that did it - hard to see it was worth the time [23:56:43] (CR) Eileen: Silverpop refactor - reduce queries to build country & language (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/607652 (owner: Eileen) [23:58:09] ejegg: or ?? can I push you to check that field mapping one? I need to get it deployed before the job runs. Shouldn't be a big job [23:58:49] sure [23:59:09] the 'reorganize final export mapping fields', right? [23:59:55] oh, there are a couple prereqs