[11:27:13] (PS1) Nikerabbit: Revert "Localisation updates from https://translatewiki.net." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/612208 [11:42:35] (PS1) Nikerabbit: Revert "Localisation updates from https://translatewiki.net." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/612235 [11:56:17] (CR) Raimond Spekking: [V: +2 C: +2] "new export follows soon" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/612208 (owner: Nikerabbit) [12:04:56] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (EYener) @Jgreen I'd like to set up more alerting on frdb1003 for before we make this ch... [12:19:36] (Merged) jenkins-bot: Revert "Localisation updates from https://translatewiki.net." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/612208 (owner: Nikerabbit) [12:39:52] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (Jgreen) >>! In T255456#6300657, @EYener wrote: > @Jgreen I'd like to set up more alerti... [12:42:35] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (Jgreen) >>! In T255456#6300657, @EYener wrote: > @Jgreen I'd like to set up more alerti... [13:29:17] (Merged) jenkins-bot: Revert "Localisation updates from https://translatewiki.net." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/612235 (owner: Nikerabbit) [14:19:59] hi fr-tech [14:20:22] so.... can we do anything about all those potential duplicate contributions? [14:20:30] (CR) Mepps: [C: +2] "Works as expected" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/610140 (https://phabricator.wikimedia.org/T256838) (owner: Jgleeson) [14:21:03] or should we disable some of that failmail? [14:21:16] it's not really helpful to get so much if we can't do anything? [14:21:30] Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, Patch-For-Review: In the DonationInterface form, handle case in which a user clicks on an employer from the dropdown, then types the name of an employer not on the list - https://phabricator.wikimedia.org/T256838 (mepps) I +2ed this but... [14:21:33] eh, last line was malpunctuated [14:23:14] (Merged) jenkins-bot: Reset employer_id each time a new search starts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/610140 (https://phabricator.wikimedia.org/T256838) (owner: Jgleeson) [14:35:03] ejegg: I was planning to dig into the failmails from the weekend as part of the chores stuff [14:41:46] ejegg: I can't remember exactly where the other locations are in the stack that we might attempt to add a new c_id to the ct record for an existing but I'm wondering if we could maybe put the hash check we added to the frontend inside smashpig so it because a library function that we can pepper around the various places likely to need it [14:42:18] so it becomes* [14:48:32] Fundraising-Backlog: Payments Wiki form variant w/ PAN field explanation text - https://phabricator.wikimedia.org/T257844 (spatton) [14:52:12] jgleeson that might be useful. Do you think that could help with these failures though? [14:54:21] ejegg: I don't feel like I understand the problem enough yet to say [14:57:32] Fundraising-Backlog: Payments Wiki form variant w/ PAN field explanation text - https://phabricator.wikimedia.org/T257844 (spatton) [14:58:48] OK, let's do some log diving to figure out a bit more of what's going on then [15:03:37] yeah I'm looking at the emails now just trying to work out what's going on [15:03:47] just gonna grab a hot drink brb [15:03:59] the emails just show which ct_ids have the problems [15:04:09] the actual issue starts way upstream [15:04:33] I think most of these are people who think their first donation failed and make a second one [15:05:16] though a small number may be us recording the same donation under two txn ids (that's the bug chistine filed a week or so ago) [15:09:00] ah ok [15:10:09] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: investigate moving non-essential databases (faulkner, pgehres, fredge) off of fundraising database cluster - https://phabricator.wikimedia.org/T255456 (Jgreen) [15:10:11] so I think fixing the problem will mean better error handling in donationinterface [15:10:22] but the first step is just figuring out where stuff goes wrong [15:10:38] and maybe adding more logging on the front end [15:11:16] ok, so for log diving, I think we want one grep command to pull all the affected ct_ids into a file [15:11:54] and then another little bash loop to get all the log lines for each ct_id into its own file [15:11:59] for easy inspection [15:12:09] I'm going onto civi1001 [15:12:17] to get the process-control logs [15:12:22] for the first bit [15:18:39] ejegg: I'm currently digging around using this [15:18:42] frlog1001:/srv/archive/frlog1001/logs$ find . -name "*2020070[1-9].gz" -exec zgrep --color -H '80922804' {} \; [15:19:43] but that's only to inspect one [15:23:49] so this one is ingenico.v=monthlyConvert [15:27:30] Wikimedia-Fundraising-Banners: Close button disables sequence - https://phabricator.wikimedia.org/T257849 (jbolorinos-ctr) [15:32:09] Fundraising-Backlog: Payments Wiki form variant w/ PAN field explanation text - https://phabricator.wikimedia.org/T257844 (DStrine) @spatton Do you have all the copy for this already? [15:39:59] jgleeson: and ejegg I know we have an adyen bug in the sprint about duplicates. Is your topic the same or adjacent? if adjacent, I feel like this might warrant a task [15:40:13] Wikimedia-Fundraising-Banners: [Dsk Lg + Dsk Sm] Hover text appearing on Close icon for RML - https://phabricator.wikimedia.org/T256439 (jbolorinos-ctr) Please note, this issue has been observed on the controls as well as the RML variants [15:40:24] dstrine we don't know yet [15:40:34] ejegg: ok [15:40:38] this is the first campaign we've had with the new warnings on [15:40:46] and we're getting more warnings than expected [15:41:18] but those warnings happen at the end of the process [15:41:29] and we need to dig in the logs to figure out the root causes [15:42:02] ok if it starts to pull a bunch of people in or takes a lot of time, it's probably worth documenting what you all found or discussed. [15:42:31] I'm currently investigating the link between monthlyConvert and the bug [15:42:32] Wikimedia-Fundraising-Banners: QA: Orange Mobile large banners - https://phabricator.wikimedia.org/T257850 (TSkaff) [15:42:56] fr-tech do you know how the email export went through the night? [15:43:58] also fr-tech, a bunch of people will probably want to discuss the hide banner cookie with advancement in the big standup in about an hour. [15:45:10] dstrine: okok thanks :) [15:45:48] checking the silverpop logs dstrine [15:47:00] I can one from sunday [15:47:03] sunday monring [15:49:11] I can see one* [15:49:40] kinda expecting to also see one from this morning too [15:52:58] jgleeson: thanks. I'm pinging the email team on slack. Caitlin and Katers will join us in backlog refinement to just in case. [15:56:59] jgleeson: Katers says they got 2 files. I'm not sure how to interpret what she is sharing in chat [15:57:22] but they got something last night [15:58:58] hmm [15:59:19] I can see in the logs 3 files got uploaded 2020-07-12 05:45:56 UTC [15:59:27] which is my sunday morning [15:59:41] but I don't see anything from THIS morning [16:01:23] there are a few failmails from around 5am this morning [16:01:31] but they are omnimail related [16:02:16] I'll just check to see if the job is on [16:05:24] hmm looks like it should run at 2am every day [16:09:40] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 2 others: Add silverpop privacy delete routine - https://phabricator.wikimedia.org/T257001 (mepps) a:Eileenmcnaughton→mepps [16:15:32] fundraising-tech-ops, Patch-For-Review: rack/setup/install civi2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T242270 (Dwisehaupt) [16:18:35] fr-tech scratching my head why I can't find the silverpop export log files from this morning. the job should have started around 2am and finished around 5am UTC according to the process-control job and the previous job run time (sunday's) [16:19:00] jgleeson: yeah, it's a puzzler [16:19:06] is it possible I'm forgetting how time works and the sunday 2am job is today's? [16:19:10] checking the schedule again [16:20:05] Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: adjust fr-log-announcer to use IRC more securely - https://phabricator.wikimedia.org/T122104 (Dwisehaupt) Moving this to watching awaiting the acceptance of the patch sets to the internal repo. [16:23:52] yah, it's * in the day slot [16:24:26] yep! [16:24:41] ohh, today's logs are already archived [16:24:58] in the srv/archive dir on civi box [16:25:11] that's empty for me [16:25:14] and yeah, it looks like the upload worked [16:25:22] oh [16:25:46] /srv/archive/civi/process-control/20200713 ? [16:26:11] oh wait [16:26:16] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 19 seconds ago with 1 failures. Failed resources (up to 3 shown): File[/etc/django_settings.py] [16:26:17] on the civi box [16:26:49] ah I see them on the civi1001 box [16:27:01] I was expecting to also see them in the above path [16:27:12] maybe they get rsyncd at some point? [16:27:36] Jeff_Green: dwisehaupt any ideas? [16:28:10] looks like the log files for a job we've been trying to track down are here civi1001:/srv/archive/civi1001/process-control/20200713 [16:28:22] but not here frlog1001:/srv/archive/civi/process-control/20200713 [16:28:26] oh [16:28:42] am I mistakenly assuming they should also be in the second place? [16:29:00] they're rotated hourly locally, and that entire archive tree is pulled daily to frlog1001 [16:29:51] best to think of frlog1001/frlog2001's archive dirs as archival storage, since that whole tree is collected only daily [16:30:01] ah got it [16:30:11] I probably need to update this https://collab.wikimedia.org/wiki/Fundraising/Engineering#Fundraising_Log_Diving [16:30:38] to show "soon-to-be-archived" label maybe [16:31:16] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 17 seconds ago with 1 failures. Failed resources (up to 3 shown): File[/etc/django_settings.py] [16:31:39] jgleeson: ya, that makes sense [16:32:34] dstrine: ejegg found the log file we were looking for which shows the silverpop job did run this morning as expected [16:33:21] the following files were sent DatabaseUpdate-20200713042727.csv, Unsubscribes-20200713042727.csv and MatchingGifts-20200713042727.csv [16:33:23] katers: ^ [16:35:35] Cool! thanks for looping me in. Also just as a heads up, the MatchingGifts CSV did not process on our end because we still have to set the program in Acoustic to retrieve the file. [16:36:16] RECOVERY - check_puppetrun on fran1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [16:36:55] yeah that's fine katers I appreciate that's a new body of work for yall to do stuff with that data. We just add the file to upload to confirm it gets sent for now [16:38:12] cool :) thanks! [16:57:14] ejegg: reply from bblack on e-mail about cookies and traffic! [17:01:32] i see it AndyRussG ! [17:01:44] also ema asked me some follow-up questions in irc [17:01:50] but he's about to end his workday [17:01:58] so will take another look tomorrow [17:05:45] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (spatton) [17:09:11] ejegg: ah cool, thanks! anything that shifts the discussion/solutions from ema? I don't see it in the backscroll of -operations? [17:12:35] Wikimedia-Fundraising-Banners: Close button disables sequence - https://phabricator.wikimedia.org/T257849 (spatton) Thanks, this is the expected behavior. Closing our large banners doesn't set a hide cookie; closing a small banner sets a 7-day hide cookie. This is described in the [[ https://docs.google.com/... [17:13:02] Wikimedia-Fundraising-Banners: QA for en6C pre-test on July 15 - https://phabricator.wikimedia.org/T257509 (spatton) [17:13:04] Wikimedia-Fundraising-Banners: Close button disables sequence - https://phabricator.wikimedia.org/T257849 (spatton) Open→Invalid p:Triage→Medium [17:16:51] ejegg: I think bblack's concerns about switching the site still needing us to address cookies and caching issues are mistaken [17:17:15] that is, I think that on both sites we can set and read the cookies from JS so no traffic/caching-relateded issues, no? [17:18:55] yeah, I was going to reply to clarify that [17:19:20] I still feel that's the most sustainable way forward [17:19:46] making donatewiki available on d.wikipedia.org as well [17:19:52] and setting the standard hide cookie there [17:19:57] ejegg: yeah... Probably in the config or somewhere we can make sure it only happens for TY pages, no? [17:20:17] ah, I was thinking it would happen in TY-specific javascript [17:20:27] ejegg: I mean the redirect [17:21:17] ejegg: that is, so that only the TY pages can be viewed at d.wikipedia.org [17:21:35] to avoid entanglement with rebranding discussions [17:24:34] AndyRussG: oh, hmm, I guess [17:27:44] fr-tech do we have a fancy log searching frontend for the fundraising stack similar to the likes of splunk or kibana ? [17:29:32] I haven't come across one but was just checking in case we could access fr-stack logs on the wider wmf instances [17:30:13] jgleeson: we do not. [17:31:07] thanks dwisehaupt [17:53:59] ejegg: thanks for giving the update in standup! [18:20:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Wikimedia-production-error: BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/ - https://phabricator.wikimedia.org/T244020 (Quiddity) Just to check, was this communicated to the CN-admins? (I'm not on tha... [18:37:53] oh hey AndyRussG, umherirrender contributed a patch for ^^^ [19:01:39] fundraising-tech-ops: Add syntax checking and linting to fr-tech-ops repos - https://phabricator.wikimedia.org/T253899 (Dwisehaupt) [19:08:03] fundraising-tech-ops: Add syntax checking and linting to fr-tech-ops repos - https://phabricator.wikimedia.org/T253899 (Dwisehaupt) tox.ini file created in main repo and python scripts updated to cleanly pass. This requires you have tox and flake8 installed on the host you wish to run the tests on (which fr... [19:09:58] fundraising-tech-ops: Move from phantomJS to grafana-image-renderer for frack grafana - https://phabricator.wikimedia.org/T250441 (Dwisehaupt) [19:23:38] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 2 others: Add silverpop privacy delete routine - https://phabricator.wikimedia.org/T257001 (mepps) From this, I assume we'd store the email_id. [19:40:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (Eileenmcnaughton) That last contact id is deleted now - they have no donation dates in our system but they won't update that through as they are deleted [19:50:33] !log disable target smart job process-control config revision is b00e7680ca [19:50:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:51:40] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 2 others: Add silverpop privacy delete routine - https://phabricator.wikimedia.org/T257001 (Eileenmcnaughton) @mepps yes [20:00:26] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hid banner cookie - https://phabricator.wikimedia.org/T251780 (DStrine) [20:02:47] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hid banner cookie - https://phabricator.wikimedia.org/T251780 (DStrine) For the record: we a... [20:03:09] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hid banner cookie - https://phabricator.wikimedia.org/T251780 (mepps) As I understand this:... [20:04:51] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hide banner cookie - https://phabricator.wikimedia.org/T251780 (DStrine) [20:14:29] Fundraising-Backlog: Payments Wiki form variant w/ PAN field explanation text - https://phabricator.wikimedia.org/T257844 (DStrine) [21:14:01] eileen: I've looked over https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/609238 and it the changes work. the output is the same as before but I can't really attest to the speed improvements (but I take your word for it). I feel like if I had more time I'd like to go through the new missing countries behaviour step by step but the fact that it stil produces the same recordset [21:14:03] tells me it hasn't introduced any problems [21:14:15] and THE changes work for me* [21:14:40] jgleeson: the missing countries part is just moved isn't it? [21:15:12] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/609238/15/silverpop_export/update_silverpop_staging.sql#@27 [21:15:27] I thought that bit had changed [21:15:53] looks like I failed to remove here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/609238/15/silverpop_export/update_table.sql [21:16:06] oh yeah at the top [21:16:33] yeah so I have 2 follow ups I thinnk [21:16:36] 1 remove that [21:16:52] 2 remove the thing we deployed over the weekend as it should not be needed now [21:20:06] I think there's an extra join on the broken out missing countries query https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/609238/15/silverpop_export/update_silverpop_staging.sql#34 [21:20:16] is that to pull in the modified date [21:20:22] for the offSet [21:20:24] ah [21:21:01] yeah ideally at the python level we would pass offset in [21:21:02] ok I guess that's pretty much the same then [21:21:21] cool - I just pushed up to remove the duplicate table [21:22:07] (PS1) Eileen: Remove duplicate instance of country map [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/612421 (https://phabricator.wikimedia.org/T253152) [21:25:26] (CR) Jgleeson: [C: +2] Fix test to have modified date for all contacts [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610946 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:25:33] (CR) Jgleeson: [C: +2] Add rebuild file for full table rebuild [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610949 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:26:42] (CR) Jgleeson: [C: +2] "This looks good to me and is working well locally. The missing_countries duplicate query is fixed in a follow on patch." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/609238 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:27:02] (Merged) jenkins-bot: Fix test to have modified date for all contacts [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610946 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:27:34] thanks jgleeson [21:27:53] (Merged) jenkins-bot: Add rebuild file for full table rebuild [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610949 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:27:58] (Merged) jenkins-bot: Silverpop - build main table incrementally [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/609238 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:28:37] This is just a function extraction if anyone can review it - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/610663 (am guessing jgleeson is done for the day) [21:28:48] (CR) Jgleeson: [C: +2] Remove duplicate instance of country map [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/612421 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:29:44] (Merged) jenkins-bot: Remove duplicate instance of country map [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/612421 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:29:46] oh dang - it needs conflict resolution [21:34:55] (PS2) Eileen: Extract running of queries to a function [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610663 (https://phabricator.wikimedia.org/T253152) [21:36:11] (CR) jerkins-bot: [V: -1] Extract running of queries to a function [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610663 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:38:06] (PS2) Eileen: Iterate array of updates to run [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610664 (https://phabricator.wikimedia.org/T253152) [21:38:54] (CR) jerkins-bot: [V: -1] Iterate array of updates to run [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610664 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [21:50:08] fundraising-tech-ops: clean up payments-wiki configuration related to deprecated mysql contribution tracking connection - https://phabricator.wikimedia.org/T253653 (Dwisehaupt) Open→Resolved a:Dwisehaupt This has been committed to master and rolled out. Logs look clean and donations coming in. C... [21:50:10] Fundraising Sprint Fistful of $variables, Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint Ice cream cures everything, and 8 others: CRM contribution tracking writes should use queue and sequence generator - https://phabricator.wikimedia.org/T215463 (Dwi... [21:51:53] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (spatton) [22:55:44] Wikimedia-Fundraising-Banners: No error message displayed when clicking "Submit" on Step 2 and missing data - https://phabricator.wikimedia.org/T257880 (jbolorinos-ctr) [22:59:29] Wikimedia-Fundraising-Banners: Unable to tab through RML options Step 2 - https://phabricator.wikimedia.org/T257882 (jbolorinos-ctr) [23:04:10] Wikimedia-Fundraising-Banners: [Enhancement] Update "Submit" button to "Continue" or something more appropriate - https://phabricator.wikimedia.org/T255600 (jbolorinos-ctr) That's certainly a good point Eric, I'm going to go ahead and close this one as Declined then, since it's neither consistent with contro... [23:04:24] Wikimedia-Fundraising-Banners: [Enhancement] Update "Submit" button to "Continue" or something more appropriate - https://phabricator.wikimedia.org/T255600 (jbolorinos-ctr) Open→Declined [23:04:26] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (jbolorinos-ctr) [23:06:10] Wikimedia-Fundraising-Banners: No error message displayed when clicking "Submit" on Step 2 and missing data - https://phabricator.wikimedia.org/T257880 (jbolorinos-ctr) p:Triage→Medium [23:07:00] Wikimedia-Fundraising-Banners: No error message displayed when clicking "Submit" on Step 2 and missing data - https://phabricator.wikimedia.org/T257880 (jbolorinos-ctr) Setting priority to medium since it would be nice if this were fixed before campaign launch, but it wont affect the campaign as a whole. [23:08:26] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (jbolorinos-ctr) [23:08:28] Wikimedia-Fundraising-Banners: [Candidate] NL Banners (Duplicate of Asana task) - https://phabricator.wikimedia.org/T255833 (jbolorinos-ctr) [23:09:22] Wikimedia-Fundraising-Banners: [BETA] QA for 'RML options' banner - https://phabricator.wikimedia.org/T253054 (jbolorinos-ctr) I've added the NL Banners task as a parent to this task, since the RML options variant was included in the NL campaign. [23:12:34] (PS3) Eileen: Extract running of queries to a function [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610663 (https://phabricator.wikimedia.org/T253152) [23:13:17] (CR) jerkins-bot: [V: -1] Extract running of queries to a function [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610663 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [23:14:09] (PS3) Eileen: Iterate array of updates to run [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610664 (https://phabricator.wikimedia.org/T253152) [23:15:54] (CR) jerkins-bot: [V: -1] Iterate array of updates to run [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610664 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [23:15:59] (PS4) Eileen: Extract running of queries to a function [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610663 (https://phabricator.wikimedia.org/T253152) [23:16:31] (CR) jerkins-bot: [V: -1] Extract running of queries to a function [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610663 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [23:20:19] (PS5) Eileen: Extract running of queries to a function [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610663 (https://phabricator.wikimedia.org/T253152) [23:23:40] (Abandoned) Eileen: Iterate array of updates to run [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610664 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [23:24:03] (PS4) Eileen: Remove a bunch of fields from silverpop_export_staging that are no longer used [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/610480 (https://phabricator.wikimedia.org/T253152) [23:25:50] Can someone review this one - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/610480 - I want to deploy JUST this patch today to remove some unnecessary fields from the staging_export table before we stop rebuilding it [23:28:36] Wikimedia-Fundraising-Banners: Close button disables sequence - https://phabricator.wikimedia.org/T257849 (jbolorinos-ctr) Thanks for the clarification Sam!