[00:06:39] (PS2) Cstone: WIP: Add variant for PAN explanation text. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/612696 [01:00:54] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 3 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaught... [02:11:55] Am just checking silverpop fail [02:35:11] okok, thought maybe you'd be on it. [02:35:21] let me know if you want a hand with anything [03:07:54] Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, FR-Civi-Dedupe: Civi Dedupe: enable Deduper to handle multiple email addresses - https://phabricator.wikimedia.org/T256316 (Eileenmcnaughton) a:Eileenmcnaughton [03:08:22] (PS1) Eileen: Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) [03:13:57] (CR) jerkins-bot: [V: -1] Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [03:14:45] (PS2) Eileen: Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) [03:21:06] (CR) jerkins-bot: [V: -1] Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [03:23:22] (PS3) Eileen: Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) [03:29:58] (CR) jerkins-bot: [V: -1] Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [03:35:33] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [03:36:01] (CR) Eileen: "We have had this install issue before - but I'm struggling to think why or see where it's coming from" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [03:48:56] (PS4) Eileen: Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) [03:50:15] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 3 others: Add silverpop privacy delete routine - https://phabricator.wikimedia.org/T257001 (Eileenmcnaughton) I think you could probably just ad... [03:56:30] (PS5) Eileen: Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) [04:05:19] (PS1) Eileen: Move casing to deduper extennsion [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613016 (https://phabricator.wikimedia.org/T256316) [06:36:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [06:41:16] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [06:46:12] RECOVERY - check_puppetrun on frdb2002 is OK: OK: Puppet is currently enabled, last run 25 seconds ago with 0 failures [08:28:18] (PS4) Eileen: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [08:35:39] (CR) Eileen: "I figured out the reason it was failing - yay" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [12:57:53] Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, Patch-For-Review: Payments Wiki form variant w/ PAN field explanation text - https://phabricator.wikimedia.org/T257844 (spatton) [13:16:54] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 3 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (KHaggard) Hi... [13:55:08] (CR) Mepps: [C: +2] Margin cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612972 (owner: Eileen) [14:04:10] (Merged) jenkins-bot: Margin cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612972 (owner: Eileen) [14:13:25] (PS5) Mepps: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) [14:15:30] (CR) jerkins-bot: [V: -1] Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [14:21:25] (PS6) Mepps: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) [14:24:07] (CR) Mepps: "argh how did rebasing lead to more test failures?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [14:39:09] Wikimedia-Fundraising-Banners: QA for en6C pre-test on July 15 - https://phabricator.wikimedia.org/T257509 (spatton) Open→Resolved [14:42:28] Wikimedia-Fundraising-Banners: QA for en6C pre-test on July 23 - https://phabricator.wikimedia.org/T258177 (spatton) [14:44:10] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T258178 (spatton) [14:45:34] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T258179 (spatton) [14:46:51] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T258180 (spatton) [14:47:40] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T258182 (spatton) [14:50:40] Wikimedia-Fundraising-Banners: QA for en6C pre-test on July 23 - https://phabricator.wikimedia.org/T258177 (spatton) [14:51:06] Wikimedia-Fundraising-Banners: QA for en6C pre-test on July 23 - https://phabricator.wikimedia.org/T258177 (spatton) [14:51:14] Wikimedia-Fundraising-Banners: QA for en6C pre-test on July 23 - https://phabricator.wikimedia.org/T258177 (spatton) [15:01:06] hi jgleeson! [15:02:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (MNoorWMF) I got an email from Acoustic today regarding updating certificates. wanted to share in the event that it is applicable here: *You are receiving this messag... [15:17:28] hey mepps :) [15:30:41] Wikimedia-Fundraising-Banners: QA: Orange Mobile large banners - https://phabricator.wikimedia.org/T257850 (TSkaff) Hi John, Could I bump this in priority? I'd love to replace the NL dark banners with one of these if we can (since they've live). Thanks! [16:05:31] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising-Backlog, Patch-For-Review: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (CCogdill_WMF) Bump! See Moska's Q above. [16:08:08] (PS3) Cstone: Add variant for PAN explanation text. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/612696 [16:10:03] jgleeson i'm seeing a new failure on crm tests, have you seen anything recently? [16:10:40] i mean locally [16:11:26] hmm [16:12:44] I don't keep track outside of that WIP patch which fixes a bunch [16:13:38] I haven't ran the crm tests for a while other than when recently rebasing that WIP patch and noticing the failures had increased [16:21:03] yeah i can't get past an initial error :( [16:25:21] I'm just finishing some review mepps but if you could maybe paste the failure or the test name that's failing I can try it out at my end? [16:29:31] (CR) Jgleeson: [C: +1] "So this is all working for me locally and the SQL looks good however I feel like I wanna know more about what's actually going on big pict" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/612700 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [16:31:32] (CR) Jgleeson: [C: +2] "Working for me locally. Nice!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/612699 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [16:32:20] (Merged) jenkins-bot: Remove reference to silverpop_export_address [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/612699 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [16:34:21] Fundraising Sprint Nyan cats for everyone, Fundraising Sprint X-rays, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: rework fredge search to include new fields and general debug - https://phabricator.wikimedia.org/T239967 (DStrine) [16:38:36] (PS7) Mepps: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) [16:42:05] (CR) jerkins-bot: [V: -1] Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [16:43:25] (CR) Mepps: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [16:52:08] Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix Matching Gift policy sync - https://phabricator.wikimedia.org/T257963 (DStrine) [16:55:48] (PS8) Mepps: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) [16:56:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Fix stuck recurring contributions, add alarm - https://phabricator.wikimedia.org/T258013 (Dwisehaupt) Icinga isn't really designed to do an alarm in that fashion. It's more along the lines of alerting when something actively mo... [16:59:55] fundraising-tech-ops: Capture metric for civicrm_contribution_recur in processing state - https://phabricator.wikimedia.org/T258204 (Dwisehaupt) [17:01:55] (CR) jerkins-bot: [V: -1] Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [17:02:41] (PS9) Mepps: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) [17:05:40] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising-Backlog, Patch-For-Review: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (DStrine) Open→Resolved @CCogdill_WMF @MNoorWMF we heard from @KHaggard that the... [17:05:42] Fundraising-Backlog, Epic: Epic: matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (DStrine) [17:07:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (DStrine) @MNoorWMF this last message actually assures us that the URLs we are using are still supported so no needed updates on our end. I am talking with the team to... [17:09:15] (CR) jerkins-bot: [V: -1] Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [17:13:14] (PS10) Mepps: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) [17:19:40] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T258178 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z2ac8ef9b69ac4645f7e [17:19:44] (CR) jerkins-bot: [V: -1] Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) (owner: Mepps) [17:21:22] (PS11) Mepps: Upgrade forget to store deleted email ids [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/612949 (https://phabricator.wikimedia.org/T257001) [17:22:44] Fundraising-Backlog, fundraising-tech-ops: Package PrivateBin for FR-Tech hosts - https://phabricator.wikimedia.org/T255063 (Dwisehaupt) Testing build of python3-sjcl which is required for the privatebin cli tool. Will be testing a static deployment in the VB land in the coming days. Then moving on to pa... [17:22:53] Fundraising-Backlog, fundraising-tech-ops: Package PrivateBin for FR-Tech hosts - https://phabricator.wikimedia.org/T255063 (Dwisehaupt) a:Dwisehaupt [17:24:53] fundraising-tech-ops: Test and choose a benchmark to use for applying a machine standard - https://phabricator.wikimedia.org/T246841 (Dwisehaupt) a:Dwisehaupt→None Holding on this for now pending more discussion. [17:28:42] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 3 others: Add silverpop privacy delete routine - https://phabricator.wikimedia.org/T257001 (mepps) Yay! It's tested. [17:29:26] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T258179 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z20bee9a8bfad58ebc85 [17:33:13] (CR) Mepps: [C: +2] "It works!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/612696 (owner: Cstone) [17:39:47] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T258180 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z00f2682167462cc1b07 [17:42:20] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising-Backlog, Patch-For-Review: Export Matching Gifts data to acoustic - https://phabricator.wikimedia.org/T254809 (KHaggard) Just clarifying here - I can't actually see the file showing up in Acoustic but... [17:52:11] (Merged) jenkins-bot: Add variant for PAN explanation text. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/612696 (owner: Cstone) [18:01:06] (PS1) Jgleeson: Add check to skip duplicate check on ct messages missing a contribution_id field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613214 (https://phabricator.wikimedia.org/T253250) [18:05:13] Wikimedia-Fundraising-Banners: 2020-07-23 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T258182 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z8599890d97087552766 [18:05:37] (PS2) Jgleeson: Add check to skip duplicate check on ct messages missing a contribution_id field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613214 (https://phabricator.wikimedia.org/T253250) [18:36:43] (PS1) Huji: Remove IE 6 & 7 hasLayout hacks [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/613229 (https://phabricator.wikimedia.org/T258199) [18:53:39] dstrine eyener jkumalah fr-tech I'll be a few minutes late to the analytics sync-up... groceries just arrived! [18:56:01] Okay no problem AndyRussG! We don't have anything on the agenda yet and jkumalah has been super busy and needs to skip. Might be a short one! [19:02:45] (PS1) Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/613236 [19:09:59] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/613236 (owner: Cstone) [19:15:32] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/613236 (owner: Cstone) [19:55:35] (PS1) Cstone: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 [20:01:54] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:03:06] (CR) Cstone: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:09:51] (CR) Bartosz Dziewoński: Remove IE 6 & 7 hasLayout hacks (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/613229 (https://phabricator.wikimedia.org/T258199) (owner: Huji) [20:10:18] (CR) Cstone: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:12:27] (CR) VolkerE: Remove IE 6 & 7 hasLayout hacks (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/613229 (https://phabricator.wikimedia.org/T258199) (owner: Huji) [20:15:20] Wikimedia-Fundraising-Banners: QA for en6C pre-test on July 23 - https://phabricator.wikimedia.org/T258177 (spatton) Hey @jbolorinos-ctr, in the last hour, I realized that I had not yet made a tweak requested by Michael - to disable post-payment monthly convert due to Ingenico incorrectly flagging all donati... [20:19:02] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice must not query master on GET request (page views) - https://phabricator.wikimedia.org/T216287 (aaron) This seems to be more of a CentralNotice issu... [20:19:37] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 3 others: BannerMessageGroup::registerGroupHook of CentralNotice must not query master on GET request (page views) - https://phabricator.wikimedia.org/T216287 (aaron) [20:20:23] (CR) Ejegg: [C: +2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613214 (https://phabricator.wikimedia.org/T253250) (owner: Jgleeson) [20:27:45] (Merged) jenkins-bot: Add check to skip duplicate check on ct messages missing a contribution_id field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613214 (https://phabricator.wikimedia.org/T253250) (owner: Jgleeson) [20:29:55] dstrine: this is important, will block any CN deploys to production... might be new, or might be just recently uncovered... https://phabricator.wikimedia.org/T216287 [20:30:08] (CR) Cstone: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:34:44] AndyRussG: looks like that ticket was made more than a year ago [20:35:20] oh, recently triaged to high [20:36:15] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:36:27] oh hmmm didn't notice it was made that long ago ejegg [20:36:40] (CR) Cstone: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:40:53] I see that fn says // Must be explicitly master for runs under a jobqueueMust be explicitly master for runs under a jobqueue [20:41:22] oops [20:41:27] not duplicated [20:41:29] but anyway [20:41:43] would it be easy to check that context? [20:42:45] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:43:17] (CR) Cstone: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:45:27] i wish this linter would behave [20:45:35] jeez, still timing out? [20:45:45] hopefully when we're off php7.0 it will go faster [20:46:21] i just failed at new gerrit UI too and somehow removed the code review +2 [20:46:25] it eventually finishes [20:48:07] (CR) Cstone: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:48:48] Fundraising-Backlog: Fix jsonlint failure affecting CiviCRM CI Job - https://phabricator.wikimedia.org/T258224 (jgleeson) [20:49:11] Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog: Fix jsonlint failure affecting CiviCRM CI Job - https://phabricator.wikimedia.org/T258224 (jgleeson) [20:50:11] (PS1) Jgleeson: Fix jsonlint failure affecting CiviCRM CI Job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613284 (https://phabricator.wikimedia.org/T258224) [20:53:07] dstrine: I've added and pulled this ticket into sprint as it was a one-line-wonder fix https://phabricator.wikimedia.org/T258224 bugging us [20:53:18] straight to review [20:53:29] ok [20:54:12] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [20:54:46] how kind of angular to support non-valid JSON? :/ [20:54:57] (CR) Cstone: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [21:01:13] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/613258 (owner: Cstone) [21:01:39] (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧ [21:01:51] :):) [21:02:08] fighting with CI is like pokemon battles [21:02:25] "...your move next JENKINS MAN" [21:02:45] and it faints and merges [21:02:47] linter is super effective [21:02:58] ha! [21:03:14] we got Pokemon Sun [21:03:22] nice! [21:03:35] although it's a little old for Oscar now. I've been playing it tho [21:03:53] what starter did you go with [21:04:12] rowlet is the only right answer [21:04:40] yes Rowlet is awesome [21:04:59] y'all are awesome -- https://bash.toolforge.org/quip/rFdxWXMBLkHzneNNhMXU [21:05:29] :) [21:06:11] haha [21:08:28] !log payments-wiki revision changed from 91852dbc9b to bf91f8adff [21:08:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:14:43] Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog: Payments Wiki form variant w/ PAN field explanation text - https://phabricator.wikimedia.org/T257844 (Cstone) @spatton This has been deployed at `variant=panExplain` [21:20:25] Wikimedia-Fundraising-Banners: QA: Orange Mobile large banners - https://phabricator.wikimedia.org/T257850 (jbolorinos-ctr) Hey @TSkaff, sure feel free to bump the priority when needed (I think I will get a notification for that too when you do). Screenshot Test Results Mobile: - Orange banner with orange... [21:20:32] i just found a could of metrics that we are set to alert on with icinga that we don't track in prometheus: recurring_gc_failures_missed recurring_gc_schedule_sanity missing_thank_yous recurring_gc_jobs_required [21:20:56] i'm going to add them for collection as i look at adding in the civicrm_contribution_recur metric. [21:21:12] i'm wondering if there are more about that we would want to capture. [21:25:31] dwisehaupt: just the # that we charge each day would be interesting [21:26:25] what i'm writing is similar to our nagios checker, so i could drop in any query that spits out a number and we can store it as a metric. [21:26:48] are they just globalcollect? cause that job is turned off for the transition [21:27:07] this would probably run every minute. [21:27:12] cstone we could group by gateway [21:27:44] dwisehaupt: every minute seems excessive for these recurring checks [21:27:51] yeah # per day and gateway would be interesting [21:28:05] even once a day might be enough - can you schedule checks that infrequently? [21:28:33] or is it a question of making the graph have enough data points to look good [21:29:13] ? [21:29:32] it's more the later. if we only graph one point a day it gets odd. [21:29:50] as long as the queries are lightweight, it's ok to run them every minute. [21:31:00] we could also store them less frequently and reference them as a panel which would just show the latest value. [21:31:08] which may make more sense for some of these. [21:31:42] kind of like what you see at the top of this: https://frmon.frdev.wikimedia.org/d/000000273/mysql?orgId=1 [21:31:50] hmm, yeah, so for the nightly ones we do see significant variation from one day to the next [21:32:04] the really interesting metric is how much it changes from the same day last month [21:32:25] the smashpig ones are usually done by like 8-9 eastern do the paypal ones follow a schedule? [21:32:31] or whenever paypal deems it? [21:32:40] 8-9am [21:34:19] ejegg: yeah. we can overlay graphs like that. [21:35:07] i know i had a time shifted one around. let me see if i can find it. [21:36:10] https://frmon.frdev.wikimedia.org/d/EEWLlH-Zk/logging?viewPanel=2&orgId=1 [21:36:31] that should show logging with 1 day and 1 week overlays. [21:36:46] but you could do them at any time period. [21:37:03] so hmm, for this one we don't care about '30 days ago' - we care about the diff from the same day-of-month last month [21:38:19] I'm sure we can do that in SQL, it'll just be verbose [21:38:55] yeah. that graph is just using the offset, which is a simple counter logic. [21:39:07] then we should also ignore big variations at the end of months that have different nubmers of days than the previous month [21:39:40] so e.g. 28th of feb should have like 3x the number of donations as 28th Jan [21:39:43] I think [21:41:47] i think superset may be a better use for some things like that (not that i'm super versed in superset and it's capabilities) [22:01:03] (PS2) Huji: Remove IE 6 & 7 hasLayout hacks [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/613229 (https://phabricator.wikimedia.org/T258199) [22:17:28] "if you don't remember where you've been then it's new and exciting the next time you go there." [22:17:45] kid logic++ [22:18:31] Wikimedia-Fundraising-Banners: QA: Orange Mobile large banners - https://phabricator.wikimedia.org/T257850 (jbolorinos-ctr) [22:18:35] Wikimedia-Fundraising-Banners: [Candidate] NL Banners (Duplicate of Asana task) - https://phabricator.wikimedia.org/T255833 (jbolorinos-ctr) [22:24:53] Wikimedia-Fundraising-Banners: [M Lg] Low contrast on "We ask you, humbly, to help." text in Orange background w/ orange border - https://phabricator.wikimedia.org/T258230 (jbolorinos-ctr) [22:25:45] ejegg: it looks like promql does support month, day_of_month, and days_in_month. so it would be possible to get what you are looking for in a graph, but the query would probably get ugly to catch edge cases like comparing the 30th of march to something in february. [22:27:25] Wikimedia-Fundraising-Banners: [M Lg] Low contrast on "We ask you, humbly, to help." text in Orange background w/ orange border - https://phabricator.wikimedia.org/T258230 (jbolorinos-ctr) It also looks like this other variant has very low contrast on the same text - https://en.m.wikipedia.org/wiki/Apple?ban... [22:43:19] Wikimedia-Fundraising-Banners: [M Lg] Low contrast on "We ask you, humbly, to help." text in Orange background w/ orange border - https://phabricator.wikimedia.org/T258230 (scervantes) This comes directly from Control, so it's not related to this specific iteration(s). To add, the text and background do com... [22:49:53] (CR) Eileen: "jgleeson this is actually near the end - it switches from fully rebuilding the table to incrementally updated & adding new rows (the updat" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/612700 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [22:50:01] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 3 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaught... [22:53:34] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, and 3 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Eileenmcnaught...