[00:21:53] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Dedupe resolvable conflict -fix script to handle Casing with other things - https://phabricator.wikimedia.org/T242156 (Eileenmcnaughton) a:Eileenmcnaughton [00:24:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Proposal - restructure our repo to not use symlinks - https://phabricator.wikimedia.org/T258667 (Eileenmcnaughton) [00:37:57] (CR) Ejegg: [C: +2] "Nice, looks like all the code got moved over cleanly." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [00:38:08] thanks ejegg [00:38:24] I actually found quite a few functions to delete (in separate patches) [00:48:35] (Merged) jenkins-bot: Move diacritics resolve to the deduper extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613010 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [00:55:51] (CR) Eileen: MG sync: use API v4 to find organizations (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615262 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [00:56:55] (CR) Eileen: [C: +2] "Yep, more connsistent" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615261 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [00:59:07] (CR) jerkins-bot: [V: -1] Avoid warning when no 'online_resources' in MG sync [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615261 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [01:09:18] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615261 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [01:10:47] (CR) jerkins-bot: [V: -1] Avoid warning when no 'online_resources' in MG sync [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615261 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [01:10:55] Wikimedia-Fundraising-Banners: [Enhancement] Include all questions in a single view - https://phabricator.wikimedia.org/T258631 (Reedy) [01:23:34] (CR) Ejegg: [C: +2] "Looks good! New syntax for setting resolved value is so much clearer than the old arrays." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613016 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:24:51] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615261 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [01:25:02] zuul is a grumpy bum today [01:31:36] (Merged) jenkins-bot: Avoid warning when no 'online_resources' in MG sync [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615261 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [01:32:15] (CR) jerkins-bot: [V: -1] Move casing to deduper extennsion [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613016 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:33:02] timeouts? [01:40:17] (CR) Ejegg: [C: +2] "Recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613016 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:41:55] I guess so [01:42:02] (CR) jerkins-bot: [V: -1] Move casing to deduper extennsion [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613016 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:47:50] oh, it's that weird thing where it fails emailing the admin password to the drupal site [01:48:29] (CR) Ejegg: [C: +2] "Recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613016 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:50:09] (Merged) jenkins-bot: Move casing to deduper extennsion [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/613016 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:58:56] whew [02:23:26] finally huh [02:24:28] I think I just nailed the case + initial combo handling - but I can't push it up because it will put everything back into one review chain & I broke it out to make it easy to review in small chunks [02:26:36] actually maybe this patch can stand alone [02:28:11] (PS1) Eileen: Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) [02:28:23] ohh I thinnk it does [02:30:01] (CR) jerkins-bot: [V: -1] Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:33:04] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:35:56] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:38:50] hmm still that email thing causing fail [02:48:24] (CR) Eileen: [C: +2] Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:48:31] (CR) Eileen: Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:48:48] (CR) Eileen: "I meant to recheck not to +2" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:50:58] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:52:44] (CR) jerkins-bot: [V: -1] Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:57:11] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:59:05] (CR) jerkins-bot: [V: -1] Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [03:02:26] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [03:32:05] I'm gonna alter dedupe to schedule to benefit silverpop [03:38:33] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [04:21:17] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [04:26:02] (Abandoned) Eileen: Add index to log_civicrm_email.email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/606053 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [08:49:54] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [13:42:00] Fundraising-Backlog, fundraising Sprint Grep works IRL, MediaWiki-extensions-CentralNotice, Epic: EPIC: Find alternative to Special:HideBanners cookies to mitigate the loss of 3rd-party cookie support - https://phabricator.wikimedia.org/T244699 (Krinkle) [13:42:04] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hide banner cookie - https://phabricator.wikimedia.org/T251780 (Krinkle) Resolved→Open [13:45:21] Fundraising Sprint Octopus hugs, Fundraising-Backlog: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (mepps) From eileen re: silverpop export emails: The silverpop job & the dedupe job running at the same time cause ‘in-the-moment’ integrity issues - where a contact in the process of bei... [14:32:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: permission update needed for DS agent to Send Failure Notifications? - https://phabricator.wikimedia.org/T258651 (MBeat33) p:Triage→High Adri is currently blocked from taking on the task of following up with 700+ recurring donors due to th... [15:18:16] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, Fundraising-Backlog: Missing "unsubscribe" link in automatic recurring failure email - https://phabricator.wikimedia.org/T256162 (mepps) Open→Resolved Confirmed that... [15:40:46] howdy fr-tech! [15:41:15] jgleeson: hi! :) [15:41:20] hi jgleeson AndyRussG! [15:41:44] hi jgleeson AndyRussG [15:41:46] mepps: I just caught your email. [15:41:46] :) [15:42:04] do you mean the stuff I was chatting with Jeff_Green about yesterday? [15:42:16] if so yep! [15:42:18] jgleeson you mentioned in your end of day you'd been looking at deadlocks [15:42:27] so yeah probably the same [15:42:32] yep [15:42:39] no idea what caused them tho [15:42:47] i'm just trying to keep on top of failmail for chores, it's definitely one of my shortcomings that i tend to tune them out [15:42:53] or what specific query [15:43:11] there's lots of interesting stuff in the fundraisingdb-misc log [15:43:35] but you have to be a mysql forensic investigator to make sense of it [15:44:01] yeah jgleeson logs can give me a bit of a headache but they're kind of fun too [15:44:36] hi fr-tech! [15:44:43] hi ejegg! [15:44:47] hi1 [15:44:56] s/1/!/ [15:44:58] jgleeson: mepps did you see this task eileen made on it? https://phabricator.wikimedia.org/T258661 [15:45:16] wouldn't if be good if 's//' actually worked! [15:45:20] on irc [15:45:22] oh good catch cstone! [15:45:41] oh no I didn't cstone [15:46:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spate of database contention - https://phabricator.wikimedia.org/T258661 (mepps) Thanks @Eileenmcnaughton! [16:03:59] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, and 4 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (me... [16:06:23] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, and 4 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (me... [16:17:13] fr-tech do we need to be on the VPN to use dlocal sandbox details locally? [16:18:45] cstone: when you were PANning did you put through any test donations? [16:19:02] jgleeson: I didn't as it was just making the text appear on the variant [16:19:21] ah no worries [16:19:35] fr-tech heyyy another help question here, now for e-mail export... if when running the export script on vagrant, it says: "Table 'civicrm.log_civicrm_email' doesn't exist" [16:19:50] and there is no such table in the db on vagrant [16:19:55] does that mean I need to turn on logging? [16:19:59] silverpop export AndyRussG ? [16:20:05] or mg ext [16:20:05] jgleeson: yep! [16:20:08] silverpop [16:20:23] whell actually now I'm not sure if the same script doesn't do both? [16:20:47] sorry my mixup. No emails involved in the mg extention [16:20:57] definitely silverpop! [16:21:00] (PS1) Mepps: WIP start new delete queries for emails [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) [16:21:07] hmm I don't remember running into that [16:21:25] lemme check [16:21:39] maybe it's part of the recent changes? [16:21:42] thanks!!!! [16:22:14] (CR) jerkins-bot: [V: -1] WIP start new delete queries for emails [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [16:22:33] ok I see it now [16:22:44] hmmm not sure why you wouldn't have that tbl AndyRussG [16:23:25] I feel like that should be there from the off [16:23:34] when puppet builds out the crm role [16:24:16] jgleeson: hmmm all the tables in my civicrm database on vagrant start with civicrm or wmf (just two of the latter) [16:24:27] oh rly [16:24:43] so you've not got any civicrm.log_* [16:24:46] interesting [16:26:09] oh actually AndyRussG you wrote "start with civicrm" so you might have other civicrm.log_* tables? [16:29:36] jgleeson: no... I mean that's just the database name, no? Also, I just checked on frdev1001, there are definitely a lot of tables there that I don't have in vagrant [16:30:05] yeah the log_tables are on the civicrm db [16:30:16] so if you're not seeing any log_* tables something is up [16:30:28] yeah including the one that the e-mail export wants [16:30:31] how long ago did you build your vagrant vm [16:31:04] eh it's been a while since initial build, though I've re-provisioned it recently, when I added mailcatcher [16:31:44] AndyRussG: it looks like the logging is a core civicrm feature so maybe you need to build civicrm again? https://docs.civicrm.org/sysadmin/en/latest/setup/logging/ [16:31:59] might save some headaches along the way [16:35:52] mepps: ejegg standup? [16:36:10] ack, be right there [16:36:39] mepps: you around for standup? [17:05:30] argh looks like I'm still getting invalid credentials for dlocal while on the vpn [17:05:38] hmm [17:06:04] maybe the credentials need resetting? [17:06:16] I'll dig in after dinner [17:13:33] dstrine sorry not sure i missed the pings--i was sitting here and just spaced on it [17:13:45] i meant not sure how i missed the pings [17:20:03] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, and 4 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (me... [17:21:20] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) a:mepps I'm going to look at the drush task a little. [18:02:41] jgleeson|dinner: I just tried with dlocal locally and it is just hanging for me is that what you saw? [18:08:51] cstone: no I was getting a response back from the api saying invalid credentials [18:09:02] I'm gonna check which ones are getting passed through [18:10:41] on an unrelated note I don't know why I eat spicy food knowing full well I can't handle it [18:12:40] jgleeson: I get this back RETURNED FROM CURL:HTTP/1.1 200 OK Server: Reblaze Secure Web Gateway Date: but then it doesnt move further [18:15:52] sorry cstone I got distracted talking about charging a royalty to the core platform team for sharing our sprint naming technique with them. I'll go back to what I should be doing now and test dlocal [18:17:03] no worries i was also reading that haha [18:25:09] cstone: I see the REBLAZE! header [18:25:14] but I also see {"status":"1","desc":"Invalid credentials","error_code":"401"} [18:25:22] in the response body [18:26:23] i am seeing Raw Response:{"status":"0","link":"https:\/\/sandbox.dlocal.com\/collect\/pay?id=M-577587bb-e4ed-4b87-9cca-a39116adc3b9&version=1. [18:26:23] 1&xtid=CATH-ST-1595526878-1428691782","local_amount":"500.00","usd_amount":"6.21","local_currency":"INR","x_document":"99583701","amount_to_deposit":"500.00"} [18:29:12] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) One noticing: "masters" and "slaves" is used which is connected to a history of slavery and has been overwritten in newe... [18:39:43] (PS2) Jgleeson: WIP make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) (owner: Ejegg) [18:41:05] (PS2) Mepps: WIP start new delete queries for emails [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) [18:41:49] (CR) jerkins-bot: [V: -1] WIP start new delete queries for emails [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [18:49:40] (CR) jerkins-bot: [V: -1] WIP make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) (owner: Ejegg) [18:59:39] cstone: I just thought were you on the vpn when testing dlocal earlier? [19:00:02] yeah [19:00:51] fr-tech I don't seem to have access details for the dlocal test console. Do folks know how I get those? [19:03:55] hmm I don't think I've been in that console [19:28:11] jgleeson let me see [19:28:29] sandbox.dlocal.com [19:29:05] will hmm, no, that's just where the API calls go? [19:29:50] ah, looks like both live and sandbox console is via merchant.dlocal.com jgleeson [19:31:33] thanks ejegg [19:33:31] ejegg: fr-tech is there someone who can add an account for me on there? or maybe share a team one if thats how it works? I'm testing out a donation locally and it's failing due to invalid credentials and i'm using the credentials that are current on frpm1001 which I'm guessing might be out of date [19:33:56] actually you know what. I guess I could skip the donation part and just confirm the form values sent across look right [19:34:15] to unblock this particular task [19:34:32] ejegg: I'll do that and figure out the dlocal test api credentials another time [19:38:11] oops, checking to see if you have an account [19:38:28] ejegg: could you check for me too? [19:57:53] ejegg: me tooooo pls ;) [20:15:08] hey ejegg me too! [20:53:23] jgleeson if you want to hand off the PAN work to us, please feel free to! [20:53:24] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) Hmm so I got it all set up locally and I'm getting a different error on drush cvsqlc ` WD php: Error: Unsupported ope... [20:53:36] don't stay up too darn late for our sake [20:57:03] I'm just testing ejegg it looks good so far [20:57:11] got sidetracked a little messing with dlocal [20:57:46] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) It might drush versioning. Locally I'm running 7.0 and on prod it's 8.3.2. [20:59:12] the filed is marked optional but I'm still seeing validation warnings saying enter your PAN so tryna figure that out [20:59:18] field* [20:59:27] jgleeson where do you see those? [20:59:43] from our form, or from dlocal's API? [20:59:59] oh, I guess from our form, since we'd be sending the placeholder value [21:00:32] yep [21:00:55] looks like we validate that field elsewhere [21:01:57] shoot, I thought we had accounted for the optional-ness there [21:02:15] let's see what else we have put as optional [21:15:31] Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, Fundraising-Backlog, fundraising-tech-ops: map out a civicrm.log_% table data expiration/delete strategy - https://phabricator.wikimedia.org/T257232 (Jgreen) Testing on frdev1003/dev_civicrm, I wrote a script that creates... [21:23:01] (PS3) Jgleeson: WIP make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) (owner: Ejegg) [21:23:11] ejegg: I'm still looking but just in case you wanted to see [21:25:28] Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, Fundraising-Backlog, fundraising-tech-ops: map out a civicrm.log_% table data expiration/delete strategy - https://phabricator.wikimedia.org/T257232 (Eileenmcnaughton) The more I think about this the more I'd like to iden... [21:34:49] (CR) Eileen: "couple of minor comments" (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [21:37:36] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (Eileenmcnaughton) Ah yeah - that doesn't help [21:38:54] hmm interesting ejegg [21:39:29] it looks like the issue is due to the transformer being an instance of ClientSideValidationHelper [21:39:51] well I mean the class isn't [21:39:59] PlaceholderFiscalNumber [21:40:12] but something called FiscalNumber is [21:40:15] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/891e514cbf16bc55ca30b8c0ba5f612a2147e5db/gateway_common/gateway.adapter.php#L3873-L3872 [21:40:34] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (Eileenmcnaughton) Just a note that @Dwisehaupt worked on this & I believe the new credentials are in the civicrm.settings.php f... [21:41:45] ok [21:42:31] so becaue we're also listing the FiscalNumber transformer for astropay which implements ClientSideValidationHelper it's marking that field as required [21:42:36] when checking for required fields [21:42:48] I guess we never run into this when testing out the original optional field stuff [21:48:37] I guess we could extend that class and just skip the clientRules if the country is India for now until we add in full support for optional field behaviour on transformers that implement ClientSideValidation [21:48:56] I'll do that then at least we can get reviewing [21:49:10] and look at a more comprehensive solution afterwards [21:52:06] jgleeson maybe instead of skipping india, that field should check the config yaml to see if fiscal_number is listed as optional or required? [21:52:18] I think we can do that in a ValidationHelper [21:53:18] ejegg: it looks like the method called is this https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/82e1c7af062196e679b63183303b79a3efbe631a/gateway_common/FiscalNumber.php#L122 [21:53:59] I only see validate() in ValidationHelper [21:55:53] I'm not sure we can convenient access the config from within a transformer [21:56:43] I've gotta drop off soon so I'll push up my idea and let others refactor/improve if that works [21:57:06] thanks jgleeson! [21:57:07] it's not pretty I'll admit [21:57:28] I think I can get at that config using the GatewayType arg passed into validate [21:57:50] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (Dwisehaupt) @Eileenmcnaughton The civi_read user has had its password updated and I've ensured the grants across the main and s... [21:58:39] but ejegg the check doesn't happen in validate... or at least from what I can see [21:58:50] it happens in getClientSideValidation() [21:59:00] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/891e514cbf16bc55ca30b8c0ba5f612a2147e5db/gateway_common/gateway.adapter.php#L3872-L3871 [22:01:36] ahhh [22:01:40] ok then [22:07:22] so I guess we should maybe add the GatewayType arg to that call too? [22:07:42] because it definitely seems like we should be able to consult the config there [22:14:00] well my hack didn't fix the issue [22:14:02] :/ [22:14:47] (PS4) Jgleeson: WIP make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) (owner: Ejegg) [22:15:10] even when skipping on the Indian scenario it still shows the client-side message [22:15:18] so kinda scratching my head at this point [22:16:48] (PS5) Jgleeson: WIP make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) (owner: Ejegg) [22:17:25] (PS6) Jgleeson: WIP make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) (owner: Ejegg) [22:18:01] I always seem to be much better at finding spelling mistakes in comments immediately after submitting the patch [22:21:18] (CR) jerkins-bot: [V: -1] WIP make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) (owner: Ejegg) [22:22:37] heh, yeah, there's something about seeing it in the gerrit UI [22:22:52] OK, fr-tech I'll pick ^^^ up from there [22:23:50] fr-tech how about we make the GatewayType available to the getClientSideValidation function? [22:24:05] as a first param, to be consistent with the validate() param? [22:26:05] gl ejegg ! [22:26:17] thanks, have a good night! [22:28:24] (CR) Eileen: WIP start new delete queries for emails (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [22:28:43] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, and 4 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (Ei... [22:39:43] hows' things - looks like lots of activity here [22:40:52] dstrine: for the CN presentation for clinic duty, may I cite your stats about % of impressions for FR vs community? Also, if so, where could I find the latest version thereof? [22:51:01] (PS7) Ejegg: Make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) [22:51:24] fr-tech looks like there might have been a shortcut possible there ^^^ [22:51:39] as it was using a regex to validate the india PAN [22:51:53] I just made that regex accept an empty string as well [22:52:28] oh hmm [22:52:37] so that gets it past client-side validation [22:52:46] looks like server-side is now failing? [22:52:49] looking [22:58:45] ah hmm, we are making the request to dlocal [22:59:24] and it comes back with 'invalid param x_cpf' [22:59:26] :( [22:59:36] so are we sending it correctly? [22:59:55] with the placeholder value? [22:59:57] ejegg: i seem to think that when we submit to dlocal we have to put in a specific generic number if there is not PAN supplied. [23:00:21] checking to see if that's actually getting added with this patch [23:00:44] oh its not changed ejegg [23:01:08] the one they gave us was like AABB [23:01:15] ahaha! [23:01:21] okok, let's just fix that [23:01:28] it is sending the one that's in the code [23:04:07] Sweet, I think that was all! [23:04:51] (PS8) Ejegg: Make PAN optional for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/615546 (https://phabricator.wikimedia.org/T258086) [23:05:08] cstone: want to see if that works for you? ^^^ [23:05:42] I can try ejegg although earlier it was just hanging when i tried to load the form maybe its behaving now [23:05:55] oh darn [23:06:01] not stuck at a breakpoint? [23:06:30] it looked like that but no [23:07:23] fr-tech is anyone else around that can help review that patch? [23:07:34] We're hoping to deploy it tonight :S [23:08:01] hmm is there a special astropay queue i turned off [23:08:05] or dlocal [23:08:25] no, no dlocal-specific queue stuff needed I don't think [23:08:40] err, maybe they have an IPN jobs queue? [23:08:56] shouldn't need it to test this though [23:09:18] just trying to figure out why mine is just hanging [23:09:19] afaict if we get the redirect to their hosted card/bank form then it's working [23:10:18] I get this far [23:10:21] astropay_gateway: 2100000003:2100000003.1 Sending donor details for 2100000003.1 to pending queue [23:10:50] hmmm [23:10:55] do you have xdebug working? [23:11:06] can you see where it stops executing? [23:11:35] i think i did just get it working on the front end where would be a good breakpoint for catching when i click on a payment method? [23:11:45] fundraising-tech-ops, Patch-For-Review: Bugfix for get_lock() function on fran1001 inserts - https://phabricator.wikimedia.org/T258454 (Dwisehaupt) Updated the lock code and pushed it up for review. [23:13:02] fundraising-tech-ops: Add logging and lockfiles to fr analytics scripts where needed - https://phabricator.wikimedia.org/T256924 (Dwisehaupt) @eyener Is there more to do under this umbrella task or should we close it out and address new issues on new tasks? [23:13:27] nevermind got it clicking failure [23:13:32] for the breakpoint [23:14:37] ak, cool [23:15:06] *ok [23:19:09] So I couldn't test with the old 'GNB' test bank for some reason [23:19:25] but when i try with 'Visa' it does redirect me to the hosted form [23:20:24] ok i was just going to ask what should happen when I click on visa? [23:29:04] cstone do you get redirected? [23:29:13] or does it freeze? [23:29:14] no thats where its hanging [23:29:34] i was wondering if i was missing some credentials but what I had isnt whats in local settings [23:30:02] now I am getting an error at least of Raw Response:{"status":"1","desc":"Invalid credentials","error_code":"401"} which is what jgleeson|away saw earlier [23:30:10] oho, ok [23:30:12] lemme check mine [23:30:20] against what's up on frpm [23:30:25] cool thanks