[00:00:28] (CR) Ejegg: "Recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615262 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [00:00:49] (PS6) Mepps: WIP start new delete queries for emails [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) [00:05:15] ejegg: I don't think the suffix overwrite is in that code - we ALSO have code in wmf_civicrm.module that just resolves conflicts by keeping the most recent donor & that part seems to be to blame - I'm trying to unravel to the point of dealing with that code as somewhere in there is one or more bugs that I'm trying to track down [00:06:56] (CR) Eileen: [C: +2] "Looks good now - check permissions is actually OK in prod as drush has a user - but I think it's also logical that this look up is not per" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615262 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [00:07:21] eileen I'm running the new MergeConflictTest - shouldn't that be unsullied by what happens in wmf_civicrm? [00:07:38] not if wmf_civicrm.module is enaabled [00:07:47] because it implements the hooks too [00:07:52] oh dang [00:08:10] yeah - it's all very confusing [00:08:45] that explains why I didn't see it hit the breakpoint in that function that you renamed [00:11:43] yeah... [00:12:54] oh ok, now I DO see it getting there [00:16:05] (Merged) jenkins-bot: MG sync: use API v4 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615262 (https://phabricator.wikimedia.org/T257963) (owner: Ejegg) [00:16:18] eileen ok, it's not wmf_civicrm interference [00:16:45] it really is that hasSamePostalCodeButOneSuffixIsEmpty returning TRUE when one has suffix 9999 and the other 6666 [00:16:51] oh really? Hmm - I tried a test & couldn't get there - where is it [00:16:53] hmm [00:17:17] I put an @group MergeConflict just on the single test [00:17:28] and a breakpoint at the start of the hasSamePostalCodeButOneSuffixIsEmpty fn [00:17:43] and ran phpunit --group MergeConflict [00:18:56] it's that last condition - if one ?? '' === other ?? '' it returns false [00:19:02] otherwise it falls back to TRUE [00:19:11] in the case when they are inequal [00:20:10] I think maybe replace the last condition with a check that exactly one is empty [00:23:07] Fundraising-Backlog: Delays in transaction completion for India - https://phabricator.wikimedia.org/T259195 (EMartin) I looked through the ZenDesk tickets that DS has shared. I observe: - All tickets say they are waiting on confirmation but they are responding to Katherine's email saying they didn't get a... [00:28:38] (PS6) Eileen: Move handling & test of postal code suffix pseudo-conflict to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616702 (https://phabricator.wikimedia.org/T256316) [00:28:47] ejegg: I think that fixes it then [00:29:10] looking [00:30:56] eileen: hmm, that's not quite it [00:31:12] setting a couple of unused vars [00:31:46] (PS7) Eileen: Move handling & test of postal code suffix pseudo-conflict to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616702 (https://phabricator.wikimedia.org/T256316) [00:31:57] ah yeah - I changed my mind about them - gone! [00:33:06] so that still returns true when one suffix is 6666 and the other is 7777 [00:33:50] can you just count how many are empty and return true if it's 1 ? [00:35:50] why wouldn't this catch that? empty($mainBlock['postal_code_suffix']) && !empty($otherBlock['postal_code_suffix'] [00:36:16] oh derp [00:36:17] sorry [00:36:19] - I thought you +2 d this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/616701 [00:36:20] I misread that [00:36:31] OK, that DOES work [00:36:46] oh shoot, I thought I +2ed it too [00:36:53] (CR) Ejegg: [C: +2] Use mergehandler to get preferred donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616701 (owner: Eileen) [00:37:03] (CR) Mepps: "Yay Eileen build passing!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [00:37:26] (PS8) Ejegg: Move handling & test of postal code suffix pseudo-conflict to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616702 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [00:38:26] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616702 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [00:40:46] now we just need zuul to kick in [00:41:33] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616701 (owner: Eileen) [00:42:51] (PS3) Ejegg: Move test for handling country only to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616964 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [00:43:22] (CR) Ejegg: [C: +2] Move test for handling country only to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616964 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [00:47:15] we are still hitting issues around duplicate locations winding up messing up merges [00:47:27] The code we have doesn't always work :-( [00:47:32] (Merged) jenkins-bot: Use mergehandler to get preferred donor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616701 (owner: Eileen) [00:48:39] (Abandoned) Eileen: Test & fix get in MG apiv4 conversion [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617290 (owner: Eileen) [00:48:59] (PS4) Eileen: Move handling for country only to the deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616965 (https://phabricator.wikimedia.org/T256316) [00:49:08] eileen I'm looking at the old _wmf_civicrm_is_this_address_better vs the mergeHandler's getAllAddressConflicts [00:49:19] and I see there are a few more ignored keys in the old code [00:49:55] reset_date hold_date display location_type_id [00:50:14] are those intentionally not ignored in the new code? [00:50:47] so reset_date & hold_date are part of email & we don't need them for address [00:50:50] ok [00:51:00] display is this concatenation of other fields [00:51:06] aha, I see getEmailConflicts is other code [00:51:23] ok, so if display is mismatching it's a conflict [00:51:24] & location is kind of implicitly the same here [00:51:29] right [00:51:39] even though it's just a symptom of other underlying conflicts [00:51:46] which is why it's kinda flakely but it also kinda makes sense [00:52:18] ok, cool [00:52:31] the 'good' side is that if we have say one person in Paris & the other in Paris US display makes that a conflict [00:53:01] whereas the individual fields are not [00:54:31] yep [00:54:36] (Abandoned) Eileen: [POC] Incrementally introduce namespacing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/592759 (https://phabricator.wikimedia.org/T133969) (owner: Awight) [00:54:58] (Abandoned) Eileen: Japanese TY email and Subject Line files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/569616 (owner: Cdenes) [00:59:51] (PS1) Eileen: Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 [01:00:25] (PS2) Eileen: Comment blocks cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617277 [01:02:41] (CR) Eileen: "mepps - does it still pass over the top of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/616948 - I think there is still " [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [01:06:22] (CR) jerkins-bot: [V: -1] Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [01:12:55] (PS2) Eileen: Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 [01:17:02] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/617297 [01:17:52] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/617297 (owner: Eileen) [01:19:34] (CR) jerkins-bot: [V: -1] Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [01:20:34] (CR) Ejegg: [C: +2] "All moving in the right direction!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616965 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:21:03] thanks ejegg I know it's hard going! [01:21:30] (CR) jerkins-bot: [V: -1] Move handling for country only to the deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616965 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:22:36] (CR) Ejegg: [C: +2] Comment blocks cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617277 (owner: Eileen) [01:23:28] this one is also just comments - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/615327 [01:29:19] (Merged) jenkins-bot: Move handling for country only to the deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/616965 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:29:21] (Merged) jenkins-bot: Comment blocks cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617277 (owner: Eileen) [01:30:03] (PS3) Ejegg: Comment fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615327 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:30:19] (CR) Ejegg: [C: +2] Comment fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615327 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:30:22] (PS3) Eileen: Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 [01:31:05] ejegg: if you can face them there is one more meaty one & 2 that just remove functions [01:31:41] (CR) jerkins-bot: [V: -1] Comment fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615327 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:31:50] yep, you mean "Move handling of dismissing blank addresses to the resolver." ? [01:32:10] oh wait, that's WIP [01:32:14] well I'll take another look at that [01:32:37] I want to just think a bit more on it - but this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/615591 [01:32:45] looking [01:34:01] the blank address one - I'm not sure if it is still a thing & I am going to see about a core fix anyway - https://github.com/civicrm/civicrm-core/pull/17993 - but I figured some stuff out in the process [01:34:23] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/617297 (owner: Eileen) [01:34:45] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615327 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [01:37:35] !log civicrm revision changed from cc5d17fbaf to 150c3476c4, config revision is b6ece03513 [01:37:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:37:48] (CR) jerkins-bot: [V: -1] Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [01:43:07] (PS4) Eileen: Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 [01:45:26] (CR) jerkins-bot: [V: -1] Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [01:48:40] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [01:52:53] (CR) Ejegg: "Code looks good, but I think the fn comment is misleading" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [01:54:15] (PS5) Eileen: Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 [01:55:32] (PS2) Eileen: Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) [01:56:06] thanks ejegg I've done a a fix - just checking the dedupe job fail on live post-deploy of the others [01:57:40] (CR) jerkins-bot: [V: -1] Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [01:59:25] hmm - that was a bit odd - I resaved the settings & it's OK... [01:59:48] huh [02:00:36] yeah the settting deduper_resolver_preferred_contact_resolution was showing as a string not an array [02:00:53] I installed that shell extension so some sort of flush [02:01:05] heh, just noticed that resolver will prefer Mcnaughton over McNaughton [02:01:22] I guess a list of special cases could be added [02:02:08] yeah - but it's choosing one of 2 things that a contact entered [02:02:16] (CR) jerkins-bot: [V: -1] Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [02:02:30] anyone with an McN name will enter it right themselves :-) [02:03:32] (PS3) Ejegg: Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:03:43] (CR) Ejegg: [C: +2] Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:05:44] k, looking at those fn removals [02:08:08] cool - there are more in the file - if you feel like looking for them & putting up a PR I can review those (ie. swap hats) - but probably late there now [02:08:45] (PS3) Ejegg: Remove unused function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615328 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [02:08:56] (PS6) Eileen: Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 [02:08:58] (CR) Ejegg: [C: +2] Remove unused function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615328 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [02:09:15] yep it is getting late [02:10:18] (Merged) jenkins-bot: Fix Casing handling to replace by word, allowing case+initial combos [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615591 (https://phabricator.wikimedia.org/T242156) (owner: Eileen) [02:10:48] (CR) jerkins-bot: [V: -1] Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [02:14:07] (PS4) Ejegg: Remove unused function civicrm_option_group_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615329 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [02:15:46] (PS7) Eileen: Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 [02:16:02] (Merged) jenkins-bot: Remove unused function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615328 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [02:16:37] k, see you later! [02:16:47] I'll test the MG sync again tomorrow [02:22:40] (CR) jerkins-bot: [V: -1] Add check to ensure all tests based on BaseChecksFileTest delete contacts at the end [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617295 (owner: Eileen) [03:05:50] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: permission update needed for DS agent to Send Failure Notifications? - https://phabricator.wikimedia.org/T258651 (Eileenmcnaughton) @SHust can you re-test? [06:41:58] Fundraising-Backlog: New logo for Paytm - https://phabricator.wikimedia.org/T259130 (scervantes) @spatton created a set of banners where I could replace the logo, here they are for reference, all of them have the good logo. Also attaching the logo in SVG ready for use if fr-tech needs it for payments wiki.... [13:56:31] Fundraising-Backlog: Bug: Error in Ingenico Orphan Slayer - https://phabricator.wikimedia.org/T259251 (mepps) [13:57:02] (CR) Ejegg: [C: +2] Remove unused function civicrm_option_group_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615329 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [13:59:12] Fundraising-Backlog: Bug: Error in Ingenico Orphan Slayer - https://phabricator.wikimedia.org/T259251 (mepps) See failmail for more info. [14:00:42] Fundraising-Backlog: Adyen message in queue without pending entry - https://phabricator.wikimedia.org/T259253 (mepps) [14:04:06] Fundraising-Backlog: Bug: Error in Ingenico Orphan Slayer - https://phabricator.wikimedia.org/T259251 (Ejegg) Ah, we're hitting that code path because the orphan rectifier is doing minfraud queries, the balance is low, and it's using memcache to determine whether it recently sent a warning email. [14:04:13] (Merged) jenkins-bot: Remove unused function civicrm_option_group_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/615329 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [14:08:44] (PS1) Ejegg: Delete more unused functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617474 [14:40:15] Fundraising-Backlog: Recurring contributions left in "processing" - https://phabricator.wikimedia.org/T259257 (mepps) [14:45:59] (Abandoned) Mepps: Use readonly db for drush cvsqlc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617270 (https://phabricator.wikimedia.org/T237350) (owner: Mepps) [14:53:02] Wikimedia-Fundraising-Banners: [Enhancement] Move Desktop Small banner all the way to the top of the page - https://phabricator.wikimedia.org/T259258 (jbolorinos-ctr) [14:54:48] Fundraising-Backlog: Recurring contributions left in "processing" - https://phabricator.wikimedia.org/T259257 (mepps) From irc: <@cstone> Christine mepps ejegg Jeff_Green the alerts are from me I didn't realize the threshold was 5, there's 5 old to news sitting at processing @Jeff_Green will be changing the... [15:00:46] (PS1) Ejegg: Allow disabling log streams by type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617483 [15:01:12] mepps ^^^ should let us at least turn off the double-failmail in CRM queue consumers [15:01:16] (CR) jerkins-bot: [V: -1] Allow disabling log streams by type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617483 (owner: Ejegg) [15:03:16] (PS2) Ejegg: Allow disabling log streams by type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617483 [15:12:23] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: permission update needed for DS agent to Send Failure Notifications? - https://phabricator.wikimedia.org/T258651 (SHust) @Eileenmcnaughton , Adri was able to send the Failure Notice. Thank you! [15:12:37] Fundraising-Backlog: Recurring contributions left in "processing" - https://phabricator.wikimedia.org/T259257 (mepps) Actually @Jeff_Green will just make it daily with the current threshold based on irc discussion. [15:13:51] Fundraising-Backlog: New logo for Paytm - https://phabricator.wikimedia.org/T259130 (spatton) Thank you @scervantes! @jbolorinos-ctr, could you run a screenshot test on each of these variants, verifying that the bank transfer payment method (with the updated Paytm logo) behaves as expected across devices?... [15:23:21] Fundraising-Backlog: Get fr-tech folks set up with icinga access and familiarized on 'ack'-ing alerts - https://phabricator.wikimedia.org/T259259 (Jgreen) [15:27:36] ejegg: I moved away from quieting them down via that route but I guess that's a patch that could be useful in the future also [15:30:27] Fundraising Sprint Octopus hugs, Fundraising-Backlog: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (mepps) a:mepps→None I've focused this sprint on failmail and alerts. Today, I created these tasks: https://phabricator.wikimedia.org/T259257, https://phabricator.wikimedia.org/T... [15:31:58] Fundraising-Backlog: Recurring contributions left in "processing" - https://phabricator.wikimedia.org/T259257 (mepps) @Jeff_Green feel free to update this task with any concerns. @cstone is going to handle the recurring contributions left in processing. [15:46:35] Fundraising-Backlog: Upgrade drush in vagrant - https://phabricator.wikimedia.org/T259260 (Aklapper) @mepps: Assuming this task is for the #Fundraising-Backlog project, hence adding that project tag so other people can also find this task when searching via projects. Please correct if I'm wrong. Thanks! [15:49:19] Wikimedia-Fundraising-Banners: [BETA] QA for new payment logo PayTM variants - https://phabricator.wikimedia.org/T259262 (jbolorinos-ctr) [15:51:57] Wikimedia-Fundraising-Banners: [BETA] QA for new payment logo PayTM variants - https://phabricator.wikimedia.org/T259262 (jbolorinos-ctr) Screenshot Test Results: - Desktop Large: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z3588c7a38f9b8932a10 - Desktop Small: https://app.crossbr... [15:54:13] Fundraising-Backlog: New logo for Paytm - https://phabricator.wikimedia.org/T259130 (jbolorinos-ctr) Hey @scervantes I created this separate QA task for testing these variants - T259262 - I'll create subtasks there for any bugs I find, and feel free to just reach out if you have any questions! [15:59:46] (CR) Mepps: "Yes eileen that's how I got it passing." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [16:01:50] Wikimedia-Fundraising-Banners: [BETA] QA for new payment logo PayTM variants - https://phabricator.wikimedia.org/T259262 (jbolorinos-ctr) Only issue to report so far is the minor bug affecting Safari 9.0 - T250094 [16:13:50] (CR) Mepps: "Hmm I'm trying to test this query on dev_civicrm and for some reason nothing is happening. There's only three ids in the deleted email col" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [16:14:45] (PS7) Mepps: WIP start new delete queries for emails [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) [16:15:29] (CR) Mepps: "This query took a weirdly long time on staging for three rows." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [16:18:02] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) Hmm I bet we could overwrite this function: drush_convert_db_from_db_url but the question is where... [16:18:53] Fundraising-Backlog: Upgrade drush in vagrant - https://phabricator.wikimedia.org/T259260 (mepps) @Aklapper not wrong--I thought I'd added it. Thanks! [16:31:20] fr-tech dstrine and I are in a call w/dlocal [16:32:00] ejegg and dstrine should we wait for you or start? [16:33:11] mepps: maybe be a bit we'll be there soon. I have some prioritization info for today [16:33:57] AndyRussG meeting? [16:46:31] Fundraising Sprint Octopus hugs, Fundraising-Backlog: New logo for Paytm - https://phabricator.wikimedia.org/T259130 (DStrine) [16:51:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Acoustic domain rollout - Change URLs - https://phabricator.wikimedia.org/T255692 (CCogdill_WMF) Just adding a little more info from Acoustic--it seems like the API calls we're using with the old URLs are related to GDPR. This could potentially be p... [16:52:00] Fundraising Sprint Octopus hugs, Fundraising-Backlog, FR-Ingenico: Japanese donors seeing errors on week of July 27th - https://phabricator.wikimedia.org/T259070 (mepps) From @krobinson on the original task 7/28: > We have seen more donors reporting this again after today's email send. A handful o... [16:55:32] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, and 4 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (me... [17:04:17] Fundraising Sprint Lazy Loading Life, Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, and 4 others: Q4 FY2019/20 investigate export and upload issues with the silverpop export - https://phabricator.wikimedia.org/T253152 (me... [17:12:31] Fundraising-Backlog, CommRel-Specialists-Support, Editing-team, Operations, and 9 others: RFC: Serve Main Page of Wikimedia wikis from a consistent URL - https://phabricator.wikimedia.org/T120085 (Elitre) Removing my team, I don't think there's anything for us here? [17:12:54] Fundraising-Backlog, Editing-team, Operations, Parsing-Team, and 8 others: RFC: Serve Main Page of Wikimedia wikis from a consistent URL - https://phabricator.wikimedia.org/T120085 (Elitre) [17:16:29] Wikimedia-Fundraising-Banners: Percentage and donation amount in copy appears bold in JP - https://phabricator.wikimedia.org/T259188 (Pcoombe) This isn't by design, there's no additional styling on those elements. I expect it's just down to what fonts are installed on your computer, this doesn't happen for m... [18:24:29] Wikimedia-Fundraising-Banners: Percentage and donation amount in copy appears bold in JP - https://phabricator.wikimedia.org/T259188 (jbolorinos-ctr) Oh I see, so nothing to worry about here then? Should I just go ahead and close this as invalid? [18:30:29] Fundraising-Backlog, Operations: New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (DStrine) Thanks all for discussing. Just for context, if we move back to our old Thank you pages, we will not be able to hid banners for people who have... [18:38:32] Fundraising-Backlog, fundraising-tech-ops: Package PrivateBin for FR-Tech hosts - https://phabricator.wikimedia.org/T255063 (RobH) [18:39:53] Fundraising Sprint Octopus hugs, Fundraising-Backlog, FR-Ingenico: Japanese donors seeing errors on week of July 27th - https://phabricator.wikimedia.org/T259070 (Ejegg) CID 11044678 has contribution tracking IDs 81690045 and 81690087, both of which show up in referrers in the logs for the TY page on... [18:40:29] Fundraising-Backlog, fundraising-tech-ops: Package PrivateBin for FR-Tech hosts - https://phabricator.wikimedia.org/T255063 (RobH) [18:43:52] Wikimedia-Fundraising-Banners: Percentage and donation amount in copy appears bold in JP - https://phabricator.wikimedia.org/T259188 (Pcoombe) I think so. [18:53:03] Wikimedia-Fundraising-Banners: [M sm] Uneven payment option buttons - https://phabricator.wikimedia.org/T259288 (jbolorinos-ctr) [18:58:24] Wikimedia-Fundraising-Banners: [M sm] Uneven payment option buttons - https://phabricator.wikimedia.org/T259288 (jbolorinos-ctr) p:Triage→Medium a:jbolorinos-ctr→None [18:59:10] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) So above, it is clear what's happening, but I'm unsure how to approach the solution. Basically re-... [19:00:33] Wikimedia-Fundraising-Banners: [M sm] Uneven payment option buttons - https://phabricator.wikimedia.org/T259288 (spatton) I believe this might be present in [[ https://en.m.wikipedia.org/wiki/Taj_Mahal?banner=B2021_072922_enIN_m_p2_sm_mnm_cnt&country=IN | control ]], too - could you confirm, John? [19:05:46] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) a:mepps→Eileenmcnaughton @Eileenmcnaughton with me going on vacation, I'm hoping I've left... [19:39:45] Fundraising Sprint Octopus hugs, Fundraising-Backlog, FR-Ingenico: Japanese donors seeing errors on week of July 27th - https://phabricator.wikimedia.org/T259070 (Ejegg) The CID with lots of retries apparently has the Wikipedia App installed, and it's hijacking the request to donate.wikipedia.org but... [20:08:23] Wikimedia-Fundraising-Banners: QA for en6C pre-test on August 5, 2020 - https://phabricator.wikimedia.org/T259297 (spatton) [20:14:14] Wikimedia-Fundraising-Banners: 2020-08-05 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T259298 (spatton) [20:14:16] Fundraising-Backlog, Operations: New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (Ejegg) It looks like our apps are hijacking all requests to *.wikipedia.org and trying to load the pages via the rest API. Can we also have restbase ins... [20:18:08] Wikimedia-Fundraising-Banners: [BETA] QA for new payment logo PayTM variants - https://phabricator.wikimedia.org/T259262 (jbolorinos-ctr) {F31954863} [22:03:36] Fundraising-Backlog, Operations: New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (Ejegg) Requested restbase for donate.wiki[mp]edia.org here: T259309 [22:03:46] Fundraising-Backlog: Recurring contributions left in "processing" - https://phabricator.wikimedia.org/T259257 (Cstone) I updated the statuses of the 5 stuck from old to to new, so there are currently 0 with status=processing [22:12:58] Wikimedia-Fundraising-Banners: 2020-08-05 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T259310 (spatton) [22:14:37] Wikimedia-Fundraising-Banners: 2020-08-05 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T259298 (spatton) [22:26:29] Fundraising-Backlog, Android-app-Bugs, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (Ejegg) [22:26:40] Fundraising-Backlog, Android-app-Bugs, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (Ejegg) [22:35:23] Fundraising-Backlog, Platform Engineering: add RESTBase to donate wiki - https://phabricator.wikimedia.org/T259309 (Ejegg) [22:40:04] ok, retrying the matching gifts sync [22:43:02] first run worked! [22:43:17] I'll line up 11 more to clear out the updates from that first seach [23:04:54] Fundraising-Backlog, Android-app-Bugs, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (JMinor) I'd prefer to make the Thanks page work in the app, but besides sounding like the harder alte... [23:05:50] Fundraising-Backlog, Android-app-Bugs, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (JMinor) p:Triage→High [23:25:45] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) Ooh I thought of another options! We could create a setting to hold the db array and then civicrm.... [23:30:07] (PS1) Mepps: Get db_array from settings for rpow [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/617560 (https://phabricator.wikimedia.org/T237350) [23:32:10] (CR) jerkins-bot: [V: -1] Get db_array from settings for rpow [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/617560 (https://phabricator.wikimedia.org/T237350) (owner: Mepps) [23:40:37] (PS2) Mepps: Get db_array from settings for rpow [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/617560 (https://phabricator.wikimedia.org/T237350) [23:49:46] (PS1) Mepps: Create setting cli_db_url for drush [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617562 (https://phabricator.wikimedia.org/T237350) [23:51:09] Fundraising Sprint Octopus hugs, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (mepps) Okay moving to review because I put a lot of the pieces up. The civi patch will have to be upstrea... [23:57:52] (PS2) Mepps: Create setting cli_db_url for drush [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617562 (https://phabricator.wikimedia.org/T237350) [23:59:30] (PS3) Mepps: Create setting cli_db_url for drush [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/617562 (https://phabricator.wikimedia.org/T237350)