[00:04:16] (PS8) Eileen: Use privacy delete email ids from the new table to ensure they are culled from export_staging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [00:04:22] (CR) Eileen: [C: +2] Use privacy delete email ids from the new table to ensure they are culled from export_staging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [00:05:10] (Merged) jenkins-bot: Use privacy delete email ids from the new table to ensure they are culled from export_staging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/615794 (https://phabricator.wikimedia.org/T253152) (owner: Mepps) [00:08:07] cstone: can you +2 this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/618408 - I can't see why the next one is failing test [00:22:12] got it eileen [00:22:28] (CR) Cstone: [C: +2] Copy edit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/618408 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [00:23:17] (Merged) jenkins-bot: Copy edit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/618408 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [01:02:40] thanks [01:30:49] (PS2) Eileen: Add code comments [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/618410 (https://phabricator.wikimedia.org/T253152) [01:31:33] (CR) jerkins-bot: [V: -1] Add code comments [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/618410 (https://phabricator.wikimedia.org/T253152) (owner: Eileen) [01:50:20] (PS1) Eileen: Drop foreign keys on acl cache tables. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) [01:52:22] (CR) jerkins-bot: [V: -1] Drop foreign keys on acl cache tables. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) (owner: Eileen) [01:56:25] (PS2) Eileen: Drop foreign keys on acl cache tables. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) [02:14:56] (PS3) Eileen: Drop foreign keys on acl cache tables. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) [02:15:29] Fundraising Sprint P 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Q2-FY2020-21-cleanup-list, Patch-For-Review: Remove foreign key in attempt to address Spate of database contention Deadlocks - https://phabricator.wikimedia.org/T258661 (Eileenmcnaughton) a:Eileenmcnaughton [03:06:27] (PS2) Eileen: Remove handling of email conflicts from custom code, handling in deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618168 (https://phabricator.wikimedia.org/T256316) [03:14:55] (CR) jerkins-bot: [V: -1] Remove handling of email conflicts from custom code, handling in deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618168 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [07:54:29] (PS1) Eileen: Minor test cleanup & add primary count check [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618484 (https://phabricator.wikimedia.org/T256316) [08:02:30] Wikimedia-Fundraising-Banners: Wikipedia fundraiser box show incorrect locality - https://phabricator.wikimedia.org/T259675 (Aklapper) [09:13:40] (CR) Awight: "> Patch Set 2:" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/618326 (owner: Awight) [09:36:19] (PS3) Awight: Migrate to a distutils package [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/618326 [09:36:36] (CR) Awight: "PS 3: manual rebase" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/618326 (owner: Awight) [10:06:34] Wikimedia-Fundraising-Banners: [M sm] India - Uneven payment option buttons at certain widths - https://phabricator.wikimedia.org/T259288 (Pcoombe) [14:58:54] Wikimedia-Fundraising-Banners: [M sm] India - Uneven payment option buttons at certain widths - https://phabricator.wikimedia.org/T259288 (jbolorinos-ctr) Thanks Peter! I'm going to just add this to the next phabricator meeting, so we can discuss more then, and just let me know if there's anymore information... [15:33:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-AutoTY-Email, fr-donorservices: Civi: send monthly transaction receipt to recurring donors - https://phabricator.wikimedia.org/T249863 (MBeat33) Open→Resolved a:MBeat33 Sticking w/initial receipt + annual summary [15:51:03] ejegg: I'm still running into some issues testing out your logStreamsPatch. I've tried pulling in smashpig to the existing civicrm/vendor dir a few ways as I think it might be autoloader related. I'm wonder if you've ran into anything similar when testing? https://phabricator.wikimedia.org/P12176 [15:51:26] jgleeson: oh, weird [15:51:29] lemme try again [15:52:06] so I just moved the existing wikimedia/smash-pig dir aside and symlinked my SmashPig folder in its place [15:52:31] ya i did the same [15:52:32] then in the wmf_common_create_smashpig_context [15:52:35] and that usually works [15:52:35] I added [15:52:47] Logger::removeLogStreamByType('SmashPig\Core\Logging\LogStreams\FailmailLogStream'); [15:53:06] Since there are no new classes, I'd be a bit surprised to see it being autoloader related [15:53:09] hmmm so it looks like that error is also thrown even if I swithc to master so this is something to do with my local [15:53:22] what's the error? [15:53:32] it's in the first message [15:53:37] pastebin link [15:53:50] feels very autoloady [15:54:56] oooh [15:55:02] no, you know what that is? [15:55:19] that's the new type hinting [15:55:24] we need to loosen that up [15:55:51] ohhh [15:55:57] sorry! [15:56:39] I guess that's a reminder to upload my dev version of php? [15:57:40] hmm it looks like you added those changes in march this year.. have I not used smashpig in all that time :/? [15:58:36] ejegg: I feel like the issue is still on my side if the patch is working on CI and for you [15:59:03] it's failing in that specific case as self::$instance is null and not Context [15:59:24] so maybe a singleton init check being too strict or I've broken something lese [15:59:29] /lese/else/ [15:59:31] heh, no, I need to test better [15:59:49] and CI still doesn't have the updates [16:00:00] ah [16:01:23] (PS1) Ejegg: Undo overzealous typehinting [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/618544 [16:01:29] ok, ^^^ undoes it [16:01:31] brb [16:08:40] sorry about that jgleeson [16:10:24] no problem! [16:12:33] oh, lemme rebase the failmail fix over that [16:13:11] (PS3) Ejegg: Allow disabling log streams by type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617483 [16:14:43] hmm? local phpunit still hitting errors [16:14:52] Class 'Civi\Api4\Message' not found [16:15:10] ah, that's the new bit that eileen added [16:15:42] oh, and it needs the datastrings extension [16:15:47] just my local setup then [16:18:08] ok, but it does get past the context init and failmail log stream disable once both those smashpig changes are applied [16:18:45] and with the datastring extension install the rest of those tests pass [16:20:49] thanks ejegg I'm gonna jump back on that a little later [16:46:08] Fundraising-Backlog, Operations, User-Urbanecm, Wiki-Setup (Create): New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (DStrine) [16:48:41] Fundraising-Backlog, Operations, User-Urbanecm, Wiki-Setup (Create): New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (DStrine) @Ladsgroup thanks for the info. I have rewritten this task in the format you have recommended. Let... [17:18:05] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: Efficiency of querying views - https://phabricator.wikimedia.org/T259731 (EYener) [17:42:15] Fundraising-Backlog, Operations, User-Urbanecm, User-dancy, Wiki-Setup (Create): New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (dancy) [18:14:52] pcoombe I just thought of a wee complication with having donate.wikiPedia.org be a different project from donate.wikiMedia.org - it would be slightly less complicated ops & config-wise to make it thanks.wikiPedia.org [18:15:15] would that be OK from your team's point of view? [18:22:47] ejegg: yes, we were assuming it would be a new domain. thankyou.wikipedia.org would be great if possible [18:34:03] ok, thanks pcoombe ! [18:34:22] dstrine: I'll make some changes to the ticket [18:34:51] ejegg: ok do we need to tell the mobile teams this too? [18:35:07] they will need to make sure that doesn't get sent to the app too right? [18:35:18] Fundraising-Backlog, Operations, User-Urbanecm, User-dancy, Wiki-Setup (Create): New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (Ejegg) [18:36:46] dstrine: good call [18:36:59] I'll add thankyou.wikipedia.org to that ticket [18:37:05] ejegg: thanks! [18:38:03] Fundraising-Backlog, Android-app-Bugs, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-v6.7-Bonefish-On-A-Bus: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (Ejegg) [18:45:00] Fundraising-Backlog, fundraising-tech-ops: Setup civi access for Nikki Maller - https://phabricator.wikimedia.org/T259741 (jkim_wikimedia) [20:46:28] Hello [20:49:44] Users from Polish Wikipedia reported banner displays "równowartość Twojej kawy środę". It has invalid form of week day. Preferred are "kawy w środę", "środowej kawy" or better without week day. It needs to be changed for all week names. [20:54:45] ejegg: can I get you to check this - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/618421 - it's the patch I hope will reduce failmail.... [20:55:07] looking eileen [21:04:47] (CR) Ejegg: [C: +2] "Thanks, Eileen! Definitely worth a try." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) (owner: Eileen) [21:07:15] (CR) jerkins-bot: [V: -1] Drop foreign keys on acl cache tables. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) (owner: Eileen) [21:14:58] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) (owner: Eileen) [21:15:56] Fundraising-Backlog, Operations, User-Urbanecm, User-dancy, Wiki-Setup (Create): New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (Ladsgroup) >>! In T259002#6363413, @DStrine wrote: > @Ladsgroup thanks for the info. I have... [21:28:09] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/618421 (https://phabricator.wikimedia.org/T258661) (owner: Eileen) [21:55:48] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/618631 [21:56:27] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/618631 (owner: Eileen) [22:21:32] I think I've finally figured out how to deal with locations on merge. The thorny issues is data integrity - somehow we have contacts with duplicate locations - which winds up with merge issues. I'm switching to trying to do that cleanup earlier in the process & have an api for it [22:42:18] Fundraising-Backlog, fr-donorservices: India banner: extra decimals on Other amount field gets PTF riled up - https://phabricator.wikimedia.org/T259762 (MBeat33) [22:51:19] Fundraising Sprint P 2020, Fundraising-Backlog, fr-donorservices: India - Dlocal/Wikimedia message trigger inquiry - https://phabricator.wikimedia.org/T259631 (EMartin) Hi all, we have a meeting with Dlocal in the morning to discuss this. Would it be easier if someone from FRTech joined that call pe... [23:10:44] Fundraising-Backlog, fr-donorservices: India banner: extra decimals on Other amount field gets PTF riled up - https://phabricator.wikimedia.org/T259762 (DStrine) @spatton @TSkaff @Pcoombe FYI for banner bug [23:25:10] Fundraising-Backlog, fundraising-tech-ops: Setup civi access for Nikki Maller - https://phabricator.wikimedia.org/T259741 (Dwisehaupt) @jkim_wikimedia Sure thing. Could you please get her contact information added to our contact list? https://collab.wikimedia.org/wiki/Fundraising#Contact_List Once that... [23:27:25] Fundraising-Backlog, fundraising-tech-ops: Setup civi access for Nikki Maller - https://phabricator.wikimedia.org/T259741 (Dwisehaupt) [23:57:53] !log civicrm revision changed from 150c3476c4 to 72452e28a9, config revision is b6ece03513 [23:57:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:58:25] Fundraising-Backlog, fundraising-tech-ops: Setup civi access for Nikki Maller - https://phabricator.wikimedia.org/T259741 (jkim_wikimedia) @Dwisehaupt Added! Thank you!