[00:00:23] (Merged) jenkins-bot: Composer update -metadata only [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621366 (owner: Eileen) [00:00:50] (Merged) jenkins-bot: CiviCRM 5.29 update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621375 (https://phabricator.wikimedia.org/T259578) (owner: Eileen) [00:01:10] Fundraising-Backlog, fundraising Sprint Q 2020 for real, Patch-For-Review: Latest currency fields in silverpop export are incorrect - https://phabricator.wikimedia.org/T260708 (Eileenmcnaughton) I think there is actually another phab that relates - I thought it was this - https://phabricator.wikimedi... [00:01:36] (CR) Eileen: [C: +2] Vendor update - guzzle, psr7, polyfill [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/621376 (owner: Eileen) [00:06:19] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621367 (https://phabricator.wikimedia.org/T259578) (owner: Eileen) [00:06:59] (PS1) Eileen: Vendor update, guzzle, psr7, polyfill [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621377 [00:07:08] (CR) Eileen: [C: +2] Vendor update, guzzle, psr7, polyfill [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621377 (owner: Eileen) [00:07:15] (Merged) jenkins-bot: Update guzzle & psr7 in conjunction with civi update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621367 (https://phabricator.wikimedia.org/T259578) (owner: Eileen) [00:08:41] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621378 [00:08:50] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621378 (owner: Eileen) [00:09:12] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621378 (owner: Eileen) [00:09:26] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621378 (owner: Eileen) [00:11:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (KHaggard) Per our convo in T260708 - moving my comment to here. "I ran a query to check for any contacts in en6C and FR who donated within the last 5 year... [00:11:35] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621378 (owner: Eileen) [00:11:37] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621378 (owner: Eileen) [00:13:51] (PS1) Eileen: Fix wrong civi commit hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621379 [00:14:03] (CR) Eileen: [C: +2] Fix wrong civi commit hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621379 (owner: Eileen) [00:20:59] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621378 (owner: Eileen) [00:22:11] (Merged) jenkins-bot: Fix wrong civi commit hash [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621379 (owner: Eileen) [00:24:31] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621380 [00:24:39] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621380 (owner: Eileen) [00:27:07] !log civicrm revision changed from c442a09153 to cf9fadbeed, config revision is 3cdffd4fc2 [00:27:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:28:04] woohoo [00:28:46] dang spotted something that didn't happen on staging [00:29:12] an alter on civicrm_activity table is happeninng - I must have already done that on staging [00:29:19] so I don't know how long it will taake [00:30:08] I just killed the db update [00:30:22] oh dang [00:30:32] what's the alter? [00:30:38] what I'll do is comment out that change & do the rest [00:30:50] ALTER TABLE `civicrm_activity` CHANGE `activity_date_time` `activity_date_time` datetime NULL DEFAULT CURRENT_TIMESTAMP COMMENT 'Date and time this activity is scheduled to occur. Formerly named scheduled_date_time.' [00:31:02] hmm - cancelling the php cll didn't kill [00:31:26] failmail has started [00:31:38] I could give it a few mins or mysql kill [00:33:11] oh darn, let's stop the jobs [00:33:58] I've issued a kill [00:34:59] !log stopped fundraising scheduled jobs [00:35:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:35:25] let's keep those jobs off till the db is in the right state [00:35:41] so the activity_date_time just gets a default current timestamp? [00:35:46] (PS1) Eileen: Hash out slow commands to run separately [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621383 [00:35:58] ejegg: yeah so https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/621383 [00:38:32] ok, so if it's just the defaults, there's no code-schema incompatibility [00:38:46] no - it kinda needs them to ensure they are set I guess [00:39:04] but if we comment them we can run separately [00:40:18] or I can just try runnning now the queues are off [00:40:26] but I think they must take 20 mins? [00:41:31] I'm trying as a single statement to see - at least in the UI I can see progress [00:41:39] 1.73% [00:42:02] ok, maybe worth waiting for [00:42:13] 3.37... [00:42:37] at least the queues are off now & I squashed into 1 statement [00:43:05] 6.13% [00:44:18] 10.1% [00:44:35] cool cool [00:46:10] 16% [00:47:53] 19.7% [00:49:43] 23.3% [00:51:33] eileen: if we can't get (or want) that alter in today we can lump it in next week. currently looking at what we might want to do from T257919 [00:51:33] T257919: Plan for FY20-21 Q1 fundraising database maintenance window - https://phabricator.wikimedia.org/T257919 [00:52:16] dwisehaupt: yeah I was thinking that at first - I suspect we are probably at the point where it may as well finish now [00:52:38] it's 29% through [00:52:40] ok. cool. just want to keep that as an option. [00:52:44] yah, another half hour or so with no QCs should be ok [00:53:31] yeah - my only reservation about delaying is that the code might be expecting it - I *think* it would be OK - but I also *think* this might be OK too [00:53:56] right now jeff and i were thinking of splitting the maint in two bits. 1 during the daytime where we can stop donations and get the quick redis bits done. then a longer part 2 in the evening when we can do db work and not effect engage/MG/civi users. [00:54:05] I must have tested 5.28 earlier on staging & it already had this change as I got no slow query there [00:54:36] dwisehaupt: probably aa good idea - feels better for headspace to break it up a bit [00:54:58] & you could get the redis ones done on an earlier day even [00:55:54] dwisehaupt: tangentally - these alter statements will also defrag the table? [00:57:40] depends on the type of alter. [00:58:19] it's at 12.30 ^^ [00:58:35] 41.1% [00:59:55] i believe that is changing a column data type, in which case yes [01:00:24] https://dev.mysql.com/doc/refman/5.6/en/innodb-online-ddl-operations.html has a list of different types of alter operations and if they do or don't trigger a rebuild of the table. [01:02:56] cool [01:03:26] I realise the log table would get updated too.... not sure we can not do that [01:04:33] i'm going to drop away to get dinner on the table. i'll stay logged in so feel free to ping me on slack / any messsaging app to have my phone bring me back. [01:05:35] cool - thanks [01:10:41] eileen: even if it's just for a default? [01:10:57] there is a field type change [01:11:18] from datetime to timestamp [01:12:42] ahh, dang [01:12:51] yeah, i guess the log table needs it too [01:13:16] yeah replication will catch up in between [01:26:21] 101% of stage done [01:26:22] we can't kick off the log table alter on another connection, can we? [01:26:23] ! [01:26:25] hah [01:26:27] oh no [01:26:51] out of 1000% ? [01:26:55] lol [01:27:09] it's still on that first alter - so more than 20 mins :-( [01:30:12] 111%!!! [01:32:17] eileen so there's no way of doing the alter on the other table in parallel? [01:32:26] yeah we could I think [01:32:26] They're stored in different files, right? [01:32:36] let's do that! [01:34:32] So I think the query is [01:34:32] truncate civicrm_queue_item; [01:34:32] Query OK, 0 rows affected (0.007 sec) [01:34:32] ALTER TABLE `log_civicrm_activity` CHANGE `activity_date_time` `activity_date_time` datetime NULL COMMENT 'Date and time this activity is scheduled to occur. Formerly named scheduled_date_time.', [01:34:33] CHANGE `created_date` `created_date` timestamp NULL 'When was the activity was created.'; [01:36:27] but, the other just finished, so I cancelled & started the script [01:36:37] 'truncate civicrm_queue_item' is to get rid of the one queued up by the upgrader? [01:36:43] oh ok, great [01:36:59] now it says it has finished [01:37:14] so it didn't care about the log table [01:37:17] the log alter finished? [01:37:19] we should just test [01:37:21] oh weird [01:37:32] sure, I'll do a --slow-start on a few qcs [01:39:29] ejegg: the created_date got a column type change - but that seems to already be timestamp in the log file so that's why no change I guess [01:40:25] ok, the donation QC slow started fine [01:40:35] will try a couple others [01:40:40] yay [01:45:01] ok, I think we're good [01:45:12] will just try the TY mailer [01:45:58] ok, that's working too [01:46:09] cool [01:47:47] turning them back on, if there's nothing more to do eileen [01:50:32] good to go? [01:51:46] yep [01:54:54] !log re-enabled fundraising scheduled jobs [01:54:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:56:12] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1233 [01:56:21] well, UI looks good from some clicks [01:56:33] lessee, I think I can ack that [01:56:39] just replication catching up, right? [01:57:06] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1290 [01:57:14] PROBLEM - check_mysql on frdb1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1295 [01:57:39] yep [01:57:53] I'm gonna try Jerry's search [01:58:19] which search was that? [01:59:22] oh hmm, says I'm not authorized to ack that alert [02:00:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1473 [02:01:12] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1532 [02:01:44] dwisehaupt: not sure if you're here, but I guess I don't have the permissions to ack at least the frdb alerts in icinga UI [02:02:08] I can log in, check the box, and type a reason, but when I submit I get a permissions error [02:02:12] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1590 [02:02:16] PROBLEM - check_mysql on frdb1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1595 [02:05:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1773 [02:06:12] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1832 [02:07:12] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1890 [02:07:16] PROBLEM - check_mysql on frdb1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1895 [02:10:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2073 [02:10:50] thanks eileen! [02:11:12] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2132 [02:12:12] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2190 [02:12:15] oh hmm, recurring charge failed in the middle of that upgrade [02:12:16] PROBLEM - check_mysql on frdb1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2195 [02:12:26] we may have one stuck in 'processing' [02:12:39] should check the processor console to see if it actually got charged [02:12:48] ejegg: ug [02:13:05] I guess that's the point of 'processing' [02:13:22] if we do nothing then if might get updated by tomorrow? [02:14:22] no, it'll stay in processing [02:14:36] no need to fix it tonight, just shouldn't forget it [02:14:47] it wouldn't get picked up as done from audit if done? [02:15:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2373 [02:16:12] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2432 [02:16:39] eileen the audit might add the individual payment record but it wouldn't reset the state of the recurring row [02:16:57] ejegg: ah OK - we should ideally fix that [02:16:59] hmm, we also might not be correctly adding recurring donations from audit files for some processors [02:17:12] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2491 [02:17:14] yeah, let me see if there's a related ticket [02:17:16] PROBLEM - check_mysql on frdb1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2496 [02:18:09] howdy [02:18:12] yeah, for adyen recurring we don't seem to write them correctly from the audit files: https://phabricator.wikimedia.org/T255317 [02:18:24] hmm, we might not for ingenico either now that i think of it [02:18:44] i'm going to ack these replication alerts since we know why they are behind. [02:20:12] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2673 [02:21:11] ACKNOWLEDGEMENT - check_mysql on frdb1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2496 Dwisehaupt replication catchup after alter from civicrm code update [02:21:11] ACKNOWLEDGEMENT - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2491 Dwisehaupt replication catchup after alter from civicrm code update [02:21:11] ACKNOWLEDGEMENT - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2432 Dwisehaupt replication catchup after alter from civicrm code update [02:21:11] ACKNOWLEDGEMENT - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2673 Dwisehaupt replication catchup after alter from civicrm code update [02:22:12] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 789026 Threads: 1 Questions: 61194796 Slow queries: 366 Opens: 97511 Flush tables: 1 Open tables: 680 Queries per second avg: 77.557 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [02:26:12] RECOVERY - check_mysql on frdb2002 is OK: Uptime: 789685 Threads: 1 Questions: 61206435 Slow queries: 380 Opens: 97605 Flush tables: 1 Open tables: 696 Queries per second avg: 77.507 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [02:32:16] RECOVERY - check_mysql on frdb1001 is OK: Uptime: 7467774 Threads: 2 Questions: 1533339737 Slow queries: 8903 Opens: 4704851 Flush tables: 1 Open tables: 690 Queries per second avg: 205.327 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [02:35:12] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 7468358 Threads: 3 Questions: 1523862487 Slow queries: 407338 Opens: 10711156 Flush tables: 8 Open tables: 200 Queries per second avg: 204.042 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [02:49:57] good night all [05:28:59] (PS14) Eileen: Move email handling to the duper and address bug where email data can be lost [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/619075 (https://phabricator.wikimedia.org/T256316) [05:29:44] (Abandoned) Eileen: Hash out slow commands to run separately [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621383 (owner: Eileen) [05:30:35] (CR) jerkins-bot: [V: -1] Move email handling to the duper and address bug where email data can be lost [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/619075 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [05:30:49] (PS2) Eileen: IDE reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621127 [05:35:04] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/619075 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [05:39:09] (PS15) Eileen: Move email handling to the duper and address bug where email data can be lost [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/619075 (https://phabricator.wikimedia.org/T256316) [07:38:57] (CR) AndyRussG: "Yay!!! Thanks so much, this is definitely on the right track!!! Please see the Phab task (T255810) for thoughts on what more is needed. Al" (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/621341 (https://phabricator.wikimedia.org/T255810) (owner: Mepps) [07:42:09] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real, and 3 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) >>! In T255810#6393568... [09:24:44] (PS1) Eileen: Remove css that is hiding some buttons [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621477 [09:26:30] (CR) Eileen: "I'm going to self-merge this as it's just css & it's directly impacting usability & I feel it will cause problems to wait since it makes s" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621477 (owner: Eileen) [09:31:48] (CR) Eileen: [C: +2] Remove css that is hiding some buttons [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621477 (owner: Eileen) [09:33:20] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621479 [09:33:31] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621479 (owner: Eileen) [09:36:05] !log civicrm revision changed from cf9fadbeed to 6c9441a18e, config revision is 706cf3c898 [09:36:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [10:10:40] (PS1) Eileen: Update Smashpig to display the cancel form (fix upgrade regression) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621481 [10:20:28] (PS2) Eileen: Update Smashpig to display the cancel form (fix upgrade regression) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621481 [11:02:08] (PS1) Eileen: Re-add enable/ disable functionality [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621507 [11:14:09] (CR) Eileen: [C: +2] "https://github.com/civicrm/civicrm-core/pull/18204" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621507 (owner: Eileen) [11:15:32] (CR) jerkins-bot: [V: -1] Re-add enable/ disable functionality [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621507 (owner: Eileen) [11:18:58] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621507 (owner: Eileen) [11:28:55] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621510 [11:29:03] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621510 (owner: Eileen) [11:30:21] (CR) jerkins-bot: [V: -1] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621510 (owner: Eileen) [11:34:08] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621510 (owner: Eileen) [11:35:15] (CR) jerkins-bot: [V: -1] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621510 (owner: Eileen) [11:36:03] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621510 (owner: Eileen) [11:39:10] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621514 [11:39:22] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621514 (owner: Eileen) [11:41:32] !log civicrm revision changed from 6c9441a18e to 958a79f660, config revision is 706cf3c898 [11:41:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [11:43:15] Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real, Patch-For-Review: Oanda exchange rates update job failing - https://phabricator.wikimedia.org/T260092 (jgleeson) Email has been sent to Oanda raising this issue. The email subject is 'web-services.oanda.co... [12:22:59] tzag fr-tech [12:36:03] Wikimedia-Fundraising-Banners: [Candidate] JP Banners due Aug 3 - https://phabricator.wikimedia.org/T259076 (Pcoombe) [12:58:08] (PS3) Jgleeson: Add in custom http_request function for OANDA requests to work around the weak cipher blocker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621066 (https://phabricator.wikimedia.org/T260092) [13:05:19] (PS4) Jgleeson: Add in custom http_request function for OANDA requests to work around the weak cipher blocker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621066 (https://phabricator.wikimedia.org/T260092) [13:43:25] (CR) Ejegg: [C: +2] "Looks good, works in local testing!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621066 (https://phabricator.wikimedia.org/T260092) (owner: Jgleeson) [13:50:16] (Merged) jenkins-bot: Add in custom http_request function for OANDA requests to work around the weak cipher blocker [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621066 (https://phabricator.wikimedia.org/T260092) (owner: Jgleeson) [13:52:30] (PS5) Jgleeson: Paypal Audit: Move the check for missing subscription ids to a later stage in the audit process to avoid overthrowing exceptions. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/620123 (https://phabricator.wikimedia.org/T243005) [13:52:50] thanks for the review ejegg|away ! [13:55:56] I just pushed up an updated version of the paypal audit patch and it turns out the test I added on the earlier PS was already covered by an existing test so I removed that. [13:56:12] now to see what the jenkins gods thought of that [13:58:13] looks like they've given the patch their blessings on this occasion. usually it's a plague of jenkins console errors [14:00:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (MBeat33) [14:05:26] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: add translations to generic email for failed recurring donations - https://phabricator.wikimedia.org/T255837 (MBeat33) Open→Resolved Ok to close, many than... [14:05:26] Fundraising-Backlog, fr-donorservices: Add translations for failed recurring email for 7 additional languages - https://phabricator.wikimedia.org/T260703 (MBeat33) [14:10:34] Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, and 2 others: Duplicate donations with the same contribution tracking id - https://phabricator.wikimedia.org/T256037 (jgleeson) a:jgleeson [14:26:29] (PS4) Mepps: WIP CampaignFallback: runPostBannerMixinHooks once per iteration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/621341 (https://phabricator.wikimedia.org/T255810) [14:27:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (MBeat33) [14:28:09] (CR) Mepps: "Made the changes suggested. Still need to think about suggestions in task." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/621341 (https://phabricator.wikimedia.org/T255810) (owner: Mepps) [14:32:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (jgleeson) >To clarify, I think the recurring failure message sends after the third and final processing a... [14:36:55] ok I'm gonna relocate. back soon! [14:53:22] hi fr-tech! [14:54:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (MBeat33) Thanks for confirming, @jgleeson If we can determine why they got the fail message 9 days afte... [14:55:50] (PS2) Ejegg: Do not cleanup the admin user on test tear down [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621126 (owner: Eileen) [14:56:25] (CR) Ejegg: [C: +2] "Yep, seems like a good idea not to delete the user that's created on install" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621126 (owner: Eileen) [14:59:44] Wikimedia-Fundraising-Banners, fr-donorservices: Extra decimals on Other amount field gets PTF riled up - https://phabricator.wikimedia.org/T259762 (Pcoombe) [15:03:35] (Merged) jenkins-bot: Do not cleanup the admin user on test tear down [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621126 (owner: Eileen) [15:04:29] hi ejegg [15:09:43] hi cstone! [15:10:04] cstone, I was cleaning up a recurring stuck in 'Processing' from last night's upgrade [15:10:24] Wikimedia-Fundraising-Banners: 2020-08-20 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T260848 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z1efde5da554f4890919 - Coffee with character matchin... [15:10:31] turns out it was easy to clean up since the processor console showed that it was failed with a 'bad card number' [15:10:35] so I just canceled it [15:10:37] ah ejegg did it get stuck in the same place? ah nice [15:10:52] but I noticed there was one more that seems to be an old-to-new [15:11:01] cid 25338264 [15:11:03] hmmm [15:13:33] not sure how I missed that one but I'll get it back in order [15:15:15] hmm i imported the missing donation [15:15:22] oh weird [15:15:33] ahh, but it just needs the recur status updated? [15:17:01] yeah im doing that now [15:18:52] (CR) Ejegg: [C: +2] "OK, so this is where we would send the cancelation to the processor for e.g. paypal, and that the management of the actual recur status is" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621481 (owner: Eileen) [15:18:58] (PS3) Ejegg: Update Smashpig to display the cancel form (fix upgrade regression) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621481 (owner: Eileen) [15:22:05] Wikimedia-Fundraising-Banners: 2020-08-20 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T260848 (jbolorinos-ctr) QA has been completed and these banners are now READY TO TEST! T247380 [15:22:19] Wikimedia-Fundraising-Banners: 2020-08-20 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T260848 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr [15:22:20] Wikimedia-Fundraising-Banners: QA for en6C pre-test on August 20 - https://phabricator.wikimedia.org/T260844 (jbolorinos-ctr) [15:24:09] Fundraising-Backlog: "Previous" navigation button does not work on Adyen payment form - https://phabricator.wikimedia.org/T260749 (jbolorinos-ctr) [15:24:36] ok 0 in processing! [15:25:10] Wikimedia-Fundraising-Banners: 2020-08-20 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T260846 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr QA has passed and these banners are now READY TO TEST! [15:26:37] (CR) jerkins-bot: [V: -1] Update Smashpig to display the cancel form (fix upgrade regression) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621481 (owner: Eileen) [15:27:23] Wikimedia-Fundraising-Banners: 2020-08-20 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T260850 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr QA has been completed and these banners are now READY TO TEST! [15:27:26] Wikimedia-Fundraising-Banners: QA for en6C pre-test on August 20 - https://phabricator.wikimedia.org/T260844 (jbolorinos-ctr) [15:29:04] Wikimedia-Fundraising-Banners: 2020-08-20 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T260851 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr QA has completed now and all issues found have been reported. These banners are now READY TO TEST! [15:29:04] Wikimedia-Fundraising-Banners: QA for en6C pre-test on August 20 - https://phabricator.wikimedia.org/T260844 (jbolorinos-ctr) [15:30:20] Wikimedia-Fundraising-Banners: QA for en6C pre-test on August 20 - https://phabricator.wikimedia.org/T260844 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr Hey @spatton, QA has been completed now for these copy variants. All issues have been reported and addressed. Please just let me know if yo... [15:41:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (MBeat33) @krobinson noticed that the donor had //two// recurrings that failed in the same month, so that... [16:05:36] (CR) Ejegg: [C: +2] "Looks good, thanks cstone!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617594 (owner: Cstone) [16:06:12] (Merged) jenkins-bot: Use eventDate from the Adyen capture for the donations queue message date. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617594 (owner: Cstone) [16:27:19] Fundraising-Backlog, FR-Civi-Dedupe, fr-donorservices: Civi dedupe: multiple errors after 8/19 updgrade - https://phabricator.wikimedia.org/T260921 (MBeat33) [16:28:26] Wikimedia-Fundraising-Banners: Remove hover text from banners - https://phabricator.wikimedia.org/T258517 (Pcoombe) Okay, this is done for current best banners. Marking the purely decorative elements (e.g. this X, which is already next to text saying "Close") as `aria-hidden="true"` and removing the title is... [16:29:48] Fundraising-Backlog, FR-Civi-Dedupe, fr-donorservices: Civi dedupe: multiple errors after 8/19 updgrade - https://phabricator.wikimedia.org/T260921 (MBeat33) p:Triage→High [16:32:34] Wikimedia-Fundraising-Banners: Orphan text visible on Japanese dsk lg Monthly Convert step - https://phabricator.wikimedia.org/T259535 (Pcoombe) [16:41:58] Fundraising-Backlog, FR-Civi-Dedupe, fr-donorservices: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (MBeat33) [16:54:32] Wikimedia-Fundraising-Banners: Orphan text visible on Japanese dsk lg Monthly Convert step - https://phabricator.wikimedia.org/T259535 (Pcoombe) Okay, this should be fixed with [this change](https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-B2021_0804_jaJP_dsk_p1_lg_txt_cnt&diff=p... [16:54:54] Wikimedia-Fundraising-Banners: Orphan text visible on Japanese dsk lg Monthly Convert step - https://phabricator.wikimedia.org/T259535 (Pcoombe) a:jbolorinos-ctr→Pcoombe [16:55:01] Wikimedia-Fundraising-Banners: Remove hover text from banners - https://phabricator.wikimedia.org/T258517 (Pcoombe) a:Pcoombe [16:56:54] Wikimedia-Fundraising-Banners: Incorrect exchange rate used in max donation amount error message - https://phabricator.wikimedia.org/T259534 (Pcoombe) Open→Resolved Resolved by removing the USD amount from the message. See T259525 [16:56:56] Wikimedia-Fundraising-Banners: [Candidate] JP Banners due Aug 3 - https://phabricator.wikimedia.org/T259076 (Pcoombe) [17:10:35] Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real, Patch-For-Review: Oanda exchange rates update job failing - https://phabricator.wikimedia.org/T260092 (jgleeson) So Oanda got back to us advising that we should switch to using www.oanda.com as the API end... [17:11:15] (PS1) Jgleeson: Revert "Add in custom http_request function for OANDA" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621494 [17:17:40] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real, and 3 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) > We'll also have to a... [17:40:18] ejegg: I updated the vendor patch I added just the file that you did for the 1_31 branch [17:41:05] thanks cstone [17:42:18] Fundraising-Backlog, FR-Civi-Dedupe, fr-donorservices: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (MBeat33) 5. We're also seeing different results from Quick Search versus Advanced Search. Rakhi noticed that if you search for the email address belongin... [17:45:33] (PS1) Scervantes: Add test commit to Payment Form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/621556 [17:54:12] Fundraising-Backlog: Currency symbol and amount on different lines in TY email - https://phabricator.wikimedia.org/T260718 (jbolorinos-ctr) duplicate→Open Hey @DStrine, this doesnt appear to be a duplicate of T259671, this issue is with the is in the template variable logic from my understanding? Re... [17:54:14] Wikimedia-Fundraising-Banners: QA for en4C pre-test on August 19 - https://phabricator.wikimedia.org/T260541 (jbolorinos-ctr) [17:58:30] cstone weird somehow it only shows that one file from the amzn directory [17:58:37] we need all of the amzn files [17:58:42] hmm ok let me try again [18:01:08] ejegg: ok files are there [18:01:17] thanks! [18:06:54] ok, backing up wiki db to try the upgrade [18:09:15] cstone: oh shoot, looks like wikimedia/smash-pig is also empty [18:09:18] probably same deal [18:09:23] ok fixing [18:42:45] ejegg: got it there after some wrangling [18:43:24] thanks [18:46:30] Wikimedia-Fundraising-Banners: Incorrect exchange rate used in max donation amount error message - https://phabricator.wikimedia.org/T259534 (jbolorinos-ctr) Thanks so much Peter! [18:47:43] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real, and 3 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (mepps) So, from what I understand... [19:00:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (mepps) Thanks for telling us about this @MBeat33! @Eileenmcnaughton This does seem like a good idea. In m... [19:10:25] Wikimedia-Fundraising-Banners: Remove hover text from banners - https://phabricator.wikimedia.org/T258517 (jbolorinos-ctr) I've checked from my end and no hover text is appearing anymore on the Close x icon. Thanks so much for this fix Peter! Does this fix need to be applied to mobile though? I initially th... [19:30:38] Fundraising-Backlog, FR-Civi-Dedupe, fr-donorservices: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (RLewis) Thanks @MBeat33 for creating this task. I was about to create a task about this. I'm also seeing some issues when searching using the quick sea... [19:33:43] hmm, what are these failmails? [19:39:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: recurring cancel inoperative - https://phabricator.wikimedia.org/T260934 (MBeat33) [19:39:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: recurring cancel inoperative - https://phabricator.wikimedia.org/T260934 (MBeat33) p:Triage→High [19:42:03] Fundraising-Backlog: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (MNoorWMF) [19:53:23] Fundraising-Backlog, Operations, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Patch-For-Review, and 3 others: New wiki for fundraising Thank You pages with similar config as donatewiki - https://phabricator.wikimedia.org/T259002 (nskaggs) [19:57:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: recurring cancel inoperative (for paypal?) - https://phabricator.wikimedia.org/T260934 (MBeat33) [20:21:20] Fundraising-Backlog, fundraising Sprint Q 2020 for real: prototype moving to docker - https://phabricator.wikimedia.org/T260085 (mepps) I started playing with this for an hour today. One issue I ran into that's specific to us is that docker uses port 8080 by default so we'll need to figure out how to cha... [20:41:17] (PS16) Ejegg: Move email handling to deduper, fix email loss bug [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/619075 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [20:45:38] Fundraising-Backlog, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe, fr-donorservices: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (Eileenmcnaughton) a:Eileenmcnaughton [20:48:34] (CR) Mepps: "Small comment. Reviewing this a bit with Ejegg right now." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/619075 (https://phabricator.wikimedia.org/T256316) (owner: Eileen) [20:50:25] Fundraising-Backlog, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe, fr-donorservices: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (Eileenmcnaughton) Looking now [20:57:44] Fundraising-Backlog: High Unique Clicks for nlNL RML program - https://phabricator.wikimedia.org/T259189 (KHaggard) Just updating that we have a Trilogy rep looking into this, but I have some questions for fr-tech: Is landingpageimpression_raw table pulling unique or gross? - How can we tell? I'm not very f... [21:00:02] (PS1) Eileen: Fix missing is_deleted in quicksearch query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621590 (https://phabricator.wikimedia.org/T260921) [21:01:02] I'm just lookig at https://phabricator.wikimedia.org/T260921 but also having yubikey issues :-( Can someone review ^^ so I can get it out - I will do a longer fix / explanation upstream but just want to resolve the issue for now [21:01:33] hah eileen i just noticed that in my local db [21:01:38] *local civi [21:02:39] cool - the underlying issue is that is_deleted was being added from the permission code when it was a query param - it got removed from permission code but is needed in some query params still! [21:08:03] I'm just testing dedupe queries locally for deleted [21:10:03] oh man, i was just looking at no changes in that api file and wonder where in tarnation it had been changed [21:10:29] ok, that looks like it'll be a good quick fix [21:10:43] that 'getQuick' api call is specifically for that search, right? [21:11:13] (CR) Ejegg: [C: +2] Fix missing is_deleted in quicksearch query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621590 (https://phabricator.wikimedia.org/T260921) (owner: Eileen) [21:11:26] yep [21:11:44] so those yubikey issues mean it would be helpful for someone to deploy ^^^ once it merges, yes? [21:11:58] I haven't replicated the other issues locally & my yubikey has died. Very recently I put my other one 'somewhere sensible' - which I have to find [21:12:06] but yes please! [21:13:01] I think the deleted in dedupe is the next most urgent but I've not yet replicated [21:13:05] okok [21:13:33] as in, deleted contacts are showing up as dedupe targets? [21:14:02] oh, i suppose it's in the phab [21:14:51] ah dang [21:15:15] from what I can tell it looks like [21:15:16] 1) slow query on safe merge (any chance you can capture it?) [21:15:16] 2) left hand column not showing up - true on staging & prod, not local [21:15:16] 3) deleted contacts in merge find - not yet replicated locally [21:15:43] eileen: there was an activity report hanging the db with this query too: https://phabricator.wikimedia.org/P12309 [21:15:54] not sure if it's normal for that subquery to have no time filter [21:16:55] that could be user selection [21:17:42] (Merged) jenkins-bot: Fix missing is_deleted in quicksearch query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621590 (https://phabricator.wikimedia.org/T260921) (owner: Eileen) [21:19:52] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621592 [21:20:16] my yubikey just worked! [21:20:37] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621592 (owner: Eileen) [21:22:54] (PS1) Ejegg: Update CiviCRM submodule pointer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621596 [21:22:56] (CR) Ejegg: [C: +2] Update CiviCRM submodule pointer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621596 (owner: Ejegg) [21:24:22] ok speed issue is the same as deleted issue - in fact I think they all are [21:25:36] Fundraising-Backlog, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe, fr-donorservices, Patch-For-Review: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (Eileenmcnaughton) I think all the dedupe issues are to do with the is_deleted filtering at... [21:28:49] (Merged) jenkins-bot: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621592 (owner: Eileen) [21:30:37] (Merged) jenkins-bot: Update CiviCRM submodule pointer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621596 (owner: Ejegg) [21:30:47] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621598 [21:31:19] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621598 (owner: Ejegg) [21:35:39] !log updated fundraising CiviCRM from 958a79f660 to 27d5900f7d [21:35:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:36:45] ok eileen, got that deployed [21:37:01] oh cool, yubikey is happy again? [21:37:02] thanks ejegg - just trying to figure out on dedupe [21:37:09] yeah - not sure it's issue.... [21:37:21] might be the mac - it does weird stuff [21:44:00] (PS1) Eileen: Fix is_deleted missing on dedupe queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621600 (https://phabricator.wikimedia.org/T260921) [21:44:09] ejegg: ok I think I got the other one [21:47:19] looking [21:48:38] whew, was entangled with the acl logic there too, huh? [21:49:01] yep [21:49:41] sigh [21:50:07] I'm actually guilty of having merged that change to core a while back :-( [21:51:00] (CR) jerkins-bot: [V: -1] Fix is_deleted missing on dedupe queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621600 (https://phabricator.wikimedia.org/T260921) (owner: Eileen) [21:51:39] hrm? [21:52:18] enotice [21:52:23] I'll put back the property [21:52:32] The upstream fix may look different [21:52:53] oh gross, non-declared [21:53:07] wanna move it to the proper spot? [21:53:10] (PS2) Eileen: Fix is_deleted missing on dedupe queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621600 (https://phabricator.wikimedia.org/T260921) [21:53:41] ejegg: I just put it back - when I do an upstream fix I'll think it through properly [21:53:46] (& add a test) [21:53:46] ok [21:56:47] k, seems to work [21:57:44] cool - let's get it out there [21:57:53] (CR) Ejegg: "Seems to do the trick. Bit of whitespace got doubled, but we can correct that with the 'real' fix." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621600 (https://phabricator.wikimedia.org/T260921) (owner: Eileen) [21:58:04] (CR) Ejegg: [C: +2] Fix is_deleted missing on dedupe queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/621600 (https://phabricator.wikimedia.org/T260921) (owner: Eileen) [21:59:47] Fundraising-Backlog: Emojis in firstname/lastname causing names to be too long for Ingenico - https://phabricator.wikimedia.org/T241757 (Cstone) Another: "name\ud83e\udd75\ud83d\udc8b\ud83d\udc44\ud83d\ude2d\ud83c\udf37\ud83e\udd22" [22:02:07] (PS1) Eileen: Submodule updatae [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621602 [22:02:16] (CR) jerkins-bot: [V: -1] Submodule updatae [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621602 (owner: Eileen) [22:03:08] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621603 [22:03:17] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621603 (owner: Eileen) [22:04:03] Fundraising-Backlog: Emojis in firstname/lastname causing names to be too long for Ingenico - https://phabricator.wikimedia.org/T241757 (Eileenmcnaughton) As an aside - civi can't say emjois anyway (without some work) [22:05:30] (Abandoned) Eileen: Submodule updatae [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621602 (owner: Eileen) [22:07:03] I did hmm - so it winds up taking 21 minutes of test time to get a merge if all goes well [22:07:20] ejegg: I see you & mepps looked at the dedupe one - did you get anywhere? [22:08:56] eileen: looks like we are on for the maintenance on monday EDT/PDT. i'll be doing the db work later day so we minimize civi obstructions. if there is anything you specifically want in the window, we can add it here: https://collab.wikimedia.org/wiki/2020-08-25-downtime-maintenance [22:14:18] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621604 [22:15:03] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621604 (owner: Eileen) [22:18:53] eileen: still making sense of it all on the dedupe patch, sorry! [22:19:27] no worries - it's tough going [22:20:47] !log civicrm revision is 27d5900f7d, config revision is 706cf3c898 [22:20:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:21:49] hmm still seeing those deleted ones :-( [22:22:24] ah not yet merged [22:29:20] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/621604 (owner: Eileen) [22:31:42] !log civicrm revision changed from 27d5900f7d to ce28723709, config revision is 706cf3c898 [22:31:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:32:55] Fundraising-Backlog, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe, fr-donorservices, Patch-For-Review: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (Eileenmcnaughton) OK - I think it's sorted now [22:34:22] MBeat: that is testing OK for me again now [22:34:40] thanks, eileen [22:34:49] deduper’s delight [22:34:52] :-) [22:35:10] any word on the recuring cancel button? [22:35:20] That was sorted last night I believe [22:35:32] T260934 had a new example from today [22:35:33] T260934: Civi: recurring cancel inoperative (for paypal?) - https://phabricator.wikimedia.org/T260934 [22:36:16] MBeat: that was likely a temporary error due to a run-away query - can you try again [22:36:26] it seems unrelated to the other stuff [22:38:20] sure thing, let me try [22:42:37] cool it looks like one of the earlier attempts finally landed, I’ll close the task - ty eileen [22:43:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: recurring cancel inoperative (for paypal?) - https://phabricator.wikimedia.org/T260934 (MBeat33) Open→Resolved a:MBeat33 "likely a temporary error due to a run-away query" and one of the... [22:43:17] yeah - I think it was just co-incidence it appeared related to the upgrade button issue - [22:44:37] MBeat: the other thing is we have a patch that will convert the cancel to the form where you can enter cancel reason. I have only one slight hesitation which is that from has a check box 'notify contributor' & will send them an email if that is not unchecked [22:45:06] oof, can we default to that being unchecked? [22:48:21] yeah ok - I wondered if that would be your re-action. It's not new but it catches me out on the local campaign I do stuff for [22:48:56] I'll leave it until next week then - the disable popup is probably better for now [22:53:53] (CR) Eileen: [C: -1] "I want to delay this after talking to mbeat" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621481 (owner: Eileen) [22:54:57] it’s not a huge deal, eileen we can just ask DS agents to always uncheck. long term it would be good to make the default be unchecked, volume is so high in Q2 it’s likely to get missed once in a while [22:55:01] Fundraising-Backlog, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe, fr-donorservices, Patch-For-Review: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (Eileenmcnaughton) @mbeat33 please confirm if this can be closed now [22:56:06] Fundraising-Backlog, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe, fr-donorservices, Patch-For-Review: Civi dedupe: multiple errors after 8/19 upgrade - https://phabricator.wikimedia.org/T260921 (MBeat33) Open→Resolved Thank you @Eileenmcnaughton ! [22:56:54] MBeat: ok - but you are not busting to get the cancel field back right now either? I can approve that patch & you'll get the cancel field, but also the notify thing [22:58:54] well we need the cancel button (this is the cancel recurring donations button, just confirming) to work every day. the ability to enter a reason or email the donor are not things we need necessarily, but if there’s tech debt to remove/disable them, that’s no problem to keep them in [22:59:06] does that make sense? [23:18:00] MBeat: ok - the cancel button should be working - it's just which form it launches [23:18:25] but for now it should be OK [23:18:37] thank you [23:19:33] I'll revist the other question next week :-) [23:23:05] ty [23:23:18] shoot eileen - want me to help with any of those other fixes? [23:23:57] ejegg: I feel like we have them under control - there is other stuff unrelated to the upgrade but AFAIK all upgrade related issues are fixed [23:25:34] ejegg: merging this would be nice as I keep committing it :-) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/620134 [23:25:57] hah, ok! [23:26:13] interesting location [23:26:24] ah, buildkit [23:26:32] (PS4) Ejegg: Ignore RPOW settings file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/620134 (owner: Eileen) [23:26:38] (CR) Ejegg: [C: +2] Ignore RPOW settings file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/620134 (owner: Eileen) [23:27:24] thanks! [23:28:43] oh this is formatting only https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/621127 [23:29:37] (Abandoned) Eileen: Add file to hold developer settinngs. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/620136 (owner: Eileen) [23:33:22] (Merged) jenkins-bot: Ignore RPOW settings file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/620134 (owner: Eileen)