[00:32:52] thanks for deploying that mb_string fix eileen! [00:33:03] no worries [00:42:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1008:down [00:47:12] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [02:31:44] (PS2) Eileen: Dev env patch - make field do_not_solicit optional, per live [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622682 [02:31:46] (PS1) Eileen: Remove added in error file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622697 [02:33:05] (CR) jerkins-bot: [V: -1] Remove added in error file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622697 (owner: Eileen) [02:41:58] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622697 (owner: Eileen) [02:50:31] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622697 (owner: Eileen) [03:30:01] Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, and 4 others: Civi Dedupe: enable Deduper to handle multiple email addresses - https://phabricator.wikimedia.org/T256316 (Eileenmcnaughton) @shust I've deployed a pa... [04:29:32] (PS1) Eileen: Fix deduper to bold the name to be kept under force merge, leverage new api functionality [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622700 (https://phabricator.wikimedia.org/T256316) [04:29:34] (PS1) Eileen: Increment deduper version [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622701 [04:37:07] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, and 2 others: My testing suggests that REMOVING the contribution_status_id (& low-cardinality indexes like is_deleted) will spe... - https://phabricator.wikimedia.org/T247489 [04:37:09] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, and 2 others: My testing suggests that REMOVING the contribution_status_id (& low-cardinality indexes like is_deleted) will spe... - https://phabricator.wikimedia.org/T247489 [04:37:11] Fundraising Sprint CAPS LOCK CULTS, Fundraising Sprint Dampness, Fundraising Sprint Evil Twins For Everyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help Pats with her query - https://phabricator.wikimedia.org/T244194 (Eileenmcnaughton) [04:37:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint Q 2020 for real: Wow let's look at that contribution_status_id index again - https://phabricator.wikimedia.org/T257132 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton [04:40:55] Fundraising-Backlog, fundraising Sprint Q 2020 for real, Patch-For-Review: Latest currency fields in silverpop export are incorrect - https://phabricator.wikimedia.org/T260708 (Eileenmcnaughton) Open→Resolved Adding 4 story points - was considering 2 but it's one of those days when things see... [04:41:03] Fundraising-Backlog, fundraising Sprint Q 2020 for real, Patch-For-Review: Latest currency fields in silverpop export are incorrect - https://phabricator.wikimedia.org/T260708 (Eileenmcnaughton) [06:43:23] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 5 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[php7.0],Package[php7.0-common],Package[php7.0-cgi],Package[php7.0-cli] [06:48:22] RECOVERY - check_puppetrun on payments1004 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [11:44:32] Wikimedia-Fundraising-Banners: [Candidate] JP Banners due Aug 3 - https://phabricator.wikimedia.org/T259076 (Pcoombe) [11:44:38] Wikimedia-Fundraising-Banners: Orphan text visible on Japanese dsk lg Monthly Convert step - https://phabricator.wikimedia.org/T259535 (Pcoombe) Open→Resolved Great. I've copied this across to the Japan banners and current best. [13:40:10] very early hellooooo fr-tech! [14:03:43] good morning AndyRussG! [14:03:49] how are you holding up? [14:09:09] (CR) Mepps: [C: +2] Undo overzealous typehinting [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/618544 (owner: Ejegg) [14:09:43] (Merged) jenkins-bot: Undo overzealous typehinting [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/618544 (owner: Ejegg) [14:10:10] (CR) Mepps: [C: +1] "This looks good and I appreciate the documentation in the patch. Maybe we want to add that somewhere in the README or code comments?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617483 (owner: Ejegg) [14:13:28] mepps: hi! actually not bad at all, thanks! [14:13:42] that's great AndyRussG! [14:13:46] how are the girls doing? [14:13:47] mepps: dunno how it happened, but I actually fell asleep really early yesterday [14:14:00] ooh lovely AndyRussG [14:15:02] yeah, thank! mmm the kids are basically fine, the zoom classes are boring but they've been going to them, complying with the camera-on requirement :) [14:15:29] how are you and your family doing with stuff? [14:25:06] AndyRussG we're not bad--i feel so lucky that the kids can go to Lisa's house but James is starting to miss his school and I am too [14:25:44] i keep toying with the idea of enrolling them in october but i'm not sure it makes sense (they'd be able to go in person to the private nursery school for a full day) [14:30:21] Fundraising-Backlog: Error: UNKNOWN missing essential contribution tracking ID - https://phabricator.wikimedia.org/T256274 (mepps) We have been getting more of these--maybe four--over the last couple of days. @DStrine we might want to try to prioritize it in the next sprint if possible. [14:31:47] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) A very basic starting point: https://www.drupal.org/docs/upgrading-drupal/preparing-a-site-for-upgrade-to-drupal-8. [14:39:20] Fundraising-Backlog: Error: UNKNOWN missing essential contribution tracking ID - https://phabricator.wikimedia.org/T256274 (mepps) I've been looking into this today a teeny bit as part of chores but I can't see any clues why it would be happening in the logs. [14:53:10] Wikimedia-Fundraising-Banners: Text and question mark are on separate lines - Opt-in text - https://phabricator.wikimedia.org/T261416 (jbolorinos-ctr) [14:57:36] Wikimedia-Fundraising-Banners: [Candidate] FR Banners due Aug 28 - https://phabricator.wikimedia.org/T259833 (jbolorinos-ctr) Hey @TSkaff, I just wanted to ping you to let you know there's a problem with the Adyen form that may result in users seeing this page: {F32197717} I've reported the issue here - T... [15:10:09] Fundraising-Backlog, FR-Adyen: "Previous" navigation button does not work on Adyen payment form - https://phabricator.wikimedia.org/T260749 (jbolorinos-ctr) [15:11:42] Wikimedia-Fundraising-Banners: QA for en4C pre-test on August 19 - https://phabricator.wikimedia.org/T260541 (jbolorinos-ctr) Hey @spatton, why did you close this task out as declined again? Is it because we decided to not run the pretest? [15:30:29] Wikimedia-Fundraising-Banners: Text and question mark are on separate lines - Opt-in text - https://phabricator.wikimedia.org/T261416 (TSkaff) Thanks @jbolorinos-ctr , I don't see this in my browser (Chrome); which one are you using? There should be a space between the word and ? so all we could do is adju... [15:40:37] mepps: hmmm yeah sounds like a dilemma [15:41:00] AndyRussG i solved it and went for a run :) [15:41:51] ah cool! that was the solution? [15:42:54] oh haha [15:43:01] i was thinking of another thread with jgleeson :) [15:43:22] yeah, AndyRussG there's no easy answer to this other question [15:43:32] i'm just going to have to see how the stars align [15:48:21] heh doesn't sound like an easy decision at all [15:50:15] AndyRussG it depends on some outside forces which helps, like the school has to have slots and our nanny share buddy family has to want to do it too [16:02:27] (CR) Jgleeson: "This does look like straightforward a change but I wanted to see the new code in action just to be sure." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622456 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [16:17:25] relocating back soon! [16:25:59] Wikimedia-Fundraising-Banners: Text and question mark are on separate lines - Opt-in text - https://phabricator.wikimedia.org/T261416 (jbolorinos-ctr) [16:26:35] Wikimedia-Fundraising-Banners: Text and question mark are on separate lines - Opt-in text - https://phabricator.wikimedia.org/T261416 (jbolorinos-ctr) I'm using Chrome also, on Windows (just updated the task to include those details). Were you using the desktop refresh version? This issue is only visible on... [16:28:03] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Bug: Illegal mix of collations (utf8_unicode_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '=' - https://phabricator.wikimedia.org/T261319 (mepps) [16:28:45] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Bug: Illegal mix of collations (utf8_unicode_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '=' - https://phabricator.wikimedia.org/T261319 (mepps) This has been deployed but we just need to confirm it works as expected. [16:30:47] Wikimedia-Fundraising-Banners: Max donation error message appears cut off - https://phabricator.wikimedia.org/T261429 (jbolorinos-ctr) [16:38:08] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Bug: Illegal mix of collations (utf8_unicode_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '=' - https://phabricator.wikimedia.org/T261319 (mepps) I confirmed this works! The message became cid 45620886 soon after deployment of the... [16:38:22] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Bug: Illegal mix of collations (utf8_unicode_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '=' - https://phabricator.wikimedia.org/T261319 (mepps) Open→Resolved a:mepps [16:48:02] Wikimedia-Fundraising-Banners: Max donation error message appears cut off - https://phabricator.wikimedia.org/T261429 (jbolorinos-ctr) a:jbolorinos-ctr→None [17:05:02] Fundraising-Backlog, fundraising Sprint Q 2020 for real, FR-Ingenico, MediaWiki-extensions-DonationInterface: Ingenico donation fails on Hungarian descriptor too long - https://phabricator.wikimedia.org/T261058 (Ejegg) The API documentation describes the limit as 256 chars: https://epayments-api.... [17:06:08] so I had to read this twice [17:06:11] Walmart joins Microsoft bid for TikTok US [17:06:17] whoa [17:06:23] wtf walmart? [17:06:23] Walmart??? [17:06:53] sitting on lots of capital with no idea what to do with it? [17:07:01] yeah feels like that right? [17:07:13] "let's just buy an internet thingy" [17:07:27] feels like this will probably work out like AOL time warner [17:07:33] ha [17:07:55] https://on.ft.com/3lz43Cy link to the article [17:12:07] this whole thing just blows my mind. [17:16:29] Wikimedia-Fundraising-Banners: Max donation error message appears cut off - https://phabricator.wikimedia.org/T261429 (Pcoombe) What browser is this? I can't reproduce. Does it also happen on the updated version? https://fr.wikipedia.org/w/index.php?title=Wikipédia&banner=pcoombe_frFR_dsk_lg_refresh1&countr... [17:21:53] Wikimedia-Fundraising-Banners: Text and question mark are on separate lines - Opt-in text - https://phabricator.wikimedia.org/T261416 (Pcoombe) @jbolorinos-ctr I changed them to non-breaking spaces, does it look okay now? [18:02:54] Wikimedia-Fundraising-Banners: Inconsistent labels used for email input - https://phabricator.wikimedia.org/T261438 (jbolorinos-ctr) [18:05:06] Wikimedia-Fundraising-Banners: Inconsistent labels used for email input - https://phabricator.wikimedia.org/T261438 (jbolorinos-ctr) a:jbolorinos-ctr→None [18:09:24] Fundraising-Backlog: Missing spacing between : and text on payments wiki page - https://phabricator.wikimedia.org/T261439 (jbolorinos-ctr) [18:18:09] Fundraising-Backlog: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (Urbanecm) [18:46:21] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) The doc above seems super useful in terms of the actual process. For example, we'll need to set up a whole new clean Drupal 8 site and then "migrate" using a module. I s... [18:48:34] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) Oh hey, this might be useful: https://www.drupal.org/project/drupalmoduleupgrader. [18:52:31] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) I also read through the known issues for 7 to 8 upgrades and most don't apply to us. They mention something about blocked ips and the ban_ip table but we have a blocked_... [18:59:33] Wikimedia-Fundraising-Banners: Text and question mark are on separate lines - Opt-in text - https://phabricator.wikimedia.org/T261416 (jbolorinos-ctr) Thanks Peter! Looks great now! Thanks you for the quick fix! :) {F32197894} [19:02:22] Wikimedia-Fundraising-Banners: Max donation error message appears cut off - https://phabricator.wikimedia.org/T261429 (jbolorinos-ctr) Hey Peter, I just verified this is no longer happening on the updated link. This was using Chrome on Windows (updating task details now) {F32197898} Feel free to close thi... [19:03:41] Wikimedia-Fundraising-Banners: Max donation error message appears cut off - https://phabricator.wikimedia.org/T261429 (jbolorinos-ctr) [19:06:00] Wikimedia-Fundraising-Banners: [Candidate] FR Banners due Aug 28 - https://phabricator.wikimedia.org/T259833 (Pcoombe) [19:06:08] Wikimedia-Fundraising-Banners: Text and question mark are on separate lines - Opt-in text - https://phabricator.wikimedia.org/T261416 (Pcoombe) Open→Resolved a:Pcoombe [19:26:22] fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561 (CCogdill_WMF) Update! The link tracking domain removed support for TLS 1.0 and 1.1, so now score higher: https://www.immuniweb.com/ssl/?id=de0FYntW Can we revisit this? [19:54:31] Wikimedia-Fundraising-Banners: Max donation error message appears cut off - https://phabricator.wikimedia.org/T261429 (Pcoombe) Open→Resolved a:Pcoombe [19:54:33] Wikimedia-Fundraising-Banners: [Candidate] FR Banners due Aug 28 - https://phabricator.wikimedia.org/T259833 (Pcoombe) [19:58:54] Wikimedia-Fundraising-Banners: [Candidate] FR Banners due Aug 28 - https://phabricator.wikimedia.org/T259833 (Pcoombe) [19:58:56] Wikimedia-Fundraising-Banners: Inconsistent labels used for email input - https://phabricator.wikimedia.org/T261438 (Pcoombe) Open→Resolved a:Pcoombe Thanks @jbolorinos-ctr. I've changed the translation to "Adresse de courriel". [20:44:13] (CR) Jgleeson: "> Patch Set 1:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622456 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [20:49:46] (CR) Jgleeson: [C: +2] "Managed to trigger this behaviour merging 'Jimmy Wales' and 'Jimy Wales' and the cache key worked as expected. Nice work!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622456 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [20:50:33] (CR) Jgleeson: [C: +2] "low-hanging review fruit here! nice work" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622450 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [20:57:11] (Merged) jenkins-bot: Fix deduper to use psr16 compliant cache keys [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622456 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [20:57:13] (Merged) jenkins-bot: Fix for occassional test issues with rpow enabled [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622450 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [20:58:04] Wikimedia-Fundraising-Banners: Inconsistent labels used for email input - https://phabricator.wikimedia.org/T261438 (jbolorinos-ctr) [20:59:37] Wikimedia-Fundraising-Banners: Inconsistent labels used for email input - https://phabricator.wikimedia.org/T261438 (jbolorinos-ctr) Thanks so much for the quick fix Peter! Fix verified now {F32197967} [21:00:03] thanks jgleeson [21:09:13] fundraising-tech-ops, fr-tech-ops-okr: Update staging to match production (php, buster) - https://phabricator.wikimedia.org/T260629 (Dwisehaupt) Open→Resolved [21:09:15] fundraising-tech-ops, fr-tech-ops-okr: Upgrade payments servers to Debian Buster - https://phabricator.wikimedia.org/T256146 (Dwisehaupt) [21:14:00] If anyone wants to look at this I'm happy to explain it :-) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/622453 - it's basically just 'telling civi about the contact_id field in the mailing_provider_data table' [21:15:39] (PS5) Eileen: Add 'pretend' FK to MailingProviderData so entities will be updated on merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622453 (https://phabricator.wikimedia.org/T220149) [21:37:05] looking eileen [21:37:40] thanks ejegg - [21:38:08] np eileen ! [21:38:36] jgleeson: nice to be able to 'resolve' some phabs without those lingering bits [21:38:38] I liked the drop down select list for the namepair resolver [21:38:56] :-) [21:38:57] very nice touch [21:38:59] :) [21:39:32] oh this one is maybe so no- brainer I should self -merge we haven't migrated address [21:39:43] opps that paste went wrong [21:39:51] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/622697 [21:40:20] (PS2) Eileen: Remove added in error file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622697 [21:42:07] ejegg: re:the logstream patch. I'm thinking as it was a little tricky to plugin the new version of smashpig into civicrm last time that I could just review that in my smashpig checkout locally testing with a quick maintenance script which adds and removes a log stream? [21:42:14] (PS6) Ejegg: Add 'pretend' FK to MailingProviderData so entities will be updated on merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622453 (https://phabricator.wikimedia.org/T220149) (owner: Eileen) [21:42:18] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (Eileenmcnaughton) [21:42:38] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Readonly DB connection available to turn on - https://phabricator.wikimedia.org/T237350 (Eileenmcnaughton) Open→Resolved Done [21:42:44] (CR) Ejegg: [C: +2] "Clever! And I like how concise a merge test you're able to make these days." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622453 (https://phabricator.wikimedia.org/T220149) (owner: Eileen) [21:48:59] jgleeson sure, that would be the way to review it! [21:49:32] (Merged) jenkins-bot: Add 'pretend' FK to MailingProviderData so entities will be updated on merge [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622453 (https://phabricator.wikimedia.org/T220149) (owner: Eileen) [21:49:37] (CR) Ejegg: [C: +2] Remove added in error file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622697 (owner: Eileen) [21:50:02] fr-tech I've just quickly scanned through the ingenico incident report and it feels like it paints a far prettier than we experienced [21:50:12] picture* [21:51:17] lemme see if I can work out how many txns failed due to timeouts during that spell [21:56:17] (Merged) jenkins-bot: Remove added in error file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622697 (owner: Eileen) [21:57:33] (PS2) Eileen: Add code and test to move over mailing provider data when we permanently delete a contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622464 (https://phabricator.wikimedia.org/T220149) [22:02:03] (PS1) Esanders: Use struct equality per the styleguide [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/622892 [22:05:35] ejegg: do you have time to check this too? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/622464 if not I'll deploy the one you just reviewed now [22:06:03] sure thing eileen [22:10:15] (PS1) Esanders: build: Update eslint-config-wikimedia to 0.17.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/622894 [22:19:52] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622464 (https://phabricator.wikimedia.org/T220149) (owner: Eileen) [22:27:08] (Merged) jenkins-bot: Add code and test to move over mailing provider data when we permanently delete a contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622464 (https://phabricator.wikimedia.org/T220149) (owner: Eileen) [22:32:30] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/622901 [22:32:44] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/622901 (owner: Eileen) [22:53:18] deploying now [22:54:53] !log civicrm revision changed from 481ab742db to a942537984, config revision is e2ab4d7c1f [22:54:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:57:38] OK - I have aa commit in process control to turn back on delete deleted contacts if anyone wants to check it. I left it off until the patch to do a pre-delete fix on mailing provider data was deployed [23:02:23] Fundraising Sprint Pseudopretzels, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe: Civi dedupe: make sure Mailing Events data is merged - https://phabricator.wikimedia.org/T220149 (Eileenmcnaughton) @MBeat33 @krobinson @EYener Going fo... [23:02:25] Fundraising Sprint Pseudopretzels, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe: Civi dedupe: make sure Mailing Events data is merged - https://phabricator.wikimedia.org/T220149 (Eileenmcnaughton) [23:09:48] (CR) Jgleeson: [C: +2] "Tested this with a maintenance script and worked as expected! Nice work!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617483 (owner: Ejegg) [23:10:19] (Merged) jenkins-bot: Allow disabling log streams by type [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/617483 (owner: Ejegg) [23:10:45] ouch contact_id is a varchar! [23:17:04] (PS1) Eileen: Add handling for schema erg to prevent slow queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/622907 (https://phabricator.wikimedia.org/T220149) [23:17:40] can someone look at this somewhat urgently - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/622907 [23:18:23] cstone: XenoRyet ? - that last deploy is creating slow queries because civicrm_mailing_provider_data.contact_id is unnexpectedly a varchar [23:21:25] or mepps ejegg|afk [23:21:30] or jgleeson [23:21:38] it's causing jobs to fail :-( [23:24:03] (PS1) Eileen: Fix index bypass due to wrong data type on contaact_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622909 [23:24:43] (CR) jerkins-bot: [V: -1] Add handling for schema erg to prevent slow queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/622907 (https://phabricator.wikimedia.org/T220149) (owner: Eileen) [23:25:51] hmm - not quite right - but checking [23:28:31] hey eileen I'm back [23:28:51] cstone: cool - it must not be quite right yet - just checkinng [23:29:03] but the issue is it is doing WHERE contact_id = 5 [23:29:17] but it's a varchar so slow without WHERE contact_id = '5' [23:29:22] ahhh [23:29:31] (it shouldn't be a varchar I don't think but....) [23:30:19] (PS2) Eileen: Add handling for schema erg to prevent slow queries [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/622907 (https://phabricator.wikimedia.org/T220149) [23:30:28] ok test issue was easy [23:31:05] oh hmm, failmail [23:31:41] ejegg: yep it's the deploy I just did [23:31:53] ah yeah, just reading backscroll [23:31:58] turns out civicrm_mailing_provider_data.contact_id is a varchar not an int [23:32:01] well, that's fun [23:32:09] so I have 2 patchs for quickfix handling [23:32:22] looking at the first one [23:33:49] (CR) Ejegg: [C: +2] "Ooh, hacky place for this fix. Looks like it should get us running for now though!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/622907 (https://phabricator.wikimedia.org/T220149) (owner: Eileen) [23:36:31] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622911 [23:36:40] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622911 (owner: Eileen) [23:40:03] ok, looking at the other too [23:40:39] (PS2) Ejegg: Fix index bypass due to wrong data type on contact_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622909 (owner: Eileen) [23:41:35] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622911 (owner: Eileen) [23:41:59] I'm tempted to bypass zull on that - it's like 3 * 7 mins IF it works right [23:42:00] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622909 (owner: Eileen) [23:42:15] yep, I'd be fine with a force on this [23:43:29] (CR) Eileen: [V: +2 C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622911 (owner: Eileen) [23:44:30] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/622912 [23:44:40] (CR) Eileen: [V: +2 C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/622912 (owner: Eileen) [23:46:00] ejegg: I just realised it's gonna sweep up my process control patch to re-enable delete deleted [23:46:12] when I deploy [23:46:27] you're deploying process-control or civicrm? [23:46:48] civi - but it seems to be grabbing that too [23:46:58] ahh, the fundraising_code_update step updates the p-c staging bit [23:47:17] but the rsync_blaster step won't push out the p-c directory if you specify civicrm [23:48:18] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/622913 [23:48:28] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/622913 (owner: Eileen) [23:48:34] ah ok [23:48:55] !log civicrm revision changed from a942537984 to 3d501e71d9, config revision is dd541a25dc [23:48:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:49:04] well the first patch is out then - phew [23:52:33] second one out too civicrm revision changed from 3d501e71d9 to 5e7352e2c3, config revision is dd541a25dc [23:53:24] ejegg: should I re-enabled delete deleted now (ie push from process control)