[01:55:12] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561 (DStrine) [02:11:01] Fundraising-Backlog, FR-Adyen: Restyle Adyen hosted page - https://phabricator.wikimedia.org/T261355 (DStrine) [02:11:20] Fundraising-Backlog, FR-Adyen: "Previous" navigation button does not work on Adyen payment form - https://phabricator.wikimedia.org/T260749 (DStrine) [02:11:59] Fundraising-Backlog, FR-Adyen: "Previous" navigation button does not work on Adyen payment form - https://phabricator.wikimedia.org/T260749 (DStrine) This has been merged into the polish task for next sprint. This will not be complete before the next test. [02:27:02] Fundraising-Backlog, FR-Adyen: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (DStrine) [02:28:04] Fundraising-Backlog, FR-Adyen: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (DStrine) [06:22:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:22:16] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:27:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:27:14] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:30:00] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic, FR-Email: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561 (CCogdill_WMF) [06:32:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:32:16] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:37:14] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:37:14] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1005:down [06:41:53] ACKNOWLEDGEMENT - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1005:down Dwisehaupt Under maint right now [06:41:53] ACKNOWLEDGEMENT - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1005:down Dwisehaupt Under maint right now [06:57:14] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [06:57:14] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [08:30:42] (PS1) AndyRussG: WIP First attempt at fixing state and fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623314 (https://phabricator.wikimedia.org/T236285) [08:33:39] (CR) jerkins-bot: [V: -1] WIP First attempt at fixing state and fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623314 (https://phabricator.wikimedia.org/T236285) (owner: AndyRussG) [08:37:38] (PS2) AndyRussG: WIP First attempt at fixing state and fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623314 (https://phabricator.wikimedia.org/T236285) [08:38:26] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real, and 3 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) a:AndyRussG [08:40:34] (CR) jerkins-bot: [V: -1] WIP First attempt at fixing state and fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623314 (https://phabricator.wikimedia.org/T236285) (owner: AndyRussG) [12:07:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1001:down [12:07:12] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1001:down [12:12:12] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1001:down [12:12:18] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1001:down [12:13:27] ACKNOWLEDGEMENT - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1001:down Dwisehaupt Known maintenance [12:13:27] ACKNOWLEDGEMENT - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1001:down Dwisehaupt Known maintenance [13:12:12] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [13:12:18] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [14:20:44] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/623390 [14:48:46] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/623390 (owner: Ejegg) [14:49:25] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/623390 (owner: Ejegg) [14:50:43] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/623397 [14:51:04] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/623397 (owner: Ejegg) [14:56:56] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/623397 (owner: Ejegg) [14:58:18] hmm [14:58:56] (CR) Ejegg: [V: +2 C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/623397 (owner: Ejegg) [15:19:16] ccccccfhrkhfficrbbfgcnndgihurinkcubicjklrrlr [15:19:18] derp [15:41:02] fundraising-tech-ops: procure and deploy new frmail server role - https://phabricator.wikimedia.org/T257245 (Papaul) [15:41:03] oh darn [15:41:09] fatal: bad object 399657e7d740790b6dd7d1f7bd658d86f642b64a [15:42:19] (PS1) Ejegg: Fix DonationInterface submodule pointer [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/623409 [15:42:33] (CR) Ejegg: [C: +2] Fix DonationInterface submodule pointer [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/623409 (owner: Ejegg) [15:47:08] (Merged) jenkins-bot: Fix DonationInterface submodule pointer [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/623409 (owner: Ejegg) [15:48:50] Fundraising-Backlog, fundraising Sprint Q 2020 for real: prototype moving to docker - https://phabricator.wikimedia.org/T260085 (mepps) From @jgleeson's end of day: I also got MediaWiki-Docker running in about 10 minutes which is exciting! [15:49:25] !log updated payments-wiki from ef7ebd08cb to be81063168 [15:49:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:04:44] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (mepps) @Eileenmcnaughton > YES - absolutely - we could do something like take one extension per sprint and migrate it to a CiviCRM extension. Do you think it'd be doable to mo... [16:35:31] (PS1) Ejegg: Truncate descriptor to 40 chars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623421 (https://phabricator.wikimedia.org/T261058) [16:41:37] fr-tech: i noticed something that may need investigation. when building out this dashboard i noticed there may be payments being queued on civi2001 for paypal: https://frmon.frdev.wikimedia.org/d/Pq1YNMviz/fundraising-overview?viewPanel=30&orgId=1&refresh=1m [16:41:44] i'm not sure if that is intended or not. [16:42:34] dwisehaupt: weird, what's running on civi2001? [16:42:52] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need By: 2020-09-30) rack/setup/install frmx2001.frack.codfw.wmnet, frdata2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T260183 (Papaul) [16:43:35] not sure. just noticed that. [16:43:56] i need to track down how this stat is collected. [16:44:01] p-c log subfolders are all empty there [16:45:23] could it be an old stat sitting in the prometheus spool dir? [16:46:14] it's not sitting at that same number forever, is it? [16:47:14] donations.prom there has a Jul 23 timestamp [16:47:25] ah yes. [16:47:31] there are a few jul23 files there. [16:47:36] let me clean those out. [16:48:20] that makes more sense. [16:48:35] thanks for the second set of eyes. [16:48:54] anytime [16:49:17] that's an interesting edge case that we may need to address since we currently don't clear prom files out. [16:49:44] yeah, we just rely on them being overwritten in a timely fashion [16:49:48] Wikimedia-Fundraising-Banners: Share banner for Sept 2 en6C test - https://phabricator.wikimedia.org/T261527 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z7e1fbce7dff8381f874 [16:49:57] i guess if we deleted them after a day that would work? [16:50:34] yeah. i'm trying to think if there is any reason that would be an issue. [16:53:56] fr-tech anyone want to give a quick look at a trivial truncation patch? https://gerrit.wikimedia.org/r/623421 [16:54:06] sure ejegg [16:54:12] thanks mepps [16:54:26] (CR) Mepps: [C: +2] Truncate descriptor to 40 chars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623421 (https://phabricator.wikimedia.org/T261058) (owner: Ejegg) [16:55:39] thanks! [16:58:15] hellooo fr-tech [16:58:19] hi AndyRussG ! [16:58:37] :) [16:58:39] * AndyRussG is back on New Zealand time [16:59:26] uff.. made the mistake of sticking my head outside. [17:01:14] dwisehaupt: oh.. what happened? [17:01:50] the wind shifted: https://www.purpleair.com/map?opt=1/mAQI/a10/cC0#11.99/37.76711/-122.44298 [17:02:18] (Merged) jenkins-bot: Truncate descriptor to 40 chars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623421 (https://phabricator.wikimedia.org/T261058) (owner: Ejegg) [17:03:15] dwisehaupt: oh no... forest fire smoke? [17:05:26] yeah. [17:27:12] (PS7) Ejegg: Add stats counter to contribution tracking qc so that we can record change of c_id exceptions and processing rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622196 (https://phabricator.wikimedia.org/T256037) (owner: Jgleeson) [17:27:54] (CR) Ejegg: [C: +2] "Looks good to merge! I'll make the changes from PS6 comments in another patch." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622196 (https://phabricator.wikimedia.org/T256037) (owner: Jgleeson) [17:27:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (DStrine) @CCogdill_WMF @MNoorWMF @KHaggard I believe you were going to contact legal on this. did you have any discussions about this or do you have any inf... [17:34:36] (Merged) jenkins-bot: Add stats counter to contribution tracking qc so that we can record change of c_id exceptions and processing rates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/622196 (https://phabricator.wikimedia.org/T256037) (owner: Jgleeson) [17:36:02] (PS1) Ejegg: Remove subsidiaries, rename 2 employer fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/623432 (https://phabricator.wikimedia.org/T260935) [17:36:50] (CR) jerkins-bot: [V: -1] Remove subsidiaries, rename 2 employer fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/623432 (https://phabricator.wikimedia.org/T260935) (owner: Ejegg) [17:58:11] (PS2) Ejegg: Remove subsidiaries, rename 2 employer fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/623432 (https://phabricator.wikimedia.org/T260935) [18:23:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (KHaggard) @CCogdill_WMF Were you going to contact legal? I'm not sure what we need to reach Legal for - but this task still stands and I was planning on cre... [18:45:49] Fundraising-Backlog: TY page for France: social media code visible - https://phabricator.wikimedia.org/T261683 (MBeat33) [18:48:47] Fundraising-Backlog: TY page for France: social media code visible - https://phabricator.wikimedia.org/T261683 (DStrine) a:Pcoombe [18:49:09] Fundraising-Backlog: TY page for France: social media code visible - https://phabricator.wikimedia.org/T261683 (DStrine) @Pcoombe @spatton [19:08:24] (PS1) Ejegg: Stats collector and CT Queue Consumer cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623441 (https://phabricator.wikimedia.org/T256037) [19:08:43] ok mepps, there's the follow-up patch for c_t stats ^^^ [19:16:14] (CR) jerkins-bot: [V: -1] Stats collector and CT Queue Consumer cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623441 (https://phabricator.wikimedia.org/T256037) (owner: Ejegg) [19:16:51] oops, what's that -1 [19:16:52] ? [19:17:39] oh, test needs update [19:19:27] (PS2) Ejegg: Stats collector and CT Queue Consumer cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623441 (https://phabricator.wikimedia.org/T256037) [19:58:45] (PS4) Cstone: Update Mustache for LightnCandy 1.2.5 for MediaWiki 1.35 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/622401 (https://phabricator.wikimedia.org/T260621) [19:59:50] (CR) jerkins-bot: [V: -1] Update Mustache for LightnCandy 1.2.5 for MediaWiki 1.35 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/622401 (https://phabricator.wikimedia.org/T260621) (owner: Cstone) [20:01:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries running during queue processing - https://phabricator.wikimedia.org/T261688 (Eileenmcnaughton) [20:02:32] Fundraising-Backlog: Grafana graph of wmf_civicrm_contribution_message_import - https://phabricator.wikimedia.org/T261689 (DStrine) [20:15:43] Fundraising-Backlog: Investigate whether dedupe contacts is really timing out - https://phabricator.wikimedia.org/T261317 (DStrine) [20:24:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries running during queue processing - https://phabricator.wikimedia.org/T261688 (DStrine) [20:24:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries in queue import - https://phabricator.wikimedia.org/T261163 (DStrine) [20:27:29] Fundraising-Backlog: Bug: Silverpop nightly jobs failed due to session limits - https://phabricator.wikimedia.org/T261211 (Eileenmcnaughton) This might be as simple as disabling omnihelll drush cvapi Setting.create omnimail_omnihell_enabled=0 } [20:36:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries running during queue processing - https://phabricator.wikimedia.org/T261688 (DStrine) [20:38:02] Fundraising-Backlog: Grafana graph of wmf_civicrm_contribution_message_import - https://phabricator.wikimedia.org/T261689 (mepps) As a developer, I want to see how long each phase of a donation import takes [20:39:12] Fundraising-Backlog: Grafana graph of wmf_civicrm_contribution_message_import - https://phabricator.wikimedia.org/T261689 (mepps) From @Ejegg at the end of the process sending how long each api call took. [20:41:31] Fundraising Sprint Pseudopretzels, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising Sprint Q 2020 for real, FR-Civi-Dedupe: Civi dedupe: make sure Mailing Events data is merged - https://phabricator.wikimedia.org/T220149 (Eileenmcnaughton) Open→Resolved [20:48:07] Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real, MW-1.36-notes (1.36.0-wmf.6; 2020-08-25): Untranslated error text on payments wiki page - https://phabricator.wikimedia.org/T259528 (Ejegg) Open→Resolved [20:52:58] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (Ejegg) Two modules that occur to me as easy-ish to start with would be the exchange rates updater and the large donation notifications. [21:05:11] Wikimedia-Fundraising-Banners: Share banner for Sept 2 en6C test - https://phabricator.wikimedia.org/T261527 (spatton) [21:05:13] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 02 - https://phabricator.wikimedia.org/T261695 (spatton) [21:13:59] Wikimedia-Fundraising-Banners: 2020-09-02 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T261697 (spatton) [21:14:44] Wikimedia-Fundraising-Banners: 2020-09-02 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T261697 (spatton) [21:21:36] Wikimedia-Fundraising-Banners: 2020-09-02 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T261700 (spatton) [21:22:28] Wikimedia-Fundraising-Banners: 2020-09-02 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T261697 (spatton) p:Triage→High [21:22:32] Wikimedia-Fundraising-Banners: 2020-09-02 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T261698 (spatton) p:Triage→High [21:23:49] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 02 - https://phabricator.wikimedia.org/T261695 (spatton) [21:36:07] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 02 - https://phabricator.wikimedia.org/T261695 (jbolorinos-ctr) Thanks Sam! Getting started on these now and I'll ping you if anything comes up. [21:49:47] Fundraising-Backlog: Rogue contacts in _all_wikimedia database preventing accurate queries - https://phabricator.wikimedia.org/T261705 (KHaggard) [21:50:02] Fundraising-Backlog: Rogue contacts in _all_wikimedia database preventing accurate queries - https://phabricator.wikimedia.org/T261705 (KHaggard) p:Triage→Low [21:52:44] Fundraising Sprint Pseudopretzels, Fundraising-Backlog: Add two additional fields to silverpop export - https://phabricator.wikimedia.org/T257597 (KHaggard) Updating this thread, the two new fields are in the database and functioning. However, I cannot confirm with certainty that all contacts in the data... [21:56:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Conflicting fields in some Acoustic contact records - https://phabricator.wikimedia.org/T254304 (KHaggard) New phab for investigating the weird contacts we can't place: T261705 [22:04:13] Fundraising-Backlog, fundraising Sprint Grep works IRL, MediaWiki-extensions-CentralNotice, Epic: EPIC: Find alternative to Special:HideBanners cookies to mitigate the loss of 3rd-party cookie support - https://phabricator.wikimedia.org/T244699 (DStrine) [22:04:15] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hide banner cookie - https://phabricator.wikimedia.org/T251780 (DStrine) Open→Declined [22:05:11] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (Eileenmcnaughton) | module | proposed destination|notes |contribution_tracking|extension wmf_civicrm|we should look at moving the table into the civi-db - the module JUST defin... [22:06:53] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (Eileenmcnaughton) @DStrine the above is what @mepps suggested I think - is there more you need? [22:12:13] cstone: is there anything I can do to help on https://phabricator.wikimedia.org/T255317 (otherwise I'll just focus on chores for the rest of the day) [22:26:49] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (DStrine) >>! In T251914#6423904, @mepps wrote: > @Eileenmcnaughton > YES - absolutely - we could do something like take one extension per sprint and migrate it to a CiviCRM ext... [22:38:10] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (Eileenmcnaughton) @DStrine yes that's correct. Then at switch over time the only thing we'd need to juggle is the user ids for the new db - there is a record in the table civic... [22:39:37] Fundraising-Backlog, fundraising Sprint Q 2020 for real: Investigate drupal upgrade - https://phabricator.wikimedia.org/T251914 (DStrine) Ok thanks then I think this is all I need for now. We could probably close this. [22:46:14] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hide banner cookie - https://phabricator.wikimedia.org/T251780 (Urbanecm) Just out of curios... [23:02:56] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hide banner cookie - https://phabricator.wikimedia.org/T251780 (DStrine) Declined→Open [23:04:20] Fundraising Sprint MySQL is YourSQL and WeSQL, Fundraising Sprint Nyan cats for everyone, Fundraising-Backlog, fundraising Sprint Grep works IRL, and 4 others: TY pages in a subdomain of wikipedia and set hide banner cookie - https://phabricator.wikimedia.org/T251780 (DStrine) This is done from m... [23:34:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM queue fail due to emjois in address - https://phabricator.wikimedia.org/T261713 (Eileenmcnaughton) [23:35:25] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising-Backlog, fundraising Sprint Q 2020 for real: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (Eileenmcnaughton) Logged https://phabricator.wikimedia.org/T261713 [23:37:43] so all these endless adyen donor details missing - do we do anything with them? [23:43:46] AndyRussG: are you OK with me abandonning this - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/355275 it's very old so I'm assuming it's not going anywhere [23:44:55] eileen: hmmm maybe let me take a look first? [23:45:38] Looks like it was +2'ed but never actually merged... Maybe the same functionality was merged in another patch? I could take a peek a bit later [23:45:55] I have a vague memory of it being a pretty simple thing [23:46:14] in any case thanks for the ping about messy old Gerrit cruft!!! In general there is a bunch of cleanup to do there, for sure! [23:46:40] yeah - I figure that if it hasn't been important for 3 years it might not be now [23:47:05] heheh I'm trying to remember exactly what it was about [23:47:40] ohhhh I remember now, it was like a little code cleanup thing [23:47:44] might be still mergeable [23:48:00] or mergeable with just a little fiddling [23:48:29] Hmm says "Merge if Necessary" [23:48:44] Yeah it was code clean-up following the implementation of the banner sequence feature [23:50:29] yeah I guess it might be the time could be as well spent on something else now though? I don't feel able to review it