[10:08:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (krobinson) We had another example of a confused donor: CID 14238272 / ZD 796016. Donor created a new rec... [13:21:25] fundraising-tech-ops: procure and deploy new frmail server role - https://phabricator.wikimedia.org/T257245 (Jclark-ctr) [20:30:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (Eileenmcnaughton) What is the process by which they create the new ones? They just do it themselves onlin... [20:41:46] so this might shut up those failmails jgleeson https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/623883/1 [20:43:43] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Patch-For-Review: Bug: Silverpop nightly jobs failed due to session limits - https://phabricator.wikimedia.org/T261211 (Eileenmcnaughton) https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/623883/1 is the main patch at this... [20:44:12] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi point release - https://phabricator.wikimedia.org/T261359 (Eileenmcnaughton) a:Eileenmcnaughton [21:06:55] (PS1) Eileen: 5.30-rc upgrade (stock) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) [21:06:57] (PS1) Eileen: re-add remaining wmf hacks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625728 (https://phabricator.wikimedia.org/T261359) [21:09:10] (CR) jerkins-bot: [V: -1] re-add remaining wmf hacks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625728 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [21:09:12] (CR) jerkins-bot: [V: -1] 5.30-rc upgrade (stock) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [21:16:58] (PS1) Eileen: Remove obsolete upgrade command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625729 (https://phabricator.wikimedia.org/T261359) [21:18:06] (PS2) Eileen: Remove obsolete upgrade command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625729 (https://phabricator.wikimedia.org/T261359) [21:19:21] hey eileen, how goes it? I was just finishing off setting up my standing dsk [21:19:24] desk* [21:19:42] oh cool - yeah all good here - just hit a weird error though [21:20:25] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/3410/console - I'm not sure if it relates to the change I'm making (updating civi) [21:21:00] this will get rid of the actual line https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625729 - but I suspect it will just bump down to the next one.... [21:21:33] missing exts ? [21:22:22] 22:08:24 WARNING: Failed to find recommended PHP extension "imap". [21:22:23] 22:08:24 WARNING: Failed to locate the PHP "mcrypt" extension. Please install this manually to avoid issues with SMTP passwords or older versions of CiviCRM. [21:22:25] 22:08:24 WARNING: Failed to find recommended PHP extension "soap". [21:22:27] 22:08:24 WARNING: Failed to locate command "node". NodeJS (http://nodejs.org/) is required for development of CiviCRM v4.6+. [21:22:29] 22:08:24 WARNING: Failed to locate command "npm". NodeJS (http://nodejs.org/) is required for development of CiviCRM v4.6+. [21:22:31] eileen: ^ [21:22:35] I see that hidden amongst the jenkins output [21:22:40] hmmm - is that new though? [21:22:50] good question [21:22:50] it's the db error that is failing [21:23:03] https://www.irccloud.com/pastebin/5ZhGHDsP/ [21:23:07] ug [21:23:16] PDOException: SQLSTATE[HY000] [1102] Incorrect database name [21:23:53] it's failing on us using drupal queries to alter the civi db - which is legacy stuff [21:24:13] strange [21:24:36] db name looks good in the code you removed [21:24:43] in that patch you linked [21:25:10] yeah - but this function wmf_civicrm_get_dbs ideally would be entirely removed from our code... [21:33:43] (PS1) Eileen: Remove code that adds indexes to civicrm_entity_tag [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625730 (https://phabricator.wikimedia.org/T261359) [21:34:20] jgleeson: are you OK to +2 that first one - then I'll re-run & confirm it just stumbles down to the next one [21:35:27] I was just pulling it down locally to run the unit tests. it's a tricky one to do a full test locally I guess? [21:35:29] eileen: [21:35:31] ^ [21:35:58] that first one - or the whole thing? [21:36:33] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/623883 [21:36:42] I'm looking at that one, the silverpop thing [21:36:53] oh yeah - that's a pain [21:36:57] do you mean the .install thingy? [21:37:32] yeah I just meant this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625729 [21:38:00] of course I wouldn't want to stand in your way on silverpop - probably easier to test on staging or to step through the unit tests [21:38:46] (CR) Jgleeson: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625729 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [21:45:47] (Merged) jenkins-bot: Remove obsolete upgrade command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625729 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [21:46:51] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [21:54:32] jgleeson: so this is a bit odd - with that gone I thought it would just fail at the next one - ie https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625730 but it's skipping that one & failing at wmf_civicrm_update_7014( [22:01:26] :| [22:02:00] hmmm [22:02:53] we had donation qc failmail early am today and it looks like a donor submited a postal code with a quote.. or an encoded quote character. "postal_code":"112”1" [22:03:05] which is kinda worrying [22:03:22] (PS1) Eileen: Explicitly call _wmf_civicrm_update_custom_fields() from install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625732 (https://phabricator.wikimedia.org/T261359) [22:04:21] hmm - what should happen in that case? [22:05:30] are you OK to +2 this one too? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625730 (trying to work through this test fail & I guess any tidy up will help move us towards getting off drupal tidy up) [22:06:29] eileen: I'm not sure how mysql handles that but ideally we'd want all quotish things removed before they get near the db [22:07:01] they could just be escaped but we are rejecting instead? [22:08:11] I'm assuming our field validation should be picking that upo [22:08:14] -o [22:10:36] you'd think [22:12:36] (PS1) Eileen: Start moving wmf_contribution_extra field creation to custom_fields function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625733 (https://phabricator.wikimedia.org/T261359) [22:13:39] Fundraising-Backlog: Donations queue consumer failed - Invalid character input in postal code - https://phabricator.wikimedia.org/T262232 (jgleeson) [22:14:57] (CR) jerkins-bot: [V: -1] Start moving wmf_contribution_extra field creation to custom_fields function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625733 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:15:59] (CR) Jgleeson: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625730 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:16:22] eileen: that last one makes sense but I'm kinda approving on faith alone! [22:16:36] (PS2) Eileen: Start moving wmf_contribution_extra field creation to custom_fields function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625733 (https://phabricator.wikimedia.org/T261359) [22:17:07] jgleeson: yeah - fundamentally though these only affect our dev environments [22:17:14] they won't run again on prod [22:17:25] oh ok that makes me feel better [22:17:32] :) [22:21:32] (PS1) Eileen: Move another field out of general field list to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625734 (https://phabricator.wikimedia.org/T26135) [22:23:12] (Merged) jenkins-bot: Remove code that adds indexes to civicrm_entity_tag [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625730 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:24:10] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:26:46] it's annoying I can't make the civicrm patch run over a specific version of the main repo [22:27:40] still failing on in wmf_civicrm_update_7014() (line 754 of [22:28:30] (PS2) Eileen: Move another field out of general field list to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625734 (https://phabricator.wikimedia.org/T26135) [22:28:44] - which can also go.... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625734 [22:29:26] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, FR-Adyen: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (jgleeson) a:jgleeson [22:29:49] (CR) Eileen: Move another field out of general field list to update_custom_fields (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625734 (https://phabricator.wikimedia.org/T26135) (owner: Eileen) [22:36:34] (PS1) Eileen: Remove statement to alter preferred_language length from upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625735 (https://phabricator.wikimedia.org/T261359) [22:40:18] so the only thing that has changed that would be causing test fails that I can think of is some work in civi to support db ssl connnections. I think that must be messing with our db_switcher in a way that is likely very specific to the docker tests. I figure if I can get rid of the calls to it from install then hopefully it will at least run the tests (they call that code too but it seems easier to debug if the tests [22:40:18] actually start) [22:41:18] eileen: I'm jumping off in a few mins, do you need anything pushing through before I do? [22:41:35] jgleeson: if you are oK to do them then a couple more would really help [22:41:46] they only affect dev [22:41:47] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625732 [22:42:37] & actually the creation of the group is required for tests to pass [22:42:55] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625734/2 is the actual one that is currently causing test faills [22:43:34] sure [22:46:50] (CR) Jgleeson: [C: +2] "Looks good and makes things clearer!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625732 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:50:21] Fundraising-Backlog: Donations queue consumer failed - Invalid character input in postal code - https://phabricator.wikimedia.org/T262232 (jgleeson) [22:53:28] (Merged) jenkins-bot: Explicitly call _wmf_civicrm_update_custom_fields() from install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625732 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:57:22] (CR) Jgleeson: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625734 (https://phabricator.wikimedia.org/T26135) (owner: Eileen) [22:59:52] those two are +2'd eileen [22:59:59] just those? [23:00:19] this one is in between them I think https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625733 [23:08:19] (CR) Jgleeson: [C: +2] "Looks like some good clean up!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625733 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [23:08:30] thanks jgleeson ! [23:08:36] np, nice work! [23:09:00] yeah - it all helps when we do the drupal upgrade too [23:09:19] yeah and we can take all the help we can get right [23:10:54] have a good one eileen o/ [23:15:38] (Merged) jenkins-bot: Start moving wmf_contribution_extra field creation to custom_fields function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625733 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [23:15:40] (Merged) jenkins-bot: Move another field out of general field list to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625734 (https://phabricator.wikimedia.org/T26135) (owner: Eileen) [23:16:38] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [23:57:05] (PS1) Eileen: Remove upgrade command to alter report menu items [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625739 (https://phabricator.wikimedia.org/T261359)