[02:07:26] (PS1) Eileen: Remove extraneous wmf_civicrm_get_dbs() [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625766 (https://phabricator.wikimedia.org/T261359) [02:07:30] (PS1) Eileen: Remove upgrade commands for wmf_fredge_qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625767 (https://phabricator.wikimedia.org/T261359) [02:19:57] (PS1) Eileen: IDE code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625768 [02:52:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Civi: search & export missing some email addresses - https://phabricator.wikimedia.org/T262100 (Eileenmcnaughton) The contact's email was not marked primary. This has been an ongoing low-volume problem. I ran the command drush cva... [03:08:28] (PS1) Eileen: Join the brave new world of 2010 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 [03:26:32] (CR) jerkins-bot: [V: -1] Join the brave new world of 2010 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 (owner: Eileen) [03:28:49] (PS2) Eileen: Join the brave new world of 2010 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 [03:33:28] (PS3) Eileen: Join the brave new world of 2010 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 [04:51:24] (CR) Eileen: "This helps -https://github.com/civicrm/civicrm-buildkit/pull/557 - will merge that tomorrow" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 (owner: Eileen) [06:44:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (krobinson) Yes, these are donors who realise their card is going to expire or has been stolen and the don... [13:31:52] tzag fr-tech! [13:42:52] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) @krobinson I did, thank you! I'm just trying to figure out where the extra fr- is getting generated. [13:45:47] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 10 - https://phabricator.wikimedia.org/T262277 (spatton) [13:46:57] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) a:mepps [13:47:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Yubico_endpoint_critical 1 [=1] [13:47:15] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1006:down [13:52:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1],GlobalCollect_endpoint_critical 1 [=1] [13:52:17] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1006:down [13:53:13] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (spatton) [13:53:46] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262280 (spatton) [13:54:59] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262281 (spatton) [13:55:34] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262282 (spatton) [13:57:11] RECOVERY - check_log_messages on frav1002 is OK: OK [13:57:11] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1006:down [13:57:15] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1006:down [14:00:39] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262282 (spatton) [14:01:40] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (spatton) [14:02:11] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1008:down [14:02:15] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [14:02:51] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262280 (spatton) [14:03:53] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262281 (spatton) [14:04:16] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (spatton) [14:04:23] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262280 (spatton) [14:04:29] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262281 (spatton) [14:07:11] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [14:09:39] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 10 - https://phabricator.wikimedia.org/T262277 (spatton) Hey @jbolorinos-ctr, here's this week's test. My advice is to spotcheck each country to ensure that the reduced minimum appears in the message and form, but not to run a functionality tes... [14:10:05] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 10 - https://phabricator.wikimedia.org/T262277 (spatton) [14:11:26] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (spatton) [14:12:10] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262280 (spatton) [14:12:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1],GlobalCollect_endpoint_critical 2 [=1],Paypal_endpoint_critical 1 [=1] [14:12:15] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1006:down [14:12:35] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262281 (spatton) [14:12:55] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262282 (spatton) [14:14:07] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 6 minutes ago with 2 failures. Failed resources (up to 3 shown): File[/etc/rssh.conf],File[/etc/vim/vimrc.local] [14:17:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1],Astropay-DLocal_endpoint_critical 1 [=1],Yubico_endpoint_critical 1 [=1] [14:17:17] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [14:18:21] RECOVERY - check_puppetrun on payments1004 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [14:22:11] RECOVERY - check_log_messages on frav1002 is OK: OK [15:48:34] tzag fr-tech [15:48:47] Did I miss some excitement with paypal this morning? [15:58:39] howdy XenoRyet. i missed it too but looks like there was a prod switch issue. should have more data soon but everything should be back to normal at this point. [15:59:24] Good to know, thanks [16:01:17] ohi here too :) [16:03:11] for today's extracurricular activities, M is starting his Oregon school today. Since everyone is remote right now anyway, there was no point in waiting until we get up there to start him, so we figured he could just start with the rest of his new class. [16:04:13] fundraising-tech-ops, Operations, netops, observability: update nagios_nsca configuration in frack for new nsca servers - https://phabricator.wikimedia.org/T262291 (Jgreen) [16:06:31] XenoRyet: ah interesting! yeah makes sense [16:06:59] XenoRyet: ha. nice. makes total sense. [16:31:30] (CR) Ejegg: "But if we stop saying the words, will the planes ever drop cargo again?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 (owner: Eileen) [16:49:20] Wikimedia-Fundraising-Banners: Missing frb-greeting emoji on Mac OS 10.10 and Windows 8.1 - https://phabricator.wikimedia.org/T261976 (Pcoombe) For context: Windows 8 is about 3.1% of desktop requests https://analytics.wikimedia.org/dashboards/browsers/#desktop-site-by-os/os-family-and-major-hierarchical-vie... [17:09:29] fundraising-tech-ops, Operations, netops, observability: update nagios_nsca configuration in frack for new nsca servers - https://phabricator.wikimedia.org/T262291 (Jgreen) [17:30:05] (CR) jerkins-bot: [V: -1] WIP: Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) (owner: Cstone) [17:36:50] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, and 4 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) Hi! The pat... [17:37:59] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fundraising Sprint Quackery limited to ducks, MediaWiki-extensions-CentralNotice, Patch-For-Review: Improve state component's munging of new data added for Campaign Fallback - https://phabricator.wikimedia.org/T232235 (AndyRus... [17:39:53] (PS3) Ejegg: Update vendor for merged fundraising deps [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/620118 (owner: Cstone) [17:40:29] (CR) Ejegg: [V: +2 C: +2] Update vendor for merged fundraising deps [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/620118 (owner: Cstone) [17:42:16] (PS1) Ejegg: Update FundraisingEmailUnsubscribe for new PHPUnit [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/625944 [17:45:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Adapt banner history for campaign fallback - https://phabricator.wikimedia.org/T236285 (AndyRussG) [17:45:38] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Can we allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969 (AndyRussG) [17:49:21] Wikimedia-Fundraising-Banners: Japan banner emojis - https://phabricator.wikimedia.org/T261972 (jbolorinos-ctr) Screenshot Test Results - Desktop: - https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/ze1a7189f5d28272cb72 [17:50:07] (CR) jerkins-bot: [V: -1] Update FundraisingEmailUnsubscribe for new PHPUnit [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/625944 (owner: Ejegg) [17:57:34] Wikimedia-Fundraising-Banners: Missing frb-greeting emoji on Mac OS 10.10 and Windows 8.1 - https://phabricator.wikimedia.org/T261976 (jbolorinos-ctr) Thanks for the context Peter! I also noticed the only browser that displays the frb-greeting emoji correctly on these operating systems is Firefox, so possib... [18:03:00] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) So based on the code, this should mean somewhere locale is getting passed to the thank you module as... [18:03:27] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, and 4 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) More fallba... [18:04:26] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, and 4 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (AndyRussG) Also, if an... [18:22:16] (Abandoned) Ejegg: Update test declarations for new PHPUnit [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/624736 (owner: Ejegg) [18:39:36] (CR) Ejegg: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623619 (owner: Ejegg) [18:41:17] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Recurring-Donations, fr-donorservices: PayPal recurring: cycle of authorization reversals? - https://phabricator.wikimedia.org/T249951 (DStrine) [18:41:19] Fundraising-Backlog: Paypal recurring indicated on One Time transactions - https://phabricator.wikimedia.org/T261994 (DStrine) [18:41:24] Fundraising-Backlog, Android-app-Bugs, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (LGoto) [18:42:37] Fundraising Sprint Heaven is a page on Wikipedia, Fundraising Sprint Ice cream cures everything, Fundraising-Backlog, Recurring-Donations, fr-donorservices: PayPal recurring: cycle of authorization reversals? - https://phabricator.wikimedia.org/T249951 (DStrine) @EMartin I'm folding T261994 i... [18:53:45] (PS4) Cstone: Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) [18:56:27] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) Okay so I'm wondering why we're just hearing about this from donors. It appears to me that this is la... [19:00:10] (CR) jerkins-bot: [V: -1] Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) (owner: Cstone) [19:09:52] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (krobinson) You're right @mepps! I just checked out a couple of recent responses to TY emails in Spanish and... [19:11:38] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) Thanks for checking on that@krobinson! So now we just want to confirm the fix is to change how the ur... [19:12:41] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 10 - https://phabricator.wikimedia.org/T262277 (spatton) p:Triage→High [19:12:46] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (spatton) p:Triage→High [19:12:50] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262280 (spatton) p:Triage→High [19:12:53] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262281 (spatton) p:Triage→High [19:12:59] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262282 (spatton) p:Triage→High [19:16:00] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (spatton) [19:16:28] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (spatton) [19:17:21] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262280 (spatton) [19:40:44] (CR) Mepps: [C: +2] Remove statement to alter preferred_language length from upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625735 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:00:13] (Merged) jenkins-bot: Remove statement to alter preferred_language length from upgrade [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625735 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:13:50] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:15:54] (CR) Mepps: [C: +2] Remove upgrade command to alter report menu items [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625739 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:16:23] (CR) Mepps: [C: +2] Remove extraneous wmf_civicrm_get_dbs() [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625766 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:18:29] (CR) Mepps: [C: +2] Remove upgrade commands for wmf_fredge_qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625767 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:18:57] (CR) Mepps: [C: +2] IDE code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625768 (owner: Eileen) [20:19:42] (CR) Mepps: [C: +2] Join the brave new world of 2010 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 (owner: Eileen) [20:23:01] (Merged) jenkins-bot: Remove upgrade command to alter report menu items [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625739 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:23:18] (Merged) jenkins-bot: Remove extraneous wmf_civicrm_get_dbs() [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625766 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:23:20] (CR) Mepps: [C: +2] Update silverpop composer package [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623883 (https://phabricator.wikimedia.org/T261211) (owner: Eileen) [20:23:42] (Abandoned) Eileen: Composer update to get silverpop connector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623693 (https://phabricator.wikimedia.org/T261211) (owner: Eileen) [20:23:44] (CR) Mepps: [C: +2] IDE reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623907 (owner: Eileen) [20:24:15] (CR) Mepps: [C: +2] Fix string to float comparison causing test fail in higher levels of phpunit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623908 (owner: Eileen) [20:25:26] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:25:33] (CR) Mepps: [C: +2] Fixes for later phpunit version stricter type checking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623909 (owner: Eileen) [20:25:43] (Merged) jenkins-bot: Remove upgrade commands for wmf_fredge_qc [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625767 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [20:25:59] (CR) Mepps: [C: +2] Minor fixes to declare exceptions, cheer up IDE [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623910 (owner: Eileen) [20:26:12] (CR) Mepps: [C: +2] IDE reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623911 (owner: Eileen) [20:26:25] (CR) Mepps: [C: +2] Fix test to cope with stricter casting in higher phpunit level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623912 (owner: Eileen) [20:26:34] (Merged) jenkins-bot: IDE code reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625768 (owner: Eileen) [20:26:36] (Merged) jenkins-bot: Join the brave new world of 2010 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625770 (owner: Eileen) [20:27:57] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, FR-Adyen, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review: Restyle Adyen hosted page - https://phabricator.wikimedia.org/T261355 (mepps) From @DStrine, the next step here is removing the smaller "Next step" text. [20:29:15] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog: Rogue contacts in _all_wikimedia database preventing accurate queries - https://phabricator.wikimedia.org/T261705 (mepps) From @Eileenmcnaughton, once they're opted out, we stop pushing the contacts up to silverpop. The fix here would be... [20:30:01] (Merged) jenkins-bot: Update silverpop composer package [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623883 (https://phabricator.wikimedia.org/T261211) (owner: Eileen) [20:30:41] (Merged) jenkins-bot: IDE reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623907 (owner: Eileen) [20:30:43] (Merged) jenkins-bot: Fix string to float comparison causing test fail in higher levels of phpunit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623908 (owner: Eileen) [20:32:12] (Merged) jenkins-bot: Fixes for later phpunit version stricter type checking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623909 (owner: Eileen) [20:32:29] (Merged) jenkins-bot: Minor fixes to declare exceptions, cheer up IDE [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623910 (owner: Eileen) [20:33:17] (Merged) jenkins-bot: IDE reformat [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623911 (owner: Eileen) [20:33:24] (Merged) jenkins-bot: Fix test to cope with stricter casting in higher phpunit level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623912 (owner: Eileen) [20:51:12] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, FR-Adyen, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review: Restyle Adyen hosted page - https://phabricator.wikimedia.org/T261355 (mepps) @Dstrine, here's the latest without the next step text. {F32251561} [20:55:00] (PS1) Eileen: Fix recurring_globalcollect_get_payment_by_id to use the api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625973 (https://phabricator.wikimedia.org/T261359) [21:02:33] (CR) jerkins-bot: [V: -1] Fix recurring_globalcollect_get_payment_by_id to use the api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625973 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [21:12:25] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625974 [21:12:49] Wikimedia-Fundraising-Banners: Japan banner emojis - https://phabricator.wikimedia.org/T261972 (TSkaff) Hi all, sounds like with Sam's fix, this is good to go or am I missing something? @jbolorinos-ctr @spatton @Pcoombe [21:18:27] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262279 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Variant: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z6956221ecaf98c5bf52 [21:24:25] hmm something doesn't look right [21:25:23] (PS2) Eileen: Fix recurring_globalcollect_get_payment_by_id to use the api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625973 (https://phabricator.wikimedia.org/T261359) [21:25:43] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262280 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Variant: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zec26e7b7e1bbc891eb6 [21:27:25] Wikimedia-Fundraising-Banners: 2020-09-10 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262281 (jbolorinos-ctr) Screenshot Test Result - Mobile: - Variant: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z25100d93d39d7c4b511 [21:27:49] (Abandoned) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625974 (owner: Jgleeson) [21:31:04] that looks better [21:31:37] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625977 [21:31:39] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625977 (owner: Jgleeson) [21:32:43] hmm [21:32:50] silverpop connector? [21:33:47] jgleeson: I guess it needs a vendor update to make any actual change on that one [21:34:24] is there a vendor update pushed? [21:34:30] (PS3) Eileen: Fix recurring_globalcollect_get_payment_by_id to use the api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625973 (https://phabricator.wikimedia.org/T261359) [21:34:46] I guess not [21:34:53] hmm so it needs installing locally [21:35:59] I think maybe vendor update needs committing - will try [21:39:46] eileen: I've updated vendor locally [21:40:03] I can push the updates if you wanna just double check them? [21:40:44] I won't front run you though in case you're already doing it [21:41:31] go ahead & push [21:42:54] this is my latest blocker on thee civi-test issues https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/625973 [21:42:58] (PS1) Jgleeson: Vendor update - silverpop-php-connector, omnimail-silverpop [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/625978 [21:43:33] eileen: ^ [21:44:04] (CR) Eileen: [C: +2] Vendor update - silverpop-php-connector, omnimail-silverpop [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/625978 (owner: Jgleeson) [21:44:25] yep looks right - a tiny change & a bunch of test & composer adjustments [21:45:32] great thanks [21:49:49] jgleeson: there is a file on staging you own that I need you to delete or unown [21:50:00] in sites/all/modules/queue2civicrm/tests/logs/ [21:50:37] (Merged) jenkins-bot: Vendor update - silverpop-php-connector, omnimail-silverpop [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/625978 (owner: Jgleeson) [21:51:06] oh rly? [21:51:55] (PS1) Eileen: Update vendor to get silverpop connnector update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625981 [21:52:33] (CR) jerkins-bot: [V: -1] Update vendor to get silverpop connnector update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625981 (owner: Eileen) [21:52:38] jgleeson: so we also need ^^ submodule commit & then it should be ok... [21:53:02] cool I was just adding that to the earlier patch [21:53:09] dang same error though! [21:53:10] lemme just check out this file first [21:53:18] oh no! [21:54:20] perf.log?!?!? [21:54:33] no memory of that [21:54:44] deleted [21:55:17] cool [22:00:10] hmm eileen so the update of that package also failed for me locally and i had to reinstall [22:00:24] but I guess CI can't deal with that prompt [22:00:40] jgleeson: so between when I did that commit & now I got him to tag a new revision - https://github.com/mrmarkfrench/silverpop-php-connector/releases/tag/v1.3.0 [22:00:43] feels like the composer.lock file might b wrong [22:00:45] be* [22:00:49] it might be switching to that helps [22:01:03] because using master is really fraught [22:01:47] I'm confused [22:02:39] why it's trying to update, CI builds from scratch right? [22:02:54] so is the .lock file telling it to update something that doesn't exist [22:03:17] not sure - jump in tech talk [22:12:20] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for HNordeenWMF - https://phabricator.wikimedia.org/T262344 (TSkaff) [22:13:11] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for HNordeenWMF - https://phabricator.wikimedia.org/T262344 (TSkaff) [22:14:51] (PS1) Eileen: Switch to 1.3.0 phpconnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625987 [22:21:30] eileen: I'm gonna abandon that deployment of civi until we work out the composerness [22:21:40] (Abandoned) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625977 (owner: Jgleeson) [22:22:09] bye for now! [22:22:46] (PS1) Eileen: Update mrmarkfrench/silverpop-php-connector to 1.3.0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625990 [22:24:03] (CR) jerkins-bot: [V: -1] Update mrmarkfrench/silverpop-php-connector to 1.3.0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625990 (owner: Eileen) [22:25:30] (PS2) Eileen: Update mrmarkfrench/silverpop-php-connector to 1.3.0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625990 [22:25:44] (Abandoned) Eileen: Switch to 1.3.0 phpconnector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625987 (owner: Eileen) [22:26:22] (Abandoned) Eileen: Update vendor to get silverpop connnector update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625981 (owner: Eileen) [22:27:07] (CR) Ejegg: [C: +2] Update mrmarkfrench/silverpop-php-connector to 1.3.0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625990 (owner: Eileen) [22:38:23] (PS1) Eileen: Vendor update - silverpop-php-connector [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/625991 [22:38:32] (CR) Eileen: [C: +2] Vendor update - silverpop-php-connector [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/625991 (owner: Eileen) [22:46:22] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625994 [22:47:34] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625994 (owner: Eileen) [22:48:02] (CR) Cstone: [C: +2] Fix recurring_globalcollect_get_payment_by_id to use the api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625973 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:52:01] (PS4) Ejegg: Further composer update on phpunit - to latest in 7.x series [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623884 (owner: Eileen) [22:55:13] (Merged) jenkins-bot: Fix recurring_globalcollect_get_payment_by_id to use the api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/625973 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:55:58] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [22:59:40] (CR) Ejegg: [C: +2] Further composer update on phpunit - to latest in 7.x series [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623884 (owner: Eileen) [23:01:30] (PS5) Cstone: Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) [23:02:33] (PS2) Eileen: 5.30-rc upgrade (stock) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) [23:06:15] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for HNordeenWMF - https://phabricator.wikimedia.org/T262344 (Dwisehaupt) @TSkaff Will she also be requiring access to superset? [23:06:44] (Merged) jenkins-bot: Further composer update on phpunit - to latest in 7.x series [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623884 (owner: Eileen) [23:08:42] (CR) jerkins-bot: [V: -1] Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) (owner: Cstone) [23:09:39] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for HNordeenWMF - https://phabricator.wikimedia.org/T262344 (Dwisehaupt) [23:09:45] (CR) jerkins-bot: [V: -1] 5.30-rc upgrade (stock) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [23:12:00] (PS1) Eileen: Remove recurring_globalcollect/tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626002 [23:12:58] (PS6) Cstone: Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) [23:13:32] (PS2) Eileen: Remove recurring_globalcollect/tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626002 [23:16:50] (PS1) Eileen: Update getOptOutEmails to use civi call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626003 [23:19:20] (CR) Ejegg: [C: +2] Remove recurring_globalcollect/tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626002 (owner: Eileen) [23:19:24] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/625994 (owner: Eileen) [23:20:26] (CR) jerkins-bot: [V: -1] Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) (owner: Cstone) [23:21:18] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for HNordeenWMF - https://phabricator.wikimedia.org/T262344 (TSkaff) Good call @Dwisehaupt and yes, that would be great! [23:21:40] (PS1) Eileen: Remove recurring_globalcollect from modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626006 [23:25:20] !log civicrm revision changed from 5e7352e2c3 to 4e40a59d42, config revision is 3cf0913789 [23:25:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:25:57] (Merged) jenkins-bot: Remove recurring_globalcollect/tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626002 (owner: Eileen) [23:26:12] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for HNordeenWMF - https://phabricator.wikimedia.org/T262344 (Dwisehaupt) [23:27:21] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625727 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [23:27:38] (PS2) Eileen: re-add remaining wmf hacks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625728 (https://phabricator.wikimedia.org/T261359) [23:35:19] (CR) jerkins-bot: [V: -1] re-add remaining wmf hacks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625728 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [23:39:24] (CR) Ejegg: [C: +2] Update getOptOutEmails to use civi call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626003 (owner: Eileen) [23:47:06] !log civicrm revision is 4e40a59d42, config revision is d26334fa36 [23:47:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:50:05] (PS1) Eileen: Remove an instance of push fredge & document in comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626012 [23:52:19] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626003 (owner: Eileen) [23:54:27] (CR) Cstone: [C: +2] Remove recurring_globalcollect from modules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626006 (owner: Eileen) [23:58:17] (Merged) jenkins-bot: Update getOptOutEmails to use civi call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626003 (owner: Eileen) [23:58:36] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/625728 (https://phabricator.wikimedia.org/T261359) (owner: Eileen)