[08:59:09] Wikimedia-Fundraising-Banners: Blue banner Desktop lg - Japan - https://phabricator.wikimedia.org/T262615 (Pcoombe) [08:59:11] Wikimedia-Fundraising-Banners: Missing translation for Credit Card title on Cancel or Change Recurring Donation help page - https://phabricator.wikimedia.org/T262714 (Pcoombe) Open→Resolved I copied the "Credit / debit card" translation from https://donate.wikimedia.org/wiki/Ways_to_Give/ja [11:51:50] tzag fr-tech! [12:26:02] Wikimedia-Fundraising-Banners: Other Ways to Give page displays Amazon Pay as a payment option in JP - https://phabricator.wikimedia.org/T262710 (Pcoombe) This is true on Ways to Give for all languages and countries. I believe this is sometimes requested and if donors have an Amazon account it will often wor... [12:58:05] Wikimedia-Fundraising-Banners: Orphan text visible on greeting (iPhone XR) - https://phabricator.wikimedia.org/T262699 (Pcoombe) Open→Declined [12:58:07] Wikimedia-Fundraising-Banners: M Lg: Blue banner - JP - https://phabricator.wikimedia.org/T262688 (Pcoombe) [12:58:11] Wikimedia-Fundraising-Banners: Orphan text visible on first paragraph (Pixel 4) - https://phabricator.wikimedia.org/T262698 (Pcoombe) Open→Declined [12:58:18] Wikimedia-Fundraising-Banners: Orphan text visible on third paragraph (Pixel 3) - https://phabricator.wikimedia.org/T262696 (Pcoombe) Open→Declined [12:58:25] Wikimedia-Fundraising-Banners: Orphan text visible on second paragraph (Galaxy S9) - https://phabricator.wikimedia.org/T262695 (Pcoombe) Open→Declined [13:15:27] Wikimedia-Fundraising-Banners: Unsubscribe link in Japan campaign TY email displays in English - https://phabricator.wikimedia.org/T262720 (Pcoombe) [13:16:06] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, Patch-For-Review: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (Pcoombe) [13:20:24] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, Patch-For-Review: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (Pcoombe) When I test French I'm getting `uselang=fr-gb` in the URL. So I think we want... [13:21:57] (PS2) Ejegg: Use SimpleHtmlParser instead of DomDocument in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522525 [13:23:26] (CR) jerkins-bot: [V: -1] Use SimpleHtmlParser instead of DomDocument in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522525 (owner: Ejegg) [13:36:41] (PS1) Ejegg: Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627283 [13:38:57] (CR) jerkins-bot: [V: -1] Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627283 (owner: Ejegg) [13:51:08] (PS3) Mepps: Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) [13:51:38] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, Patch-For-Review: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) Ahh yeah my brain spaced. I updated the patch, thanks @pcoombe! [13:58:24] (CR) jerkins-bot: [V: -1] Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [14:52:40] Fundraising-Backlog: Enable Adyen forms for New Zealand and Australia - https://phabricator.wikimedia.org/T262825 (DStrine) [15:11:09] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Jgreen) I worked with this a bit with Camille today via chat. There's something I didn't get to completely figure out going on re. her user/homedir. > ls ~/.ssh/ -rw-r--r-- 1 aalikha... [15:21:17] Fundraising-Backlog, Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice, Wikimedia-production-error: Fundraising banners are throwing JS errors - https://phabricator.wikimedia.org/T262693 (Pcoombe) This appears to be just an issue with the Live Preview function when editing banners... [15:21:32] Fundraising-Backlog, Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice, Wikimedia-production-error: Fundraising banners are throwing JS errors - https://phabricator.wikimedia.org/T262693 (Pcoombe) a:Pcoombe [15:27:46] Wikimedia-Fundraising-Banners: Other Ways to Give page displays Amazon Pay as a payment option in JP - https://phabricator.wikimedia.org/T262710 (jbolorinos-ctr) I see, thanks for the clarification on this Peter! Should I go ahead and close this then if Amazon Pay does work in these countries? Or is there a... [16:43:30] Wikimedia-Fundraising-Banners: Other Ways to Give page displays Amazon Pay as a payment option in JP - https://phabricator.wikimedia.org/T262710 (Pcoombe) Open→Declined Yeah I'll close this. [16:43:34] Wikimedia-Fundraising-Banners: Blue banner Desktop lg - Japan - https://phabricator.wikimedia.org/T262615 (Pcoombe) [17:05:56] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (mepps) @ejegg has suggested we might not be able to update this field. I'm reading through https://help.goacoustic.com/hc/en-u... [17:20:31] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (mepps) Ooh! From https://help.goacoustic.com/hc/en-us/articles/360042858094-Master-suppression-list > What happens to the co... [17:20:36] Wikimedia-Fundraising-Banners: M Lg: Blue banner - JP - https://phabricator.wikimedia.org/T262688 (TSkaff) Thank you all! [17:42:45] (CR) Mepps: [C: +2] "I had one thought but since it's in a TODO I feel okay +2ing this." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623314 (https://phabricator.wikimedia.org/T232235) (owner: AndyRussG) [17:46:11] (Merged) jenkins-bot: Campaign fallback follow-up: refactor data handling and some methods [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623314 (https://phabricator.wikimedia.org/T232235) (owner: AndyRussG) [17:49:48] (CR) Mepps: [C: +1] "I'm mostly ready to go on this but my only hangup is the mixins naming. Somehow I find the PostDisplay versus PostBannerOrFail a little co" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623537 (https://phabricator.wikimedia.org/T236285) (owner: AndyRussG) [18:04:29] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (KHaggard) Oh, that's helpful - thanks @mepps So basically, every contact on the Master Suppression List also has a copy on t... [18:15:30] Fundraising-Backlog: Last Name field too long on donations coming from audit files - https://phabricator.wikimedia.org/T262843 (Cstone) [19:02:55] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 10 - https://phabricator.wikimedia.org/T262277 (spatton) Thanks much, @jbolorinos-ctr! [19:05:34] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 10 - https://phabricator.wikimedia.org/T262277 (spatton) Open→Resolved [19:05:38] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (spatton) [19:05:40] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (spatton) [19:05:42] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (spatton) [19:05:49] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (mepps) It does @KHaggard and this would cover any contacts that were put on the supression list from Civi. Basically, what nee... [19:07:31] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (spatton) [19:16:03] Wikimedia-Fundraising-Banners: Japan Mobile Small Banner: Emoji #2 - https://phabricator.wikimedia.org/T262852 (TSkaff) [19:16:24] Wikimedia-Fundraising-Banners: Japan Mobile Small Banner: Emoji #2 - https://phabricator.wikimedia.org/T262852 (TSkaff) p:Triage→High [19:22:41] mepps: thanks so much for the code review! [19:23:27] what about "DisplayProcessFinalized"? [19:24:02] It's a complex process so it's hard to find compact-ish, fully descriptive hook names, I guess! [20:28:00] Fundraising-Backlog, Android-app-Bugs, Thank-You-Page, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (DStrine) Just checking up on this. Previous comments noted that some change neede... [20:46:24] Fundraising-Backlog, Android-app-Bugs, Thank-You-Page, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (JMinor) Hi @DStrine we never received a reply or confirmation of which option to... [21:15:31] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15): More minor bugs introduced with campaign fallback - https://phabricator.wikimedia.org/T261718 (AndyRussG) [21:19:48] Fundraising-Backlog, Android-app-Bugs, Thank-You-Page, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (Ejegg) Thanks @JMinor ! I think we're going to be fine with opening the TY page... [21:23:40] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (spatton) Desktop large batch! There's an orphan in the [[ https://en.wikipedia.org/wiki/NASA?banner=spatton_0916_en6C_dsk_lg_cvt_ctatxtinstead&force=1&country=US | monthly, instead ]] var... [21:24:31] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262868 (spatton) [21:24:47] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (spatton) [21:27:20] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262868 (spatton) [21:27:34] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262868 (spatton) p:Triage→High [21:27:36] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (spatton) p:Triage→High [21:27:38] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (spatton) p:Triage→High [21:31:06] (PS3) AndyRussG: Add FinalizeChooseAndMaybeDisplay hook, fix main banner history fallback issues [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623537 (https://phabricator.wikimedia.org/T236285) [21:32:22] (CR) Mepps: [C: +2] "I like the new name!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623537 (https://phabricator.wikimedia.org/T236285) (owner: AndyRussG) [21:32:30] mepps: thanks!!! [21:34:26] (CR) XenoRyet: "I too, like the new name." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623537 (https://phabricator.wikimedia.org/T236285) (owner: AndyRussG) [21:35:36] (Merged) jenkins-bot: Add FinalizeChooseAndMaybeDisplay hook, fix main banner history fallback issues [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623537 (https://phabricator.wikimedia.org/T236285) (owner: AndyRussG) [21:37:24] XenoRyet: heheh also thanks! [21:37:42] It's descriptive, and fun. [21:37:48] Fortunately Jenkins was also ok with the name, it seems [21:38:48] XenoRyet: heheh it took like 10-15 minutes to hash something out.... kinda a red flag for refactoring time I guess, glad we got something workable and aesthetic! [21:55:23] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262868 (jbolorinos-ctr) Screenshot Test Result - Monthly Convert - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zc20ab45e7df3bf8e55e - Simple Yes vari... [21:58:47] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (jbolorinos-ctr) Screenshots Test Results- Monthly Convert - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zf337b3e521076394d67 [21:59:38] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (jbolorinos-ctr) Thanks @spatton! Noted these are high priority so will make sure to get all bugs submitted before tomorrow. Will let you know if anything comes up! [22:48:28] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Patch-For-Review: Bug: Silverpop nightly jobs failed due to session limits - https://phabricator.wikimedia.org/T261211 (Eileenmcnaughton) This appears to have resolved the issue - somewhat masked by intermittant deadlock related issues [22:52:23] (CR) Eileen: "The test fail seems related ThankYouTest::testSendThankYou" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [22:54:09] ejegg: cstone I'm just checking in on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/624922/7/sites/all/modules/wmf_civicrm/wmf_civicrm.module - it looks OK to me - I just feel there was some issue ejegg raised that I'm not clear if it's resolved [23:03:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port in search improvement on saving groups from Coleman - https://phabricator.wikimedia.org/T262873 (Eileenmcnaughton) [23:03:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port in search improvement on saving groups from Coleman - https://phabricator.wikimedia.org/T262873 (Eileenmcnaughton) [23:05:08] (CR) Eileen: [C: +2] "I stepped through this & it seems right to me" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) (owner: Cstone) [23:05:58] Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fundraising Sprint Quackery limited to ducks, and 2 others: Adyen audit processor does not import initial recurring donations - https://phabricator.wikimedia.org/T255317 (Eileenmcnaughton) @csto... [23:11:43] if anyone is OK to +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/626012 - I mostly want it merged so when we deal with this again it's easier to get up to speed [23:12:54] (Merged) jenkins-bot: Add token creation to message import if token exists. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/624922 (https://phabricator.wikimedia.org/T255317) (owner: Cstone) [23:19:22] eileen: I think cstone's patch is fine, though I do wanna take a look in my IDE [23:19:43] ejegg: ok - I did step through the test in my IDE [23:20:57] oh cool, if you want to +2 I wouldn't object! [23:21:11] oh hah, you did [23:21:40] I need to help make some dinner here, then will look at your patch.