[00:11:14] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage Weekly Import not importing due to error message with Direct Mail Appeal - White Mail - https://phabricator.wikimedia.org/T256912 (Eileenmcnaughton) @rlewis I just tried & failed to replicate t... [00:14:53] (PS1) Eileen: IDE cheer & formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627396 (https://phabricator.wikimedia.org/T256912) [00:47:28] (CR) Mepps: "It's bizarre it didn't fail with the earlier version of the patch though.." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [01:33:14] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/627399 [01:37:12] (CR) AndyRussG: [C: +2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/627399 (owner: AndyRussG) [01:45:01] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/627399 (owner: AndyRussG) [02:41:03] (PS2) Ejegg: Remove an instance of push fredge & document in comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626012 (owner: Eileen) [02:41:17] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626012 (owner: Eileen) [02:48:02] (Merged) jenkins-bot: Remove an instance of push fredge & document in comments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626012 (owner: Eileen) [03:08:27] (PS2) Ejegg: Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627283 [03:10:04] (CR) jerkins-bot: [V: -1] Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627283 (owner: Ejegg) [03:12:56] (PS1) Eileen: Add api action to parse query log output [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627401 (https://phabricator.wikimedia.org/T261688) [03:15:03] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries running during queue processing - https://phabricator.wikimedia.org/T261688 (Eileenmcnaughton) I've documented / uploaded my method for analysing the query output for a job in the syste... [03:41:31] (PS1) Ejegg: Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627403 [03:57:46] (PS1) Ejegg: Stop messing with $_SERVER in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627404 [03:57:48] (PS1) Ejegg: Stop PHP warning/error on empty IP list [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627405 [03:57:50] (PS1) Ejegg: Use php-html-parser instead of DomDocument in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627406 [04:00:03] (PS2) Ejegg: Stop messing with $_SERVER in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627404 [04:00:05] (PS2) Ejegg: Stop PHP warning/error on empty IP list [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627405 [04:00:07] (PS2) Ejegg: Use php-html-parser instead of DomDocument in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627406 [04:00:09] (PS1) Ejegg: Update test fn signatures for new PhpUnit [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627407 [04:00:34] (Abandoned) Ejegg: Update test fn signatures for new PhpUnit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623619 (owner: Ejegg) [04:00:53] (Abandoned) Ejegg: Update Mustache for LightnCandy 1.2.5 for MediaWiki 1.35 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/622401 (https://phabricator.wikimedia.org/T260621) (owner: Cstone) [04:01:05] (Abandoned) Ejegg: Stop messing with $_SERVER in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/626174 (owner: Ejegg) [04:01:12] (Abandoned) Ejegg: Stop PHP warning/error on empty IP list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/626175 (owner: Ejegg) [04:01:19] (Abandoned) Ejegg: Use SimpleHtmlParser instead of DomDocument in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522525 (owner: Ejegg) [04:01:26] (Abandoned) Ejegg: Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627283 (owner: Ejegg) [04:04:48] (PS3) Ejegg: Use php-html-parser instead of DomDocument in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627406 [04:46:50] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries running during queue processing - https://phabricator.wikimedia.org/T261688 (Eileenmcnaughton) I've put the more detailed analysis over on gitlab https://lab.civicrm.org/dev/core/-/issue... [04:55:45] (PS4) Ejegg: Use php-html-parser instead of DomDocument in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627406 [04:58:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Address extraneous location related queries in queue processing - https://phabricator.wikimedia.org/T262883 (Eileenmcnaughton) [05:00:29] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review activity related queries in contribution processing - https://phabricator.wikimedia.org/T262884 (Eileenmcnaughton) [05:02:26] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Address extraneous pcp queries in donation processing - https://phabricator.wikimedia.org/T262885 (Eileenmcnaughton) [05:06:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Do query analysis on other jobs.... - https://phabricator.wikimedia.org/T262886 (Eileenmcnaughton) [05:06:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review activity related queries in contribution processing - https://phabricator.wikimedia.org/T262884 (Eileenmcnaughton) [05:06:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Address extraneous pcp queries in donation processing - https://phabricator.wikimedia.org/T262885 (Eileenmcnaughton) [09:44:56] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage Weekly Import not importing due to error message with Direct Mail Appeal - White Mail - https://phabricator.wikimedia.org/T256912 (RLewis) @Eileenmcnaughton this seemed to work this week. Very... [10:16:47] Fundraising-Backlog, FR-AutoTY-Email: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (Pcoombe) [13:21:32] tzag fr-tech! [13:27:49] looks like audit record is still tripping up the donation queue consumer [13:28:16] hmm let's see if we can fix that [13:55:50] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262930 (spatton) [13:55:57] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262930 (spatton) [13:56:04] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262930 (spatton) p:Triage→High [13:59:55] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262932 (spatton) [14:00:03] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262932 (spatton) p:Triage→High [14:00:47] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262930 (spatton) [14:01:05] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262868 (spatton) [14:01:21] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (spatton) [14:13:21] (CR) Ejegg: "check experimental" [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627406 (owner: Ejegg) [14:17:45] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (jbolorinos-ctr) [14:17:47] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T262868 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr All issues found have been reported and addressed. Closing this task now as Resolved, these banners are READY TO TEST! @spatton [14:28:42] (PS7) Zfilipin: WIP The first sample Selenium test in Node.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/443093 (https://phabricator.wikimedia.org/T262684) [14:30:51] (CR) jerkins-bot: [V: -1] WIP The first sample Selenium test in Node.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/443093 (https://phabricator.wikimedia.org/T262684) (owner: Zfilipin) [14:38:07] (CR) Zfilipin: "PS7 simplifies and updates the readme, and updates and fixes wdio.conf.js" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/443093 (https://phabricator.wikimedia.org/T262684) (owner: Zfilipin) [14:48:17] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (jbolorinos-ctr) Ok all issues found have been reported and addressed now. Closing this as Resolved, since these banners are now READY TO TEST! [14:48:23] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (jbolorinos-ctr) [14:48:25] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T262850 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr [14:49:53] (PS9) Zfilipin: WIP The first sample Selenium test in Node.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/443093 (https://phabricator.wikimedia.org/T262684) [14:50:26] (CR) Zfilipin: "PS9 sorts npm scripts" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/443093 (https://phabricator.wikimedia.org/T262684) (owner: Zfilipin) [14:51:11] (CR) Zfilipin: "@Jbol it took me a while to update this old patch, but all systems are green now, we're ready for launch ;)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/443093 (https://phabricator.wikimedia.org/T262684) (owner: Zfilipin) [14:56:05] ejegg|brb: I wanna run something by you [14:56:30] I'm looking over the ingenico audit record that's causing the failmail [14:57:07] the problematic record contains a " in the zipcode as discussed [14:57:13] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262932 (jbolorinos-ctr) Screenshot Test Results - Monthly Convert - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z2f841ad473973ad9206 - Challenging... [14:57:40] it looks like we can run the ingenico audit parser in isolation with this command `/usr/bin/run-job --job ingenico_wx_audit_parse` [14:58:56] which in turn runs `drush parse-audit ingenico --run_all` [14:59:28] now that last command basically finds the latest audit files in /incoming and processed them and adds in ones we don't have a record of [15:01:05] inside the ingenico audit process, it scans the directory where it expects to find the newly downloaded audit files and then it it orders the filenames to processed by the date contained within each filename [15:02:39] so my current thinking is I'm going to copy today's audit file, fix the broken zip code, drop it in /incoming and rename the file so that the audit processor sorts my new file to the top of the list [15:04:02] I'll then run the ingenico_wx_audit_parse job and I figure it should process the fixed record, ignore the versions of the broken record in other files and fix this issue [15:04:22] when I first mentioned this you had reservations about something new being downloaded [15:05:11] I think that might have been related to the ingenic_audit process control job, which downloads and runs the parser when run [15:05:54] in the plan outlind above, I'd only be running the second part of the process control job, specifically the ingenico_wx_audit_parse job [15:06:39] what say you? [15:06:44] :) [15:09:00] s/proessed/process!/ [15:09:52] good time for notconfusing to quit [15:10:30] ah you're back! hopefully that's a good omen [15:14:26] -_- [15:14:51] (づ。◕‿‿◕。)づ [15:15:00] haha jgleeson [15:15:15] :) [15:21:15] hi jgleeson [15:21:47] oh right, so it won't be a problem to have it twice [15:21:56] because the first one processed will go in [15:22:23] hm, although I think the audit processor will still send it twice [15:22:29] since it checks the db [15:23:15] and the first one it encounters won't be in the db be the time it looks at the second [15:25:49] ah got it [15:26:51] ok so it will process the first one, send it to the quue and then break on the second but the next time around.... it should skip it right? [15:27:13] whats one more failmail amongst friends ? [15:27:43] yah sure, just let it fail once more is OK too [15:28:06] oh, or actually, the queue consumer should ignore the second one [15:28:49] I forget, do we have the audit processor querying the replica db yet? [15:28:56] we should do that if we don't have it already [15:29:06] no need to hit master [15:30:20] ok cool [15:31:23] looks like the audit file processor orders the files by dates in the name in ascending order [15:31:47] so if I rename my fixed file to the day before the earliest current file [15:31:50] we should be good! [15:32:50] yep! [15:33:03] also, the fixed file only needs that one line [15:33:17] oh yeah good point! [15:33:56] ok I'm gona relocate and then I'll try that out! thanks for the feedback [15:38:29] oh derp [15:38:32] remex-html [15:38:47] description: Fast HTML 5 parser [15:39:14] perhaps i should check out that homemade option [15:39:35] though this one does seem to work too: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/627406 [15:41:28] hmm, remex seems a bit unwieldy for our needs [15:49:37] it can build a DomDocument [15:49:47] maybe I'll just see if that throws the same error [15:49:52] one less requirement would be nice [16:04:15] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: All messages in CentralNotice are defaulted to English regardless of content language - https://phabricator.wikimedia.org/T18321 (Aklapper) It's not very helpful to re-add tags while ignoring the comment which explains why the tag got rem... [16:41:53] woohoo, got it working with remex [16:42:14] pretty gnarly to get the DomDocument, but there are some examples to follow [16:46:32] (PS1) Ejegg: Use RemexHTML in tests to handle newer elements [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627564 [16:47:02] (Abandoned) Ejegg: Use php-html-parser instead of DomDocument in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627406 (owner: Ejegg) [16:47:19] fr-tech anyone have some time to review this chain? // p.s. i'm SERIOUS about the character encoding. [16:47:28] grr [16:47:37] this chain: https://gerrit.wikimedia.org/r/627564 [16:47:37] I'm here ejegg just setting up the audit job [16:47:41] ok, cool [16:47:50] lemme run that then I'll jump on it [16:47:59] when you're done that, I'd be happy to step through those other patches in a call [16:49:43] ejegg: I'm a little confused to be honest about the audit incoming dir [16:49:59] it looks like we have audit files going back to Jan 15th in the directory [16:50:37] in /var/spool/audit/globalcollect/incoming [16:50:52] now I was kinda expecting files that aren't recent to have been moved out [16:51:07] yep yep [16:51:31] so it moves files out once it has checked that there are no more unsolved transactions in them [16:51:41] also, there may be files of types that we don't process there [16:51:54] we keep them just in case they'll be interesting some day [16:52:00] I'm looking at wx1* audit files in /incoming [16:52:05] and so that the sftp sync script doesn't need to filter [16:52:16] oh really, there are wx1 files there from January? [16:52:22] yeah [16:52:33] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262930 (jbolorinos-ctr) Screenshot Test Results - Monthly Convert - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zbbdfb0421dbe3920d05 - Are you able v... [16:52:34] so we should run the audit script in --make-missing mode once a week or so [16:52:54] and that should take care of the ones that the normal run can't find details for in the logs [16:53:04] the make-missing mode fakes up some data [16:53:07] so it's not preferred [16:53:21] but if we can't find the real data after a few days it's better than nothing [16:53:25] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T262932 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr All issues found have been reported and addressed. Closing this as Resolved, these banners are now READY TO TEST! [16:53:28] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (jbolorinos-ctr) [16:53:32] can you tell if that's actually running once a week still? [16:53:46] sorry [16:53:50] that's jan 2019! [16:53:57] hmm lemme check [16:54:55] I don't see a schedule line in /srv/process-control/civi1001/ingenico_wx_make_missing.yaml ejegg [16:55:11] oh darn [16:55:38] so the other thing is that we generally only run the top N files [16:55:53] I don't think it's actually looking at the files back to Jan 2019 each night [16:56:21] hmmm [16:56:28] I think I saw a run_all flag somewhere [16:56:41] in the make missing run? [16:56:45] that would make sense [16:56:55] no in the wx_audit_parser job [16:57:52] ohh [16:58:08] huh, so that's a big waste of CPU cycles [16:58:30] `drush parse-audit ingenico --run_all` [16:58:40] yep, that's running them all I guess [16:58:55] should we remove that flag maybe? [16:59:03] hmm [16:59:08] maybe not [16:59:13] instead just move the files [16:59:26] yeah, let's move the stuff from 2019 [16:59:49] I think Jeff_Green or dwisehaupt would have to do that due to perms [17:00:15] jgleeson: we can also do that with a p-c script [17:00:37] but we should also run a makemissing mode every so often to keep it clean [17:01:48] ok. I still think I can squeeze in the patched audit file to fix the quote bug. I'll just check the date of the first failmail relating to it and add a file with the name of the date the day before that [17:01:55] to save adding one from 2019 [17:02:02] in case that does anything weird [17:02:28] ejegg: like a one-off p..c script? [17:02:34] I think I've seen you do that before [17:02:42] yeah, exactly [17:02:54] I think there might even be a move_audit yaml in there already [17:07:01] i agree that it's better to have it programattic (even if it's rarely used) than relying on a human to do the move. :) [17:09:50] Wikimedia-Fundraising-Banners: 2020-09-16 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T262930 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr All issues found have been reported and addressed. Closing this task as Resolved, these banners are now READY TO TEST! [17:09:52] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (jbolorinos-ctr) [17:10:30] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 16 - https://phabricator.wikimedia.org/T262849 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr Hey @spatton, Signing-off on QA now for this batch, these banners are now READY TO TEST!! [17:13:33] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (KHaggard) Sorry, I'm a bit confused. Fr-tech sends the Master Suppression List export file to us and we have it mapped to upda... [17:17:57] brb [17:31:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix PHPUnit deprecation warnings in DI tests - https://phabricator.wikimedia.org/T262955 (Ejegg) [17:36:23] ok looks like we first saw the quotey audit file record on the 2nd of sept [17:37:01] so let's cp the audit file for that day rename it to 20200901 [17:55:07] sorry ejegg this is taking longer than I expected! [17:55:32] turns out there was no mention of that record in the sept 2nd audit file [17:55:45] but found it in the audit file for sept 3rd [17:59:50] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, FR-Email: frFR contacts not updating in Acoustic - https://phabricator.wikimedia.org/T261870 (MBeat33) Hi all, We saw what looks like a related bulk email complaint today. The donor in Zendesk 802792 is in Civi... [18:00:23] hmm ok so this is a little tricker [18:01:35] looks like the offending " first appears in the sept 3rd audit xml file, wx1.000000657020200903.010241.xml.gz [18:01:42] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, FR-Email: frFR contacts not updating in Acoustic - https://phabricator.wikimedia.org/T261870 (MBeat33) Resolved→Open [18:02:32] so I guess it's a wx1* file I need to copy [18:03:09] ok that's cool it looks like they're the files we want [18:03:13] return '/wx\d\.\d{18}\.\d{6}.xml.gz/'; [18:03:42] so I guess I need to extract out the xml node entirely with all its child nodes [18:03:54] add it to a well formed xml doc and gzip it up [18:04:10] rename it and run the audit [18:09:56] Wikimedia-Fundraising-Banners: Japan Mobile Small Banner: Emoji #2 - https://phabricator.wikimedia.org/T262852 (jbolorinos-ctr) Hey @TSkaff, here are the results from the Screenshots Test - Mobile: - Emoji variant: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zb4b9bb90e28ff277732 [18:16:12] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, FR-Email: frFR contacts not updating in Acoustic - https://phabricator.wikimedia.org/T261870 (KHaggard) Hi @MBeat33 - Thanks for flagging. I'm looking up this contact in Acoustic and their information looks upda... [18:20:17] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, FR-Email: frFR contacts not updating in Acoustic - https://phabricator.wikimedia.org/T261870 (MBeat33) Thanks, I fwd-ed the original email from fundraising@, does that give you the visibility you'd like for this... [18:27:52] ejegg|food: looks like it might be tricky to just add a single audit record to a new audit file. The audit files contains a bunch of meta and totals data that I guess I could modify but might be easier to just run a copy of the file with the fixed record. [18:28:25] the downside is we hit the db needlessly for the other records [18:28:57] 17 74650 [18:28:59] hmmm [18:29:37] 74649 extra db queries saved for a bit more fiddling does feel worth it [18:29:46] jgleeson: we ignore those completely [18:29:56] we don't hit the db? [18:30:04] to confirm they exist [18:30:06] no, the totals section [18:30:09] ohhh [18:30:14] either leave it as is [18:30:20] or just delete it from the modified file [18:31:26] ok great, I think I'll leave them as is to preserve the hierarchy of the xml. thanks [18:33:48] sorry to ping you while you're eating btw! also when you get back I'll pause on this and we can talk through your review otherwise I'll miss you as I'm dropping off after sprint review. That way I can pick the review up tomorrow my morning. [18:34:18] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, FR-Email: frFR contacts not updating in Acoustic - https://phabricator.wikimedia.org/T261870 (KHaggard) No need, I see the Sent Date info in the forwarded email and it looks like the control from this morning's... [18:37:25] jgleeson ok, i'm back & ready to talk through the review [18:37:45] cstone: if you're around, want to also hop on the sprint call early? [18:37:59] Just trying to get some last-minute CR on the 1.35 ticket [18:39:42] ok great lemme just get my charger brb [18:40:29] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, FR-Email: frFR contacts not updating in Acoustic - https://phabricator.wikimedia.org/T261870 (MBeat33) Ah, thank you for seeing that @KHaggard. Sorry I didn't do a name search for an alt address! I will merge th... [18:40:38] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, fr-donorservices, FR-Email: frFR contacts not updating in Acoustic - https://phabricator.wikimedia.org/T261870 (MBeat33) Open→Resolved [18:40:57] sure ejegg [18:41:06] thanks! [19:05:38] (PS2) Ejegg: Update test fn signatures for new PhpUnit [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627407 [19:05:40] (PS3) Ejegg: Stop messing with $_SERVER in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627404 [19:05:42] (PS3) Ejegg: Stop PHP warning/error on empty IP list [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627405 [19:05:44] (PS2) Ejegg: Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627403 [19:05:46] (PS2) Ejegg: Use RemexHTML in tests to handle newer elements [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627564 [19:08:55] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi point release - https://phabricator.wikimedia.org/T261359 (DStrine) Open→Resolved [19:09:20] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Get drush to accept debug_query context - https://phabricator.wikimedia.org/T262368 (Eileenmcnaughton) Open→Resolved [19:09:22] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries running during queue processing - https://phabricator.wikimedia.org/T261688 (Eileenmcnaughton) [19:09:36] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Patch-For-Review: Bug: Silverpop nightly jobs failed due to session limits - https://phabricator.wikimedia.org/T261211 (Eileenmcnaughton) Open→Resolved [19:11:17] Fundraising Sprint Nyan cats for everyone, Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, and 4 others: Duplicate donations with the same contribution tracking id - https://phabricator.wikimedia.org/T256037 (DStrine) Open→... [19:12:22] (CR) Cstone: [C: +2] Fix Adyen audit processor recur handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623668 (https://phabricator.wikimedia.org/T255317) (owner: Eileen) [19:16:01] Fundraising-Backlog: Add a grafana graph for the new stats added in T256037 - https://phabricator.wikimedia.org/T262968 (jgleeson) [19:19:10] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need By: 2020-09-30) rack/setup/install frmx1001 & frdata1002 - https://phabricator.wikimedia.org/T260181 (Jgreen) [19:20:21] (Merged) jenkins-bot: Fix Adyen audit processor recur handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/623668 (https://phabricator.wikimedia.org/T255317) (owner: Eileen) [19:24:11] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage Weekly Import not importing due to error message with Direct Mail Appeal - White Mail - https://phabricator.wikimedia.org/T256912 (DStrine) Open→Resolved [19:26:00] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need By: 2020-09-30) rack/setup/install frmx1001 & frdata1002 - https://phabricator.wikimedia.org/T260181 (Jgreen) [19:44:31] Fundraising-Backlog: get payments wiki setup on docker - https://phabricator.wikimedia.org/T262971 (DStrine) [19:54:28] Fundraising-Backlog: feature parity with vagrant on docker - https://phabricator.wikimedia.org/T262971 (DStrine) [20:02:43] Fundraising-Backlog, Epic: Epic: feature parity with vagrant on docker - https://phabricator.wikimedia.org/T262971 (DStrine) [20:05:06] Fundraising-Backlog, Epic: Epic: feature parity with vagrant on docker - https://phabricator.wikimedia.org/T262971 (DStrine) [20:05:20] Fundraising-Backlog, Epic: Get civi working on docker - https://phabricator.wikimedia.org/T262975 (DStrine) [20:05:22] Fundraising-Backlog, Epic: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (DStrine) [20:05:32] Fundraising-Backlog, Epic: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (DStrine) [20:05:53] Fundraising-Backlog: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (DStrine) [20:06:01] Fundraising-Backlog: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (DStrine) [20:06:08] Fundraising-Backlog: Get civi working on docker - https://phabricator.wikimedia.org/T262975 (DStrine) [20:09:56] Fundraising-Backlog: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (DStrine) [20:15:35] Fundraising-Backlog: Get civi working on docker - https://phabricator.wikimedia.org/T262975 (DStrine) [20:19:11] Fundraising-Backlog: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (DStrine) [20:19:32] Fundraising-Backlog: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (DStrine) [20:24:59] (PS1) Pcoombe: New English Thank You email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627592 (https://phabricator.wikimedia.org/T262909) [20:26:52] Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (Pcoombe) Patch above. Can we deploy this onto civi staging first for some testing? Thanks! [20:28:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (Ejegg) @MNoorWMF if you have an example of a bad link handy, could you paste it here? The patch in review will fix the two column name... [20:32:21] Fundraising-Backlog: Enable Adyen forms for New Zealand and Australia - https://phabricator.wikimedia.org/T262825 (DStrine) [20:37:03] Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (DStrine) [20:41:23] Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (Eileenmcnaughton) Code is on staging now [20:42:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Gift Source = Alternative Gifts created - https://phabricator.wikimedia.org/T239845 (DStrine) Open→Resolved Hey @RLewis it looks like we don't have to do anything to help with this. But it's always good to know you made this. have fun! [20:44:00] Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Analyse queries running during queue processing - https://phabricator.wikimedia.org/T261688 (Eileenmcnaughton) Open→Resolved [20:45:39] Fundraising Sprint S 2020, Fundraising-Backlog: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (DStrine) [20:45:41] Fundraising Sprint S 2020, Fundraising-Backlog: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (DStrine) [20:45:43] Fundraising Sprint S 2020, Fundraising-Backlog, Epic: Epic: feature parity with vagrant on docker - https://phabricator.wikimedia.org/T262971 (DStrine) [20:45:46] Fundraising Sprint S 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Address extraneous pcp queries in donation processing - https://phabricator.wikimedia.org/T262885 (DStrine) [20:45:48] Fundraising Sprint S 2020, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (DStrine) [20:45:50] Fundraising Sprint S 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review activity related queries in contribution processing - https://phabricator.wikimedia.org/T262884 (DStrine) [20:45:52] Fundraising Sprint S 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port in search improvement on saving groups from Coleman - https://phabricator.wikimedia.org/T262873 (DStrine) [20:45:54] Fundraising Sprint S 2020, Fundraising-Backlog: Enable Adyen forms for New Zealand and Australia - https://phabricator.wikimedia.org/T262825 (DStrine) [20:45:56] Fundraising Sprint S 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Address extraneous location related queries in queue processing - https://phabricator.wikimedia.org/T262883 (DStrine) [20:45:58] Fundraising Sprint S 2020, Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (DStrine) [20:46:00] Fundraising Sprint S 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (DStrine) [20:46:02] Fundraising Sprint S 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (DStrine) [20:46:04] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (DStrine) [20:46:06] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog, FR-Adyen, Patch-For-Review: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (DStrine) [20:46:10] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog: Error: UNKNOWN missing essential contribution tracking ID - https://phabricator.wikimedia.org/T256274 (DStrine) [20:46:12] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08): Missing spacing between : and text on payments wiki page - https://phabricator.wikimedia.org/T261439 (DStrine) [20:46:14] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog: Grafana graph of wmf_civicrm_contribution_message_import - https://phabricator.wikimedia.org/T261689 (DStrine) [20:46:16] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, and 2 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (DStrine) [20:46:18] Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog, and 2 others: Adyen audit processor does not import initial recurring donations - https://phabricator.wikimedia.org/T255317 (DStrine) [20:46:20] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog, fr-donorservices, Patch-For-Review: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (DStrine) [20:46:22] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, and 6 others: Banner history logger records incorrect status code following campaign fallback - https://phabricator.wikimedia.org/T255810 (DStrine) [20:46:31] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint S 2020, Fundraising-Backlog, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08): Missing spacing between : and text on payments wiki page - https://phabricator.wikimedia.org/T261439 (Pcoombe) My change on translatewiki got [reverted](https:/... [20:54:54] cstone I reordered those commits in jenkins to match the order of the demo [20:55:02] lmk if you have any more questions about any of them [20:55:07] thanks ejegg [20:56:52] now i want to go to kazakistan to see the snake bridge: https://it.wikivoyage.org/wiki/Nur-Sultan#/media/File:Snake_bridge_02.jpg [20:57:14] oooh [20:57:58] sadly i'd never know it was there since that isn't on the english page on wikivoyage [21:04:14] ill be back in a bit gona go out on the lake while its still flat [21:04:31] dwisehaupt: sounds like an opportunity for an edit! [21:04:40] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (MNoorWMF) @Ejegg sure, I've got a handful just from clicking randomly around the datab... [21:05:11] nice, snake makes it all the way through the notifier bot and even shows nicely in irssi [21:08:36] showing good here too in weechat! [21:09:15] i like how the snake is different depending on the client. [21:09:37] nice! [21:10:04] dwisehaupt: will there be another planned outage for dbs this year? [21:10:31] (I've become aware one column that should be in int is a varchar but it would be a slow alter) [21:13:53] hmmm... not thinking of one off the top of my head, but we can try and get one in next 6 weeks if it would be good to get it done. [21:14:26] sooner the better, while avoiding email sends of course. [21:14:42] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (bsisolak) A few notes to add. You can do anything mentioned here with the API... [22:03:05] dwisehaupt: good to get it done = yes - but not required [22:14:56] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (Cstone) @dstrine Which monthly convert variant would be the main one? the one at variant=monthlyConvert? [22:29:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix PHPUnit deprecation warnings in DI tests - https://phabricator.wikimedia.org/T262955 (Reedy) [23:09:39] this week is full of turning over one rock in hopes of an answer to find 100 more small rocks underneath to search through. [23:21:20] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08): Missing spacing between : and text on payments wiki page - https://phabricator.wikimedia.org/T261439 (jbolorinos-ctr) +1 on that idea Peter! T...