[02:14:56] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, and 2 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (Cstone) Created https://phabricator.wikimedia.org/T262843... [02:15:17] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, and 2 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (Cstone) a:Cstoneβ†’None [03:50:47] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (AndyRussG) a:AndyRussG [07:14:15] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627681 (owner: L10n-bot) [07:16:59] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627681 (owner: L10n-bot) [12:33:41] Just saw the new sprint name. Brilliant! [12:37:56] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (Pcoombe) Thanks @Eileenmcnaughton! Sent some test emails and they look good to me, this is ready for deployment to pro... [13:12:10] yeah pcoombe lol we've had a few creative zip codes over the last 2 weeks [13:14:58] tzag jgleeson pcoombe [13:15:03] and fr-tech :) [13:15:20] ha and this is a good sprint name [13:15:22] hey mepps! :) [13:15:36] how are you pcoombe? [13:16:11] tzag mepps! [13:16:19] hi jgleeson! [13:16:25] how's your office space today? [13:16:28] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, and 2 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (jgleeson) a:jgleeson [13:16:51] Not bad thanks mepps. Pretty busy with prep work for France and 6C. How are you? [13:17:19] i'm not too bad pcoombe, i took yesterday off so i'm getting my head back in the game now [13:17:46] not too bad thanks mepps. standing desk day today and feeling ok so far! :) how about you? [13:18:24] still a work in progress jgleeson but i've made my own little adapted lumbar pillow [13:20:06] nice! [13:58:15] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (spatton) @MBeat33 noticed a phrasing imperfection that escaped our review; before this is deployed, is it possible to... [14:00:41] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (MBeat33) Thank you, @spatton and sorry for the last-minute change request, all! [14:02:05] ejegg|away: I'm looking over your 1.35 patches and after pulling down 1.35, installing and then running the tests I'm getting errors about Smashpig, specifically 'Uncaught Error: Class 'SmashPig\Core\GlobalConfiguration' not found ' and I feel like I've seen this before [14:02:47] lemme try updating smashpig on my local payments [14:05:02] hmm looks like I'm on the latest, v0.6.2 [14:05:15] ah is this the thing that you added a patch for a while back and I was meant to test it [14:06:13] hmm looks like that got merged [14:06:32] but did it make it to packagist [14:09:23] jgleeson that's a pretty long-established SmashPig class - maybe just make sure wikimedia/smash-pig is there in the mediawiki vendor directory? [14:09:49] you'll want the fundraising/REL1_35 branch of mediawiki, not just REL1_35 [14:10:34] to just put the site through its paces you can also pull down the fundraising/REL1_35 branch of mediawiki/vendor [14:10:52] but to run the tests you'll need to composer install to get the dev dependencies [14:12:13] so I have the f../REL1_35 mw [14:12:21] but I don't have vendor so I'll check that [14:12:38] actually that shouldn't matter right [14:12:51] as composer *should* install everything needed [14:13:45] ooof i just fixed a weird ubuntu bug [14:13:55] where it was losing windows if they were on my external monitor [14:14:06] by which i mean i can now get the windows, not that the software is fixed :) [14:14:17] i do wonder if i should upgrade... [14:23:52] (CR) Mepps: "Weirdly where I'm seeing the failure is in matching $1.23 to USD 1.23. I feel like I remember us making that change but I don't understand" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [14:31:50] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fr-donorservices, Patch-For-Review: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) Hm so what's happening is that... [14:32:48] okay now that i figured out what's blockign that i'm going to go on a short run to think [14:40:47] oh crap gotta go deal with something. my bank accounts just got blocked :/ [14:58:46] hellosies fr-tech [15:01:32] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fundraising Sprint Quackery limited to ducks, MediaWiki-extensions-CentralNotice: Improve state component's munging of new data added for Ca... - https://phabricator.wikimedia.org/T232235 [15:02:32] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (AndyRussG) a:AndyRussG [15:16:56] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (DStrine) p:Triageβ†’Medium [15:17:19] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (DStrine) p:Triageβ†’Medium [15:18:59] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (DStrine) p:Triageβ†’Medium [15:19:02] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port in search improvement on saving groups from Coleman - https://phabricator.wikimedia.org/T262873 (DStrine) p:Triageβ†’Medium [15:19:11] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Enable Adyen forms for New Zealand and Australia - https://phabricator.wikimedia.org/T262825 (DStrine) p:Triageβ†’High [15:19:24] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (DStrine) p:Triageβ†’Medium [15:19:31] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (DStrine) p:Triageβ†’High [15:20:39] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fundraising Sprint Quackery limited to ducks, MediaWiki-extensions-CentralNotice: Improve state component's munging of new data added for Ca... - https://phabricator.wikimedia.org/T232235 [15:25:36] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fr-donorservices, Patch-For-Review: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) My next step will be to try on... [15:35:23] Fundraising-Backlog: DAF & Family Foundation gifts - https://phabricator.wikimedia.org/T263035 (AParker) [15:35:50] (PS2) Pcoombe: New English Thank You email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627592 (https://phabricator.wikimedia.org/T262909) [15:37:25] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (Pcoombe) I amended the patch to remove "all" [16:05:40] (CR) Ejegg: "Mepps that failure probably is due to inconsistency in the machine's locale between environments. The php-intl currency internationalizati" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [16:07:21] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (mepps) @bsisolak Thanks for the quick response! At this time, we remove all c... [16:08:31] (CR) Mepps: "> Patch Set 3:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [16:15:45] (PS4) Mepps: Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) [16:23:07] (CR) jerkins-bot: [V: -1] Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [16:34:15] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (bsisolak) "there's a way to import the list of suppressed contacts to the mai... [16:54:00] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Enable Adyen forms for New Zealand and Australia - https://phabricator.wikimedia.org/T262825 (Ejegg) Same cards in each country as Ingenico? [17:23:37] Fundraising-Backlog, Wikimedia-Fundraising, fr-donorservices: Following link to donate fails to return user to previous page upon completion - https://phabricator.wikimedia.org/T60506 (MBeat33) [17:30:42] (PS1) Pcoombe: Remove colon from amount header [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627888 (https://phabricator.wikimedia.org/T261439) [17:35:11] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, MediaWiki-Docker: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (AndyRussG) Hi! Adding the #mediawiki-docker tag for visibility and coordination with related projects... General notes: - This is part... [17:45:05] (PS5) Mepps: Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) [17:51:14] (CR) Mepps: [C: +2] "Good solution!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627888 (https://phabricator.wikimedia.org/T261439) (owner: Pcoombe) [17:52:14] (CR) jerkins-bot: [V: -1] Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [17:58:50] (Merged) jenkins-bot: Remove colon from amount header [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627888 (https://phabricator.wikimedia.org/T261439) (owner: Pcoombe) [18:06:56] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Enable Adyen forms for New Zealand and Australia - https://phabricator.wikimedia.org/T262825 (DStrine) @EMartin could you help remind us of the payment types currently available in NZ and AU through ingenico? I can't seem to find that info... [18:09:05] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (DStrine) @Pcoombe @MBeat33 @spatton can we get a confirmation that this is good to go to prod? [18:14:27] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need By: 2020-09-30) rack/setup/install frmx1001 & frdata1002 - https://phabricator.wikimedia.org/T260181 (Cmjohnson) [18:14:36] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need By: 2020-09-30) rack/setup/install frmx1001 & frdata1002 - https://phabricator.wikimedia.org/T260181 (Cmjohnson) racked [18:14:49] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Enable Adyen forms for New Zealand and Australia - https://phabricator.wikimedia.org/T262825 (EMartin) NZ = CC (Visa, MC, AMEX) and Paypal AU = CC (Visa, MC, Amex, JCB) and Paypal [18:24:02] Wikimedia-Fundraising-Banners: Monthly convert other amount orphan text - https://phabricator.wikimedia.org/T261879 (jbolorinos-ctr) Openβ†’Declined Closing as Declined, since this is a non-issue [18:24:04] Wikimedia-Fundraising-Banners: 2020-09-02 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T261698 (jbolorinos-ctr) [18:36:11] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fr-donorservices, Patch-For-Review: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) We've been exploring this in t... [18:39:51] hmmm [18:42:30] so it looks like other stuff has changed between fundraising/REL1_31 and fundraising/REL1_35 in the GlobalFunctions.php file so I can't just push that port hack for vagrant up without deciding on a branch to push it to. [18:43:27] I guess we're mostly gonna be on 1.35 going forward and considering this patch will never be merged it doesn't really matter which one I choose [18:48:39] fr-tech, anyone seen this when trying to push patches up the to the fundraising/REL1_35 topic? ! [remote rejected] HEAD -> refs/for/master%topic=fundraising/REL1_35 (implicit merges detected) [18:48:57] a bunch of commits above it relating to the 1.35 changes [18:49:25] mepps and I were running into something like that when trying on 1_31 [18:51:40] hmm [18:51:51] I tried rebasing over the latest on 1.35 [18:54:18] ok scrap that, let's do it another way [18:57:23] jgleeson it might be trying to push them against a different branch [18:57:38] is it different if you specify explicitly, i.e. [18:57:46] git review fundraising/REL1_35 [18:58:47] I tried setting the topic as that [18:59:00] but I think that's just the name [18:59:04] lemme try your suggestion [18:59:51] (PS1) Jgleeson: DO NOT MERGE! [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627902 [19:00:04] looks like it worked! [19:00:12] thanks ejegg ! [19:01:03] grr I'm outta time today [19:02:13] I'm gonna start early tomorrow to make up for time lost due to banking problems so I'll dig into whatever else was wrong with my tests and then pick up any review outstanding on the 1.35 stuff. [19:03:13] so far this week feels like being stuck on rubixk's cube... moving stuff round but making no real progress [19:03:39] Rubik's* even [19:03:42] bye for now! [19:03:49] thanks jgleeson [19:03:54] np! [19:04:13] (CR) jerkins-bot: [V: -1] DO NOT MERGE! [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627902 (owner: Jgleeson) [19:06:07] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, MediaWiki-Docker: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (kostajh) @AndyRussG [this patch](https://gerrit.wikimedia.org/r/c/releng/dev-images/+/622575) will provide a PHP 7.3 image, but it's sti... [19:15:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice shifts down page content on load (causes mis-clicks) - https://phabricator.wikimedia.org/T52865 (Krinkle) [19:22:33] Fundraising-Backlog, Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice, JavaScript, Wikimedia-production-error: Fundraising banners are throwing JS errors - https://phabricator.wikimedia.org/T262693 (Umherirrender) [20:37:40] Wikimedia-Fundraising-Banners: Japan Banner New Emojis Tests: Mob Sm, Dsk Sm, Mob lg - https://phabricator.wikimedia.org/T263059 (TSkaff) [21:01:17] Wikimedia-Fundraising-Banners: Japan Banner New Emojis Tests: Mob Sm, Dsk Sm, Mob lg - https://phabricator.wikimedia.org/T263059 (TSkaff) p:Triageβ†’High [21:41:30] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (MBeat33) From DS' perspective, no blockers [23:06:37] Fundraising-Backlog, Fr-endowment: Constituent Relationship Refinement - https://phabricator.wikimedia.org/T263074 (EWilson)