[04:11:35] (PS1) Ammarpad: Reimove final modifier on private method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627972 [04:50:08] (CR) DannyS712: [C: +2] Reimove final modifier on private method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627972 (owner: Ammarpad) [04:56:49] (PS2) DannyS712: Remove final modifier on private method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627972 (owner: Ammarpad) [04:56:54] (CR) DannyS712: Remove final modifier on private method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627972 (owner: Ammarpad) [04:56:57] (CR) DannyS712: [C: +2] Remove final modifier on private method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627972 (owner: Ammarpad) [05:09:57] (Merged) jenkins-bot: Remove final modifier on private method [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627972 (owner: Ammarpad) [05:18:56] (PS1) Ammarpad: Fix usages of deprecated PHPUnit methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) [05:20:51] (CR) jerkins-bot: [V: -1] Fix usages of deprecated PHPUnit methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) (owner: Ammarpad) [06:41:58] (CR) Ammarpad: "The method MediaWikiTestCase::assertArraySubmapSame() was added in MW 1.35, but this extensions supports MW 1.30 and the tests are failin" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) (owner: Ammarpad) [08:57:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:02:15] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:07:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:12:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:17:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [09:22:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:27:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:30:18] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email, Patch-For-Review: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (Pcoombe) @DStrine Yes, the amended patch is ready to go. [09:32:15] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:37:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [09:42:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [09:47:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:52:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [09:57:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [10:02:15] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [10:07:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [10:12:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [10:17:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [10:22:15] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [10:27:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [10:32:15] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [10:37:11] RECOVERY - check_log_messages on frav1002 is OK: OK [10:47:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [10:52:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [10:57:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [11:00:30] ACKNOWLEDGEMENT - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] Jeff_Green known [11:07:15] RECOVERY - check_log_messages on frav1002 is OK: OK [11:17:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [11:22:21] RECOVERY - check_log_messages on frav1002 is OK: OK [11:32:06] woah [11:32:20] what's goin on here then [11:37:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [11:42:21] RECOVERY - check_log_messages on frav1002 is OK: OK [11:52:15] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [11:57:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [12:02:21] RECOVERY - check_log_messages on frav1002 is OK: OK [12:12:15] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [12:17:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [12:22:18] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [12:23:12] Jeff_Green do you know what endpoint that job is hitting? the endpoint I'm hitting that we use for Adyen backend calls is reachable for me on civi1001 [12:27:12] RECOVERY - check_log_messages on frav1002 is OK: OK [12:52:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [12:53:54] Fundraising-Backlog: Adyen SoapClient Timeouts - https://phabricator.wikimedia.org/T263122 (jgleeson) [12:57:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [13:02:16] RECOVERY - check_log_messages on frav1002 is OK: OK [13:15:39] Fundraising-Backlog, Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice, JavaScript, Wikimedia-production-error: Fundraising banners are throwing JS errors - https://phabricator.wikimedia.org/T262693 (Krinkle) @pcoombe Per "Blocked or not fr-tech", please indicate what this'd... [13:31:09] (CR) Mepps: [C: +2] New English Thank You email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627592 (https://phabricator.wikimedia.org/T262909) (owner: Pcoombe) [13:32:27] (CR) Mepps: [C: +2] "Thanks for the clear documentation of the header!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627592 (https://phabricator.wikimedia.org/T262909) (owner: Pcoombe) [13:39:09] (Merged) jenkins-bot: New English Thank You email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627592 (https://phabricator.wikimedia.org/T262909) (owner: Pcoombe) [13:41:35] (Abandoned) Mepps: WIP CampaignFallback: runPostBannerMixinHooks once per iteration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/621341 (https://phabricator.wikimedia.org/T255810) (owner: Mepps) [13:42:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [13:42:51] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628087 [13:47:43] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 4 [=1] [13:52:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 2 [=1] [13:57:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [14:02:18] RECOVERY - check_log_messages on frav1002 is OK: OK [14:12:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [14:17:27] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 4 [=1] [14:22:16] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [14:27:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [14:32:16] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [14:37:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [14:42:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [14:47:02] Wikimedia-Fundraising-Banners: Japan Banner New Emojis Tests: Mob Sm, Dsk Sm, Mob lg - https://phabricator.wikimedia.org/T263059 (jbolorinos-ctr) Hey @TSkaff, Here are the Screenshots Test Results for Mobile (and one Desktop): - M sm emojis #3: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/scr... [14:47:13] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 3 [=1] [14:52:13] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [14:57:13] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Adyen_endpoint_critical 1 [=1] [15:02:17] RECOVERY - check_log_messages on frav1002 is OK: OK [15:19:20] (CR) Mepps: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628087 (owner: Mepps) [15:43:03] !updated payments-wiki from 3c073a6a56 to 1e5a52ed26 [15:43:07] oops [15:43:18] !log updated payments-wiki from 3c073a6a56 to 1e5a52ed26 [15:43:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:11:23] fr-tech Evelyn's explanation for why we don't have Ingenico in FR (they don't offer Carte Bancaire, and that's an important method) made me think of the failmails mentioning cartebancaire [16:11:41] I think those have an easy fix: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/628134 [16:11:52] just adding it to an array where it was missing [16:12:32] i don't see that string in a phab search [16:12:43] suppose I could make a ticket [16:13:02] and see how big the impact was [16:16:40] ugh, it could have been a bad one, i.e. showing failmails to donors whose donations went through [16:16:44] looking deeper [16:18:01] ok, i see a bunch of 'failed' payments-init messages for those, so maybe those would have cleared out the pending entry and left them non-capturable [16:18:10] (though with more failmail) [16:19:22] like 25 donors / day or so :( [16:20:41] fr-tech if anyone can review https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/628134 I'll do a quick SmashPig version bump and update it in DonationInterface [16:21:02] so there's one less problem when we get the IP addresses untangled [16:21:34] ejegg: missing an o on submethod [16:28:15] (CR) Cstone: [C: -1] Add missing Carte Bancaire to Adyen decoder (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/628134 (owner: Ejegg) [16:29:08] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen: Carte Bancaire users seeing error on returning to payments-wiki - https://phabricator.wikimedia.org/T263144 (Ejegg) [16:29:44] thanks cstone ! [16:30:16] (PS2) Ejegg: Add missing Carte Bancaire to Adyen decoder [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/628134 (https://phabricator.wikimedia.org/T263144) [16:30:19] fixed [16:34:29] ejegg: standup [16:35:34] (CR) Cstone: [C: +2] Add missing Carte Bancaire to Adyen decoder [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/628134 (https://phabricator.wikimedia.org/T263144) (owner: Ejegg) [16:36:04] (Merged) jenkins-bot: Add missing Carte Bancaire to Adyen decoder [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/628134 (https://phabricator.wikimedia.org/T263144) (owner: Ejegg) [16:43:43] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (KHaggard) Addressing Brian's questions: - I think @mepps is talking about Ac... [16:55:59] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (bsisolak) Rebuilding the Master Suppression List is very risky, and I would n... [17:39:49] had a moment of doubt there whether the latest SmashPig is ok for PHP7.0 but I think it is [17:41:51] mepps oh no, that last merge to DonationInterface went the wrong way :( [17:41:57] all the tests are gone on master [17:45:37] (PS1) Ejegg: Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628154 [17:53:01] (CR) Ejegg: [C: +2] Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628154 (owner: Ejegg) [17:57:01] that's bizarre ejegg because it doens't show files being deleted.. [18:02:32] mepps: it's hidden in the second parent display [18:03:19] ah that's annoying [18:03:26] yes it is [18:03:36] i'm trying to set my upstream again locally but git is being annoying [18:04:03] is that a new thing in gerrit? I don't think I had to ever flip between parents before [18:04:16] yeah same jgleeson [18:04:26] i specifically scrolled down to make sure there wasn't anything funny! [18:06:47] it's now claiming there's no change between my local deployment branch and origin, did that get updated? [18:08:16] I think ejegg|food just reverted master [18:08:27] did it get +2'd? [18:08:46] no jenkins hasn't merged it [18:09:49] so if I understand it, you merged develop into master so update master [18:10:03] so develop should be kosher [18:10:28] once that branch merges you can then just merge master into develop [18:10:58] using the same commit message I think (bar the change id) [18:12:31] locally jgleeson i merged master in deployment [18:12:46] but my git review just set the upstream branch to master--erg [18:12:57] i tried running git review --track deployment [18:13:09] (Merged) jenkins-bot: Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628154 (owner: Ejegg) [18:13:26] and it says i have no differences between my local deployment and origin [18:14:21] ohhh [18:16:00] soo look at this earlier patch: so... [18:16:02] oops [18:16:06] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/552900/-2..1 [18:16:59] jgleeson ejegg ^^ [18:17:13] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need By: 2020-09-30) rack/setup/install frmx1001 & frdata1002 - https://phabricator.wikimedia.org/T260181 (Jgreen) [18:17:45] okay i guess that's when it's happened before [18:18:07] but i think it may have updated both deployment and master weirdly [18:18:13] i don't understand gerrit.. [18:18:40] lemme update my local and see why I see [18:22:59] so my deployment is at ceeb33b34e2dc084a674f4c2369c268ba565f9b0 mepps [18:23:14] and doesn't have the stuff on master [18:23:26] weeird jgleeson [18:23:48] you could do git reset --hard origin/deployment to tidy that up [18:23:55] and then just remerge master in [18:24:07] when on the deployment branch [18:24:21] i think! [18:25:06] my git repo is utterly convinced that origin/deployment has these commits--i just tried that and got no change.. [18:25:09] so bizarre [18:26:53] delete the branch and recheckout? [18:27:15] and also pull master [18:29:54] yeah i did that jgleeson, now my git merge is being really weird [18:30:11] :/ [18:30:12] it's just auto merging and adding a bunch of tests without even a commit--basically rebasing [18:30:20] i'm going to take a break, back in 15 [18:31:19] oh right, getting things merged back to deployment might mean manually re-doing the composer.json changes and manually removing tests [18:40:48] ejegg|food: I think I found out why my tests arent working on the 1.35 stuff [18:40:52] PHP Fatal error: Declaration of SubscribeTest::setUp() must be compatible with PHPUnit\Framework\TestCase::setUp(): void in /vagrant/mediawiki-fr/extensions/FundraisingEmailUnsubscribe/tests/phpunit/SubscribeTest.php on line 61 [18:45:04] ah it's missing the return type [18:45:06] void! [18:45:46] i think thats ejegg's first patch right? [18:46:41] oh rly? I thought that was the one I checked out [18:46:44] oh emailUnsubscribe hmm [18:46:45] hmm [18:47:43] yeah looks like the first patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/627407/2 [18:47:47] updates tests in DI [18:47:50] cstone / jgleeson the emailUnsubscribe extension should be merged too [18:48:12] I thought I updated the pointer to that in the mediawiki branch, but I might not have [18:48:29] if not, you can check out the fundraising/REL1_35 branch of that extension too [18:52:00] hmm [18:52:10] so checking out 1.35 of that ext got me onto the next failure [18:52:34] Wikimedia\Rdbms\DBConnectionError from line 1420 of /vagrant/mediawiki-fr/includes/libs/rdbms/loadbalancer/LoadBalancer.php: Cannot access the database: Unknown error (127.0.0.1) [18:53:13] ooh wait [18:53:17] that error has just gone away... [18:54:30] yay [18:54:33] tests running! [18:54:39] woo jgleeson [19:01:04] I've gotta drop off now but I'll check in first thing on the 1.35 stuff! [19:01:20] (PS1) Ejegg: Merge commit '0398bf2a' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628176 [20:15:50] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628191 [20:16:14] mepps OK, I think with ^^^ we get both branches back to normal and are able to do merges to deployment again [20:16:41] just having that previous Merge commit '0398bf2a'... commit on deployment made the next merge not a fast-forward [20:23:02] (CR) Ejegg: [V: +2 C: +2] Merge commit '0398bf2a' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628176 (owner: Ejegg) [20:23:13] (CR) Ejegg: [V: +2 C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628191 (owner: Ejegg) [20:40:31] (Merged) jenkins-bot: Merge commit '0398bf2a' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628176 (owner: Ejegg) [20:40:33] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628191 (owner: Ejegg) [21:11:44] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628199 [21:12:08] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628199 (owner: Ejegg) [21:14:15] (PS2) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628199 [21:20:29] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628199 (owner: Ejegg) [21:32:12] fundraising-tech-ops: Capture traceroute information on external endpoints for post failure diagnostics - https://phabricator.wikimedia.org/T263204 (Dwisehaupt) [21:33:58] has anyone looked at the gerrit->gitlab talk page [21:35:12] I want to indicate my support for the proposal (based on using both & finding gitlab much easier/time efficient/ better for comments) but I don't want to get into any big discussions on it - I just wanna be a 'vote' [21:35:26] https://www.mediawiki.org/wiki/Talk:GitLab_consultation [21:35:32] eileen: heh. i just took a look earlier and got sucked in. [21:36:45] lol - I didn't see that - I'll look againn [21:37:03] oh. i didn't write. just got sucked into reading. :) [21:38:05] possibly just throw a +1 comment on https://www.mediawiki.org/wiki/Topic:Vu0zhll74wexupsc [21:43:54] Oh well I commented https://www.mediawiki.org/w/index.php?title=Topic:Vu5x3nq4raedr34i&action=history [21:44:03] Hopefully that 'counts' [21:46:39] counts in my book. :) [21:47:39] i use gerrit so rarely that i don't have much opinion. once i got the list of how to do what i need, i just keep following that and have moved on. [22:05:38] (PS1) Ejegg: Disable Carte Bancaire [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628227 [22:06:51] (CR) jerkins-bot: [V: -1] Disable Carte Bancaire [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628227 (owner: Ejegg) [22:08:04] Fundraising-Backlog: Data center configuration with Ingenico for our records - https://phabricator.wikimedia.org/T263198 (DannyS712) [22:09:11] dwisehaupt: yeah I realised I probably use gitlab more than other people on that thread - although I still prefer github.... [22:10:01] fundraising-tech-ops: Capture traceroute information on external endpoints for post failure diagnostics - https://phabricator.wikimedia.org/T263204 (Dwisehaupt) [22:18:06] (PS1) Ejegg: Update SmashPig and other libraries [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628230 [22:18:10] (CR) Ejegg: [C: +2] Update SmashPig and other libraries [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628230 (owner: Ejegg) [22:19:36] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: RAID controller failing on frdb1002.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T261221 (wiki_willy) Open→Resolved a:Jclark-ctr Just a quick reminder to add "ops-eqiad" in the project tag, so that the dc-ops task doesn't g... [22:19:40] (CR) jerkins-bot: [V: -1] Update SmashPig and other libraries [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628230 (owner: Ejegg) [22:31:25] shoot, I need to force that I think [22:31:34] oh, or just merge the vendor bit first? [22:37:53] (PS2) Ejegg: Update SmashPig and other libraries [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628230 [22:38:38] (CR) Ejegg: [C: +2] Update SmashPig and other libraries [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628230 (owner: Ejegg) [22:38:43] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628199 (owner: Ejegg) [22:40:07] (CR) Ejegg: [V: +2 C: +2] Update SmashPig and other libraries [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628230 (owner: Ejegg) [22:40:26] (CR) Ejegg: [V: +2 C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628199 (owner: Ejegg) [22:40:50] (CR) Ejegg: [C: +2] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628227 (owner: Ejegg) [22:49:23] (Merged) jenkins-bot: Disable Carte Bancaire [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628227 (owner: Ejegg) [22:49:39] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628232 [22:49:47] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628232 (owner: Ejegg) [22:52:16] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628232 (owner: Ejegg) [22:58:07] ok, let's see if that deploys nicely [23:01:27] !log updated payments-wiki from 1e5a52ed26 to 86c997fdb2 [23:01:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:02:14] huh?? [23:02:17] still seeing CB [23:06:05] but anyway it's working [23:06:31] not CB, I just mean it's not totally breaking! [23:07:48] oh derp, I need to do one more submodule pointer update to get that card icon gone [23:07:51] will do that in a few [23:18:58] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628233 [23:21:41] (CR) Ejegg: [V: +2 C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628233 (owner: Ejegg) [23:27:41] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/628233 (owner: Ejegg) [23:37:54] fundraising-tech-ops, observability: fundraising recurring_gc* queues metrics into prometheus - https://phabricator.wikimedia.org/T176295 (Dwisehaupt) Stalled→Resolved a:Dwisehaupt The collection of these metrics was rolled in to the fundraising_query_collector in T258204. Closing this now. [23:41:52] !log updated payments-wiki from 86c997fdb2 to 7bb99ce03a [23:41:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:43:19] ok, that Carte Bancaire icon is actually gone now [23:53:57] and looks like the rest of the stuff still works well