[00:13:40] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen: Carte Bancaire users seeing error on returning to payments-wiki - https://phabricator.wikimedia.org/T263144 (Ejegg) Open→Resolved a:Ejegg The fix has been deployed, but it looks like Carte Bancaire isn't actually... [10:02:12] (PS6) Jforrester: build: Drop PHP 7.0 support; make MediaWiki 1.35+/PHP 7.2 compatible [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/581653 [10:02:14] (PS2) Jforrester: Replace deprecated OutputPage::parse(), which will be removed from MW [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/565116 (https://phabricator.wikimedia.org/T198214) (owner: C. Scott Ananian) [10:03:32] (CR) jerkins-bot: [V: -1] Replace deprecated OutputPage::parse(), which will be removed from MW [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/565116 (https://phabricator.wikimedia.org/T198214) (owner: C. Scott Ananian) [10:03:35] (CR) jerkins-bot: [V: -1] build: Drop PHP 7.0 support; make MediaWiki 1.35+/PHP 7.2 compatible [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/581653 (owner: Jforrester) [12:56:49] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 23 - https://phabricator.wikimedia.org/T263250 (spatton) [12:56:51] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T263251 (spatton) [12:59:42] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 23 - https://phabricator.wikimedia.org/T263250 (spatton) [13:00:39] tzag fr-tech! [13:06:43] fr-tech the adyen failmail is still coming in. As ejegg|away pointed out this means the donors won't be getting thank you emails [13:08:03] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T263254 (spatton) [13:09:03] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 23 - https://phabricator.wikimedia.org/T263250 (spatton) p:Triage→High [13:09:05] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T263251 (spatton) p:Triage→High [13:10:03] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T263254 (spatton) p:Triage→High [13:42:42] gonna pickup Oscar from school. back soon! [14:29:57] fr-tech hi! [14:30:04] jgleeson|baksoon: thanks for the heads-up! [14:57:00] fr-tech looks like there's no task for those failmail issues? [14:58:08] (the ones jgleeson|baksoon mentioned above...? I think I remember hearing something about it yesterday? Looks like a DB constraint issue?) [15:00:37] AndyRussG: the ticket for the adyen failmails is https://phabricator.wikimedia.org/T263122 [15:01:55] I think the next step is to decide on one of the approaches suggsted by Jeff_Green [15:07:12] jgleeson: ah so not the "Fail Mail (civi1001) run-job: Unsubscribe contacts who have oped out in Silverpop from CiviCRM failed with code 1" ones then [15:07:47] oh wow I didn't realise we'd had 44 of those! [15:07:53] nope AndyRussG this is another one [15:08:05] K right I see those other ones now [15:08:14] it's been raining failmail a lot lately :( [15:08:43] jgleeson: is there anything in either of these that I should try to help with, i.e. drop the Docker stuff and swivel? [15:08:55] or girate [15:19:38] lol [15:20:22] I think we're blocked on the adyen thingy and I'm not sure about the other failmail I haven't looked into it. currently trying to review the 1.35 stuff [15:20:27] argh, yeah, the failmail is really distracting [15:20:42] I think we need to get 1.35 on prod as a first priority though [15:25:50] ejegg: jgleeson: ah okok thx! [15:34:03] oh that's interesting fr-tech [15:34:27] when trying to use `git review -d ######` to pull in ejegg's patches it kept failing [15:34:56] but I just checked out the fundraising/REL1_35 branch for DI and then ran the same git review command and it worked [15:35:19] oh, so git review -d need the same upstream? [15:35:22] which makes me think if git review only lets you pull patches to the branch your on? that would be weird right [15:35:32] looks like it ejegg [15:41:00] jgleeson: what branch were you on before? I've had issues where I was in headless mode on git and git review didn't work [15:41:08] but then I went to master and it worked fine [15:41:17] not the only issue I've had though, only a sometimes solution [15:41:29] that sounds like the same thing [15:41:56] so maybe the limitation is you can't be in headless mode? [15:42:16] I was on a branch but it was pulled down via the gerrit ui and not via git review [15:42:40] AndyRussG: it sounds like the upstreams needs to match locally and the branch your pulling down [15:43:32] ejegg: I'm seeing a bunch of warnings in phpunit when using your first patch ,did you see these also? https://phabricator.wikimedia.org/P12666 [15:44:00] yep, those are fixed by the 'stop messing with $_SERVER' patch [15:44:06] jgleeson ^^ [15:45:12] awesome [15:45:16] thanks for confirming [15:47:37] (CR) Jgleeson: [C: +2] "Fixing the missing test return types bugs for me! nice work." [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627407 (owner: Ejegg) [15:50:21] (CR) Jgleeson: [C: +2] "Fixes the timer bug for me!" [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627404 (owner: Ejegg) [15:56:44] holy cow ejegg [15:57:00] what's that jgleeson ? [15:57:03] the domdocument test failure output takes over everything [15:57:11] heh yeah [16:06:27] ejegg: I'm having a hard time see [16:06:31] arg [16:06:58] ejegg: I'm having a hard time seeing an error relating to this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/627405/3 can you tell me what test triggers it? [16:07:07] (prior to applying the patch) [16:07:22] I've been scanning the logs for warnings/errors but nothing related stands out [16:07:34] jgleeson oh, maybe that was PHP7.4 specific [16:07:47] it's saying that there's an invalid value for foreach [16:07:54] at that line right after the change [16:07:55] oh rly [16:08:10] maybe that's a good catalyst to update my version og php [16:08:14] of [16:10:35] jgleeson don't worry about it if you don't see that error [16:10:46] if you want to just review the patch on its own merits [16:11:03] as not trying to loop over an empty / null things [16:14:22] sure, I guess the callers are only ever expecting and the update makes sense if the list is empty [16:15:20] (CR) Jgleeson: [C: +2] "I can't recreate the error this resolves but having read through the code I'm happy to +2" [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627405 (owner: Ejegg) [16:19:20] (CR) Jgleeson: [C: +2] "fixes the issue and removes the 500 line warning! nice work" [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627403 (owner: Ejegg) [17:05:16] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T263251 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z997cccc7a86f0da06af - Box around input variant: http... [17:07:27] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Add Carte Bancaire logo and enable card type logos in France - https://phabricator.wikimedia.org/T204545 (Pcoombe) Open→Resolved We're no longer supporting Carte Bancaire in France. So I switched both banners and donatewiki to use the existing... [17:18:28] Wikimedia-Fundraising-Banners: Incorrect error message for max donation amount - Edi - https://phabricator.wikimedia.org/T263273 (jbolorinos-ctr) [17:40:04] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Add Carte Bancaire logo and enable card type logos in France - https://phabricator.wikimedia.org/T204545 (TSkaff) Thank you Peter!! [18:02:19] (CR) Ejegg: [V: +2] Update test fn signatures for new PhpUnit [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627407 (owner: Ejegg) [18:02:34] (CR) Ejegg: [V: +2] Stop messing with $_SERVER in tests [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627404 (owner: Ejegg) [18:02:45] (CR) Ejegg: [V: +2] Stop PHP warning/error on empty IP list [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627405 (owner: Ejegg) [18:02:54] (CR) Ejegg: [V: +2] Handle lightncandy passing l10n nested arrays [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627403 (owner: Ejegg) [18:03:04] (CR) Ejegg: [V: +2] Use RemexHTML in tests to handle newer elements [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627564 (owner: Ejegg) [18:31:58] fr-tech I'm heading off for the weekend, have a great one! [19:16:18] Fundraising-Backlog: 3DS2.0 - https://phabricator.wikimedia.org/T228945 (EMartin) Hi All, adding some additional info here for future consideration. MC is going to announce that they will end of life 3DS1.0 in 4.2022 and they are increasing costs associated with 1.0 to incentivize the move to 2.2. Visa ann... [19:21:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Modified date not updated on cid 30379649 - https://phabricator.wikimedia.org/T263282 (Eileenmcnaughton) [19:28:07] !log process-control config revision is 739ea754ca [19:28:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:28:20] I just disabled delete deleted contacts per email [19:36:08] thanks eileen ! [19:36:24] eileen - I might need to make a phab for this [19:36:36] no worries - I would have unstuck it but https://phabricator.wikimedia.org/T263282 [19:36:40] but there is also an issue when the omnimail unsubscribe processor gets to a deleted contact [19:36:55] oh i hadn' checked he issue there [19:37:18] It was consistently failing on one and I just set the is_civicrm_processed flag to 1 [19:37:31] fair enough :-) [19:37:32] since the non-deleted contact with same email already was opted out [19:37:55] but I guess we need to search by email addy or something on that job [19:38:29] or maybe catch if we can check the error type? [19:39:33] would it be better to search by email address? [19:40:40] that way we make sure not to send to that email, no matter what's happened to the contact with that ID [19:45:19] hmm - maybe - we should create a phab & consider that [19:45:49] the contact id should be updated on merge now so it may be a disappearing problem [19:46:26] ah right [21:12:08] (PS1) Ejegg: Update DonationInterface & vendor, commit composer.lock [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/628445 [21:16:03] (CR) Ejegg: [V: +2 C: +2] Update DonationInterface & vendor, commit composer.lock [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/628445 (owner: Ejegg) [21:16:42] (CR) Ejegg: "check experimental" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/628445 (owner: Ejegg) [21:25:06] (PS1) Ejegg: Specify dir for parallel-lint [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/628446 [21:25:24] (CR) Ejegg: "check experimental" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/628446 (owner: Ejegg) [21:30:14] (CR) jerkins-bot: [V: -1] Specify dir for parallel-lint [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/628446 (owner: Ejegg) [21:36:10] (CR) Ejegg: [V: +2 C: +2] "This gets the experimental composer-docker job working." [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/628446 (owner: Ejegg) [21:47:12] eileen: I wonder if the problem really will disappear [21:47:31] the mailing events that are causing the current failmails are from the last couple days [21:47:51] the contact ID in silverpop seems to be an old one [21:48:19] so we're getting new mailing_provider_data rows with contact_ids that have already been deleted [21:48:39] oops sorry, I'll just make a phab for this. It's NZ saturday [21:52:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Omnimail unsubscribe processor fails on deleted contact_id - https://phabricator.wikimedia.org/T263299 (Ejegg) [22:19:45] (CR) Ejegg: [C: +2] "Looks like the same cards for each country as Ingenico" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628132 (https://phabricator.wikimedia.org/T262825) (owner: Mepps) [22:20:17] (PS2) Ejegg: Enable cc donations through Adyen for AU, NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628132 (https://phabricator.wikimedia.org/T262825) (owner: Mepps) [22:25:14] (PS1) Ejegg: Form settings for Adyen AU and NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628458 (https://phabricator.wikimedia.org/T262825) [22:36:50] (CR) Ejegg: "> Patch Set 1:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) (owner: Ammarpad) [22:41:29] (Abandoned) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) (owner: Ejegg)