[00:50:41] fundraising-tech-ops: frdb1001 hardware refresh - https://phabricator.wikimedia.org/T257242 (Jclark-ctr) [04:58:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Schema-change, User-DannyS712: CentralNotice schema audit - https://phabricator.wikimedia.org/T263343 (Marostegui) Let's wait to see what the table owner (per https://www.mediawiki.org/wiki/Developers/Maintainers it is indeed FR team) say a... [11:09:31] tzag fr-tech [11:09:47] looks like the adyen failmail is still coming on strong [11:11:48] maybe we can add a patch to quiet those down until we work out the dns fix with adyen [11:12:33] this failmail amongst the bunch has an interesting subject 'FAILMAIL - ERROR: civi1001 (ingenico) SmashPig-Adyen::processor_adyen' [11:12:47] ingenico & adyen? I wonder if we've got a stray constant somewhere [13:13:22] (CR) Mepps: [C: +2] Form settings for Adyen AU and NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628458 (https://phabricator.wikimedia.org/T262825) (owner: Ejegg) [13:23:53] (PS6) Mepps: Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) [13:24:43] (Merged) jenkins-bot: Enable cc donations through Adyen for AU, NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628132 (https://phabricator.wikimedia.org/T262825) (owner: Mepps) [13:24:45] (Merged) jenkins-bot: Form settings for Adyen AU and NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/628458 (https://phabricator.wikimedia.org/T262825) (owner: Ejegg) [13:31:19] (CR) jerkins-bot: [V: -1] Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [13:32:41] (PS7) Mepps: Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) [13:37:47] (CR) Pcoombe: "> Patch Set 1:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/623037 (https://phabricator.wikimedia.org/T228537) (owner: Pcoombe) [14:48:33] Fundraising-Backlog: FIx misnamed failmail - https://phabricator.wikimedia.org/T263465 (jgleeson) [14:49:10] Fundraising-Backlog: Fix misnamed failmail - https://phabricator.wikimedia.org/T263465 (jgleeson) [15:16:39] Wikimedia-Fundraising-Banners: Incorrect error message for max donation amount - Edi - https://phabricator.wikimedia.org/T263273 (spatton) Hey @EWilfong_WMF, could you check this out? [15:22:59] (PS1) Mepps: Search improvements from cwatts [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/628857 (https://phabricator.wikimedia.org/T262873) [15:26:18] Wikimedia-Fundraising-Banners: Remove "pay the fee" option from France banners before launch - https://phabricator.wikimedia.org/T263469 (Pcoombe) [15:31:08] jgleeson to quiet the failmail you can just change the smashpig settings in adyen/main.yaml [15:31:21] take a look at the last patch in the settings repo [15:31:29] which does the same for paypal [15:33:27] Fundraising-Backlog: Fix misnamed failmail - https://phabricator.wikimedia.org/T263465 (Ejegg) Probably has to do with the logging context we initialize when we start the recurring payments charge job. I think we might not have changed that when we added Adyen charges into the mix. [15:36:06] will do ejegg [15:38:50] busy weekend with paypal ejegg ! [15:39:05] thanks for jumping on that [15:41:12] ejegg: I can see you can add recipients to the failmail steam but I'm curious if it's ok to NOT pass any? [15:41:23] lemme check out that class [15:46:24] oh I see you added the whole logging block [15:46:34] and the second arg is the sender addy [16:04:15] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen, Patch-For-Review: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (jgleeson) So I tried this locally and it works for me. I wonder if th... [16:13:34] jgleeson right [16:14:33] Unfortunately with the cascading configs I don't know a way to override removing a block [16:15:10] hey fr-tech :) [16:15:15] hi AndyRussG [16:15:18] :) [16:23:33] hi fr-tech [16:36:18] howdy AndyRussG and cstone. [16:41:46] cstone: dwisehaupt :) [17:05:29] hey cstone :) [17:05:51] jgleeson: AndyRussG [17:05:54] hi* [17:06:46] hellooooo [17:06:50] :) [17:07:23] cstone: jgleeson: any suggestions for mac setup? [17:07:40] ejegg: ^ [17:07:47] (not urgent, sorry to distract) [17:07:48] hey AndyRussG! I haven't set mine up yet :( [17:08:01] ah okok [17:08:06] I installed homebrew [17:08:16] did it finally arrive? [17:08:23] or did you have to buy one [17:08:33] jgleeson: yes! one arrived, like, with no warning, Friday evening [17:08:52] I think it was ordered from Apple Mexico, so not the same one that couldn't pass customs [17:09:03] delivered by UPS, not DHL, and it had an Apple Mexico sticker on the package [17:09:23] nice! [17:09:36] yeah! Using it for some stuff [17:10:06] hoping the same will occur with the actual work computer [17:11:23] nice AndyRussG and I paused on mac setup as vagrant kept falling at git clones although [17:11:46] my internet here is now 270 instead of the 20 when I left so maybe that will work [17:12:15] ohhh hm right [17:12:22] cstone yeah how was your road trip? [17:13:44] long and boring hah [17:14:45] there was like a giant dust/smoke too maybe? storm going on when i drove through Iowa and it was very beginning of Interstellar [17:15:31] lol cstone [17:16:25] cstone: I tested out the adyen iframe patch today and it worked for me :| https://phabricator.wikimedia.org/T261590#6480519 [17:16:36] I wonder if they updated something inbetween? [17:16:43] cstone whoa glad you made it fine! [17:17:22] oh nice jgleeson [17:17:40] The mac UI isn't bad... I think they copied the old Ubuntu Unity thing of putting all the menus in the status bar on top [17:28:07] my bad ejegg I did see the revert but then subsequently forgot about it! [17:34:28] no worries [17:37:43] hey all, i look forward to us figuring out this adyen thing [17:37:46] the failmail is a log [17:38:02] lot [17:40:45] (CR) Ammarpad: "> Thank so much for the fixes, Ammarpad!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) (owner: Ammarpad) [17:46:45] hey mepps ! [17:51:35] (PS1) Jgleeson: WIP: Add instrumentation to civicrm import process [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628890 [17:53:10] taking a break back later! [17:57:55] (CR) jerkins-bot: [V: -1] WIP: Add instrumentation to civicrm import process [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628890 (owner: Jgleeson) [18:02:54] fundraising-tech-ops: procure and deploy new frmail server role - https://phabricator.wikimedia.org/T257245 (Jgreen) [18:03:29] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/628894 [18:05:32] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/628896 [18:06:13] (Abandoned) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/628894 (owner: Mepps) [18:06:20] (CR) Mepps: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/628896 (owner: Ejegg) [18:09:15] fundraising-tech-ops: procure and deploy new frmail server role - https://phabricator.wikimedia.org/T257245 (ayounsi) [18:27:42] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (mepps) @Eileenmcnaughton do we know if other contacts haven't had this field been updated? [18:32:14] (CR) Ejegg: [V: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/628896 (owner: Ejegg) [18:33:44] !updated crm from cc1f7e6d13 to e5ebf9d18a, [18:33:53] !log updated crm from cc1f7e6d13 to e5ebf9d18a [18:33:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:43:14] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/628904 [18:43:28] ejegg i put this up in case we want to deploy the au and nz forms [18:44:01] ok cool mepps [18:44:20] are we ready for that ejegg or is there somewhere we need to do some testing first? [18:44:46] oh hmm, let's just test a formchooser link for cc in those countries [18:44:55] and make sure it goes to ingenico [18:45:04] we should be able to test that locally [18:45:06] lemme see [18:50:21] looks good to me locally mepps [18:50:26] index.php?title=Special:GatewayFormChooser&uselang=en&language=en¤cy=AUD&amount=10&country=AU&payment_method=cc [18:50:31] want to try ^^^ ? [18:52:17] uh oh ejegg [18:52:27] paymentsinit queue consumer failiures [18:53:13] oh shoot, let's turn the consumer off and check the settings [18:53:18] to see if that prefix is there [18:53:43] ejegg okay i turn it off in settings right? [18:53:52] yep, in the process-control settings [18:55:30] okay ejegg i deployed that [18:55:52] ok, let's see if the prefix exists in civicrm settings [18:55:57] err, the drupal settings [18:56:25] hmm, yeah, eileen's last patch seems to do it [18:58:34] hmm it's still looking in drupal right now [18:59:00] dang, that prefix should have fixed it [18:59:14] fr-tech I've got the beginning of a migraine -_- I'm going to skip backlog refinement to try and stop it hopefully I should be good in a couple of hours [18:59:26] good luck cstone! [18:59:36] oh bummer cstone [18:59:40] feel better soon [19:00:31] ejegg it hoguth i turned that job off but apparently nt [19:00:37] will this have any donor impact? [19:00:51] mepps not immediately [19:01:01] but it'll mess with stats [19:01:20] let's see [19:01:52] did you fcu and rsync the process-control project mepps? [19:02:09] i did ejegg [19:02:16] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-init is 2011 2000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 28 days 4 hours - memory use is 3.36M (peak 46.50M, 0.11% of max, fragmentation 2.68%), connected_slaves is 2, donations is 231, jobs is 0, jobs-adyen is 0, jobs-paypal is 0, payments-antifraud is 295, pending is 4, recurring is 8, refund is 0, unsubscribe is 0 [19:02:36] looks like that last rsync was civicrm, not process-control [19:03:35] ahh ejegg [19:04:41] i got some weird errors [19:04:55] Traceback (most recent call last): [19:04:55] File "/usr/bin/cron-generate", line 7, in [19:04:55] crontab.make_cron() [19:04:56] File "/usr/lib/python3/dist-packages/processcontrol/crontab.py", line 15, in make_cron [19:04:56] job = job_spec.load(job_name) [19:04:56] File "/usr/lib/python3/dist-packages/processcontrol/job_spec.py", line 9, in load [19:04:56] return Job(slug=job_name) [19:04:57] File "/usr/lib/python3/dist-packages/processcontrol/job_spec.py", line 38, in __init__ [19:04:57] self.config = config.JobConfiguration(self.global_config, self.config_path) [19:04:58] File "/usr/lib/python3/dist-packages/processcontrol/config.py", line 135, in __init__ [19:04:58] self.validate_job_config() [19:04:59] File "/usr/lib/python3/dist-packages/processcontrol/config.py", line 141, in validate_job_config [19:04:59] assert "\n" not in self.values["command"], "Job config invalid: 'command' may not contain newlines" [19:05:00] TypeError: argument of type 'NoneType' is not iterable [19:05:07] oh weird [19:05:08] looking [19:06:23] crap [19:06:30] hard to tell which file that would be [19:06:41] ohhh [19:06:51] mepps, you want to comment out the schedule lin [19:06:53] *line [19:06:54] not [19:06:57] the command [19:07:10] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-init is 2474 2000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 28 days 4 hours - memory use is 3.61M (peak 46.50M, 0.11% of max, fragmentation 2.45%), connected_slaves is 2, donations is 191, jobs is 0, jobs-adyen is 5, jobs-paypal is 2, payments-antifraud is 207, pending is 2, recurring is 10, refund is 0, unsubscribe is 0 [19:07:23] ahh okay ejegg [19:07:39] ok, let's revert eileen's patch for now [19:07:44] (the crm one) [19:08:17] okay ejegg [19:08:51] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (DStrine) @Pcoombe this had been deployed [19:09:14] ejegg are we reverting just that one patch? are you taking that on? [19:09:22] (PS1) Ejegg: Revert "Remove an instance of push fredge & document in comments" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628914 [19:09:49] (CR) Mepps: [C: +2] Revert "Remove an instance of push fredge & document in comments" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628914 (owner: Ejegg) [19:10:03] thanks mepps [19:10:35] i also pushed up the patch removing my comments in the payments init config [19:10:36] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/628915 [19:10:50] (CR) Ejegg: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/628915 (owner: Ejegg) [19:12:10] want me to run fundraising_code_update again ejegg? [19:12:16] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-init is 2718 2000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 28 days 4 hours - memory use is 3.71M (peak 46.50M, 0.11% of max, fragmentation 2.42%), connected_slaves is 2, donations is 271, jobs is 0, jobs-adyen is 1, jobs-paypal is 0, payments-antifraud is 141, pending is 2, recurring is 19, refund is 0, unsubscribe is 0 [19:12:40] sure mepps [19:13:49] (CR) Ejegg: [V: +2] Revert "Remove an instance of push fredge & document in comments" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628914 (owner: Ejegg) [19:14:57] !log updated fundraising CiviCRM from e5ebf9d18a to 8f32b6301f [19:15:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:17:16] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: payments-init is 2864 2000 - REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 28 days 4 hours - memory use is 3.85M (peak 46.50M, 0.11% of max, fragmentation 2.43%), connected_slaves is 2, donations is 222, jobs is 0, jobs-adyen is 0, jobs-paypal is 0, payments-antifraud is 195, pending is 1, recurring is 23, refund is 0, unsubscribe is 1 [19:18:01] !log updated crm to 8f32b6301f [19:18:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:22:16] RECOVERY - check_redis on frqueue1001 is OK: OK: REDIS 5.0.3 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 28 days 5 hours - memory use is 2.11M (peak 46.50M, 0.09% of max, fragmentation 3.63%), connected_slaves is 2, donations is 178, jobs is 0, jobs-adyen is 0, jobs-paypal is 0, payments-antifraud is 18, payments-init is 43, pending is 4, recurring is 4, refund is 0, unsubscribe is 1 [19:22:37] ok, looks like the payments-init consumer is happy again mepps! [19:39:25] Wikimedia-Fundraising-Banners: Incorrect error message for max donation amount - Edi - https://phabricator.wikimedia.org/T263273 (EWilfong_WMF) @spatton @jbolorinos-ctr - Fixed in this banner and the other two test variants! [19:49:38] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Eileenmcnaughton) @mepps yes - I think the triggers are not firing for this update - we should get @Dwiseh... [20:01:07] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Port in search improvement on saving groups from Coleman - https://phabricator.wikimedia.org/T262873 (Eileenmcnaughton) Cool - I'll check your commit - we should grab this too https:... [20:01:19] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-AutoTY-Email: New 2020 English thank you email - https://phabricator.wikimedia.org/T262909 (Pcoombe) Openβ†’Resolved a:Pcoombe Thanks David. I made a test donation and got the new email, all looks good! Closing this. [20:05:33] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fundraising Sprint Quackery limited to ducks, and 2 others: Test payments-wiki extensions on MediaWiki 1.35 - https://phabricator.wikimedia.org/T260621 (Jgreen) [x] frdeploy project pa... [20:11:04] Wikimedia-Fundraising-Banners: Incorrect error message for max donation amount - Edi - https://phabricator.wikimedia.org/T263273 (jbolorinos-ctr) Nice! Thanks so much for the quick fix @EWilfong_WMF! Fix verified: {F32358284} [20:19:01] (CR) Eileen: [C: +2] Search improvements from cwatts [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/628857 (https://phabricator.wikimedia.org/T262873) (owner: Mepps) [20:23:52] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (bsisolak) Can we take one step back and sanity check that the Civi database h... [20:27:00] (Merged) jenkins-bot: Search improvements from cwatts [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/628857 (https://phabricator.wikimedia.org/T262873) (owner: Mepps) [20:27:03] (PS1) Eileen: Search ext: Fix field label for aggregate fields [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/628934 (https://phabricator.wikimedia.org/T262873) [20:29:11] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Port in search improvement on saving groups from Coleman - https://phabricator.wikimedia.org/T262873 (Eileenmcnaughton) mepps I merged yours but added https://gerrit.wikimedia.org/r/... [20:49:27] (CR) Mepps: [C: +2] Search ext: Fix field label for aggregate fields [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/628934 (https://phabricator.wikimedia.org/T262873) (owner: Eileen) [20:57:03] (Merged) jenkins-bot: Search ext: Fix field label for aggregate fields [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/628934 (https://phabricator.wikimedia.org/T262873) (owner: Eileen) [21:06:18] (PS3) Jgleeson: Added adyenIframe variant. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/626219 [21:10:48] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen, Patch-For-Review: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (jgleeson) Looks like I hadn't rebased over master when testing previo... [21:45:31] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T263254 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z66ff17ca1282d4de6dd - Reduced copy variant: https://ap... [22:05:55] (PS2) Ejegg: Update FundraisingEmailUnsubscribe for new PHPUnit [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/625944 [22:06:07] (CR) Ejegg: [V: +2 C: +2] Update FundraisingEmailUnsubscribe for new PHPUnit [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/625944 (owner: Ejegg) [22:10:31] (CR) jerkins-bot: [V: -1] Update FundraisingEmailUnsubscribe for new PHPUnit [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/625944 (owner: Ejegg) [22:18:31] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Schema-change, User-DannyS712: CentralNotice schema audit - https://phabricator.wikimedia.org/T263343 (DStrine) @DannyS712 and @Marostegui Fr-tech is basically the only team with engineering knowledge about Central Notice. I'm the product m...