[01:42:57] (PS2) Eileen: Add post-check to make sure all locations are valid [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629216 (https://phabricator.wikimedia.org/T262883) [01:49:43] (CR) jerkins-bot: [V: -1] Add post-check to make sure all locations are valid [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629216 (https://phabricator.wikimedia.org/T262883) (owner: Eileen) [04:17:13] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 2 [=1],cURL_error 36 [=5],minFraud_endpoint_critical 8 [=1] [04:22:13] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 2 [=1],Paypal_endpoint_warning 1 [=1],minFraud_endpoint_critical 5 [=1] [04:25:13] !log civicrm revision changed from 8f32b6301f to a789afd79b, config revision is 9933605187 [04:25:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:27:13] RECOVERY - check_log_messages on frav1002 is OK: OK [04:28:00] ha. just in time for me to hop on and the alert clears. [04:29:28] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Port in search improvement on saving groups from Coleman - https://phabricator.wikimedia.org/T262873 (Eileenmcnaughton) I just deployed this but I suspect he might add further fixes... [04:30:41] logs looking clean. headed back out. [05:26:58] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Eileenmcnaughton) This turns out to be 1 of 135 contacts where the donation was entered and then the finan... [05:31:06] (PS1) Eileen: Update triggers when financial_type_id changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629253 (https://phabricator.wikimedia.org/T262467) [05:31:54] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Eileenmcnaughton) Query to find rows to fix select contact_id, SUM(total_amount) as total, d.endowment_... [08:06:03] Fundraising-Backlog, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)): JJB / zuul support for upgrading payments-wiki to php7.3 and MW 1.35 - https://phabricator.wikimedia.org/T261777 (hashar) Eventually... [08:15:18] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/629319 [08:15:36] (CR) Hashar: "check experimental" [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/629319 (owner: Hashar) [08:44:35] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)): JJB / zuul support for upgrading payments-wiki to php7.3 and MW 1.35 - https://phabricator.wikimedia.org/T261777 (... [08:55:39] (CR) Hashar: "check experimental" [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/629319 (owner: Hashar) [09:12:14] Fundraising-Backlog, FR-Smashpig: Some SmashPig php classes do not comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T263621 (hashar) [09:16:03] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)): JJB / zuul support for upgrading payments-wiki to php7.3 and MW 1.35 - https://phabricator.wikimedia.org/T261777 (... [09:21:18] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Eileenmcnaughton) a:Eileenmcnaughton I fixed the records manually - just need to fix the triggers & re... [11:10:50] tzag fr-tech! [11:15:21] Wikimedia-Fundraising-Banners, Wikimedia-Portals: Fundraising messages on portal in France (2020) - https://phabricator.wikimedia.org/T263629 (Pcoombe) [11:22:37] woohoo looks like the adyen failmail has gone away [12:29:18] (CR) Jgleeson: [C: +2] "Code change looks good. It would be good to discuss this in tech-talk briefly maybe as there are a ton of things happening in this method!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629253 (https://phabricator.wikimedia.org/T262467) (owner: Eileen) [12:36:46] (Merged) jenkins-bot: Update triggers when financial_type_id changes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629253 (https://phabricator.wikimedia.org/T262467) (owner: Eileen) [13:17:21] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (mepps) @Eileenmcnaughton did you fix the triggers? [14:56:03] Wikimedia-Fundraising-Banners: BETA banners Sep 22 - https://phabricator.wikimedia.org/T263602 (jbolorinos-ctr) Thanks Sadok! I'll get started on these now and let you know if anything comes up [15:05:48] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T263576 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z84463d170501569b1ea - Wikipedia will never have ads... [15:10:58] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 23 - https://phabricator.wikimedia.org/T263250 (jbolorinos-ctr) [15:11:00] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T263580 (jbolorinos-ctr) Open→Resolved All bugs found have been reported and addressed. Closing this task now as Resolved, these banners are now READY TO TEST! [15:11:31] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 23 - https://phabricator.wikimedia.org/T263250 (jbolorinos-ctr) [15:11:38] Wikimedia-Fundraising-Banners: 2020-09-23 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T263576 (jbolorinos-ctr) Open→Resolved All bugs found have been reported and addressed. Closing this task now as Resolved, these banners are now READY TO TEST! [15:22:50] Wikimedia-Fundraising-Banners: QA for en6C pre-test on September 23 - https://phabricator.wikimedia.org/T263250 (jbolorinos-ctr) Open→Resolved Alright now the dsk sm and m sm variants and controls have also been QA'ed, and all issues found have been reported and addressed. Closing this task as Resol... [16:04:53] fr-tech, with our recent updates in PHP and the work on the 1.35 stuff, would it make sense now to start including PHP return types and scalar type hints in new code? [16:05:17] PHPStorm just generated a bunch for me on some new methods [16:08:27] jgleeson: hmmm would there be a reason not to? [16:12:29] let's chat about it on tech-talk. I feel like it's a noble goal but there might be legitimate reasons why we can't [16:12:32] AndyRussG: ^ [16:16:16] jgleeson: yeah cool sounds good! [16:20:59] fundraising-tech-ops: Fundraising access request for sbaruchel - https://phabricator.wikimedia.org/T263659 (Dwisehaupt) [16:31:23] fr-tech meet is giving mw 'couldn't start the video call because of an error' [16:31:36] will try restarting browser [16:41:32] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: Error: UNKNOWN missing essential contribution tracking ID - https://phabricator.wikimedia.org/T256274 (Cstone) These are donations coming in from a givelively link which are skipping the f... [16:41:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (DStrine) [16:42:14] Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (DStrine) [16:56:43] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, and 2 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (jgleeson) a:jgleeson→None [17:03:40] dwisehaupt: it's probably safe to pick this up and move it into doing https://phabricator.wikimedia.org/T263122 [17:04:02] actually i see the other task [17:04:54] we might be able to move that first one to done [17:05:07] as technically we're not seeing the failmails anymore [17:07:36] done! [17:20:14] jgleeson: yeah. sounds good to me. [17:22:29] fundraising-tech-ops: Fundraising access request for sbaruchel - https://phabricator.wikimedia.org/T263659 (Dwisehaupt) a:Dwisehaupt [17:24:34] fundraising-tech-ops: Fundraising access request for sbaruchel - https://phabricator.wikimedia.org/T263659 (Dwisehaupt) Approval obtained. ` Date: Wed, 23 Sep 2020 10:18:28 From: Lisa Gruwell Subject: Re: Superset Access for Sophie Baruchel (SSL Certificate) approved ` [17:27:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, Traffic, and 2 others: Spike: CentralNotice: Verify that our Special:HideBanners cookie storm works as efficiently as possible - https://phabricator.wikimedia.org/T117435 (BBlack) Open→Resolved a:BBlack Resolving for... [17:31:53] fundraising-tech-ops: Fundraising access request for sbaruchel - https://phabricator.wikimedia.org/T263659 (Dwisehaupt) [17:33:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, Traffic: CentralNotice: Review and update Varnish caching for Special:BannerLoader - https://phabricator.wikimedia.org/T149873 (BBlack) Are we still working on something here, or is this best closed and any remaining concerns op... [18:05:02] fundraising-tech-ops: procure and deploy new frmail server role - https://phabricator.wikimedia.org/T257245 (Jgreen) [18:29:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Schema-change, User-DannyS712: CentralNotice schema audit - https://phabricator.wikimedia.org/T263343 (DStrine) Hey all, Thanks for looking into this. I appreciate the spirit of looking for improvements. We tend to de-prioritize this sort... [19:02:21] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Eileenmcnaughton) @mepps no - it's merged - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/6... [19:05:55] fr-tech the audit parser finished! [19:06:08] yay jgleeson! [19:06:08] woo " defeated? [19:06:37] gonna check shortly just wanna finish off somethin quick but hopefully yes! [19:06:48] it's too early for the ascii face [19:12:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding the batch number for all Financial Types - https://phabricator.wikimedia.org/T258926 (DStrine) [19:13:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding the batch number for all Financial Types - https://phabricator.wikimedia.org/T258926 (DStrine) Open→Resolved [19:15:07] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/629453 [19:15:22] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/629453 (owner: Eileen) [19:19:26] (CR) Mepps: [C: +2] IDE cheer & formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627396 (https://phabricator.wikimedia.org/T256912) (owner: Eileen) [19:20:48] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Address extraneous pcp queries in donation processing - https://phabricator.wikimedia.org/T262885 (Eileenmcnaughton) @mepps it's passing upstream now - https://github.com/civicrm/civ... [19:27:35] (Merged) jenkins-bot: IDE cheer & formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/627396 (https://phabricator.wikimedia.org/T256912) (owner: Eileen) [19:37:26] Fundraising-Backlog, fundraising-tech-ops: add datacenter and server failover protocol to fundraising disaster protocol documentation - https://phabricator.wikimedia.org/T263686 (Jgreen) [19:41:15] Fundraising-Backlog, fundraising-tech-ops, Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (Jgreen) [19:41:17] Fundraising-Backlog, fundraising-tech-ops: add datacenter and server failover protocol to fundraising disaster protocol documentation - https://phabricator.wikimedia.org/T263686 (Jgreen) [19:41:19] fundraising-tech-ops: Update documentation for mysql master swap - https://phabricator.wikimedia.org/T236849 (Jgreen) [19:58:17] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need By: 2020-09-30) rack/setup/install frdb1004.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T260379 (Jgreen) [19:59:22] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: (Need By: 2020-09-30) rack/setup/install frdb1004.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T260379 (Jgreen) [20:09:17] (CR) Mepps: [C: +1] "This code looks good to me. I haven't been able to test it locally due to some environment issues though." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/629006 (https://phabricator.wikimedia.org/T262885) (owner: Eileen) [20:12:29] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/629467 [20:13:29] okay fr-tech i'm pretty sure the above patch is against the right branch because it says "deployment" but it still has that parent 1 and parent 2 dropdown [20:14:09] ejegg i was thinking the nz and au forms might be ready for deploy since we tested formchooser [20:18:01] oh totally mepps [20:18:34] yeah, that merge looks good [20:18:45] I guess all merges have the two parents listed [20:19:01] (CR) Mepps: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/629467 (owner: Mepps) [20:25:29] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/629467 (owner: Mepps) [20:30:04] (PS1) Mepps: Update DonationInterface Submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 [20:30:59] (CR) Mepps: [C: +2] Update DonationInterface Submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 (owner: Mepps) [20:36:16] (CR) jerkins-bot: [V: -1] Update DonationInterface Submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 (owner: Mepps) [20:36:19] !log civicrm revision changed from a789afd79b to 32a82aa1b7, config revision is 2a55766237 [20:36:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:36:58] (CR) Mepps: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 (owner: Mepps) [20:37:05] (CR) Mepps: [C: +1] Update DonationInterface Submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 (owner: Mepps) [20:41:06] (CR) Mepps: [C: +2] Update DonationInterface Submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 (owner: Mepps) [20:43:24] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Eileenmcnaughton) Regenerated trigger in ~/new_cont_trigges.mysqll on prod (yes typos) [20:43:57] (CR) jerkins-bot: [V: -1] Update DonationInterface Submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 (owner: Mepps) [20:44:16] (CR) Mepps: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/629473 (owner: Mepps) [20:48:08] (PS4) Jgleeson: Add instrumentation to civicrm import process. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628890 (https://phabricator.wikimedia.org/T261689) [20:48:42] * jgleeson says a silent prayer to the jenkins gods [20:54:45] (CR) jerkins-bot: [V: -1] Add instrumentation to civicrm import process. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628890 (https://phabricator.wikimedia.org/T261689) (owner: Jgleeson) [20:57:37] !log updated payments-wiki from 7bb99ce03a to f89c594e12 [20:57:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:59:30] eileen: you ever seen this on CI? 'PHP Fatal error: Maximum execution time of 30 seconds exceeded in /src/wikimedia/fundraising/crm/civicrm/api/v3/utils.php on line 2007' [20:59:50] jgleeson: locally? [21:00:00] not happening locally [21:00:05] on jenkins? [21:00:05] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/628890 [21:00:12] yeah on jenkins.CI [21:03:29] I wonder if the timing stuff is slowing things down [21:10:07] ejegg: the audit donations run earlier, should they have been processed by the qc by now? [21:12:11] not seeing anything new on the affected donors records :( [21:12:21] one for log diving tomorrow I guess [21:15:13] bye for now [22:12:26] (PS1) Eileen: Updated contribution table triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629485 (https://phabricator.wikimedia.org/T262467) [22:15:22] (PS2) Eileen: Updated contribution table triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629485 (https://phabricator.wikimedia.org/T262467) [22:48:36] (CR) Cstone: [C: +2] Updated contribution table triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629485 (https://phabricator.wikimedia.org/T262467) (owner: Eileen) [22:55:46] (Merged) jenkins-bot: Updated contribution table triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629485 (https://phabricator.wikimedia.org/T262467) (owner: Eileen) [22:58:10] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/629489 [22:58:23] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/629489 (owner: Eileen) [23:01:34] Wikimedia-Fundraising-Banners: BETA banners Sep 22 - https://phabricator.wikimedia.org/T263602 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Kinda artsy: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z2767f57185524a60787 - Average ribbon: https://app.crossbrowsertesting.com/... [23:13:21] !log civicrm revision is 32a82aa1b7, config revision is 2a55766237 [23:13:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:14:28] !log civicrm revision changed from 32a82aa1b7 to eb90dbcfd3, config revision is 2a55766237 [23:14:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:22:21] fundraising-tech-ops: Fundraising access request for sbaruchel - https://phabricator.wikimedia.org/T263659 (Dwisehaupt) Contact list updated. SSL cert generated and sent via email. Password for cert sent via SMS. [23:22:23] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [23:22:52] fundraising-tech-ops: Fundraising access request for sbaruchel - https://phabricator.wikimedia.org/T263659 (Dwisehaupt) [23:26:01] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Dwisehaupt) Triggers applied to the source DB and looked good on diff review. [23:27:27] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 3802526 Threads: 2 Questions: 692524371 Slow queries: 1776 Opens: 469115 Flush tables: 1 Open tables: 971 Queries per second avg: 182.122 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [23:35:01] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf endowment total not updated for contact 43739294 - https://phabricator.wikimedia.org/T262467 (Eileenmcnaughton) Thanks @Dwisehaupt works now @DStrine this should be fixed now but it was logged by me...