[00:11:26] Wikimedia-Fundraising-Banners: 2020-09-30 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T263966 (spatton) [00:11:33] Wikimedia-Fundraising-Banners: 2020-09-30 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T263966 (spatton) p:Triageβ†’High [06:25:26] Fundraising-Backlog, FR-Email: Email Preference Center Prototype - https://phabricator.wikimedia.org/T263887 (MSuijkerbuijk_WMF) @KHaggard for visibility. Katers, adding you here to follow the conversations and keep talking about how new fields on the DB would impact our querying. [11:38:17] tzag fr-tech [13:12:57] hello jgleeson fr-tech! [13:13:26] looks like today will be review, review, review.. [13:19:05] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (mepps) Just wanted to update that we had a great conversatoin with @bsisolak,... [13:19:40] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fr-donorservices: French TY email sending donors to unsubscribe page in English - https://phabricator.wikimedia.org/T260814 (mepps) a:meppsβ†’None [13:19:59] hey mepps [13:20:01] yep! [13:20:11] how are you jgleeson? [13:24:02] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Address extraneous pcp queries in donation processing - https://phabricator.wikimedia.org/T262885 (mepps) Thanks @eileen! Testing now. [13:24:16] feelin good thanks mepps. just sitting facing the water working from the car waiting for it to start raining. the air is warmand moist with grey skies that usually precedes a shower . How about you? [13:24:43] why in the car jgleeson? i'm not bad, a little drained after john was gone a good portion of the weekend [13:24:55] but the kids were mostly sweet so mostly full of love :) [13:25:14] ah that's good [13:25:15] hmm i seem to have added emphasis on that *mostly* ;) [13:25:20] :) [13:25:28] we only remember the good parts [13:25:38] i'm trying to jgleeson! [13:25:41] ha [13:26:24] how's tilly and oscar? [13:26:41] do they get along with each other? [13:29:41] re: the car, I started sitting here after the gym last week and it's peaceful so finding it ok for a few hours before I typically head back to pickup Oscar from school. re: the kids, Oscar's struggling a little with tilly at the moment. she's pretty demanding on roxy's time and it starting to invade his space a little so we're working on that to make "special" time for him and keep a balance. [13:29:43] it's changes by the week though, they love playing and then they annoy each other or more precisely tilly starts eating oscars snacks lol [13:29:46] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog: As a email manager, I'd like to see which contacts are suppressed - https://phabricator.wikimedia.org/T261705 (KHaggard) Hi @mepps - thanks for following up. @bsisolak and I have a one-on-... [13:29:47] mepps: ^ [13:29:59] and here is the rain... [13:31:02] jgleeson yeah we deal with that a lot too re: sam needing more attention/getting in james's space [13:32:38] even though it goes too fast already I am looking forward to the time they are at an age when they can just play together and talk to each other [13:32:52] no doubt that'll come with its own challenges too! :) [13:33:07] ok I'm gonna go pickup Oscar, back soon! [13:54:26] (CR) Mepps: [C: +1] "Tested locally and saw no issues." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/629006 (https://phabricator.wikimedia.org/T262885) (owner: Eileen) [14:02:25] (CR) Mepps: [C: +2] dev/core#2056 Only retrieve pcp & soft_credit info when needed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/629006 (https://phabricator.wikimedia.org/T262885) (owner: Eileen) [14:23:32] (Merged) jenkins-bot: dev/core#2056 Only retrieve pcp & soft_credit info when needed [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/629006 (https://phabricator.wikimedia.org/T262885) (owner: Eileen) [15:39:43] hi fr-tech :) [15:39:52] hi AndyRussG! [15:40:02] :) [15:41:06] (PS1) Ejegg: Revert "Disable Carte Bancaire" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630625 [15:41:18] (CR) Ejegg: [C: +2] Revert "Disable Carte Bancaire" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630625 (owner: Ejegg) [15:46:09] (PS1) Ejegg: Remove USD currency from non-US formSettings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630627 [15:47:13] Wikimedia-Fundraising-Banners: France Campaign Banners (for launch) - https://phabricator.wikimedia.org/T263812 (Pcoombe) [15:48:00] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/630629 [15:55:48] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/630629 (owner: Ejegg) [15:57:18] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630632 [15:58:12] (Merged) jenkins-bot: Revert "Disable Carte Bancaire" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630625 (owner: Ejegg) [16:01:16] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need By: 2020-09-30) rack/setup/install frmx2001.frack.codfw.wmnet, frdata2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T260183 (Jgreen) [16:02:22] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630632 (owner: Ejegg) [16:04:46] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need By: 2020-09-30) rack/setup/install frmx2001.frack.codfw.wmnet, frdata2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T260183 (Jgreen) [16:13:43] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/630629 (owner: Ejegg) [16:17:09] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630632 (owner: Ejegg) [16:22:37] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630632 (owner: Ejegg) [16:23:27] (CR) Mepps: [C: +1] "Is this method tested anywhere? I notice the tests succeeded even with the typo. I need to get set up to test this locally.." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629499 (https://phabricator.wikimedia.org/T262883) (owner: Eileen) [16:28:11] (CR) Ejegg: [C: +2] "Recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630632 (owner: Ejegg) [16:34:12] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630632 (owner: Ejegg) [16:45:47] grr, keeps timing out [16:45:49] fundraising-tech-ops, Operations, netops: Automate diff and commit of frack ACL - https://phabricator.wikimedia.org/T260655 (Jgreen) a:Jgreen [16:45:58] Wikimedia-Fundraising-Banners: Emoji appears by itself on a newline - https://phabricator.wikimedia.org/T261974 (jbolorinos-ctr) [16:48:28] Wikimedia-Fundraising-Banners: RML Options not available on JP banners - https://phabricator.wikimedia.org/T255893 (jbolorinos-ctr) [16:48:39] (CR) Ejegg: [V: +2 C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630632 (owner: Ejegg) [16:51:17] ejegg: having trouble with the payment change for france? [16:53:25] dstrine: just the CI infrastructure being stubborn [16:53:33] I'm forcing it through right now [16:53:37] will have it up in a couple min [16:53:52] ah sorry. thanks for dealing with the hassle [16:58:48] !log updated payment-wiki from b2eb456ed1 to 2083498811 [16:58:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:58:53] ok dstrine, it's up [16:58:59] thanks! [17:12:47] Wikimedia-Fundraising-Banners: [Enhancement] Add CC logos to buttons on FR banners - https://phabricator.wikimedia.org/T260451 (jbolorinos-ctr) [17:48:55] (CR) Mepps: [C: +2] "This was merged and tested in core so it's good to go." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/629501 (https://phabricator.wikimedia.org/T262884) (owner: Eileen) [17:50:12] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen, Patch-For-Review: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (mepps) @cstone did you test the final patch? [17:54:42] Wikimedia-Fundraising-Banners: 2020-09-30 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T263966 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z3bcab32e604ed2e3c3a - Only you can decide variant: h... [17:55:58] (Merged) jenkins-bot: dev/core#2057 Remove select query that never or almost never finds something. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/629501 (https://phabricator.wikimedia.org/T262884) (owner: Eileen) [17:59:06] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen, Patch-For-Review: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (Cstone) I did @mepps the variant in the iframe loads for me but it gi... [18:01:03] Fundraising-Backlog, FR-dlocal, MediaWiki-extensions-DonationInterface: We calculate a bad DLocal signature when email contains '+' - https://phabricator.wikimedia.org/T264030 (Ejegg) [18:08:51] Wikimedia-Fundraising-Banners: RML displayed on nag (no RML variant) - https://phabricator.wikimedia.org/T264031 (jbolorinos-ctr) [18:13:02] Wikimedia-Fundraising-Banners: 2020-09-30 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T263921 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z7be1abd375fcbe8a657 - Other ways to help variant: ht... [18:19:27] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen, Patch-For-Review: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (jgleeson) @Cstone could you screenshot and post what you see if you g... [18:21:13] jgleeson: I go to make your screenshot and it works it literally just failed on me 5 minutes ago... [18:21:37] (β•―Β°β–‘Β°οΌ‰β•―οΈ΅ ┻━┻ [18:23:51] hmmm sounds like something is wrong then [18:24:54] it repeatedly works now hmmm let me try something [18:25:28] Hah ok got it [18:26:20] i was doing it in an incognito window because I wanted to make sure i could get the iframe, that gets me the error [18:28:30] oh interesting [18:28:39] that could also be cookies related [18:29:33] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, FR-Adyen, Patch-For-Review: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (Cstone) {F32366871} Okay this is happening when I open the iframe in... [18:31:04] thanks cstone [18:55:51] cstone ooh, incognito has different cookie policies I guess? [18:59:27] yeah the donations go through fine on normal chrome [19:12:38] !log updated staging payments-wiki from 43470629cc to 885d87a905 [19:12:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:32:39] Wikimedia-Fundraising-Banners: RML displayed on nag (no RML variant) - https://phabricator.wikimedia.org/T264031 (Pcoombe) @jbolorinos-ctr I removed the RML button from the nag: [diff](https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-spatton_0930_en6C_dsk_lg_shr_normlotherways&di... [19:52:49] (CR) Eileen: "So the tests run through this code - but in the current flow - it actually does nothing so we can't test it per se" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/629499 (https://phabricator.wikimedia.org/T262883) (owner: Eileen) [20:18:41] Fundraising-Backlog: Investigation: Send mail in drual modules on crm through external server - https://phabricator.wikimedia.org/T264046 (mepps) [20:29:32] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, MediaWiki-Docker: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (DStrine) [20:39:45] (CR) Cstone: [C: +2] "Looks good, testing fine locally (non incognito)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/626219 (owner: Jgleeson) [20:57:54] (Merged) jenkins-bot: Added adyenIframe variant. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/626219 (owner: Jgleeson) [20:59:13] thanks cstone ! [21:01:17] fundraising-tech-ops: Fundraising access request for Sheyna Daniels Major Gifts - https://phabricator.wikimedia.org/T264051 (RLewis) [21:24:34] cstone: so with Jack's patch merged - we should deploy it & then figure out how we take our baseline measures [21:24:56] eileen: that was the other patch Jack had the stats one isn't merged yet [21:25:03] oh OK [21:25:06] (PS8) Jgleeson: Add instrumentation to civicrm import process. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628890 (https://phabricator.wikimedia.org/T261689) [21:25:08] (PS1) Jgleeson: WIP: Add unit tests for civicrm import stats patch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/630683 (https://phabricator.wikimedia.org/T261689) [21:25:14] do you need any help on it? [21:25:40] I just started testing it running into some weird errors but i think its my local git misbehaving [21:26:37] :-) [21:27:34] cstone: what is the change I need to make on that qperf one? [21:27:36] thanks cstone and eileen ! I just pushed up a WIP patch for some tests which I'll finish first thing to complement the first patch. have a good evening/morning :) [21:27:47] night :-) [21:28:30] eileen: I think adding a wmf_common_create_smashpig_context [21:29:00] will get rid of that config error [21:30:43] https://www.irccloud.com/pastebin/idELPVLE/ [21:31:01] I'll have to dig more [21:32:43] (CR) jerkins-bot: [V: -1] WIP: Add unit tests for civicrm import stats patch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/630683 (https://phabricator.wikimedia.org/T261689) (owner: Jgleeson) [22:05:45] ok - updated exchange rates via ui [22:05:53] & it worked [22:07:53] (PS1) Eileen: Fix q-perf for smashpig change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/630686 [22:08:33] cstone: so ^^ fixes it so the q-perf command works again (with your sugggesion) [22:09:02] nice eileen [22:27:01] eileen: have you tried Jack's patch it keeps telling me class not found even though its right there [22:27:26] ohh - I'll try now - got side tracked into the survey :-( [22:27:50] no rush [22:31:30] you got this [22:31:31] WD php: Error: Class 'wmf_civicrm\ImportStatsCollector' not found in wmf_civicrm_contribution_message_import() (line 187 of [22:32:19] yeah WD php: Error: Class 'wmf_civicrm\ImportStatsCollector' not found in queue2civicrm_batch_process() (line 155 [22:34:53] I think it's working after having done drush cc all -y [22:35:13] yeah i just did that! hah [22:38:54] so it ran -nothing in/var/spoo [22:41:58] cstone: do I need to enable something for that? [22:43:02] I was asking Jack about that too, I didn't see anything and I manually made the folder but there's still no results in it [22:47:49] hmm - O K I wasn't going through the donation queue consumer https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/628890/8/sites/all/modules/queue2civicrm/queue2civicrm.module#159 [22:52:51] yeah I made a couple donations and dont see the output file, it is touching the code at least though cause it will error with no donations [22:53:26] (CR) Cstone: Add instrumentation to civicrm import process. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628890 (https://phabricator.wikimedia.org/T261689) (owner: Jgleeson) [22:53:56] (PS9) Eileen: Add instrumentation to civicrm import process. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/628890 (https://phabricator.wikimedia.org/T261689) (owner: Jgleeson) [22:53:58] (PS1) Eileen: Parse q-perf results through ImportStatsCollector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/630689 [22:54:23] cstone: I got output using ^^ [22:54:30] oh nice [23:00:09] oh I missed tech talk [23:00:57] tomorrow :) [23:01:04] :-) [23:01:12] youre just really early for it [23:01:15] yeah it's only Tuesday... [23:01:18] just realised [23:02:29] Wyoming fire smoke cloud is descending on us here and the horizon is just slowly disappearing [23:05:57] cstone: eek! [23:05:57] oh wow - freaky [23:06:42] cstone: so in terms of this patch - I think it's working - we could +2 & then you can do a follow up with the extra exception & I'll +2 that too? [23:07:22] I just wish I could get it to make the log locally [23:11:12] cstone: try the way I'm doing it - via q-perf with those 2 patches https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/630689 [23:11:41] yeah I was trying that [23:14:20] eileen is there a use missing for the last patch in that chain? [23:14:30] could be! [23:14:44] i got qperf to run but still no log hah [23:14:53] it's stopped working locally so I may have had it but uncommitted [23:15:22] added [23:15:22] (PS2) Eileen: Parse q-perf results through ImportStatsCollector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/630689 [23:15:58] Average performance is INF per minute. seems pretty good :) [23:16:24] nice - let's roll it out now! [23:17:29] hah sorry was joking when it was 1, did you end up having to make the folder? [23:17:40] I did make it [23:19:10] alright i deleted it and made it again maybe itll behave [23:19:33] (CR) Cstone: [C: +2] Fix q-perf for smashpig change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/630686 (owner: Eileen) [23:25:15] on staging I got a redis error [23:28:21] hmm [23:37:52] (Merged) jenkins-bot: Fix q-perf for smashpig change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/630686 (owner: Eileen) [23:42:05] fundraising-tech-ops: Fundraising access request for Sheyna Daniels Major Gifts - https://phabricator.wikimedia.org/T264051 (Dwisehaupt) [23:54:12] I'm not having any luck locally eileen and have to run soon, I can talk to Jack tomorrow and hopefully we can get it behaving before you log on? [23:54:18] sure!