[00:01:48] ok - I can dig in [00:04:17] (CR) Eileen: [C: +2] Move csv upload button under format options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631286 (owner: Ejegg) [00:16:21] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [00:18:01] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [00:20:58] (Merged) jenkins-bot: Move csv upload button under format options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631286 (owner: Ejegg) [00:46:39] (PS4) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [00:54:07] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [00:58:17] (PS5) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [01:15:10] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [10:33:01] Fundraising-Backlog, Thank-You-Page, Wikipedia-iOS-App-Backlog: Donation redirect to app shows broken inset - https://phabricator.wikimedia.org/T264259 (Pcoombe) Interesting. Well this is an improvement over the error pages people were getting before at least! I would guess this is the dark mode ch... [12:14:46] tzag fr-tech! [12:46:54] hmm looks like we had a few more donation queue consumer failmails than usual [12:47:41] let's check out last nights logs [12:58:11] oh man, fr-tech it looks like we have another record with an unexpected character in a zip code coming in from the audit alongside the one we tried to fix in tech-talk [12:58:48] this might bump up the priority of the ticket for this issue [13:00:57] we have two tasks relating to this issue already https://phabricator.wikimedia.org/T262232 and https://phabricator.wikimedia.org/T262576 [13:28:13] (CR) Jgleeson: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630946 (owner: Jgleeson) [13:35:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Contributions in Civi currently not saving - https://phabricator.wikimedia.org/T264222 (mepps) This looks like it may have been a php version issue? I wasn't seeing the same error on my local... [14:37:07] Fundraising-Backlog: Donations queue consumer failed - Invalid character input in postal code - https://phabricator.wikimedia.org/T262232 (Ejegg) We hardly ever use postal code, so I think it's OK if we either just filter out invalid chars or just blank the field when it's invalid. We shouldn't let it stop t... [14:50:07] dstrine: ejegg I might bring this into sprint if it means it's stopping imports. https://phabricator.wikimedia.org/T262232 I was under the impression it was only affecting our internal records for a single donation but ejegg's comment suggests otherwise [14:52:48] jgleeson: So it's not stopping us completely, but if we're getting a mail that says the donation QC failed with a non-zero exit code, it's definitely killing one run [14:53:39] sure and it's also producing daily failmail which we could do without [15:14:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, Patch-For-Review: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (RLewis) @Eileenmcnaughton oh yikes, what can we do here? Is there anything I ca... [15:37:14] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (HNordeenWMF) [15:38:14] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (HNordeenWMF) p:Triage→Medium [15:39:34] Fundraising-Backlog: Leticia Navarro needs Civi access - https://phabricator.wikimedia.org/T264325 (EMartin) [15:51:52] fr-tech MBeat kristierobinson Hi! friendly reminder France banners are going up in 10 [15:52:05] ty tskaff we’re ready [15:52:16] thanks tskaff [15:52:29] MBeat: in that case, we're not going to test the upgraded payments servers [15:52:44] at least till the initial rush subsides [15:52:52] got it, thanks for waiting til a slower moment [15:59:52] Wikimedia-Fundraising-Banners: QA: frFR dsk sm - banner above heading - https://phabricator.wikimedia.org/T264330 (Pcoombe) [16:01:44] Wikimedia-Fundraising-Banners: QA: frFR dsk lg - move smallprint back below message only - https://phabricator.wikimedia.org/T264331 (Pcoombe) [16:03:34] Fundraising-Backlog, fundraising-tech-ops: Leticia Navarro needs Civi access - https://phabricator.wikimedia.org/T264325 (DStrine) [16:13:59] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (jbolorinos-ctr) Thanks @HNordeenWMF! I'll get started on these now and let you know if anything comes up! [16:23:05] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (HNordeenWMF) Thanks John! There will be 2 more design tests that need QA - would you prefer separate tasks, or should I add them into this one? [16:31:46] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (EWilfong_WMF) Just wanted to note that we recently discovered that WYDG Foundation webpage is not up-to-date (it uses numbers/text from a previous annual report rather than the most recent one). Might... [16:41:29] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (HNordeenWMF) Good point @EWilfong)WMF ! I'll check with Camille, and we'll hold off. [16:55:21] Fundraising-Backlog, fundraising sprint Theme songs for programming languages: new endowment TY email - https://phabricator.wikimedia.org/T263877 (Cstone) a:Cstone [17:01:06] Fundraising-Backlog: Tighten up input validation on payments form zip/postal code field - https://phabricator.wikimedia.org/T262576 (DStrine) [17:01:11] Fundraising-Backlog: Donations queue consumer failed - Invalid character input in postal code - https://phabricator.wikimedia.org/T262232 (DStrine) [17:01:55] Fundraising-Backlog: Donations queue consumer failed - Invalid character input in postal code - https://phabricator.wikimedia.org/T262232 (DStrine) [17:02:05] Fundraising-Backlog, fundraising sprint Theme songs for programming languages: Donations queue consumer failed - Invalid character input in postal code - https://phabricator.wikimedia.org/T262232 (DStrine) [17:19:29] Fundraising-Backlog: Civi Credential for Melanie - https://phabricator.wikimedia.org/T264335 (LeanneS) [17:22:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi credential for Engage staff member, Ryleigh S. - https://phabricator.wikimedia.org/T264337 (LeanneS) [17:24:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: clean up name order for Japanese donors in the civi database - https://phabricator.wikimedia.org/T264338 (DStrine) [17:25:35] Fundraising-Backlog, Thank-You-Page, Wikipedia-iOS-App-Backlog: Donation redirect to app shows broken inset - https://phabricator.wikimedia.org/T264259 (Ejegg) For testing purposes, this link should give the mobile-ified version of the page: https://thankyou.wikipedia.org/api/rest_v1/page/mobile-htm... [17:25:56] Fundraising-Backlog, fundraising-tech-ops: Civi Credential for Melanie - https://phabricator.wikimedia.org/T264335 (DStrine) [17:26:27] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z9c696a4a8347ba6abd0 - WYDG variant: [17:26:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Civi credential for Engage staff member, Ryleigh S. - https://phabricator.wikimedia.org/T264337 (DStrine) [17:30:00] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (jbolorinos-ctr) Good to note Eric! Also thank you @HNordeenWMF for that helpful note, I'll pause QA on this for now then and prioritize the France tests Peter prepared. [17:31:04] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (jbolorinos-ctr) I was also going to ask about the URL actually, currently for the FR WYDG page the url is https://wikimediafoundation.org/fr/support/where-your-money-goes/ Would it make sense to maybe... [17:31:52] Fundraising-Backlog, Thank-You-Page, Wikipedia-iOS-App-Backlog: Donation redirect to app shows broken inset - https://phabricator.wikimedia.org/T264259 (Ejegg) I see there's some inline style with this: body { margin: 0; font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI',... [17:50:12] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (TSkaff) @jbolorinos-ctr You can continue with the QA on the banner in this case; whether or not we need to update info on the page won't affect us testing the banner itself, but thanks for checking! [17:52:14] Fundraising-Backlog, Thank-You-Page: TY page for EN France: social media code visible - https://phabricator.wikimedia.org/T261683 (Pcoombe) It looks like this is coming from the REST API: https://thankyou.wikipedia.org/api/rest_v1/page/mobile-html/Thank_You @jrobell Do you have the Wikipedia app install... [18:20:48] Fundraising-Backlog, Thank-You-Page, Wikipedia-iOS-App-Backlog: Donation redirect to app shows broken inset - https://phabricator.wikimedia.org/T264259 (Pcoombe) Okay I took out a couple of the `background: #fff` declarations which has at least made the main text readable in dark mode, but now the lo... [18:35:48] (CR) Jgleeson: [V: +2 C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630946 (owner: Jgleeson) [18:41:16] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/630946 (owner: Jgleeson) [18:47:45] Wikimedia-Fundraising-Banners: France banner with link to WYDG - https://phabricator.wikimedia.org/T264324 (jbolorinos-ctr) Ok cool, sounds good, QA is continuing now then :) Thank you Thea! [19:01:41] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Adyen: reimplement adyen iframe in a variant - https://phabricator.wikimedia.org/T261590 (jgleeson) @DStrine this is no... [19:19:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Contributions in Civi currently not saving - https://phabricator.wikimedia.org/T264222 (Eileenmcnaughton) @mepps no there was an issue see https://phabricator.wikimedia.org/T264222#6507012 [19:20:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Contributions in Civi currently not saving - https://phabricator.wikimedia.org/T264222 (Eileenmcnaughton) a:Eileenmcnaughton [19:21:28] I'm gonna try again on that benevity test now cos it wasn't happening yesterday [19:32:40] fundraising-tech-ops, Operations: (Need By: 2020-09-30) rack/setup/install frmx1001 & frdata1002 - https://phabricator.wikimedia.org/T260181 (Jgreen) [19:39:45] fundraising-tech-ops: procure and deploy new frmail server role - https://phabricator.wikimedia.org/T257245 (Jgreen) [19:42:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Contributions in Civi currently not saving - https://phabricator.wikimedia.org/T264222 (mepps) Yup I was basing my guess on your fix, [19:46:32] (PS6) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [19:47:05] hmm - clutching at straws on this benevity test with the currency fail [19:51:03] eileen: maybe try turning the extreme logging output back on in that patch? [19:51:36] ejegg: hmm - I mean it is definitely the exchange rate - I managed to get that much output [19:52:04] 14:15:05 "INVALID_MESSAGE UNKNOWN_CURRENCY: 'JPY': No conversion available for currency JPY","Mickey Mouse Inc",,2015-11-01T23:09:28Z,Minnie,Mouse,minnie@mouse.org,"2 Cheesey Place",Mouseville,CA,90210,"Wikipedia roc ks",,trxn-QUACK,"One Time",JPY,,BlueSnap,4000,464,12000,254 [19:52:28] but I a m setting the currency... [19:52:44] (currrently testing in a second place) [19:53:42] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [19:54:30] oh - I think I know.... [19:54:43] no $this->epochtime = wmf_common_date_parse_string('2016-09-15'); [19:54:52] that should be before my date [19:58:16] (PS7) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [20:05:30] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [20:13:02] (PS8) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [20:31:15] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [20:34:10] Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (mepps) I just realized I assumed that this task was about making monthlyConvert the default and then bei... [20:38:25] Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (DStrine) [20:51:38] Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (mepps) Now I'm wondering if a good place to put this is in readConfig, or at least to put in an option t... [20:55:41] (PS9) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [20:58:33] Wikimedia-Fundraising-Banners: QA: frFR dsk sm - banner above heading - https://phabricator.wikimedia.org/T264330 (HNordeenWMF) [20:59:27] Wikimedia-Fundraising-Banners: QA: frFR dsk lg - move smallprint back below message only - https://phabricator.wikimedia.org/T264331 (HNordeenWMF) [21:02:46] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [21:36:09] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (Jdlrobson) [21:36:55] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (Jdlrobson) p:Triage→Unbreak! Possibly not unbreak now, but not sure as I don't know much about this banner campaign. Hopefully, someon... [21:37:01] pcoombe / spatton: ^^^ looks like it needs attention [21:37:12] or tskaff ^^^ [21:37:17] JS bug in a french banner [21:38:51] Thanks Elliott; I'm trying to understand what the bug is here ... [21:39:22] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (Jdlrobson) I'm also seeing the error NS_ERROR_FILE_CORRUPTED: on French Wikipedia which is likely related. https://logstash.wikimedia.org/ap... [21:40:37] tskaff: in that banner I see a bunch of localStorage.getItem() calls [21:40:49] guess maybe localStorage can be null in some cases? [21:41:13] Sorry, but I don't understand what that means--do I need to take banners down? [21:41:40] Also ... there was another banner running on fr Wikipedia earlier (not ours) ... are we sure it's ours? [21:42:58] the person that posted the task seems to have traced it to a banner: https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B2021_1002_frFR_m_p1_lg_txt_swap [21:43:03] not sure how [21:43:44] but it started at 16:00 UTC, which is I think the same time the campaign started [21:44:04] Yep 16 UTC is us [21:44:50] looks like the banner code is trying to get the view count out of localStorage [21:45:09] and that's not necessarily accessible depending on browser settings [21:45:29] I think we've got a safer way to look for that value in the CN code [21:45:32] lemme see [21:46:51] Hrm. It's just that one (test) banner and not the control, running at the same time? [21:47:30] well, we can at least check ext.centralNotice.kvStore.isLocalStorageAvailable() before trying getItem() [21:50:13] cn.kvStore.getItem() would be the most appropriate way I think [21:50:28] tskaff not sure, which is the control banner? [21:50:42] B2021_1002_frFR_m_p1_lg_txt_cnt [21:50:44] Control ^ [21:50:49] thanks! [21:50:50] B2021_1002_frFR_m_p1_lg_txt_swap [21:50:53] ^ Test [21:51:17] Just checked banners settings and all looks ok [21:51:30] tskaff: I see the same code in the control - I think they both need a fix [21:51:39] Ok [21:51:46] this line in both: var diet = JSON.parse( localStorage.getItem( lsName ) ); [21:52:03] needs to check that localStorage isn't null and doesn't throw errors when you getItem() on it [21:52:29] since its availability depends on privacy settings [21:52:33] Ok, since I rarely work in the JS for these, what is the exact line of code? Then I can put it in [21:52:49] hmm, that editor doesn't have line numbers [21:53:00] but if you search for getItem, you'll see it [21:53:13] I see it in the banner code yeah [21:53:23] What should it change to? [21:54:12] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (DStrine) [21:55:34] tskaff: it needs to be inside a conditional block like if (localStorag) { .... } [21:55:41] err, but spelled right [21:56:16] and then you might need a try{ ... } catch {} around it too [21:57:53] Could I trouble you to write the line exactly how it should appear? This is not my level of JS so I will almost certainly screw it up ... [21:58:27] oh shoot, lemme see [21:59:10] This is what I see: [21:59:11] var diet = JSON.parse( localStorage.getItem( lsName ) ); [22:00:35] Hrm I also see that bit of JS is related to functionality we actually aren't using in France, just 6C [22:01:20] oh hah, yeah, those ordinals are in english [22:01:31] Ahhh [22:01:31] ok, so anywhere else you want to use that code it needs the fix [22:01:36] I think this is it: https://etherpad.wikimedia.org/p/FRBanner-JS-Fix [22:01:43] but that needs testing [22:02:15] Ok ... how to proceed ... thinking [22:02:58] oops, lemme fix a little thing on that etherpad [22:03:35] I just pasted a block of JS i think we can get rid of, but I don't want to trip anything up [22:03:56] ok, yeah, that whole block looks deleteable [22:04:06] the whole /* Seen banner count */ ya? [22:04:42] yep yep [22:04:58] I don't see any of those seenCount placeholders down in the text of either banner [22:05:11] which makes sense given the english only replacements [22:05:31] Just to be safe, I kind of want to take down the mobile campaign, change banners, take a look at them. [22:05:48] Also ... would this not apply to desktop banners too? [22:06:53] tskaff: anywhere that JS is being used would trigger the error [22:06:58] Hi, just catching up. Yeah it looks like that block is in desktop too, and can just be removed [22:07:04] thanks pcoombe [22:08:17] Hey Peter. Do you think we need to take campaigns down to do this or no? [22:08:22] so we should keep an eye on those error graphs when we launch banners I guess [22:08:35] lemme refresh my memory on where that showed upu [22:08:37] *up [22:08:41] Yeah I was wondering why this wasn;t triggered in the pre-test? [22:08:41] logstash I think? [22:08:58] tskaff: it's probably a pretty small % of users [22:09:04] Ah [22:09:06] with specific privacy settings / browsers [22:09:58] The logstash for client-side errors is a new thing. It's not on en.wikpedia yet, only fr.wikipedia and some others. I was meaning to ask jon about how we can monitor it for banner errors [22:10:24] He wrote a neat blog post about it https://jdlrobson.com/posts/2020-09-28_diving-into-wikipedia-s-ocean-of-errors-a6b6be92bf2e?r=jt [22:12:42] tskaff: I'll just dive in and remove the offending code from the live banners. Don't think we need to take campaigns down for this [22:13:06] Sweet, thanks very much Peter! [22:14:00] I don't really think this is Unbreak Now - 2000 errors is small in the grand scheme of France banner impressions - but may as well fix it now I'm here [22:16:21] nice link pcoombe [22:20:59] Okay the French ones are done. I'm just checking English to make sure we're not using the counter in those at all [22:22:22] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Error: Syntax error, unrecognized expression: [id='Organisation_et_tactique_de_l'armée_spartiate'] - https://phabricator.wikimedia.org/T264373 (Jdlrobson) [22:23:02] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Error: Syntax error, unrecognized expression: [id='Organisation_et_tactique_de_l'armée_spartiate'] - https://phabricator.wikimedia.org/T264373 (Jdlrobson) p:Triage→High [22:25:53] looks like a lot of the hits for that error refer to it happening in an android webview [22:26:21] ooh, jdlrobson with another client-side error [22:27:16] Thanks again Peter. I hope you end early tomorrow to make up for these late hours. [22:27:25] hmm, looks like eval() ing something with quotes not being escaped? [22:28:44] I'm dashing off to grab my kid but will be back later [22:36:00] (CR) Cstone: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [22:40:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make it easier to identify client side errors from CentralNotice banners in logs - https://phabricator.wikimedia.org/T264375 (Pcoombe) [22:42:57] (Merged) jenkins-bot: Use first two characters of locale for mediawiki compatibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/626204 (https://phabricator.wikimedia.org/T260814) (owner: Mepps) [22:47:14] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (Pcoombe) p:Unbreak!→High Thanks for spotting this @Jdlrobson. We did indeed launch our France campaign at 4pm... [22:47:52] for those with logstash access, this seems to be the place to look at those JS error counts: https://logstash.wikimedia.org/app/kibana#/dashboard/AXDBY8Qhh3Uj6x1zCF56 [22:48:10] Is there anyway I couldve caught that error earlier in the preview links? [22:52:12] eljohnny: Probably not, they're only happening rarely. T264366 was reported about 2,030 times since launch, T264373 was 2,189. We've shown millions of banners in that time [22:52:12] T264366: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 [22:52:12] T264373: Error: Syntax error, unrecognized expression: [id='Organisation_et_tactique_de_l'armée_spartiate'] - https://phabricator.wikimedia.org/T264373 [22:55:13] Oh right, well maybe this would be something I could add to the QA process then? Like a last quick check on production? [23:00:58] Hmm I wonder what the NS_ERROR_FILE_CORRUPTED mentioned in T264366#6510591 is. Problem with one of our SVG files? [23:00:58] T264366: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 [23:01:30] Anyway I'm going to bed now. Will add this to the teetering pile of things I need to investigate tomorrow [23:28:05] crud another big batch of paypal payments with no subscription found [23:34:27] I think we need to just create new recurring records for those [23:35:46] dstrine: there are dozens and dozens of paypal donations not making it to Civi lately because we're not getting the 'subscription_started' notification we expect [23:36:03] ejegg: ah! is there a task? [23:36:16] I think we can work around that without too much trouble, and just create the subscription when we get the first payment notification [23:36:25] This task fits the bill: https://phabricator.wikimedia.org/T248420 [23:36:39] though it was made when there were a lot fewer payments in limbo [23:39:14] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (Jdlrobson) [23:40:39] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (Jdlrobson) Nice! I can confirm the drop off! {F32370464} Thanks for the bug fix. I'm happy to help you setup a dash... [23:45:02] ejegg: do you feel like it needs to be done like right now or can we discuss at standup? [23:51:22] (PS1) Cstone: Update endowment thank you text. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631556 [23:51:41] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (DStrine)