[00:27:01] ejegg|away: cool beans, thanks! [00:43:51] (PS10) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [00:50:48] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [01:14:08] (PS11) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [01:33:32] (CR) jerkins-bot: [V: -1] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [02:11:22] (PS12) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [02:21:26] fundraising-tech-ops: Fundraising access request for for Noah Israel - https://phabricator.wikimedia.org/T264473 (Ppena) Can we also get superset access? Thanks :) [02:41:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, Patch-For-Review: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (Eileenmcnaughton) MariaDB [civicrm]> select sum(total_amount), count(c.id), sum... [04:33:10] (PS1) Cstone: WIP: Add more translations for failed recurring messages. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 [05:12:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, Patch-For-Review: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (Eileenmcnaughton) Hmm - I think I'd like to pick up the fix question in tech ta... [07:53:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, Patch-For-Review: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (Eileenmcnaughton) @RLewis there are around 600 already-imported benevity contri... [09:15:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, Patch-For-Review: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (RLewis) @Eileenmcnaughton there are individual imports for a specific currency,... [14:28:42] (PS1) Mepps: Remove packages/DB.php dependency from install script [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/632496 [14:45:28] fundraising-tech-ops: keep frpm*:/var/lib/git in sync across all fundraising puppetmasters - https://phabricator.wikimedia.org/T264128 (Jgreen) Open→Resolved p:Triage→Medium [15:08:19] hi fr-tech! [15:14:57] hi ejegg [15:15:00] hi fr-tech [15:15:13] howdy [15:19:43] today's album fr-tech is a repeat offender, Hans Zimmer: Live in Prague [15:22:15] I'm listening to one of my namesakes, Ramblin' Jack Elliott [15:22:59] the album is the Early Sessions featuring such songs as "Salty Dog Blues" [15:23:24] "If I can't be your salty dog, I ain't gonna be your man at all" [15:26:44] lol nice [15:26:47] I'll check that out [15:28:55] I couldn't find Early Sessions but I could get Best Of The Vanguard Years [15:29:19] nice, should be good too [15:35:36] morn' [15:36:12] i'm still deciding on today's tunes. the day of punk yesterday was good. perhaps today will be a day of p-funk. [15:39:43] hey fr-tech ejegg jgleeson XenoRyet dwisehaupt mepps [15:46:18] hi AndyRussG [15:46:24] nice dwisehaupt [15:47:49] i might just queue up Maggot Brain after the O Brother soundtrack that just started [15:47:59] howdy dwisehaupt AndyRussG [15:49:25] hi fr-tech [15:49:37] hi cstone [15:50:22] AndyRussG: so you're building the docker image with the docker-pkg script from /operations/docker-images/docker-pkg ? [15:51:22] I get the feeling it's going to use all my disk space... [15:52:48] that's the joy of all these dev environments. they bring the datacenter to you. all of it at once. :) [15:54:26] i love the convenience, not so much the 128G of vms i have right now. [15:56:09] fundraising-tech-ops: Fundraising access request for for Noah Israel - https://phabricator.wikimedia.org/T264473 (Dwisehaupt) [15:59:11] :) [15:59:34] ejegg: it doesn't use much disk space for me, I don't think [15:59:47] I don't build all the images, just the fr one, as per the readmy [15:59:49] readme [16:00:10] I mean, that also builds the base buster one, but not others [16:00:17] ok, cool [16:01:11] $ docker image ls [16:01:13] REPOSITORY TAG IMAGE ID CREATED SIZE [16:01:15] docker-registry.wikimedia.org/dev/fundraising-buster-php73-apache2-xdebug 0.0.1-1 5307e8b8f7c0 33 hours ago 319MB [16:01:17] docker-registry.wikimedia.org/dev/fundraising-buster-php73-apache2-xdebug latest 5307e8b8f7c0 33 hours ago 319MB [16:01:19] docker-registry.wikimedia.org/dev/buster 0.0.1-1 ec0a22107350 33 hours ago 228MB [16:01:21] docker-registry.wikimedia.org/dev/buster latest ec0a22107350 33 hours ago 228MB [16:01:23] mariadb 10.4 96e797480ac5 10 days ago 399MB [16:01:25] docker-registry.wikimedia.org/wikimedia-buster [16:01:46] the two that say "latest" there are repeated (same image id as others) [16:02:42] also to note, in docker, the tests run, but don't all pass [16:05:48] ejegg: another not, if you've used docker-pkg before you may have used it to build CI images... The dev-images repo, however, is a completely separate set of configurations only for building development images [16:05:53] *another note [16:07:54] hence the "dev" namespace for the images [16:43:53] fundraising-tech-ops: Fundraising access request for Sheyna Daniels Major Gifts - https://phabricator.wikimedia.org/T264051 (Dwisehaupt) [16:44:32] fundraising-tech-ops: Fundraising access request for Sheyna Daniels Major Gifts - https://phabricator.wikimedia.org/T264051 (Dwisehaupt) Open→Resolved Verified access is good via logs. Closing. [16:45:21] Fundraising-Backlog, fundraising-tech-ops: Fundraising access request for Melanie Demos - https://phabricator.wikimedia.org/T264335 (Dwisehaupt) [16:45:45] Fundraising-Backlog, fundraising-tech-ops: Fundraising access request for Melanie Demos - https://phabricator.wikimedia.org/T264335 (Dwisehaupt) Open→Resolved Verified access is good via logs. Closing. [17:23:34] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time - https://phabricator.wikimedia.org/T264461 (jbolorinos-ctr) Yes that's correct @TSkaff, although this issue would only be visible when a window is using half the screen intead of full-screen [19:01:58] (PS1) Jgleeson: Filter out unexpected zip code characters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632540 (https://phabricator.wikimedia.org/T262232) [19:03:35] Fundraising-Backlog: Too much whitespace between form and error messages [Adyen iframe] - https://phabricator.wikimedia.org/T264785 (jbolorinos-ctr) [19:05:39] (PS2) Jgleeson: Filter out unexpected zip code characters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632540 (https://phabricator.wikimedia.org/T262232) [19:14:09] hmmm I just checked out john's adyen iframework error display ticket and it does look funky. i guess we'll have to tweak the css a little on that [19:15:48] adyen skins, such wow [20:04:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, Patch-For-Review: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (Eileenmcnaughton) @RLewis we chatted about this on our fr-tech meeting - there... [20:20:54] eileen: oh hey, if we do want to fix we can just use math on the columns that we have in the db [20:21:16] rate = (total_amount + fee) / original_amount [20:21:27] yeah I kinda looked - but I wasn't sure they were consistent in their wrongness [20:21:56] hrm? so we WERE converting fees previously? [20:22:15] or they gave us fees in USD in some spreadsheets? [20:22:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, JavaScript: Make it easier to identify client side errors from CentralNotice banners in logs - https://phabricator.wikimedia.org/T264375 (Pcoombe) [20:22:49] ejegg: wannna jump on https://meet.google.com/zjg-azmw-wvd?authuser=0 [20:23:05] (talking with mepps about the same thing) [20:23:06] sure! [20:28:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Operations, Traffic, and 2 others: Special:HideBanners is not really cacheable - https://phabricator.wikimedia.org/T256447 (Tgr) [20:31:41] Fundraising-Backlog, Wikimedia-Fundraising-Banners, JavaScript, Wikimedia-production-error: Uncaught TypeError: Cannot read property 'getItem' of null - https://phabricator.wikimedia.org/T264366 (Pcoombe) Open→Resolved a:Pcoombe I updated our banners which do use this to add some feat... [20:34:30] (CR) Eileen: [C: +2] Remove packages/DB.php dependency from install script [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/632496 (owner: Mepps) [20:37:04] (PS13) Eileen: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) [20:43:21] (CR) Mepps: [C: +2] "Tested on staging with eileen" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631556 (owner: Cstone) [20:50:18] (CR) Mepps: [V: +2] Remove packages/DB.php dependency from install script [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/632496 (owner: Mepps) [20:50:38] ah thanks mepps I was just testing the endowment thank you stuff [20:53:23] (CR) Eileen: [C: +2] Insert paypal recur records on first payments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631558 (https://phabricator.wikimedia.org/T248420) (owner: Ejegg) [20:56:41] (CR) Eileen: [C: +2] Remove subsidiaries, rename 2 employer fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/623432 (https://phabricator.wikimedia.org/T260935) (owner: Ejegg) [20:57:29] (Merged) jenkins-bot: Remove subsidiaries, rename 2 employer fields [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/623432 (https://phabricator.wikimedia.org/T260935) (owner: Ejegg) [21:01:27] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Review activity related queries in contribution processing - https://phabricator.wikimedia.org/T262884 (Eileenmcnaughton) I deployed one fix b... [21:07:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, FR-Email, Patch-For-Review: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (Ejegg) Hi @MNoorWMF - So a lot of those 'bad links' are actually working.... [21:13:03] (Merged) jenkins-bot: Update endowment thank you text. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631556 (owner: Cstone) [21:13:05] (Merged) jenkins-bot: Insert paypal recur records on first payments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631558 (https://phabricator.wikimedia.org/T248420) (owner: Ejegg) [21:23:41] thanks mepps! [21:48:50] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/632577 [21:49:22] (CR) Ejegg: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/632577 (owner: Ejegg) [21:49:58] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/632577 (owner: Ejegg) [21:50:43] eileen: I'm about to deploy "Remove temporary extra-primary delete" in the silverpop export [21:50:55] anything to watch out for? [21:56:36] no [21:56:41] seems straight forward [23:06:33] dwisehaupt: did are there any changes around 7 Aug not on https://wikitech.wikimedia.org/wiki/Server_Admin_Log#2020-08-07 [23:06:47] - https://frmon.frdev.wikimedia.org/d/Pq1YNMviz/fundraising-overview?viewPanel=22&orgId=1&from=now-6M&to=now&refresh=1m slows about thenn [23:06:59] but we can't trace back to any changes on there [23:07:18] looking [23:07:40] we are on https://meet.google.com/pau-rggj-byc?authuser=0 in tech talk [23:28:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate impact of buster upgrade on queue processing - https://phabricator.wikimedia.org/T264819 (Eileenmcnaughton) [23:34:45] Wikimedia-Fundraising: QA of Adyen iframe update - https://phabricator.wikimedia.org/T264820 (jbolorinos-ctr) [23:35:52] i should really look at the puppet -> grafana annotation thing i was thinking of a few weeks ago. [23:36:27] that could help with some things like this. well, and actually logging things to the admin log too. [23:37:10] anyway. i have parent teacher conferences in 5 mins. gotta shuffle on over to those for a little.