[00:31:12] (PS14) Ejegg: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [00:31:26] (CR) Ejegg: [C: +2] Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [00:31:45] thanks ejegg|away [00:31:52] yw :) [00:54:48] (Merged) jenkins-bot: Fix benevity import to currency convert fee amount [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/631314 (https://phabricator.wikimedia.org/T263744) (owner: Eileen) [02:23:54] Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Review activity related queries in contribution processing - https://phabricator.wikimedia.org/T262884 (Eileenmcnaughton) - the remaining ones... [02:30:21] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/632596 [02:30:47] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/632596 (owner: Eileen) [02:37:36] !log civicrm revision changed from a30da7f92a to 39b4f954ed, config revision is 0ca9a3a055 [02:37:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:38:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (Eileenmcnaughton) @rlewis - you should be able to import now - per above we are thinking to skip the... [03:43:25] (PS1) Eileen: Update shoreditch theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632600 (https://phabricator.wikimedia.org/T264124) [06:23:52] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 6 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[php7.0],Package[php7.0-common],Package[php7.0-cgi],Package[php7.0-cli] [06:28:46] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Puppet has 7 failures. Last run 11 minutes ago with 7 failures. Failed resources (up to 3 shown): Package[php7.0],Package[php7.0-common],Package[php7.0-cgi],Package[php7.0-cli] [06:33:52] RECOVERY - check_puppetrun on payments1004 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [15:11:13] (CR) Ejegg: [C: +2] Filter out unexpected zip code characters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632540 (https://phabricator.wikimedia.org/T262232) (owner: Jgleeson) [15:19:47] (Merged) jenkins-bot: Filter out unexpected zip code characters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632540 (https://phabricator.wikimedia.org/T262232) (owner: Jgleeson) [15:59:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, FR-Email: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (Ejegg) We just deployed the column change today, so the export tomorrow morning will have the '... [16:00:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, FR-Email: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (Ejegg) I'll keep looking at why we might have completely blank rows. [16:17:27] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/632754 [16:17:59] fr-tech anyone want me to hold off deploying any of the patches in that release? ^^^ [16:20:03] jgleeson: I think the first 4 there are already deployed [16:20:19] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/631886 [16:20:25] oh intersting [16:20:35] need to pull deployment locally? [16:20:38] I must have forgot to pull on deployment [16:20:43] likely! [16:21:24] (Abandoned) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/632754 (owner: Jgleeson) [16:22:27] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/632755 [16:22:50] yup, everything else has already gone out! [16:23:22] (CR) Jgleeson: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/632755 (owner: Jgleeson) [16:25:17] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, and 3 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (jgleeson) a:jgleeson [16:25:45] Fundraising-Backlog, fundraising sprint Theme songs for programming languages: new endowment TY email - https://phabricator.wikimedia.org/T263877 (Cstone) This has been deployed [16:36:01] (CR) Jgleeson: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/632755 (owner: Jgleeson) [16:39:41] !log updated civicrm from 39b4f954ed to b86a15a430 [16:39:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:42:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Citibank International import - https://phabricator.wikimedia.org/T261795 (LeanneS) Hi, I just want to see where we are with the import changes. I just received the September donation report for import. Let me know if that would be helpful to... [16:50:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Citibank International import - https://phabricator.wikimedia.org/T261795 (DStrine) Hey sorry. We didn't get this in last sprint. We will try again next week. [17:16:39] PROBLEM - check_puppetrun on payments2002 is CRITICAL: CRITICAL: Puppet has 11 failures. Last run 9 minutes ago with 11 failures. Failed resources (up to 3 shown): File[/etc/rssh.conf],File[/etc/vim/vimrc.local],File[/etc/update-motd.d/99-footer],File[/etc/motd.tail] [17:21:37] RECOVERY - check_puppetrun on payments2002 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [17:56:41] Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Q2-FY2020-21-cleanup-list: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (mepps) @Ejegg is recommending we use the showMonthlyConvert method in gatewayadapter then getResources i... [18:56:18] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint 🐍 is not a valid zipcode, and 3 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (jgleeson) a:jgleeson→None [19:06:40] Fundraising-Backlog, FR-Smashpig: Make cURL debug logging useful again - https://phabricator.wikimedia.org/T264931 (Ejegg) [19:09:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, FR-Email: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (MNoorWMF) Thank you so much Elliott! I'll take a look at the new dB tomorrow after the import... [19:24:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (DStrine) @Rlewis and @EMartin I don't know how many others might need to be looped in. But @Eileenmcn... [19:26:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (Eileenmcnaughton) To clarify - the fees not the donation amount would be off (in non-converted curren... [19:31:29] Wikimedia-Fundraising-Banners: QA for en6C pre-test on October 8 - https://phabricator.wikimedia.org/T264933 (spatton) [19:33:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages, FR-Email: Matching Gifts database data cleanup - https://phabricator.wikimedia.org/T260935 (Ejegg) Hmm, looks like the blanks are actually stored in the DB rather than being introduced in... [19:35:32] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T264934 (spatton) [19:36:45] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T264935 (spatton) [19:39:15] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T264936 (spatton) [19:41:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising sprint Theme songs for programming languages: Error message when importing a Benevity file - https://phabricator.wikimedia.org/T263744 (EMartin) Not material from my perspective. [19:41:39] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: desktop small batch - https://phabricator.wikimedia.org/T264937 (spatton) [19:43:08] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T264935 (spatton) [19:45:21] Wikimedia-Fundraising-Banners: QA for en6C pre-test on October 8 - https://phabricator.wikimedia.org/T264933 (spatton) [19:52:27] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [19:57:27] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [19:57:44] Wikimedia-Fundraising-Banners: QA for en6C pre-test on October 8 - https://phabricator.wikimedia.org/T264933 (jbolorinos-ctr) Thanks Sam! I'll get started on these right away and let you know if anything comes up. [20:00:11] ACKNOWLEDGEMENT - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] Jeff_Green puppet/apt are unhappy b/c of locked mariadb package [20:03:18] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T264934 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z2932f29d5ebdb3260cb - Reordered 2nd paragraph varian... [20:03:32] (PS2) Eileen: Update shoreditch theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632600 (https://phabricator.wikimedia.org/T264124) [20:06:13] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T264934 (jbolorinos-ctr) Hey @spatton, I noticed the sequence code is still included in these, and since that was causing issues reported in T264366 we should probably remove that code. [20:07:01] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Adyen visa debit users see error coming back from card processor - https://phabricator.wikimedia.org/T264941 (Ejegg) [20:08:55] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: mobile large batch - https://phabricator.wikimedia.org/T264934 (jbolorinos-ctr) @Pcoombe is it necessary to remove the 'seen count' code from all banners on CN? Or just the FR campaign banners? [20:19:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Omit useless entries when syncing matching gifts data - https://phabricator.wikimedia.org/T264944 (Ejegg) [20:21:51] (PS3) Ejegg: Update shoreditch theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632600 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [20:22:24] (CR) Ejegg: [C: +2] Update shoreditch theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632600 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [20:25:03] (PS1) Mepps: Create $wgMonthlyConvertCountries, addVariant method for ConfiguratonReader Allows turning on and monthlyConvert modal by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/632793 (https://phabricator.wikimedia.org/T250918) [20:27:13] (CR) jerkins-bot: [V: -1] Create $wgMonthlyConvertCountries, addVariant method for ConfiguratonReader Allows turning on and monthlyConvert modal by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/632793 (https://phabricator.wikimedia.org/T250918) (owner: Mepps) [20:29:33] (PS2) Mepps: Create $wgMonthlyConvertCountries, addVariant method for ConfiguratonReader Allows turning on and monthlyConvert modal by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/632793 (https://phabricator.wikimedia.org/T250918) [20:31:08] hey ejegg--i returned slightly to my original approach but i'm curious what you think ^^ [20:31:23] i haven't fully tested it locally because i have a js issue.. [20:34:45] now i'm wondering about testing--it looks like we don't have anything for showMonthlyConvert right now [20:38:42] (PS4) Ejegg: Add css changes for adyen redirect skin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623853 (https://phabricator.wikimedia.org/T261355) (owner: Mepps) [20:39:10] (CR) Ejegg: [C: +2] "Thanks for checking this in, mepps!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623853 (https://phabricator.wikimedia.org/T261355) (owner: Mepps) [20:41:33] hi mepps, I'll take a look [20:41:41] (Merged) jenkins-bot: Add css changes for adyen redirect skin [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/623853 (https://phabricator.wikimedia.org/T261355) (owner: Mepps) [20:42:28] (Merged) jenkins-bot: Update shoreditch theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632600 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [20:42:40] thanks ejegg! [20:44:34] mepps it feels like a weird side-effect to be messing with $this->config inside showMonthlyConvert() [20:45:10] so if there was a different variant that overrode some config bits [20:45:42] those config bits (e.g. different payment submethods) would be in effect up till the point where something calls showMonthlyConvert() [20:46:12] hmm i suppose i'm making the assumption here that it won't--given that we know what's in the variant added there [20:46:15] and from then on they get clobbered for the monthlyConvert variant [20:46:41] since $config retains it's original properties, just gets added to with the variant [20:47:00] obviously this could be abused elsewhere in code, but in this it's only adding more ui modules [20:48:00] so it wouldn't actually lose anything ejegg, just get the new scripts, from my reading [20:48:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (DStrine) Resolved→Open [20:48:22] hmm, but the UI modules are still completely replaced by the ones from monthlyConvert [20:48:31] hmm that's a good point [20:48:32] erg [20:48:35] okay.. [20:49:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (DStrine) Reopening this as @KHaggard found 5 contacts in acoustic that have not been deleted properly [20:51:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (MBeat33) [20:59:26] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: mobile small batch - https://phabricator.wikimedia.org/T264935 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z18ea653d3bea61f6e3c - Dont ignore variant: https://app... [21:03:44] dstrine: wmf meeting now? [21:03:48] ejegg: ? [21:04:26] oops [21:04:28] brt [21:16:34] Wikimedia-Fundraising-Banners: 2020-10-08 en6C pre-test: desktop large batch - https://phabricator.wikimedia.org/T264936 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z92120f744a870f40d83 - Never charge a sbuscription v... [22:45:28] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Banner code faulty when no disk space available - https://phabricator.wikimedia.org/T264952 (Jdlrobson) [22:51:31] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [22:55:03] Fundraising-Backlog, FR-Ingenico, Recurring-Donations, fr-donorservices: Oct. 2020 Ingenico recurrings failing to attempt new donations - https://phabricator.wikimedia.org/T264954 (MBeat33) [22:56:27] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 3 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [23:02:46] Fundraising-Backlog, FR-Ingenico, Recurring-Donations, fr-donorservices: Oct. 2020 Ingenico recurrings failing to attempt new donations - https://phabricator.wikimedia.org/T264954 (MBeat33) [23:07:25] Fundraising-Backlog, fundraising-tech-ops: SSH and Yubikey setup for CDenes - https://phabricator.wikimedia.org/T246390 (Dwisehaupt) Stalled→Open [23:45:50] Fundraising-Backlog, FR-Ingenico, Recurring-Donations, fr-donorservices: Oct. 2020 Ingenico recurrings failing to attempt new donations - https://phabricator.wikimedia.org/T264954 (Ejegg) We see 742 successful transactions in a recent run, so they're not all failing. I do see some errors in that... [23:54:39] Fundraising-Backlog, FR-Ingenico, Recurring-Donations, fr-donorservices: Oct. 2020 Ingenico recurrings failing to attempt new donations - https://phabricator.wikimedia.org/T264954 (MBeat33) Thanks for digging into this, @Ejegg Is there anything we can do to restart the affected donations, or shou... [23:56:14] Fundraising-Backlog, FR-Ingenico, Recurring-Donations, fr-donorservices: Oct. 2020 Ingenico recurrings failing to attempt new donations - https://phabricator.wikimedia.org/T264954 (Ejegg) We should be able to restart them - just looking at the first donor you list I see the contribution_recur row...