[00:12:37] (CR) Eileen: [C: +2] "Yep - ran through fine locally!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/634026 (https://phabricator.wikimedia.org/T261705) (owner: Mepps) [00:13:35] (Merged) jenkins-bot: Add opt out file for suppression list upload [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/634026 (https://phabricator.wikimedia.org/T261705) (owner: Mepps) [00:15:27] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/634131 [00:15:39] (CR) Eileen: [C: +2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/634131 (owner: Eileen) [00:16:02] mepps: are you still there? I merged your patch to deploy - but not sure if it needs co-ordination [00:16:10] (Merged) jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/634131 (owner: Eileen) [00:29:55] (PS1) Eileen: Include recurring_failed_message in install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634132 [00:33:45] hi eileen, i'm sort of here--next step after deployment would just be telling katie the file name [00:33:59] ok - I should just deploy then? [00:34:32] i think that's fine eileen--i would just ping khaggard and brian on the phab task and tell them when the file will be up and the name [00:34:54] cool - I expect it has missed today but will check [00:35:22] thanks for the quick review and deploy eileen! [00:35:55] no worries - I channeling my inner David & working right to left [00:36:21] !log tools revision changed from d4e08c52de to a2a91d6c6a [00:36:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:10:18] (CR) Cstone: [C: -1] "I had to use $wgIngenicoGatewayMonthlyConvertCountries = ['US'] to get it to accept the global. I don't understand 100% where Ingenico was" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/632793 (https://phabricator.wikimedia.org/T250918) (owner: Mepps) [01:17:47] (PS2) Eileen: Include recurring_failed_message in install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634132 [01:17:49] (PS1) Eileen: Add api to load a new template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634133 [01:22:44] (PS1) Eileen: Improve defining of supported languages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634134 [01:24:09] (PS2) Eileen: IDE formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633849 (https://phabricator.wikimedia.org/T261795) [01:47:41] (PS2) Eileen: Improve defining of supported languages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634134 [01:47:43] (PS1) Eileen: Add api to load a new template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634135 [02:18:26] (PS3) Eileen: New file change for citibank [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633851 (https://phabricator.wikimedia.org/T261795) [02:18:39] (PS2) Eileen: Possible fix for endowment engage import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633862 [02:21:00] (CR) Ejegg: [C: +1] "Oh hey, that's an elegant solution! +1 for now, till we get a sample file." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633862 (owner: Eileen) [02:25:28] (CR) jerkins-bot: [V: -1] Possible fix for endowment engage import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633862 (owner: Eileen) [02:31:57] (PS1) Eileen: Update failure notification form to support testing & approval of qa messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634139 [02:47:16] (PS2) Eileen: Update failure notification form to support testing & approval of qa messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634139 [03:12:10] (PS3) Eileen: Add nl,it,nb,pl,pt,ro,es translations for failed recurring messages. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [03:12:12] (PS1) Eileen: Fix funny characters in the PO box number [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634141 (https://phabricator.wikimedia.org/T260703) [03:12:14] (PS1) Eileen: Add WMF address to Swedish recurring fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634142 (https://phabricator.wikimedia.org/T260703) [03:17:07] (PS4) Eileen: Add nl,it,nb,pl,pt,ro,es translations for failed recurring messages. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [03:18:15] (CR) Eileen: "There were some weird characters in the PO box - I've fixed but you have to view through an editor to see it..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [03:18:45] (CR) Eileen: [C: +1] "It seems OK - but working on sending copy to Camille & maybe DS for checking" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [03:19:13] (Abandoned) Eileen: Fix funny characters in the PO box number [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634141 (https://phabricator.wikimedia.org/T260703) (owner: Eileen) [03:19:22] (PS2) Eileen: Add WMF address to Swedish recurring fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634142 (https://phabricator.wikimedia.org/T260703) [13:47:34] (CR) Mepps: "All the templates look good but we also need the code in wmf_civicrm.install to add these to the db." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [17:07:30] eileen: locally when I try to load the deduper I get a ServiceNotFoundException: "You have requested a non-existent service "afform_scanner" [17:07:44] trying drush cc all doesn't seem to fix it [17:07:52] any suggestions? [17:08:42] (this is after checking out the last patch in your upgrade chain and running the civi upgrade) [17:09:07] ah, lemme try extension upgrade as well [17:09:33] oh hey, extension upgrade seemed to fix it! [17:09:36] sorry for the bother [17:21:55] k, deduper and contact layout editor seem to be working well [17:28:50] smashpig charge job seems fine [17:29:06] also normal contact editing [17:30:52] was able to cancel recurring donation locally [17:31:20] well, I'm pretty satisfied [17:31:39] fr-tech does anyone else want to do local review of eileen's civi upgrade patches before I +2 them? [17:31:50] ejegg: sorry to jump in! I'm gonna start switching my local over to 1.35 again, I figure that might take a little while as I need to upgrade stuff again having revert back since last time [17:32:07] ok, cool jgleeson [17:32:53] Since prod is now completely off 1.31, you shouldn't need to switch back [17:33:19] exciting [17:38:50] no objections to merging, then, fr-tech? [17:40:22] (CR) Ejegg: [C: +2] Stock CiviCRM 5.31rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633580 (owner: Eileen) [17:40:42] (CR) Ejegg: [C: +2] re-add remaining wmf hacks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633590 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [17:40:58] none here ejegg [17:43:02] (CR) Ejegg: [C: +2] "Nice!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633591 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [17:47:53] (Merged) jenkins-bot: Stock CiviCRM 5.31rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633580 (owner: Eileen) [17:48:39] (Merged) jenkins-bot: re-add remaining wmf hacks. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633590 (https://phabricator.wikimedia.org/T261359) (owner: Eileen) [17:50:16] (Merged) jenkins-bot: dev/core#2079 Eliminate unused query on CRM_Core_BAO_CustomQuery::_construct [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633591 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [18:06:07] (CR) Ejegg: [C: +2] "Looks good!" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633592 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [18:07:19] (CR) Ejegg: [C: +2] "Nice find, good generic fix" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633597 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [18:07:57] ejegg: I'm hitting issues installing payments 1.35 [18:07:59] Problem 1 [18:08:01] - The requested package zordius/lightncandy 0.23 is satisfiable by zordius/lightncandy[v0.23] but these conflict with your requirements or minimum-stability. [18:08:03] did you run into that? [18:09:20] actually should I also be checking out DonationInterface 1.35? I was guessing the submodule pointer was updated [18:09:26] lemme try doing that [18:10:43] looks like I also needed to pull down updates [18:10:50] lemme try again after doing so [18:11:11] ohh interesting [18:11:13] - This package requires php >=7.3.19 but your PHP version (7.2.26) does not satisfy that requirement. [18:11:23] let's upgrade then [18:12:04] sorry, gotta grab some lunch first [18:12:53] but yeah, please pull down the fundraising/REL1_35 branch of both core mw and of DonationInterface [18:13:23] on it, thanks! [18:13:30] guessing I might also need to rebuild xdebug [18:13:38] against 7.3 [18:15:16] (Merged) jenkins-bot: dev/core#2039 Fix merge code so that deleted contacts are not left without a primary address [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633592 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [18:37:32] (CR) jerkins-bot: [V: -1] Make upgrade script time sane [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633597 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [18:58:02] (CR) Ejegg: [C: +2] "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633597 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [19:17:01] (Merged) jenkins-bot: Make upgrade script time sane [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/633597 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [19:41:48] (CR) Eileen: [C: +1] "mepps - I added a way to do that through the UI - sorry notes all on the phab & I emailed just Christine & Cdenes because I forwarded 8 em" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [19:42:44] thanks for merging civi upgrade ejegg [19:43:03] can someone merge this? leannes has tested https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/633851 [19:44:18] (CR) Eileen: [C: +2] "I'm going to +2 this since mepps has also checked the stuff & this can stand by itself. We can use the upgrade script to deploy or the for" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [19:45:14] MBeat: I forwarded copies of the failing mail in different languages to cdenes but I wondered if it should have been ds? [19:49:04] (CR) Cstone: [C: +2] New file change for citibank [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633851 (https://phabricator.wikimedia.org/T261795) (owner: Eileen) [19:49:21] thanks eileen for forwarding all those [19:50:43] fr-tech I've got a workaround for that adyen visa-debit not found [19:50:56] though I'm still confused as to how we actually get that value in there [19:51:44] the only decoding I see from the unstaging helper isn't passing any payment method 'variant' (<- adyen [19:52:01] s term for subbrands like visa electron, visa debit) [19:52:05] (Merged) jenkins-bot: Add nl,it,nb,pl,pt,ro,es translations for failed recurring messages. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/632365 (owner: Cstone) [19:52:07] back to the ReferenceData call [19:52:09] cstone: cool - did you look at what I did on staging to generate? It was probably overkill but I didn't want to have to rely on the copy to be sure & it does mean we can deploy & DS can check & enable if we wannt [19:52:57] mepps was sweden supposed to have a PO box? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/634142 [19:53:00] ty eileen are you concerned about the quality of the translation itself, or on the formatting of the emails? [19:53:08] if the latter we’re happy to review [19:53:50] the translations should be ok, they were texte ws were sending manually to donors and the translations were done by Transperfect, iirc [19:53:59] MBeat: so more at the level of 'did anything happen in the process' [19:54:06] *texts we were sending [19:54:30] if you’d like forward the copies to me and I can take a look [19:54:50] I've actually made it so you can view the unapproved ones on staging at the moment [19:56:01] if you try bob smith (not his real name ) civicrm/contact/view?reset=1&cid=18083834 [19:56:18] (Merged) jenkins-bot: New file change for citibank [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633851 (https://phabricator.wikimedia.org/T261795) (owner: Eileen) [19:56:34] & go to send mail it will show you the 'in QA' version [20:02:29] nice eileen [20:02:57] cstone: I was trying to figure out how to deal with a wall of text [20:08:06] cstone: at the least ie means we can turn them on one by one if we wan [20:54:57] (PS2) Ejegg: Delete test for unused code, fix format test [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634108 [21:18:57] (PS1) Ejegg: Fix method name in Mustache test [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634345 [21:19:14] fr-tech can anyone review ^^^ and the two test fixes that precede it? [21:23:45] i can ejegg and woo for deleting things [21:24:46] (CR) Cstone: [C: +2] Delete test for unused code, fix format test [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634108 (owner: Ejegg) [21:25:34] also JimmySezPleeeeeze hah [21:26:40] (CR) Cstone: [C: +2] Fix autocomplete dependency name [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634052 (owner: Ejegg) [21:27:57] (CR) Cstone: [C: +2] Fix method name in Mustache test [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634345 (owner: Ejegg) [21:29:44] thanks cstone! [21:33:07] (PS1) Ejegg: Delete backwards-compatibility OutputPage shim [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634350 [21:33:19] oh, speaking of deleting things, ^^^ is just a teeny cleanup cstone [21:41:52] (CR) Cstone: [C: +2] Delete backwards-compatibility OutputPage shim [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634350 (owner: Ejegg) [21:42:10] thanks! [21:42:51] np [21:44:23] ok, I'mma update the merge back to master [21:57:51] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Dwisehaupt) [22:02:13] fundraising-tech-ops: Upgrade payments_listener servers to Debian Buster - https://phabricator.wikimedia.org/T265688 (Dwisehaupt) [22:15:17] (PS1) Ejegg: Merge branch 'fundraising/REL1_35' into master [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/634360 [22:16:22] (CR) Ejegg: [V: +2] Fix autocomplete dependency name [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634052 (owner: Ejegg) [22:16:31] (CR) Ejegg: [V: +2] Delete test for unused code, fix format test [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634108 (owner: Ejegg) [22:16:33] (CR) Ejegg: [V: +2] Fix method name in Mustache test [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634345 (owner: Ejegg) [22:16:35] (CR) jerkins-bot: [V: -1] Merge branch 'fundraising/REL1_35' into master [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/634360 (owner: Ejegg) [22:16:37] (CR) Ejegg: [V: +2] Delete backwards-compatibility OutputPage shim [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634350 (owner: Ejegg) [22:16:57] (CR) Ejegg: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/634360 (owner: Ejegg) [22:43:41] (PS1) Ejegg: Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634367 [22:45:32] (CR) Ejegg: [C: +2] Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634367 (owner: Ejegg) [22:45:41] (CR) jerkins-bot: [V: -1] Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634367 (owner: Ejegg) [22:58:16] (CR) Ejegg: [V: +2 C: +2] Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634367 (owner: Ejegg) [22:59:46] (CR) Ejegg: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/634360 (owner: Ejegg) [23:10:41] wat [23:10:43] test failure: [23:10:50] 23:01:50 -'USB 100.59' [23:10:51] 23:01:50 +'USB 100.59' [23:11:03] is one of those a nbsp?? [23:14:07] is that from that test you just changed? [23:42:46] (PS1) Ejegg: Amount test: replace space with non-breaking space [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634379 [23:43:03] cstone: yep! [23:43:10] that should fix it ^^^ [23:43:13] hah okay [23:43:41] (CR) Cstone: [C: +2] Amount test: replace space with non-breaking space [extensions/DonationInterface] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634379 (owner: Ejegg) [23:43:47] that is a confusing CI fail [23:43:52] thanks again! [23:44:01] ok, one more update for the merge [23:45:55] (PS2) Ejegg: Merge branch 'fundraising/REL1_35' into master [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/634360 [23:47:34] (CR) jerkins-bot: [V: -1] Merge branch 'fundraising/REL1_35' into master [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/634360 (owner: Ejegg) [23:50:22] (CR) Ejegg: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/634360 (owner: Ejegg) [23:51:29] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634380 (https://phabricator.wikimedia.org/T264124) [23:52:56] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634380 (https://phabricator.wikimedia.org/T264124) (owner: Eileen) [23:53:13] I'm getting ready to deploy the update [23:53:47] (PS2) Ejegg: Fix usages of deprecated PHPUnit methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) (owner: Ammarpad) [23:54:05] (CR) Ejegg: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) (owner: Ammarpad) [23:55:04] (CR) jerkins-bot: [V: -1] Fix usages of deprecated PHPUnit methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/627977 (https://phabricator.wikimedia.org/T262955) (owner: Ammarpad)