[01:21:19] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Eileenmcnaughton) @Jgreen @Dwisehaupt - I have in my head that we want to use smtp - but I realised I need to... [02:17:31] PROBLEM - check_puppetrun on frdb1003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 51 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [02:22:31] PROBLEM - check_puppetrun on frdb1003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [04:08:48] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Dwisehaupt) Yes, we definitely want to use smtp. That page looks good and we can just list them all and it sho... [07:08:03] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Eileenmcnaughton) @Dwisehaupt - are these the values we would need for config? {F32399898} [13:18:03] Wikimedia-Fundraising-Banners: QA for enUS pre-test on October 21 - https://phabricator.wikimedia.org/T266007 (spatton) [13:20:07] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: desktop large batch - https://phabricator.wikimedia.org/T266008 (spatton) [13:22:08] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: desktop small batch - https://phabricator.wikimedia.org/T266010 (spatton) [13:23:18] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: mobile large batch - https://phabricator.wikimedia.org/T266011 (spatton) [13:24:22] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: mobile small batch - https://phabricator.wikimedia.org/T266012 (spatton) [13:24:57] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: mobile small batch - https://phabricator.wikimedia.org/T266012 (spatton) p:Triage→High [13:24:59] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: mobile large batch - https://phabricator.wikimedia.org/T266011 (spatton) p:Triage→High [13:25:01] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: desktop small batch - https://phabricator.wikimedia.org/T266010 (spatton) p:Triage→High [13:25:03] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: desktop large batch - https://phabricator.wikimedia.org/T266008 (spatton) p:Triage→High [13:27:00] Wikimedia-Fundraising-Banners: QA for enUS pre-test on October 21 - https://phabricator.wikimedia.org/T266007 (spatton) p:Triage→High [13:57:23] Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: endowment donor did not get TY email. - https://phabricator.wikimedia.org/T253257 (RLewis) Just adding to this task, I'm reviewing some of the Endowment contributions coming in, in response to the Endowment Annual Appeal Email 1 send and I've noticed tha... [14:10:26] Wikimedia-Fundraising-Banners: QA for enUS pre-test on October 21 - https://phabricator.wikimedia.org/T266007 (jbolorinos-ctr) Thanks Sam! Getting started on these now, and I'll report any issues found here [14:38:12] Wikimedia-Fundraising-Banners: [CANDIDATE] QA for WYDG variants - https://phabricator.wikimedia.org/T265925 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Dark blue: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z16a353d2bea04408a6f - Camouflaged in the footer: https://app.cr... [15:51:22] Fundraising-Backlog, Wikimedia-Fundraising-Banners, donate.wikimedia.org, fr-donorservices: Investigate Japanese unintended recurring donations - https://phabricator.wikimedia.org/T262361 (jbolorinos-ctr) Hey @TSkaff and @MBeat33, From my understanding those utm keys & tags indicate a sequence o... [16:06:26] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Dwisehaupt) @Eileenmcnaughton Yes. We would just be using SMTP server and SMTP port as we don't require auth o... [16:43:37] well that's an interesting mediawiki error: LogicException from line 409 of mediawiki/includes/cache/MessageCache.php: Process cache for 'en' should be set by now. [16:43:52] trying to load the main page [16:45:51] going to try running rebuildLocalizationCache [16:46:36] ahhh no, i just had some services stopped [16:52:11] (PS2) Ejegg: Add adyen recurring form setting for AU, NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/635025 (https://phabricator.wikimedia.org/T265752) (owner: Mepps) [16:52:39] (CR) Ejegg: [C: +2] Add adyen recurring form setting for AU, NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/635025 (https://phabricator.wikimedia.org/T265752) (owner: Mepps) [16:53:57] thanks ejegg! shall we get it deployed? [16:54:04] i need to find my keys... [16:56:24] Sure thing! [16:56:59] shoot, do we need to get the FundraisingEmailUnsubscribe extension merge back to master fixed first? [16:57:29] looks like that's making tests fail on our mediawiki branch: https://integration.wikimedia.org/ci/job/quibble-donationinterface-REL1_35-php73-docker/22/console [17:01:59] ahh [17:02:30] i guess we can't automerge on the mediawiki repo, huh? urgh [17:03:19] looks like a composer update error? [17:06:03] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: desktop large batch - https://phabricator.wikimedia.org/T266008 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zd20cfe847423e98d788 - Adyen iframe variant: [17:07:04] (Merged) jenkins-bot: Add adyen recurring form setting for AU, NZ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/635025 (https://phabricator.wikimedia.org/T265752) (owner: Mepps) [17:09:20] ejegg i'm seeing a lot of commits on master that aren't on deployment, does that sound right to you? [17:09:40] yeah [17:09:54] we have the fundraising/REL1_35 branch deployed now [17:10:11] and we've just merged that branch into master [17:11:06] but I think we DO need to get FundraisingEmailUnsubscribe sorted out [17:13:24] darn ejegg [17:15:47] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/635322 [17:16:18] (PS2) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/635322 [17:27:00] hey mepps trying to get this global to behave do they get cached somewhere that I could clear it out? its still doing it on the latest patch [17:31:54] hi fr-tech! [17:32:10] howdy jgleeson [17:32:38] how's it goin? [17:32:40] jgleeson: hi! how are you feeling? [17:32:49] hi jgleeson AndyRussG [17:32:54] that's so weird cstone [17:33:01] cstone :) [17:33:14] hey cstone AndyRussG [17:33:19] i looked at the code and it seems like it's supposed to look for a gateway level variable then a globally available variable [17:33:25] mepps: do you want to do a quick screenshare to make sure im not doing something completely wrong? hah [17:34:02] sure cstone but i was about to run out for groceries--could we do it at 3? sadly i couldn't test this code better so i'm wondering if i missed something too [17:34:14] sure that works [17:34:18] sorry that was 3 ET :) [17:34:23] yeah i figured hah [17:34:38] AndyRussG: I'm ok thanks Andy just had some paracetamol which seems to do the trick so far [17:40:58] jgleeson: cool! good to hear and good see u here, do take care eh!! :) [17:41:04] mepps so releng suggests adding a setting to extension.json that will make mediawiki load autoloaders from extension-specific vendor directories [17:41:35] maybe not the most optimal solution, but it'll get us past this for now [17:43:13] oh wait, we DO have that set for FundraisingEmailUnsubscribe: https://phabricator.wikimedia.org/diffusion/EFEU/browse/master/extension.json$116 [17:45:39] thanks! [17:55:26] bah, that extension is on its way out anyway. I'mma just tack those autoloader include lines on the top of the test files [17:56:50] (PS1) Ejegg: Tests: autoload from extension-specific composer dir [extensions/FundraisingEmailUnsubscribe] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635348 [17:59:22] (CR) Ejegg: [V: +2 C: +2] Tests: autoload from extension-specific composer dir [extensions/FundraisingEmailUnsubscribe] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635348 (owner: Ejegg) [18:00:45] (PS2) Ejegg: Merge branch 'fundraising/REL1_35' into master [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/634040 [18:03:47] (CR) jerkins-bot: [V: -1] Merge branch 'fundraising/REL1_35' into master [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/634040 (owner: Ejegg) [18:04:38] (PS1) Ejegg: Fix include_once for test autoloading [extensions/FundraisingEmailUnsubscribe] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635351 [18:05:00] (CR) Ejegg: [V: +2 C: +2] Fix include_once for test autoloading [extensions/FundraisingEmailUnsubscribe] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635351 (owner: Ejegg) [18:06:12] (PS3) Ejegg: Merge branch 'fundraising/REL1_35' into master [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/634040 [18:09:19] (CR) jerkins-bot: [V: -1] Merge branch 'fundraising/REL1_35' into master [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/634040 (owner: Ejegg) [18:30:48] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Q2-FY2020-21-cleanup-list, Patch-For-Review: Make easy on/off switch for Monthly covert - https://phabricator.wikimedia.org/T250918 (DStrine) [18:36:29] fundraising-tech-ops: Upgrade monitoring (frmon) servers to buster - https://phabricator.wikimedia.org/T266057 (Dwisehaupt) [19:17:28] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fundraising sprint Theme songs for programming languages, and 2 others: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (AndyRussG) [19:19:47] (CR) Ejegg: [V: +2 C: +2] Merge branch 'fundraising/REL1_35' into master [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/634040 (owner: Ejegg) [19:20:13] ok, that's force-submitted for now [19:20:20] let's see if that lets the mw tests pass [19:20:34] (CR) Ejegg: "recheck" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634577 (owner: Ejegg) [19:20:38] ejegg: you still fighting that battle? [19:20:53] jgleeson: yeah, there are still some tests that don't work on FundraisingEmailUnsubscribe [19:21:30] and because I couldn't merge the 1.35 updates to master on that extension, the tests for our branch of core were failing [19:21:46] (the tests for our branch of core use the master branch of FEU) [19:24:20] ah [19:26:02] luckily we don't really develop on FEU any more [19:26:12] would be nice to get it completely gone [19:26:46] but that will need both a bit more coding on the unsubscribe page under DI and some kind of recdirect [19:38:06] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fundraising sprint Theme songs for programming languages, and 2 others: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (AndyRussG) Just completed the logging se... [20:02:14] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Jgreen) @Eileenmcnaughton I did some testing and the phpmailer functionality seems reasonable. I have a couple... [20:04:38] (CR) Mepps: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/635322 (owner: Mepps) [20:04:42] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Citibank International import - https://phabricator.wikimedia.org/T261795 (LeanneS) @Eileenmcnaughton The import worked on production! Thanks for updating. [20:05:23] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Changes to Citibank International import - https://phabricator.wikimedia.org/T261795 (Eileenmcnaughton) Open→Resolved Cool - thanks for confirming [20:16:44] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/635322 (owner: Mepps) [20:30:42] mepps: did you still want to catch up? [20:31:01] eileen i'm actually a little exhausted and might rest until kids get home [20:31:10] ok sure [20:31:35] maybe tomorrow after civi fornightly eileen? [20:31:49] sure [20:32:04] cstone: did the language failure messages get enabled? I only deployed the templates [20:58:23] hey ejegg--the adyen recurring fix along with others is merged into DI deployment [20:58:38] i'm about to jump off if you or somone else from fr-tech wants to take the deployment from there [21:14:46] (CR) jerkins-bot: [V: -1] build: Updating dependencies [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/635388 (owner: Libraryupgrader) [21:24:22] (PS3) Jgleeson: Add stream_filter to curl debug log stream. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/634059 (https://phabricator.wikimedia.org/T264931) [21:24:52] (CR) jerkins-bot: [V: -1] Add stream_filter to curl debug log stream. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/634059 (https://phabricator.wikimedia.org/T264931) (owner: Jgleeson) [21:26:03] (CR) Jgleeson: "Thanks for the review!!! fixed in the next PS" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/634059 (https://phabricator.wikimedia.org/T264931) (owner: Jgleeson) [21:31:44] ejegg: I'm getting some failures in ci and local since the latest composer update to smashpig [21:31:55] 22:24:48 PHP Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /src/vendor/squizlabs/php_codesniffer/src/Files/File.php on line 1279 in /src/vendor/squizlabs/php_codesniffer/src/Runner.php:557 [21:33:22] weird, that composer update doesn't touch php_codesniffer [21:34:14] jgleeson: oh hmm, I think that has to do with a new php version? [21:34:22] we should fix it in any case [21:34:41] sure [21:34:52] I'll dig into it first thing [21:36:24] I think it's fixed in a later version of codesniffer [21:36:35] so probably updating our dev dependencies is all we need to do [21:38:25] I'll try it before I jump off [21:49:32] yeah that fixed it ejegg, going to the latest version although running `composer fix` updated a bunch of files so I'll push them as a separate commit first [21:49:46] and then the curl log patch [21:49:55] oh ok, cool [21:51:36] (PS1) Jgleeson: Update mediawiki-codesniffer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/635393 [21:52:06] (CR) jerkins-bot: [V: -1] Update mediawiki-codesniffer [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/635393 (owner: Jgleeson) [21:52:32] (PS4) Jgleeson: Add stream_filter to curl debug log stream. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/634059 (https://phabricator.wikimedia.org/T264931) [21:53:00] (CR) jerkins-bot: [V: -1] Add stream_filter to curl debug log stream. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/634059 (https://phabricator.wikimedia.org/T264931) (owner: Jgleeson) [22:09:56] (CR) Cstone: [C: +2] Include recurring_failed_message in install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634132 (owner: Eileen) [22:10:06] !log frmon2001 upgraded to buster with grafana 7.2.1 [22:10:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:12:40] (CR) Cstone: [C: +2] Typo fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633844 (owner: Eileen) [22:13:22] (CR) Cstone: [C: +2] Remove file committed in error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634077 (owner: Eileen) [22:15:50] ok. frmon2001 is looking good. i'll let it bake a few days before doing frmon1001. there appears to be some slowness pulling graph periods initailly, but that could be for a host of reasons. [22:24:28] (PS1) Eileen: Start the process of moving our mailer class to Omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635396 (https://phabricator.wikimedia.org/T264663) [22:27:44] (Merged) jenkins-bot: Include recurring_failed_message in install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634132 (owner: Eileen) [22:27:46] (Merged) jenkins-bot: Typo fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/633844 (owner: Eileen) [22:31:57] (Merged) jenkins-bot: Remove file committed in error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634077 (owner: Eileen) [22:39:04] (PS1) Eileen: Add 2020 to dash [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/635397 [22:56:36] fundraising-tech-ops: Upgrade monitoring (frmon) servers to buster - https://phabricator.wikimedia.org/T266057 (Dwisehaupt) p:Triage→Medium a:Dwisehaupt frmon2001 has been upgraded and looking ok. Some slowness on auto refresh of grafana panels to start. They would load fresh data or data from a...