[02:24:24] (PS1) Eileen: Minor code re-ordering - makes it possible to define email in one hit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635408 (https://phabricator.wikimedia.org/T264663) [02:24:26] (PS1) Eileen: Move send function into the factory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635409 (https://phabricator.wikimedia.org/T264663) [02:24:28] (PS1) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [02:31:34] (CR) jerkins-bot: [V: -1] Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [02:31:49] (PS2) Eileen: Move send function into the factory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635409 (https://phabricator.wikimedia.org/T264663) [02:32:48] (PS2) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [02:44:13] (CR) jerkins-bot: [V: -1] Move send function into the factory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635409 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [03:01:25] (PS3) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [03:06:57] (PS4) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [03:16:01] (PS5) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [03:20:42] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Eileenmcnaughton) Thanks @jgreen - very helpful. As a bonus I can see whether it went vi... [03:22:09] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: mobile small batch - https://phabricator.wikimedia.org/T266012 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z727a8959f685042e0fa - Adyen iframe variant: https://a... [03:25:50] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: desktop small batch - https://phabricator.wikimedia.org/T266010 (jbolorinos-ctr) Screenshot Test Results - Desktop: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z39b483a97606e9e25c6 - Adyen iframe variant: https://... [03:28:30] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Eileenmcnaughton) I've loaded the series of patches ending in https://gerrit.wikimedia.o... [03:28:37] Wikimedia-Fundraising-Banners: 2020-10-21 enUS pre-test: mobile large batch - https://phabricator.wikimedia.org/T266011 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zb301163db46169eb764 - Adyen iframe variant: https://a... [06:16:06] Fundraising-Backlog: Make payments phpunit tests pass under Docker - https://phabricator.wikimedia.org/T266088 (AndyRussG) [06:21:28] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: Add SmashPig config for payments wiki on Docker - https://phabricator.wikimedia.org/T266089 (AndyRussG) [06:22:10] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: Make payments phpunit tests pass under Docker - https://phabricator.wikimedia.org/T266088 (AndyRussG) [06:23:32] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: Make payments phpunit tests pass under Docker - https://phabricator.wikimedia.org/T266088 (AndyRussG) [06:26:01] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: XDebug on payments on Docker - https://phabricator.wikimedia.org/T266090 (AndyRussG) [06:33:55] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: Add license to fundraising-dev Docker repo - https://phabricator.wikimedia.org/T266091 (AndyRussG) [06:37:17] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: Set up text that goes next to payments forms on Docker - https://phabricator.wikimedia.org/T266092 (AndyRussG) [06:37:23] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: Set up private settings for payment providers for payments on Docker - https://phabricator.wikimedia.org/T266093 (AndyRussG) [06:38:36] Fundraising-Backlog: MySQL Workbench connection on Docker - https://phabricator.wikimedia.org/T266094 (AndyRussG) [13:04:21] Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form - https://phabricator.wikimedia.org/T266123 (jbolorinos-ctr) [13:04:47] Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form [modal5] - https://phabricator.wikimedia.org/T266123 (jbolorinos-ctr) [13:05:21] Fundraising-Backlog: FailMail: Duplicate contribution errors during audit run - https://phabricator.wikimedia.org/T266124 (jgleeson) [13:05:33] Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form [modal5] - https://phabricator.wikimedia.org/T266123 (jbolorinos-ctr) [13:06:06] Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form [modal5] - https://phabricator.wikimedia.org/T266123 (jbolorinos-ctr) This is a similar issue to what was reported in T264256 [13:06:22] Fundraising-Backlog: FailMail: Duplicate contribution errors during audit run - https://phabricator.wikimedia.org/T266124 (jgleeson) [13:07:05] Fundraising-Backlog: FailMail: Duplicate contribution errors during audit run - https://phabricator.wikimedia.org/T266124 (jgleeson) [13:49:41] Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form [modal5] - https://phabricator.wikimedia.org/T266123 (EWilfong_WMF) @jbolorinos-ctr - This is the intended behavior of the banner. I believe the thinking is that once the user clicks "Continue" they've begun the donation process a... [14:01:07] Wikimedia-Fundraising-Banners: RML link disappears after clicking back on form [modal5] - https://phabricator.wikimedia.org/T266123 (EWilfong_WMF) I don't think there was a specific test of this change, but it was implemented in part to avoid a possible display issue in some browsers. From an Aug. 1, 2019 c... [14:21:19] (PS13) Mepps: Create $wgDonationInterfaceMonthlyConvertCountries Allows turning on base monthlyConvert variant by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/632793 (https://phabricator.wikimedia.org/T250918) [15:40:14] Fundraising-Backlog: Prepaid bins being blocked - https://phabricator.wikimedia.org/T266151 (EMartin) [15:44:33] Fundraising-Backlog, fr-donorservices: Prepaid bins being blocked - https://phabricator.wikimedia.org/T266151 (DStrine) [15:48:11] fundraising-tech-ops, DC-Ops, Operations, ops-codfw: (Need By: 2020-09-30) rack/setup/install frmx2001.frack.codfw.wmnet, frdata2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T260183 (Jgreen) a:Jgreen→None [15:55:42] hi folks [16:00:39] fundraising-tech-ops: dovecot error messages after upgrade to buster - https://phabricator.wikimedia.org/T260859 (Jgreen) Open→Declined This is all interaction of the stock Debian packages (dovecot-core vs systemd-?) packages. It looks like a debug/warning with no actual functionality impact, so I do... [16:04:14] fundraising-tech-ops: procure and deploy new frmail server role - https://phabricator.wikimedia.org/T257245 (Jgreen) Open→Resolved a:Jgreen Boxes are up and running and so far appear to deliver mail properly. The ops/sre part of the project is complete. There's a separate task to switch civicrm t... [16:04:16] fundraising-tech-ops: break out fundraising outbound mail server to a separate host - https://phabricator.wikimedia.org/T245557 (Jgreen) [16:04:18] fundraising-tech-ops: 2020-2021 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T257244 (Jgreen) [16:13:08] Fundraising-Backlog: Invalid Pares Decline Error - https://phabricator.wikimedia.org/T247023 (EMartin) Resolved→Open Hi, the DS team continues to see these declines and they still come up in our decline reports. I had another run at talking to Ingenico about them and cited what Elliott mentioned abo... [16:15:35] Fundraising-Backlog, fr-donorservices: Invalid Pares Decline Error - https://phabricator.wikimedia.org/T247023 (MBeat33) [16:19:45] hmmm fr-tech looks like the latest mediawiki-codesniffer expects a lot of changes to our code [16:22:47] it's the good old dance of fix all the things, update sniffer, fix even more things. :) [16:23:01] yep! [16:23:29] i think that tea sounds like a good idea right now. [16:23:33] normally we can run a code beautifier to automagically fix stuff but it doesn't seem to resolve the issues this time :( [16:26:29] in SmashPig? [16:26:52] yep [16:28:33] is there a WIP up to show all the things it wants changed? [16:28:48] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: Payments on Docker: issue with composer cache directory - https://phabricator.wikimedia.org/T266158 (AndyRussG) [16:29:07] ejegg: I just spit out the errors only to make it more readable here https://phabricator.wikimedia.org/P13047 [16:29:11] split* [16:29:37] the full output is on this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/635393/1 [16:29:45] thanks jgleeson [16:30:23] so that patch also includes a bunch of fixes that phpcbf COULD apply but the remaining 20 or so errors are unfixable by that tool [16:30:34] so I'm just going through them now [16:31:08] oops standup [16:33:19] Wikimedia-Fundraising-Banners: Changed amount tracking not working correctly with Other field? - https://phabricator.wikimedia.org/T211333 (EWilfong_WMF) I'll take a look at this task this week. [16:54:09] Fundraising-Backlog, fr-donorservices: Prepaid bins being blocked - https://phabricator.wikimedia.org/T266151 (DStrine) @EMartin since we don't have any visibility on the credit card number we can't do anything to block these numbers. You will have to reach out to PSPs to do this on their end. [17:03:42] fr-tech do folks ever use Xdebug for digging into PhpUnit tests for payments? If so, how is it done, more or less? [17:04:27] AndyRussG: I do! [17:04:50] it's basically just switching over to using xdebug via the cli [17:05:02] lemme find the config setting which makes that easier [17:06:14] (CR) Cstone: [C: +2] "Works well when I have the right variable name 😊" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/632793 (https://phabricator.wikimedia.org/T250918) (owner: Mepps) [17:06:25] jgleeson: so it's something you set up in your IDE, and then when you run on the command line, it somehow tells the IDE where it is in the code? [17:06:49] or do you have to start it from within the IDE? [17:06:51] yeah kinda [17:07:10] so basically this flag `xdebug.remote_autostart=On` makes it much easier [17:07:19] jgleeson: hmmm if you have it running maybe wanna do a quick screenshare? [17:07:28] either now or any time that works for you? [17:08:46] lemme just seen if I have it setup for 7.3. I switched from PHP 7.2 last week to test out the mw/1_35 stuff so I think I need to add the config for it to make it work again. [17:09:03] jgleeson: ah okok thanks much, no rush eh! [17:10:25] it's np AndyRussG. Just gonna grab a coffee and then I'll dig into it [17:10:29] I wonder if maybe I should make it work in a browser first [17:10:31] jgleeson: thx much! [17:16:52] Wikimedia-Fundraising-Banners: Main banner and nag appearing at the same time - https://phabricator.wikimedia.org/T264461 (jbolorinos-ctr) I've confirmed this issue also appears on en.wiki, so it's not just a desktop refresh issue @Pcoombe {F32410374} [17:21:26] (Merged) jenkins-bot: Create $wgDonationInterfaceMonthlyConvertCountries Allows turning on base monthlyConvert variant by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/632793 (https://phabricator.wikimedia.org/T250918) (owner: Mepps) [17:27:59] back! took longer than expected as ice cream was getting dished out when I went down :) [17:28:28] ooo... ice cream. [17:28:42] yup yup! [17:29:48] (PS1) Mepps: DonationInterface submodule update [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635583 [17:29:52] jgleeson: :) [17:30:17] fr-tech so what's the decision about tech-talk? [17:31:42] Wikimedia-Fundraising-Banners, Instrument-ClientError, Patch-For-Review: Tag errors where a banner is being displayed - https://phabricator.wikimedia.org/T265096 (Jdlrobson) [17:32:58] (CR) Mepps: [C: +2] Update composer config PHP version [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634577 (owner: Ejegg) [17:33:54] Fundraising-Backlog, Wikimedia-Fundraising-Banners, donate.wikimedia.org, fr-donorservices: Investigate Japanese unintended recurring donations - https://phabricator.wikimedia.org/T262361 (jbolorinos-ctr) We discussed this in a meeting and decided it would be a good idea to tag the monthly other... [17:38:45] AndyRussG: looks like it's off I guess although I can hop in now to go through the cli setup for xdebug if that works for you? [17:39:17] (Merged) jenkins-bot: Update composer config PHP version [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/634577 (owner: Ejegg) [17:39:37] jgleeson: sure! gimme about 3 minutes then pls :) [17:39:57] sure thing [17:43:28] (PS2) Mepps: DonationInterface submodule update [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635583 [17:44:59] Fundraising-Backlog, Android-app-Bugs, Thank-You-Page, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (Dbrant) [17:46:30] Fundraising-Backlog, Android-app-Bugs, Thank-You-Page, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (Dbrant) And... it looks like we're already doing this on Android, too: https://gi... [17:50:38] (CR) Mepps: [C: +2] DonationInterface submodule update [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635583 (owner: Mepps) [17:58:25] (Merged) jenkins-bot: DonationInterface submodule update [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/635583 (owner: Mepps) [18:03:44] Fundraising-Backlog, Wikimedia-Fundraising-Banners: fundraising banner embeded in the article content - https://phabricator.wikimedia.org/T266170 (hashar) [18:12:17] !log updated payments-wiki-staging from db03677b2d to 5fdd29bc16 [18:12:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:16:39] Wikimedia-Fundraising-Campaigns: Fundraise in France: October 31 - November 28 - https://phabricator.wikimedia.org/T93301 (Jgreen) [18:16:41] Fundraising-Backlog: Make worldpay forms for Japan - https://phabricator.wikimedia.org/T93019 (Jgreen) [18:16:50] Wikimedia-Fundraising: Untranslated Credit Card fields (GlobalCollect iframes) - https://phabricator.wikimedia.org/T109064 (Jgreen) [18:17:10] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03): Not getting Adyen gateway for recurring AU & NZ donations - https://phabricator.wikimedia.org/T265752 (mepps) I just confirmed the adyen recurring links now work for AU and NZ. [18:19:54] Wikimedia-Fundraising-Banners: enAUNZ pre-test on October 22 - https://phabricator.wikimedia.org/T266172 (spatton) [18:31:07] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: desktop large batch - https://phabricator.wikimedia.org/T266175 (spatton) [18:34:38] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Permissions to git-update staging civi for select FR-creative members - https://phabricator.wikimedia.org/T232386 (Jgreen) I don't think we should broaden access to civicrm staging if it is avoidable. [18:36:27] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: desktop small batch - https://phabricator.wikimedia.org/T266176 (spatton) [18:37:52] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: mobile large batch - https://phabricator.wikimedia.org/T266177 (spatton) [18:39:33] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: mobile small batch - https://phabricator.wikimedia.org/T266178 (spatton) [18:39:39] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: mobile large batch - https://phabricator.wikimedia.org/T266177 (spatton) [18:40:29] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: mobile small batch - https://phabricator.wikimedia.org/T266178 (spatton) p:Triage→High [18:40:31] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: mobile large batch - https://phabricator.wikimedia.org/T266177 (spatton) p:Triage→High [18:40:33] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: desktop small batch - https://phabricator.wikimedia.org/T266176 (spatton) p:Triage→High [18:40:41] Wikimedia-Fundraising-Banners: 2020-10-22 enAUNZ pre-test: desktop large batch - https://phabricator.wikimedia.org/T266175 (spatton) p:Triage→High [18:45:43] Wikimedia-Fundraising-Banners: enAUNZ pre-test on October 22 - https://phabricator.wikimedia.org/T266172 (spatton) p:Triage→High [18:47:53] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint Upbeat Upholstery, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, and 4 others: Test payments-wiki extensions on MediaWiki 1.35 - https://phabricator.wikimedia.org/T260621 (Jgreen) I updated the frdeploy payments... [18:53:41] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New engage endowment import - https://phabricator.wikimedia.org/T265369 (RLewis) @Eileenmcnaughton I just tried to import the file and it looks as though somebody else already imported this file and it worked, I... [18:54:19] Fundraising-Backlog: Adyen hosted redirect page doesn't accurately reflect that I'm trying to make a recurring donation - https://phabricator.wikimedia.org/T266183 (spatton) [19:05:04] Wikimedia-Fundraising-Banners: enAUNZ pre-test on October 22 - https://phabricator.wikimedia.org/T266172 (spatton) Noting this related issue I saw; not sure yet if stakeholders will consider it a blocker to tomorrow's test {https://phabricator.wikimedia.org/T266183} [19:20:51] Fundraising-Backlog, fundraising-tech-ops, observability, Epic: Create Grafana dashboard for Online Fundraising to monitor live campaigns - https://phabricator.wikimedia.org/T256916 (Jgreen) [19:35:59] Fundraising-Backlog, fr-donorservices: Prepaid bins being blocked - https://phabricator.wikimedia.org/T266151 (EMartin) of course. Thanks! [19:44:36] Fundraising-Backlog, fr-donorservices: Prepaid bins being blocked - https://phabricator.wikimedia.org/T266151 (EMartin) Open→Resolved a:EMartin [19:45:37] Fundraising-Backlog, fr-donorservices: Invalid Pares Decline Error - https://phabricator.wikimedia.org/T247023 (EMartin) Ingenico is asking for: If we can get the full XML for both API's that would be great. We're aware that you're using Connect -Hosted Merchant Link, but we want to compare the APIs wi... [19:48:08] Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint Upbeat Upholstery, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, and 4 others: Test payments-wiki extensions on MediaWiki 1.35 - https://phabricator.wikimedia.org/T260621 (Jgreen) payments-wiki localsettings tre... [19:57:34] mepps: did you want to catch up in a few minutes [20:06:22] fr-tech, I've worked through the php codesniff violations that came up on smashpig against the latest version of mediawiki-codesniffer but the final two aren't straight forward fixes. I'd like to get peoples buy in before I fix those so I might add them to my end of day requested feedback https://phabricator.wikimedia.org/P13047#72465 [20:07:50] (PS2) Jgleeson: WIP: Update mediawiki-codesniffer to v31 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/635393 [20:08:09] (PS3) Jgleeson: WIP: Update mediawiki-codesniffer to v31 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/635393 [20:08:38] (CR) jerkins-bot: [V: -1] WIP: Update mediawiki-codesniffer to v31 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/635393 (owner: Jgleeson) [20:20:39] dstrine: Coleman just told me he's gotten stuck at the dentist & asked if next week would be OK for the mtg [20:20:54] ah ok I can change it [20:23:17] eileen: done [20:23:27] cool thakns [20:29:47] hey eileen i'm still not feeling great and have been working a bit today but skipping meetings [20:29:57] ok - no worrries [20:59:20] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New engage endowment import - https://phabricator.wikimedia.org/T265369 (Eileenmcnaughton) It was added by mdemos-ctr (& then you fixed it to be Endowment) [22:16:41] (PS1) Eileen: IDE code formatting cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635654 [22:16:43] (PS1) Eileen: Respect Contribution Type from the csv from Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635655 (https://phabricator.wikimedia.org/T265369) [22:18:28] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: New engage endowment import - https://phabricator.wikimedia.org/T265369 (Eileenmcnaughton) @RLewis so it seems like the Endowment donations are in the main csv that gets imported? And they... [22:20:35] I have a fix for the engage import if anyone can check - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/635655 - looks like it's really simple [22:21:22] also cstone do you think that stuff to deploy the fail messages is ok / reviewable? [22:23:41] (CR) jerkins-bot: [V: -1] Respect Contribution Type from the csv from Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635655 (https://phabricator.wikimedia.org/T265369) (owner: Eileen) [22:24:45] hey eileen sorry im back now [22:25:15] yeah i was trying to test it locally but I couldnt get the UI for the new setting to show up is there soemthing extra I need to do there [22:25:41] hmm so possibly go to civicrm/menu/rebuild [22:25:56] there is no nav link - I could add one to be nice [22:28:21] this one also just had an extra change id in the commit message https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/634135/1 [22:28:25] not sure if that was supposed to be there [22:31:27] ah dang a rebase [22:31:34] I can edit that out on gerrit [22:31:55] (PS2) Eileen: Add api to load a new template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634135 [22:32:54] does that show as updated for you? [22:33:47] yep! [22:35:58] and woo the rebuild worked [22:36:31] yya [22:36:32] yay [22:40:34] (PS2) Eileen: Respect Contribution Type from the csv from Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635655 (https://phabricator.wikimedia.org/T265369) [22:51:58] eileen: when it loads the template into the db is in an option value? [22:52:19] it looks like the es one ran fine for me but i cant find it [22:52:36] civicrm_strings [22:52:54] the master template is in civicrm_msg_tpl [22:54:55] (CR) Cstone: [C: +2] "Nice way to quickly load the templates!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634135 (owner: Eileen) [23:03:15] (Merged) jenkins-bot: Add api to load a new template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634135 (owner: Eileen) [23:06:10] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: all_Wikimedia database shows both_funds_donation_count as a decimal - https://phabricator.wikimedia.org/T265700 (Eileenmcnaughton) So looking at the first one - he has 2 references in silverpop This is for his current primary address https://eng... [23:18:43] Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog: all_Wikimedia database shows both_funds_donation_count as a decimal - https://phabricator.wikimedia.org/T265700 (Eileenmcnaughton) The second one contact id 22660624 https://engage4.silverpop.com/lists.do?action=listSummary&listId=9644238 has... [23:26:21] (CR) Cstone: [C: +2] Improve defining of supported languages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/634134 (owner: Eileen) [23:29:15] eileen: for the last patch I can't get any failed thank you to render locally but testing with myself on staging looks good [23:29:19] its not even loading the english one locally [23:29:50] hhmm & your contact has an email? [23:32:27] yeah hmm maybe its making this error API (ContributionRecur, get) does not exist (join the API team and implement it!) but that doesn't make sense [23:37:38] no - not really - unless your civi is out of date ... maybe