[00:01:22] (CR) jerkins-bot: [V: -1] WIP: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [00:10:46] AndyRussG: any ideas on how to get past the "AttributeError: 'Changelog' object has no attribute 'get_version'" error when running the first docker-pkg command? [00:11:11] looks like Changelog is a python object from a debian library [00:25:35] oh hmm, looks like the get_version method may have been renamed? [00:30:52] right, latest version of the python-debian lib's changelog object has no get_versions fn https://salsa.debian.org/python-debian-team/python-debian/-/blob/master/lib/debian/changelog.py [00:35:27] ejegg: so it worked now? [00:40:16] no, docker-pkg will need an update [00:40:21] I filed this bug: https://phabricator.wikimedia.org/T266730 [00:40:24] might try to fix it [00:45:06] ok, might be a simple fix [00:53:13] AndyRussG: want to see if this works on the version of python3-debian that you have installed? https://gerrit.wikimedia.org/r/c/operations/docker-images/docker-pkg/+/637082 [00:53:32] It let me get past the docker-pkg step [01:02:14] ejegg: huh interesting! yes I'll test it a bit later :) [01:02:27] Maybe it's been updated since I installed it locally then? [01:02:41] (Running also on Debian, on the sdcard machine.) [01:03:14] AndyRussG: i think it's because i'm on debian-testing [01:05:12] ejegg: ah right that makes sense [01:05:20] glad you could get it working! [01:13:57] ejegg: if you're doing docker image stuff, you may also find the Docker cheatsheet in the Etherpad useful [01:15:13] https://etherpad.wikimedia.org/p/fr-tech-docker line 291 [01:16:17] yep yep, thanks! [01:24:53] ejegg: also I didn't yet add to the setup.sh script pulling master of DI and the other extension, so that's manual just now [01:25:08] ok, cool [02:19:47] (PS5) Ejegg: Start the process of moving our mailer class to Omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635396 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [02:21:00] (CR) Ejegg: [C: +2] "OK, let's get this process started! Since we know we're going to HAVE to delete all the drupal modules next year, there's no chance we'll " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635396 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [02:28:53] (PS7) Ejegg: Minor code re-ordering - makes it possible to define email in one hit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635408 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [02:29:23] (CR) Ejegg: [C: +2] "More compact and better arranged, with the same result. Not crazy about the super-long ternary line with the reply-to, but no big deal." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635408 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [02:29:51] (PS2) Jforrester: [WIP] composer: Install phan locally [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/637020 [02:36:30] (CR) Jforrester: "check experimental" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/637020 (owner: Jforrester) [02:49:48] (CR) jerkins-bot: [V: -1] Minor code re-ordering - makes it possible to define email in one hit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635408 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [02:50:26] (CR) jerkins-bot: [V: -1] Start the process of moving our mailer class to Omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635396 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [02:55:38] eileen: what do you make of those test fails? [02:55:54] It's not finding the Civi\Omnimail\MailFactory class [02:56:11] I'm just trying to remember where we enable the civi extensions in CI setup [02:56:32] hmm, though we do run omnimail tests as part of the CI suite [02:56:57] and I'd imagine those would fail if the extension was disabled [02:58:20] they were passing - .... [02:58:44] ie this waas... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/635396 [02:58:47] but now... [03:00:14] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635396 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [03:00:23] hmm - just retryingg [03:00:48] oh weird [03:01:00] yeah, ps4 is identical to ps5, just rebased [03:01:03] guh [03:03:20] so that was with the new buildkit and all [03:03:27] what the heck changed? [03:03:44] I guess I rebased it around the 'delete DrupalMailer' patch [03:03:58] but that shouldn't have broken the autoloading [03:05:20] smashpig update, ty templates, and that tiny audit count fix should have no bearing on that test either [03:08:12] I'm just in the social salon (for aanoter 20 mins) [03:08:18] https://meet.google.com/fep-dmbv-vrc?authuser=0 [03:11:36] shoot, it's gotten quite late here [03:31:54] (PS8) Eileen: Minor code re-ordering - makes it possible to define email in one hit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635408 (https://phabricator.wikimedia.org/T264663) [03:56:57] (PS7) Eileen: Move send function into the factory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635409 (https://phabricator.wikimedia.org/T264663) [04:10:55] (PS10) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [04:11:04] (PS6) Eileen: Move IMailer to omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636512 [06:59:59] (PS1) AndyRussG: Set $wgPaypalExpressGatewayEnabled to false for FormChooserTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637238 (https://phabricator.wikimedia.org/T266088) [07:03:16] (CR) AndyRussG: "This fixes the last test that was failing on Docker. :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637238 (https://phabricator.wikimedia.org/T266088) (owner: AndyRussG) [09:07:38] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (1 MB out of 7628 MB) [09:09:56] ACKNOWLEDGEMENT - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (1 MB out of 7628 MB) Dwisehaupt Known [14:22:20] Fundraising-Backlog, Patch-For-Review: figure out Buster package for python3-mysql.connector for use with fruec - https://phabricator.wikimedia.org/T246823 (Jgreen) [14:26:18] Fundraising-Backlog, Patch-For-Review: figure out Buster package for python3-mysql.connector for use with fruec - https://phabricator.wikimedia.org/T246823 (Jgreen) Removing fundraising-tech-ops tag as this is a software development task. Dallas volunteered a patch, but it has been sitting unreviewed sin... [14:27:38] (CR) Ejegg: [C: +2] "Yep, let's definitely rename this from Factory - does sound weird to have a factory sending things." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635409 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [14:34:02] (CR) DannyS712: [C: +2] build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/637478 (owner: Libraryupgrader) [14:34:08] (CR) DannyS712: [C: +2] build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/637476 (owner: Libraryupgrader) [14:34:13] (CR) DannyS712: [C: +2] build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/637475 (owner: Libraryupgrader) [14:48:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Investigate impact of buster upgrade on queue processing - https://phabricator.wikimedia.org/T264819 (Jgreen) Open→Declined At this point I don't see a clear indication of a slowdown since the php 7.3 upgrade. As Dallas... [14:50:36] (Merged) jenkins-bot: Move send function into the factory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635409 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [15:10:02] fundraising-tech-ops: remove fruec code and configuration from servers - https://phabricator.wikimedia.org/T266794 (Jgreen) [15:12:08] Fundraising-Backlog, fr-donorservices: Estimate the proportion of people who send us complaints vs are affected by an issue - https://phabricator.wikimedia.org/T120722 (MBeat33) [15:54:07] (PS3) Jforrester: [WIP] composer: Install phan locally [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/637020 [16:05:58] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review: Make payments phpunit tests pass under Docker - https://phabricator.wikimedia.org/T266088 (AndyRussG) Looks like the error and fai... [16:32:46] RECOVERY - check_swap on frav1002 is OK: SWAP OK - 14% free (1065 MB out of 7628 MB) [16:40:31] Wikimedia-Fundraising-Banners: QA for en6c pre-test Saturday 10/31 - https://phabricator.wikimedia.org/T266803 (HNordeenWMF) [16:40:41] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: Monthly convert pwk modal variant 011 (alt button text) - https://phabricator.wikimedia.org/T266562 (Cstone) a:Cstone [16:41:12] Wikimedia-Fundraising-Banners: QA for en6c pre-test Saturday 10/31 - https://phabricator.wikimedia.org/T266803 (HNordeenWMF) p:Triage→High [16:43:43] Wikimedia-Fundraising-Banners: 2020-10-31 en6c pre-test desktop large batch - https://phabricator.wikimedia.org/T266804 (HNordeenWMF) [16:44:57] Wikimedia-Fundraising-Banners: 2020-10-31 en6c pre-test desktop large batch - https://phabricator.wikimedia.org/T266804 (HNordeenWMF) [16:45:40] Wikimedia-Fundraising-Banners: 2020-10-31 en6c pre-test desktop large batch - https://phabricator.wikimedia.org/T266804 (HNordeenWMF) [16:48:38] Wikimedia-Fundraising-Banners: 2020-10-31 en6c pre-test: desktop small batch - https://phabricator.wikimedia.org/T266806 (HNordeenWMF) [16:49:14] Wikimedia-Fundraising-Banners: 2020-10-31 en6c pre-test: desktop small batch - https://phabricator.wikimedia.org/T266806 (HNordeenWMF) [16:53:27] Wikimedia-Fundraising-Banners: 2020-10-31 en6c pre-test mobile large batch - https://phabricator.wikimedia.org/T266808 (HNordeenWMF) [16:55:30] Wikimedia-Fundraising-Banners: T266804 2020-10-31 en6c pre-test mobile small batch - https://phabricator.wikimedia.org/T266809 (HNordeenWMF) [16:55:47] Wikimedia-Fundraising-Banners: 2020-10-31 en6c pre-test mobile small batch - https://phabricator.wikimedia.org/T266809 (HNordeenWMF) [16:57:29] Fundraising-Backlog: fr-tech documentation needed for datacenter cutover procedure - https://phabricator.wikimedia.org/T266810 (Jgreen) [16:58:38] Fundraising-Backlog, fundraising-tech-ops: add datacenter and server failover protocol to fundraising disaster protocol documentation - https://phabricator.wikimedia.org/T263686 (Jgreen) Open→Resolved p:Triage→Medium a:Jgreen The SRE portion is essentially done: https://collab.wikimed... [16:58:40] Fundraising-Backlog, fundraising-tech-ops, Epic: epic: frtech onwiki documentation overhaul - https://phabricator.wikimedia.org/T209872 (Jgreen) [16:58:42] fundraising-tech-ops, Operations: Ensure all disaster recover documentation is in one central location - https://phabricator.wikimedia.org/T95841 (Jgreen) [20:05:28] ejegg: that test fail last night was just the parent needed merging [20:20:45] ahh oops [20:20:56] OK, continuing with the CR [20:44:52] ejegg: cool - the SMTP mailer one is the one that makes failover possible - I tested on staging [20:57:09] eileen: should SMTPMailer be in the Civi\Omnimail namespace? [20:57:32] MailFactory doesn't \ it [20:57:37] yes - is that not in that commit ? It all got a bit messy [20:57:51] ah shoot, lemme make sure I pulled down the latest [20:58:35] dang, as of PS10 it's not in the namespace [21:04:38] eileen: ^^ [21:07:31] hmm - I'll fix [21:10:32] (PS11) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [21:10:46] ejegg: was it just that missing? [21:24:57] that's all I could see on a first pass [21:27:51] oops eileen now PHPMailer needs a \ (inside SMTPMailer) [21:29:31] fixed [21:29:36] (PS12) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [21:44:36] (CR) Ejegg: "one more question" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [21:46:28] (PS13) Eileen: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) [21:46:41] (CR) Eileen: "fixed" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [21:58:54] (CR) Ejegg: [C: +2] "Cool, this looks like a good way to ease into SMTP testing. Later we can add a more robust way to handle the server setting." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [22:05:05] bother, nother merge conflict [22:06:02] yeah - my attempts to rework for review went badly - it was 1 step forwards 2 steps back [22:09:07] (PS7) Ejegg: Move IMailer to omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636512 (owner: Eileen) [22:17:50] (Merged) jenkins-bot: Rudimentary ability to use SMTP mailer with our thank you mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/635410 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [22:29:27] ejegg: now https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/636512 has lost it's v+2 but tests not running - gerrit seems unpredictable [22:36:22] ah it did run through [22:42:08] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/637575 [22:42:29] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/637575 (owner: Eileen) [23:22:01] !log civicrm revision changed from e1d65b0f3a to 3317d30356, config revision is d70fe02cb9 [23:22:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:29:35] I just cleared caches as it didn't find the new class [23:35:06] (CR) Ejegg: [C: +2] "Looks good!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636512 (owner: Eileen) [23:35:42] turning off thankyou to check out why it's not finding the class. [23:36:14] oh shoot, autoloader issues? [23:36:27] yeah :-( [23:36:47] !log process-control config revision is 1114512f90 [23:36:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:38:05] for some reason rpow shows disabled - I'm gonna enable cos that looks odd + it should do some cache clearing i n the process [23:44:04] oh weird [23:45:14] hmm, yeah, a slow_start command would be nice for the TY runner [23:45:30] for now we have to change the batch size in the UI [23:47:52] well it worked this time [23:48:03] the rpow enable was enough [23:49:30] oh good, we don't have to resort to a blood offering! [23:51:31] it was close [23:51:57] I will try the smtp for 1 run & then re-enable [23:53:25] (Merged) jenkins-bot: Move IMailer to omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636512 (owner: Eileen) [23:59:59] !log process-control config revision is 6891d35bce