[00:55:58] Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, fundraising sprint Theme songs for programming languages: Get queues working on docker - https://phabricator.wikimedia.org/T262977 (AndyRussG) This is now working! Build the [[ https://ger... [00:58:17] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: Add SmashPig config for payments wiki on Docker - https://phabricator.wikimedia.org/T266089 (AndyRussG) Initial version now available... See the [[ https://gerrit.wikimedia.org/r/c/releng/dev-images/... [01:01:22] Fundraising-Backlog: Docker dev setup: Review, update, organize and comment payments-LocalSettings.php - https://phabricator.wikimedia.org/T266840 (AndyRussG) Here's a start on this by @Ejegg: [[ https://gitlab.com/andyrussg/fundraising-dev/-/commit/09ecead0f955aa3cc9ded158f5cbc8c0ae4f7ded | Enable Ingenico... [03:13:00] (PS1) Eileen: Move PhpMailer to Omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/637893 (https://phabricator.wikimedia.org/T264663) [03:16:27] (PS1) Eileen: Move MailerBase to Omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/637894 (https://phabricator.wikimedia.org/T264663) [05:51:31] (PS1) Eileen: WIP on sending phpmailer via civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/637898 (https://phabricator.wikimedia.org/T264663) [14:15:15] (CR) Mepps: [C: +1] "This looks great. My only two thoughts are 1) Are there any cases where someone would have a display or sort name that has a name while th" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636808 (https://phabricator.wikimedia.org/T265652) (owner: Eileen) [14:21:55] (CR) Mepps: "This looks great! Should we confirm they don't want a comma between "No" and "thanks!"? This does mimic the task description as is but is " (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637767 (owner: Cstone) [14:22:36] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Patch-For-Review: Monthly convert pwk modal variant 011 (alt button text) - https://phabricator.wikimedia.org/T266562 (mepps) @spatton Quick question: did you want it to be "No, thanks!" or "No thanks!" as is? [16:21:27] Fundraising-Backlog: EPIC: Enable the ability for user to pay with iDeal through Adyen - https://phabricator.wikimedia.org/T231370 (Ejegg) Open→Resolved a:Ejegg Child tasks closed, closing parent epic. [16:39:30] !log updated payments-wiki from adc3369cb3 to 1ad4ba9639 [16:39:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:40:54] shoot, did my connection fail before the rsync completed? [16:41:03] dang, never had to run that under screen before [16:41:49] ok, re-doing it had no more files to sync, I guess it succeeded the first time. [16:43:28] (CR) Ejegg: [C: +2] "Looks good, let's just reformat the WS in a follow-on patch" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/637893 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [16:53:28] (CR) Ejegg: [C: +2] "Looks good. As with parent patch, let's reformat in a followon." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/637894 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [17:00:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Duplicate contribution messages lead to failmail - https://phabricator.wikimedia.org/T267047 (Ejegg) [17:04:44] (Merged) jenkins-bot: Move PhpMailer to Omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/637893 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [17:10:04] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Automatic TY for Stock Gifts - https://phabricator.wikimedia.org/T259173 (jgleeson) a:jgleeson [17:22:32] (Merged) jenkins-bot: Move MailerBase to Omnimail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/637894 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [17:45:19] Wikimedia-Fundraising-Banners, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): 2020 English fundraising messages in Android app - https://phabricator.wikimedia.org/T266289 (cooltey) a:cooltey [18:23:49] PROBLEM - check_apache2 on frpig1001 is CRITICAL: PROCS CRITICAL: 0 processes with command name apache2 [18:23:53] PROBLEM - check_listener_gc on frpig1001 is CRITICAL: connect to address 10.64.40.164 and port 443: Connection refused [18:23:55] PROBLEM - check_listener_ipn on frpig1001 is CRITICAL: connect to address 10.64.40.164 and port 443: Connection refused [18:26:57] old global collect endpoint maybe fr-tech? ^ [18:27:21] Jeff_Green ^^ ? [18:27:42] mepps: I just rebuilt and rebooted that server [18:28:02] is that what the notification is from Jeff_Green? [18:28:08] we're cut over to the codfw one for the moment [18:28:23] yeah, I thought I had put it in icinga downtime already but apparently forgot [18:28:36] ah [18:28:45] RECOVERY - check_apache2 on frpig1001 is OK: PROCS OK: 6 processes with command name apache2 [18:28:45] RECOVERY - check_listener_gc on frpig1001 is OK: HTTP OK: HTTP/1.1 200 OK - 408 bytes in 0.053 second response time [18:28:47] RECOVERY - check_listener_ipn on frpig1001 is OK: HTTP OK: HTTP/1.1 200 OK - 405 bytes in 0.021 second response time [18:41:05] fr-tech did backlog refinement get pushed out a little later? [18:41:53] oh it looks like it got shortened so it starts later [18:42:05] optical illusion [18:42:54] fr-tech today's album recommendation is Ben Howard - I Forget Where We Were [18:43:23] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Patch-For-Review: Monthly convert pwk modal variant 011 (alt button text) - https://phabricator.wikimedia.org/T266562 (spatton) @mepps, killer edit! I think that's just an inconsistency on my part; could you please go with **No, thanks!** [18:45:29] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Patch-For-Review: Monthly convert pwk modal variant 011 (alt button text) - https://phabricator.wikimedia.org/T266562 (mepps) Great @spatton! [18:47:07] (CR) Mepps: "Updated after hearing from Sam on the phab task." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637767 (owner: Cstone) [18:47:17] fundraising-tech-ops, Patch-For-Review: Upgrade payments_listener servers to Debian Buster - https://phabricator.wikimedia.org/T265688 (Jgreen) Open→Resolved a:Jgreen frpig1001 is done [18:47:37] jgleeson I was also just noticing that re: backlog [18:47:38] fr-tech frpig1001 upgrade to buster/7.3 is done, it's back to serving traffic [18:47:52] thanks Jeff_Green ! [18:49:18] (PS2) Cstone: Monthly Convert: Variant 011, yes button text with ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637767 [18:49:32] hey mepps, noticing what? the ticket from earlier [18:49:38] thanks Jeff_Green [18:49:47] hey jgleeson I meant about the meeting today [18:50:00] ahh gotcha [18:50:09] yeah it looked odd in the calendar [18:50:15] same here jgleeson [18:50:19] :) [18:58:20] (PS2) Ejegg: Remove USD currency from non-US formSettings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630627 [18:58:43] fr-tech ^^^ just deletes some erroneous-looking form settings [18:59:17] I think they could possible cause ppl not to get the Adyen forms even when gateway=adyen is specified on the querystring [18:59:42] I must have just copy-pasted those in there by accident when I was adding the adyen forms in the first place [19:03:05] looking ejegg [19:12:01] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [19:12:21] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [19:13:02] ejegg: I was gonna debug through that quickly to see the change but my payments is still not quite right. Am I right in assuming that removing the currency will mean that when the GatewayFormChooser comes to pick the best form, it will mean the adyen forms that previously looked for USD will now NOT get added to the $failforms array if folks specify a non-USD currency? I'm looking at this code [19:13:04] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/24894f5c4d184fe17cf91ee149eed4c421f5fe11/special/GatewayFormChooser.php#L551-L550 [19:24:52] (CR) Eileen: "> Patch Set 1: Code-Review+1" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636808 (https://phabricator.wikimedia.org/T265652) (owner: Eileen) [19:25:21] omg - gerrit has comment threading now [19:25:30] rly? [19:26:41] jgleeson yeah, that's a nasty looking conditional, huh? [19:26:50] So if you specify a currency like GBP [19:27:12] that form would previously have been added to the failforms array [19:27:17] and with this change it shouldn't [19:27:23] right, just like you said [19:28:05] (CR) Ejegg: [C: +2] "Thanks for the modernization!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637583 (https://phabricator.wikimedia.org/T248059) (owner: Ammarpad) [19:31:05] (PS3) Cstone: Monthly Convert: Variant 011, yes button text with ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637767 [19:32:56] thanks for confirming ejegg [19:33:18] (CR) Jgleeson: [C: +2] Remove USD currency from non-US formSettings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630627 (owner: Ejegg) [19:33:33] (CR) Jgleeson: [C: +2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630627 (owner: Ejegg) [19:34:36] (Merged) jenkins-bot: Use IPUtils to check IP [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637583 (https://phabricator.wikimedia.org/T248059) (owner: Ammarpad) [19:37:20] dwisehaupt (or jeff but not online) - I should try the thank you again on smtp [19:38:53] (CR) Mepps: [C: +2] Monthly Convert: Variant 011, yes button text with ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637767 (owner: Cstone) [19:39:16] (Merged) jenkins-bot: Remove USD currency from non-US formSettings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/630627 (owner: Ejegg) [19:39:30] eileen: sounds good [19:40:21] i can tail the frmx-mail log and watch for the connection [19:41:27] ok - I'll stop the thank you job & run manually [19:42:26] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/638165 [19:43:27] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/638165 (owner: Eileen) [19:44:44] (Merged) jenkins-bot: Monthly Convert: Variant 011, yes button text with ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/637767 (owner: Cstone) [19:45:56] !log process-control config revision is db912e3bba - thankyou job off for testing [19:46:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:47:22] !log civicrm revision changed from 3317d30356 to cd13d9e30f, config revision is db912e3bba [19:47:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:50:51] Wikimedia-Fundraising-Banners, Wikipedia-iOS-App-Backlog, iOS-app-Bonefish-On-A-Balloon: 2020 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T266290 (LGoto) [19:51:32] dwisehaupt: ok - about to try just one to me [19:52:26] sure thing. [19:52:39] hmm still has the phpmailer in the header so I guess it didn't 'take' [19:53:29] yeah. i see it going straight out from civi [19:54:19] eileen could the drush user-swap be messing with the env variables? [19:54:32] ohh maybe [19:54:59] is it OK to put the command I'm using up - it has the server names in it but I think Jeff put them on the phab anyway [19:55:14] i think so [19:56:21] ok - so this is it [19:56:22] env CIVICRM_SMTP_HOST="tls://frmx1001.frack.eqiad.wmnet:25;tls://frmx2001.frack.codfw.wmnet:25;localhost:25" drush cvapi thankyou.send contribution_id=51970459 [19:56:26] (Abandoned) Ejegg: WIP import stage timings [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/621323 (owner: Ejegg) [19:57:42] hmm, so the drush command there is the wrapper [19:57:54] yeah [19:57:59] oho, which has a specific --preserve-env on the sudo command [19:58:15] Jeff did that for me I think [19:58:16] and only preserves CIVICRM_DEBUG_LOG_QUERY [19:58:22] ah... [19:58:28] so I guess we need another preserve-env there? [19:58:42] Yeah -maybe CIVICRM* ? [19:59:20] huh, looks like you can preserve all or a specific list, no wildcards [19:59:34] gonna grab some lunch, back soon [20:00:10] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Eileenmcnaughton) My testing command is... [20:02:20] dwisehaupt: what do you think the best approach is -being able to do it per-job should be good for warming up the servers but once it's settled we will define in civicrm.settings.php - so I could just put the setting there [20:04:05] hmmmm... i think this would be a good question for our meeting in an hour. i'm sure jeff will have some additional insight and ideas. [20:04:39] the only thing that concerns me is the history for not preserving the env and if it was done for a specific reason. [20:06:48] i think adding CIVICRM_SMTP_HOST to preserve-env sounds perfectly sane to me. [20:07:52] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [20:08:06] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [20:20:38] dwisehaupt: OK - I'll renable thank you job & can retest when ready - or if you want you can always try the command above yourself (it will only email me) [20:22:01] !log process-control config revision is 313a36312f re-enable thank you [20:22:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:22:12] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog, and 4 others: Get payments wiki working on docker - https://phabricator.wikimedia.org/T262976 (mepps) I can confirm I got this running locally with @e... [20:22:38] - we don't actually need to disable thank you for testing using the above as it only emails one contribution [20:39:39] (PS1) Eileen: Apply drupal formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638175 (https://phabricator.wikimedia.org/T264663) [20:49:23] Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (MBeat33) [20:59:33] (PS1) Eileen: Add created_date to omnimail_job_progress table [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638177 (https://phabricator.wikimedia.org/T222287) [21:01:52] Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (MBeat33) Given our transaction volume, 8 instances is kind of a lot, so we expect to see a lot more of these. 850393 mentions testing a cross-site tracking setting - could... [21:11:06] Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (EMartin) I will look into this and get back to you. [21:12:38] Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (MBeat33) Thanks, @EMartin I am gathering browser info from the rest of the donors and will update here. [21:15:16] Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (EMartin) Do you have merchant reference number associated with these by any chance? [21:16:37] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (DStrine) [21:20:41] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (Cstone) I was able to replicate the continue button doing nothing in Safari 13.1.2 on a MacBook Pro [21:22:43] (CR) jerkins-bot: [V: -1] Add created_date to omnimail_job_progress table [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638177 (https://phabricator.wikimedia.org/T222287) (owner: Eileen) [21:23:13] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (MBeat33) Thanks, @Cstone #850393 is the donor who succeeded in a later attempt, @EMartin and that donation is AMAZON P01-22... [21:23:49] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (DStrine) I had an error on Chrome on a mac. After I signed into amazon, I got a payments wiki page with a continue button and... [21:25:37] (PS2) Eileen: Add created_date to omnimail_job_progress table [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638177 (https://phabricator.wikimedia.org/T222287) [21:49:29] (PS8) Jgleeson: WIP: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) [22:16:51] Wikimedia-Fundraising-Banners, Wikipedia-iOS-App-Backlog, Patch-For-Review, iOS-app-Bonefish-On-A-Balloon: 2020 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T266290 (cooltey) For whoever picks up this ticket, the patch I created also updates the iOS app donation lin... [22:40:38] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Dwisehaupt) CIVICRM_SMTP_HOST has been ad... [22:45:06] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Eileenmcnaughton) A run of exactly 1 emai... [22:58:00] (CR) Ejegg: [C: +2] "Looks good" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638175 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [23:00:24] ejegg: so in terms of the clean up on the mail fail over - I guess the challenge to move Civi over is the signatures need syncing [23:00:24] I guess we could update our classes to support Civi's signature - I'm just a little hestitent until this https://lab.civicrm.org/dev/core/-/issues/2159 has played out [23:00:53] ie our send() function has different input parameters to the core CiviCRM send() function [23:02:09] ok, so core civi has ($recipients, $headers, $body) and we have ($randoArrayWithSomeHeadersAndBody, $otherHeaders) [23:04:06] oh hmm what's this zeta components mail thing? [23:10:17] yeah - thats about the size of it :-) [23:10:28] our signature probably matches drupals? [23:11:04] I feel like the civi signature might not be the best in that $body is not as granular as it might be [23:11:54] I'm leaning towards not pushing further on it this round & picking it up in a couple of months under 'move modules to extensions' chore - when hopefully the discussion will have firmed up [23:17:54] (Merged) jenkins-bot: Apply drupal formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638175 (https://phabricator.wikimedia.org/T264663) (owner: Eileen) [23:27:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (MBeat33) cid=1960455 is another donor who received the Civi email on October 1, though their donation pro... [23:28:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (Eileenmcnaughton) I think it's medium - maybe a 2 [23:35:06] (PS9) Jgleeson: WIP: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) [23:35:44] jgleeson: is it still WIP? [23:35:57] (per commit msg) [23:39:10] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Dwisehaupt) Ends up that drush jobs were... [23:46:12] eileen: yeah I just spent 30 minutes blowing up an air bed with a foot pump after the electric pump died so I pushed up where I got to before that and I'll add the remaining bits (just moving that js fn around) first thing. I'm done for tonight [23:46:51] jgleeson: cool - sleep well [23:47:00] you too! by for now [23:48:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (MBeat33) Thank you. @DStrine what are the prospects for fr-tech having capacity for this this quarter? [23:52:47] Fundraising Sprint Upbeat Upholstery, Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: fr-tech to look into supporting mail fail over for civi - https://phabricator.wikimedia.org/T264663 (Eileenmcnaughton) We tried this via ENV &...