[00:58:30] (PS10) Jgleeson: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) [00:58:32] (PS1) Jgleeson: Added drush cmd to update custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638759 (https://phabricator.wikimedia.org/T259173) [01:13:08] (PS2) Jgleeson: Added drush cmd to update custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638759 (https://phabricator.wikimedia.org/T259173) [01:13:10] (PS11) Jgleeson: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) [01:15:17] Wow Florida is a real horse race [01:17:30] (CR) jerkins-bot: [V: -1] Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [01:20:52] (PS12) Jgleeson: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) [01:23:22] eileen: I tidied those patches and pushed them up but looks like my new test isn't working so I'll dig into that. I'm gonna go fall asleep watching the coverage. g'night! [01:32:09] (CR) jerkins-bot: [V: -1] Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [01:40:34] (CR) jerkins-bot: [V: -1] Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [05:18:07] (CR) DannyS712: [C: +2] build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/638800 (owner: Libraryupgrader) [12:06:02] Fundraising-Backlog: Add extra logging to provide more info on silverpop export missing email failure - https://phabricator.wikimedia.org/T266253 (jgleeson) this happened again today: See the logs for more information: /var/log/process-control/silverpop_emails_build_export_files/silverpop_emails_build_expor... [13:20:56] Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Email: Civi to IBM export: Yesterday's files were sent today - https://phabricator.wikimedia.org/T265352 (KHaggard) Noting this issue happened again today (Nov 4, 2020). @jgleeson noticed and kicked off a rerun this mor... [14:08:15] (PS13) Jgleeson: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) [14:26:36] (CR) jerkins-bot: [V: -1] Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [14:36:43] (PS14) Jgleeson: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) [14:55:18] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (mepps) I was able to reproduce this morning too. Not seeing console errors on prod weirdly. I wonder if I can get set up to r... [15:18:29] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (mepps) a:mepps On Safari I see just a continue button that doesn't work: {F32430786} BUT on chrome I see TWO buttons: {F... [15:42:05] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (mepps) There's a lot going on in the code. - The css tries to show the button that has the "force" class which is the con... [16:55:30] Fundraising-Backlog, Wikimedia-Fundraising-Banners, MediaWiki-extensions-CentralNotice, JavaScript, Wikimedia-production-error: Fundraising banners are throwing JS errors in CentralNotice live preview - https://phabricator.wikimedia.org/T262693 (Jdlrobson) Thank you so much @pcoombe ! [17:06:19] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [17:40:05] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [17:43:49] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices: Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (mepps) I see that the force class on the continue button is only supposed to be present when show_submethods is true. [17:46:24] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [17:46:49] (CR) Mepps: "Given how often it's re-used, might we want to name the js file ext.donationInterface.monthlyConvert_flipButtons?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638225 (owner: Cstone) [17:47:26] (CR) Mepps: [C: +1] "This looks like it should work to me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638225 (owner: Cstone) [17:48:56] (CR) Mepps: [C: +1] "I'm not sure about my previous comment about the js file naming. The important thing might be consistency one way or another." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638225 (owner: Cstone) [17:51:14] Wikimedia-Fundraising-Banners: en6C pre-test on November 5 - https://phabricator.wikimedia.org/T267151 (jbolorinos-ctr) Thank Sam! Getting started on this now and will ping you if any issues are found [18:00:54] Fundraising-Backlog: Can we have a separate frCA TY email? - https://phabricator.wikimedia.org/T267250 (DStrine) [18:00:56] Fundraising-Backlog: Can we have a separate frCA TY email? - https://phabricator.wikimedia.org/T267250 (DStrine) [18:03:45] Fundraising-Backlog: Can we have a separate frCA TY email? - https://phabricator.wikimedia.org/T267250 (MBeat33) cid=47785972 [18:04:15] Fundraising-Backlog, fr-donorservices: Can we have a separate frCA TY email? - https://phabricator.wikimedia.org/T267250 (MBeat33) [18:10:55] fundraising-tech-ops: Epic: Upgrade fundraising servers to buster - https://phabricator.wikimedia.org/T254198 (Jgreen) [18:52:17] (PS1) Ejegg: Fix loading styles from ui_modules [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/639236 (https://phabricator.wikimedia.org/T267070) [18:52:34] fr-tech ^^^ one char fix might make Amazon work [18:52:38] testing locally now [18:53:49] yep yep, looks much better [18:55:40] (CR) Cstone: [C: +2] Fix loading styles from ui_modules [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/639236 (https://phabricator.wikimedia.org/T267070) (owner: Ejegg) [18:55:54] did their filename change or it was just failing gracefully? [18:58:35] (Merged) jenkins-bot: Fix loading styles from ui_modules [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/639236 (https://phabricator.wikimedia.org/T267070) (owner: Ejegg) [19:05:10] Fundraising-Backlog, fundraising-tech-ops: Create new job to send Civi thank you emails over stmp through frmx hosts - https://phabricator.wikimedia.org/T267259 (Dwisehaupt) [19:07:26] Fundraising-Backlog, fundraising-tech-ops: Create new job to send Civi thank you emails over smtp through frmx hosts - https://phabricator.wikimedia.org/T267259 (Dwisehaupt) [19:15:37] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/639243 [19:22:27] Fundraising-Backlog: Add extra logging to provide more info on silverpop export missing email failure - https://phabricator.wikimedia.org/T266253 (Eileenmcnaughton) Hmm I had a feeling it was just bumped down from one table to the next last fix [19:23:04] Fundraising-Backlog: Stripe import - https://phabricator.wikimedia.org/T267255 (Aklapper) [19:23:28] Fundraising-Backlog: Stripe Import error: INVALID_FILE_FORMAT This file is missing column headers - https://phabricator.wikimedia.org/T267255 (Aklapper) [19:25:47] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/639243 (owner: Ejegg) [19:27:00] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/639243 (owner: Ejegg) [20:00:45] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/639265 [20:00:51] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/639265 (owner: Ejegg) [20:02:50] fundraising-tech-ops: frdb1001 hardware refresh - https://phabricator.wikimedia.org/T257242 (Jgreen) [20:05:32] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: Stripe Import error: INVALID_FILE_FORMAT This file is missing column headers - https://phabricator.wikimedia.org/T267255 (DStrine) [20:09:58] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: Stripe Import error: INVALID_FILE_FORMAT This file is missing column headers - https://phabricator.wikimedia.org/T267255 (jkim_wikimedia) smb://filesrv1.corp.wikimedia.org/fundraising/Development/Events/2020 Events/Stripe October 2020.csv [20:10:22] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/639265 (owner: Ejegg) [20:12:11] (CR) Mepps: [C: -1] "See comment. One thing to fix." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638225 (owner: Cstone) [20:13:21] (CR) Mepps: [C: +1] "This looks straightforward and good, just depends on previous patch." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638238 (owner: Cstone) [20:15:03] (CR) Mepps: [C: -1] "Need to move 11 to styles." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638239 (owner: Cstone) [20:17:42] mepps is that how its supposed to be,? i guess it makes sense hah the other ones I was following just had them in all in scripts eg 006 [20:19:00] interesting cstone! based on my reading of the code that shouldn't work.. [20:19:16] ejegg ^^ it does look like that's how it's used... [20:19:58] sorry, what? [20:20:22] ohh, putting a css-only module in the styles: key of ui_modules? [20:20:29] yeah ejegg [20:20:36] will it read it from scripts? [20:20:52] lemme see [20:20:59] I guess it would... [20:21:03] I think that failmail that just happened is the one I put up a patch forr [20:21:13] because addModules can add both js and css? [20:21:24] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/638734 [20:21:28] make sense for it to be in styles though [20:21:29] it's just funky and might be confusing later [20:22:01] yeah [20:22:05] good spot [20:22:09] yeah cstone it looks like your code won't break that way but putting it under styles will help us know what it's doing later [20:22:17] yeah [20:22:24] ah yeah mepps [20:22:44] I guess maybe we could simplify those ui_modules files [20:22:51] and just lump everything together [20:22:58] yeah ejegg that's another option [20:23:09] but we'd need to rewrite the mustache code for that [20:23:14] yep yep [20:23:19] of course, we'd talked about doing that anyways [20:23:20] outside the scope of this task [20:23:25] :( yeah [20:23:54] it's funny that ResourceLoader has addModuleStyles but no parallel addModuleScripts [20:24:35] or OutputPage rather [20:29:47] Wikimedia-Fundraising-Banners, Wikidata: Banner on German Wikipedia and wikidata.org throwing NS_ERROR_FILE_CORRUPTED: error - https://phabricator.wikimedia.org/T267267 (Jdlrobson) [20:29:55] Wikimedia-Fundraising-Banners, Wikidata, Wikimedia-production-error: Banner on German Wikipedia and wikidata.org throwing NS_ERROR_FILE_CORRUPTED: error - https://phabricator.wikimedia.org/T267267 (Jdlrobson) [20:30:09] Wikimedia-Fundraising-Banners, Wikidata, Wikimedia-production-error: Banner on German Wikipedia and wikidata.org throwing NS_ERROR_FILE_CORRUPTED: error - https://phabricator.wikimedia.org/T267267 (Jdlrobson) Example: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.11.04/clien... [20:33:24] !log updated payments-wiki from 1ad4ba9639 to 388490e86d [20:33:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:36:42] mepps: we should cover off this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/636808 [20:48:55] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17): Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (Ejegg) OK, we deployed a fix for this. Turns out a code refactor deployed on O... [20:49:24] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17): Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (Ejegg) There may be another Safari-specific issue - we'll look a bit more into... [21:00:08] also I put up a proposal for dealing with the forget me issue - my theory is the bug is silverpop & we can add a created_date to the job progress table & have a failmail if it is more than 1 hour old [21:03:22] Fundraising-Backlog: As a SurveyMonkey account owner, I would like to know if we need to update our email allowlist for SurveyMonkey - https://phabricator.wikimedia.org/T265161 (Ppena) Hi all, I believe November 2nd 2020, was the date SurveyMonkey was changing their IP addresses. Do we have a whitelist we c... [21:17:23] (PS15) Eileen: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [21:18:00] (CR) Eileen: [C: +2] "I found one remaining typo blocking the js - but with that fixed this seems all good to me" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [21:28:36] Wikimedia-Fundraising-Banners, Wikidata, JavaScript, Wikimedia-production-error: Banner on German Wikipedia and wikidata.org throwing NS_ERROR_FILE_CORRUPTED: error - https://phabricator.wikimedia.org/T267267 (Umherirrender) [21:28:48] (CR) Mepps: "It might be a good idea to decouple the IDE changes from the code update." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638759 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [21:30:46] (CR) Mepps: [C: +1] "Haven't tested but other than the IDE changes, code looks good." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638759 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [22:09:55] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: Stripe Import error: INVALID_FILE_FORMAT This file is missing column headers - https://phabricator.wikimedia.org/T267255 (Eileenmcnaughton) @jkim_wikimedia the new file does indeed have different column headers to previous ones You can see... [22:20:26] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: Stripe Import error: INVALID_FILE_FORMAT This file is missing column headers - https://phabricator.wikimedia.org/T267255 (jkim_wikimedia) Thanks @Eileenmcnaughton ! I'll check with Stripe, but I have a feeling it'll be permanent. It'd be str... [22:24:27] (CR) Eileen: [C: +2] "This seemed to work locally." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638759 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [22:25:28] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: Stripe Import error: INVALID_FILE_FORMAT This file is missing column headers - https://phabricator.wikimedia.org/T267255 (Eileenmcnaughton) a:Eileenmcnaughton [22:44:29] (Merged) jenkins-bot: Added drush cmd to update custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638759 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [22:45:35] (Merged) jenkins-bot: Add Stock Value field and show in ty letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/636749 (https://phabricator.wikimedia.org/T259173) (owner: Jgleeson) [23:04:54] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17): Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (MBeat33) Thank you @Ejegg and @mepps ! I will ask the non-Safari users to retr...