[02:24:55] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: matching gifts values don't match between databases - https://phabricator.wikimedia.org/T266475 (MNoorWMF) I have Briana on this task right now, will check with her on Monday if that's an okay deadline to QA this? [02:37:16] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog: matching gifts values don't match between databases - https://phabricator.wikimedia.org/T266475 (Eileenmcnaughton) perfect! [17:02:53] !log rolled out new thank_you_mail_send process_control scripts to utilize frmx hosts [17:02:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:18:56] (CR) Jgleeson: [C: -1] "I think we need to move the emoji stripping to an earlier point in the process. I tried creating a donation with a donor using an emoji in" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638734 (https://phabricator.wikimedia.org/T267171) (owner: Eileen) [17:58:55] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, Epic: [Epic] Create Adyen forms for CA, GB, AU, NZ and IE - https://phabricator.wikimedia.org/T138456 (DStrine) Open→Resolved [17:59:20] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, Android-app-Bugs, Operations, and 5 others: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (CDanis) Patches look ready to go -- as discussed with @Ejegg we'll get this deployed Monday. [18:08:48] fr-tech, this is Ali G interviewing Buzz Aldrin. https://www.youtube.com/watch?v=AwARY7Kk8ek [18:54:40] Fundraising-Backlog, fundraising-tech-ops: Create new job to send Civi thank you emails over smtp through frmx hosts - https://phabricator.wikimedia.org/T267259 (Dwisehaupt) Pushed these jobs this morning and seeing mails going through the frmxs. Leaving them running on this minimal setting for the weeke... [18:55:21] Fundraising-Backlog, fundraising-tech-ops: Create new job to send Civi thank you emails over smtp through frmx hosts - https://phabricator.wikimedia.org/T267259 (Dwisehaupt) [19:32:32] fr-tech I was just testing out the monthly convert stuff and I noticed some console log errors after clicking yes to the recurring donation option. I then tried an earlier monthly convert variant (pre these patches) and I still see the same error. Has anyone seen this? https://phabricator.wikimedia.org/F32452392 [19:34:00] what's odd is that the url it's trying to access is accessible [19:34:27] jgleeson: I have it too [19:35:15] but the page does load for me? [19:35:57] ya same [19:36:01] odd right? [19:36:12] I wonder if it's an iframe thingy [19:36:36] oh my god just caused tab apocalypse trying to get back window i accidentally closed [19:36:38] rip all tabs [19:36:45] oh noes! [19:36:52] ctrol alt and T>? [19:36:56] ctrol* [19:37:00] hmm [19:37:02] without the o [19:37:10] ctrl**** [19:37:11] :) [19:37:14] yeah haha ill just have to let the window go [19:38:53] i get the console error with the main variant too [19:40:06] ditto [20:01:38] jgleeson: aha [20:01:46] so [20:02:24] that is mediawiki's way of showing a redlink [20:02:32] i.e. article does not exist [20:02:47] oh? [20:02:52] it's a 404 because it doesn't exist [20:02:56] ah I see [20:03:03] but it gives you the UI to create it [20:03:04] well that's neat/scary [20:03:16] console sees 404 and lights up red for error [20:03:21] but it's actually fine [20:05:43] thanks for explaining [20:05:50] clears that up! [20:12:16] cstone: I think mepps has made a good point in how we're potentially misnaming our 'Style:' ui_modules although it still actually works as the files get loaded regardless of which block they're in from what I can see [20:13:34] Yeah jgleeson when i tried to switch it it wasn't loading the css at all for me [20:13:55] We talked about other refactors for the variants and i figured that could be added [20:14:38] lemme guess you tried Styles? [20:14:55] or 'styles' [20:14:59] plural [20:15:03] cstone: [20:15:40] I did then hunted down that it was style [20:16:04] Then it still wasnt showing up and i could see it loading when stepping through [20:16:28] Then it was late and i left it out hah I can look at it again now [20:16:31] oh rly [20:16:36] ah ok [20:16:44] yeah I spotted the lack of the s [20:20:31] hmm yeah I see what you mean [20:20:50] I'm curious now why the 'style:' block doesn't work [20:35:12] so the css script: element does get lost [20:35:48] in here https://github.com/wikimedia/mediawiki/blob/91c73f6bac9922925883937fa1279d42c22dd429/includes/resourceloader/ResourceLoaderClientHtml.php#L338 [20:36:06] so that's probably a separate bug cstone you're right [20:36:28] Nice find jgleeson [20:36:44] ok i guess we can +2 that and add a note to investigate why our 'style' modules get lost [20:40:00] (CR) Jgleeson: [C: +2] "Looks good and is working for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638225 (owner: Cstone) [20:40:22] Thanks jgleeson ! [20:40:39] (PS5) Jgleeson: Monthly Convert: Variant 013, flipped button order of 006 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638238 (owner: Cstone) [20:43:12] I know AndyRussG is also looking at these so I'll check out the next one and leave the final one https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/638239/2 for AndyRussG to review if that's ok AndyRussG [20:43:52] I figure you wanna give payments on might-morphin-power docker, a run? [20:44:01] mighty* doh [20:49:15] (CR) Jgleeson: [C: +2] "Working as expected for me, nice work!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638238 (owner: Cstone) [20:49:28] (PS3) Jgleeson: Monthly Convert: Variant 014, flipped buttons of 011 with text change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638239 (owner: Cstone) [20:52:47] have a good weekend fr-tech! [20:57:58] (Merged) jenkins-bot: Monthly Convert: Variant 012, flipped button order of 011 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638225 (owner: Cstone) [20:58:00] (Merged) jenkins-bot: Monthly Convert: Variant 013, flipped button order of 006 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/638238 (owner: Cstone) [22:03:22] Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog, FR-Amazon, fr-donorservices, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17): Amazon unresponsive donation form - https://phabricator.wikimedia.org/T267070 (MBeat33) #851406 tried again today, 11/6, using Firefox / Win 7 64bit: //I ge... [23:38:36] !log frdata1001 upgraded to buster [23:38:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log