[03:26:09] (CR) Ejegg: [C: +2] "Thanks mepps! This will get us past the nightly fails we're seeing now. Later we can sort out the optimal fix." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/640470 (owner: Mepps) [03:27:21] (Merged) jenkins-bot: Add duplicate handling for insert into silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/640470 (owner: Mepps) [03:31:14] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/640726 [03:31:30] (CR) Ejegg: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/640726 (owner: Ejegg) [03:32:03] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/640726 (owner: Ejegg) [03:46:20] !log updated python fundraising tools from 7853f426ee to 68e054c9ad [03:46:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [13:03:14] Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Email: Civi to IBM export: Yesterday's files were sent today - https://phabricator.wikimedia.org/T265352 (jgleeson) @KHaggard I've just checked over latest silverpop export log and file data and can confirm they complet... [14:25:27] Fundraising-Backlog, fundraising sprint Theme songs for programming languages, FR-Email: Civi to IBM export: Yesterday's files were sent today - https://phabricator.wikimedia.org/T265352 (KHaggard) Open→Resolved Thanks @jgleeson ! I checked out the recurring import jobs and they processed yes... [17:53:50] (CR) Ejegg: "It would also be nice to by default strip the emoji completely rather than replacing them with the string 'emoji', as long as that doesn't" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638734 (https://phabricator.wikimedia.org/T267171) (owner: Eileen) [20:34:54] (PS1) Ejegg: Don't delete adyen/astropay pending info on payment fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/640845 (https://phabricator.wikimedia.org/T259253) [20:35:40] (PS1) Ejegg: Don't delete Adyen pending info on capture fail [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/640846 (https://phabricator.wikimedia.org/T259253) [20:53:54] (PS1) Ejegg: Reformat payments-init consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/640851 [21:00:29] ejegg looking at that patch on skipping deleting adyen it certainly makes sense to me [21:00:45] is there anything I should consider as I'm inclined to +2 [21:03:40] (CR) Eileen: "> Patch Set 1:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638734 (https://phabricator.wikimedia.org/T267171) (owner: Eileen) [21:06:20] eileen I think its pretty straightforward! [21:17:41] ejegg: ok - I'm gonna merge [21:17:49] thanks! [21:18:26] just read your reply to the CR on your patch and I guess it makes sense to use the string in the lookup query [21:19:06] (CR) Eileen: [C: +2] "This makes sense to me. Although this is an area of code that is not my specialty I feel more confident +2ing because this in fact makes t" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/640845 (https://phabricator.wikimedia.org/T259253) (owner: Ejegg) [21:20:26] (CR) Eileen: [C: +2] "I figured out how to view with ignore whitespace in the UI - yay" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/640851 (owner: Ejegg) [21:21:27] ejegg: I chatted about the emoji with Tim yesterday -in terms of a core fix we were going to look at changing it to changing to just WHERE 0 at the v4 api level [21:21:40] I haven't worked on that yet - but it's the same end result [21:21:44] ok [21:21:53] next year we should convert the DB to UTF8mb4 [21:22:03] yep yep [21:22:12] Or we could sneak it in tomorrow's outage :-) [21:22:25] or should that be 🦉 [21:22:29] hah, what could go wrong? [21:22:56] nothing I can think of - as long as we don't mind the outage being a bit longer.... [21:23:19] are you doing a normal day today or just popping in? [21:23:55] half day today, half tomorrow [21:24:45] ah cool [21:25:31] if you get a chance - this is what I think the way forward on forget issues is https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/638177 [21:25:51] ah yeah, that's the created_date field you were talking about? [21:25:56] working theory is that silverpop is messing up & we need to keep a better eye on silver pop [21:25:57] yeah [21:26:04] k, looking [21:26:13] there are 2 patches to make it work [21:26:27] (& one that is just civix) [21:37:54] (Merged) jenkins-bot: Don't delete adyen/astropay pending info on payment fail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/640845 (https://phabricator.wikimedia.org/T259253) (owner: Ejegg) [21:38:24] (Merged) jenkins-bot: Reformat payments-init consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/640851 (owner: Ejegg) [21:48:29] (PS3) Ejegg: Add created_date to omnimail_job_progress table [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638177 (https://phabricator.wikimedia.org/T222287) (owner: Eileen) [21:48:40] (CR) Ejegg: [C: +2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638177 (https://phabricator.wikimedia.org/T222287) (owner: Eileen) [21:48:55] (PS2) Ejegg: Civix code standards update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638262 (owner: Eileen) [21:49:02] (CR) Ejegg: [C: +2] Civix code standards update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638262 (owner: Eileen) [21:57:28] eileen so that should be 'drush cvapi --version=4 OmnimailJobProgress.Check' to run the check? [21:57:53] I think so - I realise I need to check in on running v4api through the cli [21:58:21] I'm gonna talk to Coleman soon so will ask [21:59:31] thanks! [22:00:19] lol - just thinking coffee would be nice & then realised Richard had made me some & I'd been drinking it for the last 5 minutes [22:01:21] oh man, you really needed it [22:01:28] yep [22:01:38] & it's not my first cup of the day... [22:11:19] (Merged) jenkins-bot: Add created_date to omnimail_job_progress table [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638177 (https://phabricator.wikimedia.org/T222287) (owner: Eileen) [22:11:21] (Merged) jenkins-bot: Civix code standards update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638262 (owner: Eileen)