[11:56:51] (CR) Jgleeson: "Thanks for the feedback ejegg. It's not quite finished yet as I just wanted to push up a WIP of what I'd been playing around with." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) (owner: Jgleeson) [12:39:26] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Add Carte Bancaire logo and enable card type logos in France - https://phabricator.wikimedia.org/T204545 (Pcoombe) a:Pcoombe→None [13:33:41] Wikimedia-Fundraising-Banners: Remove deprecated $.bind() from banners - https://phabricator.wikimedia.org/T267169 (Pcoombe) Open→Resolved Done for current best. Desktop small diff (also removed unused nag RML javascript) - https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-templat... [13:55:47] (CR) Jgleeson: WIP: Add in check for additional recurring cotributions (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) (owner: Jgleeson) [13:56:20] (CR) Jgleeson: WIP: Add in check for additional recurring cotributions (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) (owner: Jgleeson) [14:29:41] (PS3) Jgleeson: WIP: Add in check for additional recurring cotributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) [14:40:28] (PS4) Jgleeson: WIP: Add in check for additional recurring cotributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) [15:00:45] (CR) jerkins-bot: [V: -1] WIP: Add in check for additional recurring cotributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) (owner: Jgleeson) [16:00:29] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, Epic: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (Ejegg) [16:03:46] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, MediaWiki-extensions-DonationInterface, Epic: Use Guzzle to make API request to CiviProxy to retrieve opt-in / opt-out fields. - https://phabricator.wikimedia.org/T268497 (Ejegg) [16:04:30] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-planning-ahead, Epic: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (Ejegg) [16:06:55] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Epic: Configure CiviProxy vhost and firewall to allow requests from email prefs box - https://phabricator.wikimedia.org/T268499 (Ejegg) [16:12:00] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, fundraising-tech-ops, Fr-planning-ahead, Epic: Deploy mediawiki fundraising/REL1_35 to new box for email preference center - https://phabricator.wikimedia.org/T268501 (Ejegg) [16:19:25] Fundraising-Backlog, fr-donorservices: 11/20 Email donation link pointed to “foundation.wikimedia.org/wiki/Home" - https://phabricator.wikimedia.org/T268502 (MBeat33) [16:20:52] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (HNordeenWMF) [16:21:45] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (HNordeenWMF) p:Triage→Medium [16:34:32] Fundraising-Backlog, fr-donorservices: 11/20 Email donation link pointed to “foundation.wikimedia.org/wiki/Home" - https://phabricator.wikimedia.org/T268502 (Ejegg) Weird, all of those links sure look like they're constructed right - everything starts with https://donate.wikimedia.org. The email encoding... [16:45:04] (CR) Ejegg: WIP: Add in check for additional recurring cotributions (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) (owner: Jgleeson) [17:26:31] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Fr-planning-ahead, MediaWiki-extensions-DonationInterface, Epic: Create new subpage for Special:EmailPreferences - https://phabricator.wikimedia.org/T268510 (Ejegg) [17:26:46] (PS3) Umherirrender: Validate banner name on SpecialCentralNoticeBanners for delete and clone [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/611713 (https://phabricator.wikimedia.org/T173782) [17:30:19] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-planning-ahead, Epic: Consume new messages from Email Preferences form - https://phabricator.wikimedia.org/T268511 (Ejegg) [17:33:42] Fundraising-Backlog, FR-Smashpig: Add new queue settings for email-preferences - https://phabricator.wikimedia.org/T268512 (Ejegg) [17:33:53] Fundraising-Backlog, FR-Smashpig: Add new queue settings for email-preferences - https://phabricator.wikimedia.org/T268512 (Ejegg) [17:35:02] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create new subpage for Special:EmailPreferences - https://phabricator.wikimedia.org/T268510 (Ejegg) [17:35:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (Ejegg) [17:36:01] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use Guzzle to make API request to CiviProxy to retrieve opt-in / opt-out fields. - https://phabricator.wikimedia.org/T268497 (Ejegg) [17:36:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Configure CiviProxy vhost and firewall to allow requests from email prefs box - https://phabricator.wikimedia.org/T268499 (Ejegg) [17:36:36] Fundraising-Backlog, fundraising-tech-ops: Deploy mediawiki fundraising/REL1_35 to new box for email preference center - https://phabricator.wikimedia.org/T268501 (Ejegg) [17:38:09] Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint We all meet again, Fundraising-Backlog, FR-Email: Investigate email preference center prototype - https://phabricator.wikimedia.org/T266607 (Ejegg) Created a bunch of subtasks under T125272, two for ops and the rest for fr-tech. [17:44:30] Fundraising Sprint We all meet again, Fundraising-Backlog: Add 'Stock Information' field to thank you letter - https://phabricator.wikimedia.org/T268081 (Cstone) a:Cstone [18:00:26] tzag fr-tech [18:00:48] hi jgleeson [18:00:57] hey cstone hows it goin :) [18:02:34] hey not too bad jgleeson how about you [18:02:41] hi jgleeson! [18:03:24] hey ejegg! [18:05:28] good good thanks cstone. I finally got AndyRussG's docker stuff running and I was like WOWZER looking at all the work he'd done on that [18:05:47] yeah!! [18:06:11] I finally understand docker now too [18:06:47] after working through https://www.udemy.com/course/learn-docker/ [18:08:01] oh hmm, that class is just $10? think i'll snag that [18:08:15] yeah ejegg it was a real bargain! [18:08:45] Yea, and you can definitely expense that against your personal development funds. [18:10:15] cool cool [18:33:35] Wikimedia-Fundraising-Banners, fr-donorservices: Extra decimals on Other amount field gets PTF riled up - https://phabricator.wikimedia.org/T259762 (spatton) As a point of reference, noting that this issue has been present in banners since at least 2017, even prior to implementation of the Pay The Fee fe... [18:38:34] hi jgleeson cstone ejegg XenoRyet fr-tech :) [18:54:32] hey AndyRussG ! [18:56:08] :) [18:56:14] AndyRussG: so I finally caught up with yall and got your fundraising-dev docker project running. Thanks so much for all the work on that and making it super convenient and well documented for us all! [18:57:01] jgleeson: ahhh happy to hear you liked it!!! I have a bunch of fixing-the-doc and fixing-some-gotcha tasks lined up in fact [18:57:12] though now I'm struggling to get vagrant working on the new laptop hahahah [19:00:38] arghhh vagrant [19:01:14] I'm also having issues locally AndyRussG with recurring donations and have decided to give up as I'll hopefully be trying out the civi docker stuff at some point today [19:01:38] jgleeson: k pls don't hesitate to reach out if you have Docker issues or questions eh! [19:01:49] haha for vagrant I'm not past the kernel module vbox stuff [19:01:53] system keeps freezing up [19:02:17] or that is the vbox system [19:02:36] but then I can't fully stop the broken vm without restarting [19:02:59] and then when I restart the computer the whole computer freezes on the first restart [19:03:06] AndyRussG: I was gonna look at what's involved to drop in our welcome page as part of the set up on payments. I'm guessing we can take most of it from the template in mw-vagrant [19:03:15] once I get this unit test done [19:03:49] I also wanna finish watching the recording of the civi docker discussion you had with cstone and eileen [19:04:23] to get an idea of how we're gonna squeeze civi in [19:05:09] jgleeson: ahhh cool beans! heh yes I have a tentative plan for the welcome page and the side text as well, just haven't coded it up yet, so pls lmk if you'd like to discuss! [19:08:47] :) [19:08:52] will do! [19:44:08] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ejohnston - https://phabricator.wikimedia.org/T241785 (Dwisehaupt) Resolved→Open They are back and ready for the new cert. Renewing now. [19:49:18] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ejohnston - https://phabricator.wikimedia.org/T241785 (Dwisehaupt) Open→Resolved Certificate renewed and sent via email. Password sent via SMS. ` [frack::puppet::private] 76971b5 Renewal of ejohnston certificate ` [20:06:19] ejegg: when you were working on the CiviCRM Smashpig ext, specifically the FailureEmail stuff, did you test that with local mail? I can't seem to get it to email locally and show up in mailcatcher and was wondering if you had any ideas? I spotted a flag which controls whether the mail gets sent and that's true but even with it the mails dont show up anywhere for me [20:06:50] Fundraising-Backlog, fundraising-tech-ops: Create new job to send Civi thank you emails over smtp through frmx hosts - https://phabricator.wikimedia.org/T267259 (Dwisehaupt) [20:07:29] Fundraising-Backlog, fundraising-tech-ops: Create new job to send Civi thank you emails over smtp through frmx hosts - https://phabricator.wikimedia.org/T267259 (Dwisehaupt) Open→Resolved a:Dwisehaupt Fully transitioned and logs are still looking clean through the latest test. [20:10:00] jgleeson: with the ty tests did you ever run into this when running locally " contact_id should possibly be marked as mandatory for Contribution" [20:13:52] I think so [20:14:05] I remember seeing something like that when running ucf [20:14:12] a warning? [20:14:14] cstone: ^ [20:14:51] (PS5) Jgleeson: Suppress recurring payment failure failmail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) [20:15:11] im getting it when trying to run the stock thank you test locally [20:15:27] but i did touch the columns [20:16:26] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: Upgrade Fundraising Superset to 0.37.x - https://phabricator.wikimedia.org/T262439 (Dwisehaupt) Too far into Q2 to address this. Pushing it until Q3 to avoid interfering with Q2 fundraising. [20:17:16] does it still send the ty out cstone ? [20:17:22] I can't remember seeing it there tbh [20:17:23] ooh i think i know what it is [20:18:46] its failing on inserting the test data in the unit test [20:18:55] do those errors get logged anywhere? [20:19:05] its helpfully completely gut off in the terminal [20:19:08] cut even [20:20:47] oh interesting [20:21:10] so guess you could tail the civicrm configandlog stuff [20:21:15] lemme remember when tha tis [20:21:22] yeah i did look in there [20:21:25] but its not updating from the unit tests [20:21:57] ah [20:22:25] hmm [20:22:45] what test is failing cstone ? [20:23:09] ThankYouTest::testSendStockThankYou its entirely possible my code changes broke it hah [20:23:24] (PS6) Jgleeson: Suppress recurring payment failure failmail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) [20:23:39] I'll pull the latest and try it loclaly [20:24:23] hm yeah i just tried it with no changes and its still failing [20:24:42] might be a brittle test [20:26:19] yep that test is failing locally for me cstone [20:26:20] :/ [20:26:33] hmm is it the same on inserting the test data? [20:30:46] looks like the contribution worked but it failed to count test mailings for me [20:30:56] oops meeting. be 1 minute [20:47:05] Fundraising-Backlog, fr-donorservices: 11/20 Email donation link pointed to “foundation.wikimedia.org/wiki/Home" - https://phabricator.wikimedia.org/T268502 (DStrine) @MBeat33 there isn't much for us to goon here but please let us know if you hear of more of these. thanks! [20:56:47] Fundraising-Backlog, fr-donorservices: 11/20 Email donation link pointed to “foundation.wikimedia.org/wiki/Home" - https://phabricator.wikimedia.org/T268502 (MBeat33) p:Triage→Medium Thanks, we'll keep an eye out. It's possible the donor was in error with the URL they reported. If we don't see mo... [21:01:53] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint Upbeat Upholstery, and 6 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (Ejegg) a:Ejegg [21:41:52] ejegg: just gonna try putting through two new recurring donations to see if I can recreate the bug I mentioned [21:47:44] btw cstone did you figure the test thingy out? did it go away [21:50:33] (PS1) Cstone: WIP: Add Description of Stock to thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/643094 (https://phabricator.wikimedia.org/T268081) [21:50:41] jgleeson: not locally gona see what CI does [21:51:07] jgleeson: are you not able to put in a new recurring at all? [22:01:20] cstone: first time round I was getting a bunch of errors showing [22:01:22] WD failmail: What's that? Something wrong: UNHANDLED ERROR. Halting dequeue loop. Exception: Expected one Contribution but found 0 [error] [22:01:24] Stack Trace: #0 /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/queue2civicrm/recurring/RecurringQueueConsumer.php(314): civicrm_api3('Contribution', [22:01:26] 'getvalue', Array) [22:01:47] but now it's working it seems so I'm looking at what changed [22:01:59] I think I might have forgotten when the recurring queue gets pushed to [22:02:29] and mistaking monthlyConvert recurring messages with my standard recurring donations [22:02:41] just following through the code now to remind myself what goes on :/ [22:03:40] ah yeah [22:03:42] i get that [22:04:55] jgleeson: can you get smashpig recurring to run? [22:07:00] i think so cstone I've run it a few times via the cvapi [22:09:15] nice i think it pushes everything to the main donations queue too 🤔 [22:13:48] hmm looks like tests pass on CI cstone ¯\_(ツ)_/¯ [22:14:01] yeahh of course hah [22:43:26] fundraising-tech-ops: New ssl client cert for sdaniels - https://phabricator.wikimedia.org/T268533 (Dwisehaupt) [22:49:13] Fundraising Sprint We all meet again, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Categorize all the email export failures and suggest a solution - https://phabricator.wikimedia.org/T267757 (Eileenmcnaughton) @MNoorWMF - my guess is maybe a few hundred a year between this & oth... [22:50:11] fundraising-tech-ops: New ssl client cert for sdaniels - https://phabricator.wikimedia.org/T268533 (Dwisehaupt) Open→Resolved Client cert renewed (revoke/create) and sent via email. Password sent via SMS. ` [frack::puppet::private] 1b8c6fd Renewal of ssl client cert for sdaniels ` [23:32:24] finally tested that double recurring failmail! [23:32:41] I was missing a contact merge [23:33:02] and had to play with the db to satisfy the 23 day rule [23:33:39] that tripped me up a few times. Jim Carrey was right! [23:33:56] nice jgleeson and yeah time math?? [23:34:18] always fun [23:34:44] even better when your vm is running 12 hours behind your host machine [23:34:57] nuuu [23:36:58] I noticed the recurring failmails dont make it to mailcatcher [23:37:04] not sure why that is [23:37:21] mayb civi is using another mail transport [23:49:09] jgleeson: I think it would be phpmail from civi [23:51:03] (PS7) Jgleeson: Suppress recurring payment failure failmail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/642517 (https://phabricator.wikimedia.org/T260910) [23:51:27] eileen: I thought mailcatcher would catch that [23:51:31] need to look into it [23:51:49] I guess we're gonna be taking mailcatcher or one of its successors over to docker [23:52:29] hmm maybe I should move those test instructions over to the ticket https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/642517/ [23:52:45] cstone is that stock one still wip? [23:53:00] i was testing it against CI tests cause my local ones were failing [23:53:11] I want to test one more thing locally then ill take it out [23:54:18] eileen: the tests were failing for both me and cstone on her patch (and the earlier one I did) so I'm not sure whether I forgot to test locally (unlikely since I added a unit test) or some cat corrupted my data [23:59:04] Fundraising Sprint We all meet again, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to active recurring donor - https://phabricator.wikimedia.org/T260910 (jgleeson) **To Test:** - Submit two recurring donations (same name) - R...