[00:14:30] (PS1) AndyRussG: Don't allow empty string for remote for private repo, and show link [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/644078 (https://phabricator.wikimedia.org/T268954) [06:23:15] (PS1) AndyRussG: Improvements to README.md [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/644082 (https://phabricator.wikimedia.org/T268954) [08:34:35] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Set up process control - https://phabricator.wikimedia.org/T268685 (AndyRussG) Hi! Thanks so so much for digging in here! The time and energy spent on this is hugely appreciated. So is the thoughtfulness with... [09:37:18] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Set up process control - https://phabricator.wikimedia.org/T268685 (awight) My input is out of place here, since I would only be tinkering with process-control to make tiny changes, and I don't plan to use the... [09:52:02] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Set up process control - https://phabricator.wikimedia.org/T268685 (jgleeson) > But disclaimer aside, I would expect the repo's local Dockerfile to do the absolute minimum, it only needs to support the use ca... [10:23:01] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Set up process control - https://phabricator.wikimedia.org/T268685 (jgleeson) >>! In T268685#6654822, @AndyRussG wrote: > Hi! Thanks so so much for digging in here! The time and energy spent on this is hugely... [11:04:42] (CR) Awight: [C: +1] "This is great!" (8 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/643767 (https://phabricator.wikimedia.org/T268685) (owner: Jgleeson) [14:50:39] Wikimedia-Fundraising-Banners: [CANDIDATE] 2020-11-21 Pretest: Ask Strings - https://phabricator.wikimedia.org/T267983 (spatton) Open→Resolved [15:07:22] hi fr-tech [15:07:44] ejegg hey :) [15:14:24] hey all [15:31:42] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (HNordeenWMF) @jbolorinos-ctr Her are updated Links for these banners: now pre-payment monthly convert should only display for Paypal! Desktop Large: https://en.wikipedia.org/wiki/... [15:40:49] (PS1) Ejegg: Adyen: detect more recurring auth messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/644260 (https://phabricator.wikimedia.org/T268654) [15:41:00] cstone: hi! I'm looking to tweak the adyen IPN recurring detection [15:41:08] I think you were the one that worked on that last [15:41:15] jgleeson|away: maybe you were in on that too? [15:41:42] anyway, based on ct_id 90128495 from today's failmail I think ^^^ might do it [15:50:40] Jeff_Green: :) [15:59:24] nice ejegg looking as soon as gerrit will load for me [15:59:39] ugh, slow for you too? [15:59:46] not even loading [15:59:57] 4th times the charm [16:00:07] it took like 2 minutes for me [16:00:13] ugh [16:02:20] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Set up process control - https://phabricator.wikimedia.org/T268685 (AndyRussG) > I feel like the drawbacks I've listed are valid and this response maybeee kinda brushes some of them off a bit? Ahhhh that's no... [16:14:43] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (jbolorinos-ctr) Thanks @HNordeenWMF! I'll get started on these now and let you know if there are any issues. [16:19:23] Wikimedia-Fundraising-Banners: Dsk Lg - https://phabricator.wikimedia.org/T269010 (jbolorinos-ctr) Screenshot Test Results: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zc0e51685064d619710e [16:20:01] (PS1) Ejegg: Fallback for monthly convert amt localization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644276 [16:20:21] fr-tech there's a little fix for a thing i'm seeing in the error logs today ^^^ [16:21:37] Wikimedia-Fundraising-Banners: Dsk Sm - https://phabricator.wikimedia.org/T269011 (jbolorinos-ctr) [16:22:03] Wikimedia-Fundraising-Banners: Dsk Sm - https://phabricator.wikimedia.org/T269011 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zc1fdf2f9caff8df8b73 [16:22:24] hey ejegg your patch looks fine but what if the currency isn't USD? we're assuming it is? [16:22:46] Wikimedia-Fundraising-Banners: M Lg - https://phabricator.wikimedia.org/T269012 (jbolorinos-ctr) [16:22:53] mepps oops, did I hardcode USD? I meant to use the 'currency' variable [16:23:02] you did ejegg [16:23:11] I just meant we're assuming two decimal places across the board [16:23:27] yeah, for the fallback I think it might be OK [16:23:32] (CR) jerkins-bot: [V: -1] Fallback for monthly convert amt localization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644276 (owner: Ejegg) [16:23:43] ups, I bet I broke a formatting rule [16:24:08] Wikimedia-Fundraising-Banners: M Lg - https://phabricator.wikimedia.org/T269012 (jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z8d1ad5c225bb4f97a7a [16:24:44] (PS2) Ejegg: Fallback for monthly convert amt localization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644276 [16:24:51] Wikimedia-Fundraising-Banners: M Sm - https://phabricator.wikimedia.org/T269013 (jbolorinos-ctr) [16:26:01] Wikimedia-Fundraising-Banners: M Sm - https://phabricator.wikimedia.org/T269013 (jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zf2db5c030f384098f58 [16:29:30] (CR) Mepps: [C: +2] Fallback for monthly convert amt localization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644276 (owner: Ejegg) [16:35:25] fr-tech I'm trying to get Eileen civi docker system working but it keeps freezing on installing drush modules :/ [16:35:32] where would logs for that be? [16:40:58] Wikimedia-Fundraising-Banners: Dsk Lg - https://phabricator.wikimedia.org/T269010 (jbolorinos-ctr) ✅ Monthly convert appears for Paypal pre-payment ✅ Monthly convert does NOT appear for Visa pre-payment ✅ Monthly convert does NOT appear for Amazon pre-payment Status: ✅ PASS Environment: mediawiki OS: Window... [16:41:26] Wikimedia-Fundraising-Banners: Dsk Sm - https://phabricator.wikimedia.org/T269011 (jbolorinos-ctr) ✅ Monthly convert appears for Paypal pre-payment ✅ Monthly convert does NOT appear for Visa pre-payment ✅ Monthly convert does NOT appear for Amazon pre-payment Status: ✅ PASS Environment: mediawiki OS: Window... [16:46:04] (Merged) jenkins-bot: Fallback for monthly convert amt localization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644276 (owner: Ejegg) [17:29:46] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Set up process control - https://phabricator.wikimedia.org/T268685 (jgleeson) > > This is one point from your comments where there doesn't seem to be a misunderstanding, but rather a disagreement about goals... [17:39:51] Wikimedia-Fundraising-Banners, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): 2020 English fundraising messages in Android app - https://phabricator.wikimedia.org/T266289 (cooltey) > Hi, since it's a short week I just want to double check that this is on track to launch on Monda... [17:46:53] Wikimedia-Fundraising-Banners: Dsk Lg - https://phabricator.wikimedia.org/T269010 (jbolorinos-ctr) Open→Resolved Everything looks good! No blockers found. Closing this task now as Resolved. [18:07:27] mepps interesting - I think that's the place where it pauses for a long time during CI setup too [18:07:53] we can hack in a drush output after each module maybe to narrow down where it's taking so long [18:10:34] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/644300 [18:10:39] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/644300 (owner: Ejegg) [18:12:04] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/644300 (owner: Ejegg) [18:35:42] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (jbolorinos-ctr) [18:35:46] Wikimedia-Fundraising-Banners: Dsk Sm - https://phabricator.wikimedia.org/T269011 (jbolorinos-ctr) Open→Resolved Looks good! No blockers found! Closing this task now as Resolved. [18:35:53] Wikimedia-Fundraising-Banners: M Lg - https://phabricator.wikimedia.org/T269012 (jbolorinos-ctr) ✅ Monthly convert appears for Paypal pre-payment ✅ Monthly convert does NOT appear for Visa pre-payment ✅ Monthly convert does NOT appear for Amazon pre-payment Status: ✅ PASS Environment: mediawiki-CN ext OS: A... [18:36:36] Wikimedia-Fundraising-Banners: M Lg - https://phabricator.wikimedia.org/T269012 (jbolorinos-ctr) Open→Resolved No blockers found. Closing task now as Resolved. [18:36:38] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (jbolorinos-ctr) [18:36:49] Wikimedia-Fundraising-Banners: M Sm - https://phabricator.wikimedia.org/T269013 (jbolorinos-ctr) ✅ Monthly convert appears for Paypal pre-payment ✅ Monthly convert does NOT appear for Visa pre-payment ✅ Monthly convert does NOT appear for Amazon pre-payment Status: ✅ PASS Environment: mediawiki-CN ext OS: A... [18:37:06] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (jbolorinos-ctr) [18:37:11] Wikimedia-Fundraising-Banners: M Sm - https://phabricator.wikimedia.org/T269013 (jbolorinos-ctr) Open→Resolved No blockers found. Closing task now as Resolved [18:39:24] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (jbolorinos-ctr) Ok everything looks good here, I'd say these banners are now READY TO TEST! @HNordeenWMF [18:39:30] Wikimedia-Fundraising-Banners: [CANDIDATE] Other Amount Banners for Nov. 30 Launch - https://phabricator.wikimedia.org/T268503 (jbolorinos-ctr) Open→Resolved [18:58:35] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Set up process control - https://phabricator.wikimedia.org/T268685 (AndyRussG) > I feel like the only objection at the moment to not building application-specific images (by which we'd avoid all the issues I'v... [20:37:43] Wikimedia-Fundraising-Banners: [CANDIDATE] Mobile Small w/ RML options in fixed element - https://phabricator.wikimedia.org/T269040 (spatton) [20:49:54] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Patch-For-Review: Docker dev setup: Minor improvements and doc following initial feedback - https://phabricator.wikimedia.org/T268954 (DStrine) [20:50:13] Wikimedia-Fundraising-Banners, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): 2020 English fundraising messages in Android app - https://phabricator.wikimedia.org/T266289 (Pcoombe) Thanks. We have donations coming in too! [20:50:24] Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint We all meet again, Fundraising-Backlog, Android-app-Bugs, and 6 others: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (MattCleinman) @CDanis - No rush on making these changes. We have... [20:51:05] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run away queries ->fail mail - https://phabricator.wikimedia.org/T268793 (DStrine) [20:52:54] Wikimedia-Fundraising-Banners: [CANDIDATE] Mobile Small w/ RML options in fixed element - https://phabricator.wikimedia.org/T269040 (jbolorinos-ctr) Getting started on these now, will let you know if anything comes up! [20:53:44] Wikimedia-Fundraising-Banners, Wikipedia-iOS-App-Backlog, iOS-app-Bonefish-On-A-Balloon: 2020 English fundraising messages in iOS app - https://phabricator.wikimedia.org/T266290 (Pcoombe) Just confirming that we have donations streaming in from this and all looks good. Thanks! [20:59:14] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run away queries ->fail mail - https://phabricator.wikimedia.org/T268793 (Eileenmcnaughton) @MDemosWMF @RLewis - yes it's the 'contributions & their related soft credits' causing issues - what are you hoping to fin... [21:05:20] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run away queries ->fail mail - https://phabricator.wikimedia.org/T268793 (MDemosWMF) @Eileenmcnaughton @RLewis Got it! As I searched for the gift and it wasn't popping up, I was trying a few different things and th... [21:06:20] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run away queries ->fail mail - https://phabricator.wikimedia.org/T268793 (Eileenmcnaughton) OK - @rlewis also triggered the same query - so I wondered if there is something you are missing to help you [21:11:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can we speed up thank you query? - https://phabricator.wikimedia.org/T269043 (Eileenmcnaughton) [21:20:57] fr-tech I just pushed up the process-control change for review [21:21:34] lmk if it looks reasonable [21:27:45] looking ejegg [21:32:41] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run away queries ->fail mail - https://phabricator.wikimedia.org/T268793 (RLewis) @Eileenmcnaughton sorry Eileen I was looking to find the names of our DAFs to provide a guide to Melanie and Engage staff and was lo... [21:34:23] ejegg: do those dashes before the commands mean something? [21:35:56] or because its more than one line now [21:35:56] cstone it's just yaml formatting [21:35:57] ? [21:36:01] the dashes make it an array [21:36:03] hah ok yeah trying to read the docmentation [21:36:04] ok [21:36:08] then looks good [21:36:14] cool cool! [21:36:26] anyone else want to weigh in fr-tech? [21:36:50] i can look ejegg [21:37:01] thanks mepps [21:38:31] meanwhile i'll peek at the logs to see just how much leeway we need to leave in the in-civi time limit to make sure they don't run over [21:38:57] ejegg how come queue consume will only run 2-59 now instead of 0-59? [21:39:53] mepps we want it to start on the same minutes as the ty mail sender now [21:40:14] and since it was only running every 3 minutes, it would have been more accurate to say 0-57 previously actually [21:40:24] that makes sense ejegg but could we also jsut have ty mail send start at 0? [21:40:27] ah okay [21:40:34] either way then it's probably fine [21:40:43] the settings look good to me [21:40:57] actually, yeah, we would end up with simpler cron lines if we started it all at 0 [21:41:29] i was just lazy about changing the interleaved lines for the two mxes [21:41:39] ejegg that's fair [21:41:40] but those could be rewritten [21:41:56] how come the thank you mailer isn't 2-59/6 ? [21:42:07] yah exactly [21:42:32] they did a gradual transition from the non-smtp one running all but 2 runs in an hour [21:42:38] to the smtp ones running all of them [21:42:43] i'm okay signing off as is, just might be worth adjusting before too long [21:42:45] ah okay ejegg [21:42:48] that makes sense [21:43:00] and the way they did that was to specifically more a couple runs at a time [21:43:11] but let's be forward thinking! [21:43:38] hmm hmm, there are a bunch of other jobs that run on the hour [21:44:05] I wonder if having the qc start at 2 minutes past might be slightly better for avoiding load spikes? [21:44:07] ejegg if we leave it as is, maybe just a note in the docs? [21:44:14] i mean comment [21:44:32] so someone else doesn't come along with the same questions :) [21:44:53] I'll simplify the cron lines for the mxes now [21:46:06] yeah. those cron lines are left from when we were phasing it in. [21:47:09] do we actually capture the thank you query running - I haven't seen if fly by in show processlist so far [21:47:40] I just wanted to run it & check how long it actually does take & was hoping to use a wild version [21:50:07] I've seen a couple of 'ROLLBACK TO SAVEPOINT' queries on the drupal DB which feels a bit odd [21:51:46] eileen: you can get an idea of the timing from the process-control log [21:51:55] ejegg: ah OK [21:52:40] mepps I just pushed up that cron line cleanup [21:52:44] for review [21:53:45] and looking at the mail logs, it's taking about 2:30 per run on each mx. during low volume times it's done in under a minute. [21:54:02] yep, that 2:30 is the hard limit we give it in Civi [21:54:14] I think we can actually extend that to 2:50 though [21:54:36] once we put this process-control change through [21:54:42] the mail hosts are not stressed at all. so whatever works on the civi side is good. [21:54:49] great [21:55:49] frmx1001 sees a higher volume than frmx2001 most likely due to the added overhead/latency of being halfway across the country. [21:56:28] eileen: i bet you've sussed it out, but in case this saves you time, the query is between the "Attempting to send X thank you mails" line and the first "Attempting to send thank you mail for contribution ID Y" lines [21:56:53] ejegg: thx [22:08:48] ok fr-tech I'm going to push out those job timing changes [22:13:41] !log extended and re-synchronized timing of thank you mail sender and donation queue consumer [22:13:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:27:15] Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint We all meet again, Fundraising-Backlog, Android-app-Bugs, and 6 others: Deal with donatewiki Thank You page launching in apps - https://phabricator.wikimedia.org/T259312 (CDanis) https://thankyou.wikipedia.org/.well-known/apple-app-sit... [22:27:28] cool, with the extra time the TY mail sender is now getting through the whole batch it's selecting at the start [22:27:50] with like 18 seconds to spare before the next run [22:27:58] I just increased that limit by 100 [22:33:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can we speed up thank you query? - https://phabricator.wikimedia.org/T269043 (Eileenmcnaughton) OK - looking at this the main thing affecting query speed is the 'thank_you_days' variable - we can reduce from 5.6 sec to 0.4 sec by reducing down to 2 days... [22:34:12] ejegg: so my take on the query is here https://phabricator.wikimedia.org/T269043#6657557 [22:37:46] ejegg: nice. [22:38:03] interesting eileen [22:38:37] so that makes sense, run routinely with 2 days and then once an hour with the longer range for import / audit stuffs [22:38:45] they've waited more than 2 days, what's another hour [22:39:21] yep [22:39:32] just looking at making days a drush option [22:39:44] I guess it makes sense to add batch too [22:40:25] & time limit [22:42:03] ejegg: also - that query is only 5.7 sec now - with 60 days - but that will get slower & slower over BE if we leave it at 60 days [22:42:14] right [22:42:54] yeah, I think putting the batch size on the drush command line has been a todo forever [23:23:32] My emoji fix is merged upstream https://github.com/civicrm/civicrm-core/pull/18918 - we can port that in if we see more 🦉 related failmail [23:25:33] 😎 [23:30:21] eileen: there was one an hour ago with 🏈🏀⚽ in the last name [23:30:33] what a good sport [23:38:46] (PS1) Eileen: Add batch limit options to thank you job [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/644359 (https://phabricator.wikimedia.org/T269043) [23:39:39] ejegg: that adds the 3 options as drush input params ^^ [23:41:05] sigh - power cut at school means the non ransomware installing son has just been returned home [23:41:50] good on no ransomware, bad on power cut. [23:44:37] thanks eileen [23:44:41] yeah - it seems the school ran our of water as a result since it's on tank water & pumps are involved [23:47:24] ah apparently they put up with no power for 1.5 hours before sending them home [23:49:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Can we speed up thank you query? - https://phabricator.wikimedia.org/T269043 (Eileenmcnaughton) Just noting that if we do nothing the query will slow down over BE as the number of contributions in the catchment range grows