[00:00:13] ok let's try [00:00:33] we'll see if any jobs fall over - trying now.... [00:06:22] looks like the ~35min backlog cleared in about 10-15 mins depending on which metric you look at. [00:10:13] so I'm running the other job concurrently [00:11:48] I'm starting to think that running it less but fairly soon after silverpop export is better in general [00:12:21] because I think it might do some wasteful processing otherwise - not quite sure yet but [00:13:20] hmm - it's churning through the file - which is fine [00:15:09] ok - it failed on a time out [00:15:23] so I'll go back to worrying about that for a bit... [00:15:42] there is definitely an increase in questions and row locks on the db. but i think that is all expected. [00:16:10] you can see it by scrolling through: https://frmon.frdev.wikimedia.org/d/000000273/mariadb?orgId=1 [00:18:48] i don't think it's anything horrible from the db side, but the increase of row locks makes me a little hesitant that other things may be affected by the locks. [00:20:17] yeah - it's stopped now so we are back to normal for now [00:22:05] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog: Turn off failmail for silverpop timeouts. - https://phabricator.wikimedia.org/T226747 (Eileenmcnaughton) OK I have caught an error & updated the PR / test https://github.com/mrmarkfrench/silverpop-php-connector/pull/34 But am having some trouble w... [00:22:40] I feel like I have the right patch for the time out - but my php tests are now having issues locally so having to dig into that.... [00:23:09] cool. shows promise at least. [00:25:23] yeah - just some annoying stuff with docker + phpunit + debug not working which was earlier. [00:25:30] anyway gonna get some lunch [01:17:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Monthly convert donations failing to get to Civi with email error message - https://phabricator.wikimedia.org/T269643 (Ejegg) [01:59:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Stop sending failmail when inserting second subscr_signup message - https://phabricator.wikimedia.org/T269646 (Ejegg) [02:03:52] (PS1) Ejegg: Use non-deprecated search to find existing recur row [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646885 (https://phabricator.wikimedia.org/T269646) [02:21:54] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog: Resolve failmail from session time outs - https://phabricator.wikimedia.org/T226747 (Eileenmcnaughton) [02:22:10] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog: Resolve failmail from session time outs - https://phabricator.wikimedia.org/T226747 (Eileenmcnaughton) [02:30:48] !log deployed queue consumers for new Adyen capture jobs [02:30:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:43:02] (CR) Eileen: [C: +2] "Looking at the code it's pretty clear that this is the preferred function and that it will still do what the other did. The only way it co" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646885 (https://phabricator.wikimedia.org/T269646) (owner: Ejegg) [03:58:48] (Merged) jenkins-bot: Use non-deprecated search to find existing recur row [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646885 (https://phabricator.wikimedia.org/T269646) (owner: Ejegg) [04:03:46] (PS1) Eileen: Make it easy to run tests on the silverpop connector package we use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646894 [04:03:48] (PS1) Eileen: Add updated silverpop connector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646895 (https://phabricator.wikimedia.org/T226747) [06:46:44] (PS2) Eileen: Make it easy to run tests on the silverpop connector package we use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646894 [06:46:46] (PS2) Eileen: Add updated silverpop connector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646895 (https://phabricator.wikimedia.org/T226747) [06:49:25] (PS1) Eileen: silverpop connector update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/646901 (https://phabricator.wikimedia.org/T226747) [07:03:41] (CR) jerkins-bot: [V: -1] Add updated silverpop connector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646895 (https://phabricator.wikimedia.org/T226747) (owner: Eileen) [08:08:53] (PS28) AndyRussG: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [08:12:55] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [08:52:23] (PS5) AndyRussG: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [08:55:54] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [11:06:32] fr-tch, eyener: is superset loading for you? I'm getting timeouts [11:06:58] fr-tech* [11:13:23] hmmm I'm curious why the recurring queue is so big [11:57:44] jgleeson sorry for the delay. I changed some schedules around so I could add some email cube runs to the queue as emails are going out again. Looks like one of the cubes got stuck, not sure why [11:58:16] just killed the query and things are clearing up. Unfortunately that means I'll have to rerun some of the cubes which does take a while [12:07:20] I think I know where the problem is. not sure I'll be able to fix it fully during en6C but I can do a partial fix and look into it more as things slow down [12:27:55] fr-tech it looks like we're running the recurring queue consumer job every 20 minutes and it's processing around 600-750 messages at its peak. New messages are being added to the queue at a faster rate than they are being processed, but they are being processed. [12:28:06] ah ok thanks eyener ! [12:33:47] fr-tech, looks like this traffic is related to 'enGB, Email 3, round 2' which kicked off at 10:00 AM GMT [13:40:45] jgleeson: are those recurrings maybe still coming in from the nightly charge job? [13:43:55] ok, looks like the last run might have gotten to the end of those due today [13:44:15] https://frmon.frdev.wikimedia.org/d/Pq1YNMviz/fundraising-overview?viewPanel=35&from=now-6h&orgId=1&refresh=1m&to=now [13:45:25] that panel shows 700+ per run till the one that finished at 12:27 utc which had 245 [13:47:05] oh I see ejegg [13:47:51] just checking the silverpop export re Mariana's email [13:48:19] thanks! [13:48:41] I'll take a look too I guess just to stay current [13:51:05] huh, build file job worked [13:51:19] yeah [13:51:20] as did upload [15:26:22] so i took a peek at the RML import logs [15:26:33] looks like we're getting the session timeout pretty consistently [15:26:44] but that we're still loading around 6000 per run [15:29:41] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, FR-Adyen: Process Adyen IPN messages in parallel (improve TY delivery times) - https://phabricator.wikimedia.org/T233251 (Ejegg) Config is deployed! [15:31:03] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Turn off import of RML during peak load - https://phabricator.wikimedia.org/T269185 (Ejegg) Looks like we pulled in 147,978 contact over today's run. Should be caught up after tomorrow's! [15:46:21] urg my phpstorm froze :( [15:52:36] fixed it [16:11:36] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Turn off import of RML during peak load - https://phabricator.wikimedia.org/T269185 (MBeat33) Great news, thank you @Ejegg [16:29:42] fr-tech my internet is a little spotty where i am not [16:29:45] *now [16:30:19] does anyone want to attend the scrum of scrums in 5 minutes? [16:30:43] hmm, maybe I can actually do it just with no video [16:30:53] anyway, anything to share in the notes there fr-tech? [16:33:20] oh wow, I somehow thought it was wednesday - never mind about scrum of scrums fr-tech! [16:39:41] Heh, happens to me all the time lately [16:39:48] Pandemic blursday [17:01:21] (PS1) Ejegg: Fix out-of-bounds Adyen queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/647022 [17:04:06] (CR) Jgleeson: [C: +2] Fix out-of-bounds Adyen queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/647022 (owner: Ejegg) [17:04:48] (Merged) jenkins-bot: Fix out-of-bounds Adyen queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/647022 (owner: Ejegg) [17:35:25] (PS1) Ejegg: Heuristic for skipping Adyen/Amex/recur failmail [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/647026 [17:35:28] jgleeson: thanks for the CR! [17:35:46] that next one ^^^ is a possible solution to the amex failmail [17:35:52] but I'm not thrilled with it [17:36:01] basically we keep sending the capture job to the queue [17:37:03] but then if we don't find donor details, skip the complaint [17:37:21] ejegg: I asked a question in relation to that a little earlier [17:37:34] should we be looking for pending data on recurring charges? [17:37:51] so no, we shouldn't [17:38:21] but it's hard to tell the recurring Amex charges from one-time Amex charges [17:38:33] in fact, it seems impossible from the IPNs [17:38:38] ah [17:38:44] ok now I see the issue [17:38:57] that isRecurring check that lives in the job somewhere is sending them through as normal donations [17:39:32] nice catch on the amex method! [17:39:45] Yah, if we can tell that it's DEFINITELY a recurring charge, we can decide right when we get the message not to send the capture job [17:40:07] thanks to cstone for figuring out that it was amex-specific! [17:40:19] kudos much cstone ! [17:40:21] i think another card had issues [17:40:24] let me check real quick [17:41:04] So i wrote my doubts about this heuristic in the commit message there https://gerrit.wikimedia.org/r/647026 [17:41:20] ejegg: cstone we had 53 unique adyen errors relating to that failmail when I checked earlier today [17:41:22] it would be great to be able to do at least one retry [17:41:29] ejegg: discover too [17:41:37] ooh, thanks cstone [17:41:46] that was filtered down from like 258 errors [17:42:01] https://phabricator.wikimedia.org/T255303 [17:42:02] jeez, still a lot of errors [17:42:36] cstone so can you see ANYTHING on those IPNs to help tell them apart? [17:42:53] there wasnt last time i looked which was frustrating [17:43:18] so I have a bunch of the IPNs logged of the affected donations [17:43:37] it's the authorize request right? [17:43:44] that we are checking [17:44:02] hmm I forget lemme check [17:44:10] So maybe for next year we can look at appending or prepending 'R' to the merchant reference / invoice ID when we are working with recurring installments [17:44:24] I forget if we can use letters in the order id for ingenico [17:44:34] ok so it's in the PaymentCaptureAction [17:45:32] yah, the IPNs would be the ones with eventCode AUTHORISATION [17:49:21] (PS2) Ejegg: Heuristic for skipping Adyen/Amex/recur failmail [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/647026 (https://phabricator.wikimedia.org/T255303) [17:49:54] (CR) jerkins-bot: [V: -1] Heuristic for skipping Adyen/Amex/recur failmail [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/647026 (https://phabricator.wikimedia.org/T255303) (owner: Ejegg) [17:59:43] (PS3) Ejegg: Heuristic for skipping Adyen/Amex/recur failmail [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/647026 (https://phabricator.wikimedia.org/T255303) [18:00:09] ejegg: we increment the sequence on each payment attempt right (on the paymentswiki side) [18:00:23] yeah jgleeson [18:00:37] ah you added it in the cmt msg [18:00:45] I was just reading the code [18:01:08] Hmm, so we mostly do that when an API setup call to the processor fails [18:01:20] and for Adyen we don't do API calls to set up [18:01:31] we just sign a thing for the browser to post [18:01:32] or validation fails [18:01:41] oh right, like for our own fraud filters [18:01:43] so yeah [18:01:54] I was trying to see if I could add a check on the enqueued age [18:02:33] like make the logic from BaseQueueConsumer which decides whether to retry later vs send-to-damaged-table-and-send-failmail [18:02:42] make that logic accessible to the job [18:03:01] oh no actually we don't increment if validation fails, the method returns early [18:03:14] so the job can decide to skip throwing that exception, only when it knows the exception handler will send a failmail [18:03:17] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/55f523df14adb1d199674c729a01979700f4bc5f/adyen_gateway/adyen.adapter.php#L191-L190 [18:03:18] Wikimedia-Fundraising-Banners: [CANDIDATE] Desktop small fixed element with RML - https://phabricator.wikimedia.org/T269454 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z783c5aac7e1d8ed6bfa [18:03:38] but inside the job we don't have access to the source_enqueued_time as far as I can tell [18:03:45] ah [18:03:56] I gotta go eat, back later [18:04:02] bon apetit! [18:07:29] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647033 [18:07:47] ejegg: is your civi fix in the above^ ok to deploy ? [18:11:46] i think so cstone, just taking one last look [18:12:34] oh yeah, that newer check is strictly better than the deprecated check [18:12:39] deploy away, cstone [18:12:44] ok thanks ejegg ! [18:13:59] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647033 (owner: Cstone) [18:14:12] hmm, maybe I'll put that heuristic patch in WIP [18:21:31] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Stop sending failmail when inserting second subscr_signup message - https://phabricator.wikimedia.org/T269646 (Ejegg) [18:22:23] (CR) Cstone: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647033 (owner: Cstone) [18:26:27] !log civicrm revision changed from b0ffb87c5d to 7d4b71d8b5 [18:26:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:52:37] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [18:53:44] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [19:00:01] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Turn off import of RML during peak load - https://phabricator.wikimedia.org/T269185 (MSuijkerbuijk_WMF) That's great @Ejegg [19:03:01] (PS3) Eileen: Add updated silverpop connector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646895 (https://phabricator.wikimedia.org/T226747) [19:04:55] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (AndyRussG) [19:07:48] (PS1) Eileen: Make it easy to run tests on the silverpop connector package we use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647042 [19:11:14] I am pretty sure I'm there with the silverpop stuff - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/646895 - the repo owner already merged it so it's just a composer update [19:12:17] it was failing tests - but only because I tried to do something really ambitious & it actually passed the tests but failed in the cleanup - so I took the vendor tests back out but kept https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/647042 (as a separate PR) [19:14:47] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Stop sending failmail when inserting second subscr_signup message - https://phabricator.wikimedia.org/T269646 (Eileenmcnaughton) @Ejegg does the patch I reviewed move this into Pending Depl... [19:51:10] Fundraising-Backlog, Fr-endowment, Recurring-Donations: Review and close loophole allowing recurring Endowment gifts - https://phabricator.wikimedia.org/T269455 (AParker) I just noticed a new recurring endowment donation come in from today's appeal. CID 6625822. He used to have a recurring AF donati... [19:54:42] Fundraising-Backlog, Fr-endowment, Recurring-Donations: Review and close loophole allowing recurring Endowment gifts - https://phabricator.wikimedia.org/T269455 (DStrine) Thanks @AParker! The only way I can think of this happening is that the user has edited the URL on their own. As we saw in the sta... [20:08:26] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, FR-Smashpig: Adyen listener sending ProcessCaptureRequestJob for some recurring donations - https://phabricator.wikimedia.org/T268654 (DStrine) Open→Resolved [20:09:02] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Run away queries ->fail mail - https://phabricator.wikimedia.org/T268793 (DStrine) Open→Resolved [20:10:06] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, FR-Adyen: Process Adyen IPN messages in parallel (improve TY delivery times) - https://phabricator.wikimedia.org/T233251 (DStrine) Open→Resolved [20:14:27] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Monitor the return of RML import in December - https://phabricator.wikimedia.org/T269185 (DStrine) [20:14:54] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog: Is rsyslog dropping messages that audit processor needs? - https://phabricator.wikimedia.org/T269269 (DStrine) Open→Resolved [20:16:46] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can we speed up thank you query? - https://phabricator.wikimedia.org/T269043 (DStrine) Open→Resolved [20:16:47] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/647052 [20:18:26] Fundraising Sprint We all meet again, Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog: Add 'Stock Information' field to thank you letter - https://phabricator.wikimedia.org/T268081 (DStrine) @LeanneS this looks to be done to your liking. Please let us know what you think. [20:20:49] Wikimedia-Fundraising-Banners: [CANDIDATE] Desktop small fixed element with RML - https://phabricator.wikimedia.org/T269454 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr @spatton signing off on QA for these now, no blockers found. The one nit-pick I would point out is when a user clicks on the... [20:37:25] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/647052 (owner: Ejegg) [20:37:59] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/647052 (owner: Ejegg) [20:41:24] !log updated standalone SmashPig listener from e3103b96ca to 5a69abd40f [20:41:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:01:04] Fundraising Sprint We all meet again, Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog: Add 'Stock Information' field to thank you letter - https://phabricator.wikimedia.org/T268081 (LeanneS) @DStrine Thanks! I just reviewed and it looks like we're almost set, but the whole tax exempt section w... [21:04:32] Fundraising-Backlog, fr-donorservices, FR-Email: Copy edits for end of year email (aka yearly receipt or yearly TY email) - https://phabricator.wikimedia.org/T268768 (DStrine) [21:05:17] Fundraising Sprint Xtreme Lolcats, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [21:06:04] Fundraising-Backlog: Outdated Paypal rule contributing to declines - https://phabricator.wikimedia.org/T269611 (EMartin) I just heard back from Paypal. The rules team advise that it looks like option #2 is being implemented on December 17th with the expectation of going live on December 20th. They are in th... [21:12:10] Fundraising-Backlog: Docker dev setup: Fundraising tools - https://phabricator.wikimedia.org/T269708 (AndyRussG) [21:14:09] Fundraising-Backlog: Docker dev setup: Fundraising tools > silverpop export - https://phabricator.wikimedia.org/T269708 (jgleeson) [21:18:35] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Y 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Stop sending failmail when inserting second subscr_signup message - https://phabricator.wikimedia.org/T269646 (DStrine) [21:18:37] Fundraising Sprint Y 2020, Fundraising-Backlog: Docker dev setup: Fundraising tools > silverpop export - https://phabricator.wikimedia.org/T269708 (DStrine) [21:18:39] Fundraising Sprint Y 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Monthly convert donations failing to get to Civi with email error message - https://phabricator.wikimedia.org/T269643 (DStrine) [21:18:41] Fundraising Sprint Y 2020, Fundraising-Backlog, fr-donorservices, FR-Email: Copy edits for end of year email (aka yearly receipt or yearly TY email) - https://phabricator.wikimedia.org/T268768 (DStrine) [21:18:45] Fundraising Sprint We all meet again, Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Y 2020, Fundraising-Backlog: Add 'Stock Information' field to thank you letter - https://phabricator.wikimedia.org/T268081 (DStrine) [21:18:47] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Y 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Monitor the return of RML import in December - https://phabricator.wikimedia.org/T269185 (DStrine) [21:18:49] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Y 2020, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (DStrine) [21:18:55] Fundraising Sprint Y 2020, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (DStrine) [21:18:57] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Y 2020, Fundraising-Backlog, Patch-For-Review: Resolve failmail from session time outs - https://phabricator.wikimedia.org/T226747 (DStrine) [21:18:59] Fundraising Sprint Octopus hugs, Fundraising Sprint Pseudopretzels, Fundraising Sprint Raw data never hurt anyone, Fundraising Sprint Upbeat Upholstery, and 7 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (DStrine) [21:19:03] Fundraising Sprint Y 2020, Fundraising-Backlog, Patch-For-Review: Get civi working on docker - https://phabricator.wikimedia.org/T262975 (DStrine) [21:39:21] fr-tech, 'odd radio circles' :) https://www.bbc.co.uk/news/av/55212727 [21:39:32] aka [21:39:33] ORCs [21:39:37] in space [21:40:38] oh also fr-tech, I forgot to mention this! https://www.projectnorthmoor.org/ [21:40:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Matching Gifts: Add fields to all_wikimedia from SSI database - https://phabricator.wikimedia.org/T269294 (Ejegg) Implementation note for the Civi side - it should be possible to just add these in to silverpop_export_view_full by joining s... [21:40:53] Fundraising Sprint We all meet again, Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: Add 'Stock Information' field to thank you letter - https://phabricator.wikimedia.org/T268081 (DStrine) @Cstone and @LeanneS can the two of you... [21:43:48] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: Efficiency of querying views - https://phabricator.wikimedia.org/T259731 (Jgreen) I took a look at how the online_goal_tracking_FY2021 view is created and use. I'm not super familiar with mysql views but based on some reading my first thou... [21:43:57] jgleeson: cool!!!! [21:52:01] (PS1) Cstone: Add donation record line back in for stock thank yous. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647062 [21:52:02] hey AndyRussG i'm rethinking rename db field not_campaign_type to be more clear ("campaign_type" or "type") [21:52:02] --mostly that if it's renamed "not_type" it was probably be clear enough, given the constraints of the current db naming schema [21:52:10] but i think dropping campaign will kind of help [21:52:47] jgleeson: northmoor road is a very nice street to have a house on. [21:52:51] which i suspect is what what you had in mind [21:54:04] for some reason tests are running suuuuper slowly for me [21:54:28] mepps: yeah sounds good, let's keep it consistent! thanks! [21:54:40] mepps huh I haven't tried running the tests [21:55:03] mepps fr-tech I'm actually feeling not great so am gonna lie down for a bit, but might be back in more functional state by tech-talk [21:55:22] sounds good AndyRussG i'm signing off in 5 but i think i'm close on tests [21:55:31] so i'd like to commit that once i can show their passing [21:55:36] mepps yay cool! thanks! [21:55:42] if i can get them to run before kids come home in 5... [21:55:55] If I make more progress this evening I'll also e-mail then, thanks so much eh! [21:57:23] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [22:03:16] dwisehaupt: yeah i figured you might know where that was [22:03:41] the £4.5mln price tag is a give away also right!! [22:04:42] (PS29) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [22:05:04] AndyRussG ^^ tests passed locally so hopefully there (it was a super small fix) [22:08:06] yeah. that's prime north oxford living there. a lot of those houses are huge with large yards and have been converted into b&b's or just homes for very rich folks. [22:08:41] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [22:15:26] mepps: ahh cool beans! [22:25:49] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: on endowment payments page, change ways to give link - https://phabricator.wikimedia.org/T269716 (DStrine) [22:27:11] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: on endowment payments page, change FAQ link - https://phabricator.wikimedia.org/T269717 (DStrine) [22:32:59] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: Efficiency of querying views - https://phabricator.wikimedia.org/T259731 (Jgreen) Open→Resolved p:Triage→Medium [22:38:09] (CR) Jgleeson: [C: +2] "I also got tests passing locally for that version! Nice" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646895 (https://phabricator.wikimedia.org/T226747) (owner: Eileen) [22:38:43] (CR) Jgleeson: [C: +2] "Yeah I had problems working this out when running locally also. This should make life easier!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647042 (owner: Eileen) [22:39:26] have a good rest of yours fr-tech o/ [22:56:24] feel better AndyRussG [23:00:10] (Merged) jenkins-bot: Add updated silverpop connector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646895 (https://phabricator.wikimedia.org/T226747) (owner: Eileen) [23:00:12] (Merged) jenkins-bot: Make it easy to run tests on the silverpop connector package we use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647042 (owner: Eileen) [23:32:49] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [23:37:49] RECOVERY - check_log_messages on frav1002 is OK: OK [23:58:11] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Banner error - https://phabricator.wikimedia.org/T269723 (Jdlrobson)