[00:00:17] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Banner error cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Jdlrobson) [00:00:40] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Banner error cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Jdlrobson) p:Triage→Unbreak! Huge spike in error logs [00:27:49] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [00:32:26] those paypal endpoint alerts are transient and have shown once each on two different hosts. no worries at this point. [00:32:55] RECOVERY - check_log_messages on frav1002 is OK: OK [00:35:24] (PS1) Ejegg: Use hook to change FAQ link for endowment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269717) [00:35:44] (PS2) Ejegg: Sweden form for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644637 (https://phabricator.wikimedia.org/T268647) [00:38:13] (CR) jerkins-bot: [V: -1] Use hook to change FAQ link for endowment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269717) (owner: Ejegg) [00:41:08] (PS30) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [00:44:17] (PS2) Ejegg: Use hook to change FAQ link for endowment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269717) [00:44:37] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [00:54:26] (PS31) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [00:57:02] in terms of next steps AndyRussG do you want to take on asking core team about the user config changes? [00:58:33] we can also figure it out tomorrow depending on how much you plan to work tonight [00:58:44] Uhhh sure, though I'd want to read over that code first, which I haven't done [00:58:44] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [00:59:13] yay passing build!! [00:59:58] mepps: yeah I think I'm kinda out for the evening... Just do slept for 2 hrs, still not feeling great [01:00:08] yay!!!! [01:02:14] ... but pls don't hesitate to dig into whatever next steps u like, of course!! [01:02:52] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [01:05:38] (CR) Eileen: [C: +2] silverpop connector update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/646901 (https://phabricator.wikimedia.org/T226747) (owner: Eileen) [01:06:38] (Abandoned) Eileen: Make it easy to run tests on the silverpop connector package we use [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/646894 (owner: Eileen) [01:06:48] (Abandoned) Eileen: Handle emoji in name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/638734 (https://phabricator.wikimedia.org/T267171) (owner: Eileen) [01:07:56] RECOVERY - check_log_messages on frav1002 is OK: OK [01:12:25] (PS3) Ejegg: Use hook to change FAQ link for endowment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269717) [01:22:32] (Merged) jenkins-bot: silverpop connector update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/646901 (https://phabricator.wikimedia.org/T226747) (owner: Eileen) [01:32:58] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [01:37:58] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [01:42:52] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [01:45:34] these endpoint alerts are still transient. rotating among hosts but not an actual outage. [01:46:03] they are manifesting as timeouts. [01:47:42] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [01:52:52] RECOVERY - check_log_messages on frav1002 is OK: OK [02:42:58] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [02:47:52] RECOVERY - check_log_messages on frav1002 is OK: OK [02:57:09] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Jdlrobson) [02:59:14] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (AndyRussG) [05:48:47] (PS6) AndyRussG: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [05:50:29] (PS7) AndyRussG: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [05:54:36] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [05:56:07] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647130 [05:56:26] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647130 (owner: Eileen) [06:14:06] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (AndyRussG) [06:30:00] (CR) AndyRussG: Campaign filtering (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [11:18:32] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Pcoombe) This was due to the banner [CommunityWishlistVote_Mobile](https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/CommunityWishlistVote_... [11:57:21] fundraising-tech-ops, Operations, netops: Manage frack switches with Netbox - https://phabricator.wikimedia.org/T268802 (jbond) p:Triage→Medium [12:43:51] (PS4) Ejegg: Use hook to change FAQ link for endowment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269717) [12:45:08] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: Docker dev setup: Fundraising tools > silverpop export - https://phabricator.wikimedia.org/T269708 (jgleeson) a:jgleeson [13:08:18] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Pcoombe) Open→Resolved a:Pcoombe No more logstash errors since the fix, closing this. [13:26:33] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Trizek-WMF) Thank you for fixing this! [13:47:17] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Ramtin0071) Resolved→Open p:Unbreak!→High [13:50:52] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Ramtin0071) Open→Resolved a:Pcoombe→Alexia [14:13:08] Fundraising-Backlog, fundraising-tech-ops, observability, Epic: Create Grafana dashboard for Online Fundraising to monitor live campaigns - https://phabricator.wikimedia.org/T256916 (Jgreen) Open→Declined p:Triage→Medium Superset will be a better candidate for this kind of dashboa... [14:13:10] fundraising-tech-ops, observability, Epic: [Epic] overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508 (Jgreen) [14:20:34] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (DannyS712) Resolved→Open [14:20:41] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Pcoombe) a:Alexia→Pcoombe [14:20:51] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (DannyS712) p:High→Unbreak! [14:21:33] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (DannyS712) ...oh wait, it was resolved before they reopened it, sorry [14:21:46] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (DannyS712) Resolved→Open [14:21:51] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (DannyS712) Open→Resolved [14:35:19] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Jdlrobson) @pcoombe thanks for the fix! is there a way we can change the banner process for deploying banners to make sure logstash is checked for new er... [15:09:14] (PS8) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [15:09:25] Wikimedia-Fundraising-Banners, Wikimedia-production-error: Uncaught ReferenceError: cbnnr is not defined - https://phabricator.wikimedia.org/T269723 (Trizek-WMF) @Jdlrobson, are you volunteering to transform the JS hack we use into a CentralNotice feature? :) {T269758} [15:09:34] okay that made tests pass locally [15:09:40] fingers crossed it works upstream [15:13:27] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [15:13:42] okay that's not tests at least [15:18:46] (PS9) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [15:23:33] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [15:24:30] hi fr-tech! [15:25:11] hi ejegg! [15:26:01] hi ejegg [15:26:19] fr-tech I just moved out standup ahead of the big english standup as they were on top of each other [15:26:32] on my cal [15:26:45] thanks jgleeson [15:26:51] and hi mepps! [15:37:55] (PS32) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [15:39:11] Fundraising-Backlog, FR-Adyen: Info for moving Adyen off of IFrame and onto Hosted Payment Page - https://phabricator.wikimedia.org/T252713 (EMartin) Putting this piece of info here follow up a call that DS and Elliott had with Adyen since it is impactful to our consideration on which upgrade approach to... [15:41:29] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [15:42:19] ejegg fr-tech jgleeson mepps and hellooooo here too eh! [15:43:17] howdy AndyRussG :) [15:43:54] (PS1) Ejegg: Change logo in a hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647266 (https://phabricator.wikimedia.org/T269717) [15:44:31] hi AndyRussG [15:44:46] jgleeson ejegg :) [15:51:59] (PS33) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [15:52:01] (PS10) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [15:57:04] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [15:57:19] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [15:59:51] fr-tech any news to share with scrum of scrums? [15:59:58] (PS34) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:00:10] AndyRussG ejegg maybe the user config changes? [16:01:13] (PS35) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:01:22] mepps ejegg uhhhh maybe? I dunno if this feels like slowing things down, mepps, but I don't feel right about asking for feedback elsewhere on the config changes until we've reviewed them first [16:01:44] as in, let's get them as good as we think we can get them, and then ask someone who knows that code well to double-check? [16:01:48] ejegg can just say we're plannign to ask for feedback [16:01:57] kinda as a courtesy to whomever we're asking [16:02:01] just so they know it's coming AndyRussG [16:02:08] mepps ejegg yes that sounds right [16:02:09] we don't have to say we're doing it right now [16:02:33] mepps ok yes cool [16:04:36] AndyRussG should this be in the commit: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/604279/28/i18n/qqq.json.orig [16:05:21] mepps: ahhh no oops, did I send that? [16:05:31] it looks like it AndyRussG [16:06:30] ok, will add a note about that. thanks! [16:06:30] mepps: ahhhh sorry about that! yeah that's a remnant from git mergetool thing [16:07:01] no worries AndyRussG just trying to track down these test failures--i must have committed something funky [16:07:19] mepps ah cool, yeah thanks much for noticing it [16:07:35] mepps also apologies I have to run to the bank machine quickly, back at the keyboard in like 45 min or so [16:07:49] no worries at all AndyRussG [16:10:04] this not_type change seems to break everything.. [16:10:19] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:11:15] i'm stumped as to why though... [16:11:23] i can just revert the change for now [16:13:33] (PS36) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:13:33] mepps I think it's ok also to leave tests broken on the patch meanwhile if you like :) [16:13:55] i pushed up the old one with tests passing but i have the broken one saved locally [16:14:04] i'm wondering if it's worth it to investigage [16:14:08] i'm wondering if it's worth it to investigate [16:15:23] oops [16:15:37] mepps: hmmm well I think we do need to change the db field name [16:16:23] okay i can look more closely at these test failures locally [16:18:44] ejegg AndyRussG is there a way to suppress all these logs in phpunit results? it's very noisy [16:19:27] under Mediawiki mepps? [16:19:48] yeah ejegg [16:19:50] let's see, I don't think we added extra log output like we had in CRM for a while... [16:20:04] mepps you mean on CI [16:20:07] ? [16:20:11] (back in a bit!) [16:20:15] it's also doing it locally AndyRussG ejegg [16:21:23] should those patches have a Bug: tag on them associating them with a phab? [16:25:58] mepps is there a phab for the actual feature of Campaign Filtering? [16:26:08] or just for the review & release management? [16:26:14] https://phabricator.wikimedia.org/T268646 [16:26:29] i'm not sure about the actual filter ejegg but that's what i'm working form [16:26:30] from [16:26:41] probably ejegg--i'm coming into this late [16:27:14] ok [16:28:09] i'm totally scratching my head over these test failurs [16:28:29] it's because i changed a column name and for some reason the tests are still looking at the old column name [16:28:45] and i can't find any reference to that in the code [16:29:03] i changed the db locally and my understand in CI is that it rebuilds the box each time [16:29:33] (PS2) Ejegg: Change logo in a hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647266 (https://phabricator.wikimedia.org/T269717) [16:29:35] (PS1) Ejegg: Move Endowment-related MonthlyConvert logic into hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647276 (https://phabricator.wikimedia.org/T269717) [16:30:06] okay i found a place to debu [16:33:53] ooh i think i found it :) [16:41:30] (PS37) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:42:07] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [16:44:25] (PS38) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:44:27] (PS11) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [16:49:18] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [16:49:20] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:51:29] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Stop sending failmail when inserting second subscr_signup message - https://phabricator.wikimedia.org/T269646 (DStrine) p:T... [16:51:30] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations: Monthly convert donations failing to get to Civi with email error message - https://phabricator.wikimedia.org/T269643 (DStrine) p:Triage→Medium [16:51:41] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, fr-donorservices, FR-Email: Copy edits for end of year email (aka yearly receipt or yearly TY email) - https://phabricator.wikimedia.org/T268768 (DStrine) p:Triage→High [16:51:52] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Patch-For-Review: on endowment payments page, change ways to give link - https://phabricator.wikimedia.org/T269716 (DStrine) p:Triage→High [16:51:59] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: Docker dev setup: Fundraising tools > silverpop export - https://phabricator.wikimedia.org/T269708 (DStrine) p:Triage→Medium [16:52:02] (PS5) Ejegg: Use hook to change footer links for endowment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269716) [16:52:09] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Patch-For-Review: on endowment payments page, change FAQ link - https://phabricator.wikimedia.org/T269717 (DStrine) p:Triage→High [16:52:59] (PS3) Ejegg: Change logo in a hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647266 (https://phabricator.wikimedia.org/T269717) [16:53:36] (PS2) Ejegg: Move Endowment-related MonthlyConvert logic into hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647276 (https://phabricator.wikimedia.org/T269717) [16:54:00] fr-tech: cstone and I discussed moving all the endowment-related customizations into hooks in last night's tech talk [16:54:21] those three patches ^^^ should implement it. What do folks think? [16:55:00] in related news, I got an email asking for help setting up DonationInterface to receive paypal donations & had to explain that it's tricky & we're busy [16:55:24] but kinda cool that someone else wants to use our code [17:10:44] Wikimedia-Fundraising-Banners: [CANDIDATE] New Desktop Small fixed design - https://phabricator.wikimedia.org/T269779 (spatton) [17:10:51] Wikimedia-Fundraising-Banners: [CANDIDATE] New Desktop Small fixed design - https://phabricator.wikimedia.org/T269779 (spatton) p:Triage→High [17:14:48] that's cool ejegg ! [17:15:10] thanks jgleeson! [17:15:22] the donation interface bit [17:15:51] I was knocking around a bit trying to find a better way to do the logo [17:16:13] sorry ejegg I meant the email about donation interface and setting up paypal [17:16:17] I haven't checked out the code yet [17:16:25] for the endowment stuff [17:16:33] ah yeah, it's a nice feeling that someone wants to use our stuff :) [17:16:41] definitely! [17:21:18] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: Docker dev setup: Fundraising tools > silverpop export - https://phabricator.wikimedia.org/T269708 (jgleeson) p:Medium→Low [17:22:50] Wikimedia-Fundraising-Banners: [CANDIDATE] New Desktop Small fixed design - https://phabricator.wikimedia.org/T269779 (jbolorinos-ctr) Thanks Sam! Getting started on these now...will let you know if any issues are found [17:24:13] dstrine: I'm gonna put down the docker task I picked up earlier and pick up one of the high priority tasks from the backlog. [17:24:40] * jgleeson cries a little inside [17:25:49] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, fr-donorservices, FR-Email: Copy edits for end of year email (aka yearly receipt or yearly TY email) - https://phabricator.wikimedia.org/T268768 (jgleeson) a:jgleeson [17:38:09] Wikimedia-Fundraising-Banners: [CANDIDATE] New Desktop Small fixed design - https://phabricator.wikimedia.org/T269779 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z289fd53d0eb885ca07f [17:39:42] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (DStrine) p:Medium→High [17:52:06] (PS39) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [17:52:08] (PS12) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [17:53:14] (PS13) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [18:19:03] Wikimedia-Fundraising-Banners: [CANDIDATE] New Desktop Small fixed design - https://phabricator.wikimedia.org/T269779 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr No blockers found. signing off on QA now for this variant @spatton [18:27:50] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [18:28:47] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [19:30:07] (PS1) Mepps: WIP UI Improvements for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647340 (https://phabricator.wikimedia.org/T268646) [19:31:54] Wikimedia-Fundraising-Banners: QA for Endowment banners - https://phabricator.wikimedia.org/T269791 (Pcoombe) [19:34:24] (CR) jerkins-bot: [V: -1] WIP UI Improvements for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647340 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:40:00] Wikimedia-Fundraising-Banners: QA for Endowment banners - https://phabricator.wikimedia.org/T269791 (jbolorinos-ctr) Thanks Peter! Will take a look now and let you know if there are any issues. [19:40:39] Wikimedia-Fundraising-Banners: [Dsk Lg] Endowment banner - https://phabricator.wikimedia.org/T269793 (jbolorinos-ctr) [19:41:23] Wikimedia-Fundraising-Banners: [Dsk Sm] Endowment banners - https://phabricator.wikimedia.org/T269794 (jbolorinos-ctr) [19:42:05] Wikimedia-Fundraising-Banners: [M Lg] Endowment banners - https://phabricator.wikimedia.org/T269795 (jbolorinos-ctr) [19:42:45] Wikimedia-Fundraising-Banners: [M Sm] Endowment banners - https://phabricator.wikimedia.org/T269796 (jbolorinos-ctr) [19:43:42] (PS2) Mepps: WIP UI Improvements for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647340 (https://phabricator.wikimedia.org/T268646) [19:45:50] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [19:47:12] (PS40) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [19:48:13] (Abandoned) Mepps: WIP UI Improvements for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647340 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:49:51] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, User-DannyS712, Wikimedia-production-error: RuntimeException in ApiCentralNoticeQueryCampaign - https://phabricator.wikimedia.org/T269652 (Krinkle) [19:50:36] (PS14) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [19:58:02] (CR) Eileen: [C: +2] "This change seems consistent with the discussion on phab" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647062 (owner: Cstone) [20:09:19] (PS1) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) [20:10:18] Wikimedia-Fundraising-Banners: [BETA] M Lg Frequency First Trilogy banner - https://phabricator.wikimedia.org/T269631 (HNordeenWMF) [20:19:30] (PS2) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) [20:21:02] (PS41) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [20:21:32] (PS15) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [20:22:08] (CR) jerkins-bot: [V: -1] Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [20:22:13] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (mepps) [20:22:54] (Merged) jenkins-bot: Add donation record line back in for stock thank yous. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647062 (owner: Cstone) [20:23:03] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [20:23:40] (CR) jerkins-bot: [V: -1] Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [21:45:09] Fundraising-Backlog: Access to delete contributions from civi - https://phabricator.wikimedia.org/T269806 (MDemosWMF) [21:50:28] (PS1) Ejegg: Add missing 'invalid-currency' error string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647366 [21:50:41] There's the missing message in en at least jgleeson ^^^ [21:51:05] looking [21:52:13] (CR) Jgleeson: [C: +2] Add missing 'invalid-currency' error string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647366 (owner: Ejegg) [21:53:23] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Sending invalid currency codes to Ingenico - https://phabricator.wikimedia.org/T239941 (Ejegg) To do this right will require slightly more complex currency validation that we currently have - Ingenico supports different currenc... [21:53:41] (CR) jerkins-bot: [V: -1] Add missing 'invalid-currency' error string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647366 (owner: Ejegg) [21:54:15] oh derp, forgot to add it to qqq [21:56:16] (PS2) Ejegg: Add missing 'invalid-currency' error string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647366 [21:58:43] oops [21:58:51] (CR) Jgleeson: [C: +2] Add missing 'invalid-currency' error string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647366 (owner: Ejegg) [21:59:04] Wikimedia-Fundraising-Banners: [BETA] M Lg Frequency First Trilogy banner - https://phabricator.wikimedia.org/T269631 (HNordeenWMF) **Updated banner links:** added text, trying to match height of current best while changing order of form elements. Could you read through the text language, and ensure that th... [21:59:10] thanks jgleeson ! [22:11:01] (Merged) jenkins-bot: Add missing 'invalid-currency' error string [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647366 (owner: Ejegg) [22:11:32] Wikimedia-Fundraising-Banners: [BETA] M Lg Frequency First Trilogy banner - https://phabricator.wikimedia.org/T269631 (jbolorinos-ctr) Thanks @HNordeenWMF, I'll run some updated screenshot tests on these [22:15:18] Wikimedia-Fundraising-Banners: [BETA] M Lg Frequency First Trilogy banner - https://phabricator.wikimedia.org/T269631 (jbolorinos-ctr) Screenshot Test Results - Mobile: - Control: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/za092a567fd430e3652b - Test: https://app.crossbrowsertest... [22:33:59] (PS1) Jgleeson: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 [22:38:49] Roxy just sent me a whatsapp recording of Oscar is bed asking "why is blood called blood" and then asking if we can call blood "Oxygen Rodeo Helper" instead. [22:39:23] not sure on the Rodeo part but the rest has some connection [22:39:53] jgleeson: https://www.youtube.com/watch?v=Futnu_6NmQo [22:42:14] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/647375 [22:42:21] (CR) Ejegg: [C: +2] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/647375 (owner: Ejegg) [22:42:27] lol brilliant dwisehaupt [22:43:23] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647376 [22:44:41] HYYYYYYPEEE dstrine [22:44:53] oops wrong chan [22:53:53] (CR) jerkins-bot: [V: -1] Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 (owner: Jgleeson) [23:00:25] (PS2) Jgleeson: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 [23:01:22] Wikimedia-Fundraising-Banners: [CANDIDATE] New Desktop Small fixed design - https://phabricator.wikimedia.org/T269779 (spatton) Much appreciated, @jbolorinos-ctr ! [23:01:32] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, fr-donorservices, FR-Email, Patch-For-Review: Copy edits for end of year email (aka yearly receipt or yearly TY email) - https://phabricator.wikimedia.org/T268768 (jgleeson) @CDenes_WMF thanks so much for adding t... [23:01:37] (Merged) jenkins-bot: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/647375 (owner: Ejegg) [23:15:44] (PS3) Jgleeson: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 [23:17:00] Fundraising-Backlog, FR-Tech-Analytics, FR-Email: As a email stats updater, I need to find results for a send that is missing from Superset - https://phabricator.wikimedia.org/T269811 (KHaggard) [23:17:08] (PS4) Jgleeson: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 [23:17:17] Fundraising-Backlog, FR-Tech-Analytics, FR-Email: As an email stats updater, I need to find results for a send that is missing from Superset - https://phabricator.wikimedia.org/T269811 (KHaggard) [23:22:18] Fundraising-Backlog, FR-Tech-Analytics, FR-Email: As an email stats updater, I need to find results for a send that is missing from Superset - https://phabricator.wikimedia.org/T269811 (KHaggard) [23:23:15] Fundraising-Backlog, FR-Tech-Analytics, FR-Email: As an email stats updater, I need to find results for a send that is missing from Superset - https://phabricator.wikimedia.org/T269811 (EYener) Hey FR-Tech team! I'm not seeing this in the database when I search for it, so I think it might be an impo... [23:26:00] Fundraising-Backlog, FR-Tech-Analytics, FR-Email: As an email stats updater, I need to find results for a send that is missing from Superset - https://phabricator.wikimedia.org/T269811 (KHaggard) [23:29:48] jgleeson: those receipt fixes look pretty good, but I see a bunch of empty lines being added to then end of a bunch of them [23:30:26] (PS5) Jgleeson: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 [23:31:07] yeah ejegg I judt fixed those in that latest patch. for some reason phpstorm is adding new lines to html files on save which is really annoying [23:31:18] just* [23:31:27] oh cool [23:31:47] or rather not cool that phpstorm does that [23:31:51] but cool that it's fixed [23:32:39] https://intellij-support.jetbrains.com/hc/en-us/community/posts/207071445-On-save-new-line-added-to-end-of-file-How-stop-this- [23:33:06] I've hit this problem before but last time I fixed it in a project-specific config but now it looks like I can resolve it IDE wide [23:36:08] ejegg: I added a note on the ticket relating to that patch https://phabricator.wikimedia.org/T268768#6680846 It looks like the Italian template is missing the line which includes the foundation address and tax info so I wanted to check with Camille on that [23:37:36] have a good one! [23:40:46] oh hah, i just noticed the same thing and was going to ask you about it [23:40:53] will hold off the +2 for now I guess [23:41:58] oops [23:42:11] I just noticed another stray newline [23:42:16] grr [23:43:29] oh man, when I fix this one in phpstorm it puts the line back! [23:43:40] that is super annoying [23:44:08] so one final newline is normal I think [23:44:45] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/647373/5/sites/all/modules/wmf_eoy_receipt/templates/html/eoy_thank_you.nl.html [23:45:11] yeah it's refusing to let me save it without one. I could turn that behaviour off but I guess in this case it's desired [23:45:26] although I'm not sure why it was adding a bunch to the other files [23:45:41] Yah I think in that nl one it's probably better with the newline [23:45:45] ok I'll leave that new line addition [23:45:56] laters! [23:45:59] see ya! [23:47:18] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/647389 [23:47:28] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/647389 (owner: Ejegg) [23:48:36] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/647389 (owner: Ejegg)