[00:03:50] fundraising-tech-ops, Operations, netops: Manage frack switches with Netbox - https://phabricator.wikimedia.org/T268802 (Dwisehaupt) @jbond Thanks for the pointers. I have started testing this in our VM setup and it looks like getting lldp in place should be easy to do. I do have a question about th... [00:04:36] (PS1) Ejegg: Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647395 [00:16:47] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647401 [00:21:27] (CR) Ejegg: [C: +2] Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647395 (owner: Ejegg) [00:21:38] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647401 (owner: Ejegg) [00:31:05] (Merged) jenkins-bot: Update SmashPig library [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647395 (owner: Ejegg) [00:31:11] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647401 (owner: Ejegg) [00:42:35] !log updated payments-wiki from 756c2f7ce0 to df80a99b40 [00:42:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:10:39] (CR) Eileen: [C: +2] "I looked through them all & the seem consistent with the requested changes" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 (owner: Jgleeson) [01:27:41] (Merged) jenkins-bot: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647373 (owner: Jgleeson) [10:45:07] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, fr-donorservices, FR-Email: Copy edits for end of year email (aka yearly receipt or yearly TY email) - https://phabricator.wikimedia.org/T268768 (jgleeson) Thanks for the review @Eileenmcnaughton. I'll hang back on d... [11:10:22] fundraising-tech-ops, Operations, netops: Manage frack switches with Netbox - https://phabricator.wikimedia.org/T268802 (jbond) >>! In T268802#6681000, @Dwisehaupt wrote: > I do have a question about the use of facter though. In my testing with lldbctl I see multiple neighbors for an interface. Alth... [12:35:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (krobinson) I think we may need to escalate the priority of this bug. It seems Civi is sending thes... [14:08:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, fr-donorservices: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (MBeat33) p:Triage→High [15:49:39] (CR) AndyRussG: Campaign filtering (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [15:53:27] (PS1) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/647734 (https://phabricator.wikimedia.org/T268646) [15:55:16] (PS3) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) [15:56:42] (Abandoned) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/647734 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [16:08:54] (PS42) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:15:14] (PS16) Mepps: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [16:32:13] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, fr-donorservices, FR-Email: Copy edits for end of year email (aka yearly receipt or yearly TY email) - https://phabricator.wikimedia.org/T268768 (CDenes_WMF) Hi @jgleeson ! Good catch. Here's the translation: Englis... [16:33:06] (CR) Ejegg: [C: -1] "oops, package-lock.json.orig shouldn't be checked in" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [16:46:39] (PS1) Ejegg: Only send fail email on donation cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647740 (https://phabricator.wikimedia.org/T269372) [16:47:23] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (DStrine) [16:47:32] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (Ejegg) [16:48:26] fr-tech https://gerrit.wikimedia.org/r/647740 should be an easy review [16:49:06] hmm, though do we maybe want to save the donation before trying to send an email? [16:49:18] will move that back down, just inside a conditional [16:49:53] (PS2) Ejegg: Only send fail email on donation cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647740 (https://phabricator.wikimedia.org/T269372) [17:09:59] Wikimedia-Fundraising-Banners: Japan banner emojis - https://phabricator.wikimedia.org/T261972 (jbolorinos-ctr) [17:10:01] Wikimedia-Fundraising-Banners: Emoji appears by itself on a newline - https://phabricator.wikimedia.org/T261974 (jbolorinos-ctr) Open→Declined Closing since emoji's have been removed from control [17:11:19] Wikimedia-Fundraising-Banners: Japan Mobile Small Banner: Emoji - https://phabricator.wikimedia.org/T262570 (jbolorinos-ctr) [17:11:21] Wikimedia-Fundraising-Banners: Duplicate emojis appearing as male/male instead of male/female - https://phabricator.wikimedia.org/T262578 (jbolorinos-ctr) Open→Declined Closing as emojis have been removed from controls [17:12:02] Wikimedia-Fundraising-Banners: Missing frb-greeting emoji on Mac OS 10.10 and Windows 8.1 and some older mobile devices - https://phabricator.wikimedia.org/T261976 (jbolorinos-ctr) Open→Declined Closing as emojis have been removed from control due to community feedback [17:12:05] Wikimedia-Fundraising-Banners: Japan banner emojis - https://phabricator.wikimedia.org/T261972 (jbolorinos-ctr) [17:21:02] fr-tech sounds like we should get this out ASAP: https://gerrit.wikimedia.org/r/647740 [17:23:15] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (DStrine) Some updates from standup today: thi... [17:23:41] ejegg: would it make more sense to put it in the block above it thats doing the cancelling? [17:24:26] that's how I had it in PS1, but I think it's more important to save the donation first before trying an email send [17:29:23] fr-tech let's just get the list of recurring donors who started a second donation due to the bad email but hold on the bulk cancelation. I want to hear consensus from advancement mangers. I recently did a knee-jerk cancelation and people got a little bent out of shape so I want to over-communicate this one [17:29:52] getting the list and understand the magnitude will be a good first step [17:30:11] fr-tech for those not in the leads meeting--do we want to meet or check in here? [17:32:59] there are three of us hanging out in the call if you are to join. it's a fun party. [17:33:22] fr-tech standup? [17:33:46] jgleeson: dstrine, XenoRyet and I are in a conflicting meeting [17:34:31] ah [17:45:20] almost done though i think! [18:00:15] (CR) Jgleeson: [C: +2] "Looked at this with cstone and the code looks good to me. Thanks for fixing this!!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647740 (https://phabricator.wikimedia.org/T269372) (owner: Ejegg) [18:01:05] thanks jgleeson|brb ! [18:05:21] Wikimedia-Fundraising-Banners: [Dsk Lg] Endowment banner - https://phabricator.wikimedia.org/T269793 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z04c0037fc1707e6c599 [18:06:53] Wikimedia-Fundraising-Banners: [M Lg] Endowment banners - https://phabricator.wikimedia.org/T269795 (jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zc301b5deacc483a34ff [18:16:28] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647757 [18:16:41] (CR) Ejegg: [C: +2] Update SmashPig library [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647376 (owner: Ejegg) [18:17:39] (Merged) jenkins-bot: Only send fail email on donation cancel [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647740 (https://phabricator.wikimedia.org/T269372) (owner: Ejegg) [18:17:47] Wikimedia-Fundraising-Banners: [Dsk Sm] Endowment banners - https://phabricator.wikimedia.org/T269794 (jbolorinos-ctr) Screenshot Test Result - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zfc50bf3f550a488083e [18:26:42] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647757 (owner: Ejegg) [18:26:59] Wikimedia-Fundraising-Banners: [M Sm] Endowment banners - https://phabricator.wikimedia.org/T269796 (jbolorinos-ctr) Screenshot Test Results - Mobile Sm: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z1e7e3d6b3edc0392af2 [19:14:57] (CR) Ejegg: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647757 (owner: Ejegg) [19:15:05] (CR) Ejegg: [V: +2 C: +2] Update SmashPig library [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/647376 (owner: Ejegg) [19:20:11] !log updated CiviCRM from acb87a092d to aefd10c4e6 [19:20:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:31:36] (CR) AndyRussG: Campaign filtering (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [19:34:13] (PS43) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [19:36:45] (PS44) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [19:40:45] (PS1) Jgleeson: Add test to confirm failed recurring email behaviour. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647770 (https://phabricator.wikimedia.org/T269372) [20:09:30] (PS2) Jgleeson: Add tests to confirm failed recurring email behaviour. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647770 (https://phabricator.wikimedia.org/T269372) [20:12:39] (PS3) Jgleeson: Add tests to confirm failed recurring email behaviour. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/647770 (https://phabricator.wikimedia.org/T269372) [20:25:55] ejegg: eileen: looks like this needs to go in deployed? https://phabricator.wikimedia.org/T269646 [20:26:57] oh yeah, thanks for the reminder jgleeson [20:27:24] moved [20:27:48] thanks! [20:28:34] fr-tech anyone want to review the first patch in this chain? I think we're getting a lot of endowment donations now: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/647119 [20:28:54] oh yeah ejegg [20:31:36] Fundraising Sprint We all meet again, Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: Add 'Stock Information' field to thank you letter - https://phabricator.wikimedia.org/T268081 (LeanneS) @Cstone @MDemosWMF and I reviewed the la... [20:33:10] (CR) AndyRussG: Campaign filtering (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [20:33:40] (CR) Cstone: [C: +2] "Looks good, links changed for me" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269716) (owner: Ejegg) [20:36:31] (Merged) jenkins-bot: Use hook to change footer links for endowment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647119 (https://phabricator.wikimedia.org/T269716) (owner: Ejegg) [20:39:14] thanks cstone! [20:40:06] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: Docker dev setup: Fundraising tools > silverpop export - https://phabricator.wikimedia.org/T269708 (jgleeson) a:jgleeson→None [21:33:22] (PS1) Mepps: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 [21:33:31] (PS1) Esanders: build: Update stylelint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647794 [21:37:57] (CR) jerkins-bot: [V: -1] Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [21:42:36] AndyRussG I don't understand this error locally at all--I made CampaignTest extend CentralNoticeTest and it can't find it [21:45:11] mepps: heyyy I'm kinda heading into non-work part of the day, but my first guess is: I think there's something special to be done to make sure classes are autoloaded? [21:45:18] and it may be different for test classes? [21:45:38] have a look in extension.json and maybe grep about the code elsewhere for the names of other test classes? [21:57:50] sounds good AndyRussG [22:00:18] hmm no I didn't find anything like that...sigh [22:01:14] it's weird because it works correctly in HistoryTest.. [22:01:39] they are also sharing only a tiny bit of code so I'm wondering if I should just move that code out.. [22:17:20] hmmm dunnoooo mepps I'll check it out this evening tho! :) [22:49:24] Fundraising-Backlog: Add "one-time" to header on One-time Payments Wiki - https://phabricator.wikimedia.org/T269897 (HNordeenWMF) [23:04:50] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/647818 [23:05:42] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/647818 (owner: Ejegg) [23:06:25] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647819 [23:07:51] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/647818 (owner: Ejegg) [23:18:32] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647819 (owner: Ejegg) [23:30:40] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/647819 (owner: Ejegg) [23:47:00] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (MBeat33) Thank you @DStrine and @Ejegg Just...