[02:31:38] PROBLEM - check_swap on fran1001 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7622 MB) [02:33:42] ACKNOWLEDGEMENT - check_swap on fran1001 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7622 MB) Dwisehaupt Known issue. [03:16:36] (CR) AndyRussG: "Hi! Thanks for working on this!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [03:28:52] (PS17) AndyRussG: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [03:52:13] (PS2) AndyRussG: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [03:55:33] (CR) jerkins-bot: [V: -1] Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [06:26:32] RECOVERY - check_swap on fran1001 is OK: SWAP OK - 11% free (767 MB out of 7622 MB) [07:24:35] (CR) AndyRussG: Schema updates for campaign filtering (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [07:30:02] (PS45) AndyRussG: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [07:47:00] (PS18) AndyRussG: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [07:47:40] (PS3) AndyRussG: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [07:52:22] (CR) jerkins-bot: [V: -1] Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [07:53:58] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN - https://phabricator.wikimedia.org/T268646 (AndyRussG) [08:32:49] (CR) DannyS712: [C: -1] Campaign filtering (25 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [08:33:56] (CR) DannyS712: "not very familiar with the schema of this extension, but please keep in mind" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [08:34:48] (CR) DannyS712: "> Patch Set 3:" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [14:04:47] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (jgleeson) Sorry all for falling asleep at the... [14:07:11] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (krobinson) Thank you @jgleeson :) [14:38:08] hi jgleeson ! [14:38:23] I see you were picking up the recur fail ticket [14:39:04] I think you can re-run the queries in https://phabricator.wikimedia.org/P13540 [14:39:06] hey ejegg, yeah [14:39:37] and then the ones krobinson is lookig for would be the ones where cancelled = 0 [14:40:18] though I'm sure there are other ways [14:42:23] thanks! was just about to test a hybrid of your first tmp table query with an inner join on recur records with cancelled=0 but yeah I guess it's easier to just use yours verbatim and then select from the tmp table results [14:43:00] hi jgleeson ejegg [14:43:06] sorry, join on the tmp tbl results [14:43:06] oh, though actually I need to put an upper limit on that activity_date_time [14:43:09] hey mepps ! [14:43:09] hi mepps! [14:43:27] it's cold and rainy here and the kids woke up at 5am--how are you guys doing? [14:43:52] oof, early! [14:44:26] mepps: that is early! ditto on the weather also [14:44:55] yeah jgleeson ejegg I went and rested in their room a bit then John and I traded off sleep but it all means I'm sleepy this morning [14:45:31] looks like we're still getting a lot of these Adyen failmails [14:45:36] yes we are! [14:46:02] yep, we've got a heuristic to discard them, but that could make us miss some from up front [14:46:22] and we've got an email out to adyen asking if they can add extra details to the IPNs for amex & discover [14:49:13] jgleeson: I just reused those queries and got a list of 422 who got the email but didn't have a donation canceled since 11/24 [14:49:24] I guess I can just put that list on the server [14:49:51] yeah go ahead ejegg thanks [14:50:50] dang, VPN is not happy [14:51:17] jgleeson same problem as you connecting maybe [14:51:24] just keeps asking for the password over and over [14:52:09] jgleeson: were you able to connect to the VPN, just not the fileserver? I can't even get on the VPN [14:52:29] I got in eventually [14:52:37] I figured I was pasting the wrong password or something [14:52:51] it did eventually let me in but then took about 5 minutes to load the files [14:52:56] ejegg: ^ [14:53:30] want me to see if it's any better for me? [14:53:52] not sure if that will suck resources away from your session attempt! lol [14:55:29] haha [14:55:34] you get in? [14:55:48] still no... [14:55:58] I totally could on friday [14:56:10] ok I'll see if it discriminates less against my traffic [14:56:22] neither full nor split working [14:57:06] jgleeson I left the file in /tmp/T269372-nocancels.csv [14:57:08] on frdev [14:57:25] can you copy it for me if you get on the filesrv? [14:57:35] looks like it's discriminating fairly between the UK and Columbia. I can't get in either [14:57:45] well durn [14:57:59] mepps can you connect to VPN + fileserv this morning? [15:01:48] hang on, need keys to check [15:01:53] wonder if there's a way to see more details of what's happening via connecting over the cli [15:07:31] oh shoot I'm on the mac [15:07:33] hang on [15:08:59] Mon Dec 14 15:08:41 2020 [sfo-openvpn1.corp.wikimedia.org] Peer Connection Initiated with [AF_INET]198.73.209.25:443 [15:09:01] Mon Dec 14 15:08:42 2020 AUTH: Received control message: AUTH_FAILED [15:09:03] Mon Dec 14 15:08:42 2020 SIGTERM[soft,auth-failure] received, process exiting [15:09:44] my authorization keeps failing [15:09:52] is that what's happening to you ejegg jgleeson? [15:10:16] yep mepps [15:10:17] yep [15:10:26] OK, let's ask OIT if they're working on it [15:13:19] emailed techsupport [15:14:42] (PS4) Mepps: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 [15:20:03] (CR) jerkins-bot: [V: -1] Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [15:30:12] ejegg: could we strip the list down to just CIDs and attach that list as a file to the ticket? [15:30:19] as a workaround [15:30:50] hmm, I guess so... [15:32:56] I'm a tad shocked at how many were affected! [15:33:07] we have a lot of recurrings! [15:33:24] and lately it looks like we have a lot of ingenico api issues... [15:33:48] though some of these may be normal financial-related temporary failures [15:34:38] ok, got an 'onlycsvs' version of that file, will paste it into phab [15:35:36] thanks! [15:37:35] so this explains why I couldn't send emails earlier today https://www.bbc.co.uk/news/technology-55299779 [15:39:06] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (Ejegg) OK, the list of 422 CIDs of people who... [15:40:03] I wonder if the google outage has something to do with our VPN issues. We use the same passwords for the VPN as the office gsuite right? [15:40:09] jeez, I sure hope our VPN issues have nothing to do with google [15:40:17] ditto [15:40:36] I mean, we manage pw changes on our own infrastructure [15:40:55] maybe pushing and pulling via API? [15:43:44] ejegg: https://docs.google.com/spreadsheets/d/1q5zr8bSthigQQHhiWUMylI1ZyjeagqIXzffhCdriyeg/edit?usp=sharing [15:44:01] lol there's a 24/7 Bob Ross stream on Twitch: https://www.twitch.tv/bobross [15:44:59] heh, list mirrored here: https://phabricator.wikimedia.org/P13545 [15:45:05] in case docs goes down [15:45:19] oh yeah I just added that list to a csv [15:45:32] figured it might be easier to work with [15:50:46] lol I always forget that [16:01:27] (PS5) Mepps: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 [16:09:02] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, and 2 others: Civi: Recur fail message sent to donor w/non-failed donation - https://phabricator.wikimedia.org/T269372 (MBeat33) Thank you, @Ejegg I think the CID li... [16:10:32] (CR) jerkins-bot: [V: -1] Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [16:16:04] (PS6) Mepps: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 [16:20:41] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (mepps) [16:20:45] looks like the VPN is back up! [16:21:47] (CR) jerkins-bot: [V: -1] Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [16:23:01] (PS7) Mepps: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 [16:25:27] nice ejegg! [16:27:01] I'm looking at the CiviProxy ticket now [16:27:23] I guess we can copy it into the root dir of the crm repo [16:27:47] so it'll be outside of the main crm webroot [16:28:31] the civicrm extension that civiproxy includes doesn't look like it'll be necessary for us [16:28:42] I guess it really is just about mailing newsletters [16:28:51] which seems a bit odd to include with the proxy, but OK [16:39:24] weird ejegg [17:14:56] (PS1) Ejegg: Anchor regex for campaign sanitization [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649416 (https://phabricator.wikimedia.org/T269652) [17:33:43] (PS1) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [17:38:38] (CR) jerkins-bot: [V: -1] Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [17:44:45] (PS2) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [17:45:20] (PS3) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [17:49:23] (CR) Mepps: [C: +2] Anchor regex for campaign sanitization [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649416 (https://phabricator.wikimedia.org/T269652) (owner: Ejegg) [17:49:44] (CR) jerkins-bot: [V: -1] Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [17:50:27] thanks for the CR mepps! [17:52:08] (PS4) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [17:53:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Schema-change, User-DannyS712: CentralNotice schema audit - https://phabricator.wikimedia.org/T263343 (AndyRussG) Thanks so much for digging in here!! :) Just a quick note, most of the columns mentioned are in fact used, but just don't show... [17:55:39] (CR) AndyRussG: "> Patch Set 3:" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [17:56:35] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (DStrine) @AndyRuss... [17:57:57] (Merged) jenkins-bot: Anchor regex for campaign sanitization [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649416 (https://phabricator.wikimedia.org/T269652) (owner: Ejegg) [18:02:39] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (mepps) {F33945657}... [18:05:29] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (mepps) And here's... [18:20:07] (CR) AndyRussG: [C: -1] "Hi @DannyS712! Thanks so so much for digging in and for the review! Woohoo!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [18:26:04] Wikimedia-Fundraising-Banners: QA for Endowment banners - https://phabricator.wikimedia.org/T269791 (jbolorinos-ctr) [18:26:06] Wikimedia-Fundraising-Banners: [Dsk Lg] Endowment banner - https://phabricator.wikimedia.org/T269793 (jbolorinos-ctr) Open→Resolved No blockers to report, closing task as Resolved now that QA has been completed [18:26:31] (PS5) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [18:27:08] Wikimedia-Fundraising-Banners: [Dsk Lg] Endowment banner - https://phabricator.wikimedia.org/T269793 (jbolorinos-ctr) ✅ No RML ✅ No mention of average amount ✅ No monthly option or monthly convert ✅ No Amazon in the US ✅ Added mentions of Endowment in copy ✅ Additional Endowment text in footer ✅ Goes to endo... [18:28:05] Wikimedia-Fundraising-Banners: [Dsk Sm] Endowment banners - https://phabricator.wikimedia.org/T269794 (jbolorinos-ctr) ✅ No RML ✅ No mention of average amount ✅ No monthly option or monthly convert ✅ No Amazon in the US ✅ Added mentions of Endowment in copy ✅ Additional Endowment text in footer ✅ Goes to end... [18:28:35] Wikimedia-Fundraising-Banners: [Dsk Sm] Endowment banners - https://phabricator.wikimedia.org/T269794 (jbolorinos-ctr) Open→Resolved No blockers found. Closing task as Resolved. QA Sign-off completed [18:28:37] Wikimedia-Fundraising-Banners: QA for Endowment banners - https://phabricator.wikimedia.org/T269791 (jbolorinos-ctr) [18:31:59] Wikimedia-Fundraising-Banners: [M Lg] Endowment banners - https://phabricator.wikimedia.org/T269795 (jbolorinos-ctr) ✅ No RML ✅ No mention of average amount ✅ No monthly option or monthly convert ✅ No Amazon in the US ✅ Added mentions of Endowment in copy ✅ Additional Endowment text in footer ✅ Goes to endow... [18:32:29] Wikimedia-Fundraising-Banners: [M Lg] Endowment banners - https://phabricator.wikimedia.org/T269795 (jbolorinos-ctr) Open→Resolved No blockers to report. Closing this task now as Resolved. QA Sign-off is complete [18:32:31] Wikimedia-Fundraising-Banners: QA for Endowment banners - https://phabricator.wikimedia.org/T269791 (jbolorinos-ctr) [18:33:11] Wikimedia-Fundraising-Banners: QA for Endowment banners - https://phabricator.wikimedia.org/T269791 (jbolorinos-ctr) [18:33:13] Wikimedia-Fundraising-Banners: [M Sm] Endowment banners - https://phabricator.wikimedia.org/T269796 (jbolorinos-ctr) Open→Resolved ✅ No RML ✅ No mention of average amount ✅ No monthly option or monthly convert ✅ No Amazon in the US ✅ Added mentions of Endowment in copy ✅ Additional Endowment text in... [18:56:12] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (DStrine) [18:56:26] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (DStrine) Ah mep [19:11:34] (CR) AndyRussG: [C: -1] "Just setting -1 for clarity that this is not ready to merge. :) Thanks!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [19:12:20] (PS1) Jgleeson: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649429 [19:13:08] (PS2) Jgleeson: Update end-of-year email templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649429 [19:16:50] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (mepps) @DStrine th... [19:17:08] fr-tech I'm looking at the backlog and the next unclaimed ticket is the CiviProxy ticket [19:17:17] next ticket by priority [19:18:04] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (mepps) Special and... [19:18:54] jgleeson: is there any way you can help the swedish form? [19:19:03] (CR) DannyS712: Control displaying campaigns based on user preferences (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [19:20:07] (CR) DannyS712: "why does this depend on the rest of the relation chain? Suggest doing separately, so it can be merged earlier (unless I'm missing somethin" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [19:20:15] dstrine: I left a comment on that last week https://phabricator.wikimedia.org/T268647#6676078 not sure how to proceed with it [19:20:36] (CR) DannyS712: [C: -1] Add unit tests for CampaignType (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:21:07] when ejegg|food gets back I'll mention it [19:21:36] also it looks like ejegg|food may have picked up the civiproxy ticket as I see in backscroll he's looking at it [19:21:41] (PS6) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [19:22:43] (CR) Mepps: "DannyS712 AndyRussG moved it so the other patches could be approved without this one. As you say, it could also just stand alone hypotheti" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [19:25:56] (CR) jerkins-bot: [V: -1] Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:26:54] jgleeson: dstrine i asked him and i think you just need to switch the country to test it [19:27:16] locally? [19:27:19] or on live [19:27:22] on live [19:27:36] (CR) Mepps: "Hmm MediawikiUnitTestCase requires tests to be a in a separate "unit" directory. It doesn't fit the pattern for the rest of CN so I'm not " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:28:26] (CR) AndyRussG: [C: -1] Campaign filtering (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [19:28:30] (CR) DannyS712: "> Patch Set 6:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:29:57] (CR) AndyRussG: [C: -1] Schema updates for campaign filtering (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:31:58] hmm jgleeson I just tried and didnt get any payment options for adyen [19:37:04] cstone: I'm trying here [19:37:06] https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=cc-vma&recurring=false&payment_method=cc&country=SE&uselang=en&amount=30&opt_in=0&utm_medium=Waystogive&utm_campaign=C11_Waystogive&utm_source=Waystogive.default~default~default~default~control.cc&utm_key=vw_1541.vh_769.otherAmt_0.validateError_1.time_14&referrer=donate.wikimedia.org%2Fwiki%2FWays_to_Gi [19:37:08] ve¤cy=SEK and it's just stuck for me [19:37:10] https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=cc-vma&recurring=false&payment_method=cc&country=SE&uselang=en&amount=30&opt_in=0&utm_medium=Waystogive&utm_campaign=C11_Waystogive&utm_source=Waystogive.default~default~default~default~control.cc&utm_key=vw_1541.vh_769.otherAmt_0.validateError_1.time_14&referrer=donate.wikimedia.org%2Fwiki%2FWays_to_Gi [19:37:12] ve¤cy=SEK [19:37:14] grr [19:37:16] lemme trim that down [19:37:30] yeah that was bascially what i was trying you just sit at the continue button? [19:38:18] https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQuote&ffname=cc-vma&recurring=false&payment_method=cc&country=SE&uselang=en&amount=30&opt_in=0¤cy=SEK [19:38:21] yeah cstone [19:38:39] I also don't see adyen config for Sweden in the DonationFormSettings file [19:38:52] DonationInerfaceFormSettings.php [19:49:20] hi jgleeson what's up? [19:49:39] ohhh some change needed for the swedish form? [19:49:40] looking [19:49:57] ahh, so let's try a couple links [19:50:42] the links I tried ejegg just have a continue button that dont doesnt do anything [19:51:53] right, we haven't deployed the fix yet, have we? [19:52:09] so there are no submethods available on the prod form [19:52:17] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/644637 [19:52:24] ah okay I thought it had been deployed [19:52:37] that explains that :P [19:52:43] shoot, i meant to leave that in the review column [19:53:23] looking [19:53:32] ah yeah, jgleeson that commit message has an example link [19:53:42] to make sure you can load it via the form chooser [19:53:47] when the gateway is specified [19:55:26] if the test capture ever shows up it looks good ejegg [19:55:51] ejegg: that form is redirecting me to ingenico [19:55:56] that link* [19:56:10] should I be testing this locally [19:56:18] yeah locally jgleeson [19:56:21] ahhh [19:56:22] i was wrong when i said it had been deployed [19:56:35] sorry missed that [19:56:37] got it [19:57:21] ejegg: that patch hasn't associated itself with the ticket for some reason [19:57:50] ah, looks like the phab task is private, huh [19:58:12] I'll post a link [19:59:50] ejegg: also, have you picked up the civiproxy ticket? [20:00:15] only just started looking at it jgleeson [20:00:24] I was looking at what to pick up next and that's currently the next-highest priority ticket [20:00:39] would be happy to figure out civiproxy stuff in common [20:01:28] so I see two initial questions - where to put a copy of https://github.com/systopia/CiviProxy [20:01:29] (PS7) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [20:01:39] (I have it at crm root / civiproxy) [20:02:05] and 2) whether we need the civiproxy extension enabled (I'm leaning toward no) [20:05:47] fundraising-tech-ops, Operations, netops: Manage frack switches with Netbox - https://phabricator.wikimedia.org/T268802 (Dwisehaupt) Yeah, our local VM setups are definitely hub like so that makes sense. We aren't currently using vSwitch and manage our different networks by using a host that simulate... [20:06:19] (PS2) Jgleeson: DO NOT MERGE! [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627902 [20:07:24] (PS8) Mepps: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 [20:10:34] ejegg: cstone I can't see a Swedish test card for Adyen. When using one of the US test cards available after going via the SE/SEK URL I don't see a 3ds step. Any ideas? [20:10:57] (CR) jerkins-bot: [V: -1] Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [20:11:15] ah shoot, were we ever able to see 3DS on Adyen test? [20:11:23] yeah i dont know if ive ever seen it [20:11:40] hmmm rings a bell [20:12:23] yeah, I think we just need to get the cards showing up right on our side [20:12:35] and then get it to prod [20:12:51] where we can see what adyen's live hosted site looks like [20:17:34] (CR) jerkins-bot: [V: -1] DO NOT MERGE! [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/627902 (owner: Jgleeson) [20:23:27] hmmm before I went on brb there was something I wanted to do before +2ing and I've forgotten what that was [20:25:17] ah I need to set up the IPN stuff don't I [20:25:24] to test the adyen donation coming in [20:25:33] my test IPNs went through fine jgleeson [20:25:39] and i got yours too :P [20:25:44] ah great! [20:26:09] i tried with different card types everything looked good [20:26:10] that saved me remembering how to do that! [20:26:18] cstone: happy with the +2 then? [20:26:23] yep [20:26:42] awesome [20:27:21] (CR) Jgleeson: [C: +2] "Tested locally by cstone and myself. Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644637 (https://phabricator.wikimedia.org/T268647) (owner: Ejegg) [20:35:55] (CR) Jgleeson: [C: +2] "Sorry that should be, Tested locally by cstone and I*" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644637 (https://phabricator.wikimedia.org/T268647) (owner: Ejegg) [20:37:32] (Merged) jenkins-bot: Sweden form for Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/644637 (https://phabricator.wikimedia.org/T268647) (owner: Ejegg) [21:00:18] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), and 2 others: RuntimeException in ApiCentralNoticeQueryCampaign - https://phabricator.wikimedia.org/T269652 (DStrine) [21:07:36] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), and 2 others: RuntimeException in ApiCentralNoticeQueryCampaign - https://phabricator.wikimedia.org/T269652 (DStrine) p:Triage→Low [21:35:56] (CR) AndyRussG: "> Patch Set 7:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [21:47:20] (PS9) Mepps: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 [21:48:46] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (mepps) [21:58:05] (PS4) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) [21:58:36] (PS46) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [22:01:51] (PS5) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) [22:03:24] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/649456 [22:03:27] eileen: ejegg fr-tech. Just been looking over the civiproxy stuff and I'm curious why we'd need a new civicrm extension along with the civiproxy scripts. Would that be to expose the data we want in a more customised manner? [22:03:33] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/649456 (owner: Ejegg) [22:03:58] jgleeson: so they recommend that you have a custom api so that you don't inadvertently let something through [22:04:03] (CR) AndyRussG: Schema updates for campaign filtering (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [22:04:17] the eg they give is that the email field being empty in a get request means 'any' [22:05:33] The civiproxy extension doesn't seem to add much that we want (mostly generically useful stuff) [22:05:51] so the other part is the scripts to do the proxying [22:06:48] I did think civiproxy could be altered to make it so fields could be required - but in the end - it does create some comfort just creating an api that only permits certain fields in & out [22:07:03] got it [22:07:37] we we flip the default behaviour when emptiness is present [22:07:41] so we* [22:07:54] in our ext/api [22:08:11] and that just proxies on to civicrm's core apis? [22:10:32] I feel like a good starting point would be dockerizing the civiproxy server so we can stand that up on demand and point it to our local civi instance [22:10:55] ejegg: eileen ^ [22:11:25] jgleeson: yeah I thought that was a good first step &it wound up being where I stalled [22:11:29] and then a patch for the custom ext which wraps the core apis we need ? [22:12:42] ok I can dig into that tomorrow around tech fun day [22:20:57] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (jgleeson) Discussed on IRC: - Write custom CiviCRM extension wi... [22:21:12] jgleeson: it does have a Dockerfile with it [22:21:36] pretty basic, just uses php7/apache and points the webroot at the proxy script dir [22:21:45] oh I see! [22:21:47] we might not need any customization [22:21:49] that makes it much easier then [22:25:05] you don't think we need the custom extension ejegg ? [22:25:21] or customisations to the Dockerfile [22:26:37] jgleeson: so that custom extension seems to just have some mailing stuff in it [22:26:57] and the dockerfile is pretty basic / straightforward [22:26:59] jgleeson: my take on it is the civiproxy extension itself might not be needed [22:27:01] sorry I don't mean that [22:27:15] I mean a *new* extension to wrap the Core API [22:27:27] to avoid the empty param problem eileen mentioned [22:27:51] (I agree the mailing extension might not be needed) [22:28:05] jgleeson: ah yeah, we could add a new API call, maybe in one of the WMF-y Civi extensions that eileen's already made [22:28:18] I don't think we'd need this directory https://github.com/systopia/CiviProxy/tree/master/proxy/mailing [22:28:40] Yeah - maybe it can just go in wmf_civicrm extension as an extra api until it outgrows that [22:29:12] for civi proxy it would need to be a v3 api [22:30:04] wmf_civicrm is drupal right? [22:30:19] would we wanna do this in civicrm [22:30:22] native [22:30:50] jgleeson: ah yah, wmf-civicrm is the Civi one :) [22:30:56] underscores are so drupal [22:30:59] ha! [22:31:28] gotcha [22:32:35] ok I updated the ticket https://phabricator.wikimedia.org/T268495#6690376 [22:32:38] bye for now [22:40:24] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (jgleeson) [22:42:18] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/649456 (owner: Ejegg) [22:46:47] (CR) Eileen: [C: +2] "Looks the same to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649429 (owner: Jgleeson) [22:48:59] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Monitor the return of RML import in December - https://phabricator.wikimedia.org/T269185 (Eileenmcnaughton) [23:09:46] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fr-donorservices: Monitor the return of RML import in December - https://phabricator.wikimedia.org/T269185 (Eileenmcnaughton) There are only 6900 c... [23:12:54] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/649467 [23:14:58] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/649467 (owner: Ejegg) [23:26:50] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/649467 (owner: Ejegg)