[00:01:49] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog: Docker dev setup: Fundraising tools > silverpop export - https://phabricator.wikimedia.org/T269708 (Eileenmcnaughton) To be honest I think in the past this has been little more than a folder in the civi image for me - maybe t... [00:06:20] (CR) DannyS712: [C: +2] Improve docs around object type hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649962 (owner: Umherirrender) [00:10:45] (Merged) jenkins-bot: Improve docs around object type hints [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649962 (owner: Umherirrender) [00:15:47] Wikimedia-Fundraising-Banners: [CANDIDATE] New fixed element design for mobile small - https://phabricator.wikimedia.org/T270339 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr No blockers found, signing off on QA for these now @spatton This variant is READY TO TEST! [00:47:26] (PS1) Eileen: Try hacking utf8mb4 out of enerated [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/650000 [00:49:14] (PS1) Eileen: Try with more utf8 removals [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/650001 [00:51:50] (CR) jerkins-bot: [V: -1] Try hacking utf8mb4 out of enerated [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/650000 (owner: Eileen) [01:07:55] (CR) Legoktm: "Change #650,000, congrats!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/650000 (owner: Eileen) [01:08:25] (CR) jerkins-bot: [V: -1] Try with more utf8 removals [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/650001 (owner: Eileen) [01:17:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, VisualEditor, Patch-For-Review, Wikimedia-production-error: VisualEditor Uri exception breaks display of CentralNotice banners - https://phabricator.wikimedia.org/T270331 (AndyRussG) [01:35:40] woot ^^ [01:59:40] hah, nice round number [05:23:35] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) >>! In... [05:43:29] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) [06:31:17] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) [07:30:46] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) Further... [07:32:21] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) [08:00:21] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) Of the... [12:52:50] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (jgleeson) [12:56:24] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dockerize CiviProxy - https://phabricator.wikimedia.org/T270384 (jgleeson) [12:59:08] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dockerize CiviProxy - https://phabricator.wikimedia.org/T270384 (jgleeson) Updated Dockerfile on this [[ https://github.com/jackgleeson/CiviProxy | fork ]] Will submit as gerrit patch when... [14:23:05] (CR) Jgleeson: [C: +1] "Tested locally and this is working me. Nice!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/649729 (https://phabricator.wikimedia.org/T268495) (owner: Eileen) [16:09:45] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (Ejegg) @AndyRussG... [16:53:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Inconsistent behaviour of mw.centralNotice.customHideBanner - https://phabricator.wikimedia.org/T270401 (Pcoombe) [17:05:32] (PS10) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) [17:45:31] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add CiviProxy to crm repo, write configuration or code for filtering API calls - https://phabricator.wikimedia.org/T268495 (jgleeson) I added a subtask to capture the CiviProxy docker work t... [18:01:47] (PS11) Mepps: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) [18:01:49] (PS48) Mepps: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [18:05:54] (CR) jerkins-bot: [V: -1] Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [18:22:34] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) [18:41:47] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) [18:47:28] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) [19:10:46] (PS49) Ejegg: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [19:37:02] nice, passes tests [19:40:24] (PS21) Ejegg: Control displaying campaigns based on user preferences [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/607461 (owner: ItSpiderman) [19:40:47] (PS11) Ejegg: Move Campaign class tests to separate class [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647793 (owner: Mepps) [19:41:07] (PS8) Ejegg: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:42:36] ah, that last one needs changes [19:44:53] (PS9) Ejegg: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [19:44:55] (CR) jerkins-bot: [V: -1] Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [20:05:25] couple of lil cleanups on the top patch [20:09:57] (PS10) Mepps: Add unit tests for CampaignType [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) [20:17:42] (PS50) Ejegg: Campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/604279 (owner: AlexPinchuk) [20:23:11] mepps it looks like that patch chain is in good shape! [20:23:23] yeah great rebasing ejegg! [20:23:29] I'd be happy to +2 the ones that I haven't touched [20:23:42] maybe we should let AndyRussG weigh in ejegg? [20:23:46] err, though maybe AndyRussG should weigh in first [20:23:49] jinx :) [20:23:50] hah yah, exactly [20:24:08] mepps: ejegg: aaah thanks sure heheh [20:24:20] AndyRussG i'm in the stand up call [20:24:32] k, I might try to get to the grocery store before the afternoon rush hour [20:24:39] * AndyRussG sprinkles extra drive-be review criticism sparkles on the patch [20:28:34] change of plans, doing the grocery trip later [20:28:41] let's see what's next here [20:59:27] ejegg mepps so I guess I'll do my main non-work block of stuff and then review the new code this evening? does that work? also fantastic that you got it working!!!! [20:59:44] great AndyRussG ! [20:59:50] :) [21:00:05] ^ ahh above I meant, "drive-by review criticism sparkles", just to clarify the unclarifiable I guess [21:07:17] Wikimedia-Fundraising-Banners: [BETA] M Lg Frequency First Trilogy banner - https://phabricator.wikimedia.org/T269631 (jbolorinos-ctr) Open→Resolved QA Sign-off has already completed for this variant. No blockers found. Closing task as Resolved. [21:43:36] Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: Paypal reintegration: braintree or...? - https://phabricator.wikimedia.org/T243095 (DStrine) [21:54:02] sounds good AndyRussG [21:54:15] mepps: :) [22:07:06] Fundraising-Backlog, FR-Tech-Analytics, FR-Email: As an email stats updater, I need to find results for a send that is missing from Superset - https://phabricator.wikimedia.org/T269811 (bsisolak) Ah yes, remove and that will return all types, included Canceled. [22:56:46] Fundraising-Backlog, FR-Email: Acoustic maintenance notice: No need for Civi export - https://phabricator.wikimedia.org/T270449 (KHaggard) [23:52:55] Fundraising-Backlog, fundraising-tech-ops: Fix our database to support emojis - convert tables to utf8mb4 - https://phabricator.wikimedia.org/T270218 (Dwisehaupt) [23:55:16] fundraising-tech-ops: Plan for FY 2020-21 Q3 maintenance window - https://phabricator.wikimedia.org/T268056 (Dwisehaupt)