[02:38:07] ejegg cool that u and mepps made so much progress on the campaign filtering stuff... if I have improvements to suggest and that I can do easily this evening, should I just make them and send up the patch? or is commenting on Gerrit better? [02:39:01] I kinda feel like just doing stuff might be more efficient overall? don't want to step on others' work though..... [03:07:12] AndyRussG: please go ahead and make the changes! [03:08:22] (PS1) Jforrester: Use User->isRegistered(), not deprecated isLoggedIn() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/650394 (https://phabricator.wikimedia.org/T270450) [03:09:02] ejegg: ahhh okok thanks cool beans! [03:09:16] just some minor bits and pieces here and there so far anyway [03:15:07] (CR) DannyS712: [C: +2] Use User->isRegistered(), not deprecated isLoggedIn() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/650394 (https://phabricator.wikimedia.org/T270450) (owner: Jforrester) [03:41:35] (Merged) jenkins-bot: Use User->isRegistered(), not deprecated isLoggedIn() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/650394 (https://phabricator.wikimedia.org/T270450) (owner: Jforrester) [03:48:12] (PS1) Ejegg: Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 [04:00:43] (CR) Ejegg: [C: +2] Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 (owner: Ejegg) [04:04:55] oh phooey, what's broken with this patch? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650396/1 [04:05:25] I mean, the code works well for me [04:05:34] but gerrit is dying when I try to look at it there [04:05:47] Error 500 (Server Error): Internal server error [04:05:48] Endpoint: /changes/*~*/revisions/*/files [04:06:02] Too many changes? But it usually just shows a pager [04:06:33] hmm, wikibugs didn't pick it up either [04:06:45] how bout zuul? [04:08:03] huh, only the codehealth pipeline [04:10:04] ejegg: hummm I also get an error on that [04:29:25] well shoot, I guess I should run the tests locally [05:12:28] ejegg: what about using string keys instead of numeric for the types in the config? [05:12:40] I think we could still convert to DB after that [05:12:50] and it might simplify code further [05:13:40] AndyRussG: sure, so just get rid of the CampaignType->id property completely? [05:13:42] also there's this weird thing about PHP silently converting numerical-looking keys to integers: [05:13:52] https://stackoverflow.com/questions/11678790/php-setting-a-number-as-key-in-associative-array [05:13:56] and yes [05:13:59] ahh yeah, that's potentially bad [05:14:20] ok, so changing the schema to store the notice.not_type as a string too? [05:14:35] ejegg: also, I want to be sure old campaigns don't get unintentionally recategorized because the config changes [05:14:50] good point [05:14:52] so the historcal record of campaigns would be more solid [05:15:04] ejegg: yes wrt changing the schema [05:15:45] ejegg: ahhhh now that I have you on the phone I was also thinking of adding an i18n string for "No campaign type assigned" [05:15:53] or something like that [05:16:10] or "Uncategorized (always shown)" in the UI [05:16:15] instead of the oh-so-informative '-' [05:16:17] ? [05:16:21] yis exactly [05:16:34] okok, is that sort of what 'Special' is about though? [05:17:13] ejegg: yes, except that existing campaigns would automatically get the "uncategorized" category [05:17:22] and it kinda feels better as a default, no? [05:17:26] yep [05:17:44] and also to let CN admins know clearly that no one can opt out of the uncategorized ones [05:18:35] ahhhh apologies for further extending your day and thanks much for the input btw!!! [05:19:41] no worries! I'm on anyway for the MW update [05:20:05] whew, 10% done with the full core test suite [05:20:15] (running it locally) [05:20:30] ahhh hope it doesn't take too much longer :) [05:26:07] ufff, 15% [05:26:22] looking at these patches, I think it might keep till tomorrow [05:32:17] eh no wonder Jenkins didn't want to do that [05:35:57] seems like there's some gerrit distemper going around [05:36:09] I'll see if releng has it fixed in the morning [05:42:45] heh sounds likely [05:58:56] ahhh almost sleepy time here [06:17:37] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) [06:43:50] Fundraising Sprint Xtreme Lolcats, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (AndyRussG) Finishe... [12:49:30] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/650490 [12:50:34] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/650490 (owner: Jgleeson) [13:22:38] Fundraising Sprint Yellow hornets of kindness and healing, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dockerize CiviProxy - https://phabricator.wikimedia.org/T270384 (jgleeson) a:jgleeson [14:37:48] phew, back online. Now from fighting with my router back to fighting with gerrit [14:48:26] huh, I re-did the merge from scratch and smashed in the composer update, and now gerrit's happy showing it [14:48:31] :shrug: [14:50:02] (Abandoned) Ejegg: Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 (owner: Ejegg) [14:50:36] anyone else want to try the new code locally before I put it on prod? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650396/2 [14:51:13] There was an email on one of the mediawiki lists shortly after 1.35.1 came out where someone complained that it broke their wiki's logo [14:51:24] but so far I see no sign of that [15:00:34] ah dang, gerrit's throwing that same damn error again [15:01:01] It loaded the change happily the first time I looked at it, with the changed file list and everything [15:18:00] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Error message when no bank selected for iDEAL could be more helpful - https://phabricator.wikimedia.org/T185338 (Pcoombe) Open→Resolved a:Pcoombe Not a problem with the new Adyen flow [15:19:25] fr-tech does someone else want to try doing the 1.35.1 merge locally to see if gerrit gives the same problem? [15:31:23] hey ejegg [15:31:36] the friday release curse? [15:33:14] heh, they put out the update yesterday [15:33:29] but it looks like gerrit is complaining about a 'missing blob' [15:33:54] I got the gerrit internal server error when loading the last link you posted [15:34:18] which thcipriani has just figured out is in an extension which is included in the base REL1_35 but which we have removed in our fundraising/REL1_35 branch [15:37:10] jgleeson do you want to try prepping the patch locally and see if it has the same problem? [15:37:39] I can hop on a videocall if you want me to show you the steps I followed [15:42:39] sure ejegg [15:43:55] today's standup chat? [15:44:10] sure! [16:33:17] Fundraising-Backlog: Apply Mediawiki 1.35.1 update to payments-wiki - https://phabricator.wikimedia.org/T270507 (Ejegg) [16:37:49] (PS12) AndyRussG: Schema updates for campaign filtering [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/647349 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [16:38:52] (PS1) Jgleeson: Remove unused submodules added with security release 1.35.1 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650527 [16:47:23] (PS2) Jgleeson: Remove unused submodules added with security release 1.35.1 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650527 [16:50:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Inconsistent behaviour of mw.centralNotice.customHideBanner - https://phabricator.wikimedia.org/T270401 (Pcoombe) This isn't urgent, I worked around it in the banners we want to test by just adding my own simplified function which only sets a cooki... [16:59:25] (CR) jerkins-bot: [V: -1] Remove unused submodules added with security release 1.35.1 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650527 (owner: Jgleeson) [17:12:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Inconsistent behaviour of mw.centralNotice.customHideBanner - https://phabricator.wikimedia.org/T270401 (AndyRussG) Hi! Thanks for this... I tried this with the campaign currently on aa.wikipeda.org. When I clicked the close button, I got two cooki... [17:23:09] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk sm banner w/ faces - https://phabricator.wikimedia.org/T270509 (spatton) [17:55:59] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk lg banner w/ faces - https://phabricator.wikimedia.org/T270511 (spatton) [17:59:38] (Restored) Ejegg: Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 (owner: Ejegg) [18:00:57] (PS2) Ejegg: Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 [18:05:17] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: Upgrade Fundraising Superset to 0.37.x - https://phabricator.wikimedia.org/T262439 (Jgreen) Reviewed the changes and tested the upgrade in virtualbox, it looks straightforward. The Superset install process includes a database update step,... [18:25:09] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk sm banner w/ faces - https://phabricator.wikimedia.org/T270509 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z1872dd9b515ef8fe310 [18:25:36] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk lg banner w/ faces - https://phabricator.wikimedia.org/T270511 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zc3b04bffb51a471f6a8 [18:37:44] (PS3) Jgleeson: Remove unused submodules added with security release 1.35.1 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650527 [18:38:22] (PS4) Jgleeson: Remove unused submodules added with security release 1.35.1 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650527 [18:39:05] (PS3) Jgleeson: Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 (owner: Ejegg) [18:39:39] (PS4) Jgleeson: Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 (owner: Ejegg) [18:39:59] jgleeson: this is looking more like a gerrit bug - depending on the URL we see or don't see the 500 error [18:40:11] ah [18:40:16] I just stacked those patches up [18:40:18] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650400/4 [18:40:25] e.g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650524 has no error while https://gerrit.wikimedia.org/r/c/mediawiki/core/+/650524/3 does [18:40:47] oh yeah that's weird [18:40:50] the same thing right? [18:40:54] yah [18:40:59] should be, anyway [18:41:33] let's see what the background request is [18:45:52] https://gerrit.wikimedia.org/r/changes/mediawiki%2Fcore~650524/revisions/3/files vs https://gerrit.wikimedia.org/r/changes/mediawiki%2Fcore~650524/revisions/3/files?parent=1 [18:47:51] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk lg banner w/ faces - https://phabricator.wikimedia.org/T270511 (jbolorinos-ctr) Hey @spatton, Quick question on this variant, on larger screens the images cut off, is that expected behavior? Or would we want to resize the images on 1920x1200 screens so that it... [18:47:59] (CR) jerkins-bot: [V: -1] Remove unused submodules added with security release 1.35.1 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650527 (owner: Jgleeson) [18:53:14] Wikimedia-Fundraising-Banners: Banner faces skewed left on Safari - https://phabricator.wikimedia.org/T270518 (jbolorinos-ctr) [18:53:35] Wikimedia-Fundraising-Banners: Banner faces skewed left on Safari - https://phabricator.wikimedia.org/T270518 (jbolorinos-ctr) [19:02:11] jgleeson: so thcipriani has this pegged as a gerrit bug rather than any deficiency in our repo [19:02:38] I'm going to go ahead and V+2 my original merge and we can all go back to our business [19:03:36] cool ejegg glad that's somewhat resolved! [19:04:44] thanks for all the help! [19:16:08] (PS12) Jgleeson: Dockerize process-control [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/643767 (https://phabricator.wikimedia.org/T268685) [19:40:48] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk lg banner w/ faces - https://phabricator.wikimedia.org/T270511 (spatton) Hey @jbolorinos-ctr, I see it as intentional to cut the images off on a larger screen; we only have these 10 pictures to include, so at some point, they won't fill the space. [20:30:37] (Abandoned) Ejegg: Update packages to match upstream REL1_35 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/650400 (owner: Ejegg) [20:47:22] Wikimedia-Fundraising-Banners: Banner faces skewed left on Safari - https://phabricator.wikimedia.org/T270518 (EWilfong_WMF) Open→Resolved a:EWilfong_WMF @jbolorinos-ctr - I believe this issue is resolved. I fixed by changing the display property of this element from table to flex ([[ https://me... [20:47:24] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk lg banner w/ faces - https://phabricator.wikimedia.org/T270511 (EWilfong_WMF) [20:50:52] !log updated payments-wiki from 3d3055c478 to c3e6c5f9f4 [20:50:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:45:18] Fundraising-Backlog, FR-Q2-FY2020-21-cleanup-list: Paypal reintegration: braintree or...? - https://phabricator.wikimedia.org/T243095 (EMartin) Hi Folks Paypal has come back to advise that the Braintree connection is their promoted option for enterprise accounts such as Wikimedia so it looks like we do... [22:25:00] fundraising-tech-ops: remove deprecated IPN listener standalone redirect from payments-listener role - https://phabricator.wikimedia.org/T270529 (Jgreen) [22:31:05] Wikimedia-Fundraising-Banners: Banner faces skewed left on Safari - https://phabricator.wikimedia.org/T270518 (jbolorinos-ctr) Thanks so much for the quick fix @EWilfong_WMF, I'll run another screenshot test now to verify it looks good, and if so I'll go ahead and close this task [22:43:35] Wikimedia-Fundraising-Banners: Banner faces skewed left on Safari - https://phabricator.wikimedia.org/T270518 (jbolorinos-ctr) Ok looks great now! Fix verified: {F33958359} Closing task now as Resolved, thanks again Eric! [22:44:31] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk sm banner w/ faces - https://phabricator.wikimedia.org/T270509 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr All issues found have been reported and addressed. Signing off on QA now for this banner, since it is now READY TO TEST! @spatton [22:45:48] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk lg banner w/ faces - https://phabricator.wikimedia.org/T270511 (jbolorinos-ctr) Ok, yeah that's what I figured but wanted to double check just in case. Thanks Sam! [22:46:19] Wikimedia-Fundraising-Banners: [CANDIDATE] dsk lg banner w/ faces - https://phabricator.wikimedia.org/T270511 (jbolorinos-ctr) Open→Resolved a:jbolorinos-ctr All issues found have been reported and addressed. Signing off on QA now for this variant. It's now READY TO TEST! @spatton