[00:00:14] i think it is [00:00:21] the tests are still running but none have failed yet [00:00:28] this is a fresh docker install [00:00:52] i dont know why CI is failing though :( [00:01:50] ok nevermind there are some failures [00:16:11] (CR) Cstone: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656021 (owner: Eileen) [00:17:14] eileen: how do you feel about just force merging the revert? im getting all the failing tests on CI to pass locally with the revert [00:17:25] cstone: do it [00:17:37] I mean - it's a revert so it's just bringing us back to a commit ago [00:17:43] haha yeah ok [00:18:44] (CR) Cstone: [C: +2] Revert "Move the creation of option values for gift fields to array-based" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656021 (owner: Eileen) [00:19:02] (CR) Cstone: [V: +2 C: +2] Revert "Move the creation of option values for gift fields to array-based" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656021 (owner: Eileen) [00:19:48] (CR) DannyS712: [C: -1] "> Patch Set 17:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/649420 (https://phabricator.wikimedia.org/T268646) (owner: Mepps) [00:20:30] (PS2) Cstone: [PLS DO NOT MERGE] CI test change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/655954 (owner: AndyRussG) [00:35:18] eileen: i dont want to be too quick to say this but the tests are passing so far [00:38:56] (CR) jerkins-bot: [V: -1] [PLS DO NOT MERGE] CI test change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/655954 (owner: AndyRussG) [00:39:01] haha it timed outttt [00:39:55] (CR) Cstone: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/655954 (owner: AndyRussG) [00:40:10] sigh [00:40:46] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656019 (owner: Eileen) [00:40:56] cstone: this might help on the speed https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/656019 [00:41:18] - that is upstreamed - but actually we could remove vendor in that too [00:41:23] it might help on speed [01:01:49] the speed one also timed out :( [01:05:49] lol [01:06:37] cstone: interesting to see a pure time out - I was assuming the failures might contribute to it [01:06:53] yeah i think if it didnt time it out the tests would be passing [01:06:58] i dont know why is so much slower now though [01:07:02] also - I think they all ran? [01:07:19] or if not only the last 4 didn't? [01:07:24] yeah [01:09:33] we can up the php time out a bit more & I suspect it will start finishing again [01:09:39] those last 4 run fine locally [01:09:54] yeah they run locally for me too [01:10:33] if *could* be a loop - https://stackoverflow.com/questions/3479313/set-a-test-timeout-duration-with-phpunit but let's just try increasing the time out more first [01:10:56] i had to up my local one too [01:11:02] the timeout [01:13:22] when running just that test? [01:13:27] or running all of them? [01:13:28] no running them all [01:13:42] hmm so it's slowing down as it goes for some reason [01:15:02] does increasing that timeout have any negative effects? [01:20:59] (PS1) Cstone: Increase timeout. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656281 [01:38:36] (CR) jerkins-bot: [V: -1] Increase timeout. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656281 (owner: Cstone) [01:38:47] thats the linter failing but the tests completed with no failures! [02:09:03] (CR) Eileen: [C: +2] Increase timeout. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656281 (owner: Cstone) [02:09:10] cstone: well that [02:09:13] worked [02:09:16] yeah!! [02:10:05] then I'll try to get all the straight forward ones like this cleared https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/652658 - once they pass [02:10:40] (Abandoned) Eileen: Expose phpunit fails better [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/655758 (owner: Eileen) [02:11:44] (Abandoned) Eileen: Add missing comma. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656016 (owner: Cstone) [02:26:02] (Merged) jenkins-bot: Increase timeout. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656281 (owner: Cstone) [02:26:12] !!!! [02:27:26] yep & it wasn't actually slower! [02:27:43] (PS4) Eileen: Remove upgrade step to create upstreamed index [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652658 (https://phabricator.wikimedia.org/T270680) [02:27:54] I just rebased ^^ [02:28:10] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656019 (owner: Eileen) [02:28:31] (PS4) Eileen: Remove values that are the same as defaults for payment processor create [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652656 (https://phabricator.wikimedia.org/T270680) [02:29:00] (PS5) Eileen: Remove update to set deduper_resolver_bool_prefer_yes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652630 (https://phabricator.wikimedia.org/T270680) [02:30:06] & a couple more [02:31:22] cstone did you talk to your friend about the gift q? [02:34:21] (PS1) Eileen: "Admin => Misc" - Fix validation of "Maximum File Size" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656282 [02:34:23] (CR) Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656282 (owner: Eileen) [02:35:38] Also cston - are you able to look at https://gerrit.wikimedia.org/r/656282 & add a +2 into all those new contributor welcomes :-) [02:35:45] (cstone I mean) [02:36:05] it seems Tim fortuitously hit the bug the day before I did [02:37:15] sure eileen [02:37:28] Fundraising Sprint Airline Passenger Experience, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Patch-For-Review: Importing Activity Updates - https://phabricator.wikimedia.org/T219191 (Eileenmcnaughton) @Dwisehaupt I'm still being notified that Maximum file size ca... [02:37:36] I'll just fix the bug no into the commit on it [02:38:01] (PS2) Eileen: "Admin => Misc" - Fix validation of "Maximum File Size" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656282 (https://phabricator.wikimedia.org/T219191) [02:38:44] in all honesty cstone I haven't tested it myself because it's in an area of the code which affects very little & the reviewer of the upstream PR is very thorough [02:40:14] but if you want to see where it impacts try this url https://civicrm.wikimedia.org/civicrm/admin/setting/misc & about half way down the page this field Maximum File Size (in MB) [02:40:52] I'm not sure if the php setting is right or not but with that patch it should give a clear message [02:43:27] (CR) jerkins-bot: [V: -1] Remove upgrade step to create upstreamed index [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652658 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [02:44:51] looks like we are back to the ignorable fails ^^ [02:45:08] woo! [02:46:27] (CR) jerkins-bot: [V: -1] Remove values that are the same as defaults for payment processor create [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652656 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [02:47:38] (CR) jerkins-bot: [V: -1] Remove update to set deduper_resolver_bool_prefer_yes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652630 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [02:49:06] (CR) Cstone: [C: +2] Remove update to set deduper_resolver_bool_prefer_yes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652630 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [02:51:06] haha i like your before and after on the cache flush :) [02:52:21] (CR) Cstone: [C: +2] Add setting default to speed up cache flush [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656019 (owner: Eileen) [02:54:10] cstone: yes - hopefully true but not very precise [02:55:00] hopefully it makes a noticeable difference but we'd get more benefit if we exclude vendor too - which we could do in buildkit or somewhere [02:58:36] (CR) Cstone: [C: +2] "Thanks new contributor! 😊" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656282 (https://phabricator.wikimedia.org/T219191) (owner: Eileen) [02:59:06] (CR) Eileen: "lol - so grateful to get my first patch reviewed....." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656282 (https://phabricator.wikimedia.org/T219191) (owner: Eileen) [03:00:05] cstone: did your friend respond about the Bolivia question? [03:01:46] https://www.instagram.com/planetaria_deli/?hl=fr [03:01:51] was the suggestion [03:06:34] (Merged) jenkins-bot: Remove update to set deduper_resolver_bool_prefer_yes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652630 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [03:09:45] (Merged) jenkins-bot: Add setting default to speed up cache flush [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656019 (owner: Eileen) [03:15:11] (Merged) jenkins-bot: "Admin => Misc" - Fix validation of "Maximum File Size" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/656282 (https://phabricator.wikimedia.org/T219191) (owner: Eileen) [03:21:47] planetaria looks good [03:22:55] looks like we are back to 'not-very-failey-fails' on ones like this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/652658 [03:23:51] with the linter? [03:24:47] theres a good example on andys test patch of it failing succeeding and failing i need to ask about that its something weird going on [03:24:48] (PS1) Eileen: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656285 [03:24:57] (CR) Eileen: [C: +2] CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656285 (owner: Eileen) [03:25:49] yeah I have no idea what it is up to [03:25:52] it's odd [03:26:07] yeah ill ask releng tomorrow [03:26:11] but at least we know ones like ^^ will merge with a +2 despite that [03:26:46] yeah [03:27:09] (CR) Cstone: [C: +2] Remove upgrade step to create upstreamed index [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652658 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [03:30:56] (CR) Cstone: [C: +2] Remove values that are the same as defaults for payment processor create [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652656 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [03:31:06] (PS6) Eileen: Move update 7610, civitoken settings, to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652628 (https://phabricator.wikimedia.org/T270680) [03:42:18] (CR) jerkins-bot: [V: -1] CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656285 (owner: Eileen) [03:43:22] (Merged) jenkins-bot: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656285 (owner: Eileen) [03:45:15] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/656306 [03:45:41] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/656306 (owner: Eileen) [03:45:43] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/656306 (owner: Eileen) [03:46:27] (Merged) jenkins-bot: Remove upgrade step to create upstreamed index [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652658 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [03:46:29] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/656306 (owner: Eileen) [03:47:06] (Merged) jenkins-bot: Remove values that are the same as defaults for payment processor create [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652656 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [03:49:23] !log civicrm revision changed from f417a510a5 to 4220fc8177, config revision is f08249ecf9 [03:49:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:50:10] (PS4) Eileen: Move smashpig settings to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652629 (https://phabricator.wikimedia.org/T270680) [03:50:10] eileen: should I be looking at the drupal upgrade patch? [03:50:24] or do you want to wait till after these are cleared out [03:51:23] (Abandoned) Eileen: Test a bit of apiv3 copy & paste [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656020 (owner: Eileen) [03:51:42] cstone: we should roll that out - it's a separate chain [03:52:23] I think it might need a force v+2 due to the fail-then-pass nature of the chain [03:52:45] it looks like it doesnt run the fail-y one [03:52:54] (CR) Cstone: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/654736 (owner: Eileen) [03:57:27] Fundraising Sprint Airline Passenger Experience, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Patch-For-Review: Importing Activity Updates - https://phabricator.wikimedia.org/T219191 (Eileenmcnaughton) Hmm - @Dwisehaupt it's now clealy telling me that upload_max_f... [03:59:57] Fundraising Sprint Airline Passenger Experience, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Patch-For-Review: Importing Activity Updates - https://phabricator.wikimedia.org/T219191 (Eileenmcnaughton) ohhh drush @wmff php-eval "echo ini_get('upload_max_filesize... [04:04:51] cstone: the thing with drupal is we normally commit the stock code & then our patch. The stock code fails because our patch does test-passing-hackery [04:05:46] (CR) jerkins-bot: [V: -1] Move smashpig settings to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652629 (https://phabricator.wikimedia.org/T270680) (owner: Eileen) [04:05:47] ah okay it had the same timeout as the others so I had thought it was from that [04:07:04] i see the errors ok [04:08:26] so just c+2 them then force merge them eileen ? [05:18:11] cstone: yep - but that was an hour ago [05:18:14] so you might be gone [05:33:36] hah im still at my desk but it didnt make a noise! [05:34:19] (CR) Cstone: [C: +2] Drupal update to 7.77 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/654736 (owner: Eileen) [05:34:33] cstone: it must be late [05:35:10] just a little [05:35:27] (CR) Cstone: [C: +2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/654737 (owner: Eileen) [05:39:14] cstone: I'll do the submodule update but I won't merge that to deploy as I won't be around much longer & we try to avoid 'friday' deploys [05:39:26] yeah makes sense [05:39:55] also - I rebased this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/652629 - no need to look tonight though! [05:42:50] ill get that one tomorrow but woo for getting all these merged [05:49:15] (CR) jerkins-bot: [V: -1] Drupal update to 7.77 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/654736 (owner: Eileen) [05:49:17] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/654737 (owner: Eileen) [06:44:28] (CR) Eileen: [V: +2] "Passes with re-application of our patches (next patch)" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/654736 (owner: Eileen) [06:45:12] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/654737 (owner: Eileen) [07:03:55] (PS1) Eileen: Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656309 [07:16:48] (CR) Eileen: [C: +2] Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656309 (owner: Eileen) [07:21:09] (CR) jerkins-bot: [V: -1] Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656309 (owner: Eileen) [07:32:34] (Merged) jenkins-bot: Drupal submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/656309 (owner: Eileen) [20:58:34] (PS3) Cstone: new Fy2021 thank you email for Italy [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/652823 (owner: Cdenes) [21:40:30] Fundraising Sprint Airline Passenger Experience, Fundraising-Backlog: New Italian Thank You email for upcoming Italy Campaign - https://phabricator.wikimedia.org/T270983 (Cstone) @CDenes_WMF this is now on staging. I added a missing end if to the block above the signature. [22:20:41] Fundraising Sprint Airline Passenger Experience, Fundraising-Backlog: Step 2: Investigate Omnipay - https://phabricator.wikimedia.org/T271074 (AndyRussG) a:AndyRussG [23:18:04] Fundraising-Backlog, fundraising-tech-ops, FR-Tech-Analytics: Superset user - kill query after 60-65 seconds - https://phabricator.wikimedia.org/T272080 (Dwisehaupt) @EYener Is this something that would be safe to apply to all queries for the research user? If so we can use the MAX_STATEMENT_TIME lim...