[00:00:26] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for sinaba - https://phabricator.wikimedia.org/T273494 (Dwisehaupt) Certificate renewed and delivered via email. Password sent via SMS. [00:01:55] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for avargas - https://phabricator.wikimedia.org/T273939 (Dwisehaupt) [00:03:36] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for lschreibstein - https://phabricator.wikimedia.org/T273940 (Dwisehaupt) [00:10:43] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/661281 (https://phabricator.wikimedia.org/T272061) (owner: Eileen) [00:11:09] (CR) Eileen: "this can be abandoned if it passes & the patch can just not be re-applied on update" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/661281 (https://phabricator.wikimedia.org/T272061) (owner: Eileen) [00:12:27] cstone thanks - do you have any thoughts on the drupal submodule commits? My guess is we just have to forced the first one through & the second will pass .... it's a bit ug [00:13:31] also - it would be good to do this change sooner than later just to prep for the upgrade https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/661525 [00:17:28] oh yeah i lost that one i was looking at that [00:18:37] eileen: I don't have any thoughts on the submodule the stackoverflow seems straight forward and it didnt cause any chaos when i pulled it down locally [00:19:57] cstone: my gut says we just have to force it - do you feel comfortable doing that? I assume we can get out of any problems it causes one way or another [00:20:15] yeah i think thats fine for this [00:24:43] eileen: is there three in total for drupal, the first convert then re add then the second convert? [00:25:15] cstone: so I tried both in 1 & 2 separate patches [00:25:20] in the hope one way would work [00:25:47] ah okay [00:26:02] oddly the only patch to pass was the one ENTIRELY REMOVING the drupal directory! [00:26:11] which tells us 'something' [00:26:18] but I'm not sure what :-) [00:26:21] haha [00:26:37] I suspect that if we are gonna use force the combined patch makes sense [00:27:03] yeah [00:27:56] (Abandoned) Eileen: Remove WMF hack to civi [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/661281 (https://phabricator.wikimedia.org/T272061) (owner: Eileen) [00:28:28] that was the patch that proved the hack-fix works :-) [00:28:43] cstone: so when you are ready to +2 it we will just v+2 too [00:29:07] eileen: when i was testing i accidentally did not have the hack haha [00:29:13] (CR) Cstone: [C: +2] "woo" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661538 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:29:47] (CR) Eileen: [V: +2] Convert drupal submodule to being 'just a folder' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661538 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:29:52] (CR) jerkins-bot: [V: -1] Convert drupal submodule to being 'just a folder' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661538 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:30:44] (CR) Eileen: "V+2 because jenkins won't load this due to it altering submodules & weird stuff" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661538 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:31:07] cstone: ok - merged - I'll retry something else now & make sure jenkins is cheerful [00:31:21] sounds good [00:31:22] (Abandoned) Eileen: Re add drupal as 'just a folder' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661542 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:31:35] (Abandoned) Eileen: Convert drupal submodule to being 'just a folder' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661541 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:32:25] cstone: I think this one is a no-brainer - if you +2 that we can see if it merges https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/661480 [00:33:00] (CR) Cstone: [C: +2] One symlink down [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661480 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:33:13] cool - let's see what happens! [00:34:07] this should be a no-brainer too - is't just a stern-talking to from my IDE to the code https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/660987/2/sites/all/modules/offline2civicrm/tests/EngageChecksFileTest.php [00:34:54] haha is there some like agreed upon ultimate comment line width [00:35:00] (CR) jerkins-bot: [V: -1] One symlink down [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661480 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [00:35:59] cstone: ok I found something [00:36:00] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/660987/2/sites/all/modules/offline2civicrm/tests/EngageChecksFileTest.php [00:36:05] dang not that [00:36:23] cmdline: git clone -v https://gerrit.wikimedia.org/r/p/wikimedia/fundraising/crm/drupal /src/wikimedia/fundraising/crm/drupal [00:36:51] thats what it failed on right [00:38:48] yeah - I didn't see it before - but where is it coming from! [00:39:44] buildkit does git clone --recursive "$CACHE_DIR/wikimedia/fundraising/crm.git" "$WEB_ROOT" [00:55:01] Hmm - I found this - https://gerrit.wikimedia.org/r/c/integration/config/+/661825 but it seems unlikely to be the place [01:02:30] bah I was looking in those files too but didnt click on the example [01:02:32] hah yeah [01:03:40] cstone: I think I've found the place [01:04:22] but I guess we don't have +2 rights [01:04:22] https://gerrit.wikimedia.org/r/c/integration/config/+/661826 [01:04:25] ooh okay i see im like 5 minutes behind you [01:04:32] yeah! glad its not that it was in the example [01:04:54] yeah I worried it was there for a moment [01:07:10] so I guess I have to track down releng peeps to try to convince someone to +2 it? [01:09:48] hah yeah I can tomorrow morning too eileen if they arent around [01:10:05] I wonder if elliott had rights? [01:11:24] ill add it to the list i have of CI things [01:11:54] eileen I'm gona have to go soon to my movie (rented the whole theater!! haha) but I'll be back in a couple of hours [01:12:23] cstone: so 2 options [01:12:26] 1) revert [01:12:42] 2) email fr-tech & if anyone gets blocked by it they can revert at that point [01:13:30] - I posed on #wikimedia-releng - I assume that is the right place [01:13:41] yep eileen [01:14:35] i know jack was trying to deploy some stuff but I'm not sure if he did the civi part yet [01:14:59] maybe revert is best for coming up on the weekend eileen [01:16:08] yeah Jack had some vendor stuff to update [01:16:20] that's at the deployment level [01:17:23] since https://gerrit.wikimedia.org/r/c/integration/config/+/661828/1 passed it might be possible to get them to merge that & then we can merge (rather than needing to be both repos at once) [01:19:18] yeah as long as we get across to jack what the status is I think either option is fine [01:19:35] i have to run though, I'll check back here when i get back [01:45:58] Fundraising Sprint Corrugated super slide, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Docker, Patch-For-Review: De-symlink our repos - https://phabricator.wikimedia.org/T273822 (Eileenmcnaughton) @cstone & I forced the change to the drupal repo through just now in the hope the jen... [01:47:37] (PS1) Eileen: Revert "Convert drupal submodule to being 'just a folder'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661830 (https://phabricator.wikimedia.org/T273822) [01:48:50] (CR) Eileen: [C: +2] Revert "Convert drupal submodule to being 'just a folder'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661830 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [01:51:18] Doing the revert as I think the latest patch https://gerrit.wikimedia.org/r/c/integration/config/+/661829 will pave the way for it - we just need to get releng on board [02:15:57] (Merged) jenkins-bot: Revert "Convert drupal submodule to being 'just a folder'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661830 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [13:17:03] Fundraising-Backlog, Continuous-Integration-Config, Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): JJB / zuul support for upgrading payments-wiki to php7.3 and MW 1.35 - https://phabricator.wikimedia.org/T261777 (... [15:03:07] hi everybody, hope that people are subscribed to analytics-announce@, but in case your are not on Tuesday EU morning we (Analytics) are going to upgrade the Hadoop cluster, and it will need some downtime (the famous upgrade that I was talking about in December :) [15:06:49] elukey: thanks for the heads up. I vaguely remember fr-tech discussing this planned downtime and the guy closet to it I believe would be AndyRussG so when he's around later he might have some feedback. thanks again! [15:08:02] thanks a lot! In case there are issues/etc.. feel free to ping me :) [15:13:24] :) [15:52:03] Fundraising-Backlog, fundraising-tech-ops, SRE, Traffic, and 2 others: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561 (MBeat33) [17:31:15] fundraising-tech-ops: Reconfigure fundraising public-reporting server role to fundraising-data - https://phabricator.wikimedia.org/T255435 (Jgreen) [17:35:39] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for seiker - https://phabricator.wikimedia.org/T273491 (Dwisehaupt) Certificate renewed and delivered via email. Password sent via SMS. [19:19:22] cstone: I'm gonna see if I can push out the civicrm deployment [19:19:33] lemme know if you're around and we can jump on a call [19:19:46] I'm just gonna remind myself what's outstanding [19:19:56] hey jgleeson sure [19:21:27] cool I'm join today's standup call [19:27:44] (CR) Jgleeson: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/661510 (owner: Jgleeson) [19:28:28] (CR) Jgleeson: [C: +2] Update vendor submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/661524 (owner: Jgleeson) [19:40:28] (Merged) jenkins-bot: Update vendor submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/661524 (owner: Jgleeson) [19:42:53] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/661510 (owner: Jgleeson) [20:00:17] (CR) Jforrester: [V: +2 C: +2] "No CI for DonationInterface "release" branches (which we should probably disable, but that's hard)." [extensions/DonationInterface] (REL1_35) - https://gerrit.wikimedia.org/r/652987 (owner: Libraryupgrader) [20:00:24] (CR) Jforrester: [V: +2 C: +2] "No CI for DonationInterface "release" branches (which we should probably disable, but that's hard)." [extensions/DonationInterface] (REL1_31) - https://gerrit.wikimedia.org/r/655913 (owner: Libraryupgrader) [20:20:58] Jeff_Green: dwisehaupt did you ever find out anything about those 'fatal bad object' warnings on frpm1001 the other night? [20:21:19] I'm on frpm1001 and we're about to release payments and we're seeing them again :/ [20:21:47] can you try updating donorwiki and see if they happen there? [20:22:07] donorwiki? [20:22:12] -_- [20:22:26] donatewiki [20:22:44] yes that's part of the fun :-) [20:23:22] donorwiki is the working name of the wiki that will sit between donors and civiproxy [20:23:32] got ye [20:23:34] we're gonna rename payments-wiki to donationwiki :-P [20:23:34] lemme try [20:24:09] if that one works then I guess the issue would be something with the git metadata on disk vs gerrit for payments-wiki [20:25:09] i see the bad object warnings there also [20:25:15] specific to submodules with updates [20:25:43] hrmf [20:26:21] so it looks like it either can't see or doesn't like the latest commits to the submodules [20:26:27] I see the following on frpm1001 [20:26:38] fatal: bad object a232fc3438d347deed0af5a782fd133728b7f73d:extensions/DonationInterface [20:26:44] lemme try it on my dev instance, booting it [20:27:40] and that hash is commit on mediawiki core (our branch) relating to the commit inside the submodule [20:27:46] kinda confusing [20:27:57] yeah [20:29:07] fundraising-code-update seems to have worked in virtualbox [20:29:33] there I went from 99397d7222 to a232fc3438 [20:29:51] yeah weirdly it complains but then a few lines down I can see the submodule updated and new files added [20:30:16] it could be just an artifact of how it's trying to extract things to lint check them [20:30:26] did it seem to update successfully in the end? [20:30:59] https://stackoverflow.com/questions/11834108/fatal-bad-object-xxx [20:31:10] looks like a bad ref link somehow [20:32:38] it does look like it's pulled in the files [20:33:51] yeah, I just updated donorwiki and it seemed to go ok [20:34:16] just gonna test it locally [20:34:20] then deploy and test the code [20:34:26] and if it breaks I'll revert [20:34:30] should be pretty quiet now [20:34:34] traffic wise [20:34:54] ok [20:38:40] I think I know what it is [20:39:06] does frpm git clone via ssh? [20:39:22] gerrit for some reason seems to be redirecting ssh traffic to https [20:39:34] I've seen this a few times this week, warning: redirecting to https://gerrit.wikimedia.org/r/mediawiki/extensions/DonationInterface.git/ [20:39:49] warning: redirecting to https://gerrit.wikimedia.org/r/mediawiki/extensions/cldr.git/ [20:39:56] during a git clone / git submodule init [20:40:16] after the original clone was via ssh://repo-url [20:40:27] I wonder if that redirect message is causing problems [20:41:02] good question, I don't know [20:46:23] just testing locally [20:46:51] ok I can see the error locally [20:46:53] or an error [20:46:55] if you run [20:46:57] git clone --single-branch --branch=fundraising/REL1_35 --depth=1 --recurse-submodules ssh://jgleeson@gerrit.wikimedia.org:29418/mediawiki/core [20:47:23] with your own login you will see the new "redirect to https" message when it tries to clone donation interface [20:51:24] I'll take it up with releng on monday Jeff_Green. i think it's repo related [20:51:36] hopefully that one liner will be enough to show them [20:51:42] ok [20:51:57] for what it's worth, the deploy tool always uses https [20:52:09] oh interesting [20:52:55] maybe it's two unrelated things :/ [21:02:34] Jeff_Green: deploy looks like it went ok [21:04:22] great [21:07:13] (CR) Cstone: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661480 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [21:08:51] Fundraising Sprint Corrugated super slide, Fundraising-Backlog: Update Smashpig static currency rates for 2021 - https://phabricator.wikimedia.org/T273755 (jgleeson) @Eileenmcnaughton, @Cstone and I just pushed the latest civi out along with payments. Thanks for the help merging stuff into vendor. [21:32:06] (Merged) jenkins-bot: One symlink down [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/661480 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [22:30:53] cstone: did you try communicating with releng? [22:31:23] I don't think they responded to my ping