[00:01:53] Fundraising-Backlog, Analytics, FR-Tech-Analytics: Whitelist Portal and WikipediaApp event data for (sanitized) long-term storage - https://phabricator.wikimedia.org/T273246 (EYener) Thank you @mforns and apologies that it took me a while to return to this. I've submitted three individual reviews for... [00:18:35] (Merged) jenkins-bot: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666230 (owner: Eileen) [00:26:08] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/666235 [00:26:13] dwisehaupt: are you around? [00:26:42] (CR) Eileen: [C: +2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/666235 (owner: Eileen) [00:34:30] eileen: howdy [00:35:01] dwisehaupt: I am just about to deploy a patch that alters our repo (changes drupal folder to no longer be a submodule) [00:35:15] I just wanted to check if you are about if anything weird happens... [00:36:17] i am actively about for a little while. about 20-25 more minutes. [00:36:33] after that i have to get the kids prepped for the evening's activities [00:44:49] ok - doing it now [00:46:25] !log civicrm revision changed from c535ac603a to 5e042e6e57, config revision is ef64f705bb [00:46:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:46:52] site still loads so I think all was fine [00:47:19] ha. :) [00:47:55] I'm adding the index I mentioned - but it only took 1 min on staging - will cancel if it starts to look like that is not the case [00:52:56] Fundraising-Backlog, fundraising-tech-ops: Fix our database to support emojis - convert tables to utf8mb4 - https://phabricator.wikimedia.org/T270218 (Dwisehaupt) Running tests on a restored copy of the civicrm db on frdb2002 for timings. [00:53:37] index add finished - just as I started to get nervous :-) [00:53:42] Fundraising-Backlog, fr-donorservices: Italian mobile form obscures the card number field - https://phabricator.wikimedia.org/T275458 (MBeat33) [00:54:00] yeah, that tends to be the case most of the time. [00:58:35] Fundraising-Backlog, fr-donorservices: Italian mobile form obscures the card number field - https://phabricator.wikimedia.org/T275458 (MBeat33) [01:04:33] replication of that query is still rolling but i expect it will clear soon. i see the query chugging along on frdb2002 so little concern. [01:07:50] stepping away. back later to check on these alters. [01:15:38] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1310 [01:17:28] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1427 [01:18:38] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1493 [01:20:08] ACKNOWLEDGEMENT - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1493 Dwisehaupt Alter rolling through the replicas. known. [01:20:08] ACKNOWLEDGEMENT - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1427 Dwisehaupt Alter rolling through the replicas. known. [01:20:08] ACKNOWLEDGEMENT - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1310 Dwisehaupt Alter rolling through the replicas. known. [01:27:23] it has cheered up [01:48:38] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 1598639 Threads: 12 Questions: 22212387 Slow queries: 742 Opens: 21447 Flush tables: 1 Open tables: 921 Queries per second avg: 13.894 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [01:52:34] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 1846017 Threads: 12 Questions: 25411427 Slow queries: 846 Opens: 23922 Flush tables: 1 Open tables: 863 Queries per second avg: 13.765 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [02:20:38] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 384188 Threads: 16 Questions: 4593515 Slow queries: 224732 Opens: 12703387 Flush tables: 1 Open tables: 200 Queries per second avg: 11.956 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [03:07:37] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, fr-donorservices: Italian mobile form obscures the card number field - https://phabricator.wikimedia.org/T275458 (DStrine) p:Triage→High [03:07:59] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, fr-donorservices: Italian mobile form obscures the card number field - https://phabricator.wikimedia.org/T275458 (DStrine) I'll talk to fr-tech about this tomorrow. [03:54:56] eileen: well I've almost got it working, guess that was more than 5 min heheh [03:55:17] ah well - not by much [03:55:36] ehhh 12 and counting [03:55:50] :-) [04:00:27] (PS1) AndyRussG: WIP Expose MariaDB port and make it configurable [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/666244 (https://phabricator.wikimedia.org/T266094) [04:00:42] eileen: ^ but it doesn't seem to work from the host [04:01:03] maybe something about the mysql config [04:01:10] AndyRussG: as in the port doesn't? [04:01:39] yeah I'm trying: mysql -h localhost -P 33306 -u root [04:02:05] & you entered that when loading it? [04:02:08] 33306 is the port I configured locally using setup.sh and according to docker-compose ps it is exposed [04:02:17] yeah [04:02:20] ah [04:02:25] not -hlocalhost [04:02:27] -hdatabase [04:02:41] eileen: well database is not a dns name on the host network [04:02:57] only on the internal network shared by the services in docker-compose.yml [04:03:24] I did hack into the container to ask it its IP address, and was able to connect successfully to that ip address on the normal MySQL port [04:03:24] I'll test it out in a bit [04:03:39] okok thanks I'll send an update if I have one :) [04:05:10] oh huh it works if I say 127.0.0.1 for the host [04:05:23] hmm - odd [04:05:26] mysql -h 127.0.0.1 -P 33306 -u root [04:05:38] there is that socket thing (in the back of my mind) [04:05:45] (and put in whatever port number you configure instead of 33306) [04:05:48] ? [04:06:08] huh the back of my mind lacks one of those [04:06:57] :-) [04:08:03] https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_skip_name_resolve [04:09:14] 127.0.0.1 seems fine really [04:09:52] welp yeah but... why add an unneeded gotcha [04:10:09] I kinda do want to be able to configure the DB anyway [04:15:00] eileen: btw friendly reminder, don't update the fundraising-dev repo without saying docker-compose down first [04:24:05] https://serverfault.com/a/337844 [04:24:08] That's it [04:24:35] apparently a client issue [04:25:00] using 127.0.0.1 forces it to use tcp, otherwise if yous say localhost it tries to use a unix socket [05:02:50] (PS2) AndyRussG: MariaDB setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/666244 (https://phabricator.wikimedia.org/T266094) [05:03:29] eileen: done! https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/666244/ [05:03:42] ok so 70 minutes = only 14 times longer than expected [05:03:42] AndyRussG: oh - I did put you to a bit of work [05:03:51] eileen ahhh all good heheh [05:03:53] yeah howzat for estimation... [05:03:58] welp [05:04:23] it's still within a small error margin of less than 1-2 hours difference [05:04:33] added a few bells and whistles [05:14:34] eileen: btw also added a placeholder on the host for custom mysql config. I think there are settings to make it dump all the queries it's making [05:14:53] cool [05:35:14] (PS3) AndyRussG: MariaDB setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/666244 (https://phabricator.wikimedia.org/T266094) [05:37:44] (PS4) AndyRussG: MariaDB setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/666244 (https://phabricator.wikimedia.org/T266094) [05:59:51] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: get dmaster working on docker civicrm - https://phabricator.wikimedia.org/T274944 (Eileenmcnaughton) Merged, works [06:00:09] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: get dmaster working on docker civicrm - https://phabricator.wikimedia.org/T274944 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton [06:00:38] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: get tests & xdebug working on civicrm docker - https://phabricator.wikimedia.org/T274943 (Eileenmcnaughton) Just a bunch of test cleanups in review [06:01:18] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: SIlverpop - update our list of database ids - https://phabricator.wikimedia.org/T273833 (Eileenmcnaughton) a:Eileenmcnaughton [06:12:52] Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (Eileenmcnaughton) @RLewis yes sorry - please try again - the first error is on this contact civicrm/contact/view?reset=1&cid=50372691 and is Error: Duplicate error - existing contribution record(s) have a matc... [11:58:54] Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (RLewis) {F34119706} - this is the import screen I had when it completed the import. [12:39:03] Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (RLewis) I'm not convinced that everything is imported though as the total for Feb in Civi is $623k but the wire amount and the file amount was $680k? [14:02:15] fundraising-tech-ops: Investigate/setup prometheus blackbox_exporter for fundraising - https://phabricator.wikimedia.org/T273478 (Jgreen) Open→Resolved a:Jgreen Looked into this a bit, for our purposes the existing endpoint_checker does what we need. [14:03:02] Fundraising-Backlog, Performance Issue: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404 (Jgreen) [14:05:12] Fundraising-Backlog, fundraising-tech-ops: Investigate increase syslog volume on civi1001 after buster upgrade - https://phabricator.wikimedia.org/T260000 (Jgreen) [14:06:26] fundraising-tech-ops: evaluate whether we can improve mariadb performance with mariadb tuning and/or hardware changes - https://phabricator.wikimedia.org/T245651 (Jgreen) Open→Invalid Too vague to be actionable, also we're already doing this as part of other tasks. [14:07:45] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Permissions to git-update staging civi for select FR-creative members - https://phabricator.wikimedia.org/T232386 (Jgreen) Open→Declined [14:08:55] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Permissions to git-update staging civi for select FR-creative members - https://phabricator.wikimedia.org/T232386 (Jgreen) Declined→Resolved [14:09:06] fundraising-tech-ops: evaluate whether we can improve mariadb performance with mariadb tuning and/or hardware changes - https://phabricator.wikimedia.org/T245651 (Jgreen) Invalid→Resolved [14:24:12] Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (RLewis) @Eileenmcnaughton it's now up to $671k but I'm unsure of what is missing. [14:52:54] fundraising-tech-ops: fr-log-announcer reporting logins to payments2xxx servers multiple times - https://phabricator.wikimedia.org/T251175 (Jgreen) Open→Resolved a:Jgreen This was fixed by ceasing the duplicate logging to both loggers, which was a hack to support orphan rectification when we were... [14:58:03] fundraising-tech-ops: Plan for FY 2020-21 Q3 maintenance window - https://phabricator.wikimedia.org/T268056 (Jgreen) [14:58:05] Fundraising-Backlog, fundraising-tech-ops, Epic: examine the possibility of purging data from civicrm.civicrm_activity - https://phabricator.wikimedia.org/T261353 (Jgreen) [15:04:00] fundraising-tech-ops, observability, Epic: [Epic] overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508 (Jgreen) [15:04:06] Fundraising-Backlog, fundraising-tech-ops, FR-Smashpig: collect SmashPig database/queue metrics to fundraising prometheus/grafana - https://phabricator.wikimedia.org/T162946 (Jgreen) Open→Declined declining due to task age vs progress [15:07:38] Fundraising-Backlog, Fundraising-Backlog-Old, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963 (Jgreen) [15:07:40] Fundraising-Backlog, FR-Smashpig: Add SmashPig config to settings repo - https://phabricator.wikimedia.org/T129706 (Jgreen) [15:07:42] Fundraising-Backlog, Fundraising-Backlog-Old, fundraising-tech-ops, Technical-Debt: All fundraising configuration should be deployed from either puppet templates or a private git repo - https://phabricator.wikimedia.org/T110224 (Jgreen) [15:11:26] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Silverpop - update our list of database ids - https://phabricator.wikimedia.org/T273833 (Jgreen) [15:16:15] fundraising-tech-ops: Plan for FY 2020-21 Q3 maintenance window - https://phabricator.wikimedia.org/T268056 (Jgreen) [15:16:18] fundraising-tech-ops: promote frqueue1003 to fundraising queue redis leader - https://phabricator.wikimedia.org/T274681 (Jgreen) [15:18:17] fundraising-tech-ops: Plan for FY 2020-21 Q3 maintenance window - https://phabricator.wikimedia.org/T268056 (Jgreen) [16:37:38] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1001:down [16:39:34] we are rebooting the kafka jumbo cluster for kernel upgrades :) --% [16:39:37] --^ [16:42:38] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [16:53:43] (PS1) Ejegg: Update http-foundation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666408 (https://phabricator.wikimedia.org/T271212) [16:54:03] thanks elukey! [16:55:59] ejegg: I'm working through those patches on the ticket [16:56:03] are you picking a few up? [16:56:25] we pulled it back into sprint last night [16:57:03] ejegg: see https://phabricator.wikimedia.org/T271212#6850675 [17:02:31] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1002:down [17:07:33] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1009:down [17:07:38] Ah jgleeson sorry to duplicate the work [17:07:50] I just saw that the httpFoudnation one was dead simple [17:11:14] no worries! [17:12:33] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [17:16:04] elukey: just saw your heads up re. kafka, thank you! [17:22:28] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1003:down [17:27:34] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1003:down [17:32:28] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1003:down [17:32:33] Today's music recommendation: Dr. Demento 20th Anniversary Collection - The greatest novelty records of all time vol 2. Specifically 'Fish Heads': https://www.youtube.com/watch?v=JKDtUzRIG6I [17:32:38] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1003:down [17:33:05] oh wait, there's an official video: https://www.youtube.com/watch?v=cn73Wtem0No [17:37:28] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [17:37:44] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [17:45:19] ok, maybe I can't listen to that whole album at once... [17:46:31] Fundraising-Backlog, fundraising-tech-ops: Fix our database to support emojis - convert tables to utf8mb4 - https://phabricator.wikimedia.org/T270218 (Dwisehaupt) Alters complete on all tables except log_%. Rough time estimate to alter those tables was 7.1 hours with a minimal footprint reduction of ~17M... [17:47:57] Fundraising-Backlog, fundraising-tech-ops: Update mariadb GLOBAL defaults for frdbs in preparation for utf8mb4 conversion - https://phabricator.wikimedia.org/T274438 (Dwisehaupt) Open→Resolved Closing this out as we will catch frdb1002 into this mix when we have our maintenance window. [17:47:59] Fundraising-Backlog, fundraising-tech-ops: Fix our database to support emojis - convert tables to utf8mb4 - https://phabricator.wikimedia.org/T270218 (Dwisehaupt) [17:48:05] Fundraising-Backlog, fundraising-tech-ops: Fix our database to support emojis - convert tables to utf8mb4 - https://phabricator.wikimedia.org/T270218 (Dwisehaupt) a:Dwisehaupt [17:52:26] Wikimedia-Fundraising-Banners: QA Dsk Lg - https://phabricator.wikimedia.org/T275526 (jbolorinos-ctr) [17:56:09] Wikimedia-Fundraising-Banners: QA Dsk Sm - https://phabricator.wikimedia.org/T275528 (jbolorinos-ctr) [17:57:28] Wikimedia-Fundraising-Banners: QA Dsk Sm - https://phabricator.wikimedia.org/T275528 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/ze6672e5061f4421f891 [17:57:43] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1004:down [17:58:13] Wikimedia-Fundraising-Banners: QA M Lg - https://phabricator.wikimedia.org/T275530 (jbolorinos-ctr) [17:59:24] Wikimedia-Fundraising-Banners: QA M Lg - https://phabricator.wikimedia.org/T275530 (jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/ze78ae0d0cca7eef29a6 [17:59:50] Wikimedia-Fundraising-Banners: QA M Sm - https://phabricator.wikimedia.org/T275532 (jbolorinos-ctr) [18:00:51] Wikimedia-Fundraising-Banners: QA M Sm - https://phabricator.wikimedia.org/T275532 (jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z59334e7ce6a1cbc64d2 [18:02:41] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [18:04:31] Wikimedia-Fundraising-Banners: QA Dsk Lg - https://phabricator.wikimedia.org/T275526 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z75fea4bc740a44649e0 [18:05:06] Wikimedia-Fundraising-Banners: QA Dsk Lg - EN - https://phabricator.wikimedia.org/T275526 (jbolorinos-ctr) [18:05:21] Wikimedia-Fundraising-Banners: QA Dsk Sm - EN - https://phabricator.wikimedia.org/T275528 (jbolorinos-ctr) [18:09:50] Wikimedia-Fundraising-Banners: [Dsk Sm] Bank Transfer button appears larger than other payment options on smaller screen sizes - https://phabricator.wikimedia.org/T275534 (jbolorinos-ctr) [18:28:18] Wikimedia-Fundraising-Banners: QA for Italy Launch Banners - https://phabricator.wikimedia.org/T275537 (HNordeenWMF) [18:31:59] oh, just read the news. New album recommendation fr-tech: Daft Punk - Discovery [18:32:34] Wikimedia-Fundraising-Banners: QA for Italian Banners - https://phabricator.wikimedia.org/T275538 (HNordeenWMF) [18:32:57] Wikimedia-Fundraising-Banners: QA for itIT Banners - https://phabricator.wikimedia.org/T275538 (HNordeenWMF) [18:35:46] Wikimedia-Fundraising-Banners: QA for enIT Banners - https://phabricator.wikimedia.org/T275539 (HNordeenWMF) [18:39:56] Wikimedia-Fundraising-Banners: Italy Launch Banners QA - https://phabricator.wikimedia.org/T275537 (HNordeenWMF) [18:40:41] Wikimedia-Fundraising-Banners: Latin America Pre-test Banners QA - https://phabricator.wikimedia.org/T275446 (HNordeenWMF) [18:47:39] PROBLEM - check_kafkatee on frban2001 is CRITICAL: CRITICAL: kafka-jumbo1006:down [18:47:39] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1006:down [18:48:29] updating some local packages and came across this stunner in the redis.conf diff: [18:48:32] Redis contains an implementation of the Gopher protocol, as specified in [18:48:35] +# the RFC 1436 (https://www.ietf.org/rfc/rfc1436.txt). [18:51:14] gopher was peak internet. [18:52:33] RECOVERY - check_kafkatee on frban2001 is OK: OK: brokers:9 topics:2 [18:52:42] ooh, redis 6 also has ACLs and such rather than just 1 master password [18:52:43] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 [18:54:17] nice... gopher://gopherpedia.com [19:00:37] > Work it harder, make it better / Do it faster, makes us stronger [19:16:05] Fundraising-Backlog, Wikimedia-Fundraising-Banners: diting es in latam - https://phabricator.wikimedia.org/T275543 (DStrine) [19:19:07] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Editing es in latam links shows some strings in english - https://phabricator.wikimedia.org/T275545 (DStrine) [19:57:40] Wikimedia-Fundraising, donate.wikimedia.org: Translate donation support pages into Latin American Spanish - https://phabricator.wikimedia.org/T199685 (CDenes_WMF) Adding Tomasz' email here to have everything aggregated in one place: Hi Peter, Happy Monday, the proofreading of Spanish/Portuguese/Portug... [19:58:53] Wikimedia-Fundraising, donate.wikimedia.org: Translate donation support pages into Latin American Spanish - https://phabricator.wikimedia.org/T199685 (CDenes_WMF) Note that pt-Portugal is not a priority for coding. We can shelf that until prep for the Big Bundle (or whenever bandwidth allows) . Thanks! [20:09:28] Fundraising-Backlog, FR-Docker, Patch-For-Review: MySQL Workbench connection on Docker - https://phabricator.wikimedia.org/T266094 (AndyRussG) I wasn't able to install MySQL Workbench on my Debian Bullseye laptop. However, [[ https://www.libreoffice.org/discover/base/ | LibreOffice Base ]] worked fin... [20:18:06] (CR) AndyRussG: [C: +2] "Woohooo!!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665212 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:20:29] (CR) AndyRussG: [C: +2] "Eeeee" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665239 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:21:03] (CR) AndyRussG: [C: +2] Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665240 (owner: Eileen) [20:24:05] (CR) AndyRussG: [C: +2] Improve Buffy cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665196 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:24:51] (CR) AndyRussG: [C: +2] Remove now-obsolete PEAR error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665195 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:26:19] (CR) AndyRussG: [C: +2] Improve Ponyo cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665194 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:29:08] (CR) AndyRussG: Further minor fixes from upstream EmailAmmender repo (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665217 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:30:44] (CR) AndyRussG: [C: +2] One less Test DAF 123827162 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665241 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:33:15] (CR) Eileen: Further minor fixes from upstream EmailAmmender repo (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665217 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:37:51] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Editing es in latam links shows some strings in english - https://phabricator.wikimedia.org/T275545 (XenoRyet) Here's the 'es' url that gives me Spanish https://payments.wikimedia.org/index.php?title=Special:AstroPayGateway&appeal=JimmyQuote&ffname=ast... [20:49:35] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog: Fill out SAQ A forms to be sent to PSPs - https://phabricator.wikimedia.org/T274935 (XenoRyet) Done state on this is that the latest SAQ-A form is filled out and given to (probably) Evelin to send on to they payments providers when due. [20:53:37] (Merged) jenkins-bot: Improve Ponyo cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665194 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:53:39] (Merged) jenkins-bot: Remove now-obsolete PEAR error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665195 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:53:41] (Merged) jenkins-bot: Improve Buffy cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665196 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:53:43] (Merged) jenkins-bot: Fix cleanup on email-amender [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665212 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [20:54:25] (PS2) Eileen: Stick with a nice clean mouse [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665239 (https://phabricator.wikimedia.org/T274943) [20:54:46] (PS2) Eileen: Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665240 [20:55:16] (PS2) Eileen: One less Test DAF 123827162 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665241 (https://phabricator.wikimedia.org/T274943) [20:57:27] (Abandoned) Eileen: don't use collation on blob fields [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/666219 (owner: Eileen) [20:58:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (DStrine) [20:59:11] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (DStrine) [21:01:05] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Editing es in latam links shows some strings in english - https://phabricator.wikimedia.org/T275545 (DStrine) In incognito I was able to get all spanish using this link. I think my browser was caching things. https://payments.wikimedia.org/index.php?t... [21:07:21] fr-tech here's the (trivial) core patch to at least show es-419 strings on payments interface: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/665117 [21:08:19] then the slightly less trivial DonationInterface patch to pass the full code along to Civi: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/665140 [21:11:24] (PS1) Jgleeson: Updated symfony/http-foundation to v2.8.52 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666448 (https://phabricator.wikimedia.org/T271212) [21:11:26] (PS1) Jgleeson: Updated phpmailer/phpmailer to v 5.2.28 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666449 (https://phabricator.wikimedia.org/T271212) [21:11:47] (CR) jerkins-bot: [V: -1] Updated phpmailer/phpmailer to v 5.2.28 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666449 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:12:25] hmm how did rector.php sneak in there! [21:12:39] fr-tech dstrine was there a verdict about bringing this into the sprint, to be placed now in the "Review" column? I think the review needed on it is pretty minimal, so it shouldn't slow us down much? thx in advance! [21:12:47] https://phabricator.wikimedia.org/T266094 [21:13:13] I don't remember discussing this [21:14:45] dstrine I mentioned it in my hurried update in the meeting just now [21:15:00] dstrine it was the thing that I thought would take 5 minutes and took 1hr 10 min [21:15:13] oh so it's already done? [21:15:20] dstrine yep! [21:15:25] just needs a quick +2 [21:15:26] ok [21:15:33] sorry if I wasn't clear [21:15:36] (PS2) Jgleeson: Updated phpmailer/phpmailer to v 5.2.28 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666449 (https://phabricator.wikimedia.org/T271212) [21:15:45] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, FR-Docker, Patch-For-Review: MySQL Workbench connection on Docker - https://phabricator.wikimedia.org/T266094 (DStrine) [21:16:10] (CR) jerkins-bot: [V: -1] Updated phpmailer/phpmailer to v 5.2.28 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666449 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:16:37] dstrine fr-tech thanks much! [21:16:41] Fundraising-Backlog, Wikimedia-Fundraising-Banners: diting es in latam - https://phabricator.wikimedia.org/T275543 (DStrine) Open→Resolved [21:19:26] I'm gonna need to re-do the de-symlinking patch but this change supports it & can be merged https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/664960 [21:19:51] ejegg: I also updated the composer.json file on the symfony foundation package as it specified a seemingly old version (2.1) which I figured we'd want to update also. https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/666448/1/composer.json [21:20:14] ah cool jgleeson, thanks for that [21:20:48] jgleeson: let's maybe not get that specific in the .json file though? [21:20:59] just leave it at ^2.8 ? [21:21:29] eileen jgleeson fr-tech: are these two tasks not somewhat overlapping? and also jgleeson these are indeed the tests you were talking about, right? https://phabricator.wikimedia.org/T274839 https://phabricator.wikimedia.org/T274943 [21:21:38] that's just setting the base to that version right? [21:22:01] I think ^2.8.52 will prevent any auto-updates to 2.9 [21:22:15] while ^2.8 will just prevent auto updates to 3.x + [21:22:16] ah no I think that's what ~ does [21:22:24] oh oops [21:22:25] oh [21:22:30] maybe I have it the wrong way around [21:22:35] i have to read that page again [21:22:35] I thought the ~ was the more specific [21:22:43] yeah confusing eh [21:23:14] ah yeah, caret does allow all non-breaking updates [21:23:22] ok then, that patch looks good [21:23:28] ah cool [21:25:14] (CR) Ejegg: [C: +2] Updated symfony/http-foundation to v2.8.52 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666448 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:25:49] I need to fix the lock file is seems [21:25:50] (Merged) jenkins-bot: Updated symfony/http-foundation to v2.8.52 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666448 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:25:56] hmm, guess so [21:28:32] (PS3) Jgleeson: Updated phpmailer/phpmailer to v 5.2.28 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666449 (https://phabricator.wikimedia.org/T271212) [21:30:04] ok it likes it now [21:32:39] ok once that one is merged I guess I'll tag a new version of smashpig and push it out to civicrm and payments which tick off a bunch of items on the list [21:32:56] ticks* [21:36:07] fr-tech is anyone got a min to +2 a minor version bump? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/666449/ [21:38:10] (CR) XenoRyet: [C: +2] Updated phpmailer/phpmailer to v 5.2.28 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666449 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:38:30] jgleeson^ [21:39:02] thanks XenoRyet & ejegg ! [21:39:12] (Merged) jenkins-bot: Updated phpmailer/phpmailer to v 5.2.28 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666449 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:51:16] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/666473 [21:53:08] (CR) Jgleeson: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/666473 (owner: Jgleeson) [21:57:03] Wikimedia-Fundraising-Banners: QA M Lg - EN - https://phabricator.wikimedia.org/T275530 (jbolorinos-ctr) [21:57:24] Wikimedia-Fundraising-Banners: QA M Sm - EN - https://phabricator.wikimedia.org/T275532 (jbolorinos-ctr) [21:58:54] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/666473 (owner: Jgleeson) [22:00:05] now the fun part [22:00:20] updating smashpig as a composer package -_- [22:00:34] I'll start with civirm [22:00:37] civicrm* [22:23:05] fr-tech, if you put in ` composer info wikimedia/smash-pig` do you see v0.6.7 as the latest? I only see v0.6.6 but over on packagist I see the new v0.6.7 tag https://packagist.org/packages/wikimedia/smash-pig [22:25:21] hmm I don't think info looks beyond the local packages [22:26:14] oh but if I put in `composer outdated wikimedia/smash-pig` I do see the new version [22:26:25] hmm I wonder if I can update it now, maybe a cache thing [22:28:25] nope [22:28:32] argh [22:30:01] (CR) Eileen: [C: +2] "Yep, this works!" [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/666244 (https://phabricator.wikimedia.org/T266094) (owner: AndyRussG) [22:34:35] oh this is interesting it looks like the smashpig version of phpmailer is conflicting with civicrm's version [22:34:46] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Add es-419 as a supported 'preferred language' in Civi - https://phabricator.wikimedia.org/T199733 (Ejegg) a:Ejegg [22:34:49] (PS1) Ejegg: Allow es-419 style language codes in message import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) [22:37:03] (CR) AndyRussG: Reformat, remove silly function (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665243 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [22:37:09] jgleeson lemme try locally [22:39:53] ejegg: I think I figured it out, my new min version for smashpig is higher than the composer.lock version of phpmailer on the civicrm project [22:40:14] it looks like that specific bump of the min version tripped me up [22:41:04] so I'm gonna update phpmailer in civicrm which should get us to the right version and then update smashpig (which should no longer hopefully cause the conflict)_ [22:41:28] ah yeah, locally update smashpig phpmailer both at once works for me [22:41:40] this is the composer output when I tried to pull in the new tag https://phabricator.wikimedia.org/P14452 [22:41:53] oh cool [22:42:29] fr-tech I'll be about 5 min late for tech-talk, apologies! [22:43:50] yep that is now working ejegg, thanks! [22:44:53] ok fr-tech, the civi changes for es-419 are pretty minimal too: https://gerrit.wikimedia.org/r/666476 [22:45:14] ah, I should check the thank you mailer with that [22:49:24] (PS1) Jgleeson: Update Composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666480 (https://phabricator.wikimedia.org/T271212) [22:54:51] (CR) jerkins-bot: [V: -1] Allow es-419 style language codes in message import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) (owner: Ejegg) [22:59:53] Fundraising-Backlog: Brazil TY page in English and not Portuguese - https://phabricator.wikimedia.org/T275576 (EMartin) [23:02:52] (PS2) Ejegg: Allow es-419 style language codes in message import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) [23:05:28] Fundraising-Backlog: TY page for failed BT transaction in Brazil - https://phabricator.wikimedia.org/T275577 (EMartin) [23:23:29] (CR) jerkins-bot: [V: -1] Allow es-419 style language codes in message import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) (owner: Ejegg) [23:43:03] (CR) Eileen: [C: +2] "+2 because these updates are fine - but php 5.2.27 vs 5.2.28 is close to a no-change change" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666480 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson)