[00:04:10] (Merged) jenkins-bot: Update Composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666480 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [00:46:11] (CR) Eileen: Reformat, remove silly function (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665243 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [00:47:03] (Abandoned) Eileen: Remove campaign_id pseudoconstants [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/660073 (owner: Eileen) [00:47:53] (Abandoned) Eileen: Retrigger tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/664406 (owner: Eileen) [02:16:59] (Abandoned) Ejegg: Add es-419 support with fallback to es [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/665117 (owner: Ejegg) [02:25:18] (PS1) Eileen: Composer update on twig/twig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666512 (https://phabricator.wikimedia.org/T271212) [02:31:24] (PS5) Ejegg: Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) [02:31:26] (PS1) Ejegg: Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) [02:33:14] (CR) jerkins-bot: [V: -1] Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) (owner: Ejegg) [02:33:19] (CR) jerkins-bot: [V: -1] Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) (owner: Ejegg) [02:35:24] (PS2) Ejegg: Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) [02:35:26] (PS6) Ejegg: Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) [02:37:31] (CR) jerkins-bot: [V: -1] Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) (owner: Ejegg) [02:37:34] (CR) jerkins-bot: [V: -1] Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) (owner: Ejegg) [02:48:02] (CR) AndyRussG: [V: +2] "> Patch Set 4: Code-Review+2" [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/666244 (https://phabricator.wikimedia.org/T266094) (owner: AndyRussG) [02:50:55] (PS3) Ejegg: Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) [02:50:57] (PS7) Ejegg: Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) [02:52:41] (CR) jerkins-bot: [V: -1] Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) (owner: Ejegg) [02:52:43] (CR) jerkins-bot: [V: -1] Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) (owner: Ejegg) [03:00:08] (CR) AndyRussG: "LGTM!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665243 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [03:00:44] (CR) AndyRussG: Reformat, remove silly function (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665243 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [03:01:21] eileen ^ just some more minor comments [03:01:39] (PS1) Ejegg: Update SmashPig and vendor dir [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/666515 [03:02:44] hmm the submodule thing could be a local issue [03:03:21] (PS2) Ejegg: Update SmashPig and vendor dir [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/666515 [03:03:49] ooh, changeset double-beast is coming up [03:04:03] (CR) Ejegg: [C: +2] Update SmashPig and vendor dir [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/666515 (owner: Ejegg) [03:04:05] worse than a double-bass? [03:04:26] or when the two merge, a double-baste? [03:04:37] extra juicy? [03:05:19] the gentle, deep pizzicato notes of bbq sauce [03:08:48] (Abandoned) Ejegg: Update http-foundation [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/666408 (https://phabricator.wikimedia.org/T271212) (owner: Ejegg) [03:12:26] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: Preparing Slave SQL: Yes Seconds Behind Master: (null) [03:16:36] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) (owner: Ejegg) [03:17:10] (Merged) jenkins-bot: Update SmashPig and vendor dir [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/666515 (owner: Ejegg) [03:17:28] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 1937517 Threads: 12 Questions: 26656146 Slow queries: 908 Opens: 35273 Flush tables: 1 Open tables: 872 Queries per second avg: 13.757 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [03:18:54] (CR) AndyRussG: [C: +2] "> Patch Set 2:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665243 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [03:20:22] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (Eileenmcnaughton) @rlewis so according to that screenshot everything imported except the 20 rows that are in the error file - do they... [03:20:46] (PS4) Ejegg: Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) [03:20:48] (PS8) Ejegg: Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) [03:23:02] (CR) Eileen: "AndyRussG - I found it - commit bce35c46f4f83ceab4de2644a869e38e61c639f4 adds the civicrm_initialize() function into sites/default/bootstr" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665217 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [03:30:07] (CR) AndyRussG: Sorry Christine... you are to be deleted (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665242 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [03:39:16] lolol dstrine did you notice this fine print in your new isp signup? https://www.theregister.com/2021/02/23/starlink_moon/ [03:40:52] ok, signing off, folks. have a good night! [03:45:07] (CR) AndyRussG: Sorry Christine... you are to be deleted (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665242 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [03:46:12] (Merged) jenkins-bot: Further minor fixes from upstream EmailAmmender repo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665217 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [03:49:57] (CR) AndyRussG: Add check to lock in our new lower cruft creation (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [03:51:42] (CR) AndyRussG: Fix one more contact-cruft creator (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665244 (owner: Eileen) [03:52:38] eileen heyyy so I've now either commented on or +2'ed all the patches in the chain [03:52:51] yay - thanks [03:53:08] I wish I had deeper comments to offer than mostly formatting details and superficial questions [03:53:23] (PS4) Eileen: Sorry Christine... you are to be deleted [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665242 (https://phabricator.wikimedia.org/T274943) [03:53:27] but I guess this is the sort of the review that u suggested :) [03:53:35] yw! :) [03:53:44] AndyRussG: yeah - but it might be overkill when it's just test cleanup [03:53:56] I just saw 'publish edit' [03:54:02] on the Christine one [03:55:17] eileen: ahhh okok... heheh yeah I think I've never used that feature (also not the additional comment there btw) [03:55:21] *note [03:56:04] AndyRussG: if you want to +2 this I can reformat the class afterwards - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/665244/1/sites/all/modules/wmf_communication/tests/phpunit/CiviMailTestBase.php - the new indentation is 'correct' per the drupal std that file should use [03:57:58] (PS5) Eileen: Sorry Christine... you are to be deleted (test cleanup) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665242 (https://phabricator.wikimedia.org/T274943) [03:58:14] OK - I fixed the Christine comment [03:59:06] (CR) AndyRussG: [C: +2] ":)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665244 (owner: Eileen) [03:59:37] (CR) Eileen: Fix one more contact-cruft creator (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665244 (owner: Eileen) [03:59:47] (CR) AndyRussG: [C: +2] "Wooohooo!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665242 (https://phabricator.wikimedia.org/T274943) (owner: Eileen) [04:00:47] K looks like just this one left: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/538359 [04:03:01] eileen ^ on that one, I now see there's more explanation in the commit message [04:03:20] (CR) Eileen: Add check to lock in our new lower cruft creation (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [04:04:05] (PS2) Eileen: Fix one more contact-cruft creator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665244 [04:04:30] AndyRussG: so the reason to add the check is so we don't break the clean up again [04:05:19] It's probably not best test practice in some ways but it does give us some protection against future us [04:06:03] A bit like tell the kids that there is chocolate in the cupboard - - it is now being watched [04:06:35] (PS6) Eileen: Sorry Christine... you are to be deleted (test cleanup) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/665242 (https://phabricator.wikimedia.org/T274943) [04:08:25] (CR) AndyRussG: Add check to lock in our new lower cruft creation (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [04:08:49] eileen: right, makes sense... last comment is just some thoughts on how to communicate this more :) [04:09:41] ok cool - good idea [04:12:01] (PS16) Eileen: Add check to lock in our new lower cruft creation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 [04:12:08] AndyRussG: I've edited a bit [04:13:06] Also AndyRussG if you can check https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/664960 - it just prepares for the planned removal of the sites symlink by using the unsymlined path [04:16:28] Ok - I that git review probably should wait until the other is merged [04:16:38] eileen: okok... also https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/538359 needs a rebase, then I'll +2 okok? [04:17:21] (PS17) Eileen: Add check to lock in our new lower cruft creation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 [04:17:30] thanks AndyRussG I just rebased [04:17:52] (CR) AndyRussG: [C: +2] Use full path to drupal in preparation for desymlinking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/664960 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [04:18:40] (CR) AndyRussG: [C: +2] "Yaaa cool, thanks!!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [04:19:30] eileen: cool thanks! yeah I think it's all +2'ed now [04:20:07] eileen: though as per the commit message of the last one, I guess I still can't yet expect it to run tests more than once without resetting the db? [04:20:43] AndyRussG: well I'm not quite sure which tests fail on re-run so I guess it depends what cruft was upsetting them [04:21:01] eileen: what is your normal procedure to clean things out to be able to re-run tests? [04:21:25] Well normally I just run a subset of the tests at a time & most of them are ok-ish [04:21:36] sometimes I just go into the db & delete a few things [04:21:49] Oh but note - sometimes running the tests DOES do cleanup [04:22:22] so I normally run with --stop-on-failure & if it fails quickly I try again in the hope that the deleted mice help [04:22:38] eileen ah hmmm ok... so like there's no buildkit command to run to go to a fresh state with that? [04:22:49] oh yeah civibuild wmff create [04:22:57] if you want to rebuild the db [04:23:31] eileen: ah okok cool... do I have to wipe out the db manually beforehand, or will that command do it for me? [04:23:39] it will do it [04:23:47] okok cool great to know, thanks! [04:23:52] actually it's civibuild create wmff [04:24:09] (there are a few options for civibuild create I think) [04:29:28] ahh right, yeah I did also see there's pretty extensive doc [04:31:59] there is! [04:32:18] once that last gerrit has merged I'll move that task to 'done' [04:34:15] (CR) jerkins-bot: [V: -1] Add check to lock in our new lower cruft creation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [04:40:09] (Merged) jenkins-bot: Use full path to drupal in preparation for desymlinking [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/664960 (https://phabricator.wikimedia.org/T273822) (owner: Eileen) [04:42:08] (CR) Eileen: "OK - this should pass again now that the others are merged" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [04:42:15] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [04:42:53] (CR) Eileen: Add check to lock in our new lower cruft creation (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538359 (owner: Eileen) [05:06:07] eileen: all merged now! [05:06:52] ah another question, if I do a pull master (or download any patch) on the wmf crm repo, should I also bring submodules up-to-date with the corresponding submodule pointer? [06:34:52] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: get tests & xdebug working on civicrm docker - https://phabricator.wikimedia.org/T274943 (AndyRussG) So with the last of this chain of patches now merged, here's how it went for m... [11:40:17] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (RLewis) @Eileenmcnaughton unfortunately not, these 20 were Orgs not already in Civi, so I created the new contacts and reimported. We'... [13:15:58] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity Import Error - https://phabricator.wikimedia.org/T271416 (RLewis) @Eileenmcnaughton I went back and reimported the large files with the $680k worth of gifts and everything was imported so I th... [15:14:28] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Silverpop - update our list of database ids - https://phabricator.wikimedia.org/T273833 (KHaggard) Hi @Eileenmcnaughton - I've just deleted the **20180828_Advocacy **database in Acoustic, so we no long... [16:05:09] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Editing es in latam links shows some strings in english - https://phabricator.wikimedia.org/T275545 (DStrine) I'm resolving this. @Ejegg being in Columbia did not have an issue. When I tested in incognito it worked. Testers outside Latam countries shoul... [16:09:00] wait, I don't see DonationInterface on https://donate.wikimedia.org/wiki/Special:Version [16:15:16] fr-tech ohhhhh hey, DonationInterface is NOT deployed anywhere on the main cluster, but the i18n messages are available via some other process: https://phabricator.wikimedia.org/T159098 [16:15:34] Interesting [16:15:55] hmm, so the patch I pushed up yesterday to add es-419 support via a file in DI won't actually help us on donatewiki [16:17:29] let's see, mediawiki-config setup does allow custom docroots, but that feels wrong for a file that's not supposed to be served up [16:19:17] hmmmmm [16:19:59] we could put es-419 in the base html so it would cause a content shift on the Google search results page [16:20:37] tzag fr-tech [16:20:48] Greetings, welcome back [16:20:54] Good trip I hope [16:21:20] cstone heyyy welcome back! [16:21:40] also hi fr-tech :) [16:21:58] Good attempted trip ended up staying here [16:22:27] awwww [16:25:41] hi cstone AndyRussG ! [16:26:02] fr-tech any news for scrum of scrums? [16:26:21] AndyRussG: anything waiting for +2 in the dev-images repo? [16:28:12] ejegg: thanks, nothing here for SoS, and on dev-images, nooo actually on the contrary, we need to respond to some CR we got... thanks tho! [16:29:11] ah I see we are blocking the vuejs team on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/663946 [16:29:40] BannerRenderer: Use ResourceLoader::filter instead of internal JavaScriptMinifier [16:29:53] looks like a quick one [16:31:47] ah yeah I did see that.... [16:32:11] (didn't notice it was actively blocking stuff tho) [16:32:39] it's called out in the scrum of scrums notes [16:33:28] ahhhrgh okok I can do the smoke test and +2 in a bit ejegg [16:33:49] also got a link to the notes btw? [16:42:08] https://etherpad.wikimedia.org/p/Scrum-of-Scrums [16:46:29] ejegg: thx! [16:52:59] Fundraising-Backlog, Wikimedia-Fundraising-Banners: Editing es in latam links shows some strings in english - https://phabricator.wikimedia.org/T275545 (DStrine) Open→Resolved [17:09:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Reedy) [17:18:58] Fundraising-Backlog: TY page for failed BT transaction in Brazil - https://phabricator.wikimedia.org/T275577 (DStrine) We're not totally sure what's going in the failed transaction. If this happens again, please let us know. Just going to donate.wikimedia.org directly is introducing language and geolocatio... [17:19:12] Fundraising-Backlog: Brazil TY page in English and not Portuguese - https://phabricator.wikimedia.org/T275576 (DStrine) Just going to donate.wikimedia.org directly is introducing language and geolocation issues. Please have testers go through the sidebar on wikipedia or through a test banner. That should loc... [17:26:46] Fundraising-Backlog, fundraising-tech-ops: Fix our database to support emojis - convert tables to utf8mb4 - https://phabricator.wikimedia.org/T270218 (Dwisehaupt) log table alter test completed overnight. They took ~19.1 hours to complete. This would put our total time for the civicrm alters to be ~27 ho... [17:48:36] these pics make me really want a microscope: https://www.nikonsmallworld.com/galleries/2020-photomicrography-competition [17:58:58] Fundraising-Backlog, FR-Email: Civi export data for 2 fields are preventing accurate data validation reports in Acoustic - https://phabricator.wikimedia.org/T270731 (KHaggard) [18:02:42] Fundraising-Backlog: Implementing a configurable minimum donation amount by country - https://phabricator.wikimedia.org/T261436 (EMartin) There is a desire to set a lower than usual. minimum for Argentina now, however as it is running with all of the other LATAM countries, going below the threshold can't occ... [18:21:14] Fundraising-Backlog: Email address isn't saving when updating in dedupe feature - https://phabricator.wikimedia.org/T275663 (LeanneS) [18:33:21] Fundraising-Backlog: Query breaks when results include multiple records of same donor - https://phabricator.wikimedia.org/T275668 (LeanneS) [19:12:43] Fundraising-Backlog, fundraising-tech-ops: Fix our database to support emojis - convert tables to utf8mb4 - https://phabricator.wikimedia.org/T270218 (Dwisehaupt) [19:21:53] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ppena - https://phabricator.wikimedia.org/T274587 (Dwisehaupt) Open→Resolved [19:30:47] Fundraising-Backlog: Alternate name field for donors with different alphabet characters - https://phabricator.wikimedia.org/T275678 (SHust) [20:02:01] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: get tests & xdebug working on civicrm docker - https://phabricator.wikimedia.org/T274943 (Eileenmcnaughton) Oh yeah - I think I remember something about that guzzle. Note that wh... [20:04:07] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: get tests & xdebug working on civicrm docker - https://phabricator.wikimedia.org/T274943 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton [20:10:03] Wikimedia-Fundraising-Banners: QA Dsk Lg - ES - https://phabricator.wikimedia.org/T275686 (jbolorinos-ctr) [20:10:41] Wikimedia-Fundraising-Banners: QA Dsk Sm - ES - https://phabricator.wikimedia.org/T275687 (jbolorinos-ctr) [20:11:27] Wikimedia-Fundraising-Banners: QA M Lg - ES - https://phabricator.wikimedia.org/T275688 (jbolorinos-ctr) [20:11:59] Wikimedia-Fundraising-Banners: QA M Sm - ES - https://phabricator.wikimedia.org/T275689 (jbolorinos-ctr) [20:13:09] Wikimedia-Fundraising-Banners: QA Dsk Lg - ES - https://phabricator.wikimedia.org/T275686 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zf26c69129a4ada79fbf [20:14:28] Wikimedia-Fundraising-Banners: QA Dsk Sm - ES - https://phabricator.wikimedia.org/T275687 (jbolorinos-ctr) Screenshot Test Results - Desktop: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z537da077334403207dc [20:15:29] Wikimedia-Fundraising-Banners: QA M Lg - ES - https://phabricator.wikimedia.org/T275688 (jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z3b0225ce396d9eae337 [20:16:40] Wikimedia-Fundraising-Banners: QA M Sm - ES - https://phabricator.wikimedia.org/T275689 (jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/zd5f30fcd4c4b6bffac3 [20:36:59] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for totten - https://phabricator.wikimedia.org/T273497 (Dwisehaupt) Open→Resolved Certificate expired naturally and it can be reissued if need be in the future. [20:37:25] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for mhernandez - https://phabricator.wikimedia.org/T272647 (Dwisehaupt) Open→Resolved Certificate expired naturally and it can be reissued if need be in the future. [20:38:01] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jcabanero - https://phabricator.wikimedia.org/T272643 (Dwisehaupt) Open→Resolved Certificate expired naturally and it can be reissued if need be in the future. [20:38:25] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for krobinson - https://phabricator.wikimedia.org/T273015 (Dwisehaupt) Open→Resolved Certificate expired naturally and it can be reissued if need be in the future. [20:39:56] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for spatton - https://phabricator.wikimedia.org/T273498 (Dwisehaupt) Open→Resolved Certificate expired naturally and it can be reissued if need be in the future. [20:40:22] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for sredkina - https://phabricator.wikimedia.org/T273696 (Dwisehaupt) Open→Resolved Certificate expired naturally and it can be reissued if need be in the future. [20:40:44] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for nisrael - https://phabricator.wikimedia.org/T274320 (Dwisehaupt) Open→Resolved Certificate expired naturally and it can be reissued if need be in the future. [20:45:51] Wikimedia-Fundraising-Banners: QA M Lg - ES - https://phabricator.wikimedia.org/T275688 (HNordeenWMF) @jbolorinos-ctr I see that "Maybe later" translation is getting cut off on some phones, I'm seeing if we can get a shorter translation for that, as we did for pt-BR! [21:07:55] ejegg: did you see the ping on the upstream 419 issue? [21:08:28] ah nope, lemme check my mail [21:09:01] oho, I see, the gitlab issue! [21:09:34] for now I just want to put a longer length limit on the preferred_language field to match the db field extension we already have [21:10:37] it looks easy enough to add new language codes on a site-specific basis [21:10:54] we just want more than 5 chars to fit it [21:14:26] yeah - but we will have to maintain a hack if we don't want the api to trim it [21:15:58] ah right [21:16:31] well let's see, the holy grail of language support would be to fit in any BCP language code [21:16:41] so what's the maximum length they could be? [21:22:57] yeah I tried digging into what that field means & there are a bunch of standards but from the comments on the gitlab it seems quite tied to gettext [21:28:33] so looking at the BNF for language tags in https://tools.ietf.org/search/bcp47 [21:29:10] with 26 chars we can support all the language, script, region, and variant subtags [21:29:45] privateuse and extension seem like a pretty improbable need for a CRM [21:32:41] yeah my feeling is [21:32:41] 1) make a pitch for what we think is right on that gitlab & if that fails [21:32:41] 2) just make it work with the db constrainsts (eg. 'es_la' or whatever) [21:32:41] I think it's less maintenance in the long run [21:33:14] by the way ejegg I think we are down to only one patch & can probably get to zero next month [21:33:35] heh, that's a good argument for not just locally extending the length [21:33:59] ok, so is there concern about extending the width of the contact table too much? [21:34:29] no - I think they are mostly concerned about implications around translation [21:34:44] what does it mean to have a language option not supported by gettext [21:34:56] ahhh, got it [21:35:28] On composer merge plugin - should we merge this before I try to update it ? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/666512 [21:37:17] (you can see that in civi-world es_MX basically maps to es_419 from the gitlab) [21:38:21] right right [21:39:36] oh yeah, let's get the package updates done before we update composer [21:40:32] so package updates I think are [21:40:32] 1) twig within crm.root [21:40:32] 2) symfony within smashpig and then smashpi within crm.root [21:40:46] so I'd be fine mapping es speakers from all countries in the americas to es_MX, as long as that doesn't offend anyone [21:40:46] the rest appears to just be noise to me [21:41:07] would be a little bit of special-case coding on the message processing [21:41:09] ejegg: so we can change the label [21:41:38] es_MX is the db value -but the label can be 'Spanish (Latin American)' [21:42:04] yah, and rename the template files, and remember that es-419 on the frontend corresponds to es_MX on the backend [21:42:16] yep [21:42:47] well, that sounds like the fastest way to get it locally without maintaining a hack [21:42:47] but es-419 is hardly something we were born knowing the meaning of :-) [21:43:08] ok - I'll comment on the ticket to say we'll go that way & we just rename the option value [21:43:11] label [21:48:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: civicrm-buildkit doesn't composer update our wikimedia projects correctly - https://phabricator.wikimedia.org/T104031 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton 2015 issue that is either fixed or n... [21:49:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create "composer test" entry point - https://phabricator.wikimedia.org/T91910 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton 2015 issue that is either fixed or not bothering us [21:49:04] Fundraising-Backlog-Old, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure, Epic, Patch-For-Review: Continuous integration - CiviCRM - https://phabricator.wikimedia.org/T78100 (Eileenmcnaughton) [21:51:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) Composer merge plugin is fixed upstream now. Lets 1) get onto version 2 2) remove our buildkit version 1 hack 3) switch CI &... [21:52:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) I moved this back into triage as getting this done will remove an ongoing pain point and the work involved now is probably le... [21:53:19] ejegg: so the other one I want to do is https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/664929 - the ground work is done now - but if I put up the updated version it needs a fairly quick merge as it goes stale easily [22:03:48] Also - I have a patch on frpm with the change for this comment https://phabricator.wikimedia.org/T273833#6856684 ready to deploy if someone can confirm it looks OK [22:04:06] oh rockin, the composer-merge-plugin is actually tagged with a stable 2.x release in packagist now [22:08:02] (CR) Ejegg: [C: +2] Composer update on twig/twig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666512 (https://phabricator.wikimedia.org/T271212) (owner: Eileen) [22:08:07] (PS2) Ejegg: Composer update on twig/twig [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666512 (https://phabricator.wikimedia.org/T271212) (owner: Eileen) [22:08:11] ejegg: yep! [22:35:17] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add es-419 as a supported 'preferred language' in Civi - https://phabricator.wikimedia.org/T199733 (Ejegg) To get 'es-419' in the preferred_language fie... [22:39:53] dstrine: easiest way to get es-419 in Civi is to call it es_MX ^^^ we can still call it es-419 on payments-wiki and just map it in the queue consumer [22:40:01] think folks would mind? [22:51:36] ejegg: did you see comment on frpm patch [22:51:56] it's just this if you want to check without logging in [22:52:00] - 'database_id' => [9644238,14682316,11851009,19112117,20285807], [22:52:00] + 'database_id' => [9644238,14682316,11851009,19112117], [22:54:51] Fundraising-Backlog: Search kit tool notes - contribution search - https://phabricator.wikimedia.org/T275707 (MDemosWMF) [23:04:41] AndyRussG: just FYI - this is how I create an extra buildkit site on an older civi version (to check if something really has regressed ) civibuild create dold --civi-ver 5.20 --type drupal-demo --url https://dold.localhost:32353 [23:12:37] eileen: yep, that patch looks just fine [23:12:43] thanks! [23:13:39] !log civicrm revision is 5e042e6e57, config revision is 8572611a32 [23:13:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:14:16] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Silverpop - update our list of database ids - https://phabricator.wikimedia.org/T273833 (Eileenmcnaughton) I've removed 20285807 from our list [23:21:14] ejegg: I'm wrapping some stuff up in a few minutes and I'll be OOO tomorrow and friday. Could you send an email to fr-onilne about es-419? [23:21:30] sure dstrine [23:21:33] (PS1) Ejegg: Add core es-419 support via hook [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/666753 (https://phabricator.wikimedia.org/T112889) [23:22:48] fr-tech I finished watching the meeting recording about. Gilles is very calm in that call but any reconfiguring of banners or reworking of the system is an insanely big deal. sounds like a bunch of people are going to scramble on this in the next few weeks [23:36:23] fr-tech anyone got a moment to review a couple patches for es-419 support on wikis? [23:36:34] There's this one for FundraiserLandingPage https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/666753 [23:36:46] which will get us es-419 support on donatewiki [23:36:53] and this one for DonationInterface: [23:37:15] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/666513/ [23:37:31] which gets us the support on payments-wiki [23:37:35] basically the same thing [23:38:05] but we don't have a single extension to put them in [23:38:44] since DonationInterface isn't deployed to donatewiki and FundraiserLandingPage isn't on payments [23:39:46] oh foo... thankyouwiki doesn't have either of those extensions [23:40:45] LandingCheck, then??? [23:40:57] fundraising-tech-ops: 2020-2021 fundraising hardware refresh and capex - https://phabricator.wikimedia.org/T257244 (Jclark-ctr) [23:48:11] oh, landingcheck is not on payments-wiki either [23:48:54] so I guess we need it in donationInterface + one of the other two, depending on whether thankyouwiki needs es-419 support + fallback [23:53:51] (PS1) Ejegg: Add core es-419 support via hook [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/666760 (https://phabricator.wikimedia.org/T112889) [23:54:42] (Abandoned) Ejegg: Add core es-419 support via hook [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/666753 (https://phabricator.wikimedia.org/T112889) (owner: Ejegg) [23:54:49] eileen: we talked about this in tech talk. i'm thinking we'll want to update the smashpig and silverpop dbs to utf8mb4 also. since if we start accepting those wide characters into name fields, they may populate on through to the other dbs. [23:55:28] i've updated the ticket to reflect we'll want to do those dbs also. their size isn't so large that there will be much concern. [23:55:30] good call dwisehaupt [23:56:00] yep - agree [23:56:22] we should check the silverpop db doesn't have utf8 hard coded anywhere in the code [23:56:35] yeah. was just going to mention that. [23:56:39] yeah, it'll probably need a code change [23:57:14] also mentioned that we should reach out to acoustic to see what variant of utf8 they support given it could cause issues on their end if they aren't ready for it. [23:57:53] (i feel like i've been dealing with utf8 issues off an on for 10 years at various jobs. :)