[01:56:32] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Upgrade UI issue: Some dashlets don't populate, others are hard to read now - https://phabricator.wikimedia.org/T275071 (Eileenmcnaughton) a:Eileenmcnaughton @CaitVirtue - I dug into this a bi... [03:19:56] re acoustic - we know they support emojis as we have to prune them out :-) [03:29:56] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: try to recreate lybunt and sybunt reports in search kit - https://phabricator.wikimedia.org/T272063 (Eileenmcnaughton) a:Eileenmcnaughton [03:31:38] Fundraising Sprint Corrugated super slide, Fundraising Sprint Downed power line jump rope, Fundraising-Backlog: Adding 2 new columns to Engage Reconciliation reports - https://phabricator.wikimedia.org/T271992 (Eileenmcnaughton) I started digging into this just now & created this table with search ki... [03:33:56] Fundraising Sprint Corrugated super slide, Fundraising Sprint Downed power line jump rope, Fundraising-Backlog: Remove old version of afform, use core - https://phabricator.wikimedia.org/T275728 (Eileenmcnaughton) [04:39:58] eileen: wrt dold: ah cool! did you have to change instances.yml for that? [04:40:23] AndyRussG: no - because I was happy to accept 'any old db name' since it's not gonna be around forever [04:57:53] eileen ahhhh right I forgot those were just to set specific stuff like that [04:58:02] yep [04:59:14] Is that something that option (dold) something I would expect to see documented here? https://docs.civicrm.org/dev/en/latest/tools/civibuild/ [05:24:20] yes - dold is a random string [05:24:48] in the examples it's things like [05:24:49] my-drupal-civi47 [05:24:59] (dold is like dmaster but .... old) [07:09:28] (CR) AndyRussG: [C: +2] "Hi! Thanks much for this, and apologies for the delay!! This is fine, and I see the patch on the master branch has merged. Merging this sh" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/663946 (owner: Krinkle) [07:14:14] (Merged) jenkins-bot: BannerRenderer: Use ResourceLoader::filter instead of internal JavaScriptMinifier [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/663946 (owner: Krinkle) [14:25:52] (PS1) Jgleeson: Package updates - SmashPig now at v0.6.7 - phpmailer now at v5.2.28 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666901 [14:32:45] (CR) Jgleeson: [C: +2] Package updates - SmashPig now at v0.6.7 - phpmailer now at v5.2.28 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666901 (owner: Jgleeson) [14:34:31] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, fr-donorservices: Italian mobile form obscures the card number field - https://phabricator.wikimedia.org/T275458 (MBeat33) got a little more info from the donor: I Phone mod. MD2971 IP/A Versione 10.3.4 iOS Safari [14:56:17] (Merged) jenkins-bot: Package updates - SmashPig now at v0.6.7 - phpmailer now at v5.2.28 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666901 (owner: Jgleeson) [15:01:51] Fundraising Sprint Corrugated super slide, Fundraising Sprint Downed power line jump rope, Fundraising-Backlog: Adding 2 new columns to Engage Reconciliation reports - https://phabricator.wikimedia.org/T271992 (MDemosWMF) @Eileenmcnaughton that looks great! I just switched the placement of the net su... [15:55:16] Wikimedia-Fundraising-Banners: Latin America Pre-test Banners QA - https://phabricator.wikimedia.org/T275446 (HNordeenWMF) @jbolorinos-ctr heads up that the minimums accepted by the payment form and the error messages will not match yet [16:03:04] Fundraising-Backlog, Analytics, FR-Tech-Analytics: Whitelist Portal and WikipediaApp event data for (sanitized) long-term storage - https://phabricator.wikimedia.org/T273246 (mforns) Hi all! I reviewed the include-list patches and left some comments there. Please, don't feel overwhelmed by the review... [16:05:22] (CR) Jgleeson: [V: +2 C: +2] Package updates - SmashPig now at v0.6.7 - phpmailer now at v5.2.28 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666901 (owner: Jgleeson) [16:22:27] (PS1) Jgleeson: Update Composer packages [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/666947 (https://phabricator.wikimedia.org/T271212) [16:28:25] Fundraising Sprint Bee Wheel, Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, fr-email-preference-center: Use Guzzle to make API request to CiviProxy to retrieve opt-in / opt-out fields. - https://phabricator.wikimedia.org/T268497 (C... [16:37:34] fr-tech this composer package thing is turning out to be a real headache. it looks like if we do not set a specific minimum version of http-foundation package in smashpig, all projects which use it including civicrm disregard (rightly) the smashpig composer.lock version and instead uses their own earlier (undesirable) version, which in turn causes the symfony scan to fail :| [16:42:28] jgleeson why not just specify that we want to update http-foundation at the same time as updating the smash-pig package? [16:43:28] so I'm going to propose that to fix this, we now start setting specific floors in versions in composer.json for all package updates alongsisde the composer.lock update so that all projects which use smashpig know exactly what package version smashpig intends to use. It appears that only updating composer.lock files with relaxed composer.json versions only works when using that project directly [16:43:30] but not when that project is a composer package requirement to another project. In those cases the smashpig composer.lock is ignored so the parent project can pull in earlier versions [16:45:10] ejegg: http-foundation is only used by smashpig so there isn't a package to update on civicrm I don't think [16:45:13] vagrant@mwv:/vagrant/srv/org.wikimedia.civicrm$ composer why symfony/http-foundation [16:45:15] wikimedia/smash-pig v0.6.7 requires symfony/http-foundation (^2.8.2) [16:45:19] ejegg: ^ [16:45:41] but we actually want v2.8.52 I think [16:45:48] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog: es419 Thank You Email Edits for the March 9th Pretest - https://phabricator.wikimedia.org/T274319 (Cstone) a:Cstone [16:46:28] which we get in smashpig's own composer.lock but that is ignored by composer when installing civicrm [16:46:54] and as a result, the latest update is still failing the check :( [16:47:22] so under civicrm when you say composer update wikimedia/smash-pig symfony/http-foundation it just ignores the second package? [17:26:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Parsoid, Parsoid-Rendering: Make CentralNotice extension compatible with Parsoid - https://phabricator.wikimedia.org/T272936 (Arlolra) p:Triage→Medium [17:27:01] Fundraising-Backlog, MediaViewer, MediaWiki-extensions-CentralNotice, Structured Data Engineering, and 3 others: CentralNotice throws exception on malformed URIs - https://phabricator.wikimedia.org/T269948 (Jdlrobson) [17:55:01] Fundraising-Backlog, MediaViewer, MediaWiki-extensions-CentralNotice, Structured Data Engineering, and 3 others: CentralNotice throws exception on malformed URIs - https://phabricator.wikimedia.org/T269948 (matmarex) [18:23:51] jgleeson hi! hey so just thinking about how we might coordinate es-419 review? I guess maybe lmk where you've gotten to when you finish today, maybe here or en an EOD e-mail or something, so I'll know what to focus on later today? does that make sense? thanks in advance!! [18:30:44] AndyRussG: we're still on the call if you wana hop on [18:30:48] ejegg: is demoing it [18:31:05] we haven't picked any parts yet [18:31:46] it looks like review may roll into tomorrow/monday also [18:31:52] if we can't do it all today [18:44:02] (PS3) Ejegg: WIP: Map es-419 to es_MX on import, update display [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) [18:46:32] RECOVERY - check_puppetrun on frdb2002 is OK: OK: Puppet is currently enabled, last run 29 seconds ago with 0 failures [18:47:32] PROBLEM - check_mysql on frdb2001 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) [18:47:38] RECOVERY - check_puppetrun on frdb2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [18:52:32] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 111 Threads: 10 Questions: 4481 Slow queries: 0 Opens: 1013 Flush tables: 1 Open tables: 1007 Queries per second avg: 40.369 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [18:56:57] ^^ those were related to me upgrading mariadb on frdb2001 and frdb2002 [19:03:27] (CR) jerkins-bot: [V: -1] WIP: Map es-419 to es_MX on import, update display [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) (owner: Ejegg) [19:10:32] ejegg: there are a bunch of changes to tests in the latest crm master, did you rebase on those? [19:39:47] (PS1) Jgleeson: Package updates - symfony/http-foundaton now at v2.8.52 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666981 [19:43:53] (CR) Jgleeson: [C: +2] Package updates - symfony/http-foundaton now at v2.8.52 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666981 (owner: Jgleeson) [19:44:11] (CR) Jgleeson: [V: +2 C: +2] Package updates - symfony/http-foundaton now at v2.8.52 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666981 (owner: Jgleeson) [20:00:09] (PS1) Eileen: Backport core afform fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/666983 (https://phabricator.wikimedia.org/T275728) [20:03:17] whenever ye ready jenkins! [20:04:50] (Merged) jenkins-bot: Package updates - symfony/http-foundaton now at v2.8.52 [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/666981 (owner: Jgleeson) [20:07:26] (PS2) Jgleeson: Update Composer packages [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/666947 (https://phabricator.wikimedia.org/T271212) [20:12:12] Fundraising-Backlog: Update exchange rates before Latin America Pre-test & Launch - https://phabricator.wikimedia.org/T275812 (HNordeenWMF) [20:12:58] Fundraising-Backlog: Update exchange rates before Latin America Pre-test & Launch - https://phabricator.wikimedia.org/T275812 (HNordeenWMF) [20:16:31] (CR) Jgleeson: [C: +2] Update Composer packages [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/666947 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [20:18:00] ok tskaff, that minimum donation amount for dlocal is updated to $1 on payments-wiki [20:18:55] Well that was fast. Thanks again ejegg! cc haley_ [20:20:53] (CR) Jgleeson: [V: +2 C: +2] Update Composer packages [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/666947 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [20:21:13] fr-tech I need to run a couple of errands I'll be back in a bit [20:21:16] (CR) Jgleeson: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/666947 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [20:47:12] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/667013 [20:52:49] (PS1) Eileen: Merge commit '2b057a32' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/667014 [20:53:12] (Abandoned) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/667013 (owner: Eileen) [20:53:44] (CR) Eileen: [C: +2] Merge commit '2b057a32' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/667014 (owner: Eileen) [20:54:46] just getting all those test 'changes' out - there aren't really any changes so it's just housekeeping. I excluded the twig update for now [20:57:17] !log civicrm revision changed from 604d07c859 to f07390ff87, config revision is 643477b35d [20:57:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:57:57] ok - only undeployed change now is the twig update - did you want that to go out too ejegg ? [20:58:05] or wait for Jack? [21:01:58] eileen: hey! ahh I don't know about the deploy stuff, but I dunno if you saw this patch from ejegg for es-419? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/666476 [21:05:25] hey eileen, I didn't see you'd updated twig but feel free to push that out if you have, thanks [21:28:04] fr-tech dstrine should these tasks be in the sprint? https://phabricator.wikimedia.org/T112889 https://phabricator.wikimedia.org/T199680 [21:47:59] (CR) Eileen: "looks like an e-notice is in play at the moment" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) (owner: Ejegg) [21:58:26] what's an e-notice? [21:59:42] Wikimedia-Fundraising, donate.wikimedia.org: Translate donation support pages into Latin American Spanish and Portuguese - https://phabricator.wikimedia.org/T199685 (Pcoombe) [22:01:35] Wikimedia-Fundraising, donate.wikimedia.org: Translate donation support pages into Latin American Spanish and Portuguese - https://phabricator.wikimedia.org/T199685 (Pcoombe) Okay, these are almost all live now. It just made sense to do pt-PT at the same time, since it's quite similar to pt-BR 🙂 The two... [22:15:11] sorry fr-tech, i got called away for a bit [22:15:13] back now [22:28:02] (PS4) Ejegg: Map es-419 to es_MX on import, update display name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) [22:29:37] (PS5) Ejegg: Map es-419 to es_MX on import, update display name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/666476 (https://phabricator.wikimedia.org/T199733) [22:32:00] eileen: oh hey, we should update language when we match a contact on name + email [22:32:26] Not in this patch though [22:32:36] also thanks for catching that notice [22:32:57] i had assumed language was up in that array of things that get a default value, but nope! [22:38:12] :-) [22:38:30] I think the idea is that if we don't know null is better - in fact I think we even patched core to permit that [22:40:43] ejegg: are you OK to merge this? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/civicrm/+/666983 -it's hard to make sense of but is merged upstream [22:42:04] sure thing, lemme take a peek [22:42:34] hah, yeah, that's a bit puzzling out of context [22:43:21] at the end of the day Coleman & Tim understand it :-) [22:44:35] (CR) Ejegg: [C: +2] Backport core afform fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/666983 (https://phabricator.wikimedia.org/T275728) (owner: Eileen) [22:46:40] Fundraising-Backlog: Peru transactions not being settled - https://phabricator.wikimedia.org/T275825 (EMartin) [22:51:25] Fundraising-Backlog: Peru transactions not being settled - https://phabricator.wikimedia.org/T275825 (Ejegg) This is for credit cards? Our Ingenico flow shouldn't determine whether or not to capture based on country. Any example merchant reference numbers? [22:52:40] fr-tech I asked over in #mediawiki-i18n, and Nikerabbit says he doesn't see any issues with the hook-based approach to adding the es-419 support. Also, that he can't think of a simpler way to do it and still get fallback [22:53:00] I'm trying to figure out what might have caused that warning cstone saw though [22:54:00] entirely possible ejegg I have some messed up setting [22:54:08] cstone ejegg hey ah good news... I started looking at it and have been doing non-work duties for a bit, would get back to it again in like 2 hrs [22:54:32] also ^ just askin' about those tasks? should they be sprintified? [22:55:00] https://phabricator.wikimedia.org/T112889 https://phabricator.wikimedia.org/T199680 [22:57:40] cstone ejegg also in the hook handler in DonationInterface.class.php, seems like kinda weird logic there with the array_key_exists condition on an array with fully known values? If there is a reason for doing it like that, it'd be nice to see an inline comment explaining... :) [22:58:07] also, maybe we should check the contents of $file before overwriting, for robustness in case mw core starts supporting this directly? [22:59:29] AndyRussG: the array_key_exists is just in case we want to support more extra codes [22:59:46] but i guess for simplicity's sake I could hard-code it in the 'if' while we only have one [22:59:55] and good point about the $file contents [23:00:31] ejegg ah I see... maybe either that or just adding a quick comment with the explanation you just wrote ^ ? [23:00:57] if there's a significant chance we'll add more codes, then doing it that way seems perfectly reaosnable [23:02:25] (PS5) Ejegg: Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T112889) [23:02:27] (PS9) Ejegg: Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) [23:02:44] oh, so sprintifying those tasks... [23:02:58] https://phabricator.wikimedia.org/T199680 is kindof a parent epic [23:03:52] I guess I could have tagged the changesets with different tasks [23:03:56] ejegg: hmmm also maybe more explanation in the commit message? as in, explaining the actual change in functionality: that the patch causes it es-419 to fallback to es when the messages are not available in es-419.json? Or is there more that it does in concrete terms? [23:04:11] ah right I just mentioned those tasks since they were the ones tagged [23:04:12] those core ones could be https://phabricator.wikimedia.org/T199682 [23:05:14] ejegg: hmmm whatever works! or maybe change that task to say "throughout the pipeline"? [23:06:10] (PS6) Ejegg: Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T199682) [23:06:12] (PS10) Ejegg: Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) [23:06:22] (Merged) jenkins-bot: Backport core afform fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/666983 (https://phabricator.wikimedia.org/T275728) (owner: Eileen) [23:06:26] ok, that one's retagged to the 'DonationInterface' task in sprint [23:06:31] and I'll move that task to review [23:07:12] oh, it was already there [23:07:24] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Wikimedia-Fundraising, Patch-For-Review: Localise most important DonationInterface messages to Latin American Spanish - https://phabricator.wikimedia.org/T199682 (Ejegg) That patch ^^^ should get us language fallback from es-419... [23:08:18] ejegg: cool beans! :) thx much! [23:09:06] Fundraising Sprint Downed power line jump rope, Fundraising-Backlog: es419 Thank You Email Edits for the March 9th Pretest - https://phabricator.wikimedia.org/T274319 (Ejegg) note: the es-419 thank you email is renamed to thank_you.es-mx.html in https://gerrit.wikimedia.org/r/666476 [23:10:19] Fundraising-Backlog: Peru transactions not being settled - https://phabricator.wikimedia.org/T275825 (EMartin) Hi Elliott, I just ran a report of all transactions from Peru for February to see a pattern. Some transactions are making it through but many are not. I went back to Ingenico to challenge them ab... [23:12:15] rip bears [23:12:28] Fundraising-Backlog: Peru transactions not being settled - https://phabricator.wikimedia.org/T275825 (EMartin) Open→Resolved a:EMartin After further review of this, I see that we have stopped a great many transactions in Peru for Fraud which made it look like we weren't settling transactions here... [23:18:20] !! ejegg AndyRussG my xdebug is gone with the updated patch its not doing that and catching the breakpoint [23:18:28] xdebug weirdness [23:20:09] cstone: not on Docker, right? [23:20:18] no this is vagrant [23:20:41] only hmm the page is not in spanish now for me :( [23:21:09] cstone: it should work on Docker... if you want to try, just get the latest of fundraising-dev and build the images using this Gerrit change https://gerrit.wikimedia.org/r/c/releng/dev-images/+/663294 [23:21:20] cstone btw it also works on Mac now! [23:21:26] nice!! [23:21:50] still slower than on Linux, especially for Civi, but seems usable at least on Payments [23:22:09] probably there are local hacks that could be tried to speed up Civi there, too [23:22:55] if u try it out, pls don't hesitate to ping if u run into issuez [23:24:37] The hack that I bet would make Civi work better on Mac would be just to prevent Civi logs from going to the bind mounts on the host, which are what everything seems to indicate are slow [23:24:56] and so Civi I think logs more than Payments, which could be why on Mac it's slower [23:25:55] makes sense it was super slow just like loading a page fo rme [23:27:23] AndyRussG: on the hook is there not supposed to be anything in $file when it gets there? [23:27:27] cstone right, so now all the queue and db access are moved to volumes instead of bind mounts [23:27:53] cstone: not sure, I was just reading the inline comments for the hook handler method [23:28:37] says that if mw core finds the language, $file will contain the path of the Messages file [23:28:55] when im stepping through it already has the es_419 in $file [23:29:06] not sure exactly what it'd be (empty string? null? undefined? false?) if it didn't, but there might be more doc [23:29:10] ah huh that's interesting! [23:29:32] maybe that's rather where it expects to find it? [23:29:57] I'd either check for more doc on mediawiki.org or look in the stack trace at the code that called the hook handler [23:32:31] idono if you are looking at this right now just the latest version isn't in spanish anymore for me [23:33:00] the latest version of which cstone? [23:33:14] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/666513 [23:33:35] i can get it to debug with the old code now too though so [23:34:54] ok i think i have some caching shenanigans going on [23:35:59] cstone hmmm sounds legit... so how are you testing it concretely? just some payment for URL with es vs es-419 in the URL param? [23:36:07] *payment form [23:36:08] yeah thats what I was doing [23:36:49] K just got 5 min of something nonwork to deal with here and I'll try too :) [23:37:04] yeah no rush just flaliing through testing in chat hah [23:38:57] cstone ah hehe mmm well I'm just flailing through chat while cooking.... ;) [23:44:36] alright now its in spanish haha i can see it changing between es and es419 at least [23:46:28] ahh cool! [23:46:34] wow. digging into utf8 collation sets and the rabbit holes just keep going. [23:47:54] oh no cstone [23:48:06] Wikimedia-Fundraising, donate.wikimedia.org: Translate donation support pages into Latin American Spanish and Portuguese - https://phabricator.wikimedia.org/T199685 (CDenes_WMF) Fantastic; thank you!! [23:48:06] ejegg: i think its just my local env being weird [23:48:07] the patch has a hidden xdebug-disabling virus? [23:48:16] cause its working then not working [23:48:45] errr right [23:48:58] that latest PS won't work with the empty() check [23:49:04] fixing [23:50:31] haha monthly convert is half translated :) [23:50:42] (PS7) Ejegg: Add core es-419 support via hook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/666513 (https://phabricator.wikimedia.org/T199682) [23:50:44] (PS11) Ejegg: Add response data consistently to both data copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/665140 (https://phabricator.wikimedia.org/T199680) [23:50:56] and also half-translated in esperanto, just in case [23:51:06] haha [23:51:23] should the thank you page show es-419? [23:51:25] or just es [23:52:46] ohhh i hadn't checked that far [23:52:53] ideally we should use es-419 for that [23:53:00] i dont know if it doesnt exist and its falling back [23:53:06] same with the message on the queue i see es [23:53:27] ah right, you need that follow-on patch for the queue message [23:53:32] okay [23:53:36] the 'add response data consistently' [23:53:43] probably will also fix the thankyou redirect [23:53:57] okie i thought i had that one but i was on the other patch [23:53:59] makes sense [23:55:40] ok yes nice [23:55:53] i need to go help with homework. catch you all later.