[02:22:47] oh jeez, glad you're not tsunami-ed eileen, but sorry to hear that somebody is [15:16:40] (PS2) AndyRussG: Settings for MediaWiki logs on Payments [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/667425 (https://phabricator.wikimedia.org/T276582) [16:42:26] (CR) Jgleeson: [C: -1] "This one isn't working for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/647276 (https://phabricator.wikimedia.org/T269717) (owner: Ejegg) [17:53:12] dstrine: so for docker stuff, is it, add to epic, or just the tag? [17:53:59] XenoRyet: hey, so pls lmk if/when you wish to try Docker stuff, to point you to the most recent stable-ish Gerrit changes for the repo and images, sound good? [17:54:38] XenoRyet: also as a first step, you could just try the basic Docker installation steps, including adding your local user to the docker group (if on Linux) [17:55:52] Yea, I'll let you know when I get a little time for it. Might be a good excuse to document the steps for our current version as well. [17:56:32] XenoRyet: yeee... mmm the steps should be documented in the Readme, but they could certainly be lacking.... [17:57:16] Cool. I was thinking we'd want something on a wiki too. [17:57:30] ahhh yes also for sure [17:58:49] XenoRyet: here in the MW general dev setup doc are notes and links for Docker installation in general: see "Requirements" and "Linux users", just before the "Quick start" section: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/DEVELOPERS.md [17:59:16] Cool, thanks [17:59:30] ;) [18:34:18] jgleeson: what would be the ideal way to test that twig patch locally? [18:43:15] cstone: on the phab task I added a comment showing how to run the security checker [18:43:23] so i guess you could test it before and aftr [18:43:29] it's a oneliner command [18:43:50] hmm i guess if we wanted to make sure twig was ok you'd wanna load up a form using twig [18:44:14] https://phabricator.wikimedia.org/T271212#6883729 [18:44:31] ah okay were these the composer issues you mentioned having ? PHP Fatal error: Uncaught ArgumentCountError: array_merge() does not accept unknown named parameters in /usr/share/php/Composer/DependencyResolver/DefaultPolicy.php:84 [18:45:03] oh no that's a new one [18:45:16] are you seeing that after checking out the twig patch? [18:46:49] do i have to touch composer after checking it out or just check it out? [18:50:01] so the security checker will just look at the latest composer.lock file included in the patch [18:50:12] but if you wanna test a form, you'll need to run composer install [18:50:25] ok yeah i was getting that error on composer install [18:50:57] if you remove that patch does it install ok? [18:51:03] good point lemme see [18:51:18] no ok [18:53:19] AndyRussG: on a fresh docker install do you need to add more settings to have an ingenico payment go through? [18:57:22] jgleeson: i think i know my issue [18:58:26] i wasn't actually in the box i thought i was in [18:59:42] ah [18:59:49] Updating twig/twig (v1.24.2 => v1.44.2): [18:59:57] yup! [19:00:00] ok thanks! [19:00:20] thank you! [19:07:39] cstone: in theory it should do everything up to but not including any queue consumption [19:07:58] then after that queue consumption should be tried manually, and there are no IPN listenners [19:08:38] cstone: which dev-images and fundraising-dev patchsets are you on? [19:09:04] also leaving in a few minutes to do an errand and will be afk for about 45 min, apologies! [19:14:46] have a good weekend fr-tech! [19:14:53] jgleeson: cya! [19:14:56] You too [19:16:32] later! [19:17:29] AndyRussG: I got an error when trying to donate but didn't investigate further but good question on the dev patch cause i kept deleting it hah [21:02:20] cstone: hmmm if you got so far as to donate it probably isn't an issue with the images tho [21:02:38] you could try xdebug? also I guess you see stuff in the logs... [21:03:07] the settings are all git-tracked so any fixes there can be shared that way (sorry if you already knew this also) [21:11:51] yeah I just didn't know if there was extra setup ill look into the errors [21:13:23] cstone: cool thx! also to note recently phpunit tests started failing again on Payments (the output I mistook for civi test output the other day) [21:14:18] haha [21:15:08] cstone: xdebug should also still "just work" (did last time I tried) [21:15:31] thx again! I'm about if I can help w stuff :) [21:15:48] yeah i didnt need to push a donation through was just testing the form and figure id try :P [21:22:51] cool! heheh glad it got that far anyway ;p [23:28:41] Wikimedia-Fundraising-Banners: QA Dsk Sm - ES - https://phabricator.wikimedia.org/T275687 (jbolorinos-ctr) Open→Resolved All issues found have been reported and addressed. Closing task as Resolved. [23:28:43] Wikimedia-Fundraising-Banners: QA for es-419 Banners - https://phabricator.wikimedia.org/T275448 (jbolorinos-ctr) [23:29:11] Wikimedia-Fundraising-Banners: QA Dsk Lg - ES - https://phabricator.wikimedia.org/T275686 (jbolorinos-ctr) Open→Resolved All issues found have been reported and addressed. Closing task as Resolved