[04:07:31] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: Preparing Slave SQL: Yes Seconds Behind Master: (null) [04:12:27] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 814997 Threads: 13 Questions: 15624555 Slow queries: 422 Opens: 8063 Flush tables: 1 Open tables: 1116 Queries per second avg: 19.171 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [06:04:55] (PS1) AndyRussG: E-mail Preferences Center setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/669613 (https://phabricator.wikimedia.org/T268510) [14:30:14] Fundraising-Backlog, Analytics, FR-Tech-Analytics: Whitelist Portal and WikipediaApp event data for (sanitized) long-term storage - https://phabricator.wikimedia.org/T273246 (Pcoombe) Thanks @EYener. That's correct that the 2020 portal banners ran from Nov 30 to Jan 1 inclusive. I had honestly given... [16:16:44] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: International Woman' Day banner has JS error (TypeError: this.banner is undefined) - https://phabricator.wikimedia.org/T276825 (Jdlrobson) [16:16:52] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: International Woman' Day banner has JS error (TypeError: this.banner is undefined) - https://phabricator.wikimedia.org/T276825 (Jdlrobson) p:Triage→Unbreak! [16:17:55] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined) - https://phabricator.wikimedia.org/T276825 (Jdlrobson) [16:25:05] Fundraising-Backlog, Wikimedia-Fundraising-Banners, Wikimedia-production-error: International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined) - https://phabricator.wikimedia.org/T276825 (Jdlrobson) [16:41:40] Fundraising-Backlog, Wikimedia-Fundraising-Banners, JavaScript, Wikimedia-production-error: International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined) - https://phabricator.wikimedia.org/T276825 (Umherirrender) [17:56:59] Fundraising Sprint Esperantoland, Fundraising-Backlog: Update exchange rates before Latin America Pre-test - https://phabricator.wikimedia.org/T275812 (DStrine) p:High→Unbreak! [19:10:23] (PS1) Jgleeson: Update CurrencyRates.php March 2021 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/669955 (https://phabricator.wikimedia.org/T275812) [19:15:38] (CR) Cstone: [C: +2] Update CurrencyRates.php March 2021 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/669955 (https://phabricator.wikimedia.org/T275812) (owner: Jgleeson) [19:18:34] (Merged) jenkins-bot: Update CurrencyRates.php March 2021 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/669955 (https://phabricator.wikimedia.org/T275812) (owner: Jgleeson) [19:19:36] Wikimedia-Fundraising, donate.wikimedia.org: Translate donation support pages into Latin American Spanish and Portuguese - https://phabricator.wikimedia.org/T199685 (Pcoombe) FAQ in es is live: https://donate.wikimedia.org/wiki/FAQ/es The issue with the cancellation link on Ways to Give is fixed: https:... [19:29:32] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/669959 [19:33:03] (CR) Jgleeson: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/669959 (owner: Jgleeson) [19:33:59] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/669959 (owner: Jgleeson) [19:57:28] (CR) Cstone: [C: +2] Update twig/twig [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [20:01:10] (CR) jerkins-bot: [V: -1] Update twig/twig [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [20:13:57] (CR) Zppix: "recheck" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [20:18:36] ok I think I know why that's failing on CI. It's the " The .git directory is missing from /workspace/src/vendor/wikimedia/smash-pig," bug [20:23:02] so it looks like payments CI doesn't work unless the vendor/composer.lock file matches the latest available on smashpig [20:23:37] the twig/twig patch is pulling in smashpig v0.6.7 but smashpig latest is now v0.6.8 as of the last hour when we added the new currency rates [20:24:27] so normally we'd fix this by just updating payments to use the v0.6.8 BUT the twig/twig patch is specifically using the changes in v0.6.7 and we kinda lose that in the history if we just bump that to use smashpig v0.6.8 [20:24:37] so I'm currently hmmmm'ing at a good way to work it out [20:33:52] jgleeson: looks like you are fighting gerrit on your last composer update [20:34:00] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/668463 [20:35:42] Fundraising Sprint Corrugated super slide, Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: De-symlink our repos - https://phabricator.wikimedia.org/T273822 (Eileenmcnaughton) a:Eileenmcnaughton [20:37:21] (PS1) Eileen: Update gitignore for sites move [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/669973 (https://phabricator.wikimedia.org/T273822) [20:39:55] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) a:Eileenmcnaughton [20:41:01] yeah eileen it's due to us updating smashpig again and that patch using the older, intended version [20:41:10] which brings in the composer package updates [20:41:32] I'm gonna have to update that patch to use the latest smashpig which is probably the easiest fix [20:57:03] (PS1) Eileen: Upgrade wikimedia/composer-merge-plugin to version 2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/669977 (https://phabricator.wikimedia.org/T267881) [21:04:34] hmm am I in the right place? hangout seems empty [21:05:04] (CR) Jgleeson: "recheck" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:05:16] eileen: last meeting running over [21:05:22] ah cool [21:09:27] (CR) Jgleeson: "recheck" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:14:56] woot - this just passed https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/669977 [21:23:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: Spike - do practice d9 installs locally to get our heads around it - https://phabricator.wikimedia.org/T276395 (DStrine) [21:24:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test d9 install on staging - https://phabricator.wikimedia.org/T276273 (Eileenmcnaughton) [21:26:31] Fundraising Sprint Esperantoland, Fundraising-Backlog, fundraising-tech-ops: Test silverpop export with utf8mb4 tables - https://phabricator.wikimedia.org/T276293 (DStrine) [21:26:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-drupal-upgrade-2021: Test d9 install on staging - https://phabricator.wikimedia.org/T276273 (DStrine) [21:32:43] (CR) Zppix: "resubmit" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [21:45:37] Can someone +2 the composer merge plugin so I can do the follow up bits? [21:46:10] is that testable locally with the symlinkyness ? [21:46:13] eileen: [21:47:43] jgleeson: yeah - local sites are fine re symlinks [21:47:53] if not just re-run civibuild [21:49:26] once composer merge plugin is merged I will update buildkit to run on composer 2 & then try to switch us to use upstream buildkit directly [21:49:41] & archive our repo [21:50:44] ah ok, is anyone else able to look at that fr-tech with docker civicrm setup? I wanted to push the twig & currency stuff before hopping off [21:51:19] eileen: I need to update my fundraising-dev civi image as it's currently broken due to my civiproxy tinkering [21:51:24] :-) [21:52:02] to be honest updating composer merge plugin kinda does nothing anyway - except allows us to switch to composer 2 as a follow up [21:52:16] it doesn't alter anything in verndor that is actually used in running the code [21:52:54] ok sounds good. I'll give others a check IRC and if not I'll push it through [21:52:59] a chance* [22:02:52] (PS1) Eileen: Switch to composer 2 [wikimedia/fundraising/crm/civicrm-buildkit] - https://gerrit.wikimedia.org/r/669993 (https://phabricator.wikimedia.org/T267881) [22:07:51] (PS2) Reedy: Update twig/twig [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [22:10:51] (CR) Reedy: "As a heads up, you might want to check your're all using the same versions (ie something pretty recent) of composer as there's seemingly a" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [22:14:03] (CR) Reedy: Update twig/twig (1 comment) [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [22:14:24] (CR) Eileen: "> Patch Set 2:" [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [22:14:49] (PS2) Eileen: Upgrade wikimedia/composer-merge-plugin to version 2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/669977 (https://phabricator.wikimedia.org/T267881) [22:16:00] (CR) Jgleeson: [C: -1] "let's delay this until we can work out why the package @ejegg added is being removed." [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/668463 (https://phabricator.wikimedia.org/T271212) (owner: Jgleeson) [22:16:52] hah jgleeson you want to wait on the twig then? [22:17:19] if you want to chat more through the deploy I go back into backlog jgleeson [22:17:30] cstone: I just tested that patch again with the FundraiserUnsubscribe twig forms and I'm seeing a bunch of deprecation warnings so it probably needs a but more work )_) [22:17:43] ah okay [22:18:20] it's tricky because unwinding that patch isn't easy [22:18:42] but that would be the quickest way to push our the currencyrates update, and then revisit twig afterwards [22:18:54] yeah that works [22:19:55] I'm out of time for tonight. dstrine sorry man but we'll have to deploy the currency rates thing in the morning UTC, is that ok? we need a bit more time to fix/remove a patch infront of it that's causing problems [22:20:05] what time is the test tomorrow [22:20:53] jgleeson: oh um it's 16-19utc I need to actually look up what that is for me. [22:21:01] it's basically your time right? [22:21:12] so no one else can help get this out? [22:22:20] jgleeson: XenoRyet fr-tech I'm about to go into a meeting. so no one else can deploy this? [22:22:47] I can't talk about this for another hour or so. can this get discussed and someone get back to me? [22:22:57] sure dstrine [22:23:21] dstrine: I can pick it up first thing tomorrow (9am UTC) and shouldn't take that long to get out. I can send up a flare early in the day if for some reason I get get it out but that is unlikely. [22:23:25] ok dstrine [22:23:42] some reason I can't get it out*** [22:24:00] jgleeson: okI'll update the email. as you work tomorrow please watch the email "[Banners] LatAm Pre-test tomorrow, Mar 9, 16 - 19 UTC" [22:25:27] cstone: so this has been made slightly tricker due to me having to delete the last tag we pushed to smash pig, v0.6.8. as CI is running `composer update` somewhere when testing the twig patch, and in turn trying to update to 0.6.8 but falling over due to vendor using 0.6.7. [22:25:49] so my thinking was delete our new tag, push out twig then retag current smashpig@master [22:26:10] however the twig patch now seems to have deprecation warnings I didn't see first time around [22:26:29] i was testing with this URL https://localhost:8001/index.php/Special:FundraiserUnsubscribe?p=thankyou&c=123&e=test@aol.com&h=5382E5433D701CB916F5871467B840DBB51351DD [22:26:50] okie thanks for the link [22:26:51] which loads but when I go to unsubscribe it errors, so I need to dig into that [22:27:25] I put the deprecation warnings in the comment on the ticket also https://gerrit.wikimedia.org/r/c/mediawiki/core/+/668463/2#message-e6ebb091f7b4747feb4fecb6eb6f64686093e95d [22:27:40] ah okay so thats why ci failed the first time on the twig patch? [22:28:02] yeah CI failed the first time due to us pushing out a new version of smashpig [22:28:30] the twig patch is tied to v0.6.7 but CI looks to be always looking for the latest and was pulling in v0.6.8 and causing an error [22:28:44] it's kinda a lucky in a way [22:29:19] as if we'd pushed out the twig patch without realising the deprecation issues we might have had other problems [22:29:50] im gona take my +2 off it so itll actually submit when we are ready with it too [22:30:05] * jgleeson note to self: actually test the things using twig when updating twig [22:30:22] cool [22:31:31] I'm gonna head off, catch you all tomorrow o/ [22:33:55] eileen: you happy with that first patch being +2'd? [22:34:10] jgleeson: I'm just digging now actually - hang off [22:34:22] I'm finding it's treating --no-dev differently [22:34:30] ah ok [22:34:41] I'll check it out in the morning if it's not +2'd [22:34:44] seeya! [22:46:31] so it seems like it's a bit trigger to get composer merge plugin to work right without doing a generic composer update - just checking to see what might be swept up in that [22:48:11] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) It seems that updating composer-merge-plugin without running a free range composer upda... [22:55:02] Fundraising Sprint Corrugated super slide, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Zeitgeistbusters, Fundraising-Backlog, and 2 others: Get civi working on docker - https://phabricator.wikimedia.org/T262975 (brennen) Published above: ` [contint.wikimedia.org... [22:57:46] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Reedy) >>! In T267881#6894388, @Eileenmcnaughton wrote: > It seems that updating composer-merge-plugin wi... [22:59:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wiki-Loves-Monuments, Wikimedia-production-error: It should not be possible to run a banner campaign with a syntax error - https://phabricator.wikimedia.org/T268792 (Umherirrender) CentralNotice could load the CodeEditor as done on user.js... [23:00:39] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) thanks @Reedy - I'll try that! [23:02:53] looking at T276293 the change for utf8mb4 should be straight forward to do in the code. mostly it's a set of character set and collation specifications in the sql files. [23:02:54] T276293: Test silverpop export with utf8mb4 tables - https://phabricator.wikimedia.org/T276293 [23:03:30] definitely something that we can do and test before or after the conversion on the maint window in 2 days. [23:11:02] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) Wow - that is taking forever to run .... waiting waiting [23:11:40] (PS1) Dwisehaupt: Shift from utf8 to utf8mb4 encoding for the DB tables [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/670000 (https://phabricator.wikimedia.org/T276293) [23:17:32] Fundraising Sprint Esperantoland, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: Test silverpop export with utf8mb4 tables - https://phabricator.wikimedia.org/T276293 (DStrine) p:Triage→High [23:18:26] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) Hmm - nope doing that it removed a bunch of packages added in by composer merge plugin... [23:27:09] (CR) Dwisehaupt: "This is a first stab for testing. It just updates the utf8 to utf8mb4. We will probably want to check the field values and adjust them to " [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/670000 (https://phabricator.wikimedia.org/T276293) (owner: Dwisehaupt) [23:27:16] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Reedy) Are they all dev dependancies? Numerous of them look to be... ` --no-update... [23:30:02] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) A number of them are but not all - so specifically Removing league/csv (9.3.0) is on... [23:31:57] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) This sequence DOES work (although it updates extras) - Manually update composer.json t... [23:34:04] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Reedy) `dev` in this case should means things that are listed in a `require-dev` somewhere in the heirarc... [23:35:32] Fundraising Sprint Esperantoland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Composer, Patch-For-Review: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) Yep - I'm just looking to see what composer update will change - it would be nice just... [23:42:21] dwisehaupt: cool - I seem to be in a composer rabbit hole but should get to it [23:50:01] eileen: cool. i put up a WIP that i _think_ may handle most of it. but haven't tested at all: https://gerrit.wikimedia.org/r/670000