[00:02:41] (PS1) Eileen: Add handling for possibility of concurrent processes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672839 (https://phabricator.wikimedia.org/T271416) [00:05:00] (PS2) Eileen: Fix incorrect complete recurring statuses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672803 (https://phabricator.wikimedia.org/T277590) [00:05:17] (CR) Eileen: "thanks ejegg - I've swapped it" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672803 (https://phabricator.wikimedia.org/T277590) (owner: Eileen) [00:13:02] (CR) Ejegg: [C: +2] Fix incorrect complete recurring statuses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672803 (https://phabricator.wikimedia.org/T277590) (owner: Eileen) [00:29:02] (Merged) jenkins-bot: Fix incorrect complete recurring statuses [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672803 (https://phabricator.wikimedia.org/T277590) (owner: Eileen) [00:55:23] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 [00:55:41] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [00:56:38] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [01:00:33] don't tell me your frog is back cstone! [01:00:39] (PS1) Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/672844 [01:03:12] (CR) Eileen: [C: +2] Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/672844 (owner: Eileen) [01:04:01] (PS2) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 [01:04:42] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [01:08:11] I'm just marking a few patches WIP that aren't reviewable - it still leaves me with an issue that I don't think I'm subscribed to all the repos where I SHOULD see patches needing review but will move out the ones that aren't from the ;'review panel' [01:17:34] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [01:28:03] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [01:29:00] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [01:29:42] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [01:39:37] (PS1) Eileen: Remove now-obsolete code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672851 (https://phabricator.wikimedia.org/T277590) [01:47:02] ejegg|food: I'm having a vendor battle... [01:51:55] (PS1) Eileen: Fix incorrect complete recurring statuses [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672852 (https://phabricator.wikimedia.org/T277590) [01:52:11] (CR) Eileen: [C: +2] Fix incorrect complete recurring statuses [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672852 (https://phabricator.wikimedia.org/T277590) (owner: Eileen) [01:52:42] (CR) Eileen: [C: +2] "merge to deployment is snarled up - cherry pick" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672852 (https://phabricator.wikimedia.org/T277590) (owner: Eileen) [01:55:06] !log civicrm revision changed from 550be50105 to 8c137b94f0, config revision is ef2767ab91 [01:55:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:21:16] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672854 [02:21:30] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672843 (owner: Eileen) [02:21:43] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672854 (owner: Eileen) [02:21:51] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672854 (owner: Eileen) [02:23:42] (CR) Eileen: [V: +2 C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672854 (owner: Eileen) [02:24:05] (CR) Eileen: [V: +2 C: +2] "forcing this as I don't think the vendor battle is winnable" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672854 (owner: Eileen) [02:25:27] !log civicrm revision changed from 8c137b94f0 to 99bf1c9210, config revision is ef2767ab91 [02:25:27] - not I forced the merge as I was losing in getting it to accept the vendor update [02:25:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:29:36] (PS1) Eileen: Typo fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672855 [02:29:49] (CR) Eileen: [C: +2] Typo fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672855 (owner: Eileen) [02:30:01] (CR) Eileen: [V: +2 C: +2] Typo fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672855 (owner: Eileen) [02:30:53] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672856 [02:31:05] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672856 (owner: Eileen) [02:31:26] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672856 (owner: Eileen) [02:43:22] hi eileen [02:43:45] let's see, looks like a deploy [02:43:47] hey ejegg I force merged in the hope it would 'get over it' - but erm no [02:43:55] I documented here 7 [02:44:06] https://phabricator.wikimedia.org/T277617 [02:45:24] oh hmm, that .git directory missing had previously only happened when there was a change upstream that we didn't have in vendor [02:45:54] yeah - so there is one thing that is a bit weird in vendor [02:46:57] until an hour ago this wasn't merged https://github.com/mrmarkfrench/silverpop-php-connector/pull/38 [02:47:05] & there was some mickey mouse around that [02:47:34] CI is still using composer 1.x ? [02:47:34] I'll try updating composer to the new tag & see if it helps https://github.com/mrmarkfrench/silverpop-php-connector/releases/tag/1.5.1 [02:48:16] so not on master - but maybe on deploy? [02:52:04] hmm so composer update mrmarkfrench/silverpop-php-connector [02:52:12] implies it is not found on packages yet [02:52:33] (that amazon one - if you tag a release that could help? - do we even use it now?) [02:53:44] grrr, locally I see - Updating amzn/login-and-pay-with-amazon-sdk-php dev-master (0c923fe => 0c923fe) [02:53:49] so what is it updating? [02:53:58] note same from and to sha [02:54:11] we do use it [02:54:49] I guess I have to register it under a different name at packagist to be able to tag a release? [02:55:36] not sure - we are getting it from version control so I suspect not [02:55:57] upstream has moved on a fair bit! [02:56:04] yes it has [02:56:26] let's see if they have any facilities for dealing with the reports yet [02:56:31] that's why I forked [02:56:40] they have a bunch of useful stuff for making API calls [02:56:48] but only support the API calls directly related to payments [02:57:00] not the ones that you need to automatically download the audit files [02:57:05] and I tried upstreaming twice [02:57:16] (a bit annoying with their messy whitespace) [02:57:19] but got nowhere [02:57:21] :-) [02:57:41] A lot of packages are a bit more active now due to php 8 [02:58:26] ugh, they still have a copy of Psr/Log pasted into their repo too https://github.com/amzn/amazon-pay-sdk-php/tree/master/Psr/Log [02:58:43] just asking for version conflicts [02:59:12] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Omnipay mini test development and assessment - https://phabricator.wikimedia.org/T277246 (tstarling) Hi, I see you triaged this task as Unbreak Now. Do you need help? [02:59:45] so how does one tag a release on a fork? [03:00:11] when we tag releases for SmashPig we push a git tag and hit the 'update' button in packagist [03:01:09] I'll try just pushing a tag and see what that does [03:02:29] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Omnipay mini test development and assessment - https://phabricator.wikimedia.org/T277246 (DStrine) Nope but thanks for checking! This and one other task are highest priority for the current fr-tech sprint. I wanted to be absolutely sure thi... [03:03:21] ejegg: from this page https://github.com/ejegg/login-and-pay-with-amazon-sdk-php/releases you should have an option [03:06:24] ok, I just added that 2.5.0 tag [03:06:42] oh hmm [03:07:05] right, that makes sense for the master branch [03:09:10] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Omnipay mini test development and assessment - https://phabricator.wikimedia.org/T277246 (tstarling) I would suggest high priority for that, per https://www.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels . I am regularly... [03:11:50] (PS1) Eileen: Use non-abandoned linter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672858 [03:12:13] ejegg: what do you think about ^^ - get rid of those warnings [03:13:15] yah, sounds good! [03:16:50] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Omnipay mini test development and assessment - https://phabricator.wikimedia.org/T277246 (DStrine) p:Unbreak!→High [03:17:09] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Payum mini test development and assessment - https://phabricator.wikimedia.org/T277245 (DStrine) p:Unbreak!→High [03:18:28] (PS1) Ejegg: Update libs to get off dev-master [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/672859 [03:18:49] ok, ^^^ gets the dev-master dep out of SmashPig [03:19:44] ejegg: do you think I can +2 on 'yeah that seems like the right thing to do' -& rely on CI? [03:20:44] (PS2) Ejegg: Update libs to get off dev-master [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/672859 [03:20:51] yep, I think so! [03:21:09] cool - the symfony change is just a minor version change [03:21:27] oh, right, we actually already upgraded to ..52 [03:21:37] (CR) Eileen: [C: +2] "Yep - agree with this. The symfony version is a minor change we have been running locally anyway" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/672859 (owner: Ejegg) [03:21:42] just that jack forgot a char in the .json [03:21:50] done [03:21:54] thanks [03:22:22] I'll actually deploy that change - it pulls in a patch to the amzn fork which gets rid of some warnings on trimming arrays [03:23:23] cool -do you want to +2 the one I did on the linter (https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/672858/) [03:23:46] (CR) Ejegg: [C: +2] Use non-abandoned linter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672858 (owner: Eileen) [03:24:13] (CR) Eileen: "adding jenkins" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672858 (owner: Eileen) [03:25:47] (PS1) Ejegg: Update libraries [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/672860 [03:26:00] (CR) Ejegg: [C: +2] Update libraries [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/672860 (owner: Ejegg) [03:26:59] (CR) Ejegg: [V: +2 C: +2] Update libraries [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/672860 (owner: Ejegg) [03:27:14] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/672861 [03:27:51] ah, so I guess we do another minor version bump on SmashPig to percolate that amzn non-dev-ness down [03:28:00] :-) [03:31:59] (PS1) Ejegg: Get amzn lib fork off dev-master [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/672862 [03:33:46] (CR) jerkins-bot: [V: -1] Get amzn lib fork off dev-master [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/672862 (owner: Ejegg) [03:38:08] (PS1) Eileen: Fix for warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672863 [03:38:18] ejegg: ^^ one more fix for composer warnings [03:39:12] oh cool, one sec [03:44:57] (CR) Ejegg: [C: +2] Fix for warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672863 (owner: Eileen) [03:45:33] (CR) Ejegg: [C: +2] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/672862 (owner: Ejegg) [03:48:09] (Merged) jenkins-bot: Get amzn lib fork off dev-master [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/672862 (owner: Ejegg) [03:55:08] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/672865 [03:55:15] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/672865 (owner: Ejegg) [03:56:57] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/672865 (owner: Ejegg) [03:59:07] (Merged) jenkins-bot: Fix for warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672863 (owner: Eileen) [04:00:36] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/672866 [04:04:16] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/672866 (owner: Ejegg) [04:04:18] (PS1) Eileen: Code cleanup on rip extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672867 [04:05:13] ejegg: I looked at the last abandoned warning - it will be a bit of a pain... so I just updated one extension for now ^^ (should be an easy merge) [04:10:55] (CR) Ejegg: [C: +2] "Gotta start someplace! Looks like a clean update." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672867 (owner: Eileen) [04:12:34] hmm, it's a bit late here to actually push those changes out [04:12:49] I'll put them on prod first thing tomorrow [04:15:21] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/672866 (owner: Ejegg) [04:17:44] oh fun, I need to tag another donation-interface release to actually percolate all the way down to Civi [04:17:55] :-) [04:18:17] tomorrow might be a good day for it [04:18:21] yep yep [04:18:31] have a good rest of your day eileen ! [04:18:37] night! [04:24:53] (Merged) jenkins-bot: Code cleanup on rip extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672867 (owner: Eileen) [04:55:14] (PS1) Eileen: Preparation to move buildForm hook to the extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672873 (https://phabricator.wikimedia.org/T277590) [05:05:57] (PS2) Eileen: Remove now-obsolete code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672851 (https://phabricator.wikimedia.org/T277590) [05:05:59] (PS2) Eileen: Preparation to move buildForm hook to the extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672873 (https://phabricator.wikimedia.org/T277590) [05:06:01] (PS1) Eileen: Switch to preferred core function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672874 (https://phabricator.wikimedia.org/T277590) [05:06:03] (PS1) Eileen: Move buildForm from module to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672875 (https://phabricator.wikimedia.org/T277590) [05:41:00] (PS1) Eileen: Remove 'Contributions OR Soft Credits?' from search [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672876 (https://phabricator.wikimedia.org/T277590) [05:41:02] (PS1) Eileen: Code comment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/672877 [06:42:57] Wikimedia-Fundraising: Vendor issue on merge-to-deployment on crm (composer-merge-plugin related) - https://phabricator.wikimedia.org/T277617 (Aklapper) [08:56:37] Wikimedia-Fundraising: Vendor issue on merge-to-deployment on crm (composer-merge-plugin related) - https://phabricator.wikimedia.org/T277617 (Peachey88) [13:52:16] Fundraising Sprint Corrugated super slide, Fundraising Sprint Downed power line jump rope, Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, and 4 others: BannerExistenceException due to non-existing CentralNotice banner (after Special:LanguageStats v... - https://phabricator.wikimedia.org/T157997 [13:55:05] (CR) Jgleeson: "This looks good. Do we have an associated image with Python installed to run them or is that to follow?" [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/670612 (https://phabricator.wikimedia.org/T269708) (owner: Eileen) [15:08:24] hi fr-tech! [15:09:32] any news for scrum of scrums? [15:15:28] hey ejegg, nothing from me [15:23:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Months-long delays in deployment of CentralNotice translations - https://phabricator.wikimedia.org/T273176 (Nikerabbit) We don't currently have tooling support for doing backports. This is tracked in {T272830}. [15:49:42] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/672861 (owner: Ejegg) [15:51:51] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/672861 (owner: Ejegg) [15:54:34] !log updated standalone SmashPig deployment from 58b070db1a to 250a8570d1 [15:54:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:56:43] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Omnipay mini test development and assessment - https://phabricator.wikimedia.org/T277246 (AndyRussG) a:AndyRussG [15:59:09] hmm, looks like we're getting some curl timeouts fo paypal_ec from payments dwisehaupt Jeff_Green [15:59:27] doesn't say just which IP address in the logs [15:59:47] can you see requests being blocked in the FW logs? [15:59:57] ok, yeah we should be able to figure it out [16:00:47] doesn' [16:00:52] this is on civi1001? [16:01:04] no, from payments1003 [16:01:17] and payments1001 [16:01:21] ok looking [16:01:25] oh, and payments1002 too [16:02:03] huh, they're not being blocked locally [16:03:58] ejegg: does it provide ips that are getting timeouts or is it just the general domain logged. [16:05:19] just that it's paypal related [16:05:29] i think we have debug logging off [16:05:34] hrm. ok. [16:05:36] but if we turn it on we might get IPs [16:06:17] hmm, another error coming up pretty frequently in the ingenico logs, but not ops-related: The payment submethod [122] was not found [16:06:20] let's see what that is [16:09:26] fr-tech i have lost my meet connection [16:09:30] but irc still seems happy [16:09:36] ok, back [16:17:37] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Astropay-DLocal_endpoint_critical 1 [=1] [16:18:21] (PS1) Ejegg: Allow visa-electron for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673052 [16:20:17] (CR) Cstone: [C: +2] Allow visa-electron for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673052 (owner: Ejegg) [16:22:37] RECOVERY - check_log_messages on frav1002 is OK: OK [16:38:14] (Merged) jenkins-bot: Allow visa-electron for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673052 (owner: Ejegg) [16:40:26] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/673056 [16:40:59] ejegg: I'm going to cook dinner but I moved the logs from the '122' stuff to /tmp/122 if it's any use [16:41:13] sorry, on frlog1001 ! [16:41:21] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/673056 (owner: Ejegg) [16:41:24] thanks jgleeson|dinner [16:42:25] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/673058 [16:42:50] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/673058 (owner: Ejegg) [16:47:37] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 1 [=1] [16:52:37] RECOVERY - check_log_messages on frav1002 is OK: OK [16:54:22] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/673058 (owner: Ejegg) [17:05:38] (CR) AndyRussG: "Hey, thanks so much! Just noticed a smol error (see inline comment)." (1 comment) [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/670612 (https://phabricator.wikimedia.org/T269708) (owner: Eileen) [17:22:37] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 2 [=1] [17:26:34] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/673056 (owner: Ejegg) [17:27:37] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 4 [=1] [17:32:37] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 2 [=1] [17:37:41] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: Paypal_endpoint_critical 3 [=1] [17:42:41] RECOVERY - check_log_messages on frav1002 is OK: OK [17:47:43] !log updated payments-wiki from 0405ea1723 to b06009c099 [17:47:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:50:42] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Visa-electron payments failing for Ingenico - https://phabricator.wikimedia.org/T277682 (Ejegg) [17:52:03] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Visa-electron payments failing for Ingenico - https://phabricator.wikimedia.org/T277682 (DStrine) I added DR and Evelyn to this. DR hasn't seen tickets on this yet. [18:00:27] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Visa-electron payments failing for Ingenico - https://phabricator.wikimedia.org/T277682 (Ejegg) We just deployed a fix and are no longer seeing the errors in the logs. [18:13:25] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog: Visa-electron payments failing for Ingenico - https://phabricator.wikimedia.org/T277682 (EMartin) Confirming no need for me to reach out to Ingenico. [18:33:18] fr-tech any clues on the 122 thingy? [18:36:48] jgleeson: I think we just fixed it [18:37:20] let's see if we can see some new visa-electron ingenico donations from the queue [18:40:24] yep, e.g. 100789389.1 is visa-electron [18:40:38] jeez, find contribs page taking forever to load though [18:44:33] any ideas why some failed and others got through? [18:44:47] maybe just the usual dropoffs showing up [18:45:02] they all failed till we put that patch up, didn't they? [18:45:15] donations were processed with ingenico [18:45:24] prior to the failure [18:45:38] and in some cases it appears not [18:45:50] or at least based on that quick scan of the logs on the call [18:45:55] so we were missing one specific payment product ID from our decoder [18:46:15] and donors using that type of card were all getting a fail page after coming back from ingenico [18:46:33] then about an hour ago I deployed a change to add that payment product ID [18:46:46] and now the donors with that type of card are getting into Civi [18:47:02] hmm, or should be [18:47:35] that search may not be looking in the right field [18:48:15] hmm [18:48:35] so I'm pretty sure I saw some records with that error that got redirected to the thank you page [18:48:42] lemme check the logs in tmp [18:50:59] oh it wasn't in those logs, it showed up after I looked up a ct_id who had triggered the error [18:55:46] ejegg: 100678603.2 is one that was pushed to the donations queue after being redirect to the IT thank you page after hitting that error [18:56:01] looking [18:56:08] moved to other chane [18:56:10] chan [18:58:58] oh gross, that donation got pushed to the queue with payment_submethod=122 [19:13:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New weird dedupe error - https://phabricator.wikimedia.org/T277695 (Eileenmcnaughton) [19:29:58] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New weird dedupe error - https://phabricator.wikimedia.org/T277695 (DStrine) [19:46:18] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Key Relationships not showing for a record that has a relationship - https://phabricator.wikimedia.org/T276592 (Eileenmcnaughton) Yes - it is - on the relationship type edit screen there is a check box (I... [19:50:36] jgleeson: so situation with acoustic is clear as mud? [19:53:51] pretty much. [19:54:15] not sure on next steps tbh [19:54:48] (PS4) Eileen: Add tools repo to checkout [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/670612 (https://phabricator.wikimedia.org/T269708) [19:55:02] and I haven't had a chance to dive into it much but I'm pretty sure the fact that we're writing the data using the same csv.writer encoding rules means acoustic should still be getting utf-8 data [19:59:14] something else eileen. On the call with Brian, he noticed that the new records added to the MSL from the unsubscribes was around 5k and it's normally only about 300 a day. I think he was looking at the stats in acoustic for the jobs run on the 16th, UTC morning. [19:59:26] so something odd is at play [19:59:33] hmm my head hurts [19:59:38] yeah same [20:00:00] it feels like we need to somehow convert/cast to utf8 and see if it changes anything [20:00:05] to rule it out [20:01:11] we might be able to also try out writing the data using more specific encoding flags [20:01:18] ejegg: looked at something related to that I think [20:06:30] (PS1) Jgleeson: WIP: Add CiviProxy setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/673094 (https://phabricator.wikimedia.org/T268683) [20:07:45] (CR) Eileen: "Thanks - I've made the updates" (1 comment) [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/670612 (https://phabricator.wikimedia.org/T269708) (owner: Eileen) [20:07:56] (PS2) Jgleeson: WIP: Add CiviProxy setup [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/673094 (https://phabricator.wikimedia.org/T268683) [20:10:52] jgleeson: ok - so I guess I'm not sure if there is something I should do on the acoustic issue at the moment [20:11:00] it seems like there is a test being done? [20:12:54] eileen: the last I read was that today's test to recreate the unsubscribe mapping job failed to fix the count discrepancy [20:13:07] ok [20:13:24] and acoustic don't know what's up [20:13:40] did you see the latest email from Brian? [20:13:49] I think fr-failmail was cc'd in [20:15:20] ah yeah you replied [20:15:47] yeah - but perhaps we can export with the collation changed - https://stackoverflow.com/questions/18656001/how-export-csv-from-mysql-utf8 [20:16:00] I'm wondering if dwisehaupt can do a direct csv export like that [20:16:58] I've gotta drop off but I'll be back later. I'm leaving fundriaisng-dev to build from scratch [20:37:58] (PS1) Eileen: Use utf8 view for silverpop excluded [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673099 (https://phabricator.wikimedia.org/T277366) [20:38:17] ejegg: jgleeson|away we could try ^^ [20:39:37] (CR) jerkins-bot: [V: -1] Use utf8 view for silverpop excluded [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673099 (https://phabricator.wikimedia.org/T277366) (owner: Eileen) [20:48:19] (CR) Eileen: "I don't want to bring the container part into scope here but noting we can maybe just use the releng docker docker-registry.wikimedia.org/" [wikimedia/fundraising/dev] - https://gerrit.wikimedia.org/r/670612 (https://phabricator.wikimedia.org/T269708) (owner: Eileen) [21:09:12] eileen: i'd like to try that on staging and do a file diff [21:09:22] ejegg: good idea [21:09:35] it's failing CI (I'm in search kit mtg for next hour) [21:09:54] oh yeah, lemme try a couple things for that CI fail [21:15:12] (PS1) Ejegg: Update contribution_tracking test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673127 (https://phabricator.wikimedia.org/T277595) [21:17:31] ok, ^^^ should make tools CI work again eileen [21:17:47] i checked on prod, the c_t table did get updated with the new encoding [21:18:35] so now even the country code can be 🌈🐸 [21:19:07] well, as soon as the state department lifts the embargo [21:32:19] eileen: saw my mention, just getting through backscroll [21:34:39] if we want to try an export using that select into with charset it can be done. [21:34:56] i'd just need the query for the select [21:36:43] (PS1) Ejegg: Minimal MinFraud fix for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673130 [21:37:22] eileen: I think ^^^ is enough of a fix for me to be able to tag another DonationInterface lib version to update that + smashpig + amzn fork under CRM [21:37:40] fundraising-tech-ops: Enable GTID for payments-wiki mariadb - https://phabricator.wikimedia.org/T277710 (Dwisehaupt) [21:38:43] fundraising-tech-ops: FY2020-21 Q3 maintenance window - https://phabricator.wikimedia.org/T268056 (Dwisehaupt) [21:38:47] dwisehaupt: it's just select * FROM silverpop_excluded - I did try a view silverpop_excluded_utf8 [21:39:06] fundraising-tech-ops: FY2020-21 Q3 maintenance window - https://phabricator.wikimedia.org/T268056 (Dwisehaupt) Open→Resolved a:Dwisehaupt [21:39:25] ok. let me have a go. [21:39:41] (CR) jerkins-bot: [V: -1] Minimal MinFraud fix for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673130 (owner: Ejegg) [21:41:01] ejegg: that patch seems sensible but I wonder if I should defer to someone more familiar with that code? [21:41:45] eileen: frdev1001:/tmp/silverpop_excluded_test.csv [21:42:02] file shows is as UTF-8 Unicode text [21:42:06] oops, what's that V-1 [21:42:22] thanks dwisehaupt so the next challenge ejegg is to upload that csv [21:42:42] eileen: it's pretty darn minimal! just moves a single line inside a loop [21:42:50] ah, i left a double blankline [21:42:50] ejegg: ok sold [21:42:58] fixing the WS first, one sec [21:43:31] (PS2) Ejegg: Minimal MinFraud fix for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673130 [21:44:51] eileen: ah, to upload that one we would need to move it to the normal location then run the upload only script [21:45:16] would it make sense to have that script take flags to tell it which file to upload, and even from which path? [21:47:53] hmm, it's strictly just sftp [21:48:20] so we could do it via command line [21:48:37] unless there's a user restriction on connecting out, which there may be [21:49:01] there probably is. i can easily move/rename it to where ever you need. [21:51:24] (CR) Eileen: [C: +2] Minimal MinFraud fix for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673130 (owner: Ejegg) [21:54:11] (Merged) jenkins-bot: Minimal MinFraud fix for orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/673130 (owner: Ejegg) [21:54:36] ejegg: what folder are the export files in again? [21:57:33] messaged in otherchan [21:57:58] just if we're reuploading all of em they need to re-run the import job on thier side for all of em [21:58:05] so as not to get behind by one [22:11:07] (PS1) Ejegg: Update SmashPig, amzn fork, and DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/673138 [22:11:26] ok eileen, ^^^ gets amzn off of dev-master in CRM [22:11:35] though I see we are still using dev-master for a few other libs [22:11:50] I guess we'll see if those bork CI too [22:24:55] (CR) Eileen: [C: +2] Update SmashPig, amzn fork, and DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/673138 (owner: Ejegg) [22:25:24] ejegg: I guess we'll find out... [22:42:16] (Merged) jenkins-bot: Update SmashPig, amzn fork, and DonationInterface [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/673138 (owner: Ejegg) [22:44:03] (PS1) Ejegg: Update to composer-merge-plugin version 2 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/673144 [22:45:28] (PS2) Ejegg: Update to composer-merge-plugin version 2 [core] (fundraising/REL1_35) - https://gerrit.wikimedia.org/r/673144 [22:49:33] (PS1) Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/673147 [22:49:43] ejegg: ^^ is the vendor update for your changes so far [22:49:55] does it look how you expected? [22:51:20] yep, that checks out [22:51:41] the amzn package is the same sha, just now refered to by version 2.5.0 in installed.json [22:51:52] and the smashpig and d-i updates look right [22:52:47] fr-tech I'mma upgrade the composer-merge-plugin in our mediawiki branch unless someone can think of a good reason not to yet [22:53:02] (CR) Eileen: [C: +2] Update contribution_tracking test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673127 (https://phabricator.wikimedia.org/T277595) (owner: Ejegg) [22:53:20] (CR) Eileen: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/672470 (owner: Cstone) [22:53:58] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog, Patch-For-Review: fundraising tools CI is failing - https://phabricator.wikimedia.org/T277595 (Eileenmcnaughton) Doing a recheck on the patch now [22:55:17] (Abandoned) Eileen: WIP: Testing CI [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/672470 (owner: Cstone) [22:55:32] Fundraising Sprint File Systems Stage Show, Fundraising-Backlog, Patch-For-Review: fundraising tools CI is failing - https://phabricator.wikimedia.org/T277595 (Eileenmcnaughton) Looks like it worked! [22:57:25] Fundraising Sprint Esperantoland, Fundraising Sprint File Systems Stage Show, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Get our repo onto Composer 2 - https://phabricator.wikimedia.org/T267881 (Eileenmcnaughton) Open→Resolved This is done - follow up issue for gett... [23:03:26] (CR) Eileen: [C: +2] "I checked with ejegg on irc & confirmed this looks right" [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/673147 (owner: Eileen) [23:06:07] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673152 [23:06:22] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/672856 (owner: Eileen) [23:06:36] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673152 (owner: Eileen) [23:07:16] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673152 (owner: Eileen) [23:28:29] (PS1) Eileen: Update a few more packages off dev-master onto tags [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673158 [23:28:33] (CR) jerkins-bot: [V: -1] Update a few more packages off dev-master onto tags [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673158 (owner: Eileen) [23:30:01] (PS1) Eileen: Update a few more packages off dev-master onto tags [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/673160 [23:31:15] (Abandoned) Eileen: Update a few more packages off dev-master onto tags [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673158 (owner: Eileen) [23:31:31] (CR) Eileen: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673099 (https://phabricator.wikimedia.org/T277366) (owner: Eileen) [23:32:14] ejegg: I just put up https://gerrit.wikimedia.org/r/673160 to get geocoder off dev-master [23:32:28] (new point of failure :-) [23:33:23] k, looking [23:34:20] so just phpunit upgrade + phpdoc, looks fine to me! [23:34:25] (CR) Ejegg: [C: +2] Update a few more packages off dev-master onto tags [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/673160 (owner: Eileen) [23:34:53] ejegg: it updates the geocoder/here & another one - but I think they are v safe [23:35:51] sure, especially since we don't use em! [23:37:15] :-) [23:37:47] yep - I try to also run civix & cleanup a bit when I touch extensions but not much in that change [23:44:30] (CR) Dwisehaupt: [C: +2] "Looks good to me. Let's deploy and see what the data looks like." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673099 (https://phabricator.wikimedia.org/T277366) (owner: Eileen) [23:46:25] (Merged) jenkins-bot: Use utf8 view for silverpop excluded [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673099 (https://phabricator.wikimedia.org/T277366) (owner: Eileen) [23:48:54] (PS1) Eileen: Include id too to keep file the same [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673163 (https://phabricator.wikimedia.org/T277366) [23:50:14] (Merged) jenkins-bot: Update a few more packages off dev-master onto tags [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/673160 (owner: Eileen) [23:53:30] (CR) Dwisehaupt: [C: +2] Include id too to keep file the same [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673163 (https://phabricator.wikimedia.org/T277366) (owner: Eileen) [23:54:35] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673166 [23:55:06] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673166 (owner: Eileen) [23:55:11] (Merged) jenkins-bot: Include id too to keep file the same [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/673163 (https://phabricator.wikimedia.org/T277366) (owner: Eileen) [23:55:29] (PS1) Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/673167 [23:57:00] Fundraising-Backlog, Analytics, FR-Tech-Analytics: Whitelist Portal and WikipediaApp event data for (sanitized) long-term storage - https://phabricator.wikimedia.org/T273246 (EYener) Hi @mforns - thanks again for the help and advice earlier this week. I have updated the gerrit reviews with the inform... [23:57:53] (PS1) Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/673168 [23:59:03] (CR) jerkins-bot: [V: -1] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/673168 (owner: Eileen) [23:59:08] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/673152 (owner: Eileen) [23:59:51] (CR) Eileen: [C: +2] Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/673167 (owner: Eileen)