[00:56:59] (PS3) Ejegg: Fully remove wmf_reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/675908 (https://phabricator.wikimedia.org/T270684) (owner: Eileen) [00:57:06] (CR) Ejegg: [C: +2] Fully remove wmf_reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/675908 (https://phabricator.wikimedia.org/T270684) (owner: Eileen) [01:11:03] (Merged) jenkins-bot: Fully remove wmf_reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/675908 (https://phabricator.wikimedia.org/T270684) (owner: Eileen) [01:12:40] (PS2) Ejegg: Remove code already dupllicated in deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/675928 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [01:12:53] (CR) Ejegg: [C: +2] "Yep, it's duplicated" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/675928 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [01:26:52] (Merged) jenkins-bot: Remove code already dupllicated in deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/675928 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [02:06:31] (CR) Cstone: [C: +2] Remove Davivienda from CO payment options [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/675917 (https://phabricator.wikimedia.org/T277770) (owner: Ejegg) [02:07:12] thanks cstone [02:07:19] np ejegg [02:09:17] (Merged) jenkins-bot: Remove Davivienda from CO payment options [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/675917 (https://phabricator.wikimedia.org/T277770) (owner: Ejegg) [02:37:58] (PS1) Eileen: Move skipping of wmf-donor fields to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) [02:41:08] (PS2) Eileen: Move skipping of wmf-donor fields to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) [02:55:39] (CR) jerkins-bot: [V: -1] Move skipping of wmf-donor fields to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [03:08:04] (PS3) Eileen: Move skipping of wmf-donor fields to deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676175 (https://phabricator.wikimedia.org/T270679) [03:12:02] eileen: just poking at the updated extended reports locally I notice an odd default filter getting applied in the UI - contribution ID is less than or equal to 1. [03:12:17] I don't see that anywhere in the extended reports code though [03:12:35] is this locally? [03:12:40] yah [03:12:50] hmm - are they saved reports? [03:12:53] so probably my own install's weirdness [03:13:02] -might be worth trying on staging? [03:13:03] nah, it's making a new report from template [03:13:09] sure, will do [03:13:53] ejegg: as an aside - one thing in the deduper code is a call to [03:13:54] watchdog("civicrm_merge_debug", "Deduping contacts $mainId and $otherId"); [03:13:54] [03:14:07] that gets logged to syslog via drupal doesn't it? [03:14:20] I guess we need some sort of logger on the civi side [03:14:25] eileen: ah true [03:14:34] all those 'watchdog' lines have to go [03:15:00] yeah, on staging the default is applied too [03:15:09] new report from template [03:15:18] -> contribution detail extended [03:15:31] then look under filters tab, expanding contirbutions [03:15:44] the Contribution ID 'Is less than or equal to' 1 [03:16:25] but in the code for that report the default filters are just the status id and is test [03:17:28] hmm, there was some afform fix that change the default operator a few weeks ago, right? [03:18:17] huh, didn't involve <= though [03:19:16] let me set some breakpoints locally and see if that filter default does come from backend or if it's purely frontend [03:19:54] ok - sounds weird [03:21:08] ejegg: on something else - I'm looking at preferred language resolution. There is some handling in the code that attempts to find the 'better' one because or our nastiness around preferred language - but I think I did that myself rather than on user request and what I want to do now is just keep the most recent donor's language & drop the rest [03:24:56] (PS1) Eileen: Move handling for do_not_solicit field to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676180 (https://phabricator.wikimedia.org/T270679) [03:24:58] (PS1) Eileen: Move preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676181 (https://phabricator.wikimedia.org/T270679) [03:28:54] right, most recent contact is a lot simpler than that other logic! [03:29:16] and hopefully we're cleaning things up a bit better on entry these days? [03:36:41] well, I'm a bit confused by the part of ExtendedReport::buildColumns that deals with defaults [03:37:55] it seems to stick a value from any one of fields_defaults, filters_defaults, or group_bys_defaults into the column's metadata.default key [03:38:28] so let's see where that gets used [03:38:35] (CR) jerkins-bot: [V: -1] Move preferred_language [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676181 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [03:40:08] (CR) jerkins-bot: [V: -1] Move handling for do_not_solicit field to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676180 (https://phabricator.wikimedia.org/T270679) (owner: Eileen) [03:43:42] ok, so for contribution_id we have group_bys_defaults set to true and it gets mashed into the metadata.default key, then over in setDefaultValues that gets copied into $this->_defaults['contribution_id_value'] = true [03:44:05] so how does a default value of true for a numerical field end up translating into a <= 1 filter? [03:45:09] ahh, it's the default operator [03:45:28] and true equals-ish 1 [04:04:56] eileen this seems to fix those funky default filters on my machine: https://github.com/eileenmcnaughton/nz.co.fuzion.extendedreport/pull/474 [04:05:41] not sure what it might break, though! [04:10:50] anyway, looks like the previous version of extendedreport did the same thing. Will +2 the current update in gerrit [04:12:23] (PS2) Ejegg: Update extended report to reflect upstream [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/674739 (owner: Eileen) [04:13:53] (CR) Ejegg: [C: +2] "Looks like a good update! I noticed some unwanted default filters getting added for fields that are default group-bys, but that predates t" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/674739 (owner: Eileen) [04:14:44] (PS3) Ejegg: EmailPreferencesTest: remove unneeded setUp() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/675739 (owner: DannyS712) [04:15:01] (CR) Ejegg: [C: +2] "Unneeded indeed!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/675739 (owner: DannyS712) [04:18:02] (Merged) jenkins-bot: EmailPreferencesTest: remove unneeded setUp() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/675739 (owner: DannyS712) [04:27:55] (Merged) jenkins-bot: Update extended report to reflect upstream [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/674739 (owner: Eileen) [04:29:58] k, heading to bed [04:30:01] gnight all [07:11:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) [07:12:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) //(Note: I am working on this on my own time, so, not as part of my work... [09:05:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (Jseddon) @AndyRussG your proposed solution is not ideal. It could seriously hamper n... [11:43:23] Fundraising-Backlog, MediaWiki-extensions-Other, Release-Engineering-Team, Documentation: [FundraisingTranslateWorkflow] Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996 (Aklapper) This deployed extension has no documentation... [12:16:40] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 9 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:21:34] PROBLEM - check_puppetrun on frpm1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 4 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:21:40] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 3 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:22:34] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 6 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:22:42] PROBLEM - check_puppetrun on civi2001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 5 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:25:44] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 8 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:26:34] PROBLEM - check_puppetrun on frpm1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 9 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:26:40] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 8 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:27:32] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 11 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:27:40] PROBLEM - check_puppetrun on civi2001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 10 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:30:44] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 13 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:31:34] RECOVERY - check_puppetrun on frpm1001 is OK: OK: Puppet is currently enabled, last run 46 seconds ago with 0 failures [12:31:40] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 13 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/etc/mysql/cacert.pem],File[/etc/mysql/server-cert.pem],File[/etc/mysql/server-key.pem] [12:32:32] RECOVERY - check_puppetrun on frpm2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [12:32:42] RECOVERY - check_puppetrun on civi2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [12:35:44] RECOVERY - check_puppetrun on civi1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [12:36:34] RECOVERY - check_puppetrun on fran1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [13:39:50] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [14:47:28] fundraising-tech-ops, DC-Ops, SRE, ops-eqiad: (Need By: TBD) install second SSD into payments100[5-8] - https://phabricator.wikimedia.org/T278250 (Cmjohnson) [14:48:32] fundraising-tech-ops, DC-Ops, SRE, ops-eqiad: (Need By: TBD) install second SSD into payments100[5-8] - https://phabricator.wikimedia.org/T278250 (Cmjohnson) @Jgreen The disks have been installed, feel free to do the install. @Jclark-ctr I left the packing slip in the box, can you receive and d... [14:48:46] fundraising-tech-ops, DC-Ops, SRE, ops-eqiad: (Need By: TBD) install second SSD into payments100[5-8] - https://phabricator.wikimedia.org/T278250 (Cmjohnson) a:Jclark-ctr [14:57:05] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [14:59:14] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [15:01:31] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [15:06:27] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [15:12:43] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [15:15:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) >>! In T279034#6963619, @Jseddon wrote: > @AndyRussG your proposed soluti... [15:24:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (DStrine) p:Triage→Lowest [15:24:54] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [15:50:07] Fundraising Sprint Bee Wheel, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Esperantoland, Fundraising Sprint File Systems Stage Show, and 5 others: Create new subpage for Special:EmailPreferences - https://phabricator.wikimedia.org/T268510 (Ejegg) @AndyRussG there's already... [15:53:53] oh hah, my right earphone isn't actually broken, the audio balance on my compy has just been all the way left for weeks [16:01:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (Jseddon) The rest of my comment about inequitably treating community campaigns is th... [16:02:14] ejegg oh awww well at least it's free to fix then :) [16:03:25] :P [16:33:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) >>! In T279034#6965502, @Jseddon wrote: > The rest of my comment about in... [16:46:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (Jseddon) There are a number of technical issues here whereby using cookies is going... [17:55:20] Fundraising Sprint Ghostbusting , Fundraising-Backlog, FR-dlocal, Patch-For-Review, Unplanned-Sprint-Work: Astropay: "go back" (volver) sometimes takes user to the TY page - https://phabricator.wikimedia.org/T131401 (EMartin) Hi all, I have been talking with Dlocal about this and they advise... [18:01:38] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [18:02:00] fundraising-tech-ops, Patch-For-Review: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (Dwisehaupt) Pushed this for make_grants to allow the ability to require ssl on user db connections. Not currently enabled for any accounts yet. ` [frack::puppet::... [18:02:18] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) p:Triage→Medium a:Dwisehaupt→Jgreen [18:05:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with Fundraising exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) >>! In T279034#6965817, @Jseddon wrote: > There are a number of technical... [18:21:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) [18:23:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) >>! In T279034#6965755, @AndyRussG wrote: > I can add an explanation of this... [18:24:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (Jseddon) From your description: on pageview 1 a cookie would be set that defined what b... [18:30:08] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Creating New Fidelity File Civi Import - https://phabricator.wikimedia.org/T275445 (MDemosWMF) @Eileenmcnaughton I just tested importing a few lines of a file and it... [18:32:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exception for infrequent visitors” - https://phabricator.wikimedia.org/T279034 (AndyRussG) >>! In T279034#6966131, @Jseddon wrote: > From your description: on pageview... [18:45:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exceptions for infrequent visitors or as needed” - https://phabricator.wikimedia.org/T279034 (AndyRussG) [18:45:44] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exceptions for infrequent visitors or as needed” - https://phabricator.wikimedia.org/T279034 (AndyRussG) OK, I updated the task title to reflect that the exception mig... [18:47:49] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [18:52:51] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exceptions for infrequent visitors or as needed” - https://phabricator.wikimedia.org/T279034 (AndyRussG) [18:59:58] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [19:13:37] (PS2) Ejegg: Fix fishing net error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/672582 (https://phabricator.wikimedia.org/T277338) (owner: Eileen) [19:13:44] (CR) Ejegg: [C: +2] Fix fishing net error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/672582 (https://phabricator.wikimedia.org/T277338) (owner: Eileen) [19:29:24] (Merged) jenkins-bot: Fix fishing net error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/672582 (https://phabricator.wikimedia.org/T277338) (owner: Eileen) [19:51:03] Fundraising-Backlog, fundraising-tech-ops: Shut down the new style fundraising kafakatee collection in codfw - https://phabricator.wikimedia.org/T279097 (Dwisehaupt) [20:37:30] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising-Backlog, FR-AutoTY-Email: Production of New Annual Fund Thank You Email (due to ED transition) - https://phabricator.wikimedia.org/T278363 (CDenes_WMF) Thank you Christine! I organized proofing of a few... [20:46:56] Fundraising Sprint File Systems Stage Show, Fundraising Sprint Git Rebase Jump, Fundraising-Backlog, FR-AutoTY-Email: Production of New Annual Fund Thank You Email (due to ED transition) - https://phabricator.wikimedia.org/T278363 (CDenes_WMF) One edit to the English version: > There's a typo... [20:47:04] fundraising-tech-ops: Enable GTID for payments-wiki mariadb - https://phabricator.wikimedia.org/T277710 (Dwisehaupt) Open→Resolved a:Dwisehaupt This is complete. All hosts using GTID for replication. [20:51:30] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) [20:52:50] fundraising-tech-ops: enable SSL database connection for fundraising superset - https://phabricator.wikimedia.org/T279058 (Jgreen) Open→Resolved [20:52:52] fundraising-tech-ops, Patch-For-Review: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (Jgreen) [21:11:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Impression weirdness in 2020-12-07 en6C desktop large test - https://phabricator.wikimedia.org/T278834 (Pcoombe) I did a search for any banners from the 6C campaigns where the test banner and the control banner had a pgehres impression count differ... [21:12:07] (PS1) Ejegg: Fix a couple of undefined var errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676472 [21:12:09] (PS1) Ejegg: Get rid of card_type [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676473 [21:14:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Impression weirdness in 2020-12-07 en6C desktop large test - https://phabricator.wikimedia.org/T278834 (RMurthy) Sorry I'm late here @DStrine -- I think we had been talking about portal? I don't recall this particular issue, and it sounds like Pet... [21:15:00] (CR) jerkins-bot: [V: -1] Get rid of card_type [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676473 (owner: Ejegg) [21:21:30] (PS2) Ejegg: Get rid of card_type [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676473 [21:21:32] (PS1) Ejegg: Eliminate a couple redundant if conditions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676475 [21:24:10] (CR) jerkins-bot: [V: -1] Get rid of card_type [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676473 (owner: Ejegg) [21:24:31] (CR) jerkins-bot: [V: -1] Eliminate a couple redundant if conditions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676475 (owner: Ejegg) [21:33:11] (PS3) Ejegg: Get rid of card_type [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676473 [21:33:13] (PS2) Ejegg: Eliminate a couple redundant if conditions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/676475 [22:15:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice code to fix the banner bump with “ESI and pageview+1 with possible exceptions for infrequent visitors or as needed” - https://phabricator.wikimedia.org/T279034 (AndyRussG) [22:54:58] (PS1) Ejegg: Clean up some unused imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/676483